Re: [PATCH v6 17/29] fpga: dfl: fme: add partial reconfiguration sub feature support

2018-06-13 Thread Moritz Fischer
Hi, quick question for Alan inline below. On Tue, Jun 12, 2018 at 06:10:31PM +0800, Wu Hao wrote: > From: Kang Luwei > > Partial Reconfiguration (PR) is the most important function for FME. It > allows reconfiguration for given Port/Accelerated Function Unit (AFU). > > It creates platform

Re: [PATCH v6 17/29] fpga: dfl: fme: add partial reconfiguration sub feature support

2018-06-13 Thread Moritz Fischer
Hi, quick question for Alan inline below. On Tue, Jun 12, 2018 at 06:10:31PM +0800, Wu Hao wrote: > From: Kang Luwei > > Partial Reconfiguration (PR) is the most important function for FME. It > allows reconfiguration for given Port/Accelerated Function Unit (AFU). > > It creates platform

Re: [PATCH v6 19/29] fpga: dfl: fme-mgr: add compat_id support

2018-06-13 Thread Moritz Fischer
: Alan Tull Acked-by: Moritz Fischer > --- > v6: add Acked-by from Alan. > --- > drivers/fpga/dfl-fme-mgr.c | 15 +++ > 1 file changed, 15 insertions(+) > > diff --git a/drivers/fpga/dfl-fme-mgr.c b/drivers/fpga/dfl-fme-mgr.c > index be0060a..691761f 100644

Re: [PATCH v6 19/29] fpga: dfl: fme-mgr: add compat_id support

2018-06-13 Thread Moritz Fischer
: Alan Tull Acked-by: Moritz Fischer > --- > v6: add Acked-by from Alan. > --- > drivers/fpga/dfl-fme-mgr.c | 15 +++ > 1 file changed, 15 insertions(+) > > diff --git a/drivers/fpga/dfl-fme-mgr.c b/drivers/fpga/dfl-fme-mgr.c > index be0060a..691761f 100644

Re: [PATCH v6 05/29] fpga: region: add compat_id support

2018-06-13 Thread Moritz Fischer
ther actions on this fpga-region (e.g PR). > > Signed-off-by: Wu Hao > Acked-by: Alan Tull Acked-by: Moritz Fischer > --- > v5: use pointer for compat_id as it's optional to implement. > v6: add Acked-by from Alan. > --- > Documentation/ABI/testing/sysfs-class-fpga-region

Re: [PATCH v6 05/29] fpga: region: add compat_id support

2018-06-13 Thread Moritz Fischer
ther actions on this fpga-region (e.g PR). > > Signed-off-by: Wu Hao > Acked-by: Alan Tull Acked-by: Moritz Fischer > --- > v5: use pointer for compat_id as it's optional to implement. > v6: add Acked-by from Alan. > --- > Documentation/ABI/testing/sysfs-class-fpga-region

Re: [PATCH v6 22/29] fpga: dfl: fme-region: add support for compat_id

2018-06-13 Thread Moritz Fischer
On Tue, Jun 12, 2018 at 06:10:36PM +0800, Wu Hao wrote: > This patch adds compat_id support, it reuses fme manager's > compat id, as the per region compat id is actually from the > fme manager's register. > > Signed-off-by: Wu Hao > Acked-by: Alan Tull Acked-by: Moritz F

Re: [PATCH v6 22/29] fpga: dfl: fme-region: add support for compat_id

2018-06-13 Thread Moritz Fischer
On Tue, Jun 12, 2018 at 06:10:36PM +0800, Wu Hao wrote: > This patch adds compat_id support, it reuses fme manager's > compat id, as the per region compat id is actually from the > fme manager's register. > > Signed-off-by: Wu Hao > Acked-by: Alan Tull Acked-by: Moritz F

Re: [PATCH v6 14/29] fpga: dfl: add FPGA Management Engine driver basic framework

2018-06-13 Thread Moritz Fischer
ioctl. It also registers the file operations for the device file. > > Signed-off-by: Tim Whisonant > Signed-off-by: Enno Luebbers > Signed-off-by: Shiva Rao > Signed-off-by: Christopher Rauer > Signed-off-by: Kang Luwei > Signed-off-by: Xiao Guangrong > Signed-off-by

Re: [PATCH v6 14/29] fpga: dfl: add FPGA Management Engine driver basic framework

2018-06-13 Thread Moritz Fischer
ioctl. It also registers the file operations for the device file. > > Signed-off-by: Tim Whisonant > Signed-off-by: Enno Luebbers > Signed-off-by: Shiva Rao > Signed-off-by: Christopher Rauer > Signed-off-by: Kang Luwei > Signed-off-by: Xiao Guangrong > Signed-off-by

Re: [PATCH v6 12/29] fpga: add FPGA DFL PCIe device driver

2018-06-13 Thread Moritz Fischer
her Rauer > Signed-off-by: Zhang Yi > Signed-off-by: Xiao Guangrong > Signed-off-by: Wu Hao > Acked-by: Alan Tull > Acked-by: Moritz Fischer > --- > v2: move the code to drivers/fpga folder as suggested by Alan Tull. > switch to GPLv2 license. > fix

Re: [PATCH v6 12/29] fpga: add FPGA DFL PCIe device driver

2018-06-13 Thread Moritz Fischer
her Rauer > Signed-off-by: Zhang Yi > Signed-off-by: Xiao Guangrong > Signed-off-by: Wu Hao > Acked-by: Alan Tull > Acked-by: Moritz Fischer > --- > v2: move the code to drivers/fpga folder as suggested by Alan Tull. > switch to GPLv2 license. > fix

Re: [PATCH v6 29/29] MAINTAINERS: add entry for FPGA DFL drivers

2018-06-13 Thread Moritz Fischer
On Tue, Jun 12, 2018 at 06:10:43PM +0800, Wu Hao wrote: > Add entry for FPGA Device Feature List (DFL) drivers. > > Signed-off-by: Wu Hao Acked-by: Moritz Fischer > --- > MAINTAINERS | 8 > 1 file changed, 8 insertions(+) > > diff --git a/MAINTAINERS b/MAI

Re: [PATCH v6 29/29] MAINTAINERS: add entry for FPGA DFL drivers

2018-06-13 Thread Moritz Fischer
On Tue, Jun 12, 2018 at 06:10:43PM +0800, Wu Hao wrote: > Add entry for FPGA Device Feature List (DFL) drivers. > > Signed-off-by: Wu Hao Acked-by: Moritz Fischer > --- > MAINTAINERS | 8 > 1 file changed, 8 insertions(+) > > diff --git a/MAINTAINERS b/MAI

Re: [PATCH] fpga: altera-cvp: Fix an error handling path in 'altera_cvp_probe()'

2018-06-13 Thread Moritz Fischer
rvdata") > Signed-off-by: Christophe JAILLET Reviewed-by: Moritz Fischer > --- > drivers/fpga/altera-cvp.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/fpga/altera-cvp.c b/drivers/fpga/altera-cvp.c > index dd4edd8f22ce..7fa793672a

Re: [PATCH] fpga: altera-cvp: Fix an error handling path in 'altera_cvp_probe()'

2018-06-13 Thread Moritz Fischer
rvdata") > Signed-off-by: Christophe JAILLET Reviewed-by: Moritz Fischer > --- > drivers/fpga/altera-cvp.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/fpga/altera-cvp.c b/drivers/fpga/altera-cvp.c > index dd4edd8f22ce..7fa793672a

Re: [PATCH 08/14] fpga: region: kernel-doc fixes

2018-05-24 Thread Moritz Fischer
On Wed, May 16, 2018 at 06:50:01PM -0500, Alan Tull wrote: > Fix formatting and some cleanup for the kernel-doc documentation in > fpga-region.c > > Signed-off-by: Alan Tull <at...@kernel.org> Acked-by: Moritz Fischer <m...@kernel.org> > --- > drivers/fpga/fpga-

Re: [PATCH 08/14] fpga: region: kernel-doc fixes

2018-05-24 Thread Moritz Fischer
On Wed, May 16, 2018 at 06:50:01PM -0500, Alan Tull wrote: > Fix formatting and some cleanup for the kernel-doc documentation in > fpga-region.c > > Signed-off-by: Alan Tull Acked-by: Moritz Fischer > --- > drivers/fpga/fpga-region.c | 7 +-- > 1 file changed, 5 inser

Re: [PATCH 07/14] fpga: bridge: kernel-doc fixes

2018-05-24 Thread Moritz Fischer
ing: no structured comments found > > Signed-off-by: Alan Tull <at...@kernel.org> Acked-by: Moritz Fischer <m...@kernel.org> > --- > drivers/fpga/fpga-bridge.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/fpga/fpga-bridge.c b/drivers

Re: [PATCH 07/14] fpga: bridge: kernel-doc fixes

2018-05-24 Thread Moritz Fischer
ing: no structured comments found > > Signed-off-by: Alan Tull Acked-by: Moritz Fischer > --- > drivers/fpga/fpga-bridge.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/fpga/fpga-bridge.c b/drivers/fpga/fpga-bridge.c > index 164eb55..4b207a7 100644

Re: [PATCH 06/14] fpga: mgr: kernel-doc fixes

2018-05-24 Thread Moritz Fischer
ga_mgr_buf_load' > > ./drivers/fpga/fpga-mgr.c:252: warning: Excess function parameter > 'flags' description in 'fpga_mgr_buf_load' > > Signed-off-by: Alan Tull <at...@kernel.org> Acked-by: Moritz Fischer <m...@kernel.org> > --- > drivers/fpga/fpga-mgr.c | 38

Re: [PATCH 06/14] fpga: mgr: kernel-doc fixes

2018-05-24 Thread Moritz Fischer
ga_mgr_buf_load' > > ./drivers/fpga/fpga-mgr.c:252: warning: Excess function parameter > 'flags' description in 'fpga_mgr_buf_load' > > Signed-off-by: Alan Tull Acked-by: Moritz Fischer > --- > drivers/fpga/fpga-mgr.c | 38 +- > 1 file

Re: [PATCHv5 2/8] arm64: dts: stratix10: add stratix10 service driver binding to base dtsi

2018-05-24 Thread Moritz Fischer
y: Alan Tull <at...@kernel.org> Acked-by: Moritz Fischer <m...@kernel.org> > --- > v2: Change to put service layer driver node under the firmware node > Change compatible to "intel, stratix10-svc" > v3: No change > v4: s/service driver/stratix10 service d

Re: [PATCHv5 2/8] arm64: dts: stratix10: add stratix10 service driver binding to base dtsi

2018-05-24 Thread Moritz Fischer
Hi Richard, On Thu, May 24, 2018 at 11:33:14AM -0500, richard.g...@linux.intel.com wrote: > From: Richard Gong > > Add Intel Stratix10 service layer to the device tree > > Signed-off-by: Richard Gong > Signed-off-by: Alan Tull Acked-by: Moritz Fischer > --- > v2: Cha

Re: [PATCHv5 1/8] dt-bindings, firmware: add Intel Stratix10 service layer binding

2018-05-24 Thread Moritz Fischer
> Signed-off-by: Alan Tull <at...@kernel.org> > Reviewed-by: Rob Herring <r...@kernel.org> Acked-by: Moritz Fischer <m...@kernel.org> > --- > v2: Change to put service layer driver node under the firmware node > Change compatible to "intel, stratix10

Re: [PATCHv5 1/8] dt-bindings, firmware: add Intel Stratix10 service layer binding

2018-05-24 Thread Moritz Fischer
On Thu, May 24, 2018 at 11:33:13AM -0500, richard.g...@linux.intel.com wrote: > From: Richard Gong > > Add a device tree binding for the Intel Stratix10 service layer driver > > Signed-off-by: Richard Gong > Signed-off-by: Alan Tull > Reviewed-by: Rob Herring Ack

[PATCH 1/2] net: nixge: Fix error path for obtaining mac address

2018-05-04 Thread Moritz Fischer
. Fixes commit 492caffa8a1a ("net: ethernet: nixge: Add support for National Instruments XGE netdev") Reported-by: Alex Williams <alex.willi...@ni.com> Signed-off-by: Moritz Fischer <m...@kernel.org> --- drivers/net/ethernet/ni/nixge.c | 8 +--- 1 file changed, 5 inse

[PATCH 1/2] net: nixge: Fix error path for obtaining mac address

2018-05-04 Thread Moritz Fischer
. Fixes commit 492caffa8a1a ("net: ethernet: nixge: Add support for National Instruments XGE netdev") Reported-by: Alex Williams Signed-off-by: Moritz Fischer --- drivers/net/ethernet/ni/nixge.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/net/e

[PATCH 2/2] net: nixge: Address compiler warnings about signedness

2018-05-04 Thread Moritz Fischer
r, mac_addr); ^~~~ expected ‘const u8 * {aka const unsigned char *}’ but argument is of type ‘const char *’ static inline void ether_addr_copy(u8 *dst, const u8 *src) Signed-off-by: Moritz Fischer <m...@kernel.org> --- drivers/net/ethernet/ni/nixge.c | 2 +- 1 file changed,

[PATCH 2/2] net: nixge: Address compiler warnings about signedness

2018-05-04 Thread Moritz Fischer
r, mac_addr); ^~~~ expected ‘const u8 * {aka const unsigned char *}’ but argument is of type ‘const char *’ static inline void ether_addr_copy(u8 *dst, const u8 *src) Signed-off-by: Moritz Fischer --- drivers/net/ethernet/ni/nixge.c | 2 +- 1 file changed, 1 insertion(+), 1 deleti

[PATCH v3] dmaengine: axi-dmac: Request IRQ with IRQF_SHARED

2018-04-28 Thread Moritz Fischer
ed-off-by: Moritz Fischer <m...@kernel.org> --- Changes from v2: - Reworded commit message Changes from v1: - Added Lars' Acked-by - Dropped patch [1/2] and changed accordingly --- drivers/dma/dma-axi-dmac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma/dma-

[PATCH v3] dmaengine: axi-dmac: Request IRQ with IRQF_SHARED

2018-04-28 Thread Moritz Fischer
Request IRQ with IRQF_SHARED flag to enable setups with multiple instances of the core sharing a single IRQ line. This works out since the IRQ handler already checks if there is an actual IRQ pending and returns IRQ_NONE otherwise. Acked-by: Lars-Peter Clausen Signed-off-by: Moritz Fischer

Re: [PATCH v2] dmaengine: axi-dmac: Request IRQ with IRQF_SHARED

2018-04-28 Thread Moritz Fischer
On Sat, Apr 28, 2018 at 10:40:43AM +0530, Vinod Koul wrote: > On Fri, Apr 27, 2018 at 05:18:29PM +0200, Lars-Peter Clausen wrote: > > On 04/27/2018 05:15 PM, Moritz Fischer wrote: > > > Hi Vinod, > > > > > > On Fri, Apr 27, 2018 at 12:08 AM, Vinod Koul <vin

Re: [PATCH v2] dmaengine: axi-dmac: Request IRQ with IRQF_SHARED

2018-04-28 Thread Moritz Fischer
On Sat, Apr 28, 2018 at 10:40:43AM +0530, Vinod Koul wrote: > On Fri, Apr 27, 2018 at 05:18:29PM +0200, Lars-Peter Clausen wrote: > > On 04/27/2018 05:15 PM, Moritz Fischer wrote: > > > Hi Vinod, > > > > > > On Fri, Apr 27, 2018 at 12:08 AM, Vinod Koul wrote:

Re: [PATCH v2] dmaengine: axi-dmac: Request IRQ with IRQF_SHARED

2018-04-27 Thread Moritz Fischer
Hi Vinod, On Fri, Apr 27, 2018 at 12:08 AM, Vinod Koul <vinod.k...@intel.com> wrote: > On Fri, Apr 27, 2018 at 08:53:39AM +0200, Lars-Peter Clausen wrote: >> On 04/27/2018 07:11 AM, Vinod Koul wrote: >> > On Thu, Apr 26, 2018 at 10:40:00AM -0700, Moritz Fischer

Re: [PATCH v2] dmaengine: axi-dmac: Request IRQ with IRQF_SHARED

2018-04-27 Thread Moritz Fischer
Hi Vinod, On Fri, Apr 27, 2018 at 12:08 AM, Vinod Koul wrote: > On Fri, Apr 27, 2018 at 08:53:39AM +0200, Lars-Peter Clausen wrote: >> On 04/27/2018 07:11 AM, Vinod Koul wrote: >> > On Thu, Apr 26, 2018 at 10:40:00AM -0700, Moritz Fischer wrote: >> >> Req

[PATCH 0/4] FPGA Manager Patches for 4.18

2018-04-26 Thread Moritz Fischer
Hi Greg, Here's Alan's reworked patchset changing the API for creating and registering FPGA Managers, Bridges and Regions following your suggestions on the API. These go on top of Paolo and Alan's patches that you queued up the other day. Thanks, Moritz Alan Tull (4): fpga: region: don't

[PATCH 0/4] FPGA Manager Patches for 4.18

2018-04-26 Thread Moritz Fischer
Hi Greg, Here's Alan's reworked patchset changing the API for creating and registering FPGA Managers, Bridges and Regions following your suggestions on the API. These go on top of Paolo and Alan's patches that you queued up the other day. Thanks, Moritz Alan Tull (4): fpga: region: don't

[PATCH 1/4] fpga: region: don't use drvdata in common fpga code

2018-04-26 Thread Moritz Fischer
hanges, the PCIe solution has to create an extra device for each child region to hold drvdata. Signed-off-by: Alan Tull <at...@kernel.org> Reported-by: Jiuyue Ma <majiu...@huawei.com> Signed-off-by: Moritz Fischer <m...@kernel.org> --- drivers/fpga/fpga-region.c| 1 - drivers/f

[PATCH 1/4] fpga: region: don't use drvdata in common fpga code

2018-04-26 Thread Moritz Fischer
has to create an extra device for each child region to hold drvdata. Signed-off-by: Alan Tull Reported-by: Jiuyue Ma Signed-off-by: Moritz Fischer --- drivers/fpga/fpga-region.c| 1 - drivers/fpga/of-fpga-region.c | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH 4/4] fpga: region: change api, add fpga_region_create/free

2018-04-26 Thread Moritz Fischer
region, it's not needed. Callers can just "region->dev.groups = groups;" after calling fpga_region_create. Update the drivers that call fpga_region_register with the new API. Signed-off-by: Alan Tull <at...@kernel.org> Signed-off-by: Moritz Fischer <m...@kernel.org&g

[PATCH 4/4] fpga: region: change api, add fpga_region_create/free

2018-04-26 Thread Moritz Fischer
. Callers can just "region->dev.groups = groups;" after calling fpga_region_create. Update the drivers that call fpga_region_register with the new API. Signed-off-by: Alan Tull Signed-off-by: Moritz Fischer --- Documentation/fpga/fpga-region.txt | 3 +- drivers/fpga/fpga-region.c

[PATCH 2/4] fpga: manager: change api, don't use drvdata

2018-04-26 Thread Moritz Fischer
void fpga_mgr_unregister(struct fpga_manager *mgr); Update the drivers that call fpga_mgr_register with the new API. Signed-off-by: Alan Tull <at...@kernel.org> [Moritz: Fixup whitespace issue] Reported-by: Jiuyue Ma <majiu...@huawei.com> Signed-off-by: Moritz Fischer <m...@kernel.org> ---

[PATCH 3/4] fpga: bridge: change api, don't use drvdata

2018-04-26 Thread Moritz Fischer
void fpga_bridge_unregister(struct fpga_bridge *br); Update the drivers that call fpga_bridge_register with the new API. Signed-off-by: Alan Tull <at...@kernel.org> Reported-by: Jiuyue Ma <majiu...@huawei.com> Signed-off-by: Moritz Fischer <m...@kernel.org> --- drivers/fpga/alt

[PATCH 2/4] fpga: manager: change api, don't use drvdata

2018-04-26 Thread Moritz Fischer
fpga_manager *mgr); Update the drivers that call fpga_mgr_register with the new API. Signed-off-by: Alan Tull [Moritz: Fixup whitespace issue] Reported-by: Jiuyue Ma Signed-off-by: Moritz Fischer --- Documentation/fpga/fpga-mgr.txt | 35 ++ drivers/fpga/altera-cvp.c| 19

[PATCH 3/4] fpga: bridge: change api, don't use drvdata

2018-04-26 Thread Moritz Fischer
fpga_bridge_unregister(struct fpga_bridge *br); Update the drivers that call fpga_bridge_register with the new API. Signed-off-by: Alan Tull Reported-by: Jiuyue Ma Signed-off-by: Moritz Fischer --- drivers/fpga/altera-fpga2sdram.c| 21 ++--- drivers/fpga/altera-freeze-bridge.c | 22 +++-- drivers/fpga

Re: [RFC/PATCH] net: ethernet: nixge: Use of_get_mac_address()

2018-04-26 Thread Moritz Fischer
On Thu, Apr 26, 2018 at 02:57:42PM -0700, Moritz Fischer wrote: > Make nixge driver work with 'mac-address' property instead of > 'address' property. There are currently no in-tree users and > the only users of this driver are devices that use overlays > we control to instantiat

Re: [RFC/PATCH] net: ethernet: nixge: Use of_get_mac_address()

2018-04-26 Thread Moritz Fischer
On Thu, Apr 26, 2018 at 02:57:42PM -0700, Moritz Fischer wrote: > Make nixge driver work with 'mac-address' property instead of > 'address' property. There are currently no in-tree users and > the only users of this driver are devices that use overlays > we control to instantiat

[RFC/PATCH] net: ethernet: nixge: Use of_get_mac_address()

2018-04-26 Thread Moritz Fischer
Make nixge driver work with 'mac-address' property instead of 'address' property. There are currently no in-tree users and the only users of this driver are devices that use overlays we control to instantiate the device together with the corresponding FPGA images. Signed-off-by: Moritz Fischer &l

[RFC/PATCH] net: ethernet: nixge: Use of_get_mac_address()

2018-04-26 Thread Moritz Fischer
Make nixge driver work with 'mac-address' property instead of 'address' property. There are currently no in-tree users and the only users of this driver are devices that use overlays we control to instantiate the device together with the corresponding FPGA images. Signed-off-by: Moritz Fischer

[PATCH v2] dmaengine: axi-dmac: Request IRQ with IRQF_SHARED

2018-04-26 Thread Moritz Fischer
Request IRQ with IRQF_SHARED flag. This works since the interrupt handler already checks if there is an actual IRQ pending and returns IRQ_NONE otherwise. Acked-by: Lars-Peter Clausen <l...@metafoo.de> Signed-off-by: Moritz Fischer <m...@kernel.org> --- Changes from v1: - Added

[PATCH v2] dmaengine: axi-dmac: Request IRQ with IRQF_SHARED

2018-04-26 Thread Moritz Fischer
Request IRQ with IRQF_SHARED flag. This works since the interrupt handler already checks if there is an actual IRQ pending and returns IRQ_NONE otherwise. Acked-by: Lars-Peter Clausen Signed-off-by: Moritz Fischer --- Changes from v1: - Added Lars' Acked-by - Dropped patch [1/2] and changed

Re: [PATCH 1/2] dmaengine: axi-dmac: Use devm_request_irq()

2018-04-26 Thread Moritz Fischer
Hi Lars, On Thu, Apr 26, 2018 at 9:26 AM, Lars-Peter Clausen <l...@metafoo.de> wrote: > On 04/26/2018 06:12 PM, Moritz Fischer wrote: >> Use devm_request_irq() instead of request_irq() to request the IRQ. >> >> Signed-off-by: Moritz Fischer <m...@ke

Re: [PATCH 1/2] dmaengine: axi-dmac: Use devm_request_irq()

2018-04-26 Thread Moritz Fischer
Hi Lars, On Thu, Apr 26, 2018 at 9:26 AM, Lars-Peter Clausen wrote: > On 04/26/2018 06:12 PM, Moritz Fischer wrote: >> Use devm_request_irq() instead of request_irq() to request the IRQ. >> >> Signed-off-by: Moritz Fischer >> --- >> >> Hi Lars, >&

[PATCH 2/2] dmaengine: axi-dmac: Request IRQ with IRQF_SHARED

2018-04-26 Thread Moritz Fischer
Request IRQ with IRQF_SHARED flag. This works since the interrupt handler already checks if there is an actual IRQ pending and returns IRQ_NONE otherwise. Signed-off-by: Moritz Fischer <m...@kernel.org> --- drivers/dma/dma-axi-dmac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH 1/2] dmaengine: axi-dmac: Use devm_request_irq()

2018-04-26 Thread Moritz Fischer
Use devm_request_irq() instead of request_irq() to request the IRQ. Signed-off-by: Moritz Fischer <m...@kernel.org> --- Hi Lars, was there a specific reason not to use devm_request_irq() ? Cheers, Moritz --- drivers/dma/dma-axi-dmac.c | 6 +++--- 1 file changed, 3 insertions(+), 3 del

[PATCH 2/2] dmaengine: axi-dmac: Request IRQ with IRQF_SHARED

2018-04-26 Thread Moritz Fischer
Request IRQ with IRQF_SHARED flag. This works since the interrupt handler already checks if there is an actual IRQ pending and returns IRQ_NONE otherwise. Signed-off-by: Moritz Fischer --- drivers/dma/dma-axi-dmac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma

[PATCH 1/2] dmaengine: axi-dmac: Use devm_request_irq()

2018-04-26 Thread Moritz Fischer
Use devm_request_irq() instead of request_irq() to request the IRQ. Signed-off-by: Moritz Fischer --- Hi Lars, was there a specific reason not to use devm_request_irq() ? Cheers, Moritz --- drivers/dma/dma-axi-dmac.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH 0/3] FPGA Manager Patches for 4.18

2018-04-16 Thread Moritz Fischer
Hi Greg, Please queue the following patches for v4.18. Alan's Patch clarifies the locking in the fpga-region code. Paolo's patches add a new driver with corresponding bindings for a Lattice FPGA part. Thanks, Moritz Alan Tull (1): fpga: fpga-region: comment on fpga_region_program_fpga

[PATCH 0/3] FPGA Manager Patches for 4.18

2018-04-16 Thread Moritz Fischer
Hi Greg, Please queue the following patches for v4.18. Alan's Patch clarifies the locking in the fpga-region code. Paolo's patches add a new driver with corresponding bindings for a Lattice FPGA part. Thanks, Moritz Alan Tull (1): fpga: fpga-region: comment on fpga_region_program_fpga

[PATCH 2/3] fpga: lattice machxo2: Add Lattice MachXO2 support

2018-04-16 Thread Moritz Fischer
t...@kernel.org> Signed-off-by: Moritz Fischer <m...@kernel.org> --- drivers/fpga/Kconfig | 7 + drivers/fpga/Makefile | 1 + drivers/fpga/machxo2-spi.c | 403 + 3 files changed, 411 insertions(+) create mode 100644 drivers/fpga/machxo2-spi

[PATCH 2/3] fpga: lattice machxo2: Add Lattice MachXO2 support

2018-04-16 Thread Moritz Fischer
From: Paolo Pisati This patch adds support to the FPGA manager for programming MachXO2 device’s internal flash memory, via slave SPI. Signed-off-by: Paolo Pisati [at...@kernel.org: use existing FPGA mgr API] Signed-off-by: Alan Tull Signed-off-by: Moritz Fischer --- drivers/fpga/Kconfig

[PATCH 1/3] dt: bindings: fpga: add lattice machxo2 slave spi binding description

2018-04-16 Thread Moritz Fischer
From: Paolo Pisati <p.pis...@gmail.com> Add dt binding documentation details for Lattice MachXO2 FPGA configuration over Slave SPI interface. Signed-off-by: Paolo Pisati <p.pis...@gmail.com> Acked-by: Rob Herring <r...@kernel.org> Acked-by: Alan Tull <at...@kernel.org&g

[PATCH 3/3] fpga: fpga-region: comment on fpga_region_program_fpga locking

2018-04-16 Thread Moritz Fischer
From: Alan Tull <at...@kernel.org> Add a comment to the header of fpga_region_program_fpga() regarding locking of the bridges. Signed-off-by: Alan Tull <at...@kernel.org> Signed-off-by: Moritz Fischer <m...@kernel.org> --- drivers/fpga/fpga-region.c | 5 + 1 file cha

[PATCH 1/3] dt: bindings: fpga: add lattice machxo2 slave spi binding description

2018-04-16 Thread Moritz Fischer
From: Paolo Pisati Add dt binding documentation details for Lattice MachXO2 FPGA configuration over Slave SPI interface. Signed-off-by: Paolo Pisati Acked-by: Rob Herring Acked-by: Alan Tull Signed-off-by: Moritz Fischer --- .../bindings/fpga/lattice-machxo2-spi.txt | 29

[PATCH 3/3] fpga: fpga-region: comment on fpga_region_program_fpga locking

2018-04-16 Thread Moritz Fischer
From: Alan Tull Add a comment to the header of fpga_region_program_fpga() regarding locking of the bridges. Signed-off-by: Alan Tull Signed-off-by: Moritz Fischer --- drivers/fpga/fpga-region.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/fpga/fpga-region.c b/drivers/fpga

[PATCH] fpga-manager: altera-ps-spi: preserve nCONFIG state

2018-04-15 Thread Moritz Fischer
revent this. Signed-off-by: Anatolij Gustschin <ag...@denx.de> Acked-by: Alan Tull <at...@kernel.org> Signed-off-by: Moritz Fischer <m...@kernel.org> --- Hi Greg, as discussed. Can you please take this bugfix for 4.17? I rebased it against next. Thanks, Moritz PS: Sorry for late

[PATCH] fpga-manager: altera-ps-spi: preserve nCONFIG state

2018-04-15 Thread Moritz Fischer
-by: Anatolij Gustschin Acked-by: Alan Tull Signed-off-by: Moritz Fischer --- Hi Greg, as discussed. Can you please take this bugfix for 4.17? I rebased it against next. Thanks, Moritz PS: Sorry for late submission --- drivers/fpga/altera-ps-spi.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH 4/6] fpga: region: change fpga_region_register to have one param

2018-03-29 Thread Moritz Fischer
On Thu, Mar 29, 2018 at 03:42:51PM -0500, Alan Tull wrote: > On Thu, Mar 29, 2018 at 12:06 PM, Greg KH wrote: > > Hi Greg, > > >> -int fpga_region_register(struct device *dev, struct fpga_region *region) > >> +int fpga_region_register(struct fpga_region *region) > >>

Re: [PATCH 4/6] fpga: region: change fpga_region_register to have one param

2018-03-29 Thread Moritz Fischer
On Thu, Mar 29, 2018 at 03:42:51PM -0500, Alan Tull wrote: > On Thu, Mar 29, 2018 at 12:06 PM, Greg KH wrote: > > Hi Greg, > > >> -int fpga_region_register(struct device *dev, struct fpga_region *region) > >> +int fpga_region_register(struct fpga_region *region) > >> { > >> + struct device

[PATCH 0/6] FPGA Manager Patches for 4.17

2018-03-29 Thread Moritz Fischer
Hi Greg, can you please take the following patches for 4.17. Alan's changes are mostly refactoring in preparation for non-dt based FPGA regions. Anatolij's changes fix a small issue with altera-ps-spi FPGAs, where the FPGA is being reset unnessesarily on driver load. All patches have been

[PATCH 0/6] FPGA Manager Patches for 4.17

2018-03-29 Thread Moritz Fischer
Hi Greg, can you please take the following patches for 4.17. Alan's changes are mostly refactoring in preparation for non-dt based FPGA regions. Anatolij's changes fix a small issue with altera-ps-spi FPGAs, where the FPGA is being reset unnessesarily on driver load. All patches have been

[PATCH 1/6] fpga: region: don't use drvdata in common fpga code

2018-03-29 Thread Moritz Fischer
gt; Reported-by: Jiuyue Ma <majiu...@huawei.com> Signed-off-by: Moritz Fischer <m...@kernel.org> --- drivers/fpga/fpga-region.c| 1 - drivers/fpga/of-fpga-region.c | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/fpga/fpga-region.c b/drivers/fpga/fpga-reg

[PATCH 1/6] fpga: region: don't use drvdata in common fpga code

2018-03-29 Thread Moritz Fischer
platform device. However PCIe based devices may have multiple FPGA mgr/bridge/regions under one PCIe device. Without these changes, the PCIe solution has to create an extra device for each child mgr/bridge/region to hold drvdata. Signed-off-by: Alan Tull Reported-by: Jiuyue Ma Signed-off-by: Moritz

[PATCH 3/6] fpga: bridge: don't use drvdata in common fpga code

2018-03-29 Thread Moritz Fischer
com> Signed-off-by: Moritz Fischer <m...@kernel.org> --- drivers/fpga/altera-fpga2sdram.c| 20 + drivers/fpga/altera-freeze-bridge.c | 18 +--- drivers/fpga/altera-hps2fpga.c | 16 +++--- drivers/fpga/fpg

[PATCH 3/6] fpga: bridge: don't use drvdata in common fpga code

2018-03-29 Thread Moritz Fischer
multiple FPGA mgr/bridge/regions under one pcie device. Without these changes, the PCIe solution has to create an extra device for each child mgr/bridge/region to hold drvdata. Signed-off-by: Alan Tull Reported-by: Jiuyue Ma Signed-off-by: Moritz Fischer --- drivers/fpga/altera-fpga2sdram.c

[PATCH 2/6] fpga: manager: don't use drvdata in common fpga code

2018-03-29 Thread Moritz Fischer
evices may have multiple FPGA mgr/bridge/regions under one PCIe device. Without these changes, the PCIe solution has to create an extra device for each child mgr/bridge/region to hold drvdata. Signed-off-by: Alan Tull <at...@kernel.org> Reported-by: Jiuyue Ma <majiu...@huawei.com> Sig

[PATCH 2/6] fpga: manager: don't use drvdata in common fpga code

2018-03-29 Thread Moritz Fischer
FPGA mgr/bridge/regions under one PCIe device. Without these changes, the PCIe solution has to create an extra device for each child mgr/bridge/region to hold drvdata. Signed-off-by: Alan Tull Reported-by: Jiuyue Ma Signed-off-by: Moritz Fischer --- Documentation/fpga/fpga-mgr.txt | 24

[PATCH 5/6] fpga: fpga-region: comment on fpga_region_program_fpga locking

2018-03-29 Thread Moritz Fischer
From: Alan Tull <at...@kernel.org> Add a comment to the header of fpga_region_program_fpga() regarding locking of the bridges. Signed-off-by: Alan Tull <at...@kernel.org> Signed-off-by: Moritz Fischer <m...@kernel.org> --- drivers/fpga/fpga-region.c | 5 + 1 file cha

[PATCH 5/6] fpga: fpga-region: comment on fpga_region_program_fpga locking

2018-03-29 Thread Moritz Fischer
From: Alan Tull Add a comment to the header of fpga_region_program_fpga() regarding locking of the bridges. Signed-off-by: Alan Tull Signed-off-by: Moritz Fischer --- drivers/fpga/fpga-region.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/fpga/fpga-region.c b/drivers/fpga

[PATCH 6/6] fpga-manager: altera-ps-spi: preserve nCONFIG state

2018-03-29 Thread Moritz Fischer
revent this. Signed-off-by: Anatolij Gustschin <ag...@denx.de> Signed-off-by: Alan Tull <at...@kernel.org> Signed-off-by: Moritz Fischer <m...@kernel.org> --- drivers/fpga/altera-ps-spi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/fpga/altera-ps-spi.c

[PATCH 6/6] fpga-manager: altera-ps-spi: preserve nCONFIG state

2018-03-29 Thread Moritz Fischer
-by: Anatolij Gustschin Signed-off-by: Alan Tull Signed-off-by: Moritz Fischer --- drivers/fpga/altera-ps-spi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/fpga/altera-ps-spi.c b/drivers/fpga/altera-ps-spi.c index b061408bf0ae..250d9cf9bb1b 100644 --- a/drivers/fpga

[PATCH 4/6] fpga: region: change fpga_region_register to have one param

2018-03-29 Thread Moritz Fischer
t take their respective struct. The one caller of fpga_region_register is changed to alloc the fpga_region struct, fill it in, and pass it to the register function. Signed-off-by: Alan Tull <at...@kernel.org> Signed-off-by: Moritz Fischer <m...@kernel.org> --- Documentation/fpga/fpga-region.txt | 3

[PATCH 4/6] fpga: region: change fpga_region_register to have one param

2018-03-29 Thread Moritz Fischer
. The one caller of fpga_region_register is changed to alloc the fpga_region struct, fill it in, and pass it to the register function. Signed-off-by: Alan Tull Signed-off-by: Moritz Fischer --- Documentation/fpga/fpga-region.txt | 3 +-- drivers/fpga/fpga-region.c | 8 +++- drivers/fpga

[PATCH v6 2/2] net: ethernet: nixge: Add support for National Instruments XGE netdev

2018-03-27 Thread Moritz Fischer
Add support for the National Instruments XGE 1/10G network device. It uses the EEPROM on the board via NVMEM. Signed-off-by: Moritz Fischer <m...@kernel.org> --- Changes from v5: - Fixed up indents according to David's feedback - Fixed KConfig ---help--- -> help Changes from v4:

[PATCH v6 2/2] net: ethernet: nixge: Add support for National Instruments XGE netdev

2018-03-27 Thread Moritz Fischer
Add support for the National Instruments XGE 1/10G network device. It uses the EEPROM on the board via NVMEM. Signed-off-by: Moritz Fischer --- Changes from v5: - Fixed up indents according to David's feedback - Fixed KConfig ---help--- -> help Changes from v4: - Worked on consiste

[PATCH v6 1/2] dt-bindings: net: Add bindings for National Instruments XGE netdev

2018-03-27 Thread Moritz Fischer
This adds bindings for the NI XGE 1G/10G network device. Reviewed-by: Rob Herring <r...@kernel.org> Signed-off-by: Moritz Fischer <m...@kernel.org> --- Changes from v5: - None Changes from v4: - None Changes from v3: - Added Rob's Reviewed-by Changes from v2: - Addressed Rob's co

[PATCH v6 1/2] dt-bindings: net: Add bindings for National Instruments XGE netdev

2018-03-27 Thread Moritz Fischer
This adds bindings for the NI XGE 1G/10G network device. Reviewed-by: Rob Herring Signed-off-by: Moritz Fischer --- Changes from v5: - None Changes from v4: - None Changes from v3: - Added Rob's Reviewed-by Changes from v2: - Addressed Rob's comments w.r.t to IRQ names and typo Changes from

Re: [RESEND PATCH v3 2/4] fpga: manager: don't use drvdata in common fpga code

2018-03-27 Thread Moritz Fischer
; drvdata. > > Signed-off-by: Alan Tull <at...@kernel.org> > Reported-by: Jiuyue Ma <majiu...@huawei.com> Acked-by: Moritz Fischer <m...@kernel.org> > --- > v2: change fpga_mgr_register to not need parent device param > v3: minor changes to make diffs smaller and

Re: [RESEND PATCH v3 2/4] fpga: manager: don't use drvdata in common fpga code

2018-03-27 Thread Moritz Fischer
Signed-off-by: Alan Tull > Reported-by: Jiuyue Ma Acked-by: Moritz Fischer > --- > v2: change fpga_mgr_register to not need parent device param > v3: minor changes to make diffs smaller and more obviously correct > rebased to current next branch > --- > Documentation

Re: [RESEND PATCH v3 3/4] fpga: bridge: don't use drvdata in common fpga code

2018-03-27 Thread Moritz Fischer
region to hold > drvdata. > > Signed-off-by: Alan Tull <at...@kernel.org> > Reported-by: Jiuyue Ma <majiu...@huawei.com> Acked-by: Moritz Fischer <m...@kernel.org> > --- > v2: change fpga_bridge_register to not need parent device param > fix undeclared - s/dev/>

Re: [RESEND PATCH v3 3/4] fpga: bridge: don't use drvdata in common fpga code

2018-03-27 Thread Moritz Fischer
; > Signed-off-by: Alan Tull > Reported-by: Jiuyue Ma Acked-by: Moritz Fischer > --- > v2: change fpga_bridge_register to not need parent device param > fix undeclared - s/dev/>dev/ > v3: minor changes to make diffs smaller and more obviously correct > --- > drivers

Re: [RESEND PATCH v3 4/4] fpga: region: change fpga_region_register to have one param

2018-03-27 Thread Moritz Fischer
lar to fpga_bridge_register and fpga_mgr_register > which also just take their respective struct. > > The one caller of fpga_region_register is changed to alloc the > fpga_region struct, fill it in, and pass it to the register > function. > > Signed-off-by: Alan Tull <at...@ke

Re: [RESEND PATCH v3 4/4] fpga: region: change fpga_region_register to have one param

2018-03-27 Thread Moritz Fischer
fpga_bridge_register and fpga_mgr_register > which also just take their respective struct. > > The one caller of fpga_region_register is changed to alloc the > fpga_region struct, fill it in, and pass it to the register > function. > > Signed-off-by: Alan Tull Acked-by: Moritz Fischer &g

Re: [PATCH v5 2/2] net: ethernet: nixge: Add support for National Instruments XGE netdev

2018-03-26 Thread Moritz Fischer
Hi David, On Mon, Mar 26, 2018 at 11:38:30AM -0400, David Miller wrote: > From: Moritz Fischer <m...@kernel.org> > Date: Fri, 23 Mar 2018 13:41:28 -0700 > > > +static void nixge_hw_dma_bd_release(struct net_device *ndev) > > +{ > > + int i; > > + str

Re: [PATCH v5 2/2] net: ethernet: nixge: Add support for National Instruments XGE netdev

2018-03-26 Thread Moritz Fischer
Hi David, On Mon, Mar 26, 2018 at 11:38:30AM -0400, David Miller wrote: > From: Moritz Fischer > Date: Fri, 23 Mar 2018 13:41:28 -0700 > > > +static void nixge_hw_dma_bd_release(struct net_device *ndev) > > +{ > > + int i; > > + struct nixge_priv *priv = net

[PATCH v5 2/2] net: ethernet: nixge: Add support for National Instruments XGE netdev

2018-03-23 Thread Moritz Fischer
Add support for the National Instruments XGE 1/10G network device. It uses the EEPROM on the board via NVMEM. Signed-off-by: Moritz Fischer <m...@kernel.org> --- Changes from v4: - Worked on consistency for constants - Removed unused constants - Removed unused includes Changes from v3: -

[PATCH v5 2/2] net: ethernet: nixge: Add support for National Instruments XGE netdev

2018-03-23 Thread Moritz Fischer
Add support for the National Instruments XGE 1/10G network device. It uses the EEPROM on the board via NVMEM. Signed-off-by: Moritz Fischer --- Changes from v4: - Worked on consistency for constants - Removed unused constants - Removed unused includes Changes from v3: - Added NIXGE prefix

[PATCH v5 1/2] dt-bindings: net: Add bindings for National Instruments XGE netdev

2018-03-23 Thread Moritz Fischer
This adds bindings for the NI XGE 1G/10G network device. Reviewed-by: Rob Herring <r...@kernel.org> Signed-off-by: Moritz Fischer <m...@kernel.org> --- Changes from v4: - None Changes from v3: - Added Rob's Reviewed-by Changes from v2: - Addressed Rob's comments w.r.t to IRQ na

[PATCH v5 1/2] dt-bindings: net: Add bindings for National Instruments XGE netdev

2018-03-23 Thread Moritz Fischer
This adds bindings for the NI XGE 1G/10G network device. Reviewed-by: Rob Herring Signed-off-by: Moritz Fischer --- Changes from v4: - None Changes from v3: - Added Rob's Reviewed-by Changes from v2: - Addressed Rob's comments w.r.t to IRQ names and typo Changes from v1: - Corrected from

<    1   2   3   4   5   6   7   8   9   10   >