Re: [PATCH v4 16/24] fpga: dfl: add fpga manager platform driver for FME

On Wed, Mar 21, 2018 at 10:50:01AM +0800, Wu Hao wrote: > On Tue, Mar 20, 2018 at 03:32:34PM -0500, Alan Tull wrote: > > On Tue, Feb 13, 2018 at 3:24 AM, Wu Hao wrote: > > > > Hi Hao, > > > > Elsewhere we discussed moving #defines used only in this driver either > > to this .c

Re: [PATCH v4 16/24] fpga: dfl: add fpga manager platform driver for FME

On Wed, Mar 21, 2018 at 10:50:01AM +0800, Wu Hao wrote: > On Tue, Mar 20, 2018 at 03:32:34PM -0500, Alan Tull wrote: > > On Tue, Feb 13, 2018 at 3:24 AM, Wu Hao wrote: > > > > Hi Hao, > > > > Elsewhere we discussed moving #defines used only in this driver either > > to this .c file or to a

Re: [PATCH 1/2] dt: bindings: fpga: add lattice machxo2 slave spi binding description

On Fri, Mar 16, 2018 at 04:54:28PM +0100, Paolo Pisati wrote: > Add dt binding documentation details for Lattice MachXO2 FPGA configuration > over Slave SPI interface. > > Signed-off-by: Paolo Pisati <p.pis...@gmail.com> > Acked-by: Rob Herring <r...@kernel.org>

Re: [PATCH 1/2] dt: bindings: fpga: add lattice machxo2 slave spi binding description

On Fri, Mar 16, 2018 at 04:54:28PM +0100, Paolo Pisati wrote: > Add dt binding documentation details for Lattice MachXO2 FPGA configuration > over Slave SPI interface. > > Signed-off-by: Paolo Pisati > Acked-by: Rob Herring Acked-by: Moritz Fischer > --- > .../bindings

Re: [PATCH 2/2] fpga: lattice machxo2: Add Lattice MachXO2 support

On Fri, Mar 16, 2018 at 04:54:29PM +0100, Paolo Pisati wrote: > This patch adds support to the FPGA manager for programming > MachXO2 device’s internal flash memory, via slave SPI. > > Signed-off-by: Paolo Pisati > --- > drivers/fpga/Kconfig | 8 + >

Re: [PATCH 2/2] fpga: lattice machxo2: Add Lattice MachXO2 support

On Fri, Mar 16, 2018 at 04:54:29PM +0100, Paolo Pisati wrote: > This patch adds support to the FPGA manager for programming > MachXO2 device’s internal flash memory, via slave SPI. > > Signed-off-by: Paolo Pisati > --- > drivers/fpga/Kconfig | 8 + > drivers/fpga/Makefile | 1 + >

Re: [PATCH v4 08/24] fpga: add FPGA DFL PCIe device driver

gt; > Signed-off-by: Wu Hao <hao...@intel.com> with module_pci_driver() fix: Acked-by: Moritz Fischer <m...@kernel.org> > --- > v2: move the code to drivers/fpga folder as suggested by Alan Tull. > switch to GPLv2 license. > fix comments from Moritz Fischer. &

Re: [PATCH v4 08/24] fpga: add FPGA DFL PCIe device driver

topher Rauer > Signed-off-by: Zhang Yi > Signed-off-by: Xiao Guangrong > Signed-off-by: Wu Hao with module_pci_driver() fix: Acked-by: Moritz Fischer > --- > v2: move the code to drivers/fpga folder as suggested by Alan Tull. > switch to GPLv2 license. > fix comme

Re: [PATCH] RISC-V: Rename CONFIG_CMDLINE_OVERRIDE to CONFIG_CMDLINE_FORCE

y removed the > support for CONFIG_CMDLINE_OVERRIDE from our arch-specific code so it > didn't even work any more. > > Thanks to Mortiz and Trung for finding the original bug, and for Michael Nit: s/Mortiz/Moritz/g ;-) > for suggeting a better fix. > > CC: Trung Tran <trung.t...@e

Re: [PATCH] RISC-V: Rename CONFIG_CMDLINE_OVERRIDE to CONFIG_CMDLINE_FORCE

y removed the > support for CONFIG_CMDLINE_OVERRIDE from our arch-specific code so it > didn't even work any more. > > Thanks to Mortiz and Trung for finding the original bug, and for Michael Nit: s/Mortiz/Moritz/g ;-) > for suggeting a better fix. > > CC: Trung Tran > CC: Mori

[RFC/PATCH] risc-v: Fix issue ignoring CONFIG_CMDLINE_OVERRIDE

Fix issue where CONFIG_CMDLINE_OVERRIDE is being ignored. Signed-off-by: Trung Tran <trung.t...@ettus.com> Signed-off-by: Moritz Fischer <m...@kernel.org> --- Hi all, not sure this is the right fix, hopefully someone can chime in and come up with the correct solution. Thanks, Mori

[RFC/PATCH] risc-v: Fix issue ignoring CONFIG_CMDLINE_OVERRIDE

Fix issue where CONFIG_CMDLINE_OVERRIDE is being ignored. Signed-off-by: Trung Tran Signed-off-by: Moritz Fischer --- Hi all, not sure this is the right fix, hopefully someone can chime in and come up with the correct solution. Thanks, Moritz --- arch/riscv/kernel/setup.c | 6 ++ 1

[PATCH] i2c: xiic: Make suspend function names consistent

Suspend functions seem to have been copied from i2c-cadence driver. Rename the functions to match the rest of the driver. Signed-off-by: Moritz Fischer <m...@kernel.org> --- drivers/i2c/busses/i2c-xiic.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drive

[PATCH] i2c: xiic: Make suspend function names consistent

Suspend functions seem to have been copied from i2c-cadence driver. Rename the functions to match the rest of the driver. Signed-off-by: Moritz Fischer --- drivers/i2c/busses/i2c-xiic.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/i2c/busses/i2c-xiic.c b

[RESEND PATCH v4 1/2] dt-bindings: net: Add bindings for National Instruments XGE netdev

This adds bindings for the NI XGE 1G/10G network device. Reviewed-by: Rob Herring <r...@kernel.org> Signed-off-by: Moritz Fischer <m...@kernel.org> --- Changes from v3: - Added Rob's Reviewed-by Changes from v2: - Addressed Rob's comments w.r.t to IRQ names and typo Cha

[RESEND PATCH v4 1/2] dt-bindings: net: Add bindings for National Instruments XGE netdev

This adds bindings for the NI XGE 1G/10G network device. Reviewed-by: Rob Herring Signed-off-by: Moritz Fischer --- Changes from v3: - Added Rob's Reviewed-by Changes from v2: - Addressed Rob's comments w.r.t to IRQ names and typo Changes from v1: - Corrected from nixge -> nixge.

[RESEND PATCH v4 2/2] net: ethernet: nixge: Add support for National Instruments XGE netdev

Add support for the National Instruments XGE 1/10G network device. It uses the EEPROM on the board via NVMEM. Signed-off-by: Moritz Fischer <m...@kernel.org> --- Changes from v3: - Added NIXGE prefix to MDIO constants - Removed NIXGE_MAX_PHY_ADDR (unused) - Consistency for NIXGE_MDIO_CX

[RESEND PATCH v4 2/2] net: ethernet: nixge: Add support for National Instruments XGE netdev

Add support for the National Instruments XGE 1/10G network device. It uses the EEPROM on the board via NVMEM. Signed-off-by: Moritz Fischer --- Changes from v3: - Added NIXGE prefix to MDIO constants - Removed NIXGE_MAX_PHY_ADDR (unused) - Consistency for NIXGE_MDIO_CXX_READ constants - Use

Re: [PATCH net-next 5/5] net: phy: marvell10g: Utilize gen10g_soft_reset()

Florian, On Wed, Feb 28, 2018 at 11:44 AM, Russell King wrote: > On Wed, Feb 28, 2018 at 11:36:12AM -0800, Florian Fainelli wrote: >> We do the same thing as the generic function: nothing, so utilize it. >> >> Signed-off-by: Florian Fainelli >> --- >>

Re: [PATCH net-next 5/5] net: phy: marvell10g: Utilize gen10g_soft_reset()

Florian, On Wed, Feb 28, 2018 at 11:44 AM, Russell King wrote: > On Wed, Feb 28, 2018 at 11:36:12AM -0800, Florian Fainelli wrote: >> We do the same thing as the generic function: nothing, so utilize it. >> >> Signed-off-by: Florian Fainelli >> --- >> drivers/net/phy/marvell10g.c | 7 +--

[PATCH v3 1/2] dt-bindings: power: reset: gpio-poweroff: Add 'timeout-ms' property

Add 'timeout-ms' property to support boards where the 3s timeout that the current driver defaults to is too short. Signed-off-by: Moritz Fischer <m...@kernel.org> --- Changes from v2: - Addressed Rob's feedback (timeout_ms -> timeout-ms) Changes from v1: - Addressed Rob's feedback

[PATCH v3 2/2] power: reset: gpio-poweroff: Support for timeout from device property

Add support for reading a timeout value from device property. Fall back to previous default of 3s if nothing is specified. Signed-off-by: Moritz Fischer <m...@kernel.org> --- Changes from v2: - use device_property_read_{bool,u32} instead of of equivalent Changes from v1: - of_property_re

[PATCH v3 1/2] dt-bindings: power: reset: gpio-poweroff: Add 'timeout-ms' property

Add 'timeout-ms' property to support boards where the 3s timeout that the current driver defaults to is too short. Signed-off-by: Moritz Fischer --- Changes from v2: - Addressed Rob's feedback (timeout_ms -> timeout-ms) Changes from v1: - Addressed Rob's feedback (timeout -> time

[PATCH v3 2/2] power: reset: gpio-poweroff: Support for timeout from device property

Add support for reading a timeout value from device property. Fall back to previous default of 3s if nothing is specified. Signed-off-by: Moritz Fischer --- Changes from v2: - use device_property_read_{bool,u32} instead of of equivalent Changes from v1: - of_property_read_u32() overwrites

Re: [PATCH] dt-bindings: fpga: Consolidate bridge properties

On Thu, Feb 22, 2018 at 08:12:19AM +0100, Michal Simek wrote: > On 21.2.2018 18:33, Moritz Fischer wrote: > > Consolidate bridge properties in a single file, instead of duplicating > > the same optional property over and over again. > > > > Signed-off-by: Moritz Fisch

Re: [PATCH] dt-bindings: fpga: Consolidate bridge properties

On Thu, Feb 22, 2018 at 08:12:19AM +0100, Michal Simek wrote: > On 21.2.2018 18:33, Moritz Fischer wrote: > > Consolidate bridge properties in a single file, instead of duplicating > > the same optional property over and over again. > > > > Signed-off-by: Moritz Fischer

[PATCH] dt-bindings: fpga: Consolidate bridge properties

Consolidate bridge properties in a single file, instead of duplicating the same optional property over and over again. Signed-off-by: Moritz Fischer <m...@kernel.org> Cc: Alan Tull <at...@kernel.org> Cc: Rob Herring <robh...@kernel.org> --- .../devicetree/bindings/fpga

[PATCH] dt-bindings: fpga: Consolidate bridge properties

Consolidate bridge properties in a single file, instead of duplicating the same optional property over and over again. Signed-off-by: Moritz Fischer Cc: Alan Tull Cc: Rob Herring --- .../devicetree/bindings/fpga/altera-fpga2sdram-bridge.txt | 5 + .../devicetree/bindings/fpga/altera

[PATCH v4 2/2] net: ethernet: nixge: Add support for National Instruments XGE netdev

Add support for the National Instruments XGE 1/10G network device. It uses the EEPROM on the board via NVMEM. Signed-off-by: Moritz Fischer <m...@kernel.org> --- Changes from v3: - Added NIXGE prefix to MDIO constants - Removed NIXGE_MAX_PHY_ADDR (unused) - Consistency for NIXGE_MDIO_CX

[PATCH v4 2/2] net: ethernet: nixge: Add support for National Instruments XGE netdev

Add support for the National Instruments XGE 1/10G network device. It uses the EEPROM on the board via NVMEM. Signed-off-by: Moritz Fischer --- Changes from v3: - Added NIXGE prefix to MDIO constants - Removed NIXGE_MAX_PHY_ADDR (unused) - Consistency for NIXGE_MDIO_CXX_READ constants - Use

[PATCH v4 1/2] dt-bindings: net: Add bindings for National Instruments XGE netdev

This adds bindings for the NI XGE 1G/10G network device. Reviewed-by: Rob Herring <r...@kernel.org> Signed-off-by: Moritz Fischer <m...@kernel.org> --- Changes from v3: - Added Rob's Reviewed-by Changes from v2: - Addressed Rob's comments w.r.t to IRQ names and typo Cha

[PATCH v4 1/2] dt-bindings: net: Add bindings for National Instruments XGE netdev

This adds bindings for the NI XGE 1G/10G network device. Reviewed-by: Rob Herring Signed-off-by: Moritz Fischer --- Changes from v3: - Added Rob's Reviewed-by Changes from v2: - Addressed Rob's comments w.r.t to IRQ names and typo Changes from v1: - Corrected from nixge -> nixge.

Re: [PATCH v2 2/2] power: reset: gpio-poweroff: Add support for timeout from DT

On Tue, Feb 20, 2018 at 04:12:59PM +0200, Andy Shevchenko wrote: > On Tue, Feb 20, 2018 at 12:59 AM, Moritz Fischer <m...@kernel.org> wrote: > > Add support for reading a timeout value from devicetree. > > Fall back to previous default of 3s if

Re: [PATCH v2 2/2] power: reset: gpio-poweroff: Add support for timeout from DT

On Tue, Feb 20, 2018 at 04:12:59PM +0200, Andy Shevchenko wrote: > On Tue, Feb 20, 2018 at 12:59 AM, Moritz Fischer wrote: > > Add support for reading a timeout value from devicetree. > > Fall back to previous default of 3s if nothing is specified. > > > > +

[PATCH v2 2/2] power: reset: gpio-poweroff: Add support for timeout from DT

Add support for reading a timeout value from devicetree. Fall back to previous default of 3s if nothing is specified. Signed-off-by: Moritz Fischer <m...@kernel.org> --- Changes from v1: - of_property_read_u32() overwrites the output only if it succeeds, simplify error handling --- d

[PATCH v2 2/2] power: reset: gpio-poweroff: Add support for timeout from DT

Add support for reading a timeout value from devicetree. Fall back to previous default of 3s if nothing is specified. Signed-off-by: Moritz Fischer --- Changes from v1: - of_property_read_u32() overwrites the output only if it succeeds, simplify error handling --- drivers/power/reset/gpio

[PATCH v2 1/2] dt-bindings: power: reset: gpio-poweroff: Add 'timeout_ms' property

Add 'timeout_ms' property to support boards where the 3s timeout that the current driver defaults to is too short. Signed-off-by: Moritz Fischer <m...@kernel.org> --- Changes from v1: - Addressed Rob's feedback (timeout -> timeout_ms) - Added to old example rather than creating sep

[PATCH v2 1/2] dt-bindings: power: reset: gpio-poweroff: Add 'timeout_ms' property

Add 'timeout_ms' property to support boards where the 3s timeout that the current driver defaults to is too short. Signed-off-by: Moritz Fischer --- Changes from v1: - Addressed Rob's feedback (timeout -> timeout_ms) - Added to old example rather than creating separate one --- Documentat

[PATCH v3 1/2] dt-bindings: net: Add bindings for National Instruments XGE netdev

This adds bindings for the NI XGE 1G/10G network device. Signed-off-by: Moritz Fischer <m...@kernel.org> --- Changes from v2: - Addressed Rob's comments w.r.t to IRQ names and typo Changes from v1: - Corrected from nixge -> nixge.txt --- Documentation/devicetree/bindings/net/nixge

[PATCH v3 1/2] dt-bindings: net: Add bindings for National Instruments XGE netdev

This adds bindings for the NI XGE 1G/10G network device. Signed-off-by: Moritz Fischer --- Changes from v2: - Addressed Rob's comments w.r.t to IRQ names and typo Changes from v1: - Corrected from nixge -> nixge.txt --- Documentation/devicetree/bindings/net/nixge.txt |

[PATCH v3 2/2] net: ethernet: nixge: Add support for National Instruments XGE netdev

Add support for the National Instruments XGE 1/10G network device. It uses the EEPROM on the board via NVMEM. Signed-off-by: Moritz Fischer <m...@kernel.org> --- Changes from v2: - Implement recv side NAPI - Improved error handling - Implemented C45 writes - Added ethtool callbacks &

[PATCH v3 2/2] net: ethernet: nixge: Add support for National Instruments XGE netdev

Add support for the National Instruments XGE 1/10G network device. It uses the EEPROM on the board via NVMEM. Signed-off-by: Moritz Fischer --- Changes from v2: - Implement recv side NAPI - Improved error handling - Implemented C45 writes - Added ethtool callbacks & blink functiona

[PATCH 1/2] dt-bindings: power: reset: gpio-poweroff: Add 'timeout' property

From: Moritz Fischer <m...@kernel.org> Add 'timeout' property to support boards where the 3s timeout that the current driver defaults to is too short. Signed-off-by: Moritz Fischer <m...@kernel.org> --- Documentation/devicetree/bindings/power/reset/gpio-poweroff.txt | 8 1

[PATCH 2/2] power: reset: gpio-poweroff: Add support for timeout from DT

From: Moritz Fischer <m...@kernel.org> Add support for reading a timeout value from devicetree. Fall back to previous default of 3s if nothing is specified. Signed-off-by: Moritz Fischer <m...@kernel.org> --- drivers/power/reset/gpio-poweroff.c | 9 - 1 file changed, 8 inse

[PATCH 1/2] dt-bindings: power: reset: gpio-poweroff: Add 'timeout' property

From: Moritz Fischer Add 'timeout' property to support boards where the 3s timeout that the current driver defaults to is too short. Signed-off-by: Moritz Fischer --- Documentation/devicetree/bindings/power/reset/gpio-poweroff.txt | 8 1 file changed, 8 insertions(+) diff --git

[PATCH 2/2] power: reset: gpio-poweroff: Add support for timeout from DT

From: Moritz Fischer Add support for reading a timeout value from devicetree. Fall back to previous default of 3s if nothing is specified. Signed-off-by: Moritz Fischer --- drivers/power/reset/gpio-poweroff.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers

Re: [PATCH v4 07/24] fpga: dfl: add feature device infrastructure

On Thu, Feb 15, 2018 at 10:05:20AM +, Wu, Hao wrote: > > On Wed, Feb 14, 2018 at 3:03 PM, Moritz Fischer <m...@kernel.org> wrote: > > > > Hi Moritz, > > > > > HI Hao, > > > > > Hi Alan and Moritz > > Thanks a lot for the code revi

Re: [PATCH v4 07/24] fpga: dfl: add feature device infrastructure

On Thu, Feb 15, 2018 at 10:05:20AM +, Wu, Hao wrote: > > On Wed, Feb 14, 2018 at 3:03 PM, Moritz Fischer wrote: > > > > Hi Moritz, > > > > > HI Hao, > > > > > Hi Alan and Moritz > > Thanks a lot for the code review and comments. >

Re: [PATCH v4 07/24] fpga: dfl: add feature device infrastructure

HI Hao, On Tue, Feb 13, 2018 at 05:24:36PM +0800, Wu Hao wrote: > From: Xiao Guangrong > > This patch abstracts the common operations of the sub features, and defines > the feature_ops data structure, including init, uinit and ioctl function > pointers. And this

Re: [PATCH v4 07/24] fpga: dfl: add feature device infrastructure

HI Hao, On Tue, Feb 13, 2018 at 05:24:36PM +0800, Wu Hao wrote: > From: Xiao Guangrong > > This patch abstracts the common operations of the sub features, and defines > the feature_ops data structure, including init, uinit and ioctl function > pointers. And this patch adds some common helper

Re: [PATCH v4 03/24] fpga: mgr: add status for fpga-manager

gt; to allow fpga_manager to collect latest status when failures are > detected. > > The following sysfs file is created: > * /sys/class/fpga_manager//status > Return status of fpga manager, including reconfiguration errors. > > Signed-off-by: Wu Hao <hao...@int

Re: [PATCH v4 03/24] fpga: mgr: add status for fpga-manager

gt; to allow fpga_manager to collect latest status when failures are > detected. > > The following sysfs file is created: > * /sys/class/fpga_manager//status > Return status of fpga manager, including reconfiguration errors. > > Signed-off-by: Wu Hao Acked-by: Moritz

Re: [PATCH v4 06/24] fpga: dfl: adds fpga_cdev_find_port

Signed-off-by: Christopher Rauer <christopher.ra...@intel.com> > Signed-off-by: Xiao Guangrong <guangrong.x...@linux.intel.com> > Signed-off-by: Wu Hao <hao...@intel.com> Acked-by: Moritz Fischer <m...@kernel.org> > --- > v3: s/fpga_for_each_port/fpga_cdev_fin

Re: [PATCH v4 06/24] fpga: dfl: adds fpga_cdev_find_port

ure, it uses this function to find > dedicated port on the device for PR function implementation. > > Signed-off-by: Tim Whisonant > Signed-off-by: Enno Luebbers > Signed-off-by: Shiva Rao > Signed-off-by: Christopher Rauer > Signed-off-by: Xiao Guangrong > Signed-off-

Re: [PATCH v3 0/4] fpga: don't use drvdata in common code

ed Moritz' ack on patch 1 > > Alan Tull (4): > fpga: region: don't use drvdata in common fpga code > fpga: manager: don't use drvdata in common fpga code > fpga: bridge: don't use drvdata in common fpga code > fpga: region: change fpga_region_register to have one param

Re: [PATCH v3 0/4] fpga: don't use drvdata in common code

ed Moritz' ack on patch 1 > > Alan Tull (4): > fpga: region: don't use drvdata in common fpga code > fpga: manager: don't use drvdata in common fpga code > fpga: bridge: don't use drvdata in common fpga code > fpga: region: change fpga_region_register to have one

Re: [PATCH v3 14/21] fpga: dfl: add fpga manager platform driver for FME

gt;> > On Sat, Feb 03, 2018 at 11:41:24AM +0100, Moritz Fischer wrote: > >> >> Hi Hao, > >> >> > >> >> On Fri, Feb 02, 2018 at 04:26:26PM -0800, Luebbers, Enno wrote: > >> >> > Hi Hao, Alan, > >> >> > > >>

Re: [PATCH v3 14/21] fpga: dfl: add fpga manager platform driver for FME

On Mon, Feb 05, 2018 at 10:25:27PM -0600, Alan Tull wrote: > On Mon, Feb 5, 2018 at 8:17 PM, Wu Hao wrote: > > On Mon, Feb 05, 2018 at 11:21:52AM -0600, Alan Tull wrote: > >> On Sun, Feb 4, 2018 at 4:05 AM, Wu Hao wrote: > >> > On Sat, Feb 03, 2018 at 11:41:24

Re: [PATCH v3 14/21] fpga: dfl: add fpga manager platform driver for FME

Hi Hao, On Fri, Feb 02, 2018 at 04:26:26PM -0800, Luebbers, Enno wrote: > Hi Hao, Alan, > > On Fri, Feb 02, 2018 at 05:42:13PM +0800, Wu Hao wrote: > > On Thu, Feb 01, 2018 at 04:00:36PM -0600, Alan Tull wrote: > > > On Mon, Nov 27, 2017 at 12:42 AM, Wu Hao wrote: > > > > > >

Re: [PATCH v3 14/21] fpga: dfl: add fpga manager platform driver for FME

Hi Hao, On Fri, Feb 02, 2018 at 04:26:26PM -0800, Luebbers, Enno wrote: > Hi Hao, Alan, > > On Fri, Feb 02, 2018 at 05:42:13PM +0800, Wu Hao wrote: > > On Thu, Feb 01, 2018 at 04:00:36PM -0600, Alan Tull wrote: > > > On Mon, Nov 27, 2017 at 12:42 AM, Wu Hao wrote: > > > > > > Hi Hao, > > > >

Re: [PATCH v3 16/21] fpga: dfl: add fpga region platform driver for FME

> > Signed-off-by: Tim Whisonant <tim.whison...@intel.com> > > > Signed-off-by: Enno Luebbers <enno.luebb...@intel.com> > > > Signed-off-by: Shiva Rao <shiva@intel.com> > > > Signed-off-by: Christopher Rauer <christopher.ra...@intel.com> > >

Re: [PATCH v3 16/21] fpga: dfl: add fpga region platform driver for FME

isonant > > > Signed-off-by: Enno Luebbers > > > Signed-off-by: Shiva Rao > > > Signed-off-by: Christopher Rauer > > > Signed-off-by: Wu Hao > > Acked-by: Alan Tull Acked-by: Moritz Fischer > > > > > > > diff --git a/drivers/fp

Re: [PATCH v3 19/21] fpga: dfl: afu: add FPGA_GET_API_VERSION/CHECK_EXTENSION ioctls support

; > > Signed-off-by: Enno Luebbers <enno.luebb...@intel.com> > > > Signed-off-by: Shiva Rao <shiva@intel.com> > > > Signed-off-by: Christopher Rauer <christopher.ra...@intel.com> > > > Signed-off-by: Xiao Guangrong <guangrong.x...@linux.intel.

Re: [PATCH v3 19/21] fpga: dfl: afu: add FPGA_GET_API_VERSION/CHECK_EXTENSION ioctls support

> Signed-off-by: Shiva Rao > > > Signed-off-by: Christopher Rauer > > > Signed-off-by: Xiao Guangrong > > > Signed-off-by: Wu Hao > > Acked-by: Alan Tull Acked-by: Moritz Fischer > > -- > > To unsubscribe from this list: send the line "u

Re: [PATCH v3 12/21] fpga: dfl: fme: add FPGA_GET_API_VERSION/CHECK_EXTENSION ioctls support

by: Tim Whisonant <tim.whison...@intel.com> > > > Signed-off-by: Enno Luebbers <enno.luebb...@intel.com> > > > Signed-off-by: Shiva Rao <shiva@intel.com> > > > Signed-off-by: Christopher Rauer <christopher.ra...@intel.com> > > > Sign

Re: [PATCH v3 12/21] fpga: dfl: fme: add FPGA_GET_API_VERSION/CHECK_EXTENSION ioctls support

> > Signed-off-by: Enno Luebbers > > > Signed-off-by: Shiva Rao > > > Signed-off-by: Christopher Rauer > > > Signed-off-by: Xiao Guangrong > > > Signed-off-by: Wu Hao > > > > Acked-by: Alan Tull Acked-by: Moritz Fischer > > > &

Re: [PATCH v3 15/21] fpga: dfl: add fpga bridge platform driver for FME

-by: Enno Luebbers <enno.luebb...@intel.com> > > > Signed-off-by: Shiva Rao <shiva@intel.com> > > > Signed-off-by: Christopher Rauer <christopher.ra...@intel.com> > > > Signed-off-by: Wu Hao <hao...@intel.com> > > > > Acked-by: Al

Re: [PATCH v3 15/21] fpga: dfl: add fpga bridge platform driver for FME

hiva Rao > > > Signed-off-by: Christopher Rauer > > > Signed-off-by: Wu Hao > > > > Acked-by: Alan Tull Acked-by: Moritz Fischer > > > > > diff --git a/drivers/fpga/fpga-dfl-fme-br.c > > > b/drivers/fpga/fpga-dfl-fme-br.c > > > new

Re: [PATCH] fpga: fpga-region: comment on fpga_region_program_fpga locking

Hi Alan, looks good. On Thu, Jan 25, 2018 at 09:39:22AM -0600, Alan Tull wrote: > Add a comment to the header of fpga_region_program_fpga() > regarding locking of the bridges. > > Signed-off-by: Alan Tull <at...@kernel.org> Acked-by: Moritz Fischer <m...@kernel.org> &g

Re: [PATCH] fpga: fpga-region: comment on fpga_region_program_fpga locking

Hi Alan, looks good. On Thu, Jan 25, 2018 at 09:39:22AM -0600, Alan Tull wrote: > Add a comment to the header of fpga_region_program_fpga() > regarding locking of the bridges. > > Signed-off-by: Alan Tull Acked-by: Moritz Fischer > --- > drivers/fpga/fpga-region.c | 5 +

Re: [PATCH v2 5/5] fpga: region: return NOTIFY_STOP if overlay shoud be accepted

riate change to the FPGA region's Device Tree overlay notifier. > > Fixes: 24789c5ce5a3 ("of: overlay: detect cases where device tree may become > corrupt") > Signed-off-by: Alan Tull <at...@kernel.org> Reviewed-by: Moritz Fischer <m...@kernel.org> > --- > v2:

Re: [PATCH v2 5/5] fpga: region: return NOTIFY_STOP if overlay shoud be accepted

riate change to the FPGA region's Device Tree overlay notifier. > > Fixes: 24789c5ce5a3 ("of: overlay: detect cases where device tree may become > corrupt") > Signed-off-by: Alan Tull Reviewed-by: Moritz Fischer > --- > v2: Added in v2 of this patchset. Tested on linux-ne

Re: [PATCH v2 1/5] fpga: region: don't use drvdata in common fpga code

r/bridge/region to hold > drvdata. > > Signed-off-by: Alan Tull <at...@kernel.org> > Reported-by: Jiuyue Ma <majiu...@huawei.com> Acked-by: Moritz Fischer <m...@kernel.org> > --- > v2: No change to this patch in v2 of patchset > --- > drivers/fpga/fpga-region.c|

Re: [PATCH v2 1/5] fpga: region: don't use drvdata in common fpga code

r/bridge/region to hold > drvdata. > > Signed-off-by: Alan Tull > Reported-by: Jiuyue Ma Acked-by: Moritz Fischer > --- > v2: No change to this patch in v2 of patchset > --- > drivers/fpga/fpga-region.c| 1 - > drivers/fpga/of-fpga-region.c | 1 + > 2 files changed, 1

Re: [PATCH 0/2] of: dynamic: restrict overlay by targets

On Mon, Dec 04, 2017 at 11:18:49AM -0800, Moritz Fischer wrote: > On Mon, Dec 04, 2017 at 01:13:55PM -0600, Alan Tull wrote: > > Restrict which nodes are valid targets for a DT overlay. > > > > Add a flag bit to struct device_node allowing nodes to be marked as > >

Re: [PATCH 0/2] of: dynamic: restrict overlay by targets

On Mon, Dec 04, 2017 at 11:18:49AM -0800, Moritz Fischer wrote: > On Mon, Dec 04, 2017 at 01:13:55PM -0600, Alan Tull wrote: > > Restrict which nodes are valid targets for a DT overlay. > > > > Add a flag bit to struct device_node allowing nodes to be marked as > >

Re: [PATCH 0/2] of: dynamic: restrict overlay by targets

On Mon, Dec 04, 2017 at 01:13:55PM -0600, Alan Tull wrote: > Restrict which nodes are valid targets for a DT overlay. > > Add a flag bit to struct device_node allowing nodes to be marked as > valid target for overlays. > > A driver that is always intended to handle DT overlays can > enable

Re: [PATCH 0/2] of: dynamic: restrict overlay by targets

On Mon, Dec 04, 2017 at 01:13:55PM -0600, Alan Tull wrote: > Restrict which nodes are valid targets for a DT overlay. > > Add a flag bit to struct device_node allowing nodes to be marked as > valid target for overlays. > > A driver that is always intended to handle DT overlays can > enable

Re: [PATCH] fpga: socfpga-a10: disable clk on error in socfpga_a10_fpga_probe()

Hi Alexey, On Fri, Dec 01, 2017 at 11:26:24PM +0300, Alexey Khoroshilov wrote: > If fpga_mgr_register() fails, a clock is left undisabled. > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Alexey Khoroshilov <khoroshi...@ispras.ru> Review

Re: [PATCH] fpga: socfpga-a10: disable clk on error in socfpga_a10_fpga_probe()

Hi Alexey, On Fri, Dec 01, 2017 at 11:26:24PM +0300, Alexey Khoroshilov wrote: > If fpga_mgr_register() fails, a clock is left undisabled. > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Alexey Khoroshilov Reviewed-by: Moritz Fischer > -

Re: [PATCH v3 02/21] fpga: mgr: add region_id to fpga_image_info

.@intel.com> Acked-by: Moritz Fischer <m...@kernel.org> > > v3: add one line comment for region_id > --- > include/linux/fpga/fpga-mgr.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/linux/fpga/fpga-mgr.h b/include/linux/fpga/fpga-mgr.h >

Re: [PATCH v3 02/21] fpga: mgr: add region_id to fpga_image_info

Hi Hao, On Mon, Nov 27, 2017 at 02:42:09PM +0800, Wu Hao wrote: > This patch adds region_id to fpga_image_info data structure, it > allows driver to pass region id information to fpga-mgr via > fpga_image_info for fpga reconfiguration function. > > Signed-off-by: Wu Hao Acked-by:

Re: [PATCH v3 04/21] fpga: add device feature list support

Hi Hao, first pass, I didn't get all the way through, yet. On Mon, Nov 27, 2017 at 02:42:11PM +0800, Wu Hao wrote: > Device Feature List (DFL) defines a feature list structure that creates > a link list of feature headers within the MMIO space to provide an > extensible way of adding features.

Re: [PATCH v3 04/21] fpga: add device feature list support

Hi Hao, first pass, I didn't get all the way through, yet. On Mon, Nov 27, 2017 at 02:42:11PM +0800, Wu Hao wrote: > Device Feature List (DFL) defines a feature list structure that creates > a link list of feature headers within the MMIO space to provide an > extensible way of adding features.

Re: [PATCH v5 00/18] Enable upper layers using FPGA region w/o device tree

On Tue, Oct 17, 2017 at 04:20:13PM -0500, Alan Tull wrote: > * Change the fpga-mgr API to have one fpga_mgr_load function > instead of three. > > * Separate common FPGA region code from Device Tree support > > * Expose API functions for FPGA regions > > * Add API functions for bridges where

Re: [PATCH v5 00/18] Enable upper layers using FPGA region w/o device tree

On Tue, Oct 17, 2017 at 04:20:13PM -0500, Alan Tull wrote: > * Change the fpga-mgr API to have one fpga_mgr_load function > instead of three. > > * Separate common FPGA region code from Device Tree support > > * Expose API functions for FPGA regions > > * Add API functions for bridges where

Re: [PATCH v5 10/18] fpga: region: separate out code that parses the overlay

his is a baby step in refactoring the FPGA region code to > separate out common code from Device Tree overlay support. > > Signed-off-by: Alan Tull <at...@kernel.org> Acked-by: Moritz Fischer <m...@kernel.org> > --- > v2: split out from another patch > v3: update comm

Re: [PATCH v5 11/18] fpga: region: add fpga-region.h header

Signed-off-by: Alan Tull <at...@kernel.org> Acked-by: Moritz Fischer <m...@kernel.org> > --- > v2: split out from another patch > update author email > v3: changes due to fpga_region_program_fpga() removed info param > v4: no change to this patch in this version of

Re: [PATCH v5 11/18] fpga: region: add fpga-region.h header

Signed-off-by: Alan Tull Acked-by: Moritz Fischer > --- > v2: split out from another patch > update author email > v3: changes due to fpga_region_program_fpga() removed info param > v4: no change to this patch in this version of patchset > v5: fpga-region.h - move #ifndef b

Re: [PATCH v5 10/18] fpga: region: separate out code that parses the overlay

his is a baby step in refactoring the FPGA region code to > separate out common code from Device Tree overlay support. > > Signed-off-by: Alan Tull Acked-by: Moritz Fischer > --- > v2: split out from another patch > v3: update comments > minor changes in flow > v4: no change

Re: [PATCH v5 12/18] fpga: region: rename some functions prior to moving

fpga_region_probe/remove > > Parameter changes: > * of_fpga_region_find > change parameter to be the device node of the region. > * of_fpga_region_get_bridges > change second parameter to FPGA image info. > > Export of_fpga_region_find as well. > > Signed-

Re: [PATCH v5 12/18] fpga: region: rename some functions prior to moving

fpga_region_probe/remove > > Parameter changes: > * of_fpga_region_find > change parameter to be the device node of the region. > * of_fpga_region_get_bridges > change second parameter to FPGA image info. > > Export of_fpga_region_find as well. > > Signed-off-by:

Re: [PATCH v5 15/18] fpga: region: move device tree support to of-fpga-region.c

region_init > * of_fpga_region_exit > > Signed-off-by: Alan Tull <at...@kernel.org> Acked-by: Moritz Fischer <m...@kernel.org> > --- > v2: split out code changes into other patches, only move code here > v3: updated to move changed code to of-fpga-region.c > v4: r

Re: [PATCH v5 15/18] fpga: region: move device tree support to of-fpga-region.c

region_init > * of_fpga_region_exit > > Signed-off-by: Alan Tull Acked-by: Moritz Fischer > --- > v2: split out code changes into other patches, only move code here > v3: updated to move changed code to of-fpga-region.c > v4: rebase on current for-next > remove fpga-br

Re: [PATCH v5 17/18] fpga: clean up fpga Kconfig

;*> Altera SoCFPGA FPGA Bridges > <*> Altera FPGA Freeze Bridge > <*> Xilinx LogiCORE PR Decoupler > <*> FPGA Region > <*> FPGA Region Device Tree Overlay Support > > Signed-off-by: Alan Tull <at...@kernel.org> Acked-by: Mo

Re: [PATCH v5 17/18] fpga: clean up fpga Kconfig

;*> Altera SoCFPGA FPGA Bridges > <*> Altera FPGA Freeze Bridge > <*> Xilinx LogiCORE PR Decoupler > <*> FPGA Region > <*> FPGA Region Device Tree Overlay Support > > Signed-off-by: Alan Tull Acked-by: Moritz Fischer >

Re: [PATCH v5 18/18] fpga: add attribute groups

t the device attribute group. The attributes are > created in device_add. > > Signed-off-by: Alan Tull <at...@kernel.org> Acked-by: Moritz Fischer <m...@kernel.org> > --- > v4: Patch added to patchset in v4 > v5: no change to this patch in this version of patchset >

Re: [PATCH v5 18/18] fpga: add attribute groups

t the device attribute group. The attributes are > created in device_add. > > Signed-off-by: Alan Tull Acked-by: Moritz Fischer > --- > v4: Patch added to patchset in v4 > v5: no change to this patch in this version of patchset > --- > drivers/fpga/fpga-bridge.c

Re: [PATCH 2/3] fpga: manager: don't use drvdata in common fpga code

If this stuff > doesn't have errors, let's move forward and make whatever changes we > want to make on top of this. Sounds good, haven't found anything else. Sorry for dropping the ball. > > > On Tue, Oct 31, 2017 at 8:34 PM, Moritz Fischer <m...@kernel.org> wrote: >

Re: [PATCH 2/3] fpga: manager: don't use drvdata in common fpga code

t have errors, let's move forward and make whatever changes we > want to make on top of this. Sounds good, haven't found anything else. Sorry for dropping the ball. > > > On Tue, Oct 31, 2017 at 8:34 PM, Moritz Fischer wrote: > >> On Tue, Oct 31, 2017 at 04:45:54PM -0500,

<    1   2   3   4   5   6   7   8   9   10   >