Re: [PATCH 2/3] fpga: manager: don't use drvdata in common fpga code

2017-10-31 Thread Moritz Fischer
On Tue, Oct 31, 2017 at 04:45:54PM -0500, Alan Tull wrote: > On Tue, Oct 31, 2017 at 3:59 PM, Moritz Fischer <m...@kernel.org> wrote: > > On Tue, Oct 31, 2017 at 08:42:14PM +, Alan Tull wrote: > >> Changes to the fpga manager code to not use drvdata in common >

Re: [PATCH 2/3] fpga: manager: don't use drvdata in common fpga code

2017-10-31 Thread Moritz Fischer
On Tue, Oct 31, 2017 at 04:45:54PM -0500, Alan Tull wrote: > On Tue, Oct 31, 2017 at 3:59 PM, Moritz Fischer wrote: > > On Tue, Oct 31, 2017 at 08:42:14PM +, Alan Tull wrote: > >> Changes to the fpga manager code to not use drvdata in common > >> code. > &g

Re: [PATCH 2/3] fpga: manager: don't use drvdata in common fpga code

2017-10-31 Thread Moritz Fischer
On Tue, Oct 31, 2017 at 08:42:14PM +, Alan Tull wrote: > Changes to the fpga manager code to not use drvdata in common > code. > > Change fpga_mgr_register to not set or use drvdata. > > Change the register/unregister function parameters to take the mgr > struct: > * int

Re: [PATCH 2/3] fpga: manager: don't use drvdata in common fpga code

2017-10-31 Thread Moritz Fischer
On Tue, Oct 31, 2017 at 08:42:14PM +, Alan Tull wrote: > Changes to the fpga manager code to not use drvdata in common > code. > > Change fpga_mgr_register to not set or use drvdata. > > Change the register/unregister function parameters to take the mgr > struct: > * int

Re: [PATCH] fpga: fpga-bridge: remove unnecessary null check in of_fpga_bridge_get

2017-10-28 Thread Moritz Fischer
ses-Coverity-ID: 1397912 > Reported-by: Alan Tull <at...@kernel.org> > Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> Reviewed-by: Moritz Fischer <m...@kernel.org> > --- > drivers/fpga/fpga-bridge.c | 2 -- > 1 file changed, 2 deletions(-) > > diff

Re: [PATCH] fpga: fpga-bridge: remove unnecessary null check in of_fpga_bridge_get

2017-10-28 Thread Moritz Fischer
ses-Coverity-ID: 1397912 > Reported-by: Alan Tull > Signed-off-by: Gustavo A. R. Silva Reviewed-by: Moritz Fischer > --- > drivers/fpga/fpga-bridge.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/fpga/fpga-bridge.c b/drivers/fpga/fpga-bridge.c > index 9

Re: [PATCH v2 5/5] of/fdt: only store the device node basename in full_name

2017-10-19 Thread Moritz Fischer
On Thu, Oct 19, 2017 at 11:51:40AM +0300, Pantelis Antoniou wrote: > Hi Rob, > > > On Oct 18, 2017, at 21:30 , Rob Herring wrote: > > > > On Wed, Oct 18, 2017 at 10:53 AM, Pantelis Antoniou > > wrote: > >> On Wed, 2017-10-18 at 10:44 -0500, Rob

Re: [PATCH v2 5/5] of/fdt: only store the device node basename in full_name

2017-10-19 Thread Moritz Fischer
On Thu, Oct 19, 2017 at 11:51:40AM +0300, Pantelis Antoniou wrote: > Hi Rob, > > > On Oct 18, 2017, at 21:30 , Rob Herring wrote: > > > > On Wed, Oct 18, 2017 at 10:53 AM, Pantelis Antoniou > > wrote: > >> On Wed, 2017-10-18 at 10:44 -0500, Rob Herring wrote: > >>> On Wed, Oct 18, 2017 at

Re: [PATCH 1/2] arm: dts: Add support for National Instruments Project Sulfur SDRs

2017-10-06 Thread Moritz Fischer
On Fri, Oct 06, 2017 at 01:49:44PM +0200, Michal Simek wrote: > On 26.9.2017 20:15, Philip Balister wrote: > > On 09/26/2017 02:06 PM, Michal Simek wrote: > >> On 26.9.2017 19:58, Philip Balister wrote: > >>> On 09/26/2017 01:50 PM, Moritz Fischer wrote: > >>

Re: [PATCH 1/2] arm: dts: Add support for National Instruments Project Sulfur SDRs

2017-10-06 Thread Moritz Fischer
On Fri, Oct 06, 2017 at 01:49:44PM +0200, Michal Simek wrote: > On 26.9.2017 20:15, Philip Balister wrote: > > On 09/26/2017 02:06 PM, Michal Simek wrote: > >> On 26.9.2017 19:58, Philip Balister wrote: > >>> On 09/26/2017 01:50 PM, Moritz Fischer wrote: > >>

Re: [PATCH 1/2] arm: dts: Add support for National Instruments Project Sulfur SDRs

2017-09-26 Thread Moritz Fischer
Michal, On Tue, Sep 26, 2017 at 02:54:48PM +0200, Michal Simek wrote: > Hi, > > On 25.9.2017 18:11, Moritz Fischer wrote: > > Hi Michal, > > > > On Mon, Sep 25, 2017 at 10:19:44AM +0200, Michal Simek wrote: > >> Hi Moritz > >&

Re: [PATCH 1/2] arm: dts: Add support for National Instruments Project Sulfur SDRs

2017-09-26 Thread Moritz Fischer
Michal, On Tue, Sep 26, 2017 at 02:54:48PM +0200, Michal Simek wrote: > Hi, > > On 25.9.2017 18:11, Moritz Fischer wrote: > > Hi Michal, > > > > On Mon, Sep 25, 2017 at 10:19:44AM +0200, Michal Simek wrote: > >> Hi Moritz > >&

Re: [PATCH v2 15/22] fpga: intel: add fpga manager platform driver for FME

2017-09-25 Thread Moritz Fischer
Hi Hao, On Mon, Jun 26, 2017 at 09:52:11AM +0800, Wu Hao wrote: > This patch adds fpga manager driver for Intel FPGA Management > Engine(FME). It implements fpga_manager_ops for FPGA Partial > Reconfiguration function. > > Signed-off-by: Tim Whisonant > Signed-off-by:

Re: [PATCH v2 15/22] fpga: intel: add fpga manager platform driver for FME

2017-09-25 Thread Moritz Fischer
Hi Hao, On Mon, Jun 26, 2017 at 09:52:11AM +0800, Wu Hao wrote: > This patch adds fpga manager driver for Intel FPGA Management > Engine(FME). It implements fpga_manager_ops for FPGA Partial > Reconfiguration function. > > Signed-off-by: Tim Whisonant > Signed-off-by: Enno Luebbers >

Re: [PATCH v2 03/22] fpga: bridge: remove OF dependency for fpga-bridge

2017-09-25 Thread Moritz Fischer
; > Signed-off-by: Wu Hao <hao...@intel.com> > Acked-by: Alan Tull <at...@kernel.org> Acked-by: Moritz Fischer <m...@kernel.org> signature.asc Description: PGP signature

Re: [PATCH v2 03/22] fpga: bridge: remove OF dependency for fpga-bridge

2017-09-25 Thread Moritz Fischer
gt; Acked-by: Alan Tull Acked-by: Moritz Fischer signature.asc Description: PGP signature

Re: [PATCH 1/2] arm: dts: Add support for National Instruments Project Sulfur SDRs

2017-09-25 Thread Moritz Fischer
Hi Michal, On Mon, Sep 25, 2017 at 10:19:44AM +0200, Michal Simek wrote: > Hi Moritz > > sorry for delay. No problem. > > On 12.9.2017 01:22, Moritz Fischer wrote: > > Add support for the National Instruments Project Sulfur SDR > > motherboards Rev 2,3 and 4. >

Re: [PATCH 1/2] arm: dts: Add support for National Instruments Project Sulfur SDRs

2017-09-25 Thread Moritz Fischer
Hi Michal, On Mon, Sep 25, 2017 at 10:19:44AM +0200, Michal Simek wrote: > Hi Moritz > > sorry for delay. No problem. > > On 12.9.2017 01:22, Moritz Fischer wrote: > > Add support for the National Instruments Project Sulfur SDR > > motherboards Rev 2,3 and 4. >

Re: [PATCH v2 03/22] fpga: bridge: remove OF dependency for fpga-bridge

2017-09-21 Thread Moritz Fischer
Hi, On Mon, Jun 26, 2017 at 09:51:59AM +0800, Wu Hao wrote: > This patch removes OF dependency of fpga-bridge, it allows drivers > to use fpga-bridge class without device tree support. > > Signed-off-by: Wu Hao > --- > drivers/fpga/Kconfig | 1 - > 1 file changed, 1

Re: [PATCH v2 03/22] fpga: bridge: remove OF dependency for fpga-bridge

2017-09-21 Thread Moritz Fischer
Hi, On Mon, Jun 26, 2017 at 09:51:59AM +0800, Wu Hao wrote: > This patch removes OF dependency of fpga-bridge, it allows drivers > to use fpga-bridge class without device tree support. > > Signed-off-by: Wu Hao > --- > drivers/fpga/Kconfig | 1 - > 1 file changed, 1 deletion(-) > > diff --git

Re: [PATCH] MAINTAINERS: add backup maintainer

2017-09-19 Thread Moritz Fischer
Hi Alan, On Tue, Sep 19, 2017 at 06:25:06PM -0500, Alan Tull wrote: > Add Moritz as a maintainer of the kernel FPGA framework. > > Signed-off-by: Alan Tull <at...@kernel.org> Acked-by: Moritz Fischer <m...@kernel.org> > --- > MAINTAINERS | 2 +- > 1 file chang

Re: [PATCH] MAINTAINERS: add backup maintainer

2017-09-19 Thread Moritz Fischer
Hi Alan, On Tue, Sep 19, 2017 at 06:25:06PM -0500, Alan Tull wrote: > Add Moritz as a maintainer of the kernel FPGA framework. > > Signed-off-by: Alan Tull Acked-by: Moritz Fischer > --- > MAINTAINERS | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > di

Re: [PATCH v4 01/18] fpga: bridge: support getting bridge from device

2017-09-18 Thread Moritz Fischer
On Wed, Sep 13, 2017 at 03:48:24PM -0500, Alan Tull wrote: > Add two functions for getting the FPGA bridge from the device > rather than device tree node. This is to enable writing code > that will support using FPGA bridges without device tree. > Rename one old function to make it clear that it

Re: [PATCH v4 01/18] fpga: bridge: support getting bridge from device

2017-09-18 Thread Moritz Fischer
On Wed, Sep 13, 2017 at 03:48:24PM -0500, Alan Tull wrote: > Add two functions for getting the FPGA bridge from the device > rather than device tree node. This is to enable writing code > that will support using FPGA bridges without device tree. > Rename one old function to make it clear that it

Re: [PATCH v4 04/18] fpga: region: use dev_err instead of pr_err

2017-09-18 Thread Moritz Fischer
On Wed, Sep 13, 2017 at 03:48:27PM -0500, Alan Tull wrote: > Use dev_err messages instead of pr_err. > > Also s/>dev/dev/ in two places where we already > have dev = >dev. > > Signed-off-by: Alan Tull <at...@kernel.org> Acked-by: Moritz Fischer <m...@kernel.org

Re: [PATCH v4 04/18] fpga: region: use dev_err instead of pr_err

2017-09-18 Thread Moritz Fischer
On Wed, Sep 13, 2017 at 03:48:27PM -0500, Alan Tull wrote: > Use dev_err messages instead of pr_err. > > Also s/>dev/dev/ in two places where we already > have dev = >dev. > > Signed-off-by: Alan Tull Acked-by: Moritz Fischer > --- > v2: new in thi

Re: [PATCH v4 01/18] fpga: bridge: support getting bridge from device

2017-09-18 Thread Moritz Fischer
On Wed, Sep 13, 2017 at 03:48:24PM -0500, Alan Tull wrote: > Add two functions for getting the FPGA bridge from the device > rather than device tree node. This is to enable writing code > that will support using FPGA bridges without device tree. > Rename one old function to make it clear that it

Re: [PATCH v4 01/18] fpga: bridge: support getting bridge from device

2017-09-18 Thread Moritz Fischer
On Wed, Sep 13, 2017 at 03:48:24PM -0500, Alan Tull wrote: > Add two functions for getting the FPGA bridge from the device > rather than device tree node. This is to enable writing code > that will support using FPGA bridges without device tree. > Rename one old function to make it clear that it

Re: [PATCH 2/2] driver core: remove DRIVER_ATTR

2017-09-18 Thread Moritz Fischer
gt; one can use it anymore. > > Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation.org> Reviewed-by: Moritz Fischer <m...@kernel.org> > --- > Documentation/driver-model/driver.txt | 7 --- > Documentation/filesystems/sysfs.txt | 3 ++- > include/linux/devi

Re: [PATCH 2/2] driver core: remove DRIVER_ATTR

2017-09-18 Thread Moritz Fischer
gt; one can use it anymore. > > Signed-off-by: Greg Kroah-Hartman Reviewed-by: Moritz Fischer > --- > Documentation/driver-model/driver.txt | 7 --- > Documentation/filesystems/sysfs.txt | 3 ++- > include/linux/device.h| 2 -- > 3 files changed, 6 ins

Re: [PATCH 1/2] fpga: altera-cvp: remove DRIVER_ATTR() usage

2017-09-18 Thread Moritz Fischer
nel.org> > Cc: Moritz Fischer <m...@kernel.org> > Cc: linux-f...@vger.kernel.org > Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation.org> Acked-by: Moritz Fischer <m...@kernel.org> > --- > drivers/fpga/altera-cvp.c | 6 +++--- > 1 file changed, 3

Re: [PATCH 1/2] fpga: altera-cvp: remove DRIVER_ATTR() usage

2017-09-18 Thread Moritz Fischer
On Mon, Sep 18, 2017 at 12:17:36PM +0200, Greg Kroah-Hartman wrote: > It's better to be explicit and use the DRIVER_ATTR_RW() macro when > defining a driver's sysfs file. > > This is part of a series to drop DRIVER_ATTR() from the tree entirely. > > Cc: Alan Tull > Cc:

[PATCH] thermal: of: Fix doc string phy mode -> trip type

2017-09-15 Thread Moritz Fischer
This function does not look for a phy mode, but a trip type. Signed-off-by: Moritz Fischer <m...@kernel.org> --- drivers/thermal/of-thermal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/thermal/of-thermal.c b/drivers/thermal/of-thermal.c index d04ec3

[PATCH] thermal: of: Fix doc string phy mode -> trip type

2017-09-15 Thread Moritz Fischer
This function does not look for a phy mode, but a trip type. Signed-off-by: Moritz Fischer --- drivers/thermal/of-thermal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/thermal/of-thermal.c b/drivers/thermal/of-thermal.c index d04ec3b9e5ff..4e23a09d8f63 100644

Re: [PATCH v4 01/18] fpga: bridge: support getting bridge from device

2017-09-14 Thread Moritz Fischer
On Thu, Sep 14, 2017 at 03:29:09PM -0700, matthew.gerl...@linux.intel.com wrote: > > > On Thu, 14 Sep 2017, Alan Tull wrote: > > > On Wed, Sep 13, 2017 at 6:38 PM, wrote: > > > > Hi Matthew, > > > > > > > > Hi Alan, > > > > > > Two minor nits below. > > >

Re: [PATCH v4 01/18] fpga: bridge: support getting bridge from device

2017-09-14 Thread Moritz Fischer
On Thu, Sep 14, 2017 at 03:29:09PM -0700, matthew.gerl...@linux.intel.com wrote: > > > On Thu, 14 Sep 2017, Alan Tull wrote: > > > On Wed, Sep 13, 2017 at 6:38 PM, wrote: > > > > Hi Matthew, > > > > > > > > Hi Alan, > > > > > > Two minor nits below. > > > > > > Matthew Gerlach > > > > >

[PATCH 1/2] arm: dts: Add support for National Instruments Project Sulfur SDRs

2017-09-11 Thread Moritz Fischer
Add support for the National Instruments Project Sulfur SDR motherboards Rev 2,3 and 4. Signed-off-by: Moritz Fischer <m...@kernel.org> --- arch/arm/boot/dts/Makefile| 3 + arch/arm/boot/dts/zynq-ni-sulfur-rev2.dts | 84 +++ arch/arm/boot/dts/zynq-ni-

[PATCH 2/2] MAINTAINERS: Add info for NI Project Sulfur DT files

2017-09-11 Thread Moritz Fischer
Add contact info for National Instruments Project Sulfur SDR files. Signed-off-by: Moritz Fischer <m...@kernel.org> --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index a3231bd6541d..aa54be9213bf 100644 --- a/MAINTAINERS +++ b/MAINT

[PATCH 1/2] arm: dts: Add support for National Instruments Project Sulfur SDRs

2017-09-11 Thread Moritz Fischer
Add support for the National Instruments Project Sulfur SDR motherboards Rev 2,3 and 4. Signed-off-by: Moritz Fischer --- arch/arm/boot/dts/Makefile| 3 + arch/arm/boot/dts/zynq-ni-sulfur-rev2.dts | 84 +++ arch/arm/boot/dts/zynq-ni-sulfur-rev3.dts | 118

[PATCH 2/2] MAINTAINERS: Add info for NI Project Sulfur DT files

2017-09-11 Thread Moritz Fischer
Add contact info for National Instruments Project Sulfur SDR files. Signed-off-by: Moritz Fischer --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index a3231bd6541d..aa54be9213bf 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1609,6 +1609,13

Re: [patch v7 1/4] drivers: jtag: Add JTAG core driver

2017-09-01 Thread Moritz Fischer
Nit inline ;-) On Fri, Sep 1, 2017 at 9:06 AM, Oleksandr Shamray wrote: > Initial patch for JTAG friver s/friver/driver > JTAG class driver provide infrastructure to support hardware/software > JTAG platform drivers. It provide user layer API interface for flashing >

Re: [patch v7 1/4] drivers: jtag: Add JTAG core driver

2017-09-01 Thread Moritz Fischer
Nit inline ;-) On Fri, Sep 1, 2017 at 9:06 AM, Oleksandr Shamray wrote: > Initial patch for JTAG friver s/friver/driver > JTAG class driver provide infrastructure to support hardware/software > JTAG platform drivers. It provide user layer API interface for flashing > and debugging external

Re: [PATCH] fpga: make xlnx_pr_decoupler_br_ops const

2017-08-29 Thread Moritz Fischer
On Tue, Aug 29, 2017 at 12:00 AM, Michal Simek <michal.si...@xilinx.com> wrote: > On 28.8.2017 19:32, Bhumika Goyal wrote: >> Make this const as it is only passed to a const argument of the function >> fpga_bridge_register. >> >> Signed-off-by: Bhumika Goyal <b

Re: [PATCH] fpga: make xlnx_pr_decoupler_br_ops const

2017-08-29 Thread Moritz Fischer
On Tue, Aug 29, 2017 at 12:00 AM, Michal Simek wrote: > On 28.8.2017 19:32, Bhumika Goyal wrote: >> Make this const as it is only passed to a const argument of the function >> fpga_bridge_register. >> >> Signed-off-by: Bhumika Goyal Acked-by: Moritz Fischer >&g

Re: [PATCH v2 16/22] fpga: intel: add fpga bridge platform driver for FME

2017-08-17 Thread Moritz Fischer
sonant <tim.whison...@intel.com> > Signed-off-by: Enno Luebbers <enno.luebb...@intel.com> > Signed-off-by: Shiva Rao <shiva@intel.com> > Signed-off-by: Christopher Rauer <christopher.ra...@intel.com> > Signed-off-by: Wu Hao <hao...@intel.com> Rev

Re: [PATCH v2 16/22] fpga: intel: add fpga bridge platform driver for FME

2017-08-17 Thread Moritz Fischer
: Enno Luebbers > Signed-off-by: Shiva Rao > Signed-off-by: Christopher Rauer > Signed-off-by: Wu Hao Reviewed-by: Moritz Fischer (With fixes below) > --- > drivers/fpga/Kconfig | 7 > drivers/fpga/Makefile| 1 + > d

Re: [PATCH v3 01/16] doc: fpga: update documents for the FPGA API

2017-08-17 Thread Moritz Fischer
Hi Alan, I think that should go together with [3/16] in one commit, to make API change go together with actual change? On Thu, Jul 6, 2017 at 11:47 AM, Alan Tull wrote: > The FPGA manager has been simplified to have a single > fpga_mgr_load function which replaces the three >

Re: [PATCH v3 01/16] doc: fpga: update documents for the FPGA API

2017-08-17 Thread Moritz Fischer
Hi Alan, I think that should go together with [3/16] in one commit, to make API change go together with actual change? On Thu, Jul 6, 2017 at 11:47 AM, Alan Tull wrote: > The FPGA manager has been simplified to have a single > fpga_mgr_load function which replaces the three > fpga_mgr_*load*

Re: [PATCH v2 20/22] fpga: intel: afu add FPGA_GET_API_VERSION/CHECK_EXTENSION ioctls support

2017-08-17 Thread Moritz Fischer
Hi, On Sun, Jun 25, 2017 at 6:52 PM, Wu Hao wrote: > FPGA_GET_API_VERSION and FPGA_CHECK_EXTENSION ioctls are common ones which > need to be supported by all feature devices drivers including FME and AFU. > This patch implements above 2 ioctls in Intel FPGA Accelerated Function

Re: [PATCH v2 20/22] fpga: intel: afu add FPGA_GET_API_VERSION/CHECK_EXTENSION ioctls support

2017-08-17 Thread Moritz Fischer
Hi, On Sun, Jun 25, 2017 at 6:52 PM, Wu Hao wrote: > FPGA_GET_API_VERSION and FPGA_CHECK_EXTENSION ioctls are common ones which > need to be supported by all feature devices drivers including FME and AFU. > This patch implements above 2 ioctls in Intel FPGA Accelerated Function > Unit (AFU)

Re: [PATCH v2 18/22] fpga: intel: add FPGA Accelerated Function Unit driver basic framework

2017-08-17 Thread Moritz Fischer
On Sun, Jun 25, 2017 at 6:52 PM, Wu Hao wrote: > On Intel FPGA devices, the Accelerated Function Unit (AFU), can be > reprogrammed for different functions. It connects to the FPGA > infrastructure("blue bistream") via a Port. Port CSRs are implemented > separately from the AFU

Re: [PATCH v2 18/22] fpga: intel: add FPGA Accelerated Function Unit driver basic framework

2017-08-17 Thread Moritz Fischer
On Sun, Jun 25, 2017 at 6:52 PM, Wu Hao wrote: > On Intel FPGA devices, the Accelerated Function Unit (AFU), can be > reprogrammed for different functions. It connects to the FPGA > infrastructure("blue bistream") via a Port. Port CSRs are implemented > separately from the AFU CSRs to provide

Re: [PATCH RFC] fpga: add FPGA Bus device framework

2017-08-14 Thread Moritz Fischer
On Mon, Aug 14, 2017 at 5:59 AM, Wu, Hao wrote: >> On Tue, Aug 8, 2017 at 1:25 PM, Wu, Hao wrote: >> >> On Thu, Aug 3, 2017 at 2:53 AM, Wu Hao wrote: >> >> > On Wed, Aug 02, 2017 at 04:16:32PM -0500, Alan Tull wrote: >> >> >> On Wed, Aug 2,

Re: [PATCH RFC] fpga: add FPGA Bus device framework

2017-08-14 Thread Moritz Fischer
On Mon, Aug 14, 2017 at 5:59 AM, Wu, Hao wrote: >> On Tue, Aug 8, 2017 at 1:25 PM, Wu, Hao wrote: >> >> On Thu, Aug 3, 2017 at 2:53 AM, Wu Hao wrote: >> >> > On Wed, Aug 02, 2017 at 04:16:32PM -0500, Alan Tull wrote: >> >> >> On Wed, Aug 2, 2017 at 7:19 AM, Wu Hao wrote: >> >> >> > This patch

Re: [PATCH v2 22/22] fpga: intel: afu: add FPGA_PORT_DMA_MAP/UNMAP ioctls support

2017-08-01 Thread Moritz Fischer
Hi Wu, couple of minor things inline below. On Sun, Jun 25, 2017 at 6:52 PM, Wu Hao wrote: > DMA memory regions are required for Accelerated Function Unit (AFU) usage. > These two ioctls allow user space applications to map user memory regions > for dma, and unmap them after

Re: [PATCH v2 22/22] fpga: intel: afu: add FPGA_PORT_DMA_MAP/UNMAP ioctls support

2017-08-01 Thread Moritz Fischer
Hi Wu, couple of minor things inline below. On Sun, Jun 25, 2017 at 6:52 PM, Wu Hao wrote: > DMA memory regions are required for Accelerated Function Unit (AFU) usage. > These two ioctls allow user space applications to map user memory regions > for dma, and unmap them after use. Iova is

[PATCH v2] MAINTAINERS: fpga: Update email and add patchwork URL

2017-07-31 Thread Moritz Fischer
Add Q: entry for patchwork and update my email address. Signed-off-by: Moritz Fischer <m...@kernel.org> Acked-By: Alan Tull <at...@kernel.org> Cc: Alan Tull <at...@kernel.org> Cc: linux-f...@vger.kernel.org Cc: linux-kernel@vger.kernel.org --- Changes from v1: - Don't mess up

[PATCH v2] MAINTAINERS: fpga: Update email and add patchwork URL

2017-07-31 Thread Moritz Fischer
Add Q: entry for patchwork and update my email address. Signed-off-by: Moritz Fischer Acked-By: Alan Tull Cc: Alan Tull Cc: linux-f...@vger.kernel.org Cc: linux-kernel@vger.kernel.org --- Changes from v1: - Don't mess up the email address --- MAINTAINERS | 3 ++- 1 file changed, 2

Re: [PATCH 09/10] arm64: zynqmp: Add new uartps compatible string

2017-07-25 Thread Moritz Fischer
be available. > > Signed-off-by: Michal Simek <michal.si...@xilinx.com> Reviewed-by: Moritz Fischer <m...@kernel.org> > --- > > arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/xi

Re: [PATCH 09/10] arm64: zynqmp: Add new uartps compatible string

2017-07-25 Thread Moritz Fischer
be available. > > Signed-off-by: Michal Simek Reviewed-by: Moritz Fischer > --- > > arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi > b/arch/arm64/boot/dts/

Re: [PATCH 01/10] arm64: zynqmp: Add references to cpu nodes

2017-07-25 Thread Moritz Fischer
On Thu, Jul 20, 2017 at 02:17:00PM +0200, Michal Simek wrote: > Add missing references to all cpu nodes. > > Signed-off-by: Michal Simek <michal.si...@xilinx.com> Reviewed-by: Moritz Fischer <m...@kernel.org> > --- > > arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 8

Re: [PATCH 01/10] arm64: zynqmp: Add references to cpu nodes

2017-07-25 Thread Moritz Fischer
On Thu, Jul 20, 2017 at 02:17:00PM +0200, Michal Simek wrote: > Add missing references to all cpu nodes. > > Signed-off-by: Michal Simek Reviewed-by: Moritz Fischer > --- > > arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 8 > 1 file changed, 4 insertions(+), 4 deletio

[PATCH] MAINTAINERS: fpga: Update email and add patchwork URL

2017-07-19 Thread Moritz Fischer
Add Q: entry for patchwork and update my email address. Signed-off-by: Moritz Fischer <m...@kernel.org> Cc: Alan Tull <at...@kernel.org> Cc: linux-f...@vger.kernel.org Cc: linux-kernel@vger.kernel.org --- MAINTAINERS | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

[PATCH] MAINTAINERS: fpga: Update email and add patchwork URL

2017-07-19 Thread Moritz Fischer
Add Q: entry for patchwork and update my email address. Signed-off-by: Moritz Fischer Cc: Alan Tull Cc: linux-f...@vger.kernel.org Cc: linux-kernel@vger.kernel.org --- MAINTAINERS | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index f42daf7

Re: [PATCH 002/102] ARM: socfpga: explicitly request exclusive reset control

2017-07-19 Thread Moritz Fischer
red reset > control behavior. Convert all drivers requesting exclusive resets to the > explicit API call so the temporary transition helpers can be removed. > > No functional changes. > > Cc: Alan Tull <at...@kernel.org> > Cc: Moritz Fischer <moritz.fisc...@ettus.c

Re: [PATCH 002/102] ARM: socfpga: explicitly request exclusive reset control

2017-07-19 Thread Moritz Fischer
red reset > control behavior. Convert all drivers requesting exclusive resets to the > explicit API call so the temporary transition helpers can be removed. > > No functional changes. > > Cc: Alan Tull > Cc: Moritz Fischer > Cc: linux-f...@vger.kernel.org > Signed-o

Re: [PATCH] fpga: Convert to using %pOF instead of full_name

2017-07-18 Thread Moritz Fischer
.@kernel.org> > Cc: Alan Tull <at...@kernel.org> > Cc: Moritz Fischer <moritz.fisc...@ettus.com> > Cc: linux-f...@vger.kernel.org Acked-by: Moritz Fischer <m...@kernel.org> > --- > drivers/fpga/fpga-region.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 de

Re: [PATCH] fpga: Convert to using %pOF instead of full_name

2017-07-18 Thread Moritz Fischer
c: Alan Tull > Cc: Moritz Fischer > Cc: linux-f...@vger.kernel.org Acked-by: Moritz Fischer > --- > drivers/fpga/fpga-region.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/fpga/fpga-region.c b/drivers/fpga/fpga-region.c &g

Re: [PATCH 2/2] mfd: ds1374: Add Dallas/Maxim DS1374 Multi Function Device

2017-07-17 Thread Moritz Fischer
Hi Lee, On Mon, Jul 17, 2017 at 08:51:17AM +0100, Lee Jones wrote: > On Thu, 13 Jul 2017, Moritz Fischer wrote: > > > From: Moritz Fischer <moritz.fisc...@ettus.com> > > > > Add support for the Maxim/Dallas DS1374 RTC/WDT with trickle charger. > > The devic

Re: [PATCH 2/2] mfd: ds1374: Add Dallas/Maxim DS1374 Multi Function Device

2017-07-17 Thread Moritz Fischer
Hi Lee, On Mon, Jul 17, 2017 at 08:51:17AM +0100, Lee Jones wrote: > On Thu, 13 Jul 2017, Moritz Fischer wrote: > > > From: Moritz Fischer > > > > Add support for the Maxim/Dallas DS1374 RTC/WDT with trickle charger. > > The device can either be configure

Re: [PATCH v2 1/2] dt-bindings: net: Add bindings for National Instruments XGE netdev

2017-07-17 Thread Moritz Fischer
On Sat, Jul 15, 2017 at 09:48:32PM +0200, Andrew Lunn wrote: > > > > + ethernet_phy1: ethernet-phy@4 { > > > > + compatible = "ethernet-phy-ieee802.3-c45"; > > > > + reg = <4>; > > > > + devices = <0xa>; > > > > +

Re: [PATCH v2 1/2] dt-bindings: net: Add bindings for National Instruments XGE netdev

2017-07-17 Thread Moritz Fischer
On Sat, Jul 15, 2017 at 09:48:32PM +0200, Andrew Lunn wrote: > > > > + ethernet_phy1: ethernet-phy@4 { > > > > + compatible = "ethernet-phy-ieee802.3-c45"; > > > > + reg = <4>; > > > > + devices = <0xa>; > > > > +

Re: [PATCH v2 1/2] dt-bindings: net: Add bindings for National Instruments XGE netdev

2017-07-15 Thread Moritz Fischer
Hi Andrew, On Sat, Jul 15, 2017 at 08:37:45PM +0200, Andrew Lunn wrote: > On Fri, Jul 14, 2017 at 01:48:45PM -0700, Moritz Fischer wrote: > > This adds bindings for the NI XGE 1G/10G network device. > > > > Signed-off-by: Moritz Fischer <m...@kernel.org> > >

Re: [PATCH v2 1/2] dt-bindings: net: Add bindings for National Instruments XGE netdev

2017-07-15 Thread Moritz Fischer
Hi Andrew, On Sat, Jul 15, 2017 at 08:37:45PM +0200, Andrew Lunn wrote: > On Fri, Jul 14, 2017 at 01:48:45PM -0700, Moritz Fischer wrote: > > This adds bindings for the NI XGE 1G/10G network device. > > > > Signed-off-by: Moritz Fischer > > --- > > Docu

[PATCH v2 2/2] net: ethernet: nixge: Add support for National Instruments XGE netdev

2017-07-14 Thread Moritz Fischer
Add support for the National Instruments XGE 1/10G network device. It uses the EEPROM on the board via NVMEM. Signed-off-by: Moritz Fischer <m...@kernel.org> --- Changes from v1: - Added dependency on ARCH_ZYNQ (Kbuild) - Removed unused variables - Use of_phy_connect as suggested - R

[PATCH v2 2/2] net: ethernet: nixge: Add support for National Instruments XGE netdev

2017-07-14 Thread Moritz Fischer
Add support for the National Instruments XGE 1/10G network device. It uses the EEPROM on the board via NVMEM. Signed-off-by: Moritz Fischer --- Changes from v1: - Added dependency on ARCH_ZYNQ (Kbuild) - Removed unused variables - Use of_phy_connect as suggested - Removed masking of (un

[PATCH v2 1/2] dt-bindings: net: Add bindings for National Instruments XGE netdev

2017-07-14 Thread Moritz Fischer
This adds bindings for the NI XGE 1G/10G network device. Signed-off-by: Moritz Fischer <m...@kernel.org> --- Documentation/devicetree/bindings/net/nixge.txt | 32 + 1 file changed, 32 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/nixge.txt

[PATCH v2 1/2] dt-bindings: net: Add bindings for National Instruments XGE netdev

2017-07-14 Thread Moritz Fischer
This adds bindings for the NI XGE 1G/10G network device. Signed-off-by: Moritz Fischer --- Documentation/devicetree/bindings/net/nixge.txt | 32 + 1 file changed, 32 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/nixge.txt diff --git

Re: [PATCH 2/2] mfd: ds1374: Add Dallas/Maxim DS1374 Multi Function Device

2017-07-14 Thread Moritz Fischer
Hi Guenter, On Thu, Jul 13, 2017 at 08:57:52PM -0700, Guenter Roeck wrote: > On 07/13/2017 12:54 PM, Moritz Fischer wrote: > > From: Moritz Fischer <moritz.fisc...@ettus.com> > > > > Add support for the Maxim/Dallas DS1374 RTC/WDT with trickle charger. > > Th

Re: [PATCH 2/2] mfd: ds1374: Add Dallas/Maxim DS1374 Multi Function Device

2017-07-14 Thread Moritz Fischer
Hi Guenter, On Thu, Jul 13, 2017 at 08:57:52PM -0700, Guenter Roeck wrote: > On 07/13/2017 12:54 PM, Moritz Fischer wrote: > > From: Moritz Fischer > > > > Add support for the Maxim/Dallas DS1374 RTC/WDT with trickle charger. > > The device can either be configured a

Re: [PATCH 2/2] net: ethernet: nixge: Add support for National Instruments XGE netdev

2017-07-13 Thread Moritz Fischer
Hi Andrew, On Thu, Jul 13, 2017 at 6:34 PM, Andrew Lunn wrote: >> > > + /* not sure if this is the correct way of dealing with this ... */ >> > > + ndev->phydev->supported &= ~(SUPPORTED_Autoneg); >> > > + ndev->phydev->advertising = ndev->phydev->supported; >> > > +

Re: [PATCH 2/2] net: ethernet: nixge: Add support for National Instruments XGE netdev

2017-07-13 Thread Moritz Fischer
Hi Andrew, On Thu, Jul 13, 2017 at 6:34 PM, Andrew Lunn wrote: >> > > + /* not sure if this is the correct way of dealing with this ... */ >> > > + ndev->phydev->supported &= ~(SUPPORTED_Autoneg); >> > > + ndev->phydev->advertising = ndev->phydev->supported; >> > > + ndev->phydev->autoneg =

Re: [PATCH 1/2] dt-bindings: net: Add bindings for National Instruments XGE netdev

2017-07-13 Thread Moritz Fischer
Hi Yuan, On Thu, Jul 13, 2017 at 5:33 PM, YUAN Linyu <linyu.y...@alcatel-sbell.com.cn> wrote: > > >> -Original Message- >> From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] >> On Behalf Of Moritz Fischer >> Sent: Frid

Re: [PATCH 1/2] dt-bindings: net: Add bindings for National Instruments XGE netdev

2017-07-13 Thread Moritz Fischer
Hi Yuan, On Thu, Jul 13, 2017 at 5:33 PM, YUAN Linyu wrote: > > >> -Original Message- >> From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] >> On Behalf Of Moritz Fischer >> Sent: Friday, July 14, 2017 5:22 AM >> To: n

Re: [PATCH 2/2] net: ethernet: nixge: Add support for National Instruments XGE netdev

2017-07-13 Thread Moritz Fischer
Hi Andrew, thanks for the quick response. On Fri, Jul 14, 2017 at 12:36:36AM +0200, Andrew Lunn wrote: > > +++ b/drivers/net/ethernet/ni/nixge.c > > @@ -0,0 +1,1246 @@ > > +/* > > + * Copyright (c) 2016-2017, National Instruments Corp. > > + * > > + * Network Driver for Ettus Research XGE MAC >

Re: [PATCH 2/2] net: ethernet: nixge: Add support for National Instruments XGE netdev

2017-07-13 Thread Moritz Fischer
Hi Andrew, thanks for the quick response. On Fri, Jul 14, 2017 at 12:36:36AM +0200, Andrew Lunn wrote: > > +++ b/drivers/net/ethernet/ni/nixge.c > > @@ -0,0 +1,1246 @@ > > +/* > > + * Copyright (c) 2016-2017, National Instruments Corp. > > + * > > + * Network Driver for Ettus Research XGE MAC >

[PATCH 1/2] dt-bindings: net: Add bindings for National Instruments XGE netdev

2017-07-13 Thread Moritz Fischer
This adds bindings for the NI XGE 1G/10G network device. Signed-off-by: Moritz Fischer <m...@kernel.org> --- Documentation/devicetree/bindings/net/nixge.c | 32 +++ 1 file changed, 32 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/nixge.c

[PATCH 2/2] net: ethernet: nixge: Add support for National Instruments XGE netdev

2017-07-13 Thread Moritz Fischer
Add support for the National Instruments XGE 1/10G network device. It uses the EEPROM on the board via NVMEM. Signed-off-by: Moritz Fischer <m...@kernel.org> --- drivers/net/ethernet/Kconfig |1 + drivers/net/ethernet/Makefile|1 + drivers/net/ethernet/ni/Kconfig

[PATCH 1/2] dt-bindings: net: Add bindings for National Instruments XGE netdev

2017-07-13 Thread Moritz Fischer
This adds bindings for the NI XGE 1G/10G network device. Signed-off-by: Moritz Fischer --- Documentation/devicetree/bindings/net/nixge.c | 32 +++ 1 file changed, 32 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/nixge.c diff --git

[PATCH 2/2] net: ethernet: nixge: Add support for National Instruments XGE netdev

2017-07-13 Thread Moritz Fischer
Add support for the National Instruments XGE 1/10G network device. It uses the EEPROM on the board via NVMEM. Signed-off-by: Moritz Fischer --- drivers/net/ethernet/Kconfig |1 + drivers/net/ethernet/Makefile|1 + drivers/net/ethernet/ni/Kconfig | 26 + drivers/net/ethernet

[PATCH 1/2] dt-binding: mfd: Add Maxim/Dallas DS1374 MFD device binding

2017-07-13 Thread Moritz Fischer
This adds a binding for the Maxim/Dallas DS1374 MFD. Signed-off-by: Moritz Fischer <m...@kernel.org> --- Changes from RFC: - dallas,ds1374-mode -> dallas,mode - Clarified examples - dallas,remap-reset property On second thoughts the solution for the remapping found in the discussion did

[PATCH 1/2] dt-binding: mfd: Add Maxim/Dallas DS1374 MFD device binding

2017-07-13 Thread Moritz Fischer
This adds a binding for the Maxim/Dallas DS1374 MFD. Signed-off-by: Moritz Fischer --- Changes from RFC: - dallas,ds1374-mode -> dallas,mode - Clarified examples - dallas,remap-reset property On second thoughts the solution for the remapping found in the discussion did not seem to be a g

[PATCH 2/2] mfd: ds1374: Add Dallas/Maxim DS1374 Multi Function Device

2017-07-13 Thread Moritz Fischer
From: Moritz Fischer <moritz.fisc...@ettus.com> Add support for the Maxim/Dallas DS1374 RTC/WDT with trickle charger. The device can either be configured as simple RTC, as simple RTC with Alarm (IRQ) as well as simple RTC with watchdog timer. Break up the old monolithic driver in drivers/r

[PATCH 2/2] mfd: ds1374: Add Dallas/Maxim DS1374 Multi Function Device

2017-07-13 Thread Moritz Fischer
From: Moritz Fischer Add support for the Maxim/Dallas DS1374 RTC/WDT with trickle charger. The device can either be configured as simple RTC, as simple RTC with Alarm (IRQ) as well as simple RTC with watchdog timer. Break up the old monolithic driver in drivers/rtc/rtc-ds1374.c into: - rtc part

Re: [PATCH v3 03/16] fpga: mgr: API change to replace fpga load functions with single function

2017-07-10 Thread Moritz Fischer
Hi Alan, On Thu, Jul 6, 2017 at 11:47 AM, Alan Tull wrote: > fpga-mgr has three methods for programming FPGAs, depending on > whether the image is in a scatter gather list, a contiguous > buffer, or a firmware file. This makes it difficult to write > upper layers as the caller

Re: [PATCH v3 03/16] fpga: mgr: API change to replace fpga load functions with single function

2017-07-10 Thread Moritz Fischer
Hi Alan, On Thu, Jul 6, 2017 at 11:47 AM, Alan Tull wrote: > fpga-mgr has three methods for programming FPGAs, depending on > whether the image is in a scatter gather list, a contiguous > buffer, or a firmware file. This makes it difficult to write > upper layers as the caller has to assume

Re: [PATCH] fpga: altera-hps2fpga: add NULL check on of_match_device() return value

2017-07-10 Thread Moritz Fischer
stavo A. R. Silva <garsi...@embeddedor.com> Reviewed-by: Moritz Fischer <m...@kernel.org> > --- > drivers/fpga/altera-hps2fpga.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/drivers/fpga/altera-hps2fpga.c b/drivers/fpga/altera-hps2fpga.c > index 3066b80.

Re: [PATCH] fpga: altera-hps2fpga: add NULL check on of_match_device() return value

2017-07-10 Thread Moritz Fischer
On Thu, Jul 6, 2017 at 11:22 PM, Gustavo A. R. Silva wrote: > Check return value from call to of_match_device() > in order to prevent a NULL pointer dereference. > > In case of NULL print error message and return -ENODEV > > Signed-off-by: Gustavo A. R. Silva Reviewed-

Re: [PATCH 2/2] fpga: lattice machxo2: Add Lattice MachXO2 support

2017-07-06 Thread Moritz Fischer
Hi Paolo, On Thu, Jul 6, 2017 at 3:01 AM, Paolo Pisati wrote: > This patch adds support to the FPGA manager for programming > MachXO2 device’s internal flash memory, via slave SPI. > > Signed-off-by: Paolo Pisati > --- > drivers/fpga/Kconfig | 7

Re: [PATCH 2/2] fpga: lattice machxo2: Add Lattice MachXO2 support

2017-07-06 Thread Moritz Fischer
Hi Paolo, On Thu, Jul 6, 2017 at 3:01 AM, Paolo Pisati wrote: > This patch adds support to the FPGA manager for programming > MachXO2 device’s internal flash memory, via slave SPI. > > Signed-off-by: Paolo Pisati > --- > drivers/fpga/Kconfig | 7 ++ > drivers/fpga/Makefile | 1 +

<    2   3   4   5   6   7   8   9   10   11   >