Re: [PATCH v2 07/22] fpga: intel: pcie: parse feature list and create platform device for features.

2017-06-26 Thread Moritz Fischer
.@linux.intel.com> > Signed-off-by: Wu Hao <hao...@intel.com> > --- > v2: moved the code to drivers/fpga folder as suggested by Alan Tull. > switched to GPLv2 license. > fixed comments from Moritz Fischer. > fixed kbuild warning, typos and clean up the code. >

Re: [PATCH v2 07/22] fpga: intel: pcie: parse feature list and create platform device for features.

2017-06-26 Thread Moritz Fischer
> Signed-off-by: Zhang Yi > Signed-off-by: Xiao Guangrong > Signed-off-by: Wu Hao > --- > v2: moved the code to drivers/fpga folder as suggested by Alan Tull. > switched to GPLv2 license. > fixed comments from Moritz Fischer. > fixed kbuild warning, typo

Re: [PATCH v3 2/2] fpga: lattice machxo2: Add Lattice MachXO2 support

2017-06-15 Thread Moritz Fischer
On Thu, Jun 15, 2017 at 4:13 AM, Paolo Pisati wrote: > This patch adds support to the FPGA manager for programming > MachXO2 device’s internal flash memory, via slave SPI. > > Signed-off-by: Paolo Pisati > --- > drivers/fpga/Kconfig | 7 ++ >

Re: [PATCH v3 2/2] fpga: lattice machxo2: Add Lattice MachXO2 support

2017-06-15 Thread Moritz Fischer
On Thu, Jun 15, 2017 at 4:13 AM, Paolo Pisati wrote: > This patch adds support to the FPGA manager for programming > MachXO2 device’s internal flash memory, via slave SPI. > > Signed-off-by: Paolo Pisati > --- > drivers/fpga/Kconfig | 7 ++ > drivers/fpga/Makefile | 1 + >

Re: [PATCH] Make FPGA a menuconfig to ease disabling it all

2017-05-24 Thread Moritz Fischer
FPGA-related config entries >> >> Signed-off-by: Vincent Legoll <vincent.leg...@gmail.com> Acked-by: Moritz Fischer <m...@kernel.org> > > Signed-off-by: Alan Tull <at...@kernel.org> > >> --- >> drivers/fpga/Kconfig | 6 +- >> 1 file changed,

Re: [PATCH] Make FPGA a menuconfig to ease disabling it all

2017-05-24 Thread Moritz Fischer
On Wed, May 24, 2017 at 8:35 AM, Alan Tull wrote: > On Fri, Apr 14, 2017 at 5:39 PM, Vincent Legoll > wrote: > > Hi Vincent, > > Thanks! > > Alan > >> No need to get into the submenu to disable all FPGA-related config entries >> >> Signed-off

Re: [RFC/PATCH 1/2] dt-binding: mfd: Add Maxim/Dallas DS1374 MFD device binding

2017-05-15 Thread Moritz Fischer
On Fri, May 12, 2017 at 07:00:29PM -0500, Rob Herring wrote: > On Tue, May 09, 2017 at 11:20:20AM -0700, Moritz Fischer wrote: > > This adds a binding for the Maxim/Dallas DS1374 MFD. > > > > Signed-off-by: Moritz Fischer <m...@kernel.org> > > --- > > >

Re: [RFC/PATCH 1/2] dt-binding: mfd: Add Maxim/Dallas DS1374 MFD device binding

2017-05-15 Thread Moritz Fischer
On Fri, May 12, 2017 at 07:00:29PM -0500, Rob Herring wrote: > On Tue, May 09, 2017 at 11:20:20AM -0700, Moritz Fischer wrote: > > This adds a binding for the Maxim/Dallas DS1374 MFD. > > > > Signed-off-by: Moritz Fischer > > --- > > > > Hi all, > >

Re: [RFC/PATCH 2/2] mfd: ds1374: Add Dallas/Maxim DS1374 Multi Function Device

2017-05-09 Thread Moritz Fischer
On Tue, May 09, 2017 at 11:20:21AM -0700, Moritz Fischer wrote: > From: Moritz Fischer <moritz.fisc...@ettus.com> > > Add support for the Maxim/Dallas DS1374 RTC/WDT with trickle charger. > The device can either be configured as simple RTC, as simple RTC with > Alarm (IRQ)

Re: [RFC/PATCH 2/2] mfd: ds1374: Add Dallas/Maxim DS1374 Multi Function Device

2017-05-09 Thread Moritz Fischer
On Tue, May 09, 2017 at 11:20:21AM -0700, Moritz Fischer wrote: > From: Moritz Fischer > > Add support for the Maxim/Dallas DS1374 RTC/WDT with trickle charger. > The device can either be configured as simple RTC, as simple RTC with > Alarm (IRQ) as well as simple RTC with

[RFC/PATCH 2/2] mfd: ds1374: Add Dallas/Maxim DS1374 Multi Function Device

2017-05-09 Thread Moritz Fischer
From: Moritz Fischer <moritz.fisc...@ettus.com> Add support for the Maxim/Dallas DS1374 RTC/WDT with trickle charger. The device can either be configured as simple RTC, as simple RTC with Alarm (IRQ) as well as simple RTC with watchdog timer. Break up the old monolithic driver in drivers/r

[RFC/PATCH 2/2] mfd: ds1374: Add Dallas/Maxim DS1374 Multi Function Device

2017-05-09 Thread Moritz Fischer
From: Moritz Fischer Add support for the Maxim/Dallas DS1374 RTC/WDT with trickle charger. The device can either be configured as simple RTC, as simple RTC with Alarm (IRQ) as well as simple RTC with watchdog timer. Break up the old monolithic driver in drivers/rtc/rtc-ds1374.c into: - rtc part

[RFC/PATCH 1/2] dt-binding: mfd: Add Maxim/Dallas DS1374 MFD device binding

2017-05-09 Thread Moritz Fischer
This adds a binding for the Maxim/Dallas DS1374 MFD. Signed-off-by: Moritz Fischer <m...@kernel.org> --- Hi all, I'm not entirely sure aobut the binding, does anyone have a better suggestion for the remap-wdt-reset property? Thanks, Moritz --- Documentation/devicetree/bindings/mfd/

[RFC/PATCH 1/2] dt-binding: mfd: Add Maxim/Dallas DS1374 MFD device binding

2017-05-09 Thread Moritz Fischer
This adds a binding for the Maxim/Dallas DS1374 MFD. Signed-off-by: Moritz Fischer --- Hi all, I'm not entirely sure aobut the binding, does anyone have a better suggestion for the remap-wdt-reset property? Thanks, Moritz --- Documentation/devicetree/bindings/mfd/ds1374.txt | 63

Re: [PATCH] mfd: cros-ec: Add cros_ec_readmem() helpers for I2C/SPI based ECs

2017-05-09 Thread Moritz Fischer
om/0day-ci/linux/commits/Moritz-Fischer/mfd-cros-ec-Add-cros_ec_readmem-helpers-for-I2C-SPI-based-ECs/20170509-040606 > base: https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git > for-mfd-next > config: tile-allmodconfig > compiler: tilegx-linux-gcc (GCC) 4.6.2

Re: [PATCH] mfd: cros-ec: Add cros_ec_readmem() helpers for I2C/SPI based ECs

2017-05-09 Thread Moritz Fischer
om/0day-ci/linux/commits/Moritz-Fischer/mfd-cros-ec-Add-cros_ec_readmem-helpers-for-I2C-SPI-based-ECs/20170509-040606 > base: https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git > for-mfd-next > config: tile-allmodconfig > compiler: tilegx-linux-gcc (GCC) 4.6.2

Re: [PATCH v2 02/16] fpga: bridge: support getting bridge from device

2017-05-08 Thread Moritz Fischer
Hi Alan, On Mon, May 8, 2017 at 2:20 PM, Alan Tull <at...@kernel.org> wrote: > On Mon, May 8, 2017 at 4:11 PM, Moritz Fischer <m...@kernel.org> wrote: >> Hi Alan, >> >> On Mon, May 8, 2017 at 2:02 PM, Alan Tull <at...@kernel.org> wrote: >>> O

Re: [PATCH v2 02/16] fpga: bridge: support getting bridge from device

2017-05-08 Thread Moritz Fischer
Hi Alan, On Mon, May 8, 2017 at 2:20 PM, Alan Tull wrote: > On Mon, May 8, 2017 at 4:11 PM, Moritz Fischer wrote: >> Hi Alan, >> >> On Mon, May 8, 2017 at 2:02 PM, Alan Tull wrote: >>> On Mon, May 8, 2017 at 3:52 PM, Moritz Fischer wrote: >>>> On Mon

Re: [PATCH v2 02/16] fpga: bridge: support getting bridge from device

2017-05-08 Thread Moritz Fischer
Hi Alan, On Mon, May 8, 2017 at 2:02 PM, Alan Tull <at...@kernel.org> wrote: > On Mon, May 8, 2017 at 3:52 PM, Moritz Fischer <m...@kernel.org> wrote: >> On Mon, May 8, 2017 at 1:44 PM, Alan Tull <at...@kernel.org> wrote: >>> On Mon, May 8, 2017 at 3:44

Re: [PATCH v2 02/16] fpga: bridge: support getting bridge from device

2017-05-08 Thread Moritz Fischer
Hi Alan, On Mon, May 8, 2017 at 2:02 PM, Alan Tull wrote: > On Mon, May 8, 2017 at 3:52 PM, Moritz Fischer wrote: >> On Mon, May 8, 2017 at 1:44 PM, Alan Tull wrote: >>> On Mon, May 8, 2017 at 3:44 AM, Wu, Hao wrote: >>>>> On Wed, May 3, 2017 at 3:07 PM, Alan

Re: [PATCH v2 02/16] fpga: bridge: support getting bridge from device

2017-05-08 Thread Moritz Fischer
On Mon, May 8, 2017 at 1:44 PM, Alan Tull wrote: > On Mon, May 8, 2017 at 3:44 AM, Wu, Hao wrote: >>> On Wed, May 3, 2017 at 3:07 PM, Alan Tull wrote: >>> > On Wed, May 3, 2017 at 6:58 AM, Wu Hao wrote: >>> >> On Thu, Apr

Re: [PATCH v2 02/16] fpga: bridge: support getting bridge from device

2017-05-08 Thread Moritz Fischer
On Mon, May 8, 2017 at 1:44 PM, Alan Tull wrote: > On Mon, May 8, 2017 at 3:44 AM, Wu, Hao wrote: >>> On Wed, May 3, 2017 at 3:07 PM, Alan Tull wrote: >>> > On Wed, May 3, 2017 at 6:58 AM, Wu Hao wrote: >>> >> On Thu, Apr 20, 2017 at 09:09:47AM -0500, Alan Tull wrote: >>> >>> Add two functions

[PATCH] mfd: cros-ec: Add cros_ec_readmem() helpers for I2C/SPI based ECs

2017-05-08 Thread Moritz Fischer
Add cros_ec_readmem() based helpers for I2C/SPI based ECs. Unlike the LPC based ECs the I2C/SPI based ones cannot just directly read the mapped region. Signed-off-by: Moritz Fischer <m...@kernel.org> --- Hi Lee, I'm currently reworking my patchset for the cros-ec hwmon, and a

[PATCH] mfd: cros-ec: Add cros_ec_readmem() helpers for I2C/SPI based ECs

2017-05-08 Thread Moritz Fischer
Add cros_ec_readmem() based helpers for I2C/SPI based ECs. Unlike the LPC based ECs the I2C/SPI based ones cannot just directly read the mapped region. Signed-off-by: Moritz Fischer --- Hi Lee, I'm currently reworking my patchset for the cros-ec hwmon, and as part of the feedback there Guenter

Re: [PATCH v2 08/16] fpga: region: check for child regions before allocing image info

2017-05-05 Thread Moritz Fischer
> This is a baby step in refactoring the FPGA region code to > separate out common FPGA region code from FPGA region > Device Tree overlay support. > > Signed-off-by: Alan Tull <at...@kernel.org> Acked-by: Moritz Fischer <m...@kernel.org> > --- > v2: split out from

Re: [PATCH v2 08/16] fpga: region: check for child regions before allocing image info

2017-05-05 Thread Moritz Fischer
tep in refactoring the FPGA region code to > separate out common FPGA region code from FPGA region > Device Tree overlay support. > > Signed-off-by: Alan Tull Acked-by: Moritz Fischer > --- > v2: split out from another patch > --- > drivers/fpga/fpga-region.c | 14 +-

Re: [PATCH v2 06/16] fpga: region: remove unneeded of_node_get and put

2017-05-05 Thread Moritz Fischer
lt;at...@kernel.org> Acked-by: Moritz Fischer <m...@kernel.org> > --- > v2: split out from another patch > --- > drivers/fpga/fpga-region.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/fpga/fpga-region.c b/drivers/fpga/fpga-region.c > index eaea9d

Re: [PATCH v2 06/16] fpga: region: remove unneeded of_node_get and put

2017-05-05 Thread Moritz Fischer
On Thu, Apr 20, 2017 at 7:09 AM, Alan Tull wrote: > Remove of_node_get/put in fpga_region_get/put. Not > needed and will get in the way when I separate out > the common FPGA region code from Device Tree support > code. > > Signed-off-by: Alan Tull Acked-by: Moritz Fischer

Re: [PATCH v2 15/16] fpga: region: add fpga_region_class_find

2017-05-03 Thread Moritz Fischer
A region code from device > tree support. > > Signed-off-by: Alan Tull <at...@kernel.org> Acked-by: Moritz Fischer <m...@kernel.org> > --- > v2: split out from another patch > --- > drivers/fpga/fpga-region.c | 23 +++ > include/lin

Re: [PATCH v2 15/16] fpga: region: add fpga_region_class_find

2017-05-03 Thread Moritz Fischer
evice > tree support. > > Signed-off-by: Alan Tull Acked-by: Moritz Fischer > --- > v2: split out from another patch > --- > drivers/fpga/fpga-region.c | 23 +++ > include/linux/fpga/fpga-region.h | 4 > 2 files changed, 19 insertions(+), 8 del

Re: [PATCH v2 2/2] fpga: lattice machxo2: Add Lattice MachXO2 support

2017-05-01 Thread Moritz Fischer
Hi Paolo, couple of nits inline, looks pretty good already. On Mon, May 01, 2017 at 03:15:12PM +0200, Paolo Pisati wrote: > This patch adds support to the FPGA manager for programming > MachXO2 device’s internal flash memory, via slave SPI. > > Signed-off-by: Paolo Pisati >

Re: [PATCH v2 2/2] fpga: lattice machxo2: Add Lattice MachXO2 support

2017-05-01 Thread Moritz Fischer
Hi Paolo, couple of nits inline, looks pretty good already. On Mon, May 01, 2017 at 03:15:12PM +0200, Paolo Pisati wrote: > This patch adds support to the FPGA manager for programming > MachXO2 device’s internal flash memory, via slave SPI. > > Signed-off-by: Paolo Pisati > --- >

Re: [PATCH 0/2] DS1374 Watchdog fixes

2017-04-25 Thread Moritz Fischer
On Tue, Apr 25, 2017 at 01:22:10PM -0700, Guenter Roeck wrote: > On Tue, Apr 25, 2017 at 12:58:36PM -0700, Moritz Fischer wrote: > > On Tue, Apr 25, 2017 at 09:58:24AM -0700, Guenter Roeck wrote: > > > > > Ah, I missed the "n" in various #ifndef statements.

Re: [PATCH 0/2] DS1374 Watchdog fixes

2017-04-25 Thread Moritz Fischer
On Tue, Apr 25, 2017 at 01:22:10PM -0700, Guenter Roeck wrote: > On Tue, Apr 25, 2017 at 12:58:36PM -0700, Moritz Fischer wrote: > > On Tue, Apr 25, 2017 at 09:58:24AM -0700, Guenter Roeck wrote: > > > > > Ah, I missed the "n" in various #ifndef statements.

Re: [PATCH 0/2] DS1374 Watchdog fixes

2017-04-25 Thread Moritz Fischer
On Tue, Apr 25, 2017 at 09:58:24AM -0700, Guenter Roeck wrote: > Ah, I missed the "n" in various #ifndef statements. > > I can't really comment on how to solve that; I simply don't know. > Also, even with a dt property, it still would be necessary to have > a non-DT means to configure one or the

Re: [PATCH 0/2] DS1374 Watchdog fixes

2017-04-25 Thread Moritz Fischer
On Tue, Apr 25, 2017 at 09:58:24AM -0700, Guenter Roeck wrote: > Ah, I missed the "n" in various #ifndef statements. > > I can't really comment on how to solve that; I simply don't know. > Also, even with a dt property, it still would be necessary to have > a non-DT means to configure one or the

[PATCH] spi: cadence: Allow for GPIO pins to be used as chipselects

2017-04-25 Thread Moritz Fischer
This adds support for using GPIOs for chipselects as described by the default dt-bindings. Signed-off-by: Moritz Fischer <m...@kernel.org> --- Hi Mark, I've tested this on my Zynq-7000 based system with GPIO and non-gpio based chipselects mixed. Thanks for your time, Moritz --- drive

[PATCH] spi: cadence: Allow for GPIO pins to be used as chipselects

2017-04-25 Thread Moritz Fischer
This adds support for using GPIOs for chipselects as described by the default dt-bindings. Signed-off-by: Moritz Fischer --- Hi Mark, I've tested this on my Zynq-7000 based system with GPIO and non-gpio based chipselects mixed. Thanks for your time, Moritz --- drivers/spi/spi-cadence.c

Re: [PATCH 0/2] DS1374 Watchdog fixes

2017-04-25 Thread Moritz Fischer
Hi Guenter, On Mon, Apr 24, 2017 at 10:03 PM, Guenter Roeck <li...@roeck-us.net> wrote: > On 04/24/2017 03:05 PM, Moritz Fischer wrote: >> I'm very unhappy with the CONFIG_DRV_RTC_DS1374_WDT way of enabling >> the watchdog behavior and currently I'm investigating how to mak

Re: [PATCH 0/2] DS1374 Watchdog fixes

2017-04-25 Thread Moritz Fischer
Hi Guenter, On Mon, Apr 24, 2017 at 10:03 PM, Guenter Roeck wrote: > On 04/24/2017 03:05 PM, Moritz Fischer wrote: >> I'm very unhappy with the CONFIG_DRV_RTC_DS1374_WDT way of enabling >> the watchdog behavior and currently I'm investigating how to make >> that work v

[PATCH 1/2] rtc: ds1374: wdt: Fix issue with timeout scaling from secs to wdt ticks

2017-04-24 Thread Moritz Fischer
he correct behavior. Signed-off-by: Moritz Fischer <m...@kernel.org> --- drivers/rtc/rtc-ds1374.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-ds1374.c b/drivers/rtc/rtc-ds1374.c index 4cd115e..2a8b5b3 100644 --- a/drivers/rtc/rtc-ds1374.c +++ b/drivers/

[PATCH 1/2] rtc: ds1374: wdt: Fix issue with timeout scaling from secs to wdt ticks

2017-04-24 Thread Moritz Fischer
he correct behavior. Signed-off-by: Moritz Fischer --- drivers/rtc/rtc-ds1374.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-ds1374.c b/drivers/rtc/rtc-ds1374.c index 4cd115e..2a8b5b3 100644 --- a/drivers/rtc/rtc-ds1374.c +++ b/drivers/rtc/rtc-ds1374.c

[PATCH 0/2] DS1374 Watchdog fixes

2017-04-24 Thread Moritz Fischer
[1] https://git.kernel.org/pub/scm/linux/kernel/git/mdf/linux.git/log/?h=wip/mfd-ds1374-rfc Moritz Fischer (2): rtc: ds1374: wdt: Fix issue with timeout scaling from secs to wdt ticks rtc: ds1374: wdt: Fix stop/start ioctl always returning -EINVAL drivers/rtc/rtc-ds1374.c | 10

[PATCH 2/2] rtc: ds1374: wdt: Fix stop/start ioctl always returning -EINVAL

2017-04-24 Thread Moritz Fischer
Fix commit 920f91e50c5b ("drivers/rtc/rtc-ds1374.c: add watchdog support") The WDIOC_SETOPTIONS case in the watchdog ioctl would alwayss falls through to the -EINVAL case. This is wrong since thew watchdog does actually get stopped or started correctly. Signed-off-by: Moritz

[PATCH 2/2] rtc: ds1374: wdt: Fix stop/start ioctl always returning -EINVAL

2017-04-24 Thread Moritz Fischer
Fix commit 920f91e50c5b ("drivers/rtc/rtc-ds1374.c: add watchdog support") The WDIOC_SETOPTIONS case in the watchdog ioctl would alwayss falls through to the -EINVAL case. This is wrong since thew watchdog does actually get stopped or started correctly. Signed-off-by: Mori

[PATCH 0/2] DS1374 Watchdog fixes

2017-04-24 Thread Moritz Fischer
[1] https://git.kernel.org/pub/scm/linux/kernel/git/mdf/linux.git/log/?h=wip/mfd-ds1374-rfc Moritz Fischer (2): rtc: ds1374: wdt: Fix issue with timeout scaling from secs to wdt ticks rtc: ds1374: wdt: Fix stop/start ioctl always returning -EINVAL drivers/rtc/rtc-ds1374.c | 10

Re: [PATCH 2/3] dt-bindings: hwmon: Add bindings for Google Chromium EC HWMON

2017-04-14 Thread Moritz Fischer
On Fri, Apr 14, 2017 at 5:48 AM, Rob Herring <r...@kernel.org> wrote: > On Thu, Apr 13, 2017 at 4:07 PM, Guenter Roeck <li...@roeck-us.net> wrote: >> On Thu, Apr 13, 2017 at 03:01:40PM -0500, Rob Herring wrote: >>> On Fri, Apr 07, 2017 at 03:00:09PM -0700, Moritz Fis

Re: [PATCH 2/3] dt-bindings: hwmon: Add bindings for Google Chromium EC HWMON

2017-04-14 Thread Moritz Fischer
On Fri, Apr 14, 2017 at 5:48 AM, Rob Herring wrote: > On Thu, Apr 13, 2017 at 4:07 PM, Guenter Roeck wrote: >> On Thu, Apr 13, 2017 at 03:01:40PM -0500, Rob Herring wrote: >>> On Fri, Apr 07, 2017 at 03:00:09PM -0700, Moritz Fischer wrote: >>> > From: Moritz Fis

Re: [PATCH 1/3] mfd: cros-ec: Add functions to read mapped memory

2017-04-13 Thread Moritz Fischer
Hi Guenter, On Thu, Apr 13, 2017 at 2:03 PM, Guenter Roeck <li...@roeck-us.net> wrote: > On Fri, Apr 07, 2017 at 03:00:08PM -0700, Moritz Fischer wrote: >> From: Moritz Fischer <m...@kernel.org> >> >> The ChromeOS EC has mapped memory regions where things like tem

Re: [PATCH 1/3] mfd: cros-ec: Add functions to read mapped memory

2017-04-13 Thread Moritz Fischer
Hi Guenter, On Thu, Apr 13, 2017 at 2:03 PM, Guenter Roeck wrote: > On Fri, Apr 07, 2017 at 03:00:08PM -0700, Moritz Fischer wrote: >> From: Moritz Fischer >> >> The ChromeOS EC has mapped memory regions where things like temperature >> sensors and fan speed are stor

Re: [PATCH 00/16] Intel FPGA Device Drivers

2017-04-12 Thread Moritz Fischer
Hi Jerome, On Wed, Apr 12, 2017 at 6:29 AM, Jerome Glisse wrote: > On Tue, Apr 11, 2017 at 12:38:10PM -0700, Luebbers, Enno wrote: >> Hi Jerome, >> >> On Thu, Apr 06, 2017 at 04:27:00PM -0400, Jerome Glisse wrote: >> >> > Do we have an open source toolchain to generate the

Re: [PATCH 00/16] Intel FPGA Device Drivers

2017-04-12 Thread Moritz Fischer
Hi Jerome, On Wed, Apr 12, 2017 at 6:29 AM, Jerome Glisse wrote: > On Tue, Apr 11, 2017 at 12:38:10PM -0700, Luebbers, Enno wrote: >> Hi Jerome, >> >> On Thu, Apr 06, 2017 at 04:27:00PM -0400, Jerome Glisse wrote: >> >> > Do we have an open source toolchain to generate the FPGA configuration >>

Re: [PATCH] fpga altera-hps2fpga: disable/unprepare clock on error in alt_fpga_bridge_probe()

2017-04-11 Thread Moritz Fischer
egister() and call > > clk_disable_unprepare() in both error paths in order to make sure the > > clock gets properly disabled and unprepared. > > > > Signed-off-by: Tobias Klauser <tklau...@distanz.ch> > Acked-by: Moritz Fischer <m...@kernel.org> > Signed-off-by:

Re: [PATCH] fpga altera-hps2fpga: disable/unprepare clock on error in alt_fpga_bridge_probe()

2017-04-11 Thread Moritz Fischer
clk_disable_unprepare() in both error paths in order to make sure the > > clock gets properly disabled and unprepared. > > > > Signed-off-by: Tobias Klauser > Acked-by: Moritz Fischer > Signed-off-by: Alan Tull > > > --- > > drivers/fpga/altera-hps2fpga.c |

Re: [PATCH 1/3] mfd: cros-ec: Add functions to read mapped memory

2017-04-09 Thread Moritz Fischer
On Sun, Apr 09, 2017 at 04:02:04PM -0700, Guenter Roeck wrote: > On 04/07/2017 03:00 PM, Moritz Fischer wrote: > > From: Moritz Fischer <m...@kernel.org> > > > > The ChromeOS EC has mapped memory regions where things like temperature > > sensors and fan speed ar

Re: [PATCH 1/3] mfd: cros-ec: Add functions to read mapped memory

2017-04-09 Thread Moritz Fischer
On Sun, Apr 09, 2017 at 04:02:04PM -0700, Guenter Roeck wrote: > On 04/07/2017 03:00 PM, Moritz Fischer wrote: > > From: Moritz Fischer > > > > The ChromeOS EC has mapped memory regions where things like temperature > > sensors and fan speed are stored. Provide access

[PATCH v5] dt-bindings: fpga: Add bindings document for Xilinx LogiCore PR Decoupler

2017-04-09 Thread Moritz Fischer
This adds the binding documentation for the Xilinx LogiCORE PR Decoupler soft core. Signed-off-by: Moritz Fischer <m...@kernel.org> Signed-off-by: Michal Simek <michal.si...@xilinx.com> Acked-by: Alan Tull <at...@kernel.org> Cc: Sören Brinkmann <soren.brinkm...@xilinx.

[PATCH v5] dt-bindings: fpga: Add bindings document for Xilinx LogiCore PR Decoupler

2017-04-09 Thread Moritz Fischer
This adds the binding documentation for the Xilinx LogiCORE PR Decoupler soft core. Signed-off-by: Moritz Fischer Signed-off-by: Michal Simek Acked-by: Alan Tull Cc: Sören Brinkmann Cc: linux-kernel@vger.kernel.org Cc: devicet...@vger.kernel.org --- Changes from v4: - Ssubject line

Re: [PATCH v2] fpga fr br: update supported version numbers

2017-04-07 Thread Moritz Fischer
3 in the official release of the IP. > This patch supports the old and new version numbers, and the > driver's probe function will fail if neither of the supported > versions is found. > > Signed-off-by: Matthew Gerlach <matthew.gerl...@linux.intel.com> Reviewed-by: Moritz Fi

Re: [PATCH v2] fpga fr br: update supported version numbers

2017-04-07 Thread Moritz Fischer
P. > This patch supports the old and new version numbers, and the > driver's probe function will fail if neither of the supported > versions is found. > > Signed-off-by: Matthew Gerlach Reviewed-by: Moritz Fischer > --- > v2: change warning to fail as per Moritz Fischer

[PATCH 2/3] dt-bindings: hwmon: Add bindings for Google Chromium EC HWMON

2017-04-07 Thread Moritz Fischer
From: Moritz Fischer <m...@kernel.org> Add bindings for the Chromium EC HWMON. The Chromium EC HWMON allows monitoring of temperature sensors and fans attached to the EC. Signed-off-by: Moritz Fischer <m...@kernel.org> --- .../devicetree/bindings/hwmon/cros-ec-hwmon

[PATCH 2/3] dt-bindings: hwmon: Add bindings for Google Chromium EC HWMON

2017-04-07 Thread Moritz Fischer
From: Moritz Fischer Add bindings for the Chromium EC HWMON. The Chromium EC HWMON allows monitoring of temperature sensors and fans attached to the EC. Signed-off-by: Moritz Fischer --- .../devicetree/bindings/hwmon/cros-ec-hwmon.txt| 25 ++ 1 file changed, 25

[PATCH 3/3] hwmon: cros-ec-hwmon: Add Chromium-EC HWMON driver

2017-04-07 Thread Moritz Fischer
From: Moritz Fischer <m...@kernel.org> This adds a hwmon driver for the Chromium EC's fans and temperature sensors. Signed-off-by: Moritz Fischer <m...@kernel.org> --- This one still needs some work, but I figured some early feedback might not hurt. Specifically I was wonder

[PATCH 3/3] hwmon: cros-ec-hwmon: Add Chromium-EC HWMON driver

2017-04-07 Thread Moritz Fischer
From: Moritz Fischer This adds a hwmon driver for the Chromium EC's fans and temperature sensors. Signed-off-by: Moritz Fischer --- This one still needs some work, but I figured some early feedback might not hurt. Specifically I was wondering if using the devm_hwmon_register_with_info

[PATCH 1/3] mfd: cros-ec: Add functions to read mapped memory

2017-04-07 Thread Moritz Fischer
From: Moritz Fischer <m...@kernel.org> The ChromeOS EC has mapped memory regions where things like temperature sensors and fan speed are stored. Provide access to those from the cros-ec mfd device. Signed-off-by: Moritz Fischer <m...@kernel.org> --- drivers/platform/chrome/cros_ec_

[PATCH 1/3] mfd: cros-ec: Add functions to read mapped memory

2017-04-07 Thread Moritz Fischer
From: Moritz Fischer The ChromeOS EC has mapped memory regions where things like temperature sensors and fan speed are stored. Provide access to those from the cros-ec mfd device. Signed-off-by: Moritz Fischer --- drivers/platform/chrome/cros_ec_proto.c | 55

Re: [PATCH 5/5] fpga-region: separate out common code from dt specific code

2017-04-05 Thread Moritz Fischer
Hi Alan, first pass ... need to get back to it. On Mon, Mar 13, 2017 at 04:53:33PM -0500, Alan Tull wrote: > FPGA region is a layer above the FPGA manager and FPGA bridge > frameworks. Currently, FPGA region is dependent on device tree. > This commit separates the device tree specific code from

Re: [PATCH 5/5] fpga-region: separate out common code from dt specific code

2017-04-05 Thread Moritz Fischer
Hi Alan, first pass ... need to get back to it. On Mon, Mar 13, 2017 at 04:53:33PM -0500, Alan Tull wrote: > FPGA region is a layer above the FPGA manager and FPGA bridge > frameworks. Currently, FPGA region is dependent on device tree. > This commit separates the device tree specific code from

Re: [PATCH 4/5] fpga-mgr: separate getting/locking FPGA manager

2017-04-05 Thread Moritz Fischer
Hi Alan, minor nits, inline On Mon, Mar 13, 2017 at 04:53:32PM -0500, Alan Tull wrote: > Add fpga_mgr_lock/unlock functions that get a mutex for > exclusive use. > > of_fpga_mgr_get, fpga_mgr_get, and fpga_mgr_put no longer lock > the FPGA manager mutex. > > This makes it more straightforward

Re: [PATCH 4/5] fpga-mgr: separate getting/locking FPGA manager

2017-04-05 Thread Moritz Fischer
Hi Alan, minor nits, inline On Mon, Mar 13, 2017 at 04:53:32PM -0500, Alan Tull wrote: > Add fpga_mgr_lock/unlock functions that get a mutex for > exclusive use. > > of_fpga_mgr_get, fpga_mgr_get, and fpga_mgr_put no longer lock > the FPGA manager mutex. > > This makes it more straightforward

Re: [PATCH] fpga fr br: fix warning for unexpected version number

2017-04-05 Thread Moritz Fischer
Hi Matthew, On Wed, Apr 5, 2017 at 3:25 PM, wrote: >> Maybe you actually wanna bail out if you read a random other value >> instead of what you >> expect instead of printing a warning. > > > I thought about making it an error if the version didn't match, but it

Re: [PATCH] fpga fr br: fix warning for unexpected version number

2017-04-05 Thread Moritz Fischer
Hi Matthew, On Wed, Apr 5, 2017 at 3:25 PM, wrote: >> Maybe you actually wanna bail out if you read a random other value >> instead of what you >> expect instead of printing a warning. > > > I thought about making it an error if the version didn't match, but it was a > dev_warn() before and

Re: [PATCH] fpga fr br: fix warning for unexpected version number

2017-04-05 Thread Moritz Fischer
Hi Matthew, On Wed, Apr 5, 2017 at 12:05 PM, wrote: > From: Matthew Gerlach > > The value in the version register of the altera freeze bridge > controller changed from the beta value of 2 to the > value of 0xad03 in the

Re: [PATCH] fpga fr br: fix warning for unexpected version number

2017-04-05 Thread Moritz Fischer
Hi Matthew, On Wed, Apr 5, 2017 at 12:05 PM, wrote: > From: Matthew Gerlach > > The value in the version register of the altera freeze bridge > controller changed from the beta value of 2 to the > value of 0xad03 in the official release of the IP. > This patch supports the old and new

Re: [PATCH 1/2] doc: Add bindings document for Xilinx LogiCore PR Decoupler

2017-04-04 Thread Moritz Fischer
On Thu, Mar 30, 2017 at 05:44:29PM -0500, Rob Herring wrote: > On Fri, Mar 24, 2017 at 10:33:20AM -0500, Alan Tull wrote: > > From: Moritz Fischer <m...@kernel.org> > > Please use "dt-bindings: fpga: ..." for the subject. > > > > > > This adds the

Re: [PATCH 1/2] doc: Add bindings document for Xilinx LogiCore PR Decoupler

2017-04-04 Thread Moritz Fischer
On Thu, Mar 30, 2017 at 05:44:29PM -0500, Rob Herring wrote: > On Fri, Mar 24, 2017 at 10:33:20AM -0500, Alan Tull wrote: > > From: Moritz Fischer > > Please use "dt-bindings: fpga: ..." for the subject. > > > > > > This adds the binding documentation fo

Re: [PATCH 04/16] fpga: intel: pcie: parse feature list and create platform device for features.

2017-04-03 Thread Moritz Fischer
Xiao, few nits inline, I'll need to come back to this once I went over the rest of the patchset ;-) On Thu, Mar 30, 2017 at 08:08:04PM +0800, Wu Hao wrote: > From: Xiao Guangrong > > Device Featuer List structure creates a link list of feature headers > within

Re: [PATCH 04/16] fpga: intel: pcie: parse feature list and create platform device for features.

2017-04-03 Thread Moritz Fischer
Xiao, few nits inline, I'll need to come back to this once I went over the rest of the patchset ;-) On Thu, Mar 30, 2017 at 08:08:04PM +0800, Wu Hao wrote: > From: Xiao Guangrong > > Device Featuer List structure creates a link list of feature headers > within the MMIO space to provide an

Re: [PATCH 03/16] fpga: intel: add FPGA PCIe device driver

2017-04-03 Thread Moritz Fischer
On Thu, Mar 30, 2017 at 08:08:03PM +0800, Wu Hao wrote: > From: Zhang Yi > > The Intel FPGA device appears as a PCIe device on the system. This patch > implements the basic framework of the driver for Intel PCIe device which > locates between CPU and Accelerated Function

Re: [PATCH 03/16] fpga: intel: add FPGA PCIe device driver

2017-04-03 Thread Moritz Fischer
On Thu, Mar 30, 2017 at 08:08:03PM +0800, Wu Hao wrote: > From: Zhang Yi > > The Intel FPGA device appears as a PCIe device on the system. This patch > implements the basic framework of the driver for Intel PCIe device which > locates between CPU and Accelerated Function Units (AFUs). > >

Re: [PATCH 01/16] docs: fpga: add a document for Intel FPGA driver overview

2017-04-02 Thread Moritz Fischer
On Sat, Apr 01, 2017 at 07:16:19PM +0800, Wu Hao wrote: > On Fri, Mar 31, 2017 at 01:38:06PM -0500, Alan Tull wrote: > > On Fri, Mar 31, 2017 at 1:24 PM, wrote: > > > > > > > > > On Thu, 30 Mar 2017, Wu Hao wrote: > > > > > > > > > Hi Wu Hao, > > > > > > Great

Re: [PATCH 01/16] docs: fpga: add a document for Intel FPGA driver overview

2017-04-02 Thread Moritz Fischer
On Sat, Apr 01, 2017 at 07:16:19PM +0800, Wu Hao wrote: > On Fri, Mar 31, 2017 at 01:38:06PM -0500, Alan Tull wrote: > > On Fri, Mar 31, 2017 at 1:24 PM, wrote: > > > > > > > > > On Thu, 30 Mar 2017, Wu Hao wrote: > > > > > > > > > Hi Wu Hao, > > > > > > Great documentation. I'm looking forward

Re: [PATCH 00/16] Intel FPGA Device Drivers

2017-03-30 Thread Moritz Fischer
On Thu, Mar 30, 2017 at 08:08:00PM +0800, Wu Hao wrote: > Hi All, > > Here is a patch-series adding drivers for Intel FPGA devices. > > The Intel FPGA driver provides interfaces for userspace applications to > configure, enumerate, open, and access FPGA accelerators on platforms > equipped with

Re: [PATCH 00/16] Intel FPGA Device Drivers

2017-03-30 Thread Moritz Fischer
On Thu, Mar 30, 2017 at 08:08:00PM +0800, Wu Hao wrote: > Hi All, > > Here is a patch-series adding drivers for Intel FPGA devices. > > The Intel FPGA driver provides interfaces for userspace applications to > configure, enumerate, open, and access FPGA accelerators on platforms > equipped with

Re: [PATCH 0/5] fpga: enhancements to support non-dt code

2017-03-24 Thread Moritz Fischer
On Fri, Mar 24, 2017 at 01:09:22PM -0500, Alan Tull wrote: > On Mon, Mar 13, 2017 at 4:53 PM, Alan Tull wrote: > > Set of patches that supports writing code that uses > > FPGA regions without Device Tree overlays. > > OK here's where I try to clarify my intention for this code.

Re: [PATCH 0/5] fpga: enhancements to support non-dt code

2017-03-24 Thread Moritz Fischer
On Fri, Mar 24, 2017 at 01:09:22PM -0500, Alan Tull wrote: > On Mon, Mar 13, 2017 at 4:53 PM, Alan Tull wrote: > > Set of patches that supports writing code that uses > > FPGA regions without Device Tree overlays. > > OK here's where I try to clarify my intention for this code. And > beg for

Re: [PATCH v3 1/2] doc: Add bindings document for Xilinx LogiCore PR Decoupler

2017-03-24 Thread Moritz Fischer
On Fri, Mar 24, 2017 at 12:25:25PM -0500, Alan Tull wrote: > On Fri, Mar 24, 2017 at 10:23 AM, Moritz Fischer > <moritz.fischer.priv...@gmail.com> wrote: > > On Fri, Mar 24, 2017 at 09:59:08AM -0500, Rob Herring wrote: > >> On Fri, Mar 17, 2017 at 01:11:12PM

Re: [PATCH v3 1/2] doc: Add bindings document for Xilinx LogiCore PR Decoupler

2017-03-24 Thread Moritz Fischer
On Fri, Mar 24, 2017 at 12:25:25PM -0500, Alan Tull wrote: > On Fri, Mar 24, 2017 at 10:23 AM, Moritz Fischer > wrote: > > On Fri, Mar 24, 2017 at 09:59:08AM -0500, Rob Herring wrote: > >> On Fri, Mar 17, 2017 at 01:11:12PM -0700, Moritz Fischer wrote: > >> > Th

Re: [PATCH v3 1/2] doc: Add bindings document for Xilinx LogiCore PR Decoupler

2017-03-24 Thread Moritz Fischer
On Fri, Mar 24, 2017 at 09:59:08AM -0500, Rob Herring wrote: > On Fri, Mar 17, 2017 at 01:11:12PM -0700, Moritz Fischer wrote: > > This adds the binding documentation for the Xilinx LogiCORE PR > > Decoupler soft core. > > > > Signed-off-by: Moritz Fischer <m...@ke

Re: [PATCH v3 1/2] doc: Add bindings document for Xilinx LogiCore PR Decoupler

2017-03-24 Thread Moritz Fischer
On Fri, Mar 24, 2017 at 09:59:08AM -0500, Rob Herring wrote: > On Fri, Mar 17, 2017 at 01:11:12PM -0700, Moritz Fischer wrote: > > This adds the binding documentation for the Xilinx LogiCORE PR > > Decoupler soft core. > > > > Signed-off-by: Moritz Fischer > >

[PATCH v4 2/2] fpga: Add support for Xilinx LogiCORE PR Decoupler

2017-03-23 Thread Moritz Fischer
This adds support for the Xilinx LogiCORE PR Decoupler soft-ip that does decoupling of PR regions in the FPGA fabric during partial reconfiguration. Signed-off-by: Moritz Fischer <m...@kernel.org> Signed-off-by: Michal Simek <michal.si...@xilinx.com> Cc: Sören Brinkmann &

[PATCH v4 1/2] doc: Add bindings document for Xilinx LogiCore PR Decoupler

2017-03-23 Thread Moritz Fischer
This adds the binding documentation for the Xilinx LogiCORE PR Decoupler soft core. Signed-off-by: Moritz Fischer <m...@kernel.org> Signed-off-by: Michal Simek <michal.si...@xilinx.com> Acked-by: Alan Tull <at...@kernel.org> Cc: Sören Brinkmann <soren.brinkm...@xilinx.

[PATCH v4 2/2] fpga: Add support for Xilinx LogiCORE PR Decoupler

2017-03-23 Thread Moritz Fischer
This adds support for the Xilinx LogiCORE PR Decoupler soft-ip that does decoupling of PR regions in the FPGA fabric during partial reconfiguration. Signed-off-by: Moritz Fischer Signed-off-by: Michal Simek Cc: Sören Brinkmann Cc: linux-kernel@vger.kernel.org Cc: devicet...@vger.kernel.org

[PATCH v4 1/2] doc: Add bindings document for Xilinx LogiCore PR Decoupler

2017-03-23 Thread Moritz Fischer
This adds the binding documentation for the Xilinx LogiCORE PR Decoupler soft core. Signed-off-by: Moritz Fischer Signed-off-by: Michal Simek Acked-by: Alan Tull Cc: Sören Brinkmann Cc: linux-kernel@vger.kernel.org Cc: devicet...@vger.kernel.org --- Changes from v3: - Addressed Michal's

Re: [RFC v0 0/2] Introduce on-chip interconnect API

2017-03-22 Thread Moritz Fischer
On Tue, Mar 14, 2017 at 05:41:54PM +0200, Georgi Djakov wrote: > On 03/03/2017 08:21 AM, Rob Herring wrote: > > On Wed, Mar 01, 2017 at 08:22:33PM +0200, Georgi Djakov wrote: > > > Modern SoCs have multiple processors and various dedicated cores (video, > > > gpu, > > > graphics, modem). These

Re: [RFC v0 0/2] Introduce on-chip interconnect API

2017-03-22 Thread Moritz Fischer
On Tue, Mar 14, 2017 at 05:41:54PM +0200, Georgi Djakov wrote: > On 03/03/2017 08:21 AM, Rob Herring wrote: > > On Wed, Mar 01, 2017 at 08:22:33PM +0200, Georgi Djakov wrote: > > > Modern SoCs have multiple processors and various dedicated cores (video, > > > gpu, > > > graphics, modem). These

[PATCH] fpga: altera_freeze_bridge: Constify ops

2017-03-17 Thread Moritz Fischer
The ops are not changing, make them const. Signed-off-by: Moritz Fischer <m...@kernel.org> Cc: Alan Tull <at...@kernel.org> Cc: linux-kernel@vger.kernel.org Cc: linux-f...@vger.kernel.org --- drivers/fpga/altera-freeze-bridge.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH] fpga: altera_freeze_bridge: Constify ops

2017-03-17 Thread Moritz Fischer
The ops are not changing, make them const. Signed-off-by: Moritz Fischer Cc: Alan Tull Cc: linux-kernel@vger.kernel.org Cc: linux-f...@vger.kernel.org --- drivers/fpga/altera-freeze-bridge.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/fpga/altera-freeze-bridge.c

[PATCH v3 1/2] doc: Add bindings document for Xilinx LogiCore PR Decoupler

2017-03-17 Thread Moritz Fischer
This adds the binding documentation for the Xilinx LogiCORE PR Decoupler soft core. Signed-off-by: Moritz Fischer <m...@kernel.org> Cc: Michal Simek <michal.si...@xilinx.com> Cc: Sören Brinkmann <soren.brinkm...@xilinx.com> Cc: linux-kernel@vger.kernel.org Cc: devicet.

[PATCH v3 1/2] doc: Add bindings document for Xilinx LogiCore PR Decoupler

2017-03-17 Thread Moritz Fischer
This adds the binding documentation for the Xilinx LogiCORE PR Decoupler soft core. Signed-off-by: Moritz Fischer Cc: Michal Simek Cc: Sören Brinkmann Cc: linux-kernel@vger.kernel.org Cc: devicet...@vger.kernel.org --- Changes from v2: - Added refence to generic fpga-region bindings - Fixed

<    3   4   5   6   7   8   9   10   11   12   >