re ignored.
>
> Kernel: Linux 5.15
> Dashboard link: https://syzkaller.appspot.com/bug?extid=412c9ae97b4338c5187e
>
> ---
> [1] I expect the commit to be present in:
>
> 1. linux-5.15.y branch of
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git
--
BR,
Muhammad Usama Anjum
s with
> the same signature are ignored.
>
> Kernel: Linux 5.15
> Dashboard link: https://syzkaller.appspot.com/bug?extid=412c9ae97b4338c5187e
>
> ---
> [1] I expect the commit to be present in:
>
> 1. linux-5.15.y branch of
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git
--
BR,
Muhammad Usama Anjum
pfid is being set to tcon->crfid.fid and they are copied in each other
multiple times. Remove the memcopy between same pointers - memory
locations.
Addresses-Coverity: ("Overlapped copy")
Fixes: 9e81e8ff74b9 ("cifs: return cached_fid from open_shroot")
Signed-off-b
On Wed, 2021-04-14 at 14:00 +0200, Aurélien Aptel wrote:
> Muhammad Usama Anjum writes:
> > pfid is being set to tcon->crfid.fid and they are copied in each other
> > multiple times. Remove the memcopy between same pointers.
> >
> > Addresses-Coverity: ("Overla
pfid is being set to tcon->crfid.fid and they are copied in each other
multiple times. Remove the memcopy between same pointers.
Addresses-Coverity: ("Overlapped copy")
Fixes: 9e81e8ff74b9 ("cifs: return cached_fid from open_shroot")
Signed-off-by: Muhammad Usama Anju
symbol()")
Signed-off-by: Muhammad Usama Anjum
---
Only build has been tested.
tools/objtool/elf.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/tools/objtool/elf.c b/tools/objtool/elf.c
index d08f5f3670f8..17ee265a6c6b 100644
--- a/tools/objtool/elf.c
ASN.1 TPM2 key format for
the blobs")
Signed-off-by: Muhammad Usama Anjum
---
This is only build tested.
security/keys/trusted-keys/trusted_tpm2.c | 37 +++
1 file changed, 24 insertions(+), 13 deletions(-)
diff --git a/security/keys/trusted-keys/trusted_tpm2.c
b/securi
If btusb_mtk_submit_wmt_recv_urb returns error, wc should be freed and
then error should be returned to prevent memory leak.
Addresses-Coverity: ("Prevent memory leak")
Fixes: 4cbb375e997d ("Bluetooth: btusb: Fixed too many in-token issue for
Mediatek Chip.")
Signed-off-by:
Reminder!
On Mon, 2021-03-29 at 09:24 +0200, Juergen Gross wrote:
> On 26.03.21 19:14, Muhammad Usama Anjum wrote:
> > Correct enum pci_channel_io_normal should be used instead of putting
> > integer value 1.
> >
> > Fix following smatch warnings:
> > drivers/
ret variable is not being set if get_capacity returns 0 in very first
try. It should be initialized with 0 for this case.
Addresses-Coverity: ("Uninitialized variable")
Fixes: d3c4a43d92 ("block: refactor blk_drop_partitions")
Signed-off-by: Muhammad Usama Anjum
---
fs/b
On Thu, 2021-04-08 at 17:13 +, scan-ad...@coverity.com wrote:
> ** CID 1503714:(DEADCODE)
> /drivers/staging/rtl8723bs/os_dep/ioctl_linux.c: 367 in wpa_set_auth_algs()
> /drivers/staging/rtl8723bs/os_dep/ioctl_linux.c: 357 in wpa_set_auth_algs()
>
>
>
nlh is being checked for validtity two times when it is dereferenced in
this function. Check for validity again when updating the flags through
nlh pointer to make the dereferencing safe.
CC:
Addresses-Coverity: ("NULL pointer dereference")
Signed-off-by: Muhammad Usama Anjum
---
be
removed.
Addresses-Coverity: ("Same code execution")
Signed-off-by: Muhammad Usama Anjum
---
drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
b/drivers/staging/rtl8723bs/core/rtw_ieee80211.
ot;spi: orion: Use device_get_match_data() helper")
Signed-off-by: Muhammad Usama Anjum
---
drivers/spi/spi-orion.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/spi/spi-orion.c b/drivers/spi/spi-orion.c
index d02c5c9def20..34b31aba3981 100644
--- a/drivers/spi/spi-orion.
cpu_cs_base = hdev->core->cpu_cs_base;
> + wrapper_base = hdev->core->wrapper_base;
> +
> status = readl(wrapper_base + WRAPPER_INTR_STATUS);
> if (IS_V6(core)) {
> if (status & WRAPPER_INTR_STATUS_A2H_MASK ||
Reviewed-by: Muhammad Usama Anjum
devm_ioremap_resource() prints error message in itself. Remove the
dev_err call to avoid redundant error message.
Signed-off-by: Muhammad Usama Anjum
---
drivers/staging/axis-fifo/axis-fifo.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/axis-fifo/axis-fifo.c
b/drivers
devm_ioremap_resource() prints error message in itself. Remove the
dev_err call to avoid redundant error message.
Signed-off-by: Muhammad Usama Anjum
---
drivers/staging/media/meson/vdec/vdec.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/media
On Wed, 2021-04-07 at 16:05 +0200, Hans Verkuil wrote:
> Hi Muhammad,
>
> On 07/04/2021 12:10, Muhammad Usama Anjum wrote:
> > devm_ioremap_resource() prints error message in itself. Remove the
> > dev_err call to avoid redundant error message.
>
> Please split this u
devm_ioremap_resource() prints error message in itself. Remove the
dev_err call to avoid redundant error message.
Signed-off-by: Muhammad Usama Anjum
---
drivers/staging/axis-fifo/axis-fifo.c | 1 -
drivers/staging/media/meson/vdec/vdec.c | 8 ++--
2 files changed, 2 insertions(+), 7
devm_ioremap_resource() prints error message in itself. Remove the
dev_err call to avoid redundant error message.
Signed-off-by: Muhammad Usama Anjum
---
sound/soc/fsl/fsl_aud2htx.c | 4 +---
sound/soc/fsl/fsl_easrc.c | 4 +---
sound/soc/sunxi/sun4i-codec.c | 4 +---
3 files changed, 3
On Wed, 2021-03-31 at 13:22 +0500, Muhammad Usama Anjum wrote:
> On Wed, 2021-03-24 at 23:07 +0500, Muhammad Usama Anjum wrote:
> > If some error occurs, URB buffers should also be freed. If they aren't
> > freed with the dvb here, the em28xx_dvb_fini call doesn't frees the URB
>
mutex lock can be initialized with DEFINE_MUTEX() rather than
explicitly calling mutex_init().
Signed-off-by: Muhammad Usama Anjum
---
drivers/media/common/siano/smscoreapi.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/media/common/siano/smscoreapi.c
b
bpf_preload_lock is already defined with DEFINE_MUTEX. There is no need
to initialize it again. Remove the extraneous initialization.
Signed-off-by: Muhammad Usama Anjum
---
kernel/bpf/inode.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/kernel/bpf/inode.c b/kernel/bpf/inode.c
index
kfree should be used to free memory allocated by kzalloc to avoid
any overhead and for maintaining consistency.
Fixes: 5dfeb6d945 ("cifsd: use kmalloc() for small allocations")
Signed-off-by: Muhammad Usama Anjum
---
This one place was left in earlier patch. I've already received
kfree should be used to free memory allocated by kmalloc or kzalloc to
avoid any overhead and for maintaining consistency.
Fixes: 5dfeb6d945 ("cifsd: use kmalloc() for small allocations")
Signed-off-by: Muhammad Usama Anjum
---
fs/cifsd/buffer_pool.c | 4 ++--
fs/cifsd/mgmt/shar
-off-by: Muhammad Usama Anjum
---
fs/cifsd/mgmt/share_config.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/fs/cifsd/mgmt/share_config.c b/fs/cifsd/mgmt/share_config.c
index db780febd692..b2bd789af945 100644
--- a/fs/cifsd/mgmt/share_config.c
+++ b/fs/cifsd/mgmt
Hi,
`mode` remains uninitialized when `lane_phy_type` isn't PHY_TYPE_DP
or
PHY_TYPE_QSGMII. I've checked the dtsi (k3-j721e-common-proc-
board.dts)
and possible values of `lane_phy_type` are justPHY_TYPE_USB3 and
PHY_TYPE_PCIE. If this is correct, the mode will remain uninitialized with
On Fri, 2021-03-26 at 14:24 -0600, Shuah Khan wrote:
> On 3/25/21 5:46 AM, Muhammad Usama Anjum wrote:
> > The driver was assuming that all the parameters would be valid. But it
> > is possible that parameters are sent from userspace. For those cases,
> > appropriate error c
On Wed, 2021-03-31 at 11:48 +0300, Dan Carpenter wrote:
> On Mon, Mar 22, 2021 at 11:41:58PM +0500, Muhammad Usama Anjum wrote:
> > 1) Initialize the struct msghdr msg in the start of the function
> > 2) Uninitialized variable msg.msg_flags can get used if branch happens to
>
On Mon, 2021-03-22 at 23:41 +0500, Muhammad Usama Anjum wrote:
> 1) Initialize the struct msghdr msg in the start of the function
> 2) Uninitialized variable msg.msg_flags can get used if branch happens to
> out_free before initialization.
>
> So initialize variable in questi
On Wed, 2021-03-24 at 23:07 +0500, Muhammad Usama Anjum wrote:
> If some error occurs, URB buffers should also be freed. If they aren't
> freed with the dvb here, the em28xx_dvb_fini call doesn't frees the URB
> buffers as dvb is set to NULL. The function in which error occurs should
:got int
Signed-off-by: Muhammad Usama Anjum
---
drivers/xen/xen-pciback/pci_stub.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/xen/xen-pciback/pci_stub.c
b/drivers/xen/xen-pciback/pci_stub.c
index cb904ac83006..f8e4faa96ad6 100644
--- a/drivers/xen/xen
Signed-off-by: Muhammad Usama Anjum
---
drivers/usb/usbip/vhci_hcd.c | 25 ++---
1 file changed, 22 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/usbip/vhci_hcd.c b/drivers/usb/usbip/vhci_hcd.c
index 3209b5ddd30c..e32c080a2825 100644
--- a/drivers/usb/usbip/vhci_hcd.c
+++
The returned value by create_autodetect_quirk isn't being used other
than in the success check on next line. Remove the return value
assignement. Check for error values instead of success check.
Signed-off-by: Muhammad Usama Anjum
---
sound/usb/quirks.c | 6 +++---
1 file changed, 3 insertions
On Wed, 2021-03-24 at 21:50 +0300, Dan Carpenter wrote:
> On Wed, Mar 24, 2021 at 10:26:04PM +0500, Muhammad Usama Anjum wrote:
> > Return value of usb_driver_claim_interface should not be ignored.
> > Instead it should be stored in err variable and returned from
> > this func
On Wed, 2021-03-24 at 10:36 -0700, syzbot wrote:
> Hello,
>
> syzbot found the following issue on:
>
> HEAD commit:84196390 Merge tag 'selinux-pr-20210322' of git://git.kern..
> git tree: upstream
> console output: https://syzkaller.appspot.com/x/log.txt?x=12ea778ad0
> kernel
with the reproducer provided by syzbot. This patch
fixes the memleak.
Reported-by: syzbot+889397c820fa56adf...@syzkaller.appspotmail.com
Signed-off-by: Muhammad Usama Anjum
---
Resending the same path as some email addresses were missing from the
earlier email.
syzbot found the following issue on:
HEAD
The condition in switch statement `opcode & 0xf0` cannot evaluate to
0xff. So this case statement will never execute. Remove it.
Fixes: 6256e668b7 ("x86/kprobes: Use int3 instead of debug trap for
single-step")
Signed-off-by: Muhammad Usama Anjum
---
arch/x86/kernel/kprobes/cor
Return value of usb_driver_claim_interface should not be ignored.
Instead it should be stored in err variable and returned from
this function.
Signed-off-by: Muhammad Usama Anjum
---
sound/usb/quirks.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/usb/quirks.c b
On Mon, 2021-03-22 at 22:18 +0300, Dan Carpenter wrote:
> On Tue, Mar 23, 2021 at 12:12:04AM +0500, Muhammad Usama Anjum wrote:
> > When memory allocation for cdev is successful but ida_simple_get fails,
> > branch to out_kfree_cdev label happens and cdev isn't freed. There are
When memory allocation for cdev is successful but ida_simple_get fails,
branch to out_kfree_cdev label happens and cdev isn't freed. There are
also some other cases in which the memory can leak. Fix it by freeing cdev.
Signed-off-by: Muhammad Usama Anjum
---
Fix description
drivers/thermal
When memory allocation for cdev is successful but ida_simple_get fails,
branch to out_kfree_cdev label happens and cdev isn't freed. There are
other some other branches in which the memory can leaked. Fix it by
freeing cdev.
Signed-off-by: Muhammad Usama Anjum
---
drivers/thermal/thermal_core.c
: ("Uninitialized variable")
Addresses-Coverity: ("Uninitialized variable read")
Signed-off-by: Muhammad Usama Anjum
---
fs/io_uring.c | 10 ++
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/fs/io_uring.c b/fs/io_uring.c
index bba74631954b..d5f83326abff 100644
On Mon, 2021-03-22 at 19:54 +0500, Muhammad Usama Anjum wrote:
> If some error occurs, URB buffers should also be freed. If they aren't
> freed with the dvb here, the em28xx_dvb_fini call doesn't frees the URB
> buffers as dvb is set to NULL. The function in which error occurs should
with the reproducer provided by syzbot. This patch
fixes the memleak.
Reported-by: syzbot+889397c820fa56adf...@syzkaller.appspotmail.com
Signed-off-by: Muhammad Usama Anjum
---
drivers/media/usb/em28xx/em28xx-dvb.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/usb/em28xx/em28xx-dvb.c
b
if (!lo->workqueue) {
> error = -ENOMEM;
> goto out_unlock;
Nice catch.
Reviewed-by: Muhammad Usama Anjum
There is a spelling mistake in a comment. Fix it.
Signed-off-by: Muhammad Usama Anjum
---
arch/riscv/kernel/smp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/riscv/kernel/smp.c b/arch/riscv/kernel/smp.c
index ea028d9e0d24..1ec014067855 100644
--- a/arch/riscv/kernel
in comparison expression
(different address spaces):
arch/x86/kvm//pmu.c:522:18:struct kvm_pmu_event_filter [noderef] __rcu *
arch/x86/kvm//pmu.c:522:18:struct kvm_pmu_event_filter *
Signed-off-by: Muhammad Usama Anjum
---
arch/x86/include/asm/kvm_host.h | 4 ++--
1 file changed, 2
Sparse warnings removed:
warning: Using plain integer as NULL pointer
Signed-off-by: Muhammad Usama Anjum
---
arch/x86/kvm/x86.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
index 884e5b3838c7..3e11065038e5 100644
--- a/arch/x86/kvm
Remove a unused variable from a function.
Signed-off-by: Muhammad Usama Anjum
---
fs/afs/file.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/afs/file.c b/fs/afs/file.c
index af162d7dab5b..cf2b664a68a5 100644
--- a/fs/afs/file.c
+++ b/fs/afs/file.c
@@ -288,7 +288,6 @@ static void
On Thu, 2021-02-18 at 10:40 +0100, Greg KH wrote:
> On Thu, Feb 18, 2021 at 02:21:54PM +0500, Muhammad Usama Anjum wrote:
> > It is wrong to change the endianness of a variable which has just one
> > byte size.
> >
> > Sparse warnings fixed:
> > drivers/stagi
/i2400m/op-rfkill.c:159:14: warning: cast to restricted
__le32
drivers/staging//wimax/i2400m/op-rfkill.c:160:14: warning: cast to restricted
__le32
Signed-off-by: Muhammad Usama Anjum
---
drivers/staging/wimax/i2400m/control.c | 4 ++--
drivers/staging/wimax/i2400m/op-rfkill.c | 4 ++--
2 files
Many header files have been included, but never used. Those header
files have been removed.
Signed-off-by: Muhammad Usama Anjum
---
drivers/staging/wfx/bh.c | 1 -
drivers/staging/wfx/bh.h | 4
drivers/staging/wfx/bus.h | 3 ---
drivers/staging/wfx
> I think that "#include " is no more necessary.
Good catch. I'll send another patch.
Thanks,
Usama
happy and code simple.
Warning from sparse:
drivers/stagingwfx/hif_tx.c: note: in included file (through
drivers/stagingwfx/data_tx.h, drivers/staging//wfx/wfx.h):
drivers/staging//wfx/hif_api_cmd.h:103:26: warning: array of flexible structures
Signed-off-by: Muhammad Usama Anjum
---
drivers
> Sparse's warning is not about changing the definition of this member
> as if it was the argument of a function. It's about how can you use
> an array of structure when this structure has a flexible member.
We have the following structures in drivers/staging/rtl8192e. (I've
simplified them for
structures
drivers/staging/rtl8192e/rtllib.h:821:48: warning: array of flexible structures
Signed-off-by: Muhammad Usama Anjum
---
drivers/staging/rtl8192e/rtllib.h | 10 +-
drivers/staging/rtl8192u/ieee80211/ieee80211.h | 12 ++--
2 files changed, 11 insertions(+), 11
the warning.
Signed-off-by: Muhammad Usama Anjum
---
Changes in v3:
- Removed an empty line which I had added in v1
- Updated the commit message to include why this patch is needed
drivers/staging/octeon/octeon-stubs.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/octeon
This patch fixes the checkpatch.pl warning:
WARNING: Missing or malformed SPDX-License-Identifier tag
Add a the SPDX-License-Identifier tag on line 1
Signed-off-by: Muhammad Usama Anjum
---
Other files in this folder have GPL-2.0 license. So this file should
have the same license which
Remove a coding style error. It makes code more readable.
Signed-off-by: Muhammad Usama Anjum
---
Changes in v2:
- Aligned more lines with tabs
drivers/staging/octeon/ethernet-defines.h | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/octeon
Remove a coding style error. It makes code more readable.
Signed-off-by: Muhammad Usama Anjum
---
drivers/staging/octeon/ethernet-defines.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/octeon/ethernet-defines.h
b/drivers/staging/octeon/ethernet
This patch fixes the checkpatch.pl warning:
WARNING: Missing or malformed SPDX-License-Identifier tag
Add a the SPDX-License-Identifier tag on line 1
Signed-off-by: Muhammad Usama Anjum
---
drivers/staging/octeon/octeon-stubs.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers
62 matches
Mail list logo
