/rpmsg/rpmsg_char.c:75: warning: Function parameter or struct member
'remote_flow_updated' not described in 'rpmsg_eptdev'
Fixes: 5550201c0fe2 ("rpmsg: char: Add RPMSG GET/SET FLOWCONTROL IOCTL support")
Signed-off-by: Arnaud Pouliquen
Reviewed-by: Mukesh Ojha
-Mukesh
Although, it does not make any difference apart from a write of len
bytes, still a good improvement to do ..
Acked-by: Mukesh Ojha
-Mukesh
handler(scp->share_buf, len, ipi_desc[id].priv);
scp_ipi_unlock(scp, id);
On 4/30/2024 7:08 PM, Bjorn Andersson wrote:
On Tue, Mar 26, 2024 at 07:43:12PM +0530, Mukesh Ojha wrote:
Add qcom_rproc_minidump module in a preparation to remove
minidump specific code from driver/remoteproc/qcom_common.c
and provide needed exported API, this as well helps to
abstract
. Guards the qcom_minidump() with CONFIG_QCOM_RPROC_MINIDUMP.
3. Selects this QCOM_RPROC_MINIDUMP config when QCOM_RPROC_COMMON
enabled.
4. Added new header qcom_minidump.h .
Signed-off-by: Mukesh Ojha
---
Changes in v10:
- Converted all 3 changes sent in v9 to a single to properly
reflect
Gentle ping..
-Mukesh
On 3/26/2024 7:43 PM, Mukesh Ojha wrote:
Add qcom_rproc_minidump module in a preparation to remove
minidump specific code from driver/remoteproc/qcom_common.c
and provide needed exported API, this as well helps to
abstract minidump specific data layout from qualcomm's
As minidump specific data structure and functions move under
config QCOM_RPROC_MINIDUMP, so remove minidump specific data
from driver/remoteproc/qcom_common.c .
Signed-off-by: Mukesh Ojha
---
Changes in v9:
- Change in patch order.
- rebased it.
v8: https://lore.kernel.org/lkml
qcom_rproc_minidump() and
we will be removing qcom_minidump() and minidump related stuff
from driver/remoteproc/qcom_common.c .
Signed-off-by: Mukesh Ojha
---
Changes in v9:
- Change in patch order from its last version.
- Rebased it.
v8: https://lore.kernel.org/lkml/20240131105734.13090-1-quic_mo
() functionality from
driver/remoteproc/qcom_common.c into a separate file under
qcom_rproc_minidump().
Signed-off-by: Mukesh Ojha
---
Changes in v9:
- Added source file driver/remoteproc/qcom_common.c copyright
to qcom_rproc_minidump.c
- Dissociated it from minidump series as this can go separately
On 1/23/2024 2:21 PM, Neil Armstrong wrote:
The qlink_logging memory region is also used by the modem firmware,
add it to the reserved memories and add it to the MPSS memory regions.
Signed-off-by: Neil Armstrong
LGTM,
Reviewed-by: Mukesh Ojha
-Mukesh
---
arch/arm64/boot/dts/qcom
t;qcom,sm8550-mpss-pas", .data = _mpss_resource},
+ { .compatible = "qcom,sm8650-adsp-pas", .data = _adsp_resource},
Same as sm8550;
+ { .compatible = "qcom,sm8650-cdsp-pas", .data = _cdsp_resource},
+ { .compatible = "qcom,sm8650-mpss-pas", .data = _mpss_resource},
LGTM,
Acked-by: Mukesh Ojha
-Mukesh
{ },
};
MODULE_DEVICE_TABLE(of, adsp_of_match);
On 12/18/2023 11:40 AM, Vignesh Viswanathan wrote:
q6v5 fatal and watchdog IRQ handlers always retrieves the crash reason
information from SMEM global partition (QCOM_SMEM_HOST_ANY).
For some targets like IPQ9574 and IPQ5332, crash reason information is
present in target specific partition
, 1);
+ if (ret < 0)
+ dev_err(adsp->dev, "unassign memory failed\n");
In case you are going to send another version,
you can print offset similar to the assign call failure.,
Otherwise, LGTM.
Feel free to add.
Reviewed-by: Mukesh Ojha
-Mukesh
On 11/2/2023 3:56 PM, neil.armstr...@linaro.org wrote:
On 01/11/2023 15:42, Mukesh Ojha wrote:
On 10/31/2023 10:36 PM, Neil Armstrong wrote:
Hi,
On 30/10/2023 14:10, Mukesh Ojha wrote:
On 10/30/2023 3:33 PM, Neil Armstrong wrote:
The current memory region assign only supports
On 11/2/2023 1:30 AM, Steven Rostedt wrote:
On Mon, 30 Oct 2023 21:57:13 +0530
Mukesh Ojha wrote:
On 10/30/2023 9:45 PM, Steven Rostedt wrote:
From: "Steven Rostedt (Google)"
The eventfs_remove_rec() had some missing parameters in the kerneldoc
comment above it. Also
On 10/31/2023 10:36 PM, Neil Armstrong wrote:
Hi,
On 30/10/2023 14:10, Mukesh Ojha wrote:
On 10/30/2023 3:33 PM, Neil Armstrong wrote:
The current memory region assign only supports a single
memory region.
But new platforms introduces more regions to make the
memory requirements more
const char *name, const char *loc, ...)
Fixes: 2a588dd1d5d6 ("tracing: Add kprobe event command generation functions")
Suggested-by: Mukesh Ojha
Signed-off-by: Yujie Liu
Thanks.
Reviewed-by: Mukesh Ojha
-Mukesh
---
kernel/trace/trace_kprobe.c | 2 +-
1 file changed, 1 insertion(+),
On 10/30/2023 8:33 PM, Doug Anderson wrote:
Hi,
On Mon, Oct 30, 2023 at 7:43 AM Luca Weiss wrote:
On Mon Oct 30, 2023 at 3:11 PM CET, Doug Anderson wrote:
Hi,
On Mon, Oct 30, 2023 at 2:12 AM Luca Weiss wrote:
On Mon Oct 30, 2023 at 10:04 AM CET, Mukesh Ojha wrote:
On 10/27/2023 7
eventfs: Remove eventfs_file and just use
eventfs_inode");
Reported-by: kernel test robot
Closes:
https://lore.kernel.org/oe-kbuild-all/202310052216.4sgqaswo-...@intel.com/
Signed-off-by: Steven Rostedt (Google)
Reviewed-by: Mukesh Ojha
-Mukesh
---
fs/tracefs/event_inode.c | 6 --
On 10/30/2023 3:33 PM, Neil Armstrong wrote:
The current memory region assign only supports a single
memory region.
But new platforms introduces more regions to make the
memory requirements more flexible for various use cases.
Those new platforms also shares the memory region between the
DSP
On 10/27/2023 7:50 PM, Luca Weiss wrote:
Add the node for the ADSP found on the SC7280 SoC, using standard
Qualcomm firmware.
The memory region for sc7280-chrome-common.dtsi is taken from msm-5.4
yupik.dtsi since the other areas also seem to match that file there,
though I cannot be sure
obot
Closes:
https://lore.kernel.org/oe-kbuild-all/202310190437.pai6lyjf-...@intel.com/
Signed-off-by: Yujie Liu
Not related to this patch, but I see order of the argument as well is
not proper in the document of the __kprobe_event_gen_cmd_start(),
if you can fix that too.
LGTM, Thanks for this.
(Google)
Reviewed-by: Mukesh Ojha
-Mukesh
---
fs/tracefs/internal.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/tracefs/internal.h b/fs/tracefs/internal.h
index 298d3ecaf621..64fde9490f52 100644
--- a/fs/tracefs/internal.h
+++ b/fs/tracefs/internal.h
@@ -37,7 +37,7 @@
n., Thanks.
Reviewed-by: Mukesh ojha
-Mukesh
-
if (file) {
call = file->event_call;
system = call->class->system;
=6939
Signed-off-by: Jiapeng Chong
Reviewed-by: Mukesh Ojha
-Mukesh
---
fs/tracefs/event_inode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/tracefs/event_inode.c b/fs/tracefs/event_inode.c
index 1ccd100bc565..ba9d1cb0d24c 100644
--- a/fs/tracefs/event_inode.c
c-95f-1117-706c2c22...@inria.fr/
Fixes: 5790b1fb3d67 ("eventfs: Remove eventfs_file and just use eventfs_inode")
Reported-by: Julia Lawall
Signed-off-by: Steven Rostedt (Google)
Reviewed-by: Mukesh Ojha
-Mukesh
---
fs/tracefs/event_inode.c | 3 ++-
1 file changed, 2 inser
TM, Thanks.
Reviewed-by: Mukesh Ojha
-Mukesh
---
kernel/trace/trace_events.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c
index db46d2116500..f9e3e24d8796 100644
--- a/kernel/trace/trace_events.c
+++ b/kernel/trace/trac
Hi Kees/All,
Could you please review again? I have addressed your comment made on
last patch version.
Thanks,
Mukesh
On 3/23/2021 12:12 AM, Mukesh Ojha wrote:
There could be a scenario where we define some region
in normal memory and use them store to logs which is later
retrieved
it cacheable could improve
performance.
This commit gives control to change mem_type from Device
tree, and also documents the value for normal memory.
Signed-off-by: Mukesh Ojha
---
Changes in v3:
- Minor code and documentation update done as per comment given by Kees.
Changes in v2:
- if-else
Hi All,
can you please review this ?
Thanks,
Mukesh
On 3/2/2021 1:59 PM, Mukesh Ojha wrote:
Hi Kees,
i have updated the patch based on your last comments.
please review.
Thanks,
Mukesh
On 2/25/2021 9:30 PM, Mukesh Ojha wrote:
There could be a sceanario where we define some region
Hi Kees,
i have updated the patch based on your last comments.
please review.
Thanks,
Mukesh
On 2/25/2021 9:30 PM, Mukesh Ojha wrote:
There could be a sceanario where we define some region
in normal memory and use them store to logs which is later
retrieved by bootloader during warm reset
So add the start check to avoid.
Signed-off-by: Huang Yiwei
Signed-off-by: Mukesh Ojha
---
change in v2:
- this is on top of first patchset.
fs/pstore/ram_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/pstore/ram_core.c b/fs/pstore/ram_core.c
index 0da012f..a157
it cacheable could improve
performance.
This commit gives control to change mem_type from Device
tree, and also documents the value for normal memory.
Signed-off-by: Mukesh Ojha
---
Changes in v2:
- if-else converted to switch case
- updated MODULE_PARM_DESC with new memory type.
- default setting
From: Mukesh Ojha
There could be a sceanario where we define some region
in normal memory and use them store to logs which is later
retrieved by bootloader during warm reset.
In this scenario, we wanted to treat this memory as normal
cacheable memory instead of default behaviour which
So add the start check to avoid.
Signed-off-by: Huang Yiwei
Signed-off-by: Mukesh Ojha
---
change in v2:
- this is on top of first patchset.
fs/pstore/ram_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/pstore/ram_core.c b/fs/pstore/ram_core.c
index 0da012f..a157
On 2/11/2021 1:47 AM, Kees Cook wrote:
On Wed, Feb 10, 2021 at 08:22:21PM +0530, Mukesh Ojha wrote:
There could be a sceanario where we define some region
in normal memory and use them store to logs which is later
retrieved by bootloader during warm reset.
In this scenario, we wanted
On 2/10/2021 2:32 AM, Luck, Tony wrote:
Can we use existing backend pstore ram driver (fs/pstore/ram.c) for DDR
instead of SRAM ?
The expectation for pstore is that the system will go through a reset when it
crashes. Most systems do not preserve DDR contents across reset.
to support DDR, If
it cacheable could improve
performance.
This commit gives control to change mem_type from Device
tree, and also documents the value for normal memory.
Signed-off-by: Huang Yiwei
Signed-off-by: Mukesh Ojha
---
Documentation/admin-guide/ramoops.rst | 4 +++-
fs/pstore/ram.c | 1
Hi All,
Can we use existing backend pstore ram driver (fs/pstore/ram.c) for DDR
instead of SRAM ?
Was the current driver written only to support persistant RAM like SRAM
or it can accept further change
to support DDR, If we have a mechanism to copy stored data from DDR to
external device
Cooling stats variable inside thermal_cooling_device_stats_update()
can get NULL. We should add a NULL check on stat inside for sanity.
Signed-off-by: Mukesh Ojha
---
drivers/thermal/thermal_sysfs.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/thermal/thermal_sysfs.c b/drivers
iterrupts => interrupts
stratight => straight
Minor comment correction.
Signed-off-by: Mukesh Ojha
---
kernel/sched/idle.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/sched/idle.c b/kernel/sched/idle.c
index 8dad5aa..2df8ae1 100644
--- a/kernel/sched/
witin => within
Signed-off-by: Mukesh Ojha
---
kernel/time/time.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/time/time.c b/kernel/time/time.c
index 5c54ca6..d31661c4 100644
--- a/kernel/time/time.c
+++ b/kernel/time/time.c
@@ -179,7 +179,7 @@
accuratly => accurately
while at it change `clock source` to clocksource to make
it align with its usage at other places.
Signed-off-by: Mukesh Ojha
---
kernel/time/jiffies.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/time/jiffies.c b/kernel/time/jiffie
write_seqcountbeqin => write_seqcount_begin
Signed-off-by: Mukesh Ojha
---
include/linux/seqlock.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/seqlock.h b/include/linux/seqlock.h
index bcf4cf2..370ef8f 100644
--- a/include/linux/seqlock.h
+++ b/incl
On 8/12/2019 4:12 PM, Jiri Olsa wrote:
On Fri, Aug 02, 2019 at 12:16:53AM +0530, Mukesh Ojha wrote:
Perf framework doesn't allow preserving CPU events across
CPU hotplugs. The events are scheduled out as and when the
CPU walks offline. Moreover, the framework also doesn't
allow the clients
On 9/11/2019 8:51 PM, Colin King wrote:
From: Colin Ian King
There is a spelling mistake in a TEST_ASSERT_VAL message. Fix it.
Signed-off-by: Colin Ian King
Reviewed-by: Mukesh Ojha
Thanks,
Mukesh
---
tools/perf/tests/event_update.c | 2 +-
1 file changed, 1 insertion(+), 1
On 8/12/2019 4:12 PM, Jiri Olsa wrote:
On Fri, Aug 02, 2019 at 12:16:53AM +0530, Mukesh Ojha wrote:
Perf framework doesn't allow preserving CPU events across
CPU hotplugs. The events are scheduled out as and when the
CPU walks offline. Moreover, the framework also doesn't
allow the clients
-by: Mukesh Ojha
Thanks,
Mukesh
---
tools/perf/builtin-annotate.c |5 +++--
tools/perf/builtin-buildid-cache.c |5 +++--
tools/perf/builtin-buildid-list.c |5 +++--
tools/perf/builtin-c2c.c |6 --
tools/perf/builtin-diff.c |9 +
tools
Commit-ID: a037d269221c0ae15f47046757afcbd1a7177bbf
Gitweb: https://git.kernel.org/tip/a037d269221c0ae15f47046757afcbd1a7177bbf
Author: Mukesh Ojha
AuthorDate: Wed, 31 Jul 2019 20:35:04 +0530
Committer: Peter Zijlstra
CommitDate: Tue, 6 Aug 2019 12:49:16 +0200
locking/mutex: Use mutex
Commit-ID: 5f35d5a66b3ec62cb5ec4ec2ad9aebe2ac325673
Gitweb: https://git.kernel.org/tip/5f35d5a66b3ec62cb5ec4ec2ad9aebe2ac325673
Author: Mukesh Ojha
AuthorDate: Wed, 31 Jul 2019 20:35:03 +0530
Committer: Peter Zijlstra
CommitDate: Tue, 6 Aug 2019 12:49:16 +0200
locking/mutex: Make
On 8/1/2019 8:58 AM, Masanari Iida wrote:
This patch fix a spelling typo in Makefile.
Signed-off-by: Masanari Iida
Reviewed-by: Mukesh Ojha
-Mukesh
---
tools/perf/Documentation/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/Documentation
Shishkin
Cc: Jiri Olsa
Cc: Alexei Starovoitov
Mukesh Ojha (1):
perf: event preserve and create across cpu hotplug
include/linux/perf_event.h | 1 +
kernel/events/core.c | 122 +
2 files changed, 79 insertions(+), 44 deletions(-)
--
Q
-by: Mukesh Ojha
Cc: Peter Zijlstra
Cc: Ingo Molnar
Cc: Arnaldo Carvalho de Melo
Cc: Alexander Shishkin
Cc: Jiri Olsa
Cc: Alexei Starovoitov
---
Change in V5:
=
- Rebased it.
Change in V4:
=
- Released, __get_cpu_context would not be correct way to get the
cpu
Use the mutex flag macro instead of hard code value inside
__mutex_owner().
Signed-off-by: Mukesh Ojha
---
Changes in v3:
- no change.
Changes in v2:
- Framed the commit according the changes done in 1/2 of
the patchset.
kernel/locking/mutex.c | 2 +-
1 file changed, 1 insertion(+), 1
intact move them as well and
export them.
Move mutex_waiter structure also to keep it private to the
file.
Signed-off-by: Mukesh Ojha
---
Changes in v3:
- Moved mutex_waiter and removed inline from mutex_trylock_recursive()
mutex_is_owner().
Changes in v2:
- On Peterz suggestion, moved
On 7/30/2019 9:32 PM, Peter Zijlstra wrote:
On Tue, Jul 30, 2019 at 06:10:49PM +0530, Mukesh Ojha wrote:
To make it static , i have to export mutex_is_locked() after moving it
inside mutex.c, so that other module can use it.
Yep, see below -- completely untested.
Also are we thinking
Use the mutex flag macro instead of hard code value inside
__mutex_owner().
Signed-off-by: Mukesh Ojha
---
Changes in v2:
- Framed the commit according the changes done in 1/2 of
the patchset.
kernel/locking/mutex.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel
move them as well and
export them.
Signed-off-by: Mukesh Ojha
---
Changes in v2:
- On Peterz suggestion, moved __mutex_owner() to mutex.c to
make it static to mutex.c.
- Exported mutex_is_owner() and mutex_trylock_recursive()
to keep the existing thing intact as there are loadable
modules
On 7/30/2019 1:33 PM, Peter Zijlstra wrote:
On Tue, Jul 30, 2019 at 01:23:13PM +0530, Mukesh Ojha wrote:
On 7/29/2019 4:37 PM, Peter Zijlstra wrote:
On Mon, Jul 29, 2019 at 04:22:58PM +0530, Mukesh Ojha wrote:
Let's use the mutex flag macro(which got moved from mutex.c
to linux/mutex.h
On 7/29/2019 4:37 PM, Peter Zijlstra wrote:
On Mon, Jul 29, 2019 at 04:22:58PM +0530, Mukesh Ojha wrote:
Let's use the mutex flag macro(which got moved from mutex.c
to linux/mutex.h in the last patch) instead of hard code
value which was used in __mutex_owner().
Signed-off-by: Mukesh Ojha
Let's use the mutex flag macro(which got moved from mutex.c
to linux/mutex.h in the last patch) instead of hard code
value which was used in __mutex_owner().
Signed-off-by: Mukesh Ojha
---
include/linux/mutex.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux
There exist a place where we use hard code value for mutex
flag(e.g in mutex.h __mutex_owner()). Let's move the mutex
flag macros to header linux/mutex.h, so that it could be
reused at other places as well.
Signed-off-by: Mukesh Ojha
---
include/linux/mutex.h | 15 +++
kernel
There is a spelling mistake in file tree_exp.h,
fix this.
Signed-off-by: Mukesh Ojha
---
kernel/rcu/tree_exp.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/rcu/tree_exp.h b/kernel/rcu/tree_exp.h
index af7e7b9..609fc87 100644
--- a/kernel/rcu/tree_exp.h
+++ b/kernel
Hi All,
Can you please review this ?
Thanks,
Mukesh
On 6/24/2019 2:31 PM, Mukesh Ojha wrote:
Friendly ping.
On 6/18/2019 7:16 PM, Mukesh Ojha wrote:
The embedded world, specifically Android mobile SoCs, rely on CPU
hotplugs to manage power and thermal constraints. These hotplugs
can happen
On 7/24/2019 7:11 PM, Mukesh Ojha wrote:
On 7/18/2019 4:49 PM, Muchun Song wrote:
There is a race condition between removing glue directory and adding
a new
device under the glue directory. It can be reproduced in following test:
path 1: Add the child device under glue dir
device_add
n many pattern of this issue which is coming from different
driver e.g uinput as well in 4.14
kernel.(https://lkml.org/lkml/2019/4/10/146)
The reason why it started coming after
726e41097920 ("drivers: core: Remove glue dirs from sysfs earlier")
Looks good to me
Reviewed-by: Mukesh Ojha
-Mukesh
kobject_del(glue_dir);
kobject_put(glue_dir);
mutex_unlock(_mutex);
Friendly Ping.
More explanation of the usecase added in the coverletter
[PATCH RESEND V4 0/1] perf: Add CPU hotplug support for events.
-Mukesh
On 6/18/2019 7:16 PM, Mukesh Ojha wrote:
Perf framework doesn't allow preserving CPU events across
CPU hotplugs. The events are scheduled out
On 6/28/2019 10:29 PM, Mark Rutland wrote:
On Fri, Jun 28, 2019 at 10:23:10PM +0530, Mukesh Ojha wrote:
Hi All,
Hi Mukesh,
Is it looks considerable to add cluster based event support to add in
current perf event framework and later in userspace perf to support
such events ?
Could you
Hi All,
Is it looks considerable to add cluster based event support to add in
current perf event framework and later
in userspace perf to support such events ?
Thanks,
Mukesh
Friendly ping.
On 6/18/2019 7:16 PM, Mukesh Ojha wrote:
The embedded world, specifically Android mobile SoCs, rely on CPU
hotplugs to manage power and thermal constraints. These hotplugs
can happen at a very rapid pace. Adjacently, they also relies on
many perf event counters for its management
-by: Mukesh Ojha
Cc: Peter Zijlstra
Cc: Ingo Molnar
Cc: Arnaldo Carvalho de Melo
Cc: Alexander Shishkin
Cc: Jiri Olsa
Cc: Alexei Starovoitov
---
Change in V4:
=
- Released, __get_cpu_context would not be correct way to get the
cpu context of the cpu which is offline, instead use
243819 cycles
9.6300522877102438 cycles
9.839848225 337454 cycles
10.049645048 644072 cycles
10.2594762461855410 cycles
Mukesh Ojha (1):
perf: event preserve and create across cpu hotplug
On 6/18/2019 5:53 PM, Peter Zijlstra wrote:
On Tue, Jun 18, 2019 at 02:24:51PM +0530, Mukesh Ojha wrote:
Perf framework doesn't allow preserving CPU events across
CPU hotplugs. The events are scheduled out as and when the
CPU walks offline. Moreover, the framework also doesn't
allow
-by: Mukesh Ojha
Cc: Peter Zijlstra
Cc: Ingo Molnar
Cc: Arnaldo Carvalho de Melo
Cc: Alexander Shishkin
Cc: Jiri Olsa
Cc: Alexei Starovoitov
---
Change in V4:
=
- Released, __get_cpu_context would not be correct way to get the
cpu context of the cpu which is offline, instead use
-by: Mukesh Ojha
Cc: Peter Zijlstra
Cc: Ingo Molnar
Cc: Arnaldo Carvalho de Melo
Cc: Alexander Shishkin
Cc: Jiri Olsa
Cc: Alexei Starovoitov
---
Change in V3:
- Jiri has tried perf stat -a and removed one of the cpu from the other
terminal. This resulted in a crash. Crash was because
On 6/3/2019 11:23 PM, Jiri Olsa wrote:
On Fri, May 31, 2019 at 07:09:16PM +0530, Mukesh Ojha wrote:
Perf framework doesn't allow preserving CPU events across
CPU hotplugs. The events are scheduled out as and when the
CPU walks offline. Moreover, the framework also doesn't
allow the clients
-by: Mukesh Ojha
Cc: Peter Zijlstra
Cc: Ingo Molnar
Cc: Arnaldo Carvalho de Melo
Cc: Alexander Shishkin
Cc: Jiri Olsa
Cc: Alexei Starovoitov
---
Change in V2:
As per long back discussion happened at
https://lkml.org/lkml/2018/2/15/1324
Peter.Z. has suggested to do thing in different way
243819 cycles
9.6300522877102438 cycles
9.839848225 337454 cycles
10.049645048 644072 cycles
10.2594762461855410 cycles
Mukesh Ojha (1):
perf: event preserve and create across cpu hotplug
Friendly Ping.
On 5/23/2019 6:39 PM, Mukesh Ojha wrote:
Hi Peter/All,
This is regarding the discussion happen in the past about
https://lkml.org/lkml/2018/2/15/1324
Where the exact ask is to allow preserving and creation of events on a
offline CPU, so that when the CPU
comes online
Hi Peter/All,
This is regarding the discussion happen in the past about
https://lkml.org/lkml/2018/2/15/1324
Where the exact ask is to allow preserving and creation of events on a
offline CPU, so that when the CPU
comes online it will start counting.
I had a look at your patch too and
entry_SYSCALL_64_after_hwframe+0x49/0xbe
Reported-by: Hulk Robot
Fixes: 702a4879ec33 ("spi: bitbang: Let spi_bitbang_start() take a reference to
master")
Signed-off-by: YueHaibing
Reviewed-by: Mukesh Ojha
Cheers,
-Mukesh
---
drivers/spi/spi-bitbang.c | 2 +-
1 file changed, 1 insertion(+), 1 deletio
On 5/15/2019 9:47 PM, parna.naveenku...@gmail.com wrote:
From: Naveen Kumar Parna
checkpatch.pl does not like assignment in if condition
Signed-off-by: Naveen Kumar Parna
Reviewed-by: Mukesh Ojha
Cheers,
-Mukesh
---
Changes in v3:
The first patch has an extra space in if statement, so
/ClangBuiltLinux/linux/issues/481
Signed-off-by: Nathan Chancellor
Nice catch.
Reviewed-by: Mukesh Ojha
Cheers,
-Mukesh
---
tools/objtool/Makefile | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tools/objtool/Makefile b/tools/objtool/Makefile
index 53f8be0f4a1f..88158239622b
On 5/15/2019 2:27 AM, Colin King wrote:
From: Colin Ian King
There is a spelling mistake in a warning message. Fix it.
Signed-off-by: Colin Ian King
Reviewed-by: Mukesh Ojha
Cheers,
-Mukesh
---
drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c | 2 +-
1 file changed, 1 insertion
++
On 5/4/2019 8:17 PM, Muchun Song wrote:
Benjamin Herrenschmidt 于2019年5月2日周四 下午2:25写道:
The basic idea yes, the whole bool *locked is horrid though.
Wouldn't it
work to have a get_device_parent_locked that always returns with
the mutex held,
or just move the mutex to the caller or something
On 5/1/2019 3:53 PM, Colin King wrote:
From: Colin Ian King
There is a spelling mistake in a hda_dsp_rom_msg message, fix it.
Signed-off-by: Colin Ian King
Reviewed-by: Mukesh Ojha
Cheers,
-Mukesh
---
sound/soc/sof/intel/hda.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion
Sorry to come late on this
On 4/25/2019 4:26 AM, Al Viro wrote:
On Wed, Apr 24, 2019 at 07:39:03PM +0530, Mukesh Ojha wrote:
This was my simple program no multithreading just to understand f_counting
int main()
{
int fd = open("/dev/uinput", O_WRONLY | O_NONBLOCK);
On 4/30/2019 8:26 PM, Jonathan Neuschäfer wrote:
"sysfs" was misspelled in a comment and a log message.
Signed-off-by: Jonathan Neuschäfer
Reviewed-by: Mukesh Ojha
Cheers,
-Mukesh
---
drivers/base/firmware_loader/fallback.c | 6 +++---
1 file changed, 3 insertions(+), 3
On 4/24/2019 6:37 PM, Al Viro wrote:
On Wed, Apr 24, 2019 at 05:40:40PM +0530, Mukesh Ojha wrote:
Al,
i tried to put traceprintk inside ioctl after fdget and fdput on a simple
call of open => ioctl => close
in a loop, and multithreaded, presumably?
on /dev/uinput.
uinp
On 4/23/2019 4:36 PM, Al Viro wrote:
On Tue, Apr 23, 2019 at 08:49:44AM +, dmitry.torok...@gmail.com wrote:
On Tue, Apr 23, 2019 at 12:51:13PM +0530, Mukesh Ojha wrote:
I have taken care this case from ioctl and release point of view.
Even if the release gets called first it will make
On 4/24/2019 8:20 AM, YueHaibing wrote:
Remove duplicated include.
Signed-off-by: YueHaibing
Reviewed-by: Mukesh Ojha
Cheers,
-Mukesh
---
drivers/staging/kpc2000/kpc2000/kp2000_module.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/kpc2000/kpc2000/kp2000_module.c
On 4/19/2019 12:41 PM, dmitry.torok...@gmail.com wrote:
Hi Mukesh,
On Fri, Apr 19, 2019 at 12:17:44PM +0530, Mukesh Ojha wrote:
For some reason my last mail did not get delivered, sending it again.
On 4/18/2019 11:55 AM, Mukesh Ojha wrote:
On 4/18/2019 7:13 AM, dmitry.torok...@gmail.com
On 4/18/2019 11:08 PM, Colin King wrote:
From: Colin Ian King
There is a spelling mistake on the TEST_UNSUPPORTED macro. Fix this.
Signed-off-by: Colin Ian King
Reviewed-by: Mukesh Ojha
Cheers,
-Mukesh
---
arch/arm/probes/kprobes/test-thumb.c | 2 +-
1 file changed, 1 insertion
On 4/18/2019 5:50 PM, Colin King wrote:
From: Colin Ian King
There are multiple spelling mistakes in variable names, fix these.
Signed-off-by: Colin Ian King
Well, this one a bit sensitive to touch.
Reviewed-by: Mukesh Ojha
Cheers,
-Mukesh
---
drivers/staging/rtl8723bs/hal
On 4/18/2019 3:45 PM, Colin King wrote:
From: Colin Ian King
There is a spelling mistake in the documentation. Fix it.
Signed-off-by: Colin Ian King
Reviewed-by: Mukesh Ojha
Cheers,
-Mukesh
---
Documentation/ABI/testing/sysfs-devices-platform-ipmi | 2 +-
1 file changed, 1 insertion
sue in the function
stm_source_register_device. This patch fixes these issues.
Signed-off-by: Pan Bian
Looks good to me.
Reviewed-by: Mukesh Ojha
Cheers,
-Mukesh
---
drivers/hwtracing/stm/core.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/hwtracing/stm/cor
On 4/17/2019 5:30 PM, Colin King wrote:
From: Colin Ian King
There is a spelling mistake in an RT_TRACE message, fix it.
Signed-off-by: Colin Ian King
Reviewed-by: Mukesh Ojha
Cheers,
-Mukesh
---
drivers/staging/rtl8723bs/core/rtw_ioctl_set.c | 2 +-
1 file changed, 1 insertion
On 4/17/2019 5:38 PM, Colin King wrote:
From: Colin Ian King
There are two spelling mistake in RT_TRACE messages. Fix them.
Signed-off-by: Colin Ian King
Reviewed-by: Mukesh Ojha
Cheers,
-Mukesh
---
drivers/staging/rtlwifi/btcoexist/halbtc8822b1ant.c | 4 ++--
1 file changed, 2
On 4/17/2019 4:25 PM, Colin King wrote:
From: Colin Ian King
There are a couple of spelling mistakes in test assert messages. Fix them.
Signed-off-by: Colin Ian King
Well, how are you shooting these mistakes one after the other?
Reviewed-by: Mukesh Ojha
Cheers,
-Mukesh
---
tools
On 4/16/2019 7:03 PM, Colin King wrote:
From: Colin Ian King
There is a spelling mistake in a pr_debug message. Fix it.
Signed-off-by: Colin Ian King
Reviewed-by: Mukesh Ojha
Cheers,
-Mukesh
---
drivers/watchdog/intel_scu_watchdog.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion
On 4/16/2019 5:26 PM, Colin King wrote:
From: Colin Ian King
There are a few spelling mistakes in comments and a pr_err
error message. Fix these.
Signed-off-by: Colin Ian King
Reviewed-by: Mukesh Ojha
Cheers,
-Mukesh
---
drivers/clk/mvebu/common.c | 2 +-
drivers
1 - 100 of 377 matches
Mail list logo