[GIT PULL] Please pull NFS client bugfixes

2013-11-16 Thread Myklebust, Trond
Hi Linus The following changes since commit fab99ebe39fe7d11fbd9b5fb84f07432af9ba36f: NFSv4.2: Remove redundant checks in nfs_setsecurity+nfs4_label_init_security (2013-11-04 16:42:52 -0500) are available in the git repository at: git://git.linux-nfs.org/projects/trondmy/linux-nfs.git tags

[GIT PULL] Please pull NFS client changes for 3.13

2013-11-07 Thread Myklebust, Trond
Hi Linus, The following changes since commit f927318840745095cc7003f1564ca4b87655745d: Merge tag 'nfs-for-3.12-4' of git://git.linux-nfs.org/projects/trondmy/linux-nfs (2013-09-30 17:10:26 -0700) are available in the git repository at: git://git.linux-nfs.org/projects/trondmy/linux-nfs.gi

Re: 3.12-rcX - NFS regression - kswapd0 / kswapd1 stays using 100% CPU?

2013-10-18 Thread Myklebust, Trond
On Fri, 2013-10-18 at 22:03 +0200, Helge Deller wrote: > On 10/18/2013 09:36 PM, Myklebust, Trond wrote: > > Also, could you please try a sysRQ-t the next time it happens, so that > > we can get a trace of where the mount program is hanging. Knowing that > > the mount is stuck

Re: 3.12-rcX - NFS regression - kswapd0 / kswapd1 stays using 100% CPU?

2013-10-18 Thread Myklebust, Trond
On Fri, 2013-10-18 at 21:26 +0200, Helge Deller wrote: > On 10/17/2013 11:07 PM, Myklebust, Trond wrote: > > On Thu, 2013-10-17 at 22:42 퍭, Helge Deller wrote: > >> I'm seeing a regression with current kernel git head when using NFS-mounts. > >> Architecture in my

Re: 3.12-rcX - NFS regression - kswapd0 / kswapd1 stays using 100% CPU?

2013-10-17 Thread Myklebust, Trond
On Thu, 2013-10-17 at 22:42 +0200, Helge Deller wrote: > I'm seeing a regression with current kernel git head when using NFS-mounts. > Architecture in my case is parisc, although I don't think that this is > relevant. > At least kernel 3.10 (and I think 3.11) didn't showed that problem. > > The s

[GIT PULL] Please pull NFS client bugfixes

2013-09-30 Thread Myklebust, Trond
Hi Linus, The following changes since commit 4a10c2ac2f368583138b774ca41fac4207911983: Linux 3.12-rc2 (2013-09-23 15:41:09 -0700) are available in the git repository at: git://git.linux-nfs.org/projects/trondmy/linux-nfs.git tags/nfs-for-3.12-4 for you to fetch changes up to 367156d9a87b2

Re: [RFC] extending splice for copy offloading

2013-09-30 Thread Myklebust, Trond
On Mon, 2013-09-30 at 16:08 -0400, Ric Wheeler wrote: > On 09/30/2013 04:00 PM, Bernd Schubert wrote: > > pNFS, FhGFS, Lustre, Ceph, etc., all of them shall implement their own > > interface? And userspace needs to address all of them differently? > > The NFS and SCSI groups have each defined a

Re: [RFC] extending splice for copy offloading

2013-09-30 Thread Myklebust, Trond
On Mon, 2013-09-30 at 22:00 +0200, Bernd Schubert wrote: > On 09/30/2013 09:34 PM, Myklebust, Trond wrote: > > On Mon, 2013-09-30 at 20:49 +0200, Bernd Schubert wrote: > >> On 09/30/2013 08:02 PM, Myklebust, Trond wrote: > >>> On Mon, 2013-09-30 at 19:48 +0200, Bern

Re: [RFC] extending splice for copy offloading

2013-09-30 Thread Myklebust, Trond
On Mon, 2013-09-30 at 20:49 +0200, Bernd Schubert wrote: > On 09/30/2013 08:02 PM, Myklebust, Trond wrote: > > On Mon, 2013-09-30 at 19:48 +0200, Bernd Schubert wrote: > >> On 09/30/2013 07:44 PM, Myklebust, Trond wrote: > >>> On Mon, 2013-09-30 at 19:17 +0200, B

Re: [RFC] extending splice for copy offloading

2013-09-30 Thread Myklebust, Trond
On Mon, 2013-09-30 at 19:48 +0200, Bernd Schubert wrote: > On 09/30/2013 07:44 PM, Myklebust, Trond wrote: > > On Mon, 2013-09-30 at 19:17 +0200, Bernd Schubert wrote: > >> It would be nice if there would be way if the file system would get a > >> hint that the target

Re: [RFC] extending splice for copy offloading

2013-09-30 Thread Myklebust, Trond
On Mon, 2013-09-30 at 19:17 +0200, Bernd Schubert wrote: > It would be nice if there would be way if the file system would get a > hint that the target file is supposed to be copy of another file. That > way distributed file systems could also create the target-file with the > correct meta-infor

RE: [RFC] extending splice for copy offloading

2013-09-30 Thread Myklebust, Trond
> -Original Message- > From: Ric Wheeler [mailto:rwhee...@redhat.com] > Sent: Monday, September 30, 2013 10:29 AM > To: Miklos Szeredi > Cc: J. Bruce Fields; Myklebust, Trond; Zach Brown; Anna Schumaker; Kernel > Mailing List; Linux-Fsdevel; linux-...@vger.kernel.org

RE: [RFC] extending splice for copy offloading

2013-09-28 Thread Myklebust, Trond
> -Original Message- > From: Miklos Szeredi [mailto:mik...@szeredi.hu] > Sent: Saturday, September 28, 2013 12:50 AM > To: Zach Brown > Cc: J. Bruce Fields; Ric Wheeler; Anna Schumaker; Kernel Mailing List; Linux- > Fsdevel; linux-...@vger.kernel.org; Myklebust, Trond

RE: [PATCH 3/4] SunRPC: Use no_printk() for the null dprintk() and dfprintk()

2013-09-26 Thread Myklebust, Trond
> -Original Message- > From: David Howells [mailto:dhowe...@redhat.com] > Sent: Thursday, September 26, 2013 10:36 AM > To: Joe Perches > Cc: dhowe...@redhat.com; bfie...@fieldses.org; Myklebust, Trond; > o...@lixom.net; linux-...@vger.kernel.org; linux-kernel@vger.kernel

RE: [RFC][PATCH 0/4] SunRPC/NFS: Use no_printk() in

2013-09-26 Thread Myklebust, Trond
> -Original Message- > From: J. Bruce Fields [mailto:bfie...@fieldses.org] > Sent: Thursday, September 26, 2013 10:21 AM > To: David Howells > Cc: Myklebust, Trond; o...@lixom.net; linux-...@vger.kernel.org; linux- > ker...@vger.kernel.org > Subject: Re: [RFC][PATCH

[GIT PULL] Please pull an NFS client bugfix

2013-09-21 Thread Myklebust, Trond
Hi Linus, The following changes since commit 272b98c6455f00884f0350f775c5342358ebb73f: Linux 3.12-rc1 (2013-09-16 16:17:51 -0400) are available in the git repository at: git://git.linux-nfs.org/projects/trondmy/linux-nfs.git tags/nfs-for-3.12-3 for you to fetch changes up to a0f6ed8ebe4f6d

Re: Kernel size increase of +256 KiB (was: Re: RPCSEC_GSS: Share all credential caches on a per-transport basis)

2013-09-12 Thread Myklebust, Trond
On Thu, 2013-09-12 at 21:20 +0200, Geert Uytterhoeven wrote: > On Thu, Sep 12, 2013 at 4:13 PM, Myklebust, Trond > wrote: > >> > --- a/net/sunrpc/auth_gss/auth_gss.c > >> > +++ b/net/sunrpc/auth_gss/auth_gss.c > >> > @@ -51,6 +51,7 @@ > >&

[GIT PULL] Please pull NFS client changes (part 2)

2013-09-12 Thread Myklebust, Trond
Hi Linus, The following changes since commit b1b3e136948a2bf4915326acb0d825d7d180753f: NFSv4: use mach cred for SECINFO_NO_NAME w/ integrity (2013-09-07 18:39:25 -0400) are available in the git repository at: git://git.linux-nfs.org/projects/trondmy/linux-nfs.git tags/nfs-for-3.12-2 for y

Re: [PATCH] sunrpc: Add missing kuids conversion for printing

2013-09-12 Thread Myklebust, Trond
On Thu, 2013-09-12 at 15:09 +0200, Geert Uytterhoeven wrote: > m68k/allmodconfig: > > net/sunrpc/auth_generic.c: In function ‘generic_key_timeout’: > net/sunrpc/auth_generic.c:241: warning: format ‘%d’ expects type ‘int’, but > argument 2 has type ‘kuid_t’ > > commit cdba321e291f0fbf5abda4d883402

Re: Kernel size increase of +256 KiB (was: Re: RPCSEC_GSS: Share all credential caches on a per-transport basis)

2013-09-12 Thread Myklebust, Trond
On Thu, 2013-09-12 at 15:24 +0200, Geert Uytterhoeven wrote: > On Mon, Sep 9, 2013 at 6:57 PM, Linux Kernel Mailing List > wrote: > > diff --git a/net/sunrpc/auth_gss/auth_gss.c b/net/sunrpc/auth_gss/auth_gss.c > > index 5ec15bb..dc4b449 100644 > > --- a/net/sunrpc/auth_gss/auth_gss.c > > +++ b/ne

[GIT PULL] Please pull NFS client updates for 3.12

2013-09-09 Thread Myklebust, Trond
Hi Linus, The following changes since commit 7c6d4dca777d6423cb9ccdc019cad94c75adcbe4: Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/mattst88/alpha (2013-07-23 14:39:57 -0700) are available in the git repository at: git://git.linux-nfs.org/projects/trondmy/lin

[GIT PULL] Please pull one NFS client bugfix

2013-08-29 Thread Myklebust, Trond
Hi Linus, The following changes since commit fa8218def1b1a16f0a410e2c1c767b4738cc81fa: Merge tag 'regmap-v3.11-rc7' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regmap (2013-08-27 10:10:30 -0700) are available in the git repository at: git://git.linux-nfs.org/projects/trondmy

[GIT PULL] Please pull NFS client bug fixes

2013-08-09 Thread Myklebust, Trond
Hi Linus, The following changes since commit c095ba7224d8edc71dcef0d655911399a8bd4a3f: Linux 3.11-rc4 (2013-08-04 13:46:46 -0700) are available in the git repository at: git://git.linux-nfs.org/projects/trondmy/linux-nfs.git tags/nfs-for-3.11-4 for you to fetch changes up to b72888cb0ba63b

Re: [3.10.4] NFS locking panic, plus persisting NFS shutdown panic from 3.9.*

2013-08-07 Thread Myklebust, Trond
On Wed, 2013-08-07 at 22:01 +0100, Nix wrote: > On 7 Aug 2013, Trond Myklebust said: > > > On Wed, 2013-08-07 at 11:18 +0100, Nix wrote: > >> On 6 Aug 2013, Trond Myklebust verbalised: > >> > True. How about something like the following instead. Note the change to > >> > the original patch... > >>

Re: [3.10.4] NFS locking panic, plus persisting NFS shutdown panic from 3.9.*

2013-08-07 Thread Myklebust, Trond
On Wed, 2013-08-07 at 11:18 +0100, Nix wrote: > On 6 Aug 2013, Trond Myklebust verbalised: > > True. How about something like the following instead. Note the change to > > the original patch... > > Well, with those applied I could reboot without a panic for the first > time since 3.8.x: looking go

Re: [3.10.4] NFS locking panic, plus persisting NFS shutdown panic from 3.9.*

2013-08-05 Thread Myklebust, Trond
On Mon, 2013-08-05 at 14:33 -0400, Jeff Layton wrote: > On Mon, 5 Aug 2013 18:18:03 + > "Myklebust, Trond" wrote: > > > On Mon, 2013-08-05 at 13:37 -0400, Jeff Layton wrote: > > > On Mon, 5 Aug 2013 16:15:01 + > > > &qu

Re: [3.10.4] NFS locking panic, plus persisting NFS shutdown panic from 3.9.*

2013-08-05 Thread Myklebust, Trond
On Mon, 2013-08-05 at 19:33 +0100, Nix wrote: > On 5 Aug 2013, Trond Myklebust told this: > > Does the attached patch fix the problem? > > > From 3c50ba80105464a28d456d9a1e0f1d81d4af92a8 Mon Sep 17 00:00:00 2001 > > From: Trond Myklebust > > Date: Mon, 5 Aug 2013 12:06:12 -0400 > > Subject: [PATC

Re: [3.10.4] NFS locking panic, plus persisting NFS shutdown panic from 3.9.*

2013-08-05 Thread Myklebust, Trond
On Mon, 2013-08-05 at 13:37 -0400, Jeff Layton wrote: > On Mon, 5 Aug 2013 16:15:01 + > "Myklebust, Trond" wrote: > > > From 3c50ba80105464a28d456d9a1e0f1d81d4af92a8 Mon Sep 17 00:00:00 2001 > > From: Trond Myklebust > > Date: Mon, 5 Aug 2013 12:06:12 -0

Re: [3.10.4] NFS locking panic, plus persisting NFS shutdown panic from 3.9.*

2013-08-05 Thread Myklebust, Trond
On Mon, 2013-08-05 at 16:50 +0100, Nix wrote: > On 5 Aug 2013, Jeff Layton said: > > > On Mon, 5 Aug 2013 11:04:27 -0400 > > Jeff Layton wrote: > > > >> On Mon, 05 Aug 2013 15:48:01 +0100 > >> Nix wrote: > >> > >> > On 5 Aug 2013, Jeff Layton stated: > >> > > >> > > On Sun, 04 Aug 2013 16:40:5

Re: [PATCH] fs/nfs/inode.c: adjust code alignment

2013-08-05 Thread Myklebust, Trond
On Mon, 2013-08-05 at 16:47 +0200, Julia Lawall wrote: > From: Julia Lawall > > Signed-off-by: Julia Lawall > > --- > > This patch adjusts the code so that the alignment matches the current > semantics. I have no idea if it is the intended semantics, though. Should > the call to nfs_setsecur

Re: [ 068/103] SUNRPC: fix races on PipeFS UMOUNT notifications

2013-07-23 Thread Myklebust, Trond
On Tue, 2013-07-23 at 15:26 -0700, Greg Kroah-Hartman wrote: > 3.10-stable review patch. If anyone has any objections, please let me know. > Again, please drop this patch and 67/103 for now. We'll get back to whether or not this should be stable material later. -- Trond Myklebust Linux NFS cli

Re: Linux 3.11-rc2

2013-07-23 Thread Myklebust, Trond
On Tue, 2013-07-23 at 13:42 -0700, Linus Torvalds wrote: > On Tue, Jul 23, 2013 at 12:08 PM, wrote: > > Hi Trond, > > > >> OK. With Andre's help, I think we've root caused the problem. Can you > >> please confirm that the attached patch also solves the issue for you? > > > > Seems to work fine, >

Re: Linux 3.11-rc2

2013-07-23 Thread Myklebust, Trond
On Mon, 2013-07-22 at 21:17 -0400, Trond Myklebust wrote: > On Tue, 2013-07-23 at 03:04 +0200, rydb...@euromail.se wrote: > > Hi Trond, Linus, > > > > On Sun, Jul 21, 2013 at 12:53:10PM -0700, Linus Torvalds wrote: > > > So it's been another week, and -rc2 is out there. > > > > This one happens t

Re: [Ksummit-2013-discuss] KS Topic request: Handling the Stable kernel, let's dump the cc: stable tag

2013-07-22 Thread Myklebust, Trond
On Mon, 2013-07-22 at 19:47 -0700, James Bottomley wrote: > On Tue, 2013-07-23 at 02:40 +0000, Myklebust, Trond wrote: > > On Mon, 2013-07-15 at 23:27 +0400, James Bottomley wrote: > > > The solution, to me, looks simple: Let's co-opt a process we already > > > kno

Re: [Ksummit-2013-discuss] KS Topic request: Handling the Stable kernel, let's dump the cc: stable tag

2013-07-22 Thread Myklebust, Trond
On Mon, 2013-07-15 at 23:27 +0400, James Bottomley wrote: > Before the "3.10.1-stable review" thread degenerated into a disagreement > about habits of politeness, there were some solid points being made > which, I think, bear consideration and which may now be lost. > > The problem, as Jiří Kosina

Re: Linux 3.11-rc2

2013-07-22 Thread Myklebust, Trond
On Tue, 2013-07-23 at 03:04 +0200, rydb...@euromail.se wrote: > Hi Trond, Linus, > > On Sun, Jul 21, 2013 at 12:53:10PM -0700, Linus Torvalds wrote: > > So it's been another week, and -rc2 is out there. > > This one happens to break nfs in a rather blunt-instrument fashion - > creating files on a

[GIT PULL] Please pull NFS client fixes

2013-07-19 Thread Myklebust, Trond
Hi Linus, The following changes since commit ad81f0545ef01ea651886dddac4bef6cec930092: Linux 3.11-rc1 (2013-07-14 15:18:27 -0700) are available in the git repository at: git://git.linux-nfs.org/projects/trondmy/linux-nfs.git tags/nfs-for-3.11-3 for you to fetch changes up to b4a2cf76ab7c08

Re: [GIT PULL] x86 fixes for 3.11-rc2

2013-07-18 Thread Myklebust, Trond
On Thu, 2013-07-18 at 17:46 -0700, Linus Torvalds wrote: > Finnish is hard. But good for swearing. Only because the ratio of vowels to consonants causes an immediate outbreak of swearing among those who try... Trond -- Trond Myklebust Linux NFS client maintainer NetApp trond.mykleb...@netapp.c

Re: [Ksummit-2013-discuss] [ATTEND] How to act on LKML

2013-07-16 Thread Myklebust, Trond
On Tue, 2013-07-16 at 19:31 -0400, Ric Wheeler wrote: > On 07/16/2013 07:12 PM, Sarah Sharp wrote: > > On Tue, Jul 16, 2013 at 06:54:59PM -0400, Steven Rostedt wrote: > >> On Tue, 2013-07-16 at 15:43 -0700, Sarah Sharp wrote: > >> > >>> Yes, that's true. Some kernel developers are better at modera

Re: sunrpc/clnt.c: BUG kmalloc-256 (Not tainted): Poison overwritten

2013-07-14 Thread Myklebust, Trond
On Sun, 2013-07-14 at 10:02 +0200, Toralf Förster wrote: > This bisected commit produces at a 32 bit user mode linux guest the attached > BUG : > > commit 245268c951262b861bc1be4e9dc812352499 > Author: Trond Myklebust > Date: Wed Jul 10 15:33:01 2013 -0400 > > SUNRPC: Fix a deadlock i

[GIT PULL] Please pull NFS client updates

2013-07-11 Thread Myklebust, Trond
Hi Linus, The following pull request mainly contains some small readdir optimisations that had dependencies on Al Viro's readdir rewrite. There is also a fix for a nasty deadlock which surfaced earlier in this merge window. The following changes since commit a82a729f04232ccd0b59406574ba4cf20027a4

[GIT PULL] Please pull NFS client updates

2013-07-08 Thread Myklebust, Trond
Hi Linus, The following changes since commit f722406faae2d073cc1d01063d1123c35425939e: Linux 3.10-rc1 (2013-05-11 17:14:08 -0700) are available in the git repository at: git://git.linux-nfs.org/projects/trondmy/linux-nfs.git tags/nfs-for-3.11-1 for you to fetch changes up to 959d921f5eb887

Re: [PATCH v3 24/25] sunrpc: Change how dentry's d_lock field is accessed

2013-07-08 Thread Myklebust, Trond
On Thu, 2013-07-04 at 05:20 +0100, Al Viro wrote: > On Wed, Jul 03, 2013 at 04:25:32PM -0400, Waiman Long wrote: > > There is no change in logic and everything should just work. > > > - spin_lock(&file->f_path.dentry->d_lock); > > + d_lock(file->f_path.dentry); > >

Re: [PATCH v3 2/4] SUNRPC: fix races on PipeFS UMOUNT notifications

2013-06-25 Thread Myklebust, Trond
On Mon, 2013-06-24 at 11:52 +0400, Stanislav Kinsbursky wrote: > CPU#0 CPU#1 > - - > rpc_kill_sb > sn->pipefs_sb = NULLrpc_release_client > (UMOUNT_EVENT)

Re: [PATCH v2 2/4] SUNRPC: fix races on PipeFS MOUNT notifications

2013-06-17 Thread Myklebust, Trond
On Tue, 2013-06-11 at 18:39 +0400, Stanislav Kinsbursky wrote: > Below are races, when RPC client can be created without PiepFS dentries > > CPU#0 CPU#1 > - - > rpc_new_client

[GIT PULL] Please pull 2 NFS client bugfixes

2013-05-31 Thread Myklebust, Trond
Hi Linus, The following changes since commit 83c168bf8017212a9d502536f9dcd0b54d24e330: NFS: Fix SETCLIENTID fallback if GSS is not available (2013-05-23 18:50:40 -0400) are available in the git repository at: git://git.linux-nfs.org/projects/trondmy/linux-nfs.git tags/nfs-for-3.10-4 for y

Re: 3.10-rc3 NFSv3 mount issues

2013-05-30 Thread Myklebust, Trond
On Thu, 2013-05-30 at 16:26 -0400, Chuck Lever wrote: > On May 30, 2013, at 4:19 PM, Jim Schutt wrote: > > > Hi, > > > > I've been trying to test 3.10-rc3 on some diskless clients, and found > > that I can no longer mount my root file system via NFSv3. > > > > I poked around looking at NFS chan

Re: [PATCH 3.9-stable] NFSv4.1 Fix a pNFS session draining deadlock

2013-05-26 Thread Myklebust, Trond
On Mon, 2013-05-27 at 09:23 +0900, Jonghwan Choi wrote: > This patch looks like it should be in the 3.9-stable tree, should we apply > it? It's a condition which appears to be extremely rare: so far, we've only seen it during extreme stress testing at NetApp. For that reason, and because it is NFS

[GIT PULL] Please pull NFS client bugfixes

2013-05-26 Thread Myklebust, Trond
Hi Linus, The following changes since commit f722406faae2d073cc1d01063d1123c35425939e: Linux 3.10-rc1 (2013-05-11 17:14:08 -0700) are available in the git repository at: git://git.linux-nfs.org/projects/trondmy/linux-nfs.git tags/nfs-for-3.10-3 for you to fetch changes up to 83c168bf801721

Re: [RFC v0 4/4] nfs, nfsd: rough sys_copy_range and COPY support

2013-05-15 Thread Myklebust, Trond
On Wed, 2013-05-15 at 16:19 -0400, J. Bruce Fields wrote: > On Tue, May 14, 2013 at 02:15:26PM -0700, Zach Brown wrote: > > This crude patch illustrates the simplest plumbing involved in > > supporting sys_call_range with the NFS COPY operation that's pending in > > the 4.2 draft spec. > > > > The

[GIT Pull] Please pull more NFS client bug fixes

2013-05-08 Thread Myklebust, Trond
The following changes since commit 721ccfb79b6f74f4052de70236d24047e73682d4: NFSv4: Warn once about servers that incorrectly apply open mode to setattr (2013-04-29 11:11:58 -0400) are available in the git repository at: git://git.linux-nfs.org/projects/trondmy/linux-nfs.git tags/nfs-for-3.1

Re: [PATCH 09/15] Make selection of 'readdir-plus' adapt to usage patterns.

2013-05-07 Thread Myklebust, Trond
On Tue, 2013-05-07 at 16:18 +0200, Jiri Slaby wrote: > From: NeilBrown > > While the use of READDIRPLUS is significantly more efficient than > READDIR followed by many GETATTR calls, it is still less efficient > than just READDIR if the attributes are not required. > > We can get a hint as to wh

[GIT PULL] Please pull NFS client updates for 3.10

2013-04-30 Thread Myklebust, Trond
Hi Linus, The following changes since commit 1166fde6a923c30f4351515b6a9a1efc513e7d00: SUNRPC: Add barriers to ensure read ordering in rpc_wake_up_task_queue_locked (2013-03-25 11:23:40 -0400) are available in the git repository at: git://git.linux-nfs.org/projects/trondmy/linux-nfs.git ta

Re: [PATCH] NFSv4: Use exponential backoff delay for NFS4_ERRDELAY

2013-04-25 Thread Myklebust, Trond
On Apr 25, 2013, at 2:46 PM, "bfie...@fieldses.org" wrote: > On Thu, Apr 25, 2013 at 02:40:11PM -0400, Chuck Lever wrote: >> >> On Apr 25, 2013, at 2:19 PM, "bfie...@fieldses.org" >> wrote: >> >>> On Thu, Apr 25, 2013 at 02:10:36PM +

RE: [PATCH] NFSv4: Use exponential backoff delay for Ni

2013-04-25 Thread Myklebust, Trond
It's legal, but dumb... > -Original Message- > From: Matt W. Benjamin [mailto:m...@linuxbox.com] > Sent: Thursday, April 25, 2013 11:28 AM > To: Myklebust, Trond > Cc: David Wysochanski; Dave Chiluk; linux-...@vger.kernel.org; linux- > ker...@vger.kernel.or

Re: [PATCH] NFSv4: Use exponential backoff delay for NFS4_ERRDELAY

2013-04-25 Thread Myklebust, Trond
On Thu, 2013-04-25 at 09:49 -0400, bfie...@fieldses.org wrote: > On Thu, Apr 25, 2013 at 01:30:58PM +0000, Myklebust, Trond wrote: > > On Thu, 2013-04-25 at 09:29 -0400, bfie...@fieldses.org wrote: > > > > > My position is that we simply have no idea what order of ma

Re: [PATCH] NFSv4: Use exponential backoff delay for NFS4_ERRDELAY

2013-04-25 Thread Myklebust, Trond
On Thu, 2013-04-25 at 09:29 -0400, bfie...@fieldses.org wrote: > My position is that we simply have no idea what order of magnitude even > delay should be. And that in such a situation exponential backoff such > as implemented in the synchronous case seems the reasonable default as > it guarantee

Re: [PATCH] NFSv4: Use exponential backoff delay for NFS4_ERRDELAY

2013-04-25 Thread Myklebust, Trond
On Thu, 2013-04-25 at 08:19 -0400, David Wysochanski wrote: > On Wed, 2013-04-24 at 22:35 +0000, Myklebust, Trond wrote: > > On Wed, 2013-04-24 at 16:54 -0500, Dave Chiluk wrote: > > > On 04/24/2013 04:28 PM, Myklebust, Trond wrote: > > > > On Wed, 2013-04-24 at

Re: [PATCH] NFSv4: Use exponential backoff delay for NFS4_ERRDELAY

2013-04-24 Thread Myklebust, Trond
On Wed, 2013-04-24 at 16:54 -0500, Dave Chiluk wrote: > On 04/24/2013 04:28 PM, Myklebust, Trond wrote: > > On Wed, 2013-04-24 at 15:55 -0500, Dave Chiluk wrote: > >> Changing the retry to start at NFS4_POLL_RETRY_MIN and exponentially grow > >> to NFS4_POLL_RETRY_MAX a

Re: [PATCH] NFSv4: Use exponential backoff delay for NFS4_ERRDELAY

2013-04-24 Thread Myklebust, Trond
On Wed, 2013-04-24 at 15:55 -0500, Dave Chiluk wrote: > Changing the retry to start at NFS4_POLL_RETRY_MIN and exponentially grow > to NFS4_POLL_RETRY_MAX allow for faster handling of these error conditions. > > Additionally this alleviates an interoperability problem with the AIX NFSv4 > Server.

[GIT PULL] One line typo fix

2013-04-10 Thread Myklebust, Trond
Hi Linus, I suddenly noticed that a one-line issue that I _thought_ I had fixed with the nfs41_walk_client_list patch was apparently still there in the pull request I sent earlier today. I'm very sorry for not catching that in time. The following changes since commit fa332941c0c7c00e3420078268b75

[GIT PULL] Please pull NFS client fixes

2013-04-10 Thread Myklebust, Trond
Hi Linus, The following changes since commit 1166fde6a923c30f4351515b6a9a1efc513e7d00: SUNRPC: Add barriers to ensure read ordering in rpc_wake_up_task_queue_locked (2013-03-25 11:23:40 -0400) are available in the git repository at: git://git.linux-nfs.org/projects/trondmy/linux-nfs.git ta

Re: [PATCH 6/8] nfsd4: do not export "u64" to userspace

2013-04-01 Thread Myklebust, Trond
On Mon, 2013-04-01 at 20:01 +0200, Paul Bolle wrote: > nfs4.h exports "u64" to userspace. Use "__u64" instead. > > Signed-off-by: Paul Bolle > --- > 0) Tested with a kernel build. > > 1) I'm guessing userspace doesn't actually use NFS4_MAX_UINT64. > > include/uapi/linux/nfs4.h | 2 +- > 1 file

Re: openat(..., AT_UNLINKED) was Re: New copyfile system call - discuss before LSF?

2013-03-31 Thread Myklebust, Trond
On Sun, 2013-03-31 at 20:32 +0200, Pavel Machek wrote: > > > > > Hmm. open_deleted_file() will still need to get a directory... so it > > > > > will still need a path. Perhaps open("/foo/bar/mnt", O_DELETED) would > > > > > be acceptable interface? > > > > > > > > ...and what's the big plan to mak

Re: New copyfile system call - discuss before LSF?

2013-03-31 Thread Myklebust, Trond
On Sun, 2013-03-31 at 09:36 +0200, Pavel Machek wrote: > Hi! > > > >>> Hmm, really? AFAICT it would be simple to provide an > > >>> open_deleted_file("directory") syscall. You'd open_deleted_file(), > > >>> copy source file into it, then fsync(), then link it into filesystem. > > >>> > > >>> That

Re: New copyfile system call - discuss before LSF?

2013-03-30 Thread Myklebust, Trond
On Sun, 2013-03-31 at 00:36 -0400, Trond Myklebust wrote: > On Sat, 2013-03-30 at 21:18 -0700, Andy Lutomirski wrote: > > On Sat, Mar 30, 2013 at 8:52 PM, Myklebust, Trond > > wrote: > > > On Sat, 2013-03-30 at 19:53 -0700, Andreas Dilger wrote: > > >> On 2013

Re: New copyfile system call - discuss before LSF?

2013-03-30 Thread Myklebust, Trond
On Sat, 2013-03-30 at 21:18 -0700, Andy Lutomirski wrote: > On Sat, Mar 30, 2013 at 8:52 PM, Myklebust, Trond > wrote: > > On Sat, 2013-03-30 at 19:53 -0700, Andreas Dilger wrote: > >> On 2013-03-30, at 16:21, Ric Wheeler wrote: > >> > >> > On 0

Re: New copyfile system call - discuss before LSF?

2013-03-30 Thread Myklebust, Trond
On Sat, 2013-03-30 at 19:53 -0700, Andreas Dilger wrote: > On 2013-03-30, at 16:21, Ric Wheeler wrote: > > > On 03/30/2013 05:57 PM, Myklebust, Trond wrote: > >> On Mar 30, 2013, at 5:45 PM, Pavel Machek > >> wrote: > >> > >>> On Sat 2013-0

Re: New copyfile system call - discuss before LSF?

2013-03-30 Thread Myklebust, Trond
On Mar 30, 2013, at 5:45 PM, Pavel Machek wrote: > On Sat 2013-03-30 13:08:39, Andreas Dilger wrote: >> On 2013-03-30, at 12:49 PM, Pavel Machek wrote: >>> Hmm, really? AFAICT it would be simple to provide an >>> open_deleted_file("directory") syscall. You'd open_deleted_file(), >>> copy source

[GIT PULL] Please pull NFS client bugfixes

2013-03-26 Thread Myklebust, Trond
Hi Linus, The following changes since commit 6dbe51c251a327e012439c4772097a13df43c5b8: Linux 3.9-rc1 (2013-03-03 15:11:05 -0800) are available in the git repository at: git://git.linux-nfs.org/projects/trondmy/linux-nfs.git tags/nfs-for-3.9-3 for you to fetch changes up to 1166fde6a923c30f

Re: [PATCH linux-next v2] SUNRPC: rpcrdma_register_default_external: Dynamically allocate ib_phys_buf

2013-03-11 Thread Myklebust, Trond
On Mon, 2013-03-11 at 15:15 -0400, J. Bruce Fields wrote: > On Mon, Mar 11, 2013 at 12:51:44PM -0600, Tim Gardner wrote: > > On 03/11/2013 12:14 PM, J. Bruce Fields wrote: > > > > >> > > >> v2 - Move the array of 'struct ib_phys_buf' objects into struct > > >> rpcrdma_req > > >> and pass this req

RE: sunrpc ODEBUG assertion.

2013-03-09 Thread Myklebust, Trond
> -Original Message- > From: J. Bruce Fields [mailto:bfie...@fieldses.org] > Sent: Saturday, March 09, 2013 9:01 AM > To: Dave Jones; Linux Kernel; linux-...@vger.kernel.org; Myklebust, Trond > Subject: Re: sunrpc ODEBUG assertion. > > On Fri, Mar 08, 2013 at 09:59:4

Re: LOCKDEP: 3.9-rc1: mount.nfs/4272 still has locks held!

2013-03-07 Thread Myklebust, Trond
On Thu, 2013-03-07 at 09:03 -0800, Linus Torvalds wrote: > On Thu, Mar 7, 2013 at 8:45 AM, Myklebust, Trond > wrote: > > > > The problem there is that we get into the whole 'hard' vs 'soft' mount > > problem. We're supposed to guarantee data inte

Re: LOCKDEP: 3.9-rc1: mount.nfs/4272 still has locks held!

2013-03-07 Thread Myklebust, Trond
On Thu, 2013-03-07 at 08:25 -0800, Linus Torvalds wrote: > On Thu, Mar 7, 2013 at 7:59 AM, Myklebust, Trond > wrote: > > > > It _shouldn't_ be an interruption unless the filesystem can't make > > progress. > > So how can we tell? Calling "freezable_s

Re: LOCKDEP: 3.9-rc1: mount.nfs/4272 still has locks held!

2013-03-07 Thread Myklebust, Trond
On Thu, 2013-03-07 at 07:55 -0800, Linus Torvalds wrote: > On Thu, Mar 7, 2013 at 3:41 AM, Jeff Layton wrote: > > > > I think Trond may be on the right track. We probably need some > > mechanism to quiesce the filesystem ahead of any sort of freezer > > event. > > No, guys. That cannot work. It's

Re: LOCKDEP: 3.9-rc1: mount.nfs/4272 still has locks held!

2013-03-06 Thread Myklebust, Trond
On Wed, 2013-03-06 at 13:23 -0500, Jeff Layton wrote: > On Wed, 6 Mar 2013 07:59:01 -0800 > Mandeep Singh Baines wrote: > > In general, holding a lock and freezing can cause a deadlock if: > > > > 1) you froze via the cgroup_freezer subsystem and a task in another > > cgroup tried to acquire the

Re: LOCKDEP: 3.9-rc1: mount.nfs/4272 still has locks held!

2013-03-05 Thread Myklebust, Trond
On Tue, 2013-03-05 at 14:03 -0500, Jeff Layton wrote: > On Tue, 5 Mar 2013 09:49:54 -0800 > Tejun Heo wrote: > > > On Tue, Mar 05, 2013 at 09:46:48AM -0800, Tejun Heo wrote: > > > So, I think this is why implementing freezer as a separate blocking > > > mechanism isn't such a good idea. We're ef

Re: [PATCH -v3 17/23] net/sunrpc: rename random32() to prandom_u32()

2013-03-04 Thread Myklebust, Trond
On Mon, 2013-03-04 at 21:58 +0900, Akinobu Mita wrote: > Use more preferable function name which implies using a pseudo-random > number generator. > > Signed-off-by: Akinobu Mita > Cc: "J. Bruce Fields" > Cc: Trond Myklebust > Cc: "David S. Miller" > Cc: net...@vger.kernel.org > Cc: linux-...@

Re: LOCKDEP: 3.9-rc1: mount.nfs/4272 still has locks held!

2013-03-04 Thread Myklebust, Trond
On Mon, 2013-03-04 at 21:53 +0100, Oleg Nesterov wrote: > On 03/04, Mandeep Singh Baines wrote: > > > > The problem is that freezer_count() calls try_to_freeze(). In this > > case, try_to_freeze() is not really adding any value. > > Well, I tend to agree. > > If a task calls __refrigerator() hold

Re: LOCKDEP: 3.9-rc1: mount.nfs/4272 still has locks held!

2013-03-04 Thread Myklebust, Trond
On Mon, 2013-03-04 at 23:33 +0800, Ming Lei wrote: > Hi, > > CC guys who introduced the lockdep change. > > On Mon, Mar 4, 2013 at 11:04 PM, Jeff Layton wrote: > > > > > I don't get it -- why is it bad to hold a lock across a freeze event? > > At least this may deadlock another mount.nfs durin

Re: LOCKDEP: 3.9-rc1: mount.nfs/4272 still has locks held!

2013-03-04 Thread Myklebust, Trond
On Mon, 2013-03-04 at 21:57 +0800, Ming Lei wrote: > Hi, > > The below warning can be triggered each time when mount.nfs is > running on 3.9-rc1. > > Not sure if freezable_schedule() inside rpc_wait_bit_killable should > be changed to schedule() since nfs_clid_init_mutex is held in the path. Cc:

[GIT PULL] Please pull NFS client bugfixes

2013-03-02 Thread Myklebust, Trond
Hi Linus, We've just concluded another Connectathon interoperability testing week, and so here are the fixes for the bugs that were discovered. Cheers, Trond The following changes since commit 666b3d803a511fbc9bc5e5ea8ce66010cf03ea13: NLM: Ensure that we resend all pending blocking locks af

Re: linux-next: build failure after merge of the nfsd tree

2013-02-28 Thread Myklebust, Trond
On Fri, 2013-03-01 at 12:04 +1100, Stephen Rothwell wrote: > Hi all, > > After merging the nfsd tree, today's linux-next build (powerpc > ppc64_defconfig) failed like this: > > net/sunrpc/xprtsock.c:1923:30: error: 'struct rpc_task' has no member named > 'tk_xprt' > > Caused by commit dc107402a

Re: New copyfile system call - discuss before LSF?

2013-02-25 Thread Myklebust, Trond
On Mon, 2013-02-25 at 15:35 -0800, Andy Lutomirski wrote: > On Mon, Feb 25, 2013 at 3:28 PM, Myklebust, Trond > wrote: > > On Mon, 2013-02-25 at 14:16 -0800, Andy Lutomirski wrote: > >> On Mon, Feb 25, 2013 at 1:59 PM, Myklebust, Trond > >> wrote: > >> &

Re: New copyfile system call - discuss before LSF?

2013-02-25 Thread Myklebust, Trond
On Mon, 2013-02-25 at 14:16 -0800, Andy Lutomirski wrote: > On Mon, Feb 25, 2013 at 1:59 PM, Myklebust, Trond > wrote: > > On Mon, 2013-02-25 at 16:49 -0500, Ric Wheeler wrote: > >> On 02/25/2013 04:14 PM, Andy Lutomirski wrote: > >> > On 02/21/2013 02:24 PM, Zach

Re: New copyfile system call - discuss before LSF?

2013-02-25 Thread Myklebust, Trond
On Mon, 2013-02-25 at 16:49 -0500, Ric Wheeler wrote: > On 02/25/2013 04:14 PM, Andy Lutomirski wrote: > > On 02/21/2013 02:24 PM, Zach Brown wrote: > >> On Thu, Feb 21, 2013 at 08:50:27PM +, Myklebust, Trond wrote: > >>> On Thu, 2013-02-21 at 21:00 +0100, Paolo

RE: New copyfile system call - discuss before LSF?

2013-02-22 Thread Myklebust, Trond
> -Original Message- > From: Zach Brown [mailto:z...@redhat.com] > Sent: Friday, February 22, 2013 1:22 PM > To: Ric Wheeler > Cc: Paolo Bonzini; Myklebust, Trond; Linux FS Devel; linux- > ker...@vger.kernel.org; Chris L. Mason; Christoph Hellwig; Alexander Viro; &g

RE: New copyfile system call - discuss before LSF?

2013-02-21 Thread Myklebust, Trond
> -Original Message- > From: Zach Brown [mailto:z...@redhat.com] > Sent: Thursday, February 21, 2013 5:25 PM > To: Myklebust, Trond > Cc: Paolo Bonzini; Ric Wheeler; Linux FS Devel; linux-kernel@vger.kernel.org; > Chris L. Mason; Christoph Hellwig; Alexander Viro;

Re: New copyfile system call - discuss before LSF?

2013-02-21 Thread Myklebust, Trond
On Thu, 2013-02-21 at 23:05 +0100, Ric Wheeler wrote: > On 02/21/2013 09:00 PM, Paolo Bonzini wrote: > > Il 21/02/2013 15:57, Ric Wheeler ha scritto: > >>> sendfile64() pretty much already has the right arguments for a > >>> "copyfile", however it would be nice to add a 'flags' parameter: the > >>>

Re: New copyfile system call - discuss before LSF?

2013-02-21 Thread Myklebust, Trond
On Thu, 2013-02-21 at 21:00 +0100, Paolo Bonzini wrote: > Il 21/02/2013 15:57, Ric Wheeler ha scritto: > >>> > >> sendfile64() pretty much already has the right arguments for a > >> "copyfile", however it would be nice to add a 'flags' parameter: the > >> NFSv4.2 version would use that to specify w

Re: [PATCH] sunrpc/auth_gss: fix sparse warnings for gss_mech_switch

2013-02-21 Thread Myklebust, Trond
On Thu, 2013-02-21 at 20:10 +0200, Silviu-Mihai Popescu wrote: > This fixes the following sparse warnings: > * net/sunrpc/auth_gss/gss_mech_switch.c:143:21: warning: symbol > '_gss_mech_get_by_name' was not declared. Should it be static? > * net/sunrpc/auth_gss/gss_mech_switch.c:208:21:

Re: New copyfile system call - discuss before LSF?

2013-02-21 Thread Myklebust, Trond
On Thu, 2013-02-21 at 12:37 +0100, Ric Wheeler wrote: > We have debated the need to have a system call to allow for offloading copy > operations, for example to an NFS server (part to the new NFS 4.2 > specification), SCSI target device (two different SCSI commands do this), > local > file syst

[GIT PULL] Please pull NFS client bugfixes

2013-02-20 Thread Myklebust, Trond
Hi Linus, The following changes since commit 88b62b915b0b7e25870eb0604ed9a92ba4bfc9f7: Linux 3.8-rc6 (2013-02-01 12:08:14 +1100) are available in the git repository at: git://git.linux-nfs.org/projects/trondmy/linux-nfs.git tags/nfs-for-3.9-1 for you to fetch changes up to 666b3d803a511fbc

[GIT PULL] Please pull NFS client fixes

2013-01-31 Thread Myklebust, Trond
Hi Linus, The following changes since commit 949db153b6466c6f7cad5a427ecea94985927311: Linux 3.8-rc5 (2013-01-25 11:57:28 -0800) are available in the git repository at: git://git.linux-nfs.org/projects/trondmy/linux-nfs.git tags/nfs-for-3.8-4 for you to fetch changes up to c489ee290bdbbace6

Re: [PATCH 11/14] nfs: idr_destroy() no longer needs idr_remove_all()

2013-01-29 Thread Myklebust, Trond
On Tue, 2013-01-29 at 17:58 -0500, J. Bruce Fields wrote: > On Fri, Jan 25, 2013 at 05:31:09PM -0800, Tejun Heo wrote: > > idr_destroy() can destroy idr by itself and idr_remove_all() is being > > deprecated. Drop reference to idr_remove_all(). Note that the code > > wasn't completely correct bef

RE: [PATCH 15/19] sunrpc: don't warn for unused variable 'buf'

2013-01-25 Thread Myklebust, Trond
> -Original Message- > From: Arnd Bergmann [mailto:a...@arndb.de] > Sent: Friday, January 25, 2013 5:44 PM > To: linux-arm-ker...@lists.infradead.org > Cc: linux-kernel@vger.kernel.org; Arnd Bergmann; J. Bruce Fields; > Myklebust, Trond; linux-...@vger.kernel.org; net.

[CFP] Linux Storage, Filesystem and Memory Management Summit 2013

2013-01-17 Thread Myklebust, Trond
The annual Linux Storage, Filesystem and Memory Management Summit for 2013 will be held on April 18th and 19th following the Linux Foundation Collaboration Summit at Parc 55 Hotel in San Francisco, CA: https://events.linuxfoundation.org/events/collaboration-summit https://events.l

[GIT PULL] Please pull one SUNRPC client bugfix

2013-01-11 Thread Myklebust, Trond
The following changes since commit d287b8750e47c1702dab0e37ac11012bb751ece0: Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs (2013-01-07 09:41:20 -0800) are available in the git repository at: git://git.linux-nfs.org/projects/trondmy/linux-nfs.git tags/n

[GIT PULL] Please pull NFS client bugfixes

2013-01-07 Thread Myklebust, Trond
Hi Linus, The following changes since commit d1c3ed669a2d452cacfb48c2d171a1f364dae2ed: Linux 3.8-rc2 (2013-01-02 18:13:21 -0800) are available in the git repository at: git://git.linux-nfs.org/projects/trondmy/linux-nfs.git tags/nfs-for-3.8-2 for you to fetch changes up to ecf0eb9edbb607d7

Re: [PATCH] nfs: avoid dereferencing null pointer in initiate_bulk_draining

2013-01-05 Thread Myklebust, Trond
On Sat, 2013-01-05 at 14:19 -0500, Nickolai Zeldovich wrote: > Fix an inverted null pointer check in initiate_bulk_draining(). > > Signed-off-by: Nickolai Zeldovich > --- > fs/nfs/callback_proc.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/nfs/callback_proc.c

  1   2   >