Re: [LTP] [PATCH 1/8] Scaling msgmni to the amount of lowmem

2008-02-21 Thread Nadia Derbey
Subrata Modak wrote: Nadia Derbey wrote: Matt Helsley wrote: On Tue, 2008-02-19 at 18:16 +0100, Nadia Derbey wrote: +#define MAX_MSGQUEUES 16 /* MSGMNI as defined in linux/msg.h */ + It's not quite the maximum anymore, is it? More like the minumum maximum ;). A better

Re: [LTP] [PATCH 1/8] Scaling msgmni to the amount of lowmem

2008-02-21 Thread Nadia Derbey
Nadia Derbey wrote: Matt Helsley wrote: On Tue, 2008-02-19 at 18:16 +0100, Nadia Derbey wrote: +#define MAX_MSGQUEUES 16 /* MSGMNI as defined in linux/msg.h */ + It's not quite the maximum anymore, is it? More like the minumum maximum ;). A better name might better document

Re: [LTP] [PATCH 1/8] Scaling msgmni to the amount of lowmem

2008-02-21 Thread Nadia Derbey
Matt Helsley wrote: On Tue, 2008-02-19 at 18:16 +0100, Nadia Derbey wrote: +#define MAX_MSGQUEUES 16 /* MSGMNI as defined in linux/msg.h */ + It's not quite the maximum anymore, is it? More like the minumum maximum ;). A better name might better document what the test is act

Re: [LTP] [PATCH 1/8] Scaling msgmni to the amount of lowmem

2008-02-21 Thread Nadia Derbey
Matt Helsley wrote: On Tue, 2008-02-19 at 18:16 +0100, Nadia Derbey wrote: +#define MAX_MSGQUEUES 16 /* MSGMNI as defined in linux/msg.h */ + It's not quite the maximum anymore, is it? More like the minumum maximum ;). A better name might better document what the test is act

Re: [LTP] [PATCH 1/8] Scaling msgmni to the amount of lowmem

2008-02-19 Thread Nadia Derbey
Subrata Modak wrote: Nadia Derbey wrote: Andrew Morton wrote: On Mon, 11 Feb 2008 15:16:47 +0100 [EMAIL PROTECTED] wrote: [PATCH 01/08] This patch computes msg_ctlmni to make it scale with the amount of lowmem. msg_ctlmni is now set to make the message queues occupy 1/32 of the

Re: [PATCH 1/8] Scaling msgmni to the amount of lowmem

2008-02-18 Thread Nadia Derbey
Nadia Derbey wrote: Andrew Morton wrote: On Mon, 11 Feb 2008 15:16:47 +0100 [EMAIL PROTECTED] wrote: [PATCH 01/08] This patch computes msg_ctlmni to make it scale with the amount of lowmem. msg_ctlmni is now set to make the message queues occupy 1/32 of the available lowmem. Some

Re: [PATCH 1/8] Scaling msgmni to the amount of lowmem

2008-02-18 Thread Nadia Derbey
Andrew Morton wrote: On Mon, 11 Feb 2008 15:16:47 +0100 [EMAIL PROTECTED] wrote: [PATCH 01/08] This patch computes msg_ctlmni to make it scale with the amount of lowmem. msg_ctlmni is now set to make the message queues occupy 1/32 of the available lowmem. Some cleaning has also been done for

Re: [PATCH 7/8] Do not recompute msgmni anymore if explicitely set by user

2008-02-14 Thread Nadia Derbey
Andrew Morton wrote: On Tue, 12 Feb 2008 16:15:00 +0100 Nadia Derbey <[EMAIL PROTECTED]> wrote: Andrew Morton wrote: On Tue, 12 Feb 2008 10:32:31 +0100 Nadia Derbey <[EMAIL PROTECTED]> wrote: it builds fine, modulo some changes in ipv4 and ipv6 (see attached patch - didn&

Re: [PATCH 7/8] Do not recompute msgmni anymore if explicitely set by user

2008-02-12 Thread Nadia Derbey
Andrew Morton wrote: On Tue, 12 Feb 2008 10:32:31 +0100 Nadia Derbey <[EMAIL PROTECTED]> wrote: it builds fine, modulo some changes in ipv4 and ipv6 (see attached patch - didn't find it in the hot fixes). OK, thanks for checking. Did you confirm that we don't have unneeded

Re: [PATCH 8/8] Re-enable msgmni automatic recomputing msgmni if set to negative

2008-02-12 Thread Nadia Derbey
Andrew Morton wrote: On Mon, 11 Feb 2008 15:16:54 +0100 [EMAIL PROTECTED] wrote: [PATCH 08/08] This patch is the enhancement as asked for by Yasunori: if msgmni is set to a negative value, register it back into the ipcns notifier chain. A new interface has been added to the notification mech

Re: [PATCH 7/8] Do not recompute msgmni anymore if explicitely set by user

2008-02-12 Thread Nadia Derbey
Nadia Derbey wrote: Andrew Morton wrote: On Mon, 11 Feb 2008 15:16:53 +0100 [EMAIL PROTECTED] wrote: [PATCH 07/08] This patch makes msgmni not recomputed anymore upon ipc namespace creation / removal or memory add/remove, as soon as it has been set from userland. As soon as msgmni is

Re: [PATCH 7/8] Do not recompute msgmni anymore if explicitely set by user

2008-02-12 Thread Nadia Derbey
PV6 build if CONFIG_PROC_FS=n Signed-off-by: Nadia Derbey <[EMAIL PROTECTED]> --- include/net/ip_fib.h | 13 - include/net/ipv6.h |6 +++--- 2 files changed, 15 insertions(+), 4 deletions(-) Index: linux-2.6.24-mm1/include/net/ip_fib.h ==

[PATCH 8/8] Re-enable msgmni automatic recomputing msgmni if set to negative

2008-02-11 Thread Nadia . Derbey
registered. With that new interface we avoid taking care of the states changes in procfs. Signed-off-by: Nadia Derbey <[EMAIL PROTECTED]> --- include/linux/ipc_namespace.h |1 include/linux/notifier.h |4 +++ ipc/ipc_sysctl.c

[PATCH 7/8] Do not recompute msgmni anymore if explicitely set by user

2008-02-11 Thread Nadia . Derbey
notifier chain. Signed-off-by: Nadia Derbey <[EMAIL PROTECTED]> --- ipc/ipc_sysctl.c | 43 +-- 1 file changed, 41 insertions(+), 2 deletions(-) Index: linux-2.6.24-mm1/ipc/ipc_sy

[PATCH 6/8] Recomputing msgmni on ipc namespace creation/removal

2008-02-11 Thread Nadia . Derbey
or an existing ipc namespace is removed, the ipcns notifier chain is notified. The callback routine for each registered ipc namespace is then activated in order to recompute msgmni for that namespace. Signed-off-by: Nadia Derbey <[EMAIL PROTECTED]> --- include/linux/ipc_namespace.h

[PATCH 4/8] Recomputing msgmni on memory add / remove

2008-02-11 Thread Nadia . Derbey
. Each callback routine registered in the ipcns namespace, in turn, recomputes msgmni for the owning namespace. Signed-off-by: Nadia Derbey <[EMAIL PROTECTED]> --- include/linux/ipc_namespace.h | 43 - include/linux/memory.h|1 ipc/Ma

[PATCH 5/8] Invoke the ipcns notifier chain as a work item

2008-02-11 Thread Nadia . Derbey
[PATCH 05/08] This patch makes the memory hotplug chain's mutex held for a shorter time: when memory is offlined or onlined a work item is added to the global workqueue. When the work item is run, it notifies the ipcns notifier chain with the IPCNS_MEMCHANGED event. Signed-off-by: Nadia D

[PATCH 3/8] Defining the slab_memory_callback priority as a constant

2008-02-11 Thread Nadia . Derbey
[PATCH 03/08] This is a trivial patch that defines the priority of slab_memory_callback in the callback chain as a constant. This is to prepare for next patch in the series. Signed-off-by: Nadia Derbey <[EMAIL PROTECTED]> --- include/linux/memory.h |6 ++ mm/slub.c

[PATCH 0/8] Change default MSGMNI tunable to scale with lowmem (v3)

2008-02-11 Thread Nadia . Derbey
Resending the set of patches after Yasunori's remark about being able to turn on/off automatic recomputing. (see message at http://lkml.org/lkml/2008/2/5/149). I actually introduced an intermediate solution: when msgmni is set by hand, it is uneregistered from the ipcns notifier chain (i.e. automa

[PATCH 2/8] Scaling msgmni to the number of ipc namespaces

2008-02-11 Thread Nadia . Derbey
[PATCH 02/08] Since all the namespaces see the same amount of memory (the total one) this patch introduces a new variable that counts the ipc namespaces and divides msg_ctlmni by this counter. Signed-off-by: Nadia Derbey <[EMAIL PROTECTED]> --- include/linux/ipc_namespace.h |1 + ipc

[PATCH 1/8] Scaling msgmni to the amount of lowmem

2008-02-11 Thread Nadia . Derbey
es it as a size in bytes (the code expresses it in Kbytes). Signed-off-by: Nadia Derbey <[EMAIL PROTECTED]> --- include/linux/msg.h | 14 -- ipc/msg.c | 37 - 2 files changed, 48 insertions(+), 3 deletions(-) Index: linux

[PATCH 2.6.24-mm1] fix build error in arch/x86/mm/pgtable_32.c

2008-02-08 Thread Nadia Derbey
Add the mm missing argument to pmd_free() calls. Signed-off-by: Nadia Derbey <[EMAIL PROTECTED]> --- arch/x86/mm/pgtable_32.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) Index: linux-2.6.24-mm1/arch/x86

Re: [RFC][PATCH v2 7/7] Do not recompute msgmni anymore if explicitely set by user

2008-02-05 Thread Nadia Derbey
Yasunori Goto wrote: Thanks Nadia-san. I tested this patch set on my box. It works well. I have only one comment. --- ipc/ipc_sysctl.c | 43 +-- 1 file changed, 41 insertions(+), 2 deletions(-) Index: linux-2.6.24/ipc/ipc_sysctl.c ===

[RFC][PATCH v2 6/7] Recomputing msgmni on ipc namespace creation/removal

2008-01-31 Thread Nadia . Derbey
or an existing ipc namespace is removed, the ipcns notifier chain is notified. The callback routine for each registered ipc namespace is then activated in order to recompute msgmni for that namespace. Signed-off-by: Nadia Derbey <[EMAIL PROTECTED]> --- include/linux/ipc.h

[RFC][PATCH v2 7/7] Do not recompute msgmni anymore if explicitely set by user

2008-01-31 Thread Nadia . Derbey
notifier chain. Signed-off-by: Nadia Derbey <[EMAIL PROTECTED]> --- ipc/ipc_sysctl.c | 43 +-- 1 file changed, 41 insertions(+), 2 deletions(-) Index: linux-2.6.24/ipc/ipc_sy

[RFC][PATCH v2 5/7] Invoke the ipcns notifier chain as a work item

2008-01-31 Thread Nadia . Derbey
[PATCH 05/07] This patche makes the memory hotplug chain's mutex held for a shorter time: when memory is offlined or onlined a work item is added to the global workqueue. When the work item is run, it notifies the ipcns notifier chain with the IPCNS_MEMCHANGED event. Signed-off-by: Nadia D

[RFC][PATCH v2 4/7] Recomputing msgmni on memory add / remove

2008-01-31 Thread Nadia . Derbey
. Each callback routine registered in the ipcns namespace, in turn, recomputes msgmni for the owning namespace. Signed-off-by: Nadia Derbey <[EMAIL PROTECTED]> --- include/linux/ipc.h| 38 ++ include/linux/memory.h |1 ipc/Makefile |3 +

[RFC][PATCH v2 2/7] Scaling msgmni to the number of ipc namespaces

2008-01-31 Thread Nadia . Derbey
[PATCH 02/07] Since all the namespaces see the same amount of memory (the total one) this patch introduces a new variable that counts the ipc namespaces and divides msg_ctlmni by this counter. Signed-off-by: Nadia Derbey <[EMAIL PROTECTED]> --- include/linux/ipc.h |1 + ipc

[RFC][PATCH v2 3/7] Defining the slab_memory_callback priority as a constant

2008-01-31 Thread Nadia . Derbey
[PATCH 03/07] This is a trivial patch that defines the priority of slab_memory_callback in the callback chain as a constant. This is to prepare for next patch in the series. Signed-off-by: Nadia Derbey <[EMAIL PROTECTED]> --- include/linux/memory.h |6 ++ mm/slub.c

[RFC][PATCH v2 1/7] Scaling msgmni to the amount of lowmem

2008-01-31 Thread Nadia . Derbey
es it as a size in bytes (the code expresses it in Kbytes). Signed-off-by: Nadia Derbey <[EMAIL PROTECTED]> --- include/linux/msg.h | 14 -- ipc/msg.c | 37 - 2 files changed, 48 insertions(+), 3 deletions(-) Index: linux-2.6

[RFC][PATCH v2 0/7] Scaling msgmni to the amount of lowmem

2008-01-31 Thread Nadia . Derbey
Resending the set of patches after Yasunori's remark about having a single callback on the hotplug memory notifier chain for the ipc subsystem. (see thread at http://lkml.org/lkml/2008/1/14/196). Cc'ing linux-mm since I'm adding a notifier block to the memory hotplug notifier chain. Also, Cc'ing

Re: [PATCH 2.6.24-rc8-mm1 05/15] IPC/semaphores: remove one unused parameter from semctl_down()

2008-01-31 Thread Nadia Derbey
Pierre Peiffer wrote: Nadia Derbey wrote: [EMAIL PROTECTED] wrote: From: Pierre Peiffer <[EMAIL PROTECTED]> semctl_down() takes one unused parameter: semnum. This patch proposes to get rid of it. Signed-off-by: Pierre Peiffer <[EMAIL PROTECTED]> Acked-by: Serge Hallyn <[

Re: [PATCH 2.6.24-rc8-mm1 05/15] IPC/semaphores: remove one unused parameter from semctl_down()

2008-01-31 Thread Nadia Derbey
[EMAIL PROTECTED] wrote: From: Pierre Peiffer <[EMAIL PROTECTED]> semctl_down() takes one unused parameter: semnum. This patch proposes to get rid of it. Signed-off-by: Pierre Peiffer <[EMAIL PROTECTED]> Acked-by: Serge Hallyn <[EMAIL PROTECTED]> --- ipc/sem.c |6 +++--- 1 file changed, 3

Re: [RFC PATCH 0/4] [RESEND] Change default MSGMNI tunable to scale with lowmem

2008-01-15 Thread Nadia Derbey
Resending with the right address for the containers mailing list. So sorry... Nadia Derbey wrote: Hi, Yesterday, I posted to lkml a series of patches that make the ipc tunable msgmni scale with lowmem (see thread http://lkml.org/lkml/2008/1/14/196). Since these patches watch for memory

[RFC PATCH 0/4] [RESEND] Change default MSGMNI tunable to scale with lowmem

2008-01-15 Thread Nadia Derbey
Hi, Yesterday, I posted to lkml a series of patches that make the ipc tunable msgmni scale with lowmem (see thread http://lkml.org/lkml/2008/1/14/196). Since these patches watch for memory hotplug notifications, I thought that comments from linux-mm people would be interesting. Also, since

Re: [RFC PATCH 4/4] [RESEND] Recomputing msgmni on memory add / remove

2008-01-15 Thread Nadia Derbey
Yasunori Goto wrote: Yasunori Goto wrote: Hello Nadia-san. @@ -118,6 +122,10 @@ struct ipc_namespace { size_t shm_ctlall; int shm_ctlmni; int shm_tot; + +#ifdef CONFIG_MEMORY_HOTPLUG + struct notifier_block ipc_memory_hotplug; +

Re: [RFC PATCH 0/4] [RESEND] Change default MSGMNI tunable to scale with lowmem

2008-01-15 Thread Nadia Derbey
I'm realizing that I wrote Andrew's address wrong. So please if ever you're answering in this thread correct his address by hand. Sorry for that! Now if you find it more convenient that I start a new thread with the right address, please tell me and I'll do it. Regards, Nadia -- To unsubscr

Re: [RFC PATCH 4/4] [RESEND] Recomputing msgmni on memory add / remove

2008-01-15 Thread Nadia Derbey
Yasunori Goto wrote: Hello Nadia-san. @@ -118,6 +122,10 @@ struct ipc_namespace { size_t shm_ctlall; int shm_ctlmni; int shm_tot; + +#ifdef CONFIG_MEMORY_HOTPLUG + struct notifier_block ipc_memory_hotplug; +#endif }; I'm sorry,

[RFC PATCH 4/4] [RESEND] Recomputing msgmni on memory add / remove

2008-01-14 Thread Nadia . Derbey
registered into the memory hotplug notifier chain (it is unregistered when the ipc namespace is freed). That routine is then activated when memory is added or removed, in order to recompute msgmni for that namespace. Signed-off-by: Nadia Derbey <[EMAIL PROTECTED]> --- include/linux/ipc.h

[RFC PATCH 3/4] [RESEND] Defining the slab_memory_callback priority as a constant

2008-01-14 Thread Nadia . Derbey
[PATCH 03/04] This is a trivial patch that defines the priority of slab_memory_callback in the callback chain as a constant. This is to prepare for next patch in the series. Signed-off-by: Nadia Derbey <[EMAIL PROTECTED]> --- include/linux/memory.h |6 ++ mm/slub.c

[RFC PATCH 2/4] [RESEND] Scaling msgmni to the number of ipc namespaces

2008-01-14 Thread Nadia . Derbey
[PATCH 02/04] Since all the namespaces see the same amount of memory (the total one) this patch introduces a new variable that counts the ipc namespaces and divides msg_ctlmni by this counter. Signed-off-by: Nadia Derbey <[EMAIL PROTECTED]> --- include/linux/ipc.h |1 + ipc

[RFC PATCH 0/4] [RESEND] Change default MSGMNI tunable to scale with lowmem

2008-01-14 Thread Nadia . Derbey
Resending the set of patches after Andrew's remark about the fact that we should take the lowmem into account, rather than the total ram. Also, these patches have been enhanced with memory hotplug management. Note: they now have to applied to 2.6.24-rc7. --- On large systems we

[RFC PATCH 1/4] [RESEND] Scaling msgmni to the amount of lowmem

2008-01-14 Thread Nadia . Derbey
ut it also defines it as a size in bytes (the code expresses it in Kbytes). . MSGSEG definition has been removed since it used only once in msgctl(). Signed-off-by: Nadia Derbey <[EMAIL PROTECTED]> --- include/linux/msg.h | 14 +++--- ipc/msg.c

[RFC PATCH 2/2] Scaling msgmni to the number of ipc namespaces

2007-12-11 Thread Nadia . Derbey
[PATCH 02/02] Since all the namespaces see the same amount of memory (the total one) this patch introduces a new variable that counts the ipc namespaces and divides msg_ctlmni by this counter. Signed-off-by: Nadia Derbey <[EMAIL PROTECTED]> --- include/linux/ipc.h |1 + ipc

[RFC PATCH 1/2] Scaling msgmni to the system memory

2007-12-11 Thread Nadia . Derbey
also defines it as a size in bytes (the code expresses it in Kbytes). . MSGSEG definition has been removed since it used only once in msgctl(). Signed-off-by: Nadia Derbey <[EMAIL PROTECTED]> --- include/linux/msg.h |6 +++--- ipc/msg.c | 20 ++

[RFC PATCH 0/2] Change default MSGMNI tunable to scale with system memory

2007-12-11 Thread Nadia . Derbey
On large systems we'd like to allow a larger number of message queues. In some cases up to 32K. However simply setting MSGMNI to a larger value may cause problems for smaller systems. The first patch of this series introduces a default maximum number of message queue ids that scales with the tota

Re: [2.6 patch] make ipc/util.c:sysvipc_find_ipc() static

2007-10-25 Thread Nadia Derbey
_t pos, + loff_t *new_pos) { struct kern_ipc_perm *ipc; int total, id; Acked-by: Nadia Derbey <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PRO

Re: what is the rationale for "TAINT_USER"?

2007-10-12 Thread Nadia Derbey
Robert P. J. Day wrote: i can see what the theoretical purpose for it is here: http://kerneltrap.org/node/6656 but it's not clear how it can possibly be set from userland given that: $ grep -r TAINT_USER * include/linux/kernel.h:#define TAINT_USER (1<<6) kernel/panic.c:

Re: [RFC][PATCH -mm] IPC: fix error checking in all new xxx_lock() functions

2007-10-11 Thread Nadia Derbey
Pierre Peiffer wrote: In the new implementation of the [sem|shm|msg]_lock[_check]() routines, we use the return value of ipc_lock() in container_of() without any check. But ipc_lock may return a errcode. The use of this errcode in container_of() may alter this errcode, and we don't want this. To

Re: [PATCH] IPC: fix error case when idr-cache is empty in ipcget()

2007-10-10 Thread Nadia Derbey
Pierre Peiffer wrote: With the use of idr to store the ipc, the case where the idr cache is empty, when idr_get_new is called (this may happen even if we call idr_pre_get() before), is not well handled: it lets semget()/shmget()/msgget() return ENOSPC when this cache is empty, what 1. does not re

Re: [PATCH -mm1 1/2] fixing idr_find() locking

2007-09-28 Thread Nadia Derbey
his is the routine that is now called in all the update paths. Signed-off-by: Nadia Derbey <[EMAIL PROTECTED]> Acked-by: Jarek Poplawski <[EMAIL PROTECTED]> PS: there is one big mistake around To/Cc ordering, so I doubt Andrew will ever sign this... Jarek, I thought that

Re: [PATCH -mm1 0/2] Fix unlocked call to idr_find()

2007-09-27 Thread Nadia Derbey
Jarek Poplawski wrote: On Thu, Sep 27, 2007 at 04:33:54PM +0200, [EMAIL PROTECTED] wrote: This a series of 2 patches that should be applied on top of the other ipc patches, in 2.6.23-rc6-mm1. ... They should be applied to 2.6.23-rc6-mm1, in the following order: Didn't you mean 2.6.23-rc8

[PATCH -mm1 2/2] Removing unneeded parameters

2007-09-27 Thread Nadia . Derbey
[PATCH 02/02] This is a trivial patch that removes the unneeded parameters from ipc_checkid() and ipc_buildid() interfaces. Signed-off-by: Nadia Derbey <[EMAIL PROTECTED]> --- This patch applies on top of the 2.6.23-rc6-mm1 ipc/msg.c |5 ++--- ipc/sem.c | 10 -- ipc

[PATCH -mm1 1/2] fixing idr_find() locking

2007-09-27 Thread Nadia . Derbey
phore. . ipc_lock() now takes the mutex as a reader during the idr_find(). . a new routine ipc_lock_down() has been defined: it doesn't take the mutex, assuming that it is being held by the caller. This is the routine that is now called in all the update paths. Signed-off-by: Na

[PATCH -mm1 0/2] Fix unlocked call to idr_find()

2007-09-27 Thread Nadia . Derbey
This a series of 2 patches that should be applied on top of the other ipc patches, in 2.6.23-rc6-mm1. The first one is an answer to the following issue pointed out by Jarek: > Jarek Poplawski wrote: > 1. ipc_lock() and ipc_lock_check() are used without ipc_ids.mutex, > but it's probably wrong: t

Re: 2.6.23-rc6-mm1: IPC: sleeping function called ...

2007-09-24 Thread Nadia Derbey
Jarek Poplawski wrote: On Thu, Sep 20, 2007 at 03:08:42PM +0200, Nadia Derbey wrote: Nadia Derbey wrote: Jarek Poplawski wrote: On Thu, Sep 20, 2007 at 08:24:58AM +0200, Nadia Derbey wrote: ... Actually, ipc_lock() is called most of the time without the ipc_ids.mutex held and without

Re: 2.6.23-rc6-mm1: IPC: sleeping function called ...

2007-09-24 Thread Nadia Derbey
Jarek Poplawski wrote: On Fri, Sep 21, 2007 at 01:03:47PM +0200, Jarek Poplawski wrote: ... I hope not! But, then it would be probably another logical trick: ipc_rcu_getref/putref() seems to prevent kfreeing of a structure, so if it's used in do_msgsnd() there should be a risk something can do

Re: 2.6.23-rc6-mm1: IPC: sleeping function called ...

2007-09-21 Thread Nadia Derbey
Jarek Poplawski wrote: On Thu, Sep 20, 2007 at 03:08:42PM +0200, Nadia Derbey wrote: Nadia Derbey wrote: Jarek Poplawski wrote: On Thu, Sep 20, 2007 at 08:24:58AM +0200, Nadia Derbey wrote: ... Actually, ipc_lock() is called most of the time without the ipc_ids.mutex held and without

Re: 2.6.23-rc6-mm1: IPC: sleeping function called ...

2007-09-21 Thread Nadia Derbey
Andrew Morton wrote: On Tue, 18 Sep 2007 16:55:19 +0200 Nadia Derbey <[EMAIL PROTECTED]> wrote: This patch fixes the missing rcu_read_(un)lock in the ipc code Thanks. Could you please check the code comments in ipc/util.c for accuracy and completeness sometime? Done - see atta

Re: 2.6.23-rc6-mm1: IPC: sleeping function called ...

2007-09-20 Thread Nadia Derbey
Nadia Derbey wrote: Jarek Poplawski wrote: On Thu, Sep 20, 2007 at 08:24:58AM +0200, Nadia Derbey wrote: Jarek Poplawski wrote: On 18-09-2007 16:55, Nadia Derbey wrote: ... Well, reviewing the code I found another place where the rcu_read_unlock() was missing. I'm so sorry fo

Re: 2.6.23-rc6-mm1: IPC: sleeping function called ...

2007-09-20 Thread Nadia Derbey
Jarek Poplawski wrote: On Thu, Sep 20, 2007 at 08:24:58AM +0200, Nadia Derbey wrote: Jarek Poplawski wrote: On 18-09-2007 16:55, Nadia Derbey wrote: ... Well, reviewing the code I found another place where the rcu_read_unlock() was missing. I'm so sorry for the inconvenience. It&#

Re: 2.6.23-rc6-mm1: IPC: sleeping function called ...

2007-09-19 Thread Nadia Derbey
Jarek Poplawski wrote: On 18-09-2007 16:55, Nadia Derbey wrote: ... Well, reviewing the code I found another place where the rcu_read_unlock() was missing. I'm so sorry for the inconvenience. It's true that I should have tested with CONFIG_PREEMPT=y :-( Now, the ltp tests pass even

Re: 2.6.23-rc6-mm1: IPC: sleeping function called ...

2007-09-18 Thread Nadia Derbey
e. Regards, Nadia This patch fixes the missing rcu_read_(un)lock in the ipc code Signed-off-by: Nadia Derbey <[EMAIL PROTECTED]> --- ipc/util.c |3 ++- ipc/util.h |4 +++- 2 files changed, 5 insertions(+),

Re: 2.6.23-rc6-mm1: IPC: sleeping function called ...

2007-09-18 Thread Nadia Derbey
Andrew Morton wrote: On Tue, 18 Sep 2007 13:17:28 +0400 Alexey Dobriyan <[EMAIL PROTECTED]> wrote: I'm getting tons of this, and X fails to start CONFIG_SYSVIPC=y CONFIG_SYSVIPC_SYSCTL=y # CONFIG_PREEMPT_NONE is not set # CONFIG_PREEMPT_VOLUNTARY is not set CONFIG_PREEMPT=y CONFIG_PREEMPT_BKL

[PATCH -mm1] Storing ipcs into IDRs

2007-09-14 Thread Nadia . Derbey
. Signed-off-by: Nadia Derbey <[EMAIL PROTECTED]> --- This patch applies on top of 2.6.23-rc4-mm1 + the previous IPC patches. Hopefully this will make review and application easier for anyone already familiar with this series. ipc/msg.c | 14 ++ ipc/sem.c

Re: [RFC][PATCH 1/6] Storing ipcs into IDRs

2007-09-07 Thread Nadia Derbey
Nadia Derbey wrote: Andi Kleen wrote: [EMAIL PROTECTED] writes: This patch introduces ipcs storage into IDRs. The main changes are: . This ipc_ids structure is changed: the entries array is changed into a root idr structure. . The grow_ary() routine is removed: it is not needed

Re: [RFC][PATCH 1/6] Storing ipcs into IDRs

2007-09-06 Thread Nadia Derbey
Andi Kleen wrote: [EMAIL PROTECTED] writes: This patch introduces ipcs storage into IDRs. The main changes are: . This ipc_ids structure is changed: the entries array is changed into a root idr structure. . The grow_ary() routine is removed: it is not needed anymore when adding an ipc

Re: [RFC][PATCH 1/6] Storing ipcs into IDRs

2007-09-03 Thread Nadia Derbey
Nadia -- === Name.. Nadia DERBEY Organization.. BULL/DT/OSwR&D/Linux --- Email. mailto:[EMAIL PROTECTED] Address... BULL, B.P. 208, 38432 Echirolles Cedex, France Tel... (33) 76

[RFC][PATCH 6/6] Inlining ipc_buildid()

2007-08-31 Thread Nadia . Derbey
[PATCH 06/06] This is a trivial patch that changes the ipc_buildid() routine into a static inline. Signed-off-by: Nadia Derbey <[EMAIL PROTECTED]> --- ipc/util.c |5 - ipc/util.h |6 +- 2 files changed, 5 insertions(+), 6 deletions(-) Index: linux-2.6.23-r

[RFC][PATCH 5/6] Introducing the ipcid_to_idx macro

2007-08-31 Thread Nadia . Derbey
[PATCH 05/06] This is a trivial patch that changes all the (id % SEQ_MULTIPLIER) into a call to the ipcid_to_idx(id) macro. Signed-off-by: Nadia Derbey <[EMAIL PROTECTED]> --- ipc/util.c |4 ++-- ipc/util.h |2 ++ 2 files changed, 4 insertions(+), 2 deletions(-)

[RFC][PATCH 4/6] Integrating ipc_checkid() into ipc_lock()

2007-08-31 Thread Nadia . Derbey
[PATCH 04/06] This patch introduces a new ipc_lock_check() routine interface: . each time ipc_checkid() is called, this is done after calling ipc_lock(). ipc_checkid() is now called from inside ipc_lock_check(). Signed-off-by: Nadia Derbey <[EMAIL PROTECTED]> --- ipc

[RFC][PATCH 3/6] Removing the ipc_get() routine

2007-08-31 Thread Nadia . Derbey
[PATCH 03/06] This is a trivial patch that removes the ipc_get() routine: it is replaced by a call to idr_find(). Signed-off-by: Nadia Derbey <[EMAIL PROTECTED]> --- ipc/shm.c | 16 +--- ipc/util.c | 19 --- ipc/util.h |1 - 3 files chang

[RFC][PATCH 2/6] Unifying the syscalls code

2007-08-31 Thread Nadia . Derbey
[PATCH 02/06] This patch introduces a change into the sys_msgget(), sys_semget() and sys_shmget() routines: they now share a common code, which is better for maintainability. Signed-off-by: Nadia Derbey <[EMAIL PROTECTED]> --- ipc/msg.c | 61 ++-- ipc

[RFC][PATCH 1/6] Storing ipcs into IDRs

2007-08-31 Thread Nadia . Derbey
argument to the routine Signed-off-by: Nadia Derbey <[EMAIL PROTECTED]> --- include/linux/ipc.h |1 include/linux/msg.h |1 include/linux/sem.h |1 include/linux/shm.h |1 ipc/msg.c | 113 +- ipc/sem.c | 111

[RFC][PATCH 0/6] An IPC implementation base on Linux IDRs

2007-08-31 Thread Nadia . Derbey
A couple of months ago, I dropped a series of patches that introduced the AKT framework (Automatic Kernel Tunables). (see thread http://lkml.org/lkml/2007/1/16/16) When reading the patches, people complained that I was trying to treat a symptom, not the problem itself, and that it'd be better try

Re: Change in default vm_dirty_ratio

2007-06-21 Thread Nadia Derbey
Dave Jones wrote: On Mon, Jun 18, 2007 at 04:47:11PM -0700, Andrew Morton wrote: > Frankly, I find it very depressing that the kernel defaults matter. These > things are trivially tunable and you'd think that after all these years, > distro initscripts would be establishing the settings, bas

Re: [RFC][PATCH 1/6] Storing ipcs into radix trees

2007-06-08 Thread Nadia Derbey
Ingo Oeser wrote: Hi Nadia, good to see someone is pounding this old beast again :-) On Thursday 07 June 2007, [EMAIL PROTECTED] wrote: Index: linux-2.6.21/ipc/util.h === --- linux-2.6.21.orig/ipc/util.h2007-06-07 11:00:3

[RFC][PATCH 6/6] Introducing msg_findkey() sem_findkey() and shm_findkey()

2007-06-07 Thread Nadia . Derbey
[PATCH 06/06] This is a trivial patch that changes all the calls to casted ipc_findkey() into calls to static inline routines that do the cast themselves. Signed-off-by: Nadia Derbey <[EMAIL PROTECTED]> --- ipc/msg.c |8 +++- ipc/sem.c |8 +++- ipc/shm.c |8 +

[RFC][PATCH 4/6] Integrating ipc_checkid() into ipc_lock()

2007-06-07 Thread Nadia . Derbey
called from inside ipc_lock(). Signed-off-by: Nadia Derbey <[EMAIL PROTECTED]> --- ipc/msg.c | 65 ++- ipc/sem.c | 74 - ipc/shm.c

[RFC][PATCH 5/6] Introducing the ipcid_to_idx macro

2007-06-07 Thread Nadia . Derbey
[PATCH 05/06] This is a trivial patch that changes all the (id % SEQ_MULTIPLIER) into a call to the ipcid_to_idx(id) macro. Signed-off-by: Nadia Derbey <[EMAIL PROTECTED]> --- ipc/msg.c |2 +- ipc/sem.c |3 +-- ipc/shm.c |6 ++ ipc/util.c | 10 +- ipc/

[RFC][PATCH 3/6] Changing the loops on a single ipcid into radix_tree_gang_lookup() calls

2007-06-07 Thread Nadia . Derbey
job. Signed-off-by: Nadia Derbey <[EMAIL PROTECTED]> --- ipc/msg.c | 24 ++--- ipc/sem.c | 25 ++ ipc/shm.c | 82 + ipc/util.c | 21 --- ipc/util.h |1 5 files chang

[RFC][PATCH 2/6] Changing ipc_rmid() interface

2007-06-07 Thread Nadia . Derbey
argument to the routine Signed-off-by: Nadia Derbey <[EMAIL PROTECTED]> --- ipc/msg.c | 16 ++-- ipc/sem.c | 16 ++-- ipc/shm.c |6 +++--- ipc/util.c | 15 +++ ipc/util.h |2 +- 5 files changed, 31 insertions(+), 24 deletions(-) Index:

[RFC][PATCH 1/6] Storing ipcs into radix trees

2007-06-07 Thread Nadia . Derbey
to radix trees introduction Signed-off-by: Nadia Derbey <[EMAIL PROTECTED]> --- include/linux/ipc.h |1 include/linux/msg.h |1 include/linux/sem.h |1 include/linux/shm.h |1 ipc/msg.c | 64 ++--- ipc/sem.c | 63 ++-- ipc

[RFC][PATCH 0/6] an IPC implementation based on Linux radix trees

2007-06-07 Thread Nadia . Derbey
-- A couple of months ago, I dropped a series of patches that introduced the AKT framework (Automatic Kernel Tunables). (see thread http://lkml.org/lkml/2007/1/16/16) When reading the patches people complained that I was trying to treat a symptom, not the problem itself, and that it'd be better

Re: [RFC][PATCH 6/6] automatic tuning applied to some kernel components

2007-02-15 Thread Nadia Derbey
Eric W. Biederman wrote: Nadia Derbey <[EMAIL PROTECTED]> writes: But, what do you do with Oracle that's asking maxfiles to be set to 0x1, while the default value might be enough for a system that's not running Oracle. I'm afraid that giving boot time values to the m

Re: [RFC][PATCH 6/6] automatic tuning applied to some kernel components

2007-02-14 Thread Nadia Derbey
Eric W. Biederman wrote: Nadia Derbey <[EMAIL PROTECTED]> writes: So, should I understand from this that automatic tuning and the AKT framework itself would make sense, given that I find the rigth tunables it should be applied to? Sort of. The concept of things tuning them

Re: [PATCH 1/6] AKT - Tunable structure and registration routines

2007-02-13 Thread Nadia Derbey
Andi Kleen wrote: [EMAIL PROTECTED] writes: + +This feature aims at making the kernel automatically change the tunables +values as it sees resources running out. The only reason we have resource limit is to avoid DOS when one resource consumes too much memory. When there is no such danger t

Re: [RFC][PATCH 6/6] automatic tuning applied to some kernel components

2007-02-13 Thread Nadia Derbey
Eric W. Biederman wrote: Nadia Derbey <[EMAIL PROTECTED]> writes: I do not fully agree with you: It is true that some ipc tunables play the role of DoS limits. But IMHO the *mni ones (semmni, msgmni, shmmni) are used by the ipc subsystem to adapt its data structures sizes to what is

Re: [RFC][PATCH 6/6] automatic tuning applied to some kernel components

2007-02-09 Thread Nadia Derbey
Eric W. Biederman wrote: Nadia Derbey <[EMAIL PROTECTED]> writes: 2) why autotuning: There are at least 3 cases where it can be useful . for workloads that are known to need a big amount of a given resource type (say shared memories), but we don't know what the maximum amount nee

[PATCH 4/6] AKT - min and max kobjects

2007-01-30 Thread Nadia . Derbey
[PATCH 04/06] Introduces the kobjects associated to each tunable min and max value Signed-off-by: Nadia Derbey <[EMAIL PROTECTED]> --- include/linux/akt.h | 14 kernel/autotune/akt.c | 148 kernel/autotune/akt_sysfs.c

[PATCH 6/6] AKT - automatic tuning applied to some kernel components

2007-01-30 Thread Nadia . Derbey
[PATCH 06/06] The following kernel components register a tunable structure and call the auto-tuning routine: . file system . shared memory (per namespace) . semaphore (per namespace) . message queues (per namespace) Signed-off-by: Nadia Derbey <[EMAIL PROTECTED]> --- fs/file_t

[PATCH 5/6] AKT - per namespace tunables

2007-01-30 Thread Nadia . Derbey
[PATCH 05/06] This patch introduces all that is needed to process per namespace tunables. Signed-off-by: Nadia Derbey <[EMAIL PROTECTED]> --- include/linux/akt.h | 12 ++ kernel/autotune/akt.c | 94 +- 2 files changed, 83 inse

[PATCH 3/6] AKT - tunables associated kobjects

2007-01-30 Thread Nadia . Derbey
[PATCH 03/06] Introduces the kobjects associated to each tunable and the sysfs registration Signed-off-by: Nadia Derbey <[EMAIL PROTECTED]> --- include/linux/akt.h | 25 - init/main.c |1 kernel/autotune/Makefile|2 kernel/autotune

[PATCH 2/6] AKT - auto_tuning activation

2007-01-30 Thread Nadia . Derbey
[PATCH 02/06] Introduces the auto-tuning activation routine The auto-tuning routine is called by the fork kernel component Signed-off-by: Nadia Derbey <[EMAIL PROTECTED]> --- include/linux/akt.h | 51 +++ kernel/exit.c

[PATCH 1/6] AKT - Tunable structure and registration routines

2007-01-30 Thread Nadia . Derbey
. Signed-off-by: Nadia Derbey <[EMAIL PROTECTED]> --- Documentation/00-INDEX |2 Documentation/auto_tune.txt | 333 include/linux/akt.h | 166 + include/linux/akt_ops.h | 109 ++ init/K

[PATCH 0/6] AKT - Automatic Kernel Tunables

2007-01-30 Thread Nadia . Derbey
Re-sending the series of patches for the automatic kernel tunables feature: have done some fixes after the remarks sent back by Andrew and Randy. 1) All the type independent macros have been removed, except for the automatic tuning routine: it manages pointers to the tunable and to the value to be

Re: [RFC][PATCH 1/6] Tunable structure and registration routines

2007-01-25 Thread Nadia Derbey
Randy Dunlap wrote: On Thu, 25 Jan 2007 17:26:31 +0100 Nadia Derbey wrote: +Any kernel subsystem that has registered a tunable should call +auto_tune_func() as follows: + ++-++ +| Step| Routine to call

Re: [RFC][PATCH 4/6] min and max kobjects

2007-01-25 Thread Nadia Derbey
Randy Dunlap wrote: On Tue, 16 Jan 2007 07:15:20 +0100 [EMAIL PROTECTED] wrote: [PATCH 04/06] Introduces the kobjects associated to each tunable min and max value Index: linux-2.6.20-rc4/kernel/autotune/akt.c === --- linux-

Re: [RFC][PATCH 1/6] Tunable structure and registration routines

2007-01-25 Thread Nadia Derbey
Randy, Thanks for reviewing the code! My comments embedded. I'll re-send the patches as soon as possible. Regards, Nadia Randy Dunlap wrote: On Tue, 16 Jan 2007 07:15:17 +0100 [EMAIL PROTECTED] wrote: [PATCH 01/06] +Any kernel subsystem that has registered a tunable should call +auto

Re: [RFC][PATCH 6/6] automatic tuning applied to some kernel components

2007-01-23 Thread Nadia Derbey
Andrew Morton wrote: On Tue, 16 Jan 2007 07:15:22 +0100 [EMAIL PROTECTED] wrote: The following kernel components register a tunable structure and call the auto-tuning routine: . file system . shared memory (per namespace) . semaphore (per namespace) . message queues (per namespace) This is

  1   2   >