Re: [PATCH v2 2/4] x86/mce, EDAC/mce_amd: Add support for new MCA_SYND{1,2} registers

2024-07-10 Thread Naik, Avadhut
On 7/10/2024 04:38, Borislav Petkov wrote: > On Tue, Jul 09, 2024 at 01:27:25AM -0500, Naik, Avadhut wrote: > >> Userspace error decoding tools like the rasdaemon gather related hardware >> error >> information through the tracepoints. As such, its important to have t

Re: [PATCH v2 4/4] EDAC/mce_amd: Add support for FRU Text in MCA

2024-07-08 Thread Naik, Avadhut
On 6/26/2024 13:20, Borislav Petkov wrote: > On Wed, Jun 26, 2024 at 01:00:30PM -0500, Naik, Avadhut wrote: >>> >>> Why are you clearing it if you're overwriting it immediately? >>> >> Since its a local variable, wanted to ensure that the memory is zer

Re: [PATCH v2 2/4] x86/mce, EDAC/mce_amd: Add support for new MCA_SYND{1,2} registers

2024-07-08 Thread Naik, Avadhut
On 6/26/2024 13:18, Borislav Petkov wrote: > On Wed, Jun 26, 2024 at 12:24:20PM -0500, Naik, Avadhut wrote: >> >> >> On 6/26/2024 06:10, Borislav Petkov wrote: >>> On Tue, Jun 25, 2024 at 02:56:22PM -0500, Avadhut Naik wrote: >>>> AMD's Scala

[PATCH v2 4/4] EDAC/mce_amd: Add support for FRU Text in MCA

2024-06-26 Thread Naik, Avadhut
On 6/26/2024 07:04, Borislav Petkov wrote: > On Tue, Jun 25, 2024 at 02:56:24PM -0500, Avadhut Naik wrote: >> From: Yazen Ghannam >> >> A new "FRU Text in MCA" feature is defined where the Field Replaceable >> Unit (FRU) Text for a device is represented by a string in the new >> MCA_SYND1 and M

Re: [PATCH v2 3/4] x86/mce/apei: Handle variable register array size

2024-06-26 Thread Naik, Avadhut
On 6/26/2024 06:57, Borislav Petkov wrote: > On Tue, Jun 25, 2024 at 02:56:23PM -0500, Avadhut Naik wrote: >> From: Yazen Ghannam >> >> ACPI Boot Error Record Table (BERT) is being used by the kernel to >> report errors that occurred in a previous boot. On some modern AMD >> systems, these very

[PATCH v2 2/4] x86/mce, EDAC/mce_amd: Add support for new MCA_SYND{1,2} registers

2024-06-26 Thread Naik, Avadhut
On 6/26/2024 06:10, Borislav Petkov wrote: > On Tue, Jun 25, 2024 at 02:56:22PM -0500, Avadhut Naik wrote: >> AMD's Scalable MCA systems viz. Genoa will include two new registers: > > "viz."? > Right. Will mention Zen4 instead of Genoa. > Not a lot of people outside of AMD know what Genoa is.

Re: [PATCH 0/4] MCE wrapper and support for new SMCA syndrome MSRs

2024-06-21 Thread Naik, Avadhut
On 6/21/2024 15:01, Yazen Ghannam wrote: > On Fri, Jun 21, 2024 at 06:58:23PM +0200, Borislav Petkov wrote: >> On Thu, May 30, 2024 at 04:16:16PM -0500, Avadhut Naik wrote: >>> arch/x86/include/asm/mce.h | 20 ++- >>> arch/x86/kernel/cpu/mce/apei.c | 111 ++ >>

[PATCH v4 2/2] tracing: Include Microcode Revision in mce_record tracepoint

2024-03-27 Thread Naik, Avadhut
On 3/27/2024 17:35, Borislav Petkov wrote: > On Wed, Mar 27, 2024 at 03:31:01PM -0700, Sohil Mehta wrote: >> On 3/27/2024 1:54 PM, Avadhut Naik wrote: >> >>> - TP_printk("CPU: %d, MCGc/s: %llx/%llx, MC%d: %016Lx, IPID: %016Lx, >>> ADDR/MISC/SYND: %016Lx/%016Lx/%016Lx, RIP: %02x:<%016Lx>, TSC:

Re: [PATCH v4 2/2] tracing: Include Microcode Revision in mce_record tracepoint

2024-03-27 Thread Naik, Avadhut
On 3/27/2024 17:31, Sohil Mehta wrote: > On 3/27/2024 1:54 PM, Avadhut Naik wrote: > >> -TP_printk("CPU: %d, MCGc/s: %llx/%llx, MC%d: %016Lx, IPID: %016Lx, >> ADDR/MISC/SYND: %016Lx/%016Lx/%016Lx, RIP: %02x:<%016Lx>, TSC: %llx, PPIN: >> %llx, PROCESSOR: %u:%x, TIME: %llu, SOCKET: %u, APIC

Re: [PATCH v3 0/2] Update mce_record tracepoint

2024-03-25 Thread Naik, Avadhut
On 3/25/2024 15:31, Borislav Petkov wrote: > On Mon, Mar 25, 2024 at 03:12:14PM -0500, Naik, Avadhut wrote: >> Can this patchset be merged in? Or would you prefer me sending out >> another revision with Steven's "Reviewed-by:" tag? > > First of all, please d

[PATCH v3 0/2] Update mce_record tracepoint

2024-03-25 Thread Naik, Avadhut
Hi Boris, Can this patchset be merged in? Or would you prefer me sending out another revision with Steven's "Reviewed-by:" tag? On 2/8/2024 11:10, Steven Rostedt wrote: > On Fri, 26 Jan 2024 01:57:58 -0600 > Avadhut Naik wrote: > >> This patchset updates the mce_record tracepoint so that the re

Re: [PATCH v2 2/2] tracing: Include Microcode Revision in mce_record tracepoint

2024-01-25 Thread Naik, Avadhut
On 1/25/2024 3:03 PM, Sohil Mehta wrote: > On 1/25/2024 10:48 AM, Avadhut Naik wrote: >> Currently, the microcode field (Microcode Revision) of struct mce is not >> exported to userspace through the mce_record tracepoint. >> >> Export it through the tracepoint as it may provide useful informatio

Re: [PATCH v2 0/2] Update mce_record tracepoint

2024-01-25 Thread Naik, Avadhut
Hi, On 1/25/2024 1:19 PM, Luck, Tony wrote: >>> The first patch adds PPIN (Protected Processor Inventory Number) field to >>> the tracepoint. >>> >>> The second patch adds the microcode field (Microcode Revision) to the >>> tracepoint. >> >> This is a lot of static information to add to *every* MC

[PATCH] tracing: Include PPIN in mce_record tracepoint

2024-01-23 Thread Naik, Avadhut
Hi, On 1/23/2024 6:12 PM, Tony Luck wrote: > On Tue, Jan 23, 2024 at 05:51:50PM -0600, Avadhut Naik wrote: >> Machine Check Error information from struct mce is exported to userspace >> through the mce_record tracepoint. >> >> Currently, however, the PPIN (Protected Processor Inventory Number) fie