[PATCH v3 3/6] perf tools: Decompress kernel module when reading DSO data

2017-06-07 Thread Namhyung Kim
Currently perf decompresses kernel modules when loading symbol table but it missed to do it when reading raw data. Signed-off-by: Namhyung Kim --- tools/perf/util/dso.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/tools/perf/util/dso.c b/tools/perf/util

Re: [PATCH] perf symbols: Fix plt entry calculation for ARM and AARCH64

2017-06-05 Thread Namhyung Kim
adrpx16, 1 <__FRAME_END__+0xf8a8> > 594: f944c611ldr x17, [x16,#2440] > 598: 91262210add x16, x16, #0x988 > 59c: d61f0220br x17 > > NOTES: > In addition to ARM and AARCH64, other architectures, such as > s390/alpha/

Re: [PATCH v2 3/3] perf test: Decompress kernel module before objdump

2017-06-05 Thread Namhyung Kim
Hi Adrian, On Mon, Jun 5, 2017 at 8:13 PM, Adrian Hunter wrote: > On 03/06/17 05:00, Namhyung Kim wrote: >> If a kernel modules is compressed, it should be decompressed before >> running objdump to parse binary data correctly. This fixes a failure of >> object cod

Re: [PATCH v2 1/3] perf tools: Introduce dso__decompress_kmodule_{fd,path}

2017-06-05 Thread Namhyung Kim
Hi Jiri, On Mon, Jun 5, 2017 at 6:58 PM, Jiri Olsa wrote: > On Sat, Jun 03, 2017 at 11:00:31AM +0900, Namhyung Kim wrote: >> Move decompress_kmodule() to util/dso.c and split it to two functions >> returning fd and (decompressed) file path. Existing user only wants the >&g

Re: [PATCH 6/7] perf report: mark inlined frames in output by " (inlined)" suffix

2017-06-05 Thread Namhyung Kim
On Sat, Jun 3, 2017 at 10:51 PM, Milian Wolff wrote: > On Montag, 22. Mai 2017 14:48:18 CEST Namhyung Kim wrote: >> On Thu, May 18, 2017 at 09:34:10PM +0200, Milian Wolff wrote: >> > The original patch that introduced inline frame output in the >> > various browsers us

[PATCH v2 2/3] perf tools: Decompress kernel module when reading DSO data

2017-06-02 Thread Namhyung Kim
Currently perf decompresses kernel modules when loading symbol table but it missed to do it when reading raw data. Signed-off-by: Namhyung Kim --- tools/perf/util/dso.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/tools/perf/util/dso.c b/tools/perf/util

[PATCH v2 3/3] perf test: Decompress kernel module before objdump

2017-06-02 Thread Namhyung Kim
If a kernel modules is compressed, it should be decompressed before running objdump to parse binary data correctly. This fixes a failure of object code reading test for me. Signed-off-by: Namhyung Kim --- tools/perf/tests/code-reading.c | 26 +- 1 file changed, 25

[PATCH v2 1/3] perf tools: Introduce dso__decompress_kmodule_{fd,path}

2017-06-02 Thread Namhyung Kim
Move decompress_kmodule() to util/dso.c and split it to two functions returning fd and (decompressed) file path. Existing user only wants the fd version but the path version will be used soon. Signed-off-by: Namhyung Kim --- tools/perf/util/dso.c| 51

Re: [PATCH 1/2] perf tools: Decompress kernel module when reading DSO data

2017-06-02 Thread Namhyung Kim
On Thu, Jun 1, 2017 at 8:29 PM, Jiri Olsa wrote: > On Thu, Jun 01, 2017 at 06:06:04PM +0900, Namhyung Kim wrote: > > SNIP > >> - } >> - >> - unlink(tmpbuf); >> - >> -out: >> - free(m.ext); >> - return fd; >>

Re: [PATCH 1/2] perf tools: Decompress kernel module when reading DSO data

2017-06-02 Thread Namhyung Kim
Hi Jiri, On Thu, Jun 1, 2017 at 8:29 PM, Jiri Olsa wrote: > On Thu, Jun 01, 2017 at 06:06:04PM +0900, Namhyung Kim wrote: > > SNIP > >> @@ -399,6 +438,7 @@ static int __open_dso(struct dso *dso, struct machine >> *machine) >> int fd; >> char *

[PATCH 2/2] perf test: Decompress kernel module before objdump

2017-06-01 Thread Namhyung Kim
If a kernel modules is compressed, it should be decompressed before running objdump to parse binary data correctly. This fixes a failure of object code reading test for me. Signed-off-by: Namhyung Kim --- tools/perf/tests/code-reading.c | 29 - 1 file changed, 28

[PATCH 1/2] perf tools: Decompress kernel module when reading DSO data

2017-06-01 Thread Namhyung Kim
Currently perf decompresses kernel modules when loading symbol table but it missed to do it when reading raw data. Move decompress_kmodule() to util/dso.c and do not unlink it immediately. Signed-off-by: Namhyung Kim --- tools/perf/util/dso.c| 56

[PATCH 2/3] perf tools: Set module info when build-id event found

2017-05-31 Thread Namhyung Kim
Like machine__findnew_module_dso(), it should set necessary info for kernel modules to find symbol info from the file. Factor out dso__set_module_info() to do it. This is needed for dso__needs_decompress() to detect such DSOs. Signed-off-by: Namhyung Kim --- tools/perf/util/dso.c | 15

[PATCH 3/3] perf tools: Use correct filename for compressed modules in build-id cache

2017-05-31 Thread Namhyung Kim
0.00% as [scsi_mod][k] scsi_sg_alloc 0.00% cc1 [scsi_mod][k] scsi_setup_cmnd 0.00% cc1 [scsi_mod][k] scsi_get_command Signed-off-by: Namhyung Kim --- tools/perf/util/symbol-elf.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/to

[PATCH 1/3] perf tools: Set proper module name when build-id event found

2017-05-31 Thread Namhyung Kim
scsi/scsi_mod.ko.gz with build id cafe1ce6ca13a98a5d9ed3425cde249e57a27fc1 not found, continuing without symbols ... Now it shows the build-id but still cannot load the symbol table. This is a different problem which will be fixed in the next patch. Signed-off-by: Namhyung Kim -

Re: [PATCH 0/7] generate full callchain cursor entries for inlined frames

2017-05-29 Thread Namhyung Kim
On Mon, May 29, 2017 at 08:36:25PM +0200, Milian Wolff wrote: > On Mittwoch, 24. Mai 2017 17:02:37 CEST Namhyung Kim wrote: > > On Wed, May 24, 2017 at 03:42:59PM +0200, Milian Wolff wrote: > > > If you think the above is not a valid assessment, I'll try to change my > &

Re: [PATCH v2 13/13] perf tools: add feature header record to pipe-mode

2017-05-24 Thread Namhyung Kim
On Tue, May 23, 2017 at 12:48:53AM -0700, David Carrillo-Cisneros wrote: > Add header record types to pipe-mode, reusing the functions > used in file-mode and leveraging the new struct feat_fd. > > Add the perf_event__synthesize_feature event call back to > process the new header records. > > Bef

Re: [PATCH v2 01/13] perf header: encapsulate read and swap

2017-05-24 Thread Namhyung Kim
On Tue, May 23, 2017 at 12:48:41AM -0700, David Carrillo-Cisneros wrote: > Most callers of readn in perf header read either a 32 or a 64 bits > number, error check it and swap it, if necessary. > > Create do_read_u32 and do_read_u64 to simplify this usage. > > Signed-off-by: David Carrillo-Cisner

Re: [PATCH 0/7] generate full callchain cursor entries for inlined frames

2017-05-24 Thread Namhyung Kim
On Wed, May 24, 2017 at 03:42:59PM +0200, Milian Wolff wrote: > On Wednesday, May 24, 2017 1:46:04 PM CEST Milian Wolff wrote: > > On Monday, May 22, 2017 11:06:43 AM CEST Namhyung Kim wrote: > > > Why not making the fake symbol has start addr of the sample IP and > > >

Re: [PATCH 4/7] perf script: Add --inline option

2017-05-24 Thread Namhyung Kim
On Wed, May 24, 2017 at 08:38:11AM +0200, Ingo Molnar wrote: > > * Namhyung Kim wrote: > > > The --inline option is to show inlined functions in callchains. > > > > For example, > > > > $ perf script > > a.out 5644 11611.467597: 30996

[tip:perf/urgent] perf tools: Put caller above callee in --children mode

2017-05-24 Thread tip-bot for Namhyung Kim
Commit-ID: 711160a68f55d864200cd6c7677319e5c242 Gitweb: http://git.kernel.org/tip/711160a68f55d864200cd6c7677319e5c242 Author: Namhyung Kim AuthorDate: Wed, 24 May 2017 15:21:29 +0900 Committer: Ingo Molnar CommitDate: Wed, 24 May 2017 08:41:49 +0200 perf tools: Put caller

[tip:perf/urgent] perf script: Add --inline option for debugging

2017-05-24 Thread tip-bot for Namhyung Kim
Commit-ID: 325fbff51f961491adff4037d0e0a94d6132bd9b Gitweb: http://git.kernel.org/tip/325fbff51f961491adff4037d0e0a94d6132bd9b Author: Namhyung Kim AuthorDate: Wed, 24 May 2017 15:21:26 +0900 Committer: Ingo Molnar CommitDate: Wed, 24 May 2017 08:41:48 +0200 perf script: Add --inline

[PATCH 1/7] perf report: don't crash on invalid maps in `-g srcline` mode

2017-05-23 Thread Namhyung Kim
dependency from another change] Signed-off-by: Namhyung Kim --- tools/perf/util/callchain.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/tools/perf/util/callchain.c b/tools/perf/util/callchain.c index 81fc29ac798f..b4204b43ed58 100644 --- a/tools/perf/util/callchai

[PATCH 6/7] perf report: do not drop last inlined frame

2017-05-23 Thread Namhyung Kim
start (a.out) ~ Cc: Arnaldo Carvalho de Melo Cc: David Ahern Cc: Peter Zijlstra Cc: Yao Jin Signed-off-by: Milian Wolff Signed-off-by: Namhyung Kim --- tools/perf/util/srcline.c | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/tools/perf/util/srcline.c

[PATCH 7/7] perf tools: Fix to put caller above callee in children mode

2017-05-23 Thread Namhyung Kim
mmand Shared ObjectSymbol # ... ... . # 99.61% 0.00% a.outa.out[.] _start 99.61% 0.00% a.outlibc-2.25.so [.] __libc_start_main 99.54%99.44% a.outa.out[.] main Cc: Frederic Weisbecker Cc: Milian Wolff Acked-by: Jiri

[PATCH 4/7] perf script: Add --inline option

2017-05-23 Thread Namhyung Kim
tested-by: Milian Wolff Signed-off-by: Namhyung Kim --- tools/perf/Documentation/perf-script.txt | 4 tools/perf/builtin-script.c | 2 ++ tools/perf/util/evsel_fprintf.c | 33 3 files changed, 39 insertions(+) diff --git a/t

[PATCH 3/7] perf report: fix off-by-one for non-activation frames

2017-05-23 Thread Namhyung Kim
ff-by: Milian Wolff Signed-off-by: Namhyung Kim --- tools/perf/util/unwind-libdw.c | 6 +- tools/perf/util/unwind-libunwind-local.c | 11 +++ 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/tools/perf/util/unwind-libdw.c b/tools/perf/util/unwind-libdw.c

[PATCH 2/7] perf report: fix memory leak in addr2line when called by addr2inlines

2017-05-23 Thread Namhyung Kim
: Peter Zijlstra Cc: Yao Jin Signed-off-by: Milian Wolff Signed-off-by: Namhyung Kim --- tools/perf/util/srcline.c | 23 +-- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/tools/perf/util/srcline.c b/tools/perf/util/srcline.c index df051a52393c..5e376d64d59e

[GIT PULL 0/7] perf/urgent callchain fixes

2017-05-23 Thread Namhyung Kim
script` also gained `--inline` option to show inlined functions with callchains. This helped to find a bug in the current inline code. (Namhyung Kim) - Fix missed callchain ordering with `-g callee/caller` when libbfd is not available. (Milian Wolff) - Reorder output entries in `perf

[PATCH 5/7] perf report: always honor callchain order for inlined nodes

2017-05-23 Thread Namhyung Kim
the need to reverse the list and also ensures that all callers construct the list in the right order. Cc: Arnaldo Carvalho de Melo Cc: David Ahern Cc: Peter Zijlstra Cc: Yao Jin Signed-off-by: Milian Wolff Signed-off-by: Namhyung Kim --- tools/perf/util/srcline.c | 18 -- 1

[PATCH] perf tools: Fix to put caller above callee in children mode

2017-05-22 Thread Namhyung Kim
mmand Shared ObjectSymbol # ... ... . # 99.61% 0.00% a.outa.out[.] _start 99.61% 0.00% a.outlibc-2.25.so [.] __libc_start_main 99.54%99.44% a.outa.out[.] main Cc: Frederic Weisbecker Cc: Milian Wolff Signed-off-by:

Re: [PATCH 6/7] perf report: mark inlined frames in output by " (inlined)" suffix

2017-05-22 Thread Namhyung Kim
Thanks, Namhyung > > Cc: Arnaldo Carvalho de Melo > Cc: David Ahern > Cc: Namhyung Kim > Cc: Peter Zijlstra > Cc: Yao Jin > Signed-off-by: Milian Wolff > --- > tools/perf/util/callchain.c | 10 +++--- > 1 file changed, 7 insertions(+), 3 deletions(-) >

Re: [PATCH 3/7] perf report: create real callchain entries for inlined frames

2017-05-22 Thread Namhyung Kim
On Thu, May 18, 2017 at 09:34:07PM +0200, Milian Wolff wrote: > + > + if (strcmp(funcname, base_sym->name) == 0) { > + // reuse the real, existing symbol I don't know whether it's required by coding style guide but please use C-style block comment if possible (especially for multil

Re: [PATCH 7/7] perf script: mark inlined frames and do not print DSO for them

2017-05-22 Thread Namhyung Kim
lian/projects/src/perf-tests/inlining) >20510 __libc_start_main (/usr/lib/libc-2.25.so) > bd9 _start > (/home/milian/projects/src/perf-tests/inlining) > > Cc: Arnaldo Carvalho de Melo > Cc: David Ahern > Cc: Namhyung Kim > Cc: Peter Zijlstra >

Re: [PATCH 0/7] generate full callchain cursor entries for inlined frames

2017-05-22 Thread Namhyung Kim
On Thu, May 18, 2017 at 09:34:04PM +0200, Milian Wolff wrote: > This series of patches completely reworks the way inline frames are handled. > Instead of querying for the inline nodes on-demand in the individual tools, > we now create proper callchain nodes for inlined frames. The advantages this >

Re: [PATCH 0/7] generate full callchain cursor entries for inlined frames

2017-05-22 Thread Namhyung Kim
Hi Milian, On Thu, May 18, 2017 at 10:05:36PM +0200, Milian Wolff wrote: > On Donnerstag, 18. Mai 2017 21:34:04 CEST Milian Wolff wrote: > > This series of patches completely reworks the way inline frames are handled. > > Instead of querying for the inline nodes on-demand in the individual tools,

Re: [PATCH v2] perf report: do not drop last inlined frame

2017-05-18 Thread Namhyung Kim
a4a main (/tmp/a.out) >20510 __libc_start_main (/usr/lib/libc-2.25.so) > bd9 _start (/tmp/a.out) > ~ > > Cc: Arnaldo Carvalho de Melo > Cc: David Ahern > Cc: Namhyung Kim > Cc: Peter Zijlstra > Cc: Yao Jin

Re: [PATCH v2] perf report: always honor callchain order for inlined nodes

2017-05-18 Thread Namhyung Kim
he nodes in the correct order within > inline_list__append. This removes the need to reverse the list > and also ensures that all callers construct the list in the right > order. > > Cc: Arnaldo Carvalho de Melo > Cc: David Ahern > Cc: Namhyung Kim > Cc: Peter Zijlstra >

Re: [PATCH v2] perf report: fix memory leak in addr2line when called by addr2inlines

2017-05-18 Thread Namhyung Kim
internal_command (perf.c:348) > ==16331==by 0x434371: run_argv (perf.c:392) > ==16331==by 0x434371: main (perf.c:530) > > Cc: Arnaldo Carvalho de Melo > Cc: David Ahern > Cc: Peter Zijlstra > Cc: Yao Jin > Signed-off-by: Milian Wolff Acked-by: Namhyung Kim Th

Re: [PATCH v3] perf report: fix off-by-one for non-activation frames

2017-05-18 Thread Namhyung Kim
--main signal.c:29 >| __libc_start_main >| _start >| > --49.51%--0x33a8f > raise .:0 > main signal.c:27 > __libc

[PATCH] perf report: Fix invalid warning on callchain param

2017-05-17 Thread Namhyung Kim
d sort-key, it shows invalid mode and order warnings. Change it to show a warning only if failed to parse the given token as any of valid parameter. Also code under try_numbers requires the token to be a number, it's good to show the warning there. Cc: Milian Wolff Cc: Frederic Weisbecker Si

Re: [PATCH v2] perf report: distinguish between inliners in the same function

2017-05-16 Thread Namhyung Kim
On Tue, May 16, 2017 at 03:18:13PM +0200, Milian Wolff wrote: > On Dienstag, 16. Mai 2017 02:53:32 CEST Namhyung Kim wrote: > > On Mon, May 15, 2017 at 12:01:54PM +0200, Milian Wolff wrote: > > > On Monday, May 15, 2017 3:21:58 AM CEST Namhyung Kim wrote: > > > > Hi M

Re: [PATCH v2] perf report: fix off-by-one for non-activation frames

2017-05-16 Thread Namhyung Kim
On Tue, May 16, 2017 at 06:26:47PM +0200, Milian Wolff wrote: > On Dienstag, 16. Mai 2017 18:17:26 CEST Milian Wolff wrote: > > On Dienstag, 16. Mai 2017 16:38:29 CEST Namhyung Kim wrote: > > > On Tue, May 16, 2017 at 10:59:51AM +0200, Milian Wolff wrote: > > >

Re: [PATCH] perf report: do not drop last inlined frame

2017-05-16 Thread Namhyung Kim
d::abs (inline) (/tmp/a.out) > a4a std::_Norm_helper::_S_do_it (inline) > (/tmp/a.out) > a4a std::norm (inline) (/tmp/a.out) > a4a main (/tmp/a.out) >20510 __libc_start_main (/usr/lib/libc-2.25.so)

Re: [PATCH] perf report: always honor callchain order for inlined nodes

2017-05-16 Thread Namhyung Kim
t; Cc: David Ahern > Cc: Namhyung Kim > Cc: Peter Zijlstra > Cc: Yao Jin > Signed-off-by: Milian Wolff > --- > tools/perf/util/srcline.c | 28 ++-- > 1 file changed, 14 insertions(+), 14 deletions(-) > > diff --git a/tools/perf/util/srcline

Re: [PATCH] perf report: fix memory leak in addr2line when called by addr2inlines

2017-05-16 Thread Namhyung Kim
internal_command (perf.c:348) > ==16331==by 0x434371: run_argv (perf.c:392) > ==16331==by 0x434371: main (perf.c:530) > > Cc: Arnaldo Carvalho de Melo > Cc: David Ahern > Cc: Namhyung Kim > Cc: Peter Zijlstra > Cc: Yao Jin > Signed-off-by: Milian Wolff > ---

Re: [PATCH v2] perf report: fix off-by-one for non-activation frames

2017-05-16 Thread Namhyung Kim
art > ~~~ > > Note how this patch fixes this issue for both unwinding methods, i.e. > both dwfl and libunwind. The former case is straight-forward thanks > to dwfl_frame_pc. For libunwind, we replace the functionality via > unw_is_signal_frame for any but the ver

Re: [PATCH] perf report: fix off-by-one for non-activation frames

2017-05-15 Thread Namhyung Kim
On Mon, May 15, 2017 at 05:13:06PM +0200, Milian Wolff wrote: > On Monday, May 15, 2017 5:04:44 PM CEST Milian Wolff wrote: > > As the documentation for dwfl_frame_pc says, frames that > > are no activation frames need to have their program counter > > decremented by one to properly find the functi

Re: [PATCH v2] perf report: distinguish between inliners in the same function

2017-05-15 Thread Namhyung Kim
On Mon, May 15, 2017 at 12:01:54PM +0200, Milian Wolff wrote: > On Monday, May 15, 2017 3:21:58 AM CEST Namhyung Kim wrote: > > Hi Milian, > > > > On Sun, May 14, 2017 at 08:10:50PM +0200, Milian Wolff wrote: > > > On Freitag, 12. Mai 2017 15:01:29 CEST Namhyung Kim

Re: [PATCH v2] perf report: distinguish between inliners in the same function

2017-05-14 Thread Namhyung Kim
Hi Milian, On Sun, May 14, 2017 at 08:10:50PM +0200, Milian Wolff wrote: > On Freitag, 12. Mai 2017 15:01:29 CEST Namhyung Kim wrote: > > On Fri, May 12, 2017 at 12:37:01PM +0200, Milian Wolff wrote: > > > On Mittwoch, 10. Mai 2017 07:53:52 CEST Namhyung Kim wrote: > > &

Re: [PATCH v2] perf report: distinguish between inliners in the same function

2017-05-14 Thread Namhyung Kim
Hi Andi, On Fri, May 12, 2017 at 07:55:13AM -0700, Andi Kleen wrote: > Milian Wolff writes: > > > > I think I'm missing something, but isn't this what this function provides? > > The > > function above is now being used by the match_chain_inliner function below. > > > > Ah, or do you mean for

Re: [PATCH v2] perf report: distinguish between inliners in the same function

2017-05-12 Thread Namhyung Kim
On Fri, May 12, 2017 at 12:37:01PM +0200, Milian Wolff wrote: > On Mittwoch, 10. Mai 2017 07:53:52 CEST Namhyung Kim wrote: > > Hi, > > > > On Wed, May 03, 2017 at 11:35:36PM +0200, Milian Wolff wrote: > > > > > > +static enum match_result match_cha

Re: [PATCH] perf report: don't crash on invalid maps in `-g srcline` mode

2017-05-12 Thread Namhyung Kim
On Fri, May 12, 2017 at 12:23:06PM +0200, Milian Wolff wrote: > On Mittwoch, 10. Mai 2017 08:04:23 CEST Namhyung Kim wrote: > > On Tue, May 09, 2017 at 10:50:46PM +0200, Milian Wolff wrote: > > > > > > diff --git a/tools/perf/util/callchain.c b/tools/perf/u

[PATCH] perf script: Add --inline option

2017-05-10 Thread Namhyung Kim
f Signed-off-by: Namhyung Kim --- tools/perf/Documentation/perf-script.txt | 4 tools/perf/builtin-script.c | 2 ++ tools/perf/util/evsel_fprintf.c | 33 3 files changed, 39 insertions(+) diff --git a/tools/perf/Documentation/perf-s

Re: [PATCH] perf report: don't crash on invalid maps in `-g srcline` mode

2017-05-09 Thread Namhyung Kim
d > > This patch fixes the issue. > > Cc: Arnaldo Carvalho de Melo > Cc: David Ahern > Cc: Namhyung Kim > Cc: Peter Zijlstra > Cc: Yao Jin > Signed-off-by: Milian Wolff > --- > tools/perf/util/callchain.c | 23 --- > 1 file changed,

Re: [PATCH v2] perf report: distinguish between inliners in the same function

2017-05-09 Thread Namhyung Kim
(inline) >| > --3.35%--main > main (inline) > > std::uniform_real_distribution::operator() long, 16807ul, 0ul, 2147483647ul> > (inline) > ~ > > Note

Re: [PATCH] pstore: Solve lockdep warning by moving inode locks

2017-04-27 Thread Namhyung Kim
->s_type->i_mutex_key#14); > lock(&psinfo->read_mutex); > lock(&sb->s_type->i_mutex_key#14); >lock(&psinfo->read_mutex); > > Reported-by: Marta Lofstedt > Reported-by: Chris Wilson > Si

Re: perf report warnings on tracepoint events hidden by ui

2017-04-27 Thread Namhyung Kim
Hi, On Fri, Apr 28, 2017 at 9:31 AM, David Carrillo-Cisneros wrote: > When processing tracepoint events, perf report outputs warnings about > field not founds. The warnings are usually hidden by perf report UI > and appear when using the --stdio option. e.g. Yep, currently perf report TUI hides

Re: [for-next][PATCH 0/5] selftests: ftrace: Tracing updates to allow instance testing

2017-04-25 Thread Namhyung Kim
tests run in a tracing instance too > selftests: ftrace: Allow some event trigger tests to run in an instance Acked-by: Namhyung Kim But I saw a warning during the below test. I used the for-next branch but the commit id was different: c486bbae781cce337a31cbbbc609f2313ab54542 ("Merge branc

Re: [PATCH 0/4] ftrace: Add 'function-fork' trace option (v2)

2017-04-18 Thread Namhyung Kim
Hi Steve, Sorry for little late, On Tue, Apr 18, 2017 at 4:18 AM, Steven Rostedt wrote: > On Mon, 17 Apr 2017 11:44:26 +0900 > Namhyung Kim wrote: > >> Hello, >> >> This patchset add 'function-fork' option to function tracer which >> makes pid fi

Re: [PATCH 1/4] ftrace: Fix function pid filter on instances

2017-04-17 Thread Namhyung Kim
Hi Masami, On Mon, Apr 17, 2017 at 8:52 PM, Masami Hiramatsu wrote: > On Mon, 17 Apr 2017 11:44:27 +0900 > Namhyung Kim wrote: > >> When function tracer has a pid filter, it adds a probe to sched_switch >> to track if current task can be ignored. The probe checks the >

[PATCH 2/4] ftrace: Add 'function-fork' trace option

2017-04-16 Thread Namhyung Kim
The function-fork option is same as event-fork that it tracks task fork/exit and set the pid filter properly. This can be useful if user wants to trace selected tasks including their children only. Signed-off-by: Namhyung Kim --- kernel/trace/ftrace.c | 37

[PATCH 0/4] ftrace: Add 'function-fork' trace option (v2)

2017-04-16 Thread Namhyung Kim
tion-fork-v2' branch on git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git Thanks, Namhyung Namhyung Kim (4): ftrace: Fix function pid filter on instances ftrace: Add 'function-fork' trace option selftests: ftrace: Add -l/--logdir option selftests: f

[PATCH 4/4] selftests: ftrace: Add a testcase for function PID filter

2017-04-16 Thread Namhyung Kim
Like event pid filtering test, add function pid filtering test with the new "function-fork" option. It also tests it on an instance directory so that it can verify the bug related pid filtering on instances. Cc: Masami Hiramatsu Cc: Steven Rostedt Cc: Shuah Khan Signed-off-by: Na

[PATCH 1/4] ftrace: Fix function pid filter on instances

2017-04-16 Thread Namhyung Kim
ted ftrace codes, it can just free the filter safely. Fixes: 0c8916c34203 ("tracing: Add rmdir to remove multibuffer instances") Signed-off-by: Namhyung Kim --- kernel/trace/ftrace.c | 9 + kernel/trace/trace.c | 1 + kernel/trace/trace.h | 2 ++ 3 files changed, 12 insertions(+)

[PATCH 3/4] selftests: ftrace: Add -l/--logdir option

2017-04-16 Thread Namhyung Kim
In my virtual machine setup, running ftracetest failed on creating LOG_DIR on a read-only filesystem. It'd be convenient to provide an option to specify a different directory as log directory. Acked-by: Masami Hiramatsu Cc: Steven Rostedt Cc: Shuah Khan Signed-off-by: Namhyung Kim ---

Re: [PATCH v2] perf: fix double free at function perf_hpp__reset_output_field

2017-04-04 Thread Namhyung Kim
Hi Arnaldo, On Wed, Apr 5, 2017 at 12:19 AM, Arnaldo Carvalho de Melo wrote: > Em Mon, Mar 27, 2017 at 02:22:55PM +0800, changbin...@intel.com escreveu: >> From: Changbin Du >> >> Some perf_hpp_fmt both registered at field and sort list. For such >> instance, we only can free it when removed fro

Re: [PATCH 0/4] ftrace: Add 'function-fork' trace option (v1)

2017-03-29 Thread Namhyung Kim
Hi Masami, On Thu, Mar 30, 2017 at 9:54 AM, Masami Hiramatsu wrote: > On Wed, 29 Mar 2017 10:46:21 +0900 > Namhyung Kim wrote: > >> Hello, >> >> This patchset add 'function-fork' option to function tracer which >> makes pid filter to be inherited lik

Re: [PATCH 1/4] ftrace: Fix function pid filter on instances

2017-03-28 Thread Namhyung Kim
On Tue, Mar 28, 2017 at 10:58:43PM -0400, Steven Rostedt wrote: > On Wed, 29 Mar 2017 11:42:27 +0900 > Namhyung Kim wrote: > > > On Tue, Mar 28, 2017 at 10:28:55PM -0400, Steven Rostedt wrote: > > > On Wed, 29 Mar 2017 11:20:37 +0900 > > > Namhyung Kim wrote: &

Re: [PATCH 1/4] ftrace: Fix function pid filter on instances

2017-03-28 Thread Namhyung Kim
On Tue, Mar 28, 2017 at 10:28:55PM -0400, Steven Rostedt wrote: > On Wed, 29 Mar 2017 11:20:37 +0900 > Namhyung Kim wrote: > > > > > Actually, if this is called after event_trace_del_tracer(), the tr is > > > already invisible and nothing new should change. &

Re: [PATCH 1/4] ftrace: Fix function pid filter on instances

2017-03-28 Thread Namhyung Kim
On Tue, Mar 28, 2017 at 10:08:41PM -0400, Steven Rostedt wrote: > On Wed, 29 Mar 2017 10:46:22 +0900 > Namhyung Kim wrote: > > > When function tracer has a pid filter, it adds a probe to sched_switch > > to track if current task can be ignored. The probe checks the >

Re: [PATCH 1/4] ftrace: Fix function pid filter on instances

2017-03-28 Thread Namhyung Kim
Hi Steve, On Tue, Mar 28, 2017 at 10:08:41PM -0400, Steven Rostedt wrote: > On Wed, 29 Mar 2017 10:46:22 +0900 > Namhyung Kim wrote: > > > When function tracer has a pid filter, it adds a probe to sched_switch > > to track if current task can be ignored.

[PATCH 4/4] selftests: ftrace: Add a testcase for function PID filter

2017-03-28 Thread Namhyung Kim
Like event pid filtering test, add function pid filtering test with the new "function-fork" option. It also tests it on an instance directory so that it can verify the bug related pid filtering on instances. Cc: Masami Hiramatsu Cc: Steven Rostedt Cc: Shuah Khan Signed-off-by: Na

[PATCH 0/4] ftrace: Add 'function-fork' trace option (v1)

2017-03-28 Thread Namhyung Kim
git/namhyung/linux-perf.git Thanks, Namhyung Namhyung Kim (4): ftrace: Fix function pid filter on instances ftrace: Add 'function-fork' trace option selftests: ftrace: Add -l/--logdir option selftests: ftrace: Add a testcase for function PID filter kernel/trace/ftrace.c

[PATCH 2/4] ftrace: Add 'function-fork' trace option

2017-03-28 Thread Namhyung Kim
The function-fork option is same as event-fork that it tracks task fork/exit and set the pid filter properly. This can be useful if user wants to trace selected tasks including their children only. Signed-off-by: Namhyung Kim --- kernel/trace/ftrace.c | 37

[PATCH 1/4] ftrace: Fix function pid filter on instances

2017-03-28 Thread Namhyung Kim
ted ftrace codes, it can just free the filter safely. Fixes: 0c8916c34203 ("tracing: Add rmdir to remove multibuffer instances") Signed-off-by: Namhyung Kim --- kernel/trace/ftrace.c | 10 ++ kernel/trace/trace.c | 1 + kernel/trace/trace.h | 2 ++ 3 files changed, 9 ins

[PATCH 3/4] selftests: ftrace: Add -l/--logdir option

2017-03-28 Thread Namhyung Kim
In my virtual machine setup, running ftracetest failed on creating LOG_DIR on a read-only filesystem. It'd be convenient to provide an option to specify a different directory as log directory. Cc: Masami Hiramatsu Cc: Steven Rostedt Cc: Shuah Khan Signed-off-by: Namhyung Kim ---

Re: [PATCH 2/6] ftrace/x86_32: Move the ftrace specific code out of entry_32.S

2017-03-22 Thread Namhyung Kim
Hi Steve, On Wed, Mar 22, 2017 at 10:35 AM, Steven Rostedt wrote: > From: "Steven Rostedt (VMware)" > > The function tracing hook code for ftrace is not an entry point from > userspace and does not belong in the entry_*.S files. It has already been > moved out of entry_64.S. This moves it out of

Re: [PATCH] fs/pstore: Perform erase from a worker

2017-03-20 Thread Namhyung Kim
Hello, On Mon, Mar 20, 2017 at 10:49:16AM -0700, Kees Cook wrote: > On Fri, Mar 17, 2017 at 2:52 AM, Chris Wilson > wrote: > > In order to prevent a cyclic recursion between psi->read_mutex and the > > inode_lock, we need to move the pse->erase to a worker. > > > > [ 605.374955] ===

Re: change uprobe_events default ? Was: [PATCH] perf: Rename CONFIG_[UK]PROBE_EVENT to CONFIG_[UK]PROBE_EVENTS

2017-03-15 Thread Namhyung Kim
On Wed, Mar 15, 2017 at 07:10:56PM -0600, David Ahern wrote: > On 3/15/17 7:06 PM, Arnaldo Carvalho de Melo wrote: > > Added more people to the CC list. > > > > Em Wed, Mar 15, 2017 at 05:58:19PM -0700, Alexei Starovoitov escreveu: > >> On Thu, Feb 16, 2017 at 05:00:50PM +1100, Anton Blanchard wro

[tip:perf/core] perf c2c: Fix display bug when using pipe

2017-03-15 Thread tip-bot for Namhyung Kim
Commit-ID: 1936feae54a6724a27a6ca1b948fd0e80371f7b0 Gitweb: http://git.kernel.org/tip/1936feae54a6724a27a6ca1b948fd0e80371f7b0 Author: Namhyung Kim AuthorDate: Wed, 8 Mar 2017 00:08:33 +0900 Committer: Arnaldo Carvalho de Melo CommitDate: Tue, 7 Mar 2017 12:48:46 -0300 perf c2c: Fix

[tip:perf/core] perf c2c: Clarify help message of --stats option

2017-03-15 Thread tip-bot for Namhyung Kim
Commit-ID: f75d2895e053efb2a69194d98754e4d5f4fa3a28 Gitweb: http://git.kernel.org/tip/f75d2895e053efb2a69194d98754e4d5f4fa3a28 Author: Namhyung Kim AuthorDate: Wed, 8 Mar 2017 00:08:32 +0900 Committer: Arnaldo Carvalho de Melo CommitDate: Tue, 7 Mar 2017 12:48:41 -0300 perf c2c

[tip:perf/core] perf report: Hide tip message when -q option is given

2017-03-15 Thread tip-bot for Namhyung Kim
Commit-ID: 8b53dbef2aeaad6bf532bd4db2f4b2beefd42e49 Gitweb: http://git.kernel.org/tip/8b53dbef2aeaad6bf532bd4db2f4b2beefd42e49 Author: Namhyung Kim AuthorDate: Wed, 8 Mar 2017 00:08:29 +0900 Committer: Arnaldo Carvalho de Melo CommitDate: Tue, 7 Mar 2017 12:25:27 -0300 perf report

[PATCH 09/23] perf ftrace: Add -q/--quiet option

2017-03-07 Thread Namhyung Kim
The -q/--quiet option is to suppress any message. Sometimes users just want to run the command and it can be used for that case. Suggested-by: Arnaldo Carvalho de Melo Signed-off-by: Namhyung Kim --- tools/perf/Documentation/perf-ftrace.txt | 4 tools/perf/builtin-ftrace.c

[PATCH 23/23] perf trace: Add -q/--quiet option

2017-03-07 Thread Namhyung Kim
The -q/--quiet option is to suppress any message. Sometimes users just want to run the command and it can be used for that case. Also check the quiet variable when printing error messages. Suggested-by: Arnaldo Carvalho de Melo Signed-off-by: Namhyung Kim --- tools/perf/Documentation/perf

Re: [PATCH 02/23] perf buildid-cache: Add -q/--quiet option

2017-03-07 Thread Namhyung Kim
Hi Arnaldo, On Wed, Mar 8, 2017 at 12:28 AM, Arnaldo Carvalho de Melo wrote: > Em Wed, Mar 08, 2017 at 12:08:30AM +0900, Namhyung Kim escreveu: >> The -q/--quiet option is to suppress any message. Sometimes users just >> want to run the command and it can be used for that case.

[PATCH 01/23] perf report: Hide tip message when -q option is given

2017-03-07 Thread Namhyung Kim
plified to honor the -q option. Signed-off-by: Namhyung Kim --- tools/perf/builtin-report.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c index 0a88670e56f3..f03a5eac2a62 100644 --- a/tools/perf/builtin-report.c +

[PATCHSET 00/23] perf tools: Add -q/--quiet option

2017-03-07 Thread Namhyung Kim
, please let me know. The patch 1, 4 and 5 are fixes and can be applied separately. The code is available on the 'perf/quiet-v2' branche on my tree git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git Thanks, Namhyung Namhyung Kim (23): perf report: Hide tip message when

Re: [PATCH 03/18] pstore: Avoid race in module unloading

2017-03-07 Thread Namhyung Kim
Hi Kees, On Tue, Mar 7, 2017 at 6:55 AM, Kees Cook wrote: > Technically, it might be possible for struct pstore_info to go out of > scope after the module_put(), so report the backend name first. But in that case, using pstore will crash the kernel anyway, right? If so, why pstore doesn't keep a

Re: [PATCH 06/18] pstore: Extract common arguments into structure

2017-03-07 Thread Namhyung Kim
On Tue, Mar 7, 2017 at 6:55 AM, Kees Cook wrote: > The read/mkfile pair pass the same arguments and should be cleared > between calls. Move to a structure and wipe it after every loop. > > Signed-off-by: Kees Cook > --- > fs/pstore/platform.c | 55 > +++

[PATCH 06/23] perf c2c: Add -q/--quiet option

2017-03-07 Thread Namhyung Kim
: Arnaldo Carvalho de Melo Signed-off-by: Namhyung Kim --- tools/perf/Documentation/perf-c2c.txt | 8 tools/perf/builtin-c2c.c | 12 ++-- 2 files changed, 18 insertions(+), 2 deletions(-) diff --git a/tools/perf/Documentation/perf-c2c.txt b/tools/perf/Documentation

[PATCH 02/23] perf buildid-cache: Add -q/--quiet option

2017-03-07 Thread Namhyung Kim
The -q/--quiet option is to suppress any message. Sometimes users just want to run the command and it can be used for that case. Suggested-by: Arnaldo Carvalho de Melo Signed-off-by: Namhyung Kim --- tools/perf/Documentation/perf-buildid-cache.txt | 4 tools/perf/builtin-buildid-cache.c

[PATCH 18/23] perf script: Use pr_err() for error messages

2017-03-07 Thread Namhyung Kim
There are many open calls to fprintf() for error logging. use pr_err() instead so that they can be treated at once (e.g. with -q option). Also convert perror() to pr_err() + str_error_r(). Signed-off-by: Namhyung Kim --- tools/perf/builtin-script.c | 41

[PATCH 13/23] perf kvm: Add -q/--quiet option

2017-03-07 Thread Namhyung Kim
The -q/--quiet option is to suppress any message. Sometimes users just want to run the command and it can be used for that case. Suggested-by: Arnaldo Carvalho de Melo Signed-off-by: Namhyung Kim --- tools/perf/Documentation/perf-kvm.txt | 3 +++ tools/perf/builtin-kvm.c | 10

[PATCH 19/23] perf script: Add -q/--quiet option

2017-03-07 Thread Namhyung Kim
The -q/--quiet option is to suppress any message. Sometimes users just want to run the command and it can be used for that case. Suggested-by: Arnaldo Carvalho de Melo Signed-off-by: Namhyung Kim --- tools/perf/Documentation/perf-script.txt | 8 tools/perf/builtin-script.c

[PATCH 20/23] perf stat: Use pr_err() for error messages

2017-03-07 Thread Namhyung Kim
There are many open calls to fprintf() for error logging. use pr_err() instead so that they can be treated at once (e.g. with -q option). Also convert perror() to pr_err() + str_error_r(). Signed-off-by: Namhyung Kim --- tools/perf/builtin-stat.c | 52

[PATCH 14/23] perf list: Add -q/--quiet option

2017-03-07 Thread Namhyung Kim
The -q/--quiet option is to suppress any message. Sometimes users just want to run the command and it can be used for that case. Suggested-by: Arnaldo Carvalho de Melo Signed-off-by: Namhyung Kim --- tools/perf/Documentation/perf-list.txt | 9 - tools/perf/builtin-list.c

[PATCH 22/23] perf top: Add -q/--quiet option

2017-03-07 Thread Namhyung Kim
The -q/--quiet option is to suppress any message. Sometimes users just want to run the command and it can be used for that case. Suggested-by: Arnaldo Carvalho de Melo Signed-off-by: Namhyung Kim --- tools/perf/Documentation/perf-top.txt | 4 tools/perf/builtin-top.c | 6

[PATCH 04/23] perf c2c: Fix help message of --stats option

2017-03-07 Thread Namhyung Kim
Signed-off-by: Namhyung Kim --- tools/perf/builtin-c2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/builtin-c2c.c b/tools/perf/builtin-c2c.c index e2b21723bbf8..3fac30ed92f1 100644 --- a/tools/perf/builtin-c2c.c +++ b/tools/perf/builtin-c2c.c @@ -2536,7

[PATCH 21/23] perf stat: Add -q/--quiet option

2017-03-07 Thread Namhyung Kim
The -q/--quiet option is to suppress any message. Sometimes users just want to run the command and it can be used for that case. Suggested-by: Arnaldo Carvalho de Melo Signed-off-by: Namhyung Kim --- tools/perf/Documentation/perf-stat.txt | 4 tools/perf/builtin-stat.c | 7

<    5   6   7   8   9   10   11   12   13   14   >