Re: [PATCH] regmap: Fix leftover from struct reg_default to struct reg_sequence change

2015-12-15 Thread Nariman Poushin
missed > > one place to fix up. > > > > Signed-off-by: Daniel Wagner > > Cc: Nariman Poushin > > Cc: Mark Brown > > Forgot to add: > > Reported-by: kbuild test robot > > Sorry about that. Acked-By: Nariman Poushin -- To unsubscribe from this li

Re: [PATCH] regmap: Fix leftover from struct reg_default to struct reg_sequence change

2015-12-15 Thread Nariman Poushin
missed > > one place to fix up. > > > > Signed-off-by: Daniel Wagner <daniel.wag...@bmw-carit.de> > > Cc: Nariman Poushin <nari...@opensource.wolfsonmicro.com> > > Cc: Mark Brown <broo...@kernel.org> > > Forgot to add: > > Reported-by: kbuild

Re: linux-next: build warnings after merge of the regmap tree

2015-07-17 Thread Nariman Poushin
On Fri, Jul 17, 2015 at 11:34:50AM +0100, Mark Brown wrote: > On Fri, Jul 17, 2015 at 10:44:36AM +0100, Nariman Poushin wrote: > > > What is the best course of action here? I am more than happy to help with > > whatever is needed but unsure of the etiquette here and also not s

[PATCH 2/2] ASoC: wm5110: Use reg_sequence for multi_reg_write/register_patch

2015-07-17 Thread Nariman Poushin
Introduced by: commit 8019ff6cfc04 ("regmap: Use reg_sequence for multi_reg_write / register_patch") Interacting with: commit d1acd31883d7 ("ASoC: wm5110: Add special DRE on/off handling for the headphone path") Signed-off-by: Nariman Poushin --- sound/soc/codecs/wm5110.c

[PATCH 1/2] mfd: Fixup clients of multi_reg_write/register_patch

2015-07-17 Thread Nariman Poushin
Introduced by: commit 8019ff6cfc04 ("regmap: Use reg_sequence for multi_reg_write / register_patch") Interacting with: commit 561629755a21 ("mfd: arizona: Add support for WM8998 and WM1814") commit 81207880cef2 ("mfd: wm5110: Add register patch for rev E and above&

Re: linux-next: build warnings after merge of the regmap tree

2015-07-17 Thread Nariman Poushin
On Fri, Jul 17, 2015 at 02:39:34PM +1000, Stephen Rothwell wrote: > Hi Mark, > > After merging the regmap tree, today's linux-next build (powerpc > allyesconfig) produced these warnings: > > sound/soc/codecs/wm5110.c: In function 'wm5110_hp_pre_enable': > sound/soc/codecs/wm5110.c:294:9:

[PATCH 1/2] mfd: Fixup clients of multi_reg_write/register_patch

2015-07-17 Thread Nariman Poushin
Introduced by: commit 8019ff6cfc04 (regmap: Use reg_sequence for multi_reg_write / register_patch) Interacting with: commit 561629755a21 (mfd: arizona: Add support for WM8998 and WM1814) commit 81207880cef2 (mfd: wm5110: Add register patch for rev E and above) Signed-off-by: Nariman Poushin nari

[PATCH 2/2] ASoC: wm5110: Use reg_sequence for multi_reg_write/register_patch

2015-07-17 Thread Nariman Poushin
Introduced by: commit 8019ff6cfc04 (regmap: Use reg_sequence for multi_reg_write / register_patch) Interacting with: commit d1acd31883d7 (ASoC: wm5110: Add special DRE on/off handling for the headphone path) Signed-off-by: Nariman Poushin nari...@opensource.wolfsonmicro.com --- sound/soc/codecs

Re: linux-next: build warnings after merge of the regmap tree

2015-07-17 Thread Nariman Poushin
On Fri, Jul 17, 2015 at 11:34:50AM +0100, Mark Brown wrote: On Fri, Jul 17, 2015 at 10:44:36AM +0100, Nariman Poushin wrote: What is the best course of action here? I am more than happy to help with whatever is needed but unsure of the etiquette here and also not sure what I can do

Re: linux-next: build warnings after merge of the regmap tree

2015-07-17 Thread Nariman Poushin
On Fri, Jul 17, 2015 at 02:39:34PM +1000, Stephen Rothwell wrote: Hi Mark, After merging the regmap tree, today's linux-next build (powerpc allyesconfig) produced these warnings: sound/soc/codecs/wm5110.c: In function 'wm5110_hp_pre_enable': sound/soc/codecs/wm5110.c:294:9: warning:

Re: [alsa-devel] [PATCH 1/2] V4 regmap: Use reg_sequence for multi_reg_write / register_patch

2015-07-16 Thread Nariman Poushin
On Thu, Jul 16, 2015 at 01:52:54PM +0100, Mark Brown wrote: > On Tue, Jul 14, 2015 at 03:45:51PM +0100, Nariman Poushin wrote: > > Please submit patches in the format covered in SubmittingPatches, > version information goes inside the []. > > > Add support for writing s

[PATCH 2/2 V5] regmap: Apply optional delay in multi_reg_write/register_patch

2015-07-16 Thread Nariman Poushin
before a delay (in the same way you can coalesce all writes before a page change is needed) Signed-off-by: Nariman Poushin --- drivers/base/regmap/regmap.c | 54 +++- include/linux/regmap.h | 5 +++- 2 files changed, 52 insertions(+), 7 deletions

[PATCH 1/2 V5] regmap: Use reg_sequence for multi_reg_write / register_patch

2015-07-16 Thread Nariman Poushin
adding an int to all register defaults, which could substantially increase memory usage for regmaps with large default tables. This also updates all the clients of multi_reg_write/register_patch. Signed-off-by: Nariman Poushin --- drivers/base/regmap/internal.h | 2 +- drivers/base/regmap

[PATCH 1/2 V5] regmap: Use reg_sequence for multi_reg_write / register_patch

2015-07-16 Thread Nariman Poushin
adding an int to all register defaults, which could substantially increase memory usage for regmaps with large default tables. This also updates all the clients of multi_reg_write/register_patch. Signed-off-by: Nariman Poushin nari...@opensource.wolfsonmicro.com --- drivers/base/regmap/internal.h

[PATCH 2/2 V5] regmap: Apply optional delay in multi_reg_write/register_patch

2015-07-16 Thread Nariman Poushin
before a delay (in the same way you can coalesce all writes before a page change is needed) Signed-off-by: Nariman Poushin nari...@opensource.wolfsonmicro.com --- drivers/base/regmap/regmap.c | 54 +++- include/linux/regmap.h | 5 +++- 2 files changed

Re: [alsa-devel] [PATCH 1/2] V4 regmap: Use reg_sequence for multi_reg_write / register_patch

2015-07-16 Thread Nariman Poushin
On Thu, Jul 16, 2015 at 01:52:54PM +0100, Mark Brown wrote: On Tue, Jul 14, 2015 at 03:45:51PM +0100, Nariman Poushin wrote: Please submit patches in the format covered in SubmittingPatches, version information goes inside the []. Add support for writing sequences of registers / patches

[PATCH 1/2] V4 regmap: Use reg_sequence for multi_reg_write / register_patch

2015-07-14 Thread Nariman Poushin
substantially. This also updates all the clients of multi_reg_write/register_patch. Signed-off-by: Nariman Poushin --- drivers/base/regmap/internal.h | 2 +- drivers/base/regmap/regmap.c | 22 +++--- drivers/gpu/drm/i2c/adv7511.c | 2 +- drivers/input/misc/drv260x.c | 6

[PATCH 2/2] V4 regmap: Apply optional delay in multi_reg_write/register_patch

2015-07-14 Thread Nariman Poushin
We treat a delay in a sequence the same way we treat a page change as they are logically similar in that you can coalesce all write before a delay (in the same way you can coalesce all writes before a page change is needed) Signed-off-by: Nariman Poushin --- drivers/base/regmap/regmap.c | 65

[PATCH 1/2] V4 regmap: Use reg_sequence for multi_reg_write / register_patch

2015-07-14 Thread Nariman Poushin
substantially. This also updates all the clients of multi_reg_write/register_patch. Signed-off-by: Nariman Poushin nari...@opensource.wolfsonmicro.com --- drivers/base/regmap/internal.h | 2 +- drivers/base/regmap/regmap.c | 22 +++--- drivers/gpu/drm/i2c/adv7511.c | 2 +- drivers

[PATCH 2/2] V4 regmap: Apply optional delay in multi_reg_write/register_patch

2015-07-14 Thread Nariman Poushin
We treat a delay in a sequence the same way we treat a page change as they are logically similar in that you can coalesce all write before a delay (in the same way you can coalesce all writes before a page change is needed) Signed-off-by: Nariman Poushin nari...@opensource.wolfsonmicro.com

Re: [RFC][PATCH] regmap: make REGCACHE_NONE maps return error on regcache_sync

2015-06-08 Thread Nariman Poushin
On Fri, May 08, 2015 at 11:34:54AM +0100, Nariman Poushin wrote: > On Fri, May 08, 2015 at 11:20:19AM +0100, Mark Brown wrote: > > On Fri, May 08, 2015 at 10:55:37AM +0100, Nariman Poushin wrote: > > > Signed-off-by: Nariman Poushin > > > --- > > >

Re: [RFC][PATCH] regmap: make REGCACHE_NONE maps return error on regcache_sync

2015-06-08 Thread Nariman Poushin
On Fri, May 08, 2015 at 11:34:54AM +0100, Nariman Poushin wrote: On Fri, May 08, 2015 at 11:20:19AM +0100, Mark Brown wrote: On Fri, May 08, 2015 at 10:55:37AM +0100, Nariman Poushin wrote: Signed-off-by: Nariman Poushin nari...@opensource.wolfsonmicro.com --- regcache currently

Re: [RFC][PATCH] regmap: Add reg_sequence for use with multi_reg_write / register_patch

2015-06-04 Thread Nariman Poushin
On Tue, Jun 02, 2015 at 07:15:13PM +0100, Mark Brown wrote: > On Mon, Jun 01, 2015 at 10:20:12AM +0100, Nariman Poushin wrote: > > > it be accepted), should I: > > - Squash all the updates in to this patch (I suppose the benefit > > there is that we don't bre

Re: [RFC][PATCH] regmap: Add reg_sequence for use with multi_reg_write / register_patch

2015-06-04 Thread Nariman Poushin
On Tue, Jun 02, 2015 at 07:15:13PM +0100, Mark Brown wrote: On Mon, Jun 01, 2015 at 10:20:12AM +0100, Nariman Poushin wrote: it be accepted), should I: - Squash all the updates in to this patch (I suppose the benefit there is that we don't break the kernel build from one patch

[RFC][PATCH] regmap: Add reg_sequence for use with multi_reg_write / register_patch

2015-06-01 Thread Nariman Poushin
). Signed-off-by: Nariman Poushin --- I am not sure how best to update all the users of this patch (should it be accepted), should I: - Squash all the updates in to this patch (I suppose the benefit there is that we don't break the kernel build from one patch

[RFC][PATCH] regmap: Add reg_sequence for use with multi_reg_write / register_patch

2015-06-01 Thread Nariman Poushin
). Signed-off-by: Nariman Poushin nari...@opensource.wolfsonmicro.com --- I am not sure how best to update all the users of this patch (should it be accepted), should I: - Squash all the updates in to this patch (I suppose the benefit there is that we don't break the kernel build

Re: [RFC][PATCH] regmap: Add support for sequences of writes with specified delays

2015-05-27 Thread Nariman Poushin
On Tue, May 26, 2015 at 04:36:54PM +0100, Richard Fitzgerald wrote: > On Tue, May 26, 2015 at 04:21:00PM +0100, Mark Brown wrote: > > On Tue, May 26, 2015 at 01:39:21PM +0100, Nariman Poushin wrote: > > > > > Change-Id:Ie9e77aa48f258b353ffa7406d02e19c28d5f2a44 My

Re: [RFC][PATCH] regmap: Add support for sequences of writes with specified delays

2015-05-27 Thread Nariman Poushin
On Tue, May 26, 2015 at 04:36:54PM +0100, Richard Fitzgerald wrote: On Tue, May 26, 2015 at 04:21:00PM +0100, Mark Brown wrote: On Tue, May 26, 2015 at 01:39:21PM +0100, Nariman Poushin wrote: Change-Id:Ie9e77aa48f258b353ffa7406d02e19c28d5f2a44 My bad, should have removed

[RFC][PATCH] regmap: Add support for sequences of writes with specified delays

2015-05-26 Thread Nariman Poushin
. This also maintains atomicity for the sequence, which avoids callers needing this type of behaviour from having to implement their own locking schemes to achieve this when also requiring delays within a write sequence Change-Id:Ie9e77aa48f258b353ffa7406d02e19c28d5f2a44 Signed-off-by: Nariman Poushin

[RFC][PATCH] regmap: Add support for sequences of writes with specified delays

2015-05-26 Thread Nariman Poushin
. This also maintains atomicity for the sequence, which avoids callers needing this type of behaviour from having to implement their own locking schemes to achieve this when also requiring delays within a write sequence Change-Id:Ie9e77aa48f258b353ffa7406d02e19c28d5f2a44 Signed-off-by: Nariman Poushin nari

Re: [RFC][PATCH] regmap: make REGCACHE_NONE maps return error on regcache_sync

2015-05-08 Thread Nariman Poushin
On Fri, May 08, 2015 at 11:20:19AM +0100, Mark Brown wrote: > On Fri, May 08, 2015 at 10:55:37AM +0100, Nariman Poushin wrote: > > Signed-off-by: Nariman Poushin > > --- > > regcache currently causes a BUG_ON if cache_sync/sync_region is > > called on a map wi

[RFC][PATCH] regmap: make REGCACHE_NONE maps return error on regcache_sync

2015-05-08 Thread Nariman Poushin
Signed-off-by: Nariman Poushin --- regcache currently causes a BUG_ON if cache_sync/sync_region is called on a map with cache_type REGCACHE_NONE. This is not consistent with the behaviour of regcache_read/write which currently just return -ENOSYS and only throws a BUG_ON if the cache_type

[RFC][PATCH] regmap: make REGCACHE_NONE maps return error on regcache_sync

2015-05-08 Thread Nariman Poushin
Signed-off-by: Nariman Poushin nari...@opensource.wolfsonmicro.com --- regcache currently causes a BUG_ON if cache_sync/sync_region is called on a map with cache_type REGCACHE_NONE. This is not consistent with the behaviour of regcache_read/write which currently just return -ENOSYS and only

Re: [RFC][PATCH] regmap: make REGCACHE_NONE maps return error on regcache_sync

2015-05-08 Thread Nariman Poushin
On Fri, May 08, 2015 at 11:20:19AM +0100, Mark Brown wrote: On Fri, May 08, 2015 at 10:55:37AM +0100, Nariman Poushin wrote: Signed-off-by: Nariman Poushin nari...@opensource.wolfsonmicro.com --- regcache currently causes a BUG_ON if cache_sync/sync_region is called on a map