Re: [PATCH 0/3] Add support for perf user stack dump in powerpc

2016-04-28 Thread Naveen N. Rao
On 2016/04/28 12:29PM, Arnaldo Carvalho de Melo wrote: > Em Thu, Apr 28, 2016 at 07:53:41PM +0530, Naveen N. Rao escreveu: > > On 2016/04/28 03:01PM, Chandan Kumar wrote: > > > This patch set enables perf user stack dump on powerpc > > > > For this patch-set:

Re: [PATCH 0/3] Add support for perf user stack dump in powerpc

2016-04-28 Thread Naveen N. Rao
On 2016/04/28 12:29PM, Arnaldo Carvalho de Melo wrote: > Em Thu, Apr 28, 2016 at 07:53:41PM +0530, Naveen N. Rao escreveu: > > On 2016/04/28 03:01PM, Chandan Kumar wrote: > > > This patch set enables perf user stack dump on powerpc > > > > For this patch-set:

Re: [PATCH 0/3] Add support for perf user stack dump in powerpc

2016-04-28 Thread Naveen N. Rao
On 2016/04/28 03:01PM, Chandan Kumar wrote: > This patch set enables perf user stack dump on powerpc For this patch-set: Reviewed-by: Naveen N. Rao <naveen.n@linux.vnet.ibm.com> I suppose that implies my testing, but nonetheless: Tested-by: Naveen N. Rao <naveen.n@linux.

Re: [PATCH 0/3] Add support for perf user stack dump in powerpc

2016-04-28 Thread Naveen N. Rao
On 2016/04/28 03:01PM, Chandan Kumar wrote: > This patch set enables perf user stack dump on powerpc For this patch-set: Reviewed-by: Naveen N. Rao I suppose that implies my testing, but nonetheless: Tested-by: Naveen N. Rao > > Example with "ls" command as user prog

Re: [PATCH v2 0/2] perf probe fixes for ppc64le

2016-04-27 Thread Naveen N. Rao
On 2016/04/12 02:40PM, Naveen N Rao wrote: > This patchset fixes three issues found with perf probe on ppc64le: > 1. 'perf test kallsyms' failure on ppc64le (reported by Michael > Ellerman). This was due to the symbols being fixed up during symbol > table load. This is fixed in patch 2

Re: [PATCH v2 0/2] perf probe fixes for ppc64le

2016-04-27 Thread Naveen N. Rao
On 2016/04/12 02:40PM, Naveen N Rao wrote: > This patchset fixes three issues found with perf probe on ppc64le: > 1. 'perf test kallsyms' failure on ppc64le (reported by Michael > Ellerman). This was due to the symbols being fixed up during symbol > table load. This is fixed in patch 2

Re: [PATCH V11 2/4] perf/powerpc: add support for sampling intr machine state

2016-04-21 Thread Naveen N. Rao
On 2016/02/20 10:32AM, Anju T wrote: > The perf infrastructure uses a bit mask to find out valid > registers to display. Define a register mask for supported > registers defined in asm/perf_regs.h. The bit positions also > correspond to register IDs which is used by perf infrastructure > to fetch

Re: [PATCH V11 2/4] perf/powerpc: add support for sampling intr machine state

2016-04-21 Thread Naveen N. Rao
On 2016/02/20 10:32AM, Anju T wrote: > The perf infrastructure uses a bit mask to find out valid > registers to display. Define a register mask for supported > registers defined in asm/perf_regs.h. The bit positions also > correspond to register IDs which is used by perf infrastructure > to fetch

Re: [PATCH V11 1/4] perf/powerpc: assign an id to each powerpc register

2016-04-21 Thread Naveen N. Rao
On 2016/02/20 10:32AM, Anju T wrote: > The enum definition assigns an 'id' to each register in "struct pt_regs" > of arch/powerpc. The order of these values in the enum definition are > based on the corresponding macros in arch/powerpc/include/uapi/asm/ptrace.h. > > Signed-off-by: Anju T

Re: [PATCH V11 1/4] perf/powerpc: assign an id to each powerpc register

2016-04-21 Thread Naveen N. Rao
On 2016/02/20 10:32AM, Anju T wrote: > The enum definition assigns an 'id' to each register in "struct pt_regs" > of arch/powerpc. The order of these values in the enum definition are > based on the corresponding macros in arch/powerpc/include/uapi/asm/ptrace.h. > > Signed-off-by: Anju T > --- >

[PATCH v2 0/2] perf probe fixes for ppc64le

2016-04-12 Thread Naveen N. Rao
...@redhat.com> Cc: Thiago Jung Bauermann <bauer...@linux.vnet.ibm.com> Cc: Arnaldo Carvalho de Melo <a...@redhat.com> Cc: Masami Hiramatsu <mhira...@kernel.org> Cc: Michael Ellerman <m...@ellerman.id.au> Cc: Balbir Singh <bsinghar...@gmail.com> Cc: Ananth N Mavina

[PATCH v2 1/2] perf tools: Fix kprobe and kretprobe handling with kallsyms on ppc64le

2016-04-12 Thread Naveen N. Rao
Cc: Arnaldo Carvalho de Melo <a...@redhat.com> Cc: Masami Hiramatsu <mhira...@kernel.org> Cc: Michael Ellerman <m...@ellerman.id.au> Cc: Balbir Singh <bsinghar...@gmail.com> Reported-by: Ananth N Mavinakayanahalli <ana...@in.ibm.com> Signed-off-by: Naveen N. Rao <naveen

[PATCH v2 0/2] perf probe fixes for ppc64le

2016-04-12 Thread Naveen N. Rao
naldo Carvalho de Melo Cc: Masami Hiramatsu Cc: Michael Ellerman Cc: Balbir Singh Cc: Ananth N Mavinakayanahalli Naveen N. Rao (2): perf tools: Fix kprobe and kretprobe handling with kallsyms on ppc64le perf tools: Fix kallsyms perf test on ppc64le tools/perf/arch/powerpc/ut

[PATCH v2 1/2] perf tools: Fix kprobe and kretprobe handling with kallsyms on ppc64le

2016-04-12 Thread Naveen N. Rao
: Michael Ellerman Cc: Balbir Singh Reported-by: Ananth N Mavinakayanahalli Signed-off-by: Naveen N. Rao --- v2: Removed un-necessary check for uprobes tools/perf/arch/powerpc/util/sym-handling.c | 19 ++- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/tools/perf/arch

[PATCH v2 2/2] perf tools: Fix kallsyms perf test on ppc64le

2016-04-12 Thread Naveen N. Rao
: Balbir Singh <bsinghar...@gmail.com> Acked-by: Ananth N Mavinakayanahalli <ana...@in.ibm.com> Reported-by: Michael Ellerman <m...@ellerman.id.au> Signed-off-by: Naveen N. Rao <naveen.n@linux.vnet.ibm.com> --- v2: Added uprobes handling -- we modify the probe address, rather tha

[PATCH v2 2/2] perf tools: Fix kallsyms perf test on ppc64le

2016-04-12 Thread Naveen N. Rao
member of perf symbol structure, and later use this to adjust the probe trace point. Cc: Mark Wielaard Cc: Thiago Jung Bauermann Cc: Arnaldo Carvalho de Melo Cc: Masami Hiramatsu Cc: Balbir Singh Acked-by: Ananth N Mavinakayanahalli Reported-by: Michael Ellerman Signed-off-by: Naveen N. Rao

Re: [PATCH 0/2] perf probe fixes for ppc64le

2016-04-11 Thread Naveen N. Rao
On 2016/04/11 02:41PM, Michael Ellerman wrote: > On Sat, 2016-04-09 at 19:12 +0530, Naveen N. Rao wrote: > > > > I suppose this boils down to the quirkiness of ABIv2. Though, in > > reality, I don't think most users will notice. As I stated above, users >

Re: [PATCH 0/2] perf probe fixes for ppc64le

2016-04-11 Thread Naveen N. Rao
On 2016/04/11 02:41PM, Michael Ellerman wrote: > On Sat, 2016-04-09 at 19:12 +0530, Naveen N. Rao wrote: > > > > I suppose this boils down to the quirkiness of ABIv2. Though, in > > reality, I don't think most users will notice. As I stated above, users >

Re: [PATCH 0/2] perf probe fixes for ppc64le

2016-04-09 Thread Naveen N. Rao
On 2016/04/08 04:57PM, Balbir Singh wrote: > On Thu, 2016-04-07 at 14:56 +0530, Naveen N. Rao wrote: > > On 2016/04/07 06:19PM, Balbir Singh wrote: > > >  > > >  > > > On 06/04/16 22:32, Naveen N. Rao wrote: > > > >  > > > > This

Re: [PATCH 0/2] perf probe fixes for ppc64le

2016-04-09 Thread Naveen N. Rao
On 2016/04/08 04:57PM, Balbir Singh wrote: > On Thu, 2016-04-07 at 14:56 +0530, Naveen N. Rao wrote: > > On 2016/04/07 06:19PM, Balbir Singh wrote: > > >  > > >  > > > On 06/04/16 22:32, Naveen N. Rao wrote: > > > >  > > > > This

Re: [PATCH 0/2] perf probe fixes for ppc64le

2016-04-07 Thread Naveen N. Rao
On 2016/04/07 06:19PM, Balbir Singh wrote: > > On 06/04/16 22:32, Naveen N. Rao wrote: > > This patchset fixes three issues found with perf probe on ppc64le: > > 1. 'perf test kallsyms' failure on ppc64le (reported by Michael > > Ellerman). This was due to the symbols bein

Re: [PATCH 0/2] perf probe fixes for ppc64le

2016-04-07 Thread Naveen N. Rao
On 2016/04/07 06:19PM, Balbir Singh wrote: > > On 06/04/16 22:32, Naveen N. Rao wrote: > > This patchset fixes three issues found with perf probe on ppc64le: > > 1. 'perf test kallsyms' failure on ppc64le (reported by Michael > > Ellerman). This was due to the symbols bein

Re: [PATCH 1/2] perf/powerpc: Fix kprobe and kretprobe handling with kallsyms

2016-04-07 Thread Naveen N. Rao
On 2016/04/07 10:00AM, Ananth N wrote: > On Wed, Apr 06, 2016 at 06:02:57PM +0530, Naveen N. Rao wrote: > > > + if (!pev->uprobes && map->dso->symtab_type == DSO_BINARY_TYPE__KALLSYMS) > > tev->point.offset += PPC64LE_LEP_OFFSET; > > u

Re: [PATCH 1/2] perf/powerpc: Fix kprobe and kretprobe handling with kallsyms

2016-04-07 Thread Naveen N. Rao
On 2016/04/07 10:00AM, Ananth N wrote: > On Wed, Apr 06, 2016 at 06:02:57PM +0530, Naveen N. Rao wrote: > > > + if (!pev->uprobes && map->dso->symtab_type == DSO_BINARY_TYPE__KALLSYMS) > > tev->point.offset += PPC64LE_LEP_OFFSET; > > u

[PATCH 0/2] perf probe fixes for ppc64le

2016-04-06 Thread Naveen N. Rao
t.ibm.com> Cc: Arnaldo Carvalho de Melo <a...@redhat.com> Cc: Masami Hiramatsu <masami.hiramatsu...@hitachi.com> Cc: Michael Ellerman <m...@ellerman.id.au> Cc: Ananth N Mavinakayanahalli <ana...@in.ibm.com> Naveen N. Rao (2): perf/powerpc: Fix kprobe and kretprobe h

[PATCH 0/2] perf probe fixes for ppc64le

2016-04-06 Thread Naveen N. Rao
Hiramatsu Cc: Michael Ellerman Cc: Ananth N Mavinakayanahalli Naveen N. Rao (2): perf/powerpc: Fix kprobe and kretprobe handling with kallsyms tools/perf: Fix kallsyms perf test on ppc64le tools/perf/arch/powerpc/util/sym-handling.c | 41 - tools/p

[PATCH 1/2] perf/powerpc: Fix kprobe and kretprobe handling with kallsyms

2016-04-06 Thread Naveen N. Rao
Cc: Arnaldo Carvalho de Melo <a...@redhat.com> Cc: Masami Hiramatsu <masami.hiramatsu...@hitachi.com> Cc: Michael Ellerman <m...@ellerman.id.au> Reported-by: Ananth N Mavinakayanahalli <ana...@in.ibm.com> Signed-off-by: Naveen N. Rao <naveen.n@linux.vnet.ibm.com

[PATCH 1/2] perf/powerpc: Fix kprobe and kretprobe handling with kallsyms

2016-04-06 Thread Naveen N. Rao
: Michael Ellerman Reported-by: Ananth N Mavinakayanahalli Signed-off-by: Naveen N. Rao --- tools/perf/arch/powerpc/util/sym-handling.c | 19 ++- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/tools/perf/arch/powerpc/util/sym-handling.c b/tools/perf/arch/powerpc/util

[PATCH 2/2] tools/perf: Fix kallsyms perf test on ppc64le

2016-04-06 Thread Naveen N. Rao
t;m...@redhat.com> Cc: Thiago Jung Bauermann <bauer...@linux.vnet.ibm.com> Cc: Ananth N Mavinakayanahalli <ana...@in.ibm.com> Cc: Arnaldo Carvalho de Melo <a...@redhat.com> Cc: Masami Hiramatsu <masami.hiramatsu...@hitachi.com> Reported-by: Michael Ellerman <m...@ellerman.id

[PATCH 2/2] tools/perf: Fix kallsyms perf test on ppc64le

2016-04-06 Thread Naveen N. Rao
Jung Bauermann Cc: Ananth N Mavinakayanahalli Cc: Arnaldo Carvalho de Melo Cc: Masami Hiramatsu Reported-by: Michael Ellerman Signed-off-by: Naveen N. Rao --- tools/perf/arch/powerpc/util/sym-handling.c | 24 tools/perf/util/probe-event.c | 5

Re: [PATCH net 4/4] lib/test_bpf: Add additional BPF_ADD tests

2016-04-05 Thread Naveen N. Rao
On 2016/04/05 09:28AM, Alexei Starovoitov wrote: > On 4/5/16 3:02 AM, Naveen N. Rao wrote: > >Some of these tests proved useful with the powerpc eBPF JIT port due to > >sign-extended 16-bit immediate loads. Though some of these aspects get > >covered in other tests, it is be

Re: [PATCH net 4/4] lib/test_bpf: Add additional BPF_ADD tests

2016-04-05 Thread Naveen N. Rao
On 2016/04/05 09:28AM, Alexei Starovoitov wrote: > On 4/5/16 3:02 AM, Naveen N. Rao wrote: > >Some of these tests proved useful with the powerpc eBPF JIT port due to > >sign-extended 16-bit immediate loads. Though some of these aspects get > >covered in other tests, it is be

Re: [PATCH net 2/4] lib/test_bpf: Add tests for unsigned BPF_JGT

2016-04-05 Thread Naveen N. Rao
On 2016/04/05 09:20AM, Alexei Starovoitov wrote: > On 4/5/16 3:02 AM, Naveen N. Rao wrote: > >Unsigned Jump-if-Greater-Than. > > > >Cc: Alexei Starovoitov <a...@fb.com> > >Cc: Daniel Borkmann <dan...@iogearbox.net> > >Cc: "David S. Miller"

Re: [PATCH net 2/4] lib/test_bpf: Add tests for unsigned BPF_JGT

2016-04-05 Thread Naveen N. Rao
On 2016/04/05 09:20AM, Alexei Starovoitov wrote: > On 4/5/16 3:02 AM, Naveen N. Rao wrote: > >Unsigned Jump-if-Greater-Than. > > > >Cc: Alexei Starovoitov > >Cc: Daniel Borkmann > >Cc: "David S. Miller" > >Cc: Ananth N Mavinakayanahalli > >

[PATCH net 2/4] lib/test_bpf: Add tests for unsigned BPF_JGT

2016-04-05 Thread Naveen N. Rao
Mackerras <pau...@samba.org> Signed-off-by: Naveen N. Rao <naveen.n@linux.vnet.ibm.com> --- lib/test_bpf.c | 29 + 1 file changed, 29 insertions(+) diff --git a/lib/test_bpf.c b/lib/test_bpf.c index e76fa4d..7e6fb49 100644 --- a/lib/test_bpf.c +++ b

[PATCH net 2/4] lib/test_bpf: Add tests for unsigned BPF_JGT

2016-04-05 Thread Naveen N. Rao
Unsigned Jump-if-Greater-Than. Cc: Alexei Starovoitov Cc: Daniel Borkmann Cc: "David S. Miller" Cc: Ananth N Mavinakayanahalli Cc: Michael Ellerman Cc: Paul Mackerras Signed-off-by: Naveen N. Rao --- lib/test_bpf.c | 29 + 1 file changed, 29 insertion

[PATCH net 1/4] lib/test_bpf: Fix JMP_JSET tests

2016-04-05 Thread Naveen N. Rao
lerman.id.au> Cc: Paul Mackerras <pau...@samba.org> Signed-off-by: Naveen N. Rao <naveen.n@linux.vnet.ibm.com> --- lib/test_bpf.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/test_bpf.c b/lib/test_bpf.c index 27a7a26..e76fa4d 100644 --- a/li

[PATCH net 1/4] lib/test_bpf: Fix JMP_JSET tests

2016-04-05 Thread Naveen N. Rao
JMP_JSET tests incorrectly used BPF_JNE. Fix the same. Cc: Alexei Starovoitov Cc: Daniel Borkmann Cc: "David S. Miller" Cc: Ananth N Mavinakayanahalli Cc: Michael Ellerman Cc: Paul Mackerras Signed-off-by: Naveen N. Rao --- lib/test_bpf.c | 8 1 file changed, 4 insert

[PATCH net 3/4] lib/test_bpf: Add test to check for result of 32-bit add that overflows

2016-04-05 Thread Naveen N. Rao
bm.com> Cc: Michael Ellerman <m...@ellerman.id.au> Cc: Paul Mackerras <pau...@samba.org> Signed-off-by: Naveen N. Rao <naveen.n@linux.vnet.ibm.com> --- lib/test_bpf.c | 64 ++ 1 file changed, 64 insertions(+) diff --git a/li

[PATCH net 3/4] lib/test_bpf: Add test to check for result of 32-bit add that overflows

2016-04-05 Thread Naveen N. Rao
BPF_ALU32 and BPF_ALU64 tests for adding two 32-bit values that results in 32-bit overflow. Cc: Alexei Starovoitov Cc: Daniel Borkmann Cc: "David S. Miller" Cc: Ananth N Mavinakayanahalli Cc: Michael Ellerman Cc: Paul Mackerras Signed-off-by: Naveen N. Rao --- lib/test_

[PATCH net 4/4] lib/test_bpf: Add additional BPF_ADD tests

2016-04-05 Thread Naveen N. Rao
Daniel Borkmann <dan...@iogearbox.net> Cc: "David S. Miller" <da...@davemloft.net> Cc: Ananth N Mavinakayanahalli <ana...@in.ibm.com> Cc: Michael Ellerman <m...@ellerman.id.au> Cc: Paul Mackerras <pau...@samba.org> Signed-off-by: Naveen N. Rao <naveen.n.

[PATCH net 4/4] lib/test_bpf: Add additional BPF_ADD tests

2016-04-05 Thread Naveen N. Rao
: "David S. Miller" Cc: Ananth N Mavinakayanahalli Cc: Michael Ellerman Cc: Paul Mackerras Signed-off-by: Naveen N. Rao --- lib/test_bpf.c | 128 + 1 file changed, 128 insertions(+) diff --git a/lib/test_bpf.c b/lib/test_bpf.c ind

Re: [RFC PATCH 6/6] ppc: ebpf/jit: Implement JIT compiler for extended BPF

2016-04-04 Thread Naveen N. Rao
On 2016/04/01 08:34PM, Daniel Borkmann wrote: > On 04/01/2016 08:10 PM, Alexei Starovoitov wrote: > >On 4/1/16 2:58 AM, Naveen N. Rao wrote: > >>PPC64 eBPF JIT compiler. Works for both ABIv1 and ABIv2. > >> > >>Enable with: > >>echo 1 > /proc/sys/n

Re: [RFC PATCH 6/6] ppc: ebpf/jit: Implement JIT compiler for extended BPF

2016-04-04 Thread Naveen N. Rao
On 2016/04/01 08:34PM, Daniel Borkmann wrote: > On 04/01/2016 08:10 PM, Alexei Starovoitov wrote: > >On 4/1/16 2:58 AM, Naveen N. Rao wrote: > >>PPC64 eBPF JIT compiler. Works for both ABIv1 and ABIv2. > >> > >>Enable with: > >>echo 1 > /proc/sys/n

[PATCHv2 net 3/3] samples/bpf: Enable powerpc support

2016-04-04 Thread Naveen N. Rao
rkmann <dan...@iogearbox.net> Cc: David S. Miller <da...@davemloft.net> Cc: Ananth N Mavinakayanahalli <ana...@in.ibm.com> Cc: Michael Ellerman <m...@ellerman.id.au> Signed-off-by: Naveen N. Rao <naveen.n@linux.vnet.ibm.com> --- v2: updated macros using ({ }) gcc e

[PATCHv2 net 3/3] samples/bpf: Enable powerpc support

2016-04-04 Thread Naveen N. Rao
. Miller Cc: Ananth N Mavinakayanahalli Cc: Michael Ellerman Signed-off-by: Naveen N. Rao --- v2: updated macros using ({ }) gcc extension as per Alexei samples/bpf/bpf_helpers.h | 26 ++ samples/bpf/spintest_kern.c | 2 +- samples/bpf/tracex2_kern.c | 4

[PATCHv2 net 1/3] samples/bpf: Fix build breakage with map_perf_test_user.c

2016-04-04 Thread Naveen N. Rao
Starovoitov <a...@fb.com> Cc: Daniel Borkmann <dan...@iogearbox.net> Cc: David S. Miller <da...@davemloft.net> Cc: Ananth N Mavinakayanahalli <ana...@in.ibm.com> Cc: Michael Ellerman <m...@ellerman.id.au> Acked-by: Alexei Starovoitov <a...@kernel.org> Si

[PATCHv2 net 2/3] samples/bpf: Use llc in PATH, rather than a hardcoded value

2016-04-04 Thread Naveen N. Rao
Cc: Michael Ellerman <m...@ellerman.id.au> Signed-off-by: Naveen N. Rao <naveen.n@linux.vnet.ibm.com> --- v2: removed generation of .s files samples/bpf/Makefile | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/samples/bpf/Makefile b/samples/bpf/Ma

[PATCHv2 net 1/3] samples/bpf: Fix build breakage with map_perf_test_user.c

2016-04-04 Thread Naveen N. Rao
Starovoitov Cc: Daniel Borkmann Cc: David S. Miller Cc: Ananth N Mavinakayanahalli Cc: Michael Ellerman Acked-by: Alexei Starovoitov Signed-off-by: Naveen N. Rao --- v2: no changes samples/bpf/map_perf_test_user.c | 1 + 1 file changed, 1 insertion(+) diff --git a/samples/bpf

[PATCHv2 net 2/3] samples/bpf: Use llc in PATH, rather than a hardcoded value

2016-04-04 Thread Naveen N. Rao
While at it, remove the generation of .s files and fix some typos in the related comment. Cc: Alexei Starovoitov Cc: David S. Miller Cc: Daniel Borkmann Cc: Ananth N Mavinakayanahalli Cc: Michael Ellerman Signed-off-by: Naveen N. Rao --- v2: removed generation of .s files samples/bpf

Re: [PATCH 4/4] samples/bpf: Enable powerpc support

2016-04-01 Thread Naveen N. Rao
On 2016/03/31 10:52AM, Alexei Starovoitov wrote: > On 3/31/16 4:25 AM, Naveen N. Rao wrote: > ... > >+ > >+#ifdef __powerpc__ > >+#define BPF_KPROBE_READ_RET_IP(ip, ctx) { (ip) = (ctx)->link; } > >+#define BPF_KRETPROBE_READ_RET_IP(ip, ctx) BPF_KPRO

Re: [PATCH 4/4] samples/bpf: Enable powerpc support

2016-04-01 Thread Naveen N. Rao
On 2016/03/31 10:52AM, Alexei Starovoitov wrote: > On 3/31/16 4:25 AM, Naveen N. Rao wrote: > ... > >+ > >+#ifdef __powerpc__ > >+#define BPF_KPROBE_READ_RET_IP(ip, ctx) { (ip) = (ctx)->link; } > >+#define BPF_KRETPROBE_READ_RET_IP(ip, ctx) BPF_KPRO

Re: [PATCH 2/4] samples/bpf: Use llc in PATH, rather than a hardcoded value

2016-04-01 Thread Naveen N. Rao
On 2016/03/31 08:19PM, Daniel Borkmann wrote: > On 03/31/2016 07:46 PM, Alexei Starovoitov wrote: > >On 3/31/16 4:25 AM, Naveen N. Rao wrote: > >> clang $(NOSTDINC_FLAGS) $(LINUXINCLUDE) $(EXTRA_CFLAGS) \ > >> -D__KERNEL__ -D__ASM_SYSREG_H -Wno-unu

Re: [PATCH 2/4] samples/bpf: Use llc in PATH, rather than a hardcoded value

2016-04-01 Thread Naveen N. Rao
On 2016/03/31 08:19PM, Daniel Borkmann wrote: > On 03/31/2016 07:46 PM, Alexei Starovoitov wrote: > >On 3/31/16 4:25 AM, Naveen N. Rao wrote: > >> clang $(NOSTDINC_FLAGS) $(LINUXINCLUDE) $(EXTRA_CFLAGS) \ > >> -D__KERNEL__ -D__ASM_SYSREG_H -Wno-unu

Re: [RFC PATCH 0/6] eBPF JIT for PPC64

2016-04-01 Thread Naveen N. Rao
On 2016/04/01 03:28PM, Naveen N Rao wrote: > Implement extended BPF JIT for ppc64. We retain the classic BPF JIT for > ppc32 and move ppc64 BE/LE to use the new JIT. Classic BPF filters will > be converted to extended BPF (see convert_filter()) and JIT'ed with the > new compile

Re: [RFC PATCH 0/6] eBPF JIT for PPC64

2016-04-01 Thread Naveen N. Rao
On 2016/04/01 03:28PM, Naveen N Rao wrote: > Implement extended BPF JIT for ppc64. We retain the classic BPF JIT for > ppc32 and move ppc64 BE/LE to use the new JIT. Classic BPF filters will > be converted to extended BPF (see convert_filter()) and JIT'ed with the > new compile

[RFC PATCH 3/6] ppc: bpf/jit: Introduce rotate immediate instructions

2016-04-01 Thread Naveen N. Rao
gt; Cc: Michael Ellerman <m...@ellerman.id.au> Cc: Paul Mackerras <pau...@samba.org> Cc: Alexei Starovoitov <a...@fb.com> Cc: "David S. Miller" <da...@davemloft.net> Cc: Ananth N Mavinakayanahalli <ana...@in.ibm.com> Signed-off-by: Naveen N. Rao <naveen.n.

[RFC PATCH 3/6] ppc: bpf/jit: Introduce rotate immediate instructions

2016-04-01 Thread Naveen N. Rao
Ellerman Cc: Paul Mackerras Cc: Alexei Starovoitov Cc: "David S. Miller" Cc: Ananth N Mavinakayanahalli Signed-off-by: Naveen N. Rao --- arch/powerpc/include/asm/ppc-opcode.h | 2 ++ arch/powerpc/net/bpf_jit.h| 20 +++- 2 files changed, 13 insertions(+), 9

[RFC PATCH 2/6] ppc: bpf/jit: Optimize 64-bit Immediate loads

2016-04-01 Thread Naveen N. Rao
man <m...@ellerman.id.au> Cc: Paul Mackerras <pau...@samba.org> Cc: Alexei Starovoitov <a...@fb.com> Cc: "David S. Miller" <da...@davemloft.net> Cc: Ananth N Mavinakayanahalli <ana...@in.ibm.com> Signed-off-by: Naveen N. Rao <naveen.n@linux.v

[RFC PATCH 4/6] ppc: bpf/jit: A few cleanups

2016-04-01 Thread Naveen N. Rao
c: "David S. Miller" <da...@davemloft.net> Cc: Ananth N Mavinakayanahalli <ana...@in.ibm.com> Signed-off-by: Naveen N. Rao <naveen.n@linux.vnet.ibm.com> --- arch/powerpc/net/bpf_jit.h | 13 +++-- arch/powerpc/net/bpf_jit_comp.c | 8 2 files changed,

[RFC PATCH 4/6] ppc: bpf/jit: A few cleanups

2016-04-01 Thread Naveen N. Rao
-alignment, per the ISA. Change the macros to use IMM_L(). 4. A few white-space cleanups to satisfy checkpatch.pl. Cc: Matt Evans Cc: Michael Ellerman Cc: Paul Mackerras Cc: Alexei Starovoitov Cc: "David S. Miller" Cc: Ananth N Mavinakayanahalli Signed-off-by: Naveen N. Rao --- ar

[RFC PATCH 2/6] ppc: bpf/jit: Optimize 64-bit Immediate loads

2016-04-01 Thread Naveen N. Rao
: Alexei Starovoitov Cc: "David S. Miller" Cc: Ananth N Mavinakayanahalli Signed-off-by: Naveen N. Rao --- arch/powerpc/net/bpf_jit.h | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/arch/powerpc/net/bpf_jit.h b/arch/powerpc/net/bpf_jit.h ind

[RFC PATCH 5/6] ppc: bpf/jit: Isolate classic BPF JIT specifics into a separate header

2016-04-01 Thread Naveen N. Rao
Alexei Starovoitov <a...@fb.com> Cc: "David S. Miller" <da...@davemloft.net> Cc: Ananth N Mavinakayanahalli <ana...@in.ibm.com> Signed-off-by: Naveen N. Rao <naveen.n@linux.vnet.ibm.com> --- arch/powerpc/net/bpf_jit.h | 122 +

[RFC PATCH 6/6] ppc: ebpf/jit: Implement JIT compiler for extended BPF

2016-04-01 Thread Naveen N. Rao
ans <m...@ozlabs.org> Cc: Michael Ellerman <m...@ellerman.id.au> Cc: Paul Mackerras <pau...@samba.org> Cc: Alexei Starovoitov <a...@fb.com> Cc: "David S. Miller" <da...@davemloft.net> Cc: Ananth N Mavinakayanahalli <ana...@in.ibm.com> Signed-off-by: Navee

[RFC PATCH 5/6] ppc: bpf/jit: Isolate classic BPF JIT specifics into a separate header

2016-04-01 Thread Naveen N. Rao
ayanahalli Signed-off-by: Naveen N. Rao --- arch/powerpc/net/bpf_jit.h | 122 +- arch/powerpc/net/bpf_jit32.h| 140 arch/powerpc/net/bpf_jit_asm.S | 2 +- arch/powerpc/net/bpf_jit_comp.c | 2 +- 4 files changed, 145

[RFC PATCH 6/6] ppc: ebpf/jit: Implement JIT compiler for extended BPF

2016-04-01 Thread Naveen N. Rao
ns Cc: Michael Ellerman Cc: Paul Mackerras Cc: Alexei Starovoitov Cc: "David S. Miller" Cc: Ananth N Mavinakayanahalli Signed-off-by: Naveen N. Rao --- arch/powerpc/include/asm/ppc-opcode.h | 19 +- arch/powerpc/net/Makefile | 4 + arch/powerpc/net/bpf_jit.h

[RFC PATCH 1/6] ppc: bpf/jit: Fix/enhance 32-bit Load Immediate implementation

2016-04-01 Thread Naveen N. Rao
c: "David S. Miller" <da...@davemloft.net> Cc: Ananth N Mavinakayanahalli <ana...@in.ibm.com> Signed-off-by: Naveen N. Rao <naveen.n@linux.vnet.ibm.com> --- arch/powerpc/net/bpf_jit.h | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/arch/powe

[RFC PATCH 1/6] ppc: bpf/jit: Fix/enhance 32-bit Load Immediate implementation

2016-04-01 Thread Naveen N. Rao
we now only need a single LI. The new implementation now generates the same or less number of instructions. Cc: Matt Evans Cc: Michael Ellerman Cc: Paul Mackerras Cc: Alexei Starovoitov Cc: "David S. Miller" Cc: Ananth N Mavinakayanahalli Signed-off-by: Naveen N. Rao --- arch/p

[RFC PATCH 0/6] eBPF JIT for PPC64

2016-04-01 Thread Naveen N. Rao
Naveen N. Rao (6): ppc: bpf/jit: Fix/enhance 32-bit Load Immediate implementation ppc: bpf/jit: Optimize 64-bit Immediate loads ppc: bpf/jit: Introduce rotate immediate instructions ppc: bpf/jit: A few cleanups ppc: bpf/jit: Isolate classic BPF JIT specifics into a separate header ppc

[RFC PATCH 0/6] eBPF JIT for PPC64

2016-04-01 Thread Naveen N. Rao
Naveen N. Rao (6): ppc: bpf/jit: Fix/enhance 32-bit Load Immediate implementation ppc: bpf/jit: Optimize 64-bit Immediate loads ppc: bpf/jit: Introduce rotate immediate instructions ppc: bpf/jit: A few cleanups ppc: bpf/jit: Isolate classic BPF JIT specifics into a separate header ppc

Re: [PATCH 3/4] samples/bpf: Simplify building BPF samples

2016-03-31 Thread Naveen N. Rao
On 2016/03/31 10:49AM, Alexei Starovoitov wrote: > On 3/31/16 4:25 AM, Naveen N. Rao wrote: > >Make BPF samples build depend on CONFIG_SAMPLE_BPF. We still don't add a > >Kconfig option since that will add a dependency on llvm for allyesconfig > >builds which may not be desira

Re: [PATCH 3/4] samples/bpf: Simplify building BPF samples

2016-03-31 Thread Naveen N. Rao
On 2016/03/31 10:49AM, Alexei Starovoitov wrote: > On 3/31/16 4:25 AM, Naveen N. Rao wrote: > >Make BPF samples build depend on CONFIG_SAMPLE_BPF. We still don't add a > >Kconfig option since that will add a dependency on llvm for allyesconfig > >builds which may not be desira

Re: [PATCH 1/4] samples/bpf: Fix build breakage with map_perf_test_user.c

2016-03-31 Thread Naveen N. Rao
On 2016/03/31 10:43AM, Alexei Starovoitov wrote: > On 3/31/16 4:25 AM, Naveen N. Rao wrote: > >Building BPF samples is failing with the below error: > > > >samples/bpf/map_perf_test_user.c: In function ‘main’: > >samples/bpf/map_perf_test_user.c:134:9: error: vari

Re: [PATCH 1/4] samples/bpf: Fix build breakage with map_perf_test_user.c

2016-03-31 Thread Naveen N. Rao
On 2016/03/31 10:43AM, Alexei Starovoitov wrote: > On 3/31/16 4:25 AM, Naveen N. Rao wrote: > >Building BPF samples is failing with the below error: > > > >samples/bpf/map_perf_test_user.c: In function ‘main’: > >samples/bpf/map_perf_test_user.c:134:9: error: vari

[PATCH 1/4] samples/bpf: Fix build breakage with map_perf_test_user.c

2016-03-31 Thread Naveen N. Rao
Starovoitov <a...@fb.com> Cc: David S. Miller <da...@davemloft.net> Cc: Ananth N Mavinakayanahalli <ana...@in.ibm.com> Cc: Michael Ellerman <m...@ellerman.id.au> Signed-off-by: Naveen N. Rao <naveen.n@linux.vnet.ibm.com> --- samples/bpf/map_perf_test_user.c | 1

[PATCH 2/4] samples/bpf: Use llc in PATH, rather than a hardcoded value

2016-03-31 Thread Naveen N. Rao
While at it, fix some typos in the comment. Cc: Alexei Starovoitov <a...@fb.com> Cc: David S. Miller <da...@davemloft.net> Cc: Ananth N Mavinakayanahalli <ana...@in.ibm.com> Cc: Michael Ellerman <m...@ellerman.id.au> Signed-off-by: Naveen N. Rao <naveen.n@linux.vne

[PATCH 1/4] samples/bpf: Fix build breakage with map_perf_test_user.c

2016-03-31 Thread Naveen N. Rao
Starovoitov Cc: David S. Miller Cc: Ananth N Mavinakayanahalli Cc: Michael Ellerman Signed-off-by: Naveen N. Rao --- samples/bpf/map_perf_test_user.c | 1 + 1 file changed, 1 insertion(+) diff --git a/samples/bpf/map_perf_test_user.c b/samples/bpf/map_perf_test_user.c index 95af56e..3147377

[PATCH 2/4] samples/bpf: Use llc in PATH, rather than a hardcoded value

2016-03-31 Thread Naveen N. Rao
While at it, fix some typos in the comment. Cc: Alexei Starovoitov Cc: David S. Miller Cc: Ananth N Mavinakayanahalli Cc: Michael Ellerman Signed-off-by: Naveen N. Rao --- samples/bpf/Makefile | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/samples/bpf

[PATCH 3/4] samples/bpf: Simplify building BPF samples

2016-03-31 Thread Naveen N. Rao
make Cc: Alexei Starovoitov <a...@fb.com> Cc: David S. Miller <da...@davemloft.net> Cc: Ananth N Mavinakayanahalli <ana...@in.ibm.com> Cc: Michael Ellerman <m...@ellerman.id.au> Signed-off-by: Naveen N. Rao <naveen.n@linux.vnet.ibm.com> --- samples/Makefile

[PATCH 3/4] samples/bpf: Simplify building BPF samples

2016-03-31 Thread Naveen N. Rao
make Cc: Alexei Starovoitov Cc: David S. Miller Cc: Ananth N Mavinakayanahalli Cc: Michael Ellerman Signed-off-by: Naveen N. Rao --- samples/Makefile | 2 +- samples/bpf/Makefile | 39 --- 2 files changed, 21 insertions(+), 20 deletions(-) diff --git

[PATCH 4/4] samples/bpf: Enable powerpc support

2016-03-31 Thread Naveen N. Rao
, but not s390. Cc: Alexei Starovoitov <a...@fb.com> Cc: David S. Miller <da...@davemloft.net> Cc: Ananth N Mavinakayanahalli <ana...@in.ibm.com> Cc: Michael Ellerman <m...@ellerman.id.au> Signed-off-by: Naveen N. Rao <naveen.n@linux.vnet.ibm.com> --- sa

[PATCH 4/4] samples/bpf: Enable powerpc support

2016-03-31 Thread Naveen N. Rao
, but not s390. Cc: Alexei Starovoitov Cc: David S. Miller Cc: Ananth N Mavinakayanahalli Cc: Michael Ellerman Signed-off-by: Naveen N. Rao --- samples/bpf/bpf_helpers.h | 26 ++ samples/bpf/spintest_kern.c | 2 +- samples/bpf/tracex2_kern.c | 4 ++-- samples/bpf

Re: [RFC PATCH 2/2] tools/perf: Change how probe offsets are handled

2016-03-31 Thread Naveen N. Rao
On 2016/03/30 10:13PM, Naveen N Rao wrote: > While trying to address the kallsyms perf test failure on ppc64le, > Ananth noticed that we were not necessarily probing at the expected > address when an offset to the function was specified. > > So far, we used to treat probe point o

Re: [RFC PATCH 2/2] tools/perf: Change how probe offsets are handled

2016-03-31 Thread Naveen N. Rao
On 2016/03/30 10:13PM, Naveen N Rao wrote: > While trying to address the kallsyms perf test failure on ppc64le, > Ananth noticed that we were not necessarily probing at the expected > address when an offset to the function was specified. > > So far, we used to treat probe point o

[RFC PATCH 2/2] tools/perf: Change how probe offsets are handled

2016-03-30 Thread Naveen N. Rao
asami.hiramatsu...@hitachi.com> Cc: Michael Ellerman <m...@ellerman.id.au> Reported-by: Ananth N Mavinakayanahalli <ana...@in.ibm.com> Signed-off-by: Naveen N. Rao <naveen.n@linux.vnet.ibm.com> --- tools/perf/arch/powerpc/util/sym-handling.c | 21 ++---

[RFC PATCH 2/2] tools/perf: Change how probe offsets are handled

2016-03-30 Thread Naveen N. Rao
Signed-off-by: Naveen N. Rao --- tools/perf/arch/powerpc/util/sym-handling.c | 21 ++--- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/tools/perf/arch/powerpc/util/sym-handling.c b/tools/perf/arch/powerpc/util/sym-handling.c index 3e98a61..36f6eb0 100644

[RFC PATCH 1/2] tools/perf: Change how ppc64le symbols are fixed up

2016-03-30 Thread Naveen N. Rao
in a different manner. Cc: Thiago Jung Bauermann <bauer...@linux.vnet.ibm.com> Cc: Ananth N Mavinakayanahalli <ana...@in.ibm.com> Cc: Arnaldo Carvalho de Melo <a...@redhat.com> Cc: Masami Hiramatsu <masami.hiramatsu...@hitachi.com> Reported-by: Michael Ellerman <m...@ellerman.id.

[RFC PATCH 1/2] tools/perf: Change how ppc64le symbols are fixed up

2016-03-30 Thread Naveen N. Rao
in a different manner. Cc: Thiago Jung Bauermann Cc: Ananth N Mavinakayanahalli Cc: Arnaldo Carvalho de Melo Cc: Masami Hiramatsu Reported-by: Michael Ellerman Signed-off-by: Naveen N. Rao --- tools/perf/arch/powerpc/util/sym-handling.c | 12 +--- tools/perf/util/probe-event.c

[PATCH] scripts/tags.sh: add regex to map kprobe helpers

2016-02-18 Thread Naveen N. Rao
Add regex for [get|free]_[insn|optinsn|dmainsn]_slot() functions. Signed-off-by: Naveen N. Rao <naveen.n@linux.vnet.ibm.com> --- scripts/tags.sh | 2 ++ 1 file changed, 2 insertions(+) diff --git a/scripts/tags.sh b/scripts/tags.sh index 23ba1c6..f72f48f 100755 --- a/scripts/tags.sh

[PATCH] scripts/tags.sh: add regex to map kprobe helpers

2016-02-18 Thread Naveen N. Rao
Add regex for [get|free]_[insn|optinsn|dmainsn]_slot() functions. Signed-off-by: Naveen N. Rao --- scripts/tags.sh | 2 ++ 1 file changed, 2 insertions(+) diff --git a/scripts/tags.sh b/scripts/tags.sh index 23ba1c6..f72f48f 100755 --- a/scripts/tags.sh +++ b/scripts/tags.sh @@ -163,6 +163,8

Re: [RESEND PATCH v4 2/3] tools: Move Makefile.arch from perf/config to tools/scripts

2015-12-16 Thread Naveen N. Rao
d-off-by: Wang Nan > Acked-by: Jiri Olsa > Tested-by: Naveen N. Rao > Cc: Arnaldo Carvalho de Melo > Cc: Naveen N. Rao > Cc: Sukadev Bhattiprolu > --- > tools/perf/config/Makefile | 2 +- > tools/perf/config/Makefile.arch | 18 -- > tools/perf/

Re: [PATCH v4] perf: bpf: Fix build breakage due to libbpf

2015-12-16 Thread Naveen N. Rao
On 2015/12/17 09:29AM, Wang Nan wrote: > > > On 2015/12/17 3:42, Arnaldo Carvalho de Melo wrote: > >Em Tue, Dec 15, 2015 at 05:10:46PM +0530, Naveen N. Rao escreveu: > >>On 2015/12/15 08:51AM, Wang Nan wrote: > >>>From: "Naveen N. Rao" > &

Re: [RESEND PATCH v4 2/3] tools: Move Makefile.arch from perf/config to tools/scripts

2015-12-16 Thread Naveen N. Rao
d-off-by: Wang Nan <wangn...@huawei.com> > Acked-by: Jiri Olsa <jo...@kernel.org> > Tested-by: Naveen N. Rao <naveen.n@linux.vnet.ibm.com> > Cc: Arnaldo Carvalho de Melo <a...@kernel.org> > Cc: Naveen N. Rao <naveen.n@linux.vnet.ibm.com> > Cc: Sukad

Re: [PATCH v4] perf: bpf: Fix build breakage due to libbpf

2015-12-16 Thread Naveen N. Rao
On 2015/12/17 09:29AM, Wang Nan wrote: > > > On 2015/12/17 3:42, Arnaldo Carvalho de Melo wrote: > >Em Tue, Dec 15, 2015 at 05:10:46PM +0530, Naveen N. Rao escreveu: > >>On 2015/12/15 08:51AM, Wang Nan wrote: > >>>From: "Naveen N. Rao" <navee

Re: [PATCH v4] perf: bpf: Fix build breakage due to libbpf

2015-12-15 Thread Naveen N. Rao
On 2015/12/15 08:51AM, Wang Nan wrote: > From: "Naveen N. Rao" > > perf build is currently (v4.4-rc5) broken on powerpc: > > bpf.c:28:4: error: #error __NR_bpf not defined. libbpf does not support > your arch. > # error __NR_bpf not defined. libbpf does not supp

Re: [PATCH v3 0/3] perf build: PowerPC: Fix build breakage due to libbpf

2015-12-15 Thread Naveen N. Rao
3 patches. Please help me test it on PowerPC. Hi Wang, Thanks for putting this together. Entire series: Tested-by: Naveen N. Rao > > Cc: Arnaldo Carvalho de Melo > Cc: Jiri Olsa > Cc: Naveen N. Rao > Cc: Sukadev Bhattiprolu > > Naveen N. Rao (1): > perf:

Re: [PATCH v3 0/3] perf build: PowerPC: Fix build breakage due to libbpf

2015-12-15 Thread Naveen N. Rao
3 patches. Please help me test it on PowerPC. Hi Wang, Thanks for putting this together. Entire series: Tested-by: Naveen N. Rao <naveen.n@linux.vnet.ibm.com> > > Cc: Arnaldo Carvalho de Melo <a...@kernel.org> > Cc: Jiri Olsa <jo...@redhat.com> > Cc: N

Re: [PATCH v4] perf: bpf: Fix build breakage due to libbpf

2015-12-15 Thread Naveen N. Rao
On 2015/12/15 08:51AM, Wang Nan wrote: > From: "Naveen N. Rao" <naveen.n@linux.vnet.ibm.com> > > perf build is currently (v4.4-rc5) broken on powerpc: > > bpf.c:28:4: error: #error __NR_bpf not defined. libbpf does not support > your arch. > # er

Re: [PATCH v2] tools lib bpf: Support libbpf on PowerPC

2015-12-14 Thread Naveen N. Rao
On 2015/12/14 11:57AM, Wang Nan wrote: > Support basic PowerPC compiling. > > Checks BPF syscall number, turn off libbpf building on platform doesn't > support sys_bpf instead of blocking compiling. > > Reported-by: Naveen N. Rao > Signed-off-by: Wang Nan > Cc: Arnald

Re: [PATCH] perf: bpf: Fix build breakage due to libbpf

2015-12-14 Thread Naveen N. Rao
On 2015/12/14 07:53PM, Wang Nan wrote: > Hi Naveen, > > On 2015/12/14 18:50, Naveen N. Rao wrote: > >perf build is currently (v4.4-rc5) broken on powerpc: > > > >bpf.c:28:4: error: #error __NR_bpf not defined. libbpf does not support > >your arch. > > #

<    4   5   6   7   8   9   10   11   12   13   >