Use cred->fsuid and cred->fsgid instead.
Signed-off-by: NeilBrown
---
fs/nfs/flexfilelayout/flexfilelayout.c | 14 --
fs/nfsd/nfs4callback.c |6 ++
include/linux/sunrpc/auth.h|3 ---
net/sunrpc/auth.c |6 +
it is never used.
Signed-off-by: NeilBrown
---
include/linux/sunrpc/sched.h |1 -
1 file changed, 1 deletion(-)
diff --git a/include/linux/sunrpc/sched.h b/include/linux/sunrpc/sched.h
index 7b540c066594..f542dad8d4ab 100644
--- a/include/linux/sunrpc/sched.h
+++ b/include/linux/sunrpc
Use cred->fsuid and cred->fsgid instead.
Signed-off-by: NeilBrown
---
fs/nfs/flexfilelayout/flexfilelayout.c | 14 --
fs/nfsd/nfs4callback.c |6 ++
include/linux/sunrpc/auth.h|3 ---
net/sunrpc/auth.c |6 +
it is never used.
Signed-off-by: NeilBrown
---
include/linux/sunrpc/sched.h |1 -
1 file changed, 1 deletion(-)
diff --git a/include/linux/sunrpc/sched.h b/include/linux/sunrpc/sched.h
index 7b540c066594..f542dad8d4ab 100644
--- a/include/linux/sunrpc/sched.h
+++ b/include/linux/sunrpc
that the original need for the locking here was removed
long ago, and there is no longer anything to protect.
Signed-off-by: NeilBrown
---
fs/nfs/nfs4_fs.h|6 +++---
fs/nfs/nfs4proc.c |4 ++--
fs/nfs/nfs4renewd.c |5 +
fs/nfs/nfs4state.c | 26 ++
4 files changed
that the original need for the locking here was removed
long ago, and there is no longer anything to protect.
Signed-off-by: NeilBrown
---
fs/nfs/nfs4_fs.h|6 +++---
fs/nfs/nfs4proc.c |4 ++--
fs/nfs/nfs4renewd.c |5 +
fs/nfs/nfs4state.c | 26 ++
4 files changed
cl_machine_cred and
cl_root_cred will disappear later in the series.
Signed-off-by: NeilBrown
---
fs/nfs/client.c |2 ++
fs/nfs/nfs4state.c| 20
include/linux/nfs_fs_sb.h |1 +
3 files changed, 15 insertions(+), 8 deletions(-)
diff --git a/fs/nfs/client.c
cl_machine_cred and
cl_root_cred will disappear later in the series.
Signed-off-by: NeilBrown
---
fs/nfs/client.c |2 ++
fs/nfs/nfs4state.c| 20
include/linux/nfs_fs_sb.h |1 +
3 files changed, 15 insertions(+), 8 deletions(-)
diff --git a/fs/nfs/client.c
We can use cred->groupinfo (from the 'struct cred') instead.
Signed-off-by: NeilBrown
---
fs/nfs/flexfilelayout/flexfilelayout.c | 14 +-
include/linux/sunrpc/auth.h|1 -
net/sunrpc/auth.c |1 -
net/sunrpc/auth_generic.c |
the
reference, and "acred" shares it.
Signed-off-by: NeilBrown
---
fs/nfs/flexfilelayout/flexfilelayout.c | 17 +
fs/nfsd/nfs4callback.c | 13 -
include/linux/sunrpc/auth.h|2 ++
net/sunrpc/auth.c
oot credential instead.
This appears to be what is expected of the caller, and is
clearly the result provided by both auth_unix and auth_gss
which already ignore the flag.
Signed-off-by: NeilBrown
---
include/linux/sunrpc/auth.h|3 +--
net/sunrpc/auth_generic.c | 12 ++--
We can use cred->groupinfo (from the 'struct cred') instead.
Signed-off-by: NeilBrown
---
fs/nfs/flexfilelayout/flexfilelayout.c | 14 +-
include/linux/sunrpc/auth.h|1 -
net/sunrpc/auth.c |1 -
net/sunrpc/auth_generic.c |
the
reference, and "acred" shares it.
Signed-off-by: NeilBrown
---
fs/nfs/flexfilelayout/flexfilelayout.c | 17 +
fs/nfsd/nfs4callback.c | 13 -
include/linux/sunrpc/auth.h|2 ++
net/sunrpc/auth.c
oot credential instead.
This appears to be what is expected of the caller, and is
clearly the result provided by both auth_unix and auth_gss
which already ignore the flag.
Signed-off-by: NeilBrown
---
include/linux/sunrpc/auth.h|3 +--
net/sunrpc/auth_generic.c | 12 ++--
it in
get_task_cred().
Signed-off-by: NeilBrown
---
include/linux/cred.h | 11 +++
kernel/cred.c|2 +-
2 files changed, 12 insertions(+), 1 deletion(-)
diff --git a/include/linux/cred.h b/include/linux/cred.h
index f1085767e1b3..48979fcb95cf 100644
--- a/include/linux/cred.h
+++ b
comments most welcome.
Thanks,
NeilBrown
---
NeilBrown (23):
cred: add cred_fscmp() for comparing creds.
cred: add get_cred_rcu()
cred: export get_task_cred().
cred: allow get_cred() and put_cred() to be given NULL.
SUNRPC: add 'struct cred *' to auth_cred
It is common practice for helpers like this to silently,
accept a NULL pointer.
get_rpccred() and put_rpccred() used by NFS act this way
and using the same interface will ease the conversion
for NFS, and simplify the resulting code.
Signed-off-by: NeilBrown
---
include/linux/cred.h | 14
to more consistent
use of 'struct cred' we need a comparison function.
This patch adds that function.
Signed-off-by: NeilBrown
---
include/linux/cred.h |1 +
kernel/cred.c| 55 ++
2 files changed, 56 insertions(+)
diff --git a/include/linux
There is no reason that modules should not be able
to use this, and NFS will need it when converted to
use 'struct cred'.
Signed-off-by: NeilBrown
---
kernel/cred.c |1 +
1 file changed, 1 insertion(+)
diff --git a/kernel/cred.c b/kernel/cred.c
index ba60162249e8..21f4a97085b4 100644
it in
get_task_cred().
Signed-off-by: NeilBrown
---
include/linux/cred.h | 11 +++
kernel/cred.c|2 +-
2 files changed, 12 insertions(+), 1 deletion(-)
diff --git a/include/linux/cred.h b/include/linux/cred.h
index f1085767e1b3..48979fcb95cf 100644
--- a/include/linux/cred.h
+++ b
comments most welcome.
Thanks,
NeilBrown
---
NeilBrown (23):
cred: add cred_fscmp() for comparing creds.
cred: add get_cred_rcu()
cred: export get_task_cred().
cred: allow get_cred() and put_cred() to be given NULL.
SUNRPC: add 'struct cred *' to auth_cred
It is common practice for helpers like this to silently,
accept a NULL pointer.
get_rpccred() and put_rpccred() used by NFS act this way
and using the same interface will ease the conversion
for NFS, and simplify the resulting code.
Signed-off-by: NeilBrown
---
include/linux/cred.h | 14
to more consistent
use of 'struct cred' we need a comparison function.
This patch adds that function.
Signed-off-by: NeilBrown
---
include/linux/cred.h |1 +
kernel/cred.c| 55 ++
2 files changed, 56 insertions(+)
diff --git a/include/linux
There is no reason that modules should not be able
to use this, and NFS will need it when converted to
use 'struct cred'.
Signed-off-by: NeilBrown
---
kernel/cred.c |1 +
1 file changed, 1 insertion(+)
diff --git a/kernel/cred.c b/kernel/cred.c
index ba60162249e8..21f4a97085b4 100644
On Fri, Oct 05 2018, NeilBrown wrote:
> The synchronize_rcu() in namespace_unlock() is called every time
> a filesystem is unmounted. If a great many filesystems are mounted,
> this can cause a noticable slow-down in, for example, system shutdown.
>
> The sequence:
> mkdi
On Fri, Oct 05 2018, NeilBrown wrote:
> The synchronize_rcu() in namespace_unlock() is called every time
> a filesystem is unmounted. If a great many filesystems are mounted,
> this can cause a noticable slow-down in, for example, system shutdown.
>
> The sequence:
> mkdi
On Mon, Nov 05 2018, Jeff Layton wrote:
> On Mon, 2018-11-05 at 12:30 +1100, NeilBrown wrote:
>> Rather than assuming all-zeros is sufficient, use the available API to
>> initialize the file_lock structure use for unlock.
>> VFS-level changes will soon make it important t
On Mon, Nov 05 2018, Jeff Layton wrote:
> On Mon, 2018-11-05 at 12:30 +1100, NeilBrown wrote:
>> Rather than assuming all-zeros is sufficient, use the available API to
>> initialize the file_lock structure use for unlock.
>> VFS-level changes will soon make it important t
- spaces before tabs,
- spaces at the end of lines,
- multiple blank lines,
- blank lines before EXPORT_SYMBOL,
can all go.
Signed-off-by: NeilBrown
---
fs/locks.c | 33 -
1 file changed, 12 insertions(+), 21 deletions(-)
diff --git a/fs/locks.c b/fs
.
Signed-off-by: NeilBrown
---
fs/cifs/file.c |2 +-
fs/lockd/svclock.c |2 +-
fs/locks.c | 36 +---
fs/nfsd/nfs4state.c |6 +++---
include/linux/fs.h |4 ++--
5 files changed, 20 insertions(+), 30 deletions(-)
diff --git a/fs/cifs/file.c
- spaces before tabs,
- spaces at the end of lines,
- multiple blank lines,
- blank lines before EXPORT_SYMBOL,
can all go.
Signed-off-by: NeilBrown
---
fs/locks.c | 33 -
1 file changed, 12 insertions(+), 21 deletions(-)
diff --git a/fs/locks.c b/fs
.
Signed-off-by: NeilBrown
---
fs/cifs/file.c |2 +-
fs/lockd/svclock.c |2 +-
fs/locks.c | 36 +---
fs/nfsd/nfs4state.c |6 +++---
include/linux/fs.h |4 ++--
5 files changed, 20 insertions(+), 30 deletions(-)
diff --git a/fs/cifs/file.c
to the new lock, though when merged with a
pre-exiting lock, this might not happen.
In all cases we don't want blocked locks to remain
attached, so we remove them to be safe.
Signed-off-by: NeilBrown
---
fs/locks.c | 24 +---
1 file changed, 9 insertions(+), 15 deletions
using flock_make_lock(), and changing it to
allow a file_lock to be passed in, so memory allocation isn't
always needed.
Signed-off-by: NeilBrown
---
fs/locks.c | 21 +
1 file changed, 9 insertions(+), 12 deletions(-)
diff --git a/fs/locks.c b/fs/locks.c
index b8f33792a0a6
to the new lock, though when merged with a
pre-exiting lock, this might not happen.
In all cases we don't want blocked locks to remain
attached, so we remove them to be safe.
Signed-off-by: NeilBrown
---
fs/locks.c | 24 +---
1 file changed, 9 insertions(+), 15 deletions
using flock_make_lock(), and changing it to
allow a file_lock to be passed in, so memory allocation isn't
always needed.
Signed-off-by: NeilBrown
---
fs/locks.c | 21 +
1 file changed, 9 insertions(+), 12 deletions(-)
diff --git a/fs/locks.c b/fs/locks.c
index b8f33792a0a6
Wilck
Signed-off-by: NeilBrown
---
fs/locks.c | 29 +++--
1 file changed, 23 insertions(+), 6 deletions(-)
diff --git a/fs/locks.c b/fs/locks.c
index 802d5853acd5..1b0eac6b2918 100644
--- a/fs/locks.c
+++ b/fs/locks.c
@@ -715,11 +715,25 @@ static void locks_delete_block
is requeued or discarded, all blocked requests are
woken.
- When deadlock-detection looks for the lock which blocks a
given request, we follow the chain of ->fl_blocker all
the way to the top.
Signed-off-by: NeilBrown
---
fs/locks.c | 36 ++--
1 file changed,
.
And convert some
return (foo);
to
return foo;
Signed-off-by: NeilBrown
---
fs/locks.c | 27 +++
1 file changed, 15 insertions(+), 12 deletions(-)
diff --git a/fs/locks.c b/fs/locks.c
index a323160290f6..802d5853acd5 100644
--- a/fs/locks.c
+++ b/fs/locks.c
@@ -791,47
is requeued or discarded, all blocked requests are
woken.
- When deadlock-detection looks for the lock which blocks a
given request, we follow the chain of ->fl_blocker all
the way to the top.
Signed-off-by: NeilBrown
---
fs/locks.c | 36 ++--
1 file changed,
.
And convert some
return (foo);
to
return foo;
Signed-off-by: NeilBrown
---
fs/locks.c | 27 +++
1 file changed, 15 insertions(+), 12 deletions(-)
diff --git a/fs/locks.c b/fs/locks.c
index a323160290f6..802d5853acd5 100644
--- a/fs/locks.c
+++ b/fs/locks.c
@@ -791,47
Wilck
Signed-off-by: NeilBrown
---
fs/locks.c | 29 +++--
1 file changed, 23 insertions(+), 6 deletions(-)
diff --git a/fs/locks.c b/fs/locks.c
index 802d5853acd5..1b0eac6b2918 100644
--- a/fs/locks.c
+++ b/fs/locks.c
@@ -715,11 +715,25 @@ static void locks_delete_block
This functionality will be useful in future patches, so
split it out from locks_wake_up_blocks().
Signed-off-by: NeilBrown
---
fs/locks.c | 27 ---
1 file changed, 16 insertions(+), 11 deletions(-)
diff --git a/fs/locks.c b/fs/locks.c
index a6c6d601286c..b8f33792a0a6
without this patch there are about 700,000.
NeilBrown
---
NeilBrown (12):
fs/locks: rename some lists and pointers.
fs/locks: split out __locks_wake_up_blocks().
NFS: use locks_copy_lock() to copy locks.
gfs2: properly initial file_lock used for unlock.
ocfs2: properly
fl_blocker instead
of fl_next.
Signed-off-by: NeilBrown
---
fs/cifs/file.c |2 +-
fs/locks.c | 38 --
include/linux/fs.h |7 +--
include/trace/events/filelock.h | 16
4 files
This functionality will be useful in future patches, so
split it out from locks_wake_up_blocks().
Signed-off-by: NeilBrown
---
fs/locks.c | 27 ---
1 file changed, 16 insertions(+), 11 deletions(-)
diff --git a/fs/locks.c b/fs/locks.c
index a6c6d601286c..b8f33792a0a6
without this patch there are about 700,000.
NeilBrown
---
NeilBrown (12):
fs/locks: rename some lists and pointers.
fs/locks: split out __locks_wake_up_blocks().
NFS: use locks_copy_lock() to copy locks.
gfs2: properly initial file_lock used for unlock.
ocfs2: properly
fl_blocker instead
of fl_next.
Signed-off-by: NeilBrown
---
fs/cifs/file.c |2 +-
fs/locks.c | 38 --
include/linux/fs.h |7 +--
include/trace/events/filelock.h | 16
4 files
Rather than assuming all-zeros is sufficient, use the available API to
initialize the file_lock structure use for unlock.
VFS-level changes will soon make it important that the
list_heads in file_lock are always properly initialized.
Signed-off-by: NeilBrown
---
fs/gfs2/file.c | 10
-by: NeilBrown
---
fs/nfs/nfs4proc.c |6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
index 867457d6dfbe..0ba2b0fb8ff3 100644
--- a/fs/nfs/nfs4proc.c
+++ b/fs/nfs/nfs4proc.c
@@ -6311,7 +6311,8 @@ static struct nfs4_unlockdata
Rather than assuming all-zeros is sufficient, use the available API to
initialize the file_lock structure use for unlock.
VFS-level changes will soon make it important that the
list_heads in file_lock are always properly initialized.
Signed-off-by: NeilBrown
---
fs/ocfs2/locks.c | 10
Rather than assuming all-zeros is sufficient, use the available API to
initialize the file_lock structure use for unlock.
VFS-level changes will soon make it important that the
list_heads in file_lock are always properly initialized.
Signed-off-by: NeilBrown
---
fs/gfs2/file.c | 10
-by: NeilBrown
---
fs/nfs/nfs4proc.c |6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
index 867457d6dfbe..0ba2b0fb8ff3 100644
--- a/fs/nfs/nfs4proc.c
+++ b/fs/nfs/nfs4proc.c
@@ -6311,7 +6311,8 @@ static struct nfs4_unlockdata
Rather than assuming all-zeros is sufficient, use the available API to
initialize the file_lock structure use for unlock.
VFS-level changes will soon make it important that the
list_heads in file_lock are always properly initialized.
Signed-off-by: NeilBrown
---
fs/ocfs2/locks.c | 10
On Sat, Nov 03 2018, Paul E. McKenney wrote:
> On Sat, Nov 03, 2018 at 07:36:19PM +1100, NeilBrown wrote:
>> On Fri, Nov 02 2018, Paul E. McKenney wrote:
>>
>> > On Fri, Nov 02, 2018 at 08:50:11AM +1100, NeilBrown wrote:
>> >> On Thu, Nov 01 2018, Paul E. M
On Sat, Nov 03 2018, Paul E. McKenney wrote:
> On Sat, Nov 03, 2018 at 07:36:19PM +1100, NeilBrown wrote:
>> On Fri, Nov 02 2018, Paul E. McKenney wrote:
>>
>> > On Fri, Nov 02, 2018 at 08:50:11AM +1100, NeilBrown wrote:
>> >> On Thu, Nov 01 2018, Paul E. M
On Fri, Nov 02 2018, Paul E. McKenney wrote:
> On Fri, Nov 02, 2018 at 08:50:11AM +1100, NeilBrown wrote:
>> On Thu, Nov 01 2018, Paul E. McKenney wrote:
>>
>> > On Sat, Oct 27, 2018 at 02:10:10AM +0100, Josh Triplett wrote:
>> >> On Fri, Oct 26, 2018
On Fri, Nov 02 2018, Paul E. McKenney wrote:
> On Fri, Nov 02, 2018 at 08:50:11AM +1100, NeilBrown wrote:
>> On Thu, Nov 01 2018, Paul E. McKenney wrote:
>>
>> > On Sat, Oct 27, 2018 at 02:10:10AM +0100, Josh Triplett wrote:
>> >> On Fri, Oct 26, 2018
On Thu, Nov 01 2018, Paul E. McKenney wrote:
> On Sat, Oct 27, 2018 at 02:10:10AM +0100, Josh Triplett wrote:
>> On Fri, Oct 26, 2018 at 08:14:51AM +1100, NeilBrown wrote:
>> > On Wed, Oct 24 2018, Josh Triplett wrote:
>> >
>> > > On Tue, Oct 23, 20
On Thu, Nov 01 2018, Paul E. McKenney wrote:
> On Sat, Oct 27, 2018 at 02:10:10AM +0100, Josh Triplett wrote:
>> On Fri, Oct 26, 2018 at 08:14:51AM +1100, NeilBrown wrote:
>> > On Wed, Oct 24 2018, Josh Triplett wrote:
>> >
>> > > On Tue, Oct 23, 20
On Fri, Oct 26 2018, Jeff Layton wrote:
> On Wed, 2018-10-24 at 09:43 +1100, NeilBrown wrote:
>> This took longer that I had wanted, due to various reasons - sorry.
>> And I'm now posting it in a merge window, which is not ideal. I don't
>> expect it to be included in th
On Fri, Oct 26 2018, Jeff Layton wrote:
> On Wed, 2018-10-24 at 09:43 +1100, NeilBrown wrote:
>> This took longer that I had wanted, due to various reasons - sorry.
>> And I'm now posting it in a merge window, which is not ideal. I don't
>> expect it to be included in th
On Fri, Oct 26 2018, Jeff Layton wrote:
> On Wed, 2018-10-24 at 09:43 +1100, NeilBrown wrote:
>> This took longer that I had wanted, due to various reasons - sorry.
>> And I'm now posting it in a merge window, which is not ideal. I don't
>> expect it to be included in th
On Fri, Oct 26 2018, Jeff Layton wrote:
> On Wed, 2018-10-24 at 09:43 +1100, NeilBrown wrote:
>> This took longer that I had wanted, due to various reasons - sorry.
>> And I'm now posting it in a merge window, which is not ideal. I don't
>> expect it to be included in th
On Sat, Oct 27 2018, Josh Triplett wrote:
> On Fri, Oct 26, 2018 at 08:14:51AM +1100, NeilBrown wrote:
>> On Wed, Oct 24 2018, Josh Triplett wrote:
>>
>> > On Tue, Oct 23, 2018 at 07:26:06AM +1100, NeilBrown wrote:
>> >> On Sun, Oct 21 2018, Josh Triplett
On Sat, Oct 27 2018, Josh Triplett wrote:
> On Fri, Oct 26, 2018 at 08:14:51AM +1100, NeilBrown wrote:
>> On Wed, Oct 24 2018, Josh Triplett wrote:
>>
>> > On Tue, Oct 23, 2018 at 07:26:06AM +1100, NeilBrown wrote:
>> >> On Sun, Oct 21 2018, Josh Triplett
human, even if they don't act that way.
Do you *really* want to use the CoC to support your position?
Thanks,
NeilBrown
>
> --
> Jiri Kosina
> SUSE Labs
signature.asc
Description: PGP signature
human, even if they don't act that way.
Do you *really* want to use the CoC to support your position?
Thanks,
NeilBrown
>
> --
> Jiri Kosina
> SUSE Labs
signature.asc
Description: PGP signature
On Fri, Oct 26 2018, Rainer Fiebig wrote:
> NeilBrown schrieb:
>> On Thu, Oct 25 2018, Rainer Fiebig wrote:
>>
>>> Am Montag, 22. Oktober 2018, 08:20:11 schrieb NeilBrown:
>>>> On Sat, Oct 20 2018, Greg Kroah-Hartman wrote:
>>>>> Hi all,
>&g
On Fri, Oct 26 2018, Rainer Fiebig wrote:
> NeilBrown schrieb:
>> On Thu, Oct 25 2018, Rainer Fiebig wrote:
>>
>>> Am Montag, 22. Oktober 2018, 08:20:11 schrieb NeilBrown:
>>>> On Sat, Oct 20 2018, Greg Kroah-Hartman wrote:
>>>>> Hi all,
>&g
On Thu, Oct 25 2018, Eric S. Raymond wrote:
> NeilBrown :
>> I think you are blurring two groups here.
>> Ted describes "anti-CoC dissidents" as people who are advancing an
>> argument about rescinding their license. This is a smaller groups than
>> the
On Thu, Oct 25 2018, Eric S. Raymond wrote:
> NeilBrown :
>> I think you are blurring two groups here.
>> Ted describes "anti-CoC dissidents" as people who are advancing an
>> argument about rescinding their license. This is a smaller groups than
>> the
On Thu, Oct 25 2018, Rainer Fiebig wrote:
> Am Montag, 22. Oktober 2018, 08:20:11 schrieb NeilBrown:
>> On Sat, Oct 20 2018, Greg Kroah-Hartman wrote:
>> > Hi all,
>> >
>> > As everyone knows by now, we added a new Code of Conduct to the kernel
>> >
On Thu, Oct 25 2018, Rainer Fiebig wrote:
> Am Montag, 22. Oktober 2018, 08:20:11 schrieb NeilBrown:
>> On Sat, Oct 20 2018, Greg Kroah-Hartman wrote:
>> > Hi all,
>> >
>> > As everyone knows by now, we added a new Code of Conduct to the kernel
>> >
o don't really like the CoC. I suspect is it is a
much smaller group when restricting to actual copyright holders.
I am against the CoC as it stands, but rescinding any license is such an
enormous over-reaction, I find the concept laughable.
NeilBrown
>
> Even supposing you are right about
o don't really like the CoC. I suspect is it is a
much smaller group when restricting to actual copyright holders.
I am against the CoC as it stands, but rescinding any license is such an
enormous over-reaction, I find the concept laughable.
NeilBrown
>
> Even supposing you are right about
On Wed, Oct 24 2018, Laura Abbott wrote:
> On 10/21/2018 02:20 PM, NeilBrown wrote:
>
>
>
>> I call on the community to consider what *does* need to be said, about
>> conduct, to people outside the community and who have recently joined.
>> What is the document tha
On Wed, Oct 24 2018, Laura Abbott wrote:
> On 10/21/2018 02:20 PM, NeilBrown wrote:
>
>
>
>> I call on the community to consider what *does* need to be said, about
>> conduct, to people outside the community and who have recently joined.
>> What is the document tha
On Wed, Oct 24 2018, Josh Triplett wrote:
> On Tue, Oct 23, 2018 at 07:26:06AM +1100, NeilBrown wrote:
>> On Sun, Oct 21 2018, Josh Triplett wrote:
>>
>> > On Mon, Oct 22, 2018 at 08:20:11AM +1100, NeilBrown wrote:
>> >> I call on you, Greg:
>> >&g
On Wed, Oct 24 2018, Josh Triplett wrote:
> On Tue, Oct 23, 2018 at 07:26:06AM +1100, NeilBrown wrote:
>> On Sun, Oct 21 2018, Josh Triplett wrote:
>>
>> > On Mon, Oct 22, 2018 at 08:20:11AM +1100, NeilBrown wrote:
>> >> I call on you, Greg:
>> >&g
On Wed, Oct 24 2018, Theodore Y. Ts'o wrote:
> On Wed, Oct 24, 2018 at 12:47:57PM +1100, NeilBrown wrote:
>>
>> I doubt it was copied - more likely independent evolution.
>> But on reflection, I see that it is probably reasonable that it
>> shouldn't be used this way
On Wed, Oct 24 2018, Theodore Y. Ts'o wrote:
> On Wed, Oct 24, 2018 at 12:47:57PM +1100, NeilBrown wrote:
>>
>> I doubt it was copied - more likely independent evolution.
>> But on reflection, I see that it is probably reasonable that it
>> shouldn't be used this way
On Thu, Oct 18 2018, Andy Lutomirski wrote:
> On Wed, Oct 17, 2018 at 9:36 PM NeilBrown wrote:
>>
>> On Wed, Oct 17 2018, Andy Lutomirski wrote:
>>
>> > On Wed, Oct 17, 2018 at 6:48 PM NeilBrown wrote:
>> >>
>> >>
>> >> Was: Re:
On Thu, Oct 18 2018, Andy Lutomirski wrote:
> On Wed, Oct 17, 2018 at 9:36 PM NeilBrown wrote:
>>
>> On Wed, Oct 17 2018, Andy Lutomirski wrote:
>>
>> > On Wed, Oct 17, 2018 at 6:48 PM NeilBrown wrote:
>> >>
>> >>
>> >> Was: Re:
.
And convert some
return (foo);
to
return foo;
Signed-off-by: NeilBrown
---
fs/locks.c | 27 +++
1 file changed, 15 insertions(+), 12 deletions(-)
diff --git a/fs/locks.c b/fs/locks.c
index e2ad0a7986c5..1e2a122c9673 100644
--- a/fs/locks.c
+++ b/fs/locks.c
@@ -791,47
.
And convert some
return (foo);
to
return foo;
Signed-off-by: NeilBrown
---
fs/locks.c | 27 +++
1 file changed, 15 insertions(+), 12 deletions(-)
diff --git a/fs/locks.c b/fs/locks.c
index e2ad0a7986c5..1e2a122c9673 100644
--- a/fs/locks.c
+++ b/fs/locks.c
@@ -791,47
- spaces before tabs,
- spaces at the end of lines,
- multiple blank lines,
- blank lines before EXPORT_SYMBOL,
can all go.
Signed-off-by: NeilBrown
---
fs/locks.c | 33 -
1 file changed, 12 insertions(+), 21 deletions(-)
diff --git a/fs/locks.c b/fs
- spaces before tabs,
- spaces at the end of lines,
- multiple blank lines,
- blank lines before EXPORT_SYMBOL,
can all go.
Signed-off-by: NeilBrown
---
fs/locks.c | 33 -
1 file changed, 12 insertions(+), 21 deletions(-)
diff --git a/fs/locks.c b/fs
is requeued or discarded, all blocked requests are
woken.
- When deadlock-detection looks for the lock which blocks a
given request, we follow the chain of ->fl_blocker all
the way to the top.
Signed-off-by: NeilBrown
---
fs/locks.c | 36 ++--
1 file changed,
Wilck
Signed-off-by: NeilBrown
---
fs/locks.c | 29 +++--
1 file changed, 23 insertions(+), 6 deletions(-)
diff --git a/fs/locks.c b/fs/locks.c
index 1e2a122c9673..06e9ae1cc0c4 100644
--- a/fs/locks.c
+++ b/fs/locks.c
@@ -715,11 +715,25 @@ static void locks_delete_block
.
Signed-off-by: NeilBrown
---
fs/cifs/file.c |2 +-
fs/lockd/svclock.c |2 +-
fs/locks.c | 35 ---
fs/nfsd/nfs4state.c |6 +++---
include/linux/fs.h |4 ++--
5 files changed, 19 insertions(+), 30 deletions(-)
diff --git a/fs/cifs/file.c
to the new lock, though when merged with a
pre-exiting lock, this might not happen.
In all cases we don't want blocked locks to remain
attached, so we remove them to be safe.
Signed-off-by: NeilBrown
---
fs/locks.c | 24 +---
1 file changed, 9 insertions(+), 15 deletions
is requeued or discarded, all blocked requests are
woken.
- When deadlock-detection looks for the lock which blocks a
given request, we follow the chain of ->fl_blocker all
the way to the top.
Signed-off-by: NeilBrown
---
fs/locks.c | 36 ++--
1 file changed,
Wilck
Signed-off-by: NeilBrown
---
fs/locks.c | 29 +++--
1 file changed, 23 insertions(+), 6 deletions(-)
diff --git a/fs/locks.c b/fs/locks.c
index 1e2a122c9673..06e9ae1cc0c4 100644
--- a/fs/locks.c
+++ b/fs/locks.c
@@ -715,11 +715,25 @@ static void locks_delete_block
.
Signed-off-by: NeilBrown
---
fs/cifs/file.c |2 +-
fs/lockd/svclock.c |2 +-
fs/locks.c | 35 ---
fs/nfsd/nfs4state.c |6 +++---
include/linux/fs.h |4 ++--
5 files changed, 19 insertions(+), 30 deletions(-)
diff --git a/fs/cifs/file.c
to the new lock, though when merged with a
pre-exiting lock, this might not happen.
In all cases we don't want blocked locks to remain
attached, so we remove them to be safe.
Signed-off-by: NeilBrown
---
fs/locks.c | 24 +---
1 file changed, 9 insertions(+), 15 deletions
fl_blocker instead
of fl_next.
Signed-off-by: NeilBrown
---
fs/cifs/file.c |2 +-
fs/locks.c | 38 --
include/linux/fs.h |7 +--
include/trace/events/filelock.h | 16
4 files
-by: NeilBrown
---
fs/nfs/nfs4proc.c |6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
index 8220a168282e..cd5a431c6583 100644
--- a/fs/nfs/nfs4proc.c
+++ b/fs/nfs/nfs4proc.c
@@ -6284,7 +6284,8 @@ static struct nfs4_unlockdata
This functionality will be useful in future patches, so
split it out from locks_wake_up_blocks().
Signed-off-by: NeilBrown
---
fs/locks.c | 27 ---
1 file changed, 16 insertions(+), 11 deletions(-)
diff --git a/fs/locks.c b/fs/locks.c
index a6c6d601286c..b8f33792a0a6
fl_blocker instead
of fl_next.
Signed-off-by: NeilBrown
---
fs/cifs/file.c |2 +-
fs/locks.c | 38 --
include/linux/fs.h |7 +--
include/trace/events/filelock.h | 16
4 files
301 - 400 of 4892 matches
Mail list logo
