[GIT PULL] target updates for v4.4-rc1

2015-11-13 Thread Nicholas A. Bellinger
Hello Linus, Apologies for the late PULL request. Please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git for-next This series contains HCH's changes to absorb configfs attribute ->show() + ->store() function pointer usage from it's original tree-wide

[GIT PULL] target updates for v4.4-rc1

2015-11-13 Thread Nicholas A. Bellinger
Hello Linus, Apologies for the late PULL request. Please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git for-next This series contains HCH's changes to absorb configfs attribute ->show() + ->store() function pointer usage from it's original tree-wide

[GIT PULL] target updates for v4.4-rc1

2015-11-13 Thread Nicholas A. Bellinger
Hello Linus, Apologies for the late PULL request. Please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git for-next This series contains HCH's changes to absorb configfs attribute ->show() + ->store() function pointer usage from it's original tree-wide

[GIT PULL] target updates for v4.4-rc1

2015-11-13 Thread Nicholas A. Bellinger
Hello Linus, Apologies for the late PULL request. Please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git for-next This series contains HCH's changes to absorb configfs attribute ->show() + ->store() function pointer usage from it's original tree-wide

Re: [GIT PULL] target updates for v4.4-rc1

2015-11-13 Thread Nicholas A. Bellinger
On Fri, 2015-11-13 at 09:48 -0800, Linus Torvalds wrote: > On Fri, Nov 13, 2015 at 1:59 AM, Nicholas A. Bellinger > <n...@linux-iscsi.org> wrote: > > > > Please pull from: > > > > git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git > >

[GIT PULL] target updates for v4.4-rc1 (-v2)

2015-11-13 Thread Nicholas A. Bellinger
Hi Linus, Here is the (late) target-updates for v4.4-rc1. There is one build failure as reported by linux-next in hwtracing/stm to expect after merging: https://lkml.org/lkml/2015/10/6/1016 That has been fixed-up to use the new configfs attribute API by Alexander (CC'ed) here: [PATCH] stm

[GIT PULL] target fixes for v4.3-rc3

2015-09-26 Thread Nicholas A. Bellinger
all the command data comes as immediate Nicholas Bellinger (5): target: Fix PR registration + APTPL RCU conversion regression target: Propigate backend read-only to core_tpg_add_lun target: Fix target_sense_desc_format NULL pointer dereference target: Make TCM_WRITE_PROTECT failure honor D_SENSE

[GIT PULL] target fixes for v4.3-rc3

2015-09-26 Thread Nicholas A. Bellinger
all the command data comes as immediate Nicholas Bellinger (5): target: Fix PR registration + APTPL RCU conversion regression target: Propigate backend read-only to core_tpg_add_lun target: Fix target_sense_desc_format NULL pointer dereference target: Make TCM_WRITE_PROTECT failure honor D_SENSE

Re: [GIT PULL] target updates for v4.3-rc1

2015-09-11 Thread Nicholas A. Bellinger
On Fri, 2015-09-11 at 14:28 -0700, Linus Torvalds wrote: > On Fri, Sep 11, 2015 at 2:07 PM, Nicholas A. Bellinger > wrote: > > (RESENDING) > > This is not a re-send as far as I'm concerned. I've not seen the > original. The last email I saw from you was from Aug 18, the su

[GIT PULL] target updates for v4.3-rc1

2015-09-11 Thread Nicholas A. Bellinger
t: Add tpg_enabled_sendtargets for disabled discovery target: use stringify.h instead of own definition Hannes Reinecke (2): tcm_loop: Remove SAS vestigies tcm_loop: Send I_T_NEXUS_LOSS_OCCURRED UA Joern Engel (1): target: improve unsupported opcode message Nicholas Bellinger (2):

Re: [PATCH-v2 1/2] mpt3sas: Refcount sas_device objects and fix unsafe list usage

2015-09-11 Thread Nicholas A. Bellinger
On Fri, 2015-09-11 at 10:50 -0700, James Bottomley wrote: > On Thu, 2015-09-10 at 23:55 -0700, Nicholas A. Bellinger wrote: > > On Wed, 2015-09-09 at 15:03 -0700, Nicholas A. Bellinger wrote: > > > On Wed, 2015-09-09 at 19:59 +0530, Chaitra Basappa wrote: > > &

Re: [PATCH-v2 1/2] mpt3sas: Refcount sas_device objects and fix unsafe list usage

2015-09-11 Thread Nicholas A. Bellinger
On Wed, 2015-09-09 at 15:03 -0700, Nicholas A. Bellinger wrote: > On Wed, 2015-09-09 at 19:59 +0530, Chaitra Basappa wrote: > > From: Sreekanth Reddy [mailto:sreekanth.re...@avagotech.com] > > Sent: Tuesday, September 08, 2015 5:26 PM > > To: Nicholas A. Bellinger > > C

Re: [PATCH-v2 1/2] mpt3sas: Refcount sas_device objects and fix unsafe list usage

2015-09-11 Thread Nicholas A. Bellinger
On Wed, 2015-09-09 at 15:03 -0700, Nicholas A. Bellinger wrote: > On Wed, 2015-09-09 at 19:59 +0530, Chaitra Basappa wrote: > > From: Sreekanth Reddy [mailto:sreekanth.re...@avagotech.com] > > Sent: Tuesday, September 08, 2015 5:26 PM > > To: Nicholas A. Bellinger > > C

Re: [PATCH-v2 1/2] mpt3sas: Refcount sas_device objects and fix unsafe list usage

2015-09-11 Thread Nicholas A. Bellinger
On Fri, 2015-09-11 at 10:50 -0700, James Bottomley wrote: > On Thu, 2015-09-10 at 23:55 -0700, Nicholas A. Bellinger wrote: > > On Wed, 2015-09-09 at 15:03 -0700, Nicholas A. Bellinger wrote: > > > On Wed, 2015-09-09 at 19:59 +0530, Chaitra Basappa wrote: > > &

Re: [GIT PULL] target updates for v4.3-rc1

2015-09-11 Thread Nicholas A. Bellinger
On Fri, 2015-09-11 at 14:28 -0700, Linus Torvalds wrote: > On Fri, Sep 11, 2015 at 2:07 PM, Nicholas A. Bellinger > <n...@linux-iscsi.org> wrote: > > (RESENDING) > > This is not a re-send as far as I'm concerned. I've not seen the > original. The last email I s

[GIT PULL] target updates for v4.3-rc1

2015-09-11 Thread Nicholas A. Bellinger
t: Add tpg_enabled_sendtargets for disabled discovery target: use stringify.h instead of own definition Hannes Reinecke (2): tcm_loop: Remove SAS vestigies tcm_loop: Send I_T_NEXUS_LOSS_OCCURRED UA Joern Engel (1): target: improve unsupported opcode message Nicholas Bellinger (2):

Re: [PATCH-v2 1/2] mpt3sas: Refcount sas_device objects and fix unsafe list usage

2015-09-09 Thread Nicholas A. Bellinger
On Wed, 2015-09-09 at 19:59 +0530, Chaitra Basappa wrote: > From: Sreekanth Reddy [mailto:sreekanth.re...@avagotech.com] > Sent: Tuesday, September 08, 2015 5:26 PM > To: Nicholas A. Bellinger > Cc: linux-scsi; linux-kernel; James Bottomley; Calvin Owens; Christoph > Hellwig; MPT-

Re: [PATCH-v2 1/2] mpt3sas: Refcount sas_device objects and fix unsafe list usage

2015-09-09 Thread Nicholas A. Bellinger
Hi Sreekanth, On Tue, 2015-09-08 at 17:25 +0530, Sreekanth Reddy wrote: > On Sun, Aug 30, 2015 at 1:24 PM, Nicholas A. Bellinger > wrote: > > From: Nicholas Bellinger > > > > These objects can be referenced concurrently throughout the driver, we > > need a way to

Re: [PATCH-v2 1/2] mpt3sas: Refcount sas_device objects and fix unsafe list usage

2015-09-09 Thread Nicholas A. Bellinger
Hi Sreekanth, On Tue, 2015-09-08 at 17:25 +0530, Sreekanth Reddy wrote: > On Sun, Aug 30, 2015 at 1:24 PM, Nicholas A. Bellinger > <n...@daterainc.com> wrote: > > From: Nicholas Bellinger <n...@linux-iscsi.org> > > > > These objects can be referenced co

Re: [PATCH-v2 1/2] mpt3sas: Refcount sas_device objects and fix unsafe list usage

2015-09-09 Thread Nicholas A. Bellinger
On Wed, 2015-09-09 at 19:59 +0530, Chaitra Basappa wrote: > From: Sreekanth Reddy [mailto:sreekanth.re...@avagotech.com] > Sent: Tuesday, September 08, 2015 5:26 PM > To: Nicholas A. Bellinger > Cc: linux-scsi; linux-kernel; James Bottomley; Calvin Owens; Christoph > Hellwig; MPT-

Re: [PATCH-v2 0/2] mpt3sas: Reference counting fixes from for-next mpt2sas

2015-09-04 Thread Nicholas A. Bellinger
Hi Sreekanth, (Adding MKP CC') On Sun, 2015-08-30 at 07:54 +, Nicholas A. Bellinger wrote: > From: Nicholas Bellinger > > Hi all, > > This series is a mpt3sas LLD forward port of Calvin Owens' for-next > reference counting bugfix series for mpt2sas LLD code. > >

Re: [PATCH-v2 0/2] mpt3sas: Reference counting fixes from for-next mpt2sas

2015-09-04 Thread Nicholas A. Bellinger
Hi Sreekanth, (Adding MKP CC') On Sun, 2015-08-30 at 07:54 +, Nicholas A. Bellinger wrote: > From: Nicholas Bellinger <n...@linux-iscsi.org> > > Hi all, > > This series is a mpt3sas LLD forward port of Calvin Owens' for-next > reference counting bugfix series for mp

[PATCH-v2 2/2] mpt3sas: Refcount fw_events and fix unsafe list usage

2015-08-30 Thread Nicholas A. Bellinger
From: Nicholas Bellinger The fw_event_work struct is concurrently referenced at shutdown, so add a refcount to protect it, and refactor the code to use it. Additionally, refactor _scsih_fw_event_cleanup_queue() such that it no longer iterates over the list without holding the lock, since

[PATCH-v2 1/2] mpt3sas: Refcount sas_device objects and fix unsafe list usage

2015-08-30 Thread Nicholas A. Bellinger
From: Nicholas Bellinger These objects can be referenced concurrently throughout the driver, we need a way to make sure threads can't delete them out from under each other. This patch adds the refcount, and refactors the code to use it. Additionally, we cannot iterate over the sas_device_list

[PATCH-v2 0/2] mpt3sas: Reference counting fixes from for-next mpt2sas

2015-08-30 Thread Nicholas A. Bellinger
From: Nicholas Bellinger Hi all, This series is a mpt3sas LLD forward port of Calvin Owens' for-next reference counting bugfix series for mpt2sas LLD code. His latest patch series can be found here: [PATCH v4 0/2] Fixes for memory corruption in mpt2sas http://marc.info/?l=linux-scsi

Re: [PATCH 0/2] mpt3sas: Reference counting fixes from in-flight mpt2sas

2015-08-30 Thread Nicholas A. Bellinger
On Fri, 2015-08-28 at 13:25 -0700, James Bottomley wrote: > On Thu, 2015-08-27 at 12:15 -0700, Nicholas A. Bellinger wrote: > > On Thu, 2015-08-27 at 07:40 -0700, James Bottomley wrote: > > > On Thu, 2015-08-27 at 10:37 +0530, Sreekanth Reddy wrote: > >

[PATCH-v2 1/2] mpt3sas: Refcount sas_device objects and fix unsafe list usage

2015-08-30 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org These objects can be referenced concurrently throughout the driver, we need a way to make sure threads can't delete them out from under each other. This patch adds the refcount, and refactors the code to use it. Additionally, we cannot iterate over

[PATCH-v2 0/2] mpt3sas: Reference counting fixes from for-next mpt2sas

2015-08-30 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org Hi all, This series is a mpt3sas LLD forward port of Calvin Owens' for-next reference counting bugfix series for mpt2sas LLD code. His latest patch series can be found here: [PATCH v4 0/2] Fixes for memory corruption in mpt2sas http://marc.info/?l

[PATCH-v2 2/2] mpt3sas: Refcount fw_events and fix unsafe list usage

2015-08-30 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org The fw_event_work struct is concurrently referenced at shutdown, so add a refcount to protect it, and refactor the code to use it. Additionally, refactor _scsih_fw_event_cleanup_queue() such that it no longer iterates over the list without holding

Re: [PATCH 0/2] mpt3sas: Reference counting fixes from in-flight mpt2sas

2015-08-30 Thread Nicholas A. Bellinger
On Fri, 2015-08-28 at 13:25 -0700, James Bottomley wrote: On Thu, 2015-08-27 at 12:15 -0700, Nicholas A. Bellinger wrote: On Thu, 2015-08-27 at 07:40 -0700, James Bottomley wrote: On Thu, 2015-08-27 at 10:37 +0530, Sreekanth Reddy wrote: HI Nicholas Calvin, Thanks

Re: [PATCH 0/2] mpt3sas: Reference counting fixes from in-flight mpt2sas

2015-08-27 Thread Nicholas A. Bellinger
On Thu, 2015-08-27 at 07:40 -0700, James Bottomley wrote: > On Thu, 2015-08-27 at 10:37 +0530, Sreekanth Reddy wrote: > > HI Nicholas & Calvin, > > > > Thanks for the patchset. Sure We will review and we do some unit > > testing on this patch series. Currently my bandwidth is occupied with > >

Re: [PATCH 0/2] mpt3sas: Reference counting fixes from in-flight mpt2sas

2015-08-27 Thread Nicholas A. Bellinger
Hi Sreekanth, On Thu, 2015-08-27 at 10:37 +0530, Sreekanth Reddy wrote: > HI Nicholas & Calvin, > > Thanks for the patchset. Sure We will review and we do some unit > testing on this patch series. Currently my bandwidth is occupied with > some internal activity, so by end of next week I will

Re: [PATCH 0/2] mpt3sas: Reference counting fixes from in-flight mpt2sas

2015-08-27 Thread Nicholas A. Bellinger
On Thu, 2015-08-27 at 07:40 -0700, James Bottomley wrote: On Thu, 2015-08-27 at 10:37 +0530, Sreekanth Reddy wrote: HI Nicholas Calvin, Thanks for the patchset. Sure We will review and we do some unit testing on this patch series. Currently my bandwidth is occupied with some internal

Re: [PATCH 0/2] mpt3sas: Reference counting fixes from in-flight mpt2sas

2015-08-27 Thread Nicholas A. Bellinger
Hi Sreekanth, On Thu, 2015-08-27 at 10:37 +0530, Sreekanth Reddy wrote: HI Nicholas Calvin, Thanks for the patchset. Sure We will review and we do some unit testing on this patch series. Currently my bandwidth is occupied with some internal activity, so by end of next week I will

Re: [PATCH 0/2] mpt3sas: Reference counting fixes from in-flight mpt2sas

2015-08-26 Thread Nicholas A. Bellinger
On Wed, 2015-08-26 at 16:54 -0700, Calvin Owens wrote: > On Wednesday 08/26 at 04:09 +0000, Nicholas A. Bellinger wrote: > > From: Nicholas Bellinger > > > > Hi James & Co, > > > > This series is a mpt3sas forward port of Calvin Owens' in-flight > >

Re: [PATCH 0/2] mpt3sas: Reference counting fixes from in-flight mpt2sas

2015-08-26 Thread Nicholas A. Bellinger
On Wed, 2015-08-26 at 16:54 -0700, Calvin Owens wrote: On Wednesday 08/26 at 04:09 +, Nicholas A. Bellinger wrote: From: Nicholas Bellinger n...@linux-iscsi.org Hi James Co, This series is a mpt3sas forward port of Calvin Owens' in-flight reference counting bugfixes for mpt2sas

[PATCH 1/2] mpt3sas: Refcount sas_device objects and fix unsafe list usage

2015-08-25 Thread Nicholas A. Bellinger
From: Nicholas Bellinger These objects can be referenced concurrently throughout the driver, we need a way to make sure threads can't delete them out from under each other. This patch adds the refcount, and refactors the code to use it. Additionally, we cannot iterate over the sas_device_list

[PATCH 2/2] mpt3sas: Refcount fw_events and fix unsafe list usage

2015-08-25 Thread Nicholas A. Bellinger
From: Nicholas Bellinger The fw_event_work struct is concurrently referenced at shutdown, so add a refcount to protect it, and refactor the code to use it. Additionally, refactor _scsih_fw_event_cleanup_queue() such that it no longer iterates over the list without holding the lock, since

[PATCH 0/2] mpt3sas: Reference counting fixes from in-flight mpt2sas

2015-08-25 Thread Nicholas A. Bellinger
From: Nicholas Bellinger Hi James & Co, This series is a mpt3sas forward port of Calvin Owens' in-flight reference counting bugfixes for mpt2sas LLD code here: [PATCH v4 0/2] Fixes for memory corruption in mpt2sas http://marc.info/?l=linux-scsi=143951695904115=2 The differences bet

Re: [PATCH v4 0/2] Fixes for memory corruption in mpt2sas

2015-08-25 Thread Nicholas A. Bellinger
On Thu, 2015-08-13 at 18:48 -0700, Calvin Owens wrote: > Hello all, > > This patchset attempts to address problems we've been having with > panics due to memory corruption from the mpt2sas driver. > > Thanks, > Calvin > > > [PATCH v4 1/2] mpt2sas: Refcount sas_device objects and fix unsafe

Re: [PATCH v4 2/2] mpt2sas: Refcount fw_events and fix unsafe list usage

2015-08-25 Thread Nicholas A. Bellinger
as/mpt2sas_scsih.c | 112 --- > 1 file changed, 91 insertions(+), 21 deletions(-) > Looks good. Reviewed-by: Nicholas Bellinger -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@

Re: [PATCH v4 1/2] mpt2sas: Refcount sas_device objects and fix unsafe list usage

2015-08-25 Thread Nicholas A. Bellinger
base.h | 22 +- > drivers/scsi/mpt2sas/mpt2sas_scsih.c | 480 > +-- > drivers/scsi/mpt2sas/mpt2sas_transport.c | 12 +- > 3 files changed, 360 insertions(+), 154 deletions(-) > Looks good. Reviewed-by: Nicholas Bellinger -- To unsubsc

[PATCH 1/2] mpt3sas: Refcount sas_device objects and fix unsafe list usage

2015-08-25 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org These objects can be referenced concurrently throughout the driver, we need a way to make sure threads can't delete them out from under each other. This patch adds the refcount, and refactors the code to use it. Additionally, we cannot iterate over

[PATCH 2/2] mpt3sas: Refcount fw_events and fix unsafe list usage

2015-08-25 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org The fw_event_work struct is concurrently referenced at shutdown, so add a refcount to protect it, and refactor the code to use it. Additionally, refactor _scsih_fw_event_cleanup_queue() such that it no longer iterates over the list without holding

[PATCH 0/2] mpt3sas: Reference counting fixes from in-flight mpt2sas

2015-08-25 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org Hi James Co, This series is a mpt3sas forward port of Calvin Owens' in-flight reference counting bugfixes for mpt2sas LLD code here: [PATCH v4 0/2] Fixes for memory corruption in mpt2sas http://marc.info/?l=linux-scsim=143951695904115w=2

Re: [PATCH v4 2/2] mpt2sas: Refcount fw_events and fix unsafe list usage

2015-08-25 Thread Nicholas A. Bellinger
changed, 91 insertions(+), 21 deletions(-) Looks good. Reviewed-by: Nicholas Bellinger n...@linux-iscsi.org -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v4 1/2] mpt2sas: Refcount sas_device objects and fix unsafe list usage

2015-08-25 Thread Nicholas A. Bellinger
+-- drivers/scsi/mpt2sas/mpt2sas_transport.c | 12 +- 3 files changed, 360 insertions(+), 154 deletions(-) Looks good. Reviewed-by: Nicholas Bellinger n...@linux-iscsi.org -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

Re: [PATCH v4 0/2] Fixes for memory corruption in mpt2sas

2015-08-25 Thread Nicholas A. Bellinger
On Thu, 2015-08-13 at 18:48 -0700, Calvin Owens wrote: Hello all, This patchset attempts to address problems we've been having with panics due to memory corruption from the mpt2sas driver. Thanks, Calvin [PATCH v4 1/2] mpt2sas: Refcount sas_device objects and fix unsafe list [PATCH

[GIT PULL] target fixes for v4.2-rc7

2015-08-18 Thread Nicholas A. Bellinger
, that is currently required as a work-around for FC hosts which don't honor EVPD block-limits settings. At this point, it will most likely become for-next material. Thank you, --nab Alexei Potashnik (1): target/iscsi: Fix double free of a TUR followed by a solicited NOPOUT Nicholas Bellinger (1

[GIT PULL] target fixes for v4.2-rc7

2015-08-18 Thread Nicholas A. Bellinger
, that is currently required as a work-around for FC hosts which don't honor EVPD block-limits settings. At this point, it will most likely become for-next material. Thank you, --nab Alexei Potashnik (1): target/iscsi: Fix double free of a TUR followed by a solicited NOPOUT Nicholas Bellinger (1

Re: [PATCH] target: Fix handling of small allocation lengths in REPORT LUNS

2015-08-13 Thread Nicholas A. Bellinger
Hi Spencer & Co, On Wed, 2015-08-12 at 23:05 -0700, Spencer Baugh wrote: > From: Roland Dreier > > REPORT LUNS should not fail just because the allocation length is less > than 16. The relevant section of SPC-4 is: > > 4.2.5.6 Allocation length > > The ALLOCATION LENGTH field specifies

Re: [PATCH] target: Fix handling of small allocation lengths in REPORT LUNS

2015-08-13 Thread Nicholas A. Bellinger
Hi Spencer Co, On Wed, 2015-08-12 at 23:05 -0700, Spencer Baugh wrote: From: Roland Dreier rol...@purestorage.com REPORT LUNS should not fail just because the allocation length is less than 16. The relevant section of SPC-4 is: 4.2.5.6 Allocation length The ALLOCATION LENGTH

Re: [PATCH v3] target: Drop iSCSI use of mutex around max_cmd_sn increment

2015-08-03 Thread Nicholas A. Bellinger
On Thu, 2015-07-23 at 14:53 -0700, Spencer Baugh wrote: > From: Roland Dreier > > In a performance profile, taking a mutex in iscsit_increment_maxcmdsn() > shows up very high. However taking a mutex around "sess->max_cmd_sn += 1" > seems pretty silly: we're not serializing against other

Re: [PATCH v3] target: Drop iSCSI use of mutex around max_cmd_sn increment

2015-08-03 Thread Nicholas A. Bellinger
On Thu, 2015-07-23 at 14:53 -0700, Spencer Baugh wrote: From: Roland Dreier rol...@purestorage.com In a performance profile, taking a mutex in iscsit_increment_maxcmdsn() shows up very high. However taking a mutex around sess-max_cmd_sn += 1 seems pretty silly: we're not serializing against

Re: [PATCH 11/15] drivers: target: Drop unlikely before IS_ERR(_OR_NULL)

2015-08-02 Thread Nicholas A. Bellinger
On Fri, 2015-07-31 at 14:08 +0530, Viresh Kumar wrote: > IS_ERR(_OR_NULL) already contain an 'unlikely' compiler flag and there > is no need to do that again from its callers. Drop it. > > Signed-off-by: Viresh Kumar > --- > drivers/target/tcm_fc/tfc_cmd.c | 2 +- > 1 file changed, 1

Re: [PATCH 11/15] drivers: target: Drop unlikely before IS_ERR(_OR_NULL)

2015-08-02 Thread Nicholas A. Bellinger
On Fri, 2015-07-31 at 14:08 +0530, Viresh Kumar wrote: IS_ERR(_OR_NULL) already contain an 'unlikely' compiler flag and there is no need to do that again from its callers. Drop it. Signed-off-by: Viresh Kumar viresh.ku...@linaro.org --- drivers/target/tcm_fc/tfc_cmd.c | 2 +- 1 file

Re: [PATCH] target: add support for START_STOP_UNIT SCSI opcode

2015-07-31 Thread Nicholas A. Bellinger
On Thu, 2015-07-23 at 15:27 -0700, Spencer Baugh wrote: > From: Brian Bunker > > AIX servers using VIOS servers that virtualize FC cards will have a > problem booting without support for START_STOP_UNIT. > > v2: Cite sb3r36 exactly, clean up if conditions > > Signed-off-by: Brian Bunker >

Re: [PATCH] target: improve unsupported opcode message

2015-07-31 Thread Nicholas A. Bellinger
On Wed, 2015-07-22 at 15:01 -0700, Spencer Baugh wrote: > From: Joern Engel > > Make the warning about unsupported SCSI opcode more useful: > > - Add in the initiator name so we know who's sending it. > - Print the warning even for opcodes that spc_parse_cdb() knows about >but that we

Re: [PATCH] target: allow underflow/overflow for PR OUT etc. commands

2015-07-31 Thread Nicholas A. Bellinger
On Wed, 2015-07-22 at 15:08 -0700, Spencer Baugh wrote: > From: Roland Dreier > > It's not necessarily a fatal error if a command with a data-out phase > has a data length that differs from the transport data length (e.g. > PERSISTENT RESERVE OUT might have a parameter list length in the CDB >

Re: [PATCH] target/iscsi: fix digest computation for chained SGs

2015-07-31 Thread Nicholas A. Bellinger
On Tue, 2015-07-21 at 18:38 -0700, Roland Dreier wrote: > On Tue, Jul 21, 2015 at 1:57 AM, Sagi Grimberg > wrote: > > How were you able to get a chained SG list in the target code? > > Local hack. So this bug can't be hit in current mainline code, but > patch improves the code and removes a

Re: [PATCH] target/iscsi: Fix double free of a TUR followed by a solicited NOPOUT

2015-07-31 Thread Nicholas A. Bellinger
Hi Spencer & Alexei, On Tue, 2015-07-21 at 15:07 -0700, Spencer Baugh wrote: > From: Alexei Potashnik > > Make sure all non-READ SCSI commands get targ_xfer_tag initialized > to 0x, not just WRITEs. > > Double-free of a TUR cmd object occurs under the following scenario: > > 1. TUR

Re: [PATCH] target/iscsi: Fix double free of a TUR followed by a solicited NOPOUT

2015-07-31 Thread Nicholas A. Bellinger
Hi Spencer Alexei, On Tue, 2015-07-21 at 15:07 -0700, Spencer Baugh wrote: From: Alexei Potashnik ale...@purestorage.com Make sure all non-READ SCSI commands get targ_xfer_tag initialized to 0x, not just WRITEs. Double-free of a TUR cmd object occurs under the following scenario:

Re: [PATCH] target: allow underflow/overflow for PR OUT etc. commands

2015-07-31 Thread Nicholas A. Bellinger
On Wed, 2015-07-22 at 15:08 -0700, Spencer Baugh wrote: From: Roland Dreier rol...@purestorage.com It's not necessarily a fatal error if a command with a data-out phase has a data length that differs from the transport data length (e.g. PERSISTENT RESERVE OUT might have a parameter list

Re: [PATCH] target: improve unsupported opcode message

2015-07-31 Thread Nicholas A. Bellinger
On Wed, 2015-07-22 at 15:01 -0700, Spencer Baugh wrote: From: Joern Engel jo...@purestorage.com Make the warning about unsupported SCSI opcode more useful: - Add in the initiator name so we know who's sending it. - Print the warning even for opcodes that spc_parse_cdb() knows about

Re: [PATCH] target: add support for START_STOP_UNIT SCSI opcode

2015-07-31 Thread Nicholas A. Bellinger
On Thu, 2015-07-23 at 15:27 -0700, Spencer Baugh wrote: From: Brian Bunker br...@purestorage.com AIX servers using VIOS servers that virtualize FC cards will have a problem booting without support for START_STOP_UNIT. v2: Cite sb3r36 exactly, clean up if conditions Signed-off-by: Brian

Re: [PATCH] target/iscsi: fix digest computation for chained SGs

2015-07-31 Thread Nicholas A. Bellinger
On Tue, 2015-07-21 at 18:38 -0700, Roland Dreier wrote: On Tue, Jul 21, 2015 at 1:57 AM, Sagi Grimberg sa...@dev.mellanox.co.il wrote: How were you able to get a chained SG list in the target code? Local hack. So this bug can't be hit in current mainline code, but patch improves the code

[GIT PULL] target fixes for v4.2-rc5

2015-07-28 Thread Nicholas A. Bellinger
manshu Madhani (2): qla2xxx: Enable target mode for ISP27XX qla2xxx: Remove msleep in qlt_send_term_exchange Kanoj Sarcar (1): qla2xxx: fix command initialization in target mode. Nicholas Bellinger (5): target: Add extra TYPE_DISK + protection checks for INQUIRY SPT iscsi-target: Fix use-afte

[GIT PULL] target fixes for v4.2-rc5

2015-07-28 Thread Nicholas A. Bellinger
(2): qla2xxx: Enable target mode for ISP27XX qla2xxx: Remove msleep in qlt_send_term_exchange Kanoj Sarcar (1): qla2xxx: fix command initialization in target mode. Nicholas Bellinger (5): target: Add extra TYPE_DISK + protection checks for INQUIRY SPT iscsi-target: Fix use-after-free

Re: [PATCH] target: fix crash in cmd tracing when cmd didn't match a LUN

2015-07-25 Thread Nicholas A. Bellinger
On Sat, 2015-07-25 at 08:48 +0200, Christoph Hellwig wrote: > On Fri, Jul 24, 2015 at 01:32:14PM -0700, Nicholas A. Bellinger wrote: > > We've already been through this discussion a couple of years back when > > target_submit_cmd() first came into existence. > > > > T

Re: [PATCH] target: fix crash in cmd tracing when cmd didn't match a LUN

2015-07-25 Thread Nicholas A. Bellinger
On Sat, 2015-07-25 at 08:48 +0200, Christoph Hellwig wrote: On Fri, Jul 24, 2015 at 01:32:14PM -0700, Nicholas A. Bellinger wrote: We've already been through this discussion a couple of years back when target_submit_cmd() first came into existence. The reason iscsi/iser-target continues

Re: [PATCH] target: fix crash in cmd tracing when cmd didn't match a LUN

2015-07-24 Thread Nicholas A. Bellinger
On Fri, 2015-07-24 at 12:52 +0200, Christoph Hellwig wrote: > On Thu, Jul 23, 2015 at 03:19:32PM -0700, Spencer Baugh wrote: > > From: Alexei Potashnik > > > > If command didn't match a LUN and we're sending check condition, the > > target_cmd_complete ftrace point will crash because it assumes

Re: [PATCH] target: fix crash in cmd tracing when cmd didn't match a LUN

2015-07-24 Thread Nicholas A. Bellinger
On Fri, 2015-07-24 at 12:52 +0200, Christoph Hellwig wrote: On Thu, Jul 23, 2015 at 03:19:32PM -0700, Spencer Baugh wrote: From: Alexei Potashnik ale...@purestorage.com If command didn't match a LUN and we're sending check condition, the target_cmd_complete ftrace point will crash

Re: [PATCH] tcm_qla2xxx: pass timeout as HZ independent value

2015-07-06 Thread Nicholas A. Bellinger
Hi Nicholas, On Mon, 2015-07-06 at 18:04 +0200, Nicholas Mc Guire wrote: > API compliance scanning with coccinelle flagged: > ./drivers/scsi/qla2xxx/tcm_qla2xxx.c:407:2-29: > WARNING: timeout is HZ dependent > > This was introduced in 'commit 75f8c1f693ee ("[SCSI] tcm_qla2xxx: Add >= >

Re: [PATCH] tcm_qla2xxx: pass timeout as HZ independent value

2015-07-06 Thread Nicholas A. Bellinger
Hi Nicholas, On Mon, 2015-07-06 at 18:04 +0200, Nicholas Mc Guire wrote: API compliance scanning with coccinelle flagged: ./drivers/scsi/qla2xxx/tcm_qla2xxx.c:407:2-29: WARNING: timeout is HZ dependent This was introduced in 'commit 75f8c1f693ee ([SCSI] tcm_qla2xxx: Add = 24xx

[GIT PULL] target updates for v4.2-rc1

2015-07-05 Thread Nicholas A. Bellinger
CDB support target/transport: Always initialize bidi fields in se_cmd target/user: Refactor data area allocation code target/user: Add support for bidirectional commands Nicholas Bellinger (16): target: Convert se_node_acl->device_list[] to RCU hlist target/pr: Use atomic bitop for

[GIT PULL] target updates for v4.2-rc1

2015-07-05 Thread Nicholas A. Bellinger
/transport: Always initialize bidi fields in se_cmd target/user: Refactor data area allocation code target/user: Add support for bidirectional commands Nicholas Bellinger (16): target: Convert se_node_acl-device_list[] to RCU hlist target/pr: Use atomic bitop for se_dev_entry-deve_flags

[GIT PULL] target fixes for v4.1

2015-06-20 Thread Nicholas A. Bellinger
Hi Linus, Apologies for the late PULL request. Here are the outstanding target-pending fixes for v4.1 code. Please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git master The series contains three patches from Sagi + Co that address a few iser-target issues

[GIT PULL] target fixes for v4.1

2015-06-20 Thread Nicholas A. Bellinger
Hi Linus, Apologies for the late PULL request. Here are the outstanding target-pending fixes for v4.1 code. Please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git master The series contains three patches from Sagi + Co that address a few iser-target issues

Re: [RFC 0/2] target: Add TFO->complete_irq queue_work bypass

2015-06-10 Thread Nicholas A. Bellinger
On Tue, 2015-06-09 at 09:19 +0200, Christoph Hellwig wrote: > On Thu, Jun 04, 2015 at 12:06:09AM -0700, Nicholas A. Bellinger wrote: > > So I've been using tcm_loop + RAMDISK backends for prototyping, but this > > patch is intended for vhost-scsi so it can avoid the unnecessary

Re: [RFC 0/2] target: Add TFO-complete_irq queue_work bypass

2015-06-10 Thread Nicholas A. Bellinger
On Tue, 2015-06-09 at 09:19 +0200, Christoph Hellwig wrote: On Thu, Jun 04, 2015 at 12:06:09AM -0700, Nicholas A. Bellinger wrote: So I've been using tcm_loop + RAMDISK backends for prototyping, but this patch is intended for vhost-scsi so it can avoid the unnecessary queue_work() context

Re: [RFC 0/2] target: Add TFO->complete_irq queue_work bypass

2015-06-04 Thread Nicholas A. Bellinger
On Wed, 2015-06-03 at 14:57 +0200, Christoph Hellwig wrote: > This makes lockdep very unhappy, rightly so. If you execute > one end_io function inside another you basіcally nest every possible > lock taken in the I/O completion path. Also adding more work > to the hardirq path generally isn't a

Re: [RFC 0/2] target: Add TFO-complete_irq queue_work bypass

2015-06-04 Thread Nicholas A. Bellinger
On Wed, 2015-06-03 at 14:57 +0200, Christoph Hellwig wrote: This makes lockdep very unhappy, rightly so. If you execute one end_io function inside another you basіcally nest every possible lock taken in the I/O completion path. Also adding more work to the hardirq path generally isn't a

Re: linux-next: build failure after merge of the target-updates tree

2015-06-03 Thread Nicholas A. Bellinger
On Wed, 2015-06-03 at 15:33 -0700, James Bottomley wrote: > On Wed, 2015-06-03 at 15:12 -0700, Nicholas A. Bellinger wrote: > > On Wed, 2015-06-03 at 13:00 -0700, James Bottomley wrote: > > > OK, this gives us a cross tree dependency on the SCSI header split > > >

Re: linux-next: build failure after merge of the target-updates tree

2015-06-03 Thread Nicholas A. Bellinger
On Wed, 2015-06-03 at 13:00 -0700, James Bottomley wrote: > On Wed, 2015-06-03 at 18:16 +1000, Stephen Rothwell wrote: > > Hi Nicholas, > > > > After merging the target-updates tree, today's linux-next build (x86_64 > > allmodconfig) failed like this: > > > >

Re: linux-next: build failure after merge of the target-updates tree

2015-06-03 Thread Nicholas A. Bellinger
On Wed, 2015-06-03 at 13:00 -0700, James Bottomley wrote: On Wed, 2015-06-03 at 18:16 +1000, Stephen Rothwell wrote: Hi Nicholas, After merging the target-updates tree, today's linux-next build (x86_64 allmodconfig) failed like this: drivers/target/target_core_fabric_lib.c: In

Re: linux-next: build failure after merge of the target-updates tree

2015-06-03 Thread Nicholas A. Bellinger
On Wed, 2015-06-03 at 15:33 -0700, James Bottomley wrote: On Wed, 2015-06-03 at 15:12 -0700, Nicholas A. Bellinger wrote: On Wed, 2015-06-03 at 13:00 -0700, James Bottomley wrote: SNIP OK, this gives us a cross tree dependency on the SCSI header split patches. Nic, if you base your

Re: linux-next: manual merge of the target-updates tree with the tree

2015-06-01 Thread Nicholas A. Bellinger
On Mon, 2015-06-01 at 21:22 +1000, Stephen Rothwell wrote: > Hi Nicholas, > > Today's linux-next merge of the target-updates tree got so many > conflicts against Linus' tree that I just gave up and dropped it > completely. Please fix up this mess. > Apologies for the conflicts vs. mainline in

Re: linux-next: manual merge of the target-updates tree with Linus' tree

2015-06-01 Thread Nicholas A. Bellinger
Hi Stephen, On Mon, 2015-06-01 at 20:48 +1000, Stephen Rothwell wrote: > Hi Nicholas, > > Today's linux-next merge of the target-updates tree got a conflict in > drivers/target/target_core_configfs.c between commit d588cf8f618d > ("target: Fix se_tpg_tfo->tf_subsys regression + remove

Re: [PATCH-v3 00/10] target: se_node_acl + se_lun RCU conversions

2015-06-01 Thread Nicholas A. Bellinger
On Tue, 2015-05-26 at 11:41 +0200, Hannes Reinecke wrote: > On 05/26/2015 08:25 AM, Nicholas A. Bellinger wrote: > > From: Nicholas Bellinger > > > > Hi all, > > > > Here is -v3 series for converting LIO target se_node_acl + se_lun > > mapping table

[PATCH-v3 3/4] target: Drop se_lun->lun_active for existing percpu lun_ref

2015-06-01 Thread Nicholas A. Bellinger
From: Nicholas Bellinger With se_port_t and t10_alua_tg_pt_gp_member being absored into se_lun, there is no need for an extra atomic_t based reference count for PR ALL_TG_PT=1 and ALUA access state transition. Go ahead and use the existing percpu se_lun->lun_ref instead, and convert the

[PATCH-v3 2/4] target: Drop lun_sep_lock for se_lun->lun_se_dev RCU usage

2015-06-01 Thread Nicholas A. Bellinger
From: Nicholas Bellinger With se_port and t10_alua_tg_pt_gp_member being absored into se_lun, there is no need for an extra lock to protect se_lun->lun_se_dev assignment. This patch also converts backend drivers to use call_rcu() release to allow any se_device readers to complete. The call_

[PATCH-v3 4/4] target: Drop unnecessary core_tpg_register TFO parameter

2015-06-01 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch drops unnecessary target_core_fabric_ops parameter usage for core_tpg_register() during fabric driver TFO->fabric_make_tpg() se_portal_group creation callback execution. Instead, use the existing se_wwn->wwn_tf->tf_ops pointer to ensure fabr

[PATCH-v3 1/4] target: Subsume se_port + t10_alua_tg_pt_gp_member into se_lun

2015-06-01 Thread Nicholas A. Bellinger
off-by: Christoph Hellwig Reviewed-by: Hannes Reinecke Signed-off-by: Nicholas Bellinger --- drivers/target/target_core_alua.c| 394 ++- drivers/target/target_core_alua.h| 14 +- drivers/target/target_core_configfs.c| 11 +- drivers/tar

[PATCH-v3 0/4] target: Eliminate se_port + t10_alua_tg_pt_gp_member

2015-06-01 Thread Nicholas A. Bellinger
From: Nicholas Bellinger Hi all, Here is v3 series with HCH's recent changes to go ahead and drop all se_port + t10_alua_tg_pt_gp_member usage within target-core in favor of direct se_lun pointer dereference. This includes the original patch + minor fixes, along with two other improvements

[PATCH-v4 02/10] target/pr: Use atomic bitop for se_dev_entry->deve_flags reservation check

2015-06-01 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch converts the core_scsi3_pr_seq_non_holder() check for non reservation holding registrations to use an atomic bitop in ->deve_flags to determine if a registration is currently active. It also includes associated a set_bit() in __core_scsi3_add_registrat

[PATCH-v4 07/10] target: Convert core_tpg_deregister to use list splice

2015-06-01 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch converts core_tpg_deregister() to perform a list splice for any remaining dynamically generated se_node_acls attached to se_tpg, before calling kfree(nacl) to free memory. Reviewed-by: Hannes Reinecke Cc: Christoph Hellwig Cc: Sagi Grimberg Signed-off

[PATCH-v4 09/10] target: Only reset specific dynamic entries during lun_group creation

2015-06-01 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch changes core_tpg_add_node_to_devs() to avoid unnecessarly resetting every se_dev_entry in se_node_acl->tpg_lun_hlist when the operation is driven by an explicit configfs se_lun->lun_group creation via core_dev_add_lun() to only update a single

[PATCH-v4 03/10] target/pr: Change alloc_registration to avoid pr_reg_tg_pt_lun

2015-06-01 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch changes __core_scsi3_do_alloc_registration() code to drop pr_reg->pr_reg_tg_pt_lun pointer usage in favor of a new pr_reg RPTI + existing pr_reg->pr_aptpl_target_lun used by APTPL metadata logic. It also includes changes to REGISTER, REGISTER_AN

[PATCH-v4 00/10] target: se_node_acl + se_lun RCU conversions

2015-06-01 Thread Nicholas A. Bellinger
From: Nicholas Bellinger Hi all, Here is -v4 series for converting LIO target se_node_acl + se_lun mapping tables from fixed size arrays to dynamic RCU (read-copy-update) hlist_heads. This turns fast-path I/O into a lock-less RCU reader using existing percpu based se_lun->lun_ref lo

[PATCH-v4 05/10] target: Convert se_portal_group->tpg_lun_list[] to RCU hlist

2015-06-01 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch converts the fixed size se_portal_group->tpg_lun_list[] to use modern RCU with hlist_head in order to support an arbitary number of se_lun ports per target endpoint. It includes dropping core_tpg_alloc_lun() from core_dev_add_lun(), and calling it direc

<    1   2   3   4   5   6   7   8   9   10   >