From: Nicholas Bellinger n...@linux-iscsi.org
This patch changes __core_scsi3_do_alloc_registration() code to
drop pr_reg-pr_reg_tg_pt_lun pointer usage in favor of a new
pr_reg RPTI + existing target_lun.
It also includes changes to REGISTER, REGISTER_AND_MOVE and APTPL
feature bit codepaths
From: Nicholas Bellinger n...@linux-iscsi.org
This patch converts the fixed size se_portal_group-tpg_lun_list[]
to use modern RCU with hlist_head in order to support an arbitary
number of se_lun ports per target endpoint.
It includes dropping core_tpg_alloc_lun() from core_dev_add_lun
On Tue, 2015-04-28 at 19:15 -0700, James Bottomley wrote:
> On Wed, 2015-04-29 at 09:34 +0900, Akinobu Mita wrote:
> > 2015-04-29 7:16 GMT+09:00 James Bottomley
> > :
> > > On Tue, 2015-04-28 at 14:27 -0700, Andrew Morton wrote:
> > >> On Sat, 25 Apr 2015 23:56:16 +0900 Akinobu Mita
> > >>
On Tue, 2015-04-28 at 19:15 -0700, James Bottomley wrote:
On Wed, 2015-04-29 at 09:34 +0900, Akinobu Mita wrote:
2015-04-29 7:16 GMT+09:00 James Bottomley
james.bottom...@hansenpartnership.com:
On Tue, 2015-04-28 at 14:27 -0700, Andrew Morton wrote:
On Sat, 25 Apr 2015 23:56:16 +0900
the target template registration API
target: fix tcm_mod_builder.py
Ilias Tsitsimpis (1):
target: Better handling of AllRegistrants reservations
Julia Lawall (1):
iscsi-target: don't export static symbol
Ming Lin (1):
tcm_loop: fixup tpgt string to integer conversion
Nicholas Bellinger
: simplify the target template registration API
target: fix tcm_mod_builder.py
Ilias Tsitsimpis (1):
target: Better handling of AllRegistrants reservations
Julia Lawall (1):
iscsi-target: don't export static symbol
Ming Lin (1):
tcm_loop: fixup tpgt string to integer conversion
Nicholas
Hi Linus,
Here are the outstanding target fixes for v4.0 code.
Please go ahead and pull from:
git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git master
Just a few small fixes.
Two from Andy, the first addresses a v4.0 target specific regression to
a user visible configfs
Hi Linus,
Here are the outstanding target fixes for v4.0 code.
Please go ahead and pull from:
git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git master
Just a few small fixes.
Two from Andy, the first addresses a v4.0 target specific regression to
a user visible configfs
tcm_fc: missing curly braces in ft_invl_hw_context()
Nicholas Bellinger (5):
target: Disallow changing of WRITE cache/FUA attrs after export
Revert "iscsi-target: Avoid IN_LOGOUT failure case for iser-target"
iscsi-target: Avoid early conn_logout_comp for iser connections
target/pscsi:
On Wed, 2015-03-11 at 17:56 +0100, Julia Lawall wrote:
> From: Julia Lawall
>
> The semantic patch that fixes this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> //
> @r@
> type T;
> identifier f;
> @@
>
> static T f (...) { ... }
>
> @@
> identifier r.f;
> declarer name
: missing curly braces in ft_invl_hw_context()
Nicholas Bellinger (5):
target: Disallow changing of WRITE cache/FUA attrs after export
Revert iscsi-target: Avoid IN_LOGOUT failure case for iser-target
iscsi-target: Avoid early conn_logout_comp for iser connections
target/pscsi: Fix NULL pointer
On Wed, 2015-03-11 at 17:56 +0100, Julia Lawall wrote:
From: Julia Lawall julia.law...@lip6.fr
The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)
// smpl
@r@
type T;
identifier f;
@@
static T f (...) { ... }
@@
identifier r.f;
declarer name
her various minor SPC/SBC compliance fixes based upon Ronnie Sahlberg
test suite (nab)
Thank you,
--nab
Andy Shevchenko (2):
tcm_qla2xxx: print port name via %*phC
iscsi-target: use '%*ph' specifier to dump hex buffer
Dan Carpenter (1):
vhost/scsi: potential memory corruption
Nicho
various minor SPC/SBC compliance fixes based upon Ronnie Sahlberg
test suite (nab)
Thank you,
--nab
Andy Shevchenko (2):
tcm_qla2xxx: print port name via %*phC
iscsi-target: use '%*ph' specifier to dump hex buffer
Dan Carpenter (1):
vhost/scsi: potential memory corruption
Nicholas
Hi Gavin,
On Tue, 2015-02-03 at 08:28 +0800, Gavin Guo wrote:
> Hi Nicholas,
>
> On Sun, Feb 1, 2015 at 11:47 AM, Gavin Guo wrote:
> > Hi Nicholas,
> >
> > On Sat, Jan 31, 2015 at 6:53 AM, Nicholas A. Bellinger
> > wrote:
> >> On Fri, 2015-01-23
Hi Gavin,
On Tue, 2015-02-03 at 08:28 +0800, Gavin Guo wrote:
Hi Nicholas,
On Sun, Feb 1, 2015 at 11:47 AM, Gavin Guo gavin@canonical.com wrote:
Hi Nicholas,
On Sat, Jan 31, 2015 at 6:53 AM, Nicholas A. Bellinger
n...@linux-iscsi.org wrote:
On Fri, 2015-01-23 at 09:30 +0800
On Fri, 2015-02-06 at 01:09 +0100, Rasmus Villemoes wrote:
> The macro isert_dbg already ensures that __func__ is part of the
> output, so there's no reason to duplicate the function name in the
> format string itself.
>
> Signed-off-by: Rasmus Villemoes
> ---
>
On Fri, 2015-02-06 at 01:09 +0100, Rasmus Villemoes wrote:
The macro isert_dbg already ensures that __func__ is part of the
output, so there's no reason to duplicate the function name in the
format string itself.
Signed-off-by: Rasmus Villemoes li...@rasmusvillemoes.dk
---
On Mon, 2015-02-02 at 14:25 +0800, kbuild test robot wrote:
> tree: git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git
> for-next
> head: 2936f1d4f3e8247bd519feba7892371d5e4c6603
> commit: 105acf608f25d5e0d9fef669299a5438b7b114ee [16/21] vhost/scsi: Add
> ANY_LAYOUT
On Mon, 2015-02-02 at 14:25 +0800, kbuild test robot wrote:
tree: git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git
for-next
head: 2936f1d4f3e8247bd519feba7892371d5e4c6603
commit: 105acf608f25d5e0d9fef669299a5438b7b114ee [16/21] vhost/scsi: Add
ANY_LAYOUT
On Fri, 2015-01-23 at 09:30 +0800, Gavin Guo wrote:
> Hi Nicholas,
>
> On Fri, Jan 23, 2015 at 1:35 AM, Nicholas A. Bellinger
> wrote:
> > On Thu, 2015-01-22 at 23:56 +0800, Gavin Guo wrote:
> >> Hi Nicolas,
> >>
> >> On Thu, Jan 22, 2015 at 5:50 PM,
On Fri, 2015-01-23 at 09:30 +0800, Gavin Guo wrote:
Hi Nicholas,
On Fri, Jan 23, 2015 at 1:35 AM, Nicholas A. Bellinger
n...@linux-iscsi.org wrote:
On Thu, 2015-01-22 at 23:56 +0800, Gavin Guo wrote:
Hi Nicolas,
On Thu, Jan 22, 2015 at 5:50 PM, Nicholas A. Bellinger
n...@linux
On Thu, 2015-01-22 at 23:56 +0800, Gavin Guo wrote:
> Hi Nicolas,
>
> On Thu, Jan 22, 2015 at 5:50 PM, Nicholas A. Bellinger
> wrote:
> > Hi Gavin,
> >
> > On Thu, 2015-01-22 at 06:38 +0800, Gavin Guo wrote:
> >> Hi all,
> >>
> >
On Thu, 2015-01-22 at 23:56 +0800, Gavin Guo wrote:
Hi Nicolas,
On Thu, Jan 22, 2015 at 5:50 PM, Nicholas A. Bellinger
n...@linux-iscsi.org wrote:
Hi Gavin,
On Thu, 2015-01-22 at 06:38 +0800, Gavin Guo wrote:
Hi all,
The general protection fault screenshot is attached.
Summary
Hi Nicholas,
On Fri, 2015-01-16 at 12:20 +0100, Nicholas Mc Guire wrote:
> Signed-off-by: Nicholas Mc Guire
> ---
>
> Patch is against 3.19.0-rc3 -next-20150109
>
> Patch was compiletested only with x86_64_defconfig +
> CONFIG_TARGET_CORE=m, CONFIG_INFINIBAND=m, CONFIG_INFINIBAND_SRPT=m
>
>
Hi Nicholas,
On Fri, 2015-01-16 at 12:20 +0100, Nicholas Mc Guire wrote:
Signed-off-by: Nicholas Mc Guire der.h...@hofr.at
---
Patch is against 3.19.0-rc3 -next-20150109
Patch was compiletested only with x86_64_defconfig +
CONFIG_TARGET_CORE=m, CONFIG_INFINIBAND=m,
ors attribute.
Thank you,
--nab
Andy Grover (1):
iscsi-target: Fix typos in enum cmd_flags_table
Lee Duncan (1):
target: Allow Write Exclusive non-reservation holders to READ
Nicholas Bellinger (4):
vhost-scsi: Add missing virtio-scsi -> TCM attribute conversion
Documentation/target:
attribute.
Thank you,
--nab
Andy Grover (1):
iscsi-target: Fix typos in enum cmd_flags_table
Lee Duncan (1):
target: Allow Write Exclusive non-reservation holders to READ
Nicholas Bellinger (4):
vhost-scsi: Add missing virtio-scsi - TCM attribute conversion
Documentation/target: Update
On Wed, 2015-01-07 at 22:26 +0200, Sagi Grimberg wrote:
> >> On Wed, 2015-01-07 at 10:57 +0200, Sagi Grimberg wrote:
> >>> On 1/7/2015 12:44 AM, Nicholas A. Bellinger wrote:
> >> Hey Nic,
> >>
> >> Hope all is well.
> >>
> >> S
On Wed, 2015-01-07 at 10:57 +0200, Sagi Grimberg wrote:
> On 1/7/2015 12:44 AM, Nicholas A. Bellinger wrote:
> > On Wed, 2015-01-07 at 03:35 +0800, kbuild test robot wrote:
> >> tree:
> >> git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.
On Wed, 2015-01-07 at 22:26 +0200, Sagi Grimberg wrote:
On Wed, 2015-01-07 at 10:57 +0200, Sagi Grimberg wrote:
On 1/7/2015 12:44 AM, Nicholas A. Bellinger wrote:
SNIP
Hey Nic,
Hope all is well.
So this skeleton is interesting to me. As this is a fabric module I
assume
On Wed, 2015-01-07 at 10:57 +0200, Sagi Grimberg wrote:
On 1/7/2015 12:44 AM, Nicholas A. Bellinger wrote:
On Wed, 2015-01-07 at 03:35 +0800, kbuild test robot wrote:
tree:
git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git
nvme_of
head
On Wed, 2015-01-07 at 03:35 +0800, kbuild test robot wrote:
> tree: git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git
> nvme_of
> head: 40d8c11927282d59855d645b35798edd97828da5
> commit: 40d8c11927282d59855d645b35798edd97828da5 [3/3] nvme_of: Initial
> skeleton commit
>
On Wed, 2015-01-07 at 03:35 +0800, kbuild test robot wrote:
tree: git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git
nvme_of
head: 40d8c11927282d59855d645b35798edd97828da5
commit: 40d8c11927282d59855d645b35798edd97828da5 [3/3] nvme_of: Initial
skeleton commit
On Mon, 2014-12-22 at 21:56 +0100, Jiri Kosina wrote:
> On Mon, 22 Dec 2014, Andrew Morton wrote:
>
> > On Sat, 20 Dec 2014 23:11:39 -0800 "Nicholas A. Bellinger"
> > wrote:
> >
> > > Just hit the following build failure with CONFIG_AUDIT=y:
>
On Sun, 2014-12-21 at 04:11 -0800, Guenter Roeck wrote:
> On Sat, Dec 20, 2014 at 11:11:39PM -0800, Nicholas A. Bellinger wrote:
> > Hi Linus,
> >
> > On Sat, 2014-12-20 at 17:43 -0800, Linus Torvalds wrote:
> > > So it's been a day less than two weeks,
On Sun, 2014-12-21 at 04:11 -0800, Guenter Roeck wrote:
On Sat, Dec 20, 2014 at 11:11:39PM -0800, Nicholas A. Bellinger wrote:
Hi Linus,
On Sat, 2014-12-20 at 17:43 -0800, Linus Torvalds wrote:
So it's been a day less than two weeks, and the merge window is closed.
...
Just
On Mon, 2014-12-22 at 21:56 +0100, Jiri Kosina wrote:
On Mon, 22 Dec 2014, Andrew Morton wrote:
On Sat, 20 Dec 2014 23:11:39 -0800 Nicholas A. Bellinger
n...@linux-iscsi.org wrote:
Just hit the following build failure with CONFIG_AUDIT=y:
arch/x86/ia32/audit.c: In function
Hi Linus,
On Sat, 2014-12-20 at 17:43 -0800, Linus Torvalds wrote:
> So it's been a day less than two weeks, and the merge window is closed.
>
> Considering how much came in fairly late, I find it hard to care about
> anybody who had decided to cut it even closer than some people already
> did.
Hi Linus,
On Sat, 2014-12-20 at 17:43 -0800, Linus Torvalds wrote:
So it's been a day less than two weeks, and the merge window is closed.
Considering how much came in fairly late, I find it hard to care about
anybody who had decided to cut it even closer than some people already
did.
ser.h: fix headers_install.sh badness
Lino Sanfilippo (1):
iscsi-target: fix error path in iscsi_target_init_module()
Markus Elfring (1):
target: Deletion of unnecessary checks before the function call
"module_put"
Nicholas Bellinger (22):
target: Move dev_cit to struct se_su
headers_install.sh badness
Lino Sanfilippo (1):
iscsi-target: fix error path in iscsi_target_init_module()
Markus Elfring (1):
target: Deletion of unnecessary checks before the function call
module_put
Nicholas Bellinger (22):
target: Move dev_cit to struct se_subsystem_api
target: Move
Hi Kyle,
On Thu, 2014-12-18 at 12:57 -0500, Kyle McMartin wrote:
> scripts/headers_install.sh will transform __packed to
> __attribute__((packed)), so the #ifndef is not necessary.
> (and, in fact, it's problematic, because we'll end up with the header
> containing:
> #ifndef
Hi Kyle,
On Thu, 2014-12-18 at 12:57 -0500, Kyle McMartin wrote:
scripts/headers_install.sh will transform __packed to
__attribute__((packed)), so the #ifndef is not necessary.
(and, in fact, it's problematic, because we'll end up with the header
containing:
#ifndef __attribute__((packed))
On Tue, 2014-12-16 at 06:04 +, Al Viro wrote:
> On Tue, Dec 16, 2014 at 04:48:58AM +0000, Nicholas A. Bellinger wrote:
>
> > In practice this has not been an issue because iscsit_do_tx_data()
> > is only used for transferring 48 byte headers + 4 byte digests,
> >
On Tue, 2014-12-16 at 06:04 +, Al Viro wrote:
On Tue, Dec 16, 2014 at 04:48:58AM +, Nicholas A. Bellinger wrote:
In practice this has not been an issue because iscsit_do_tx_data()
is only used for transferring 48 byte headers + 4 byte digests,
along with seldom used control
From: Nicholas Bellinger
This patch changes iscsit_do_[tx,rx]_data() to fail on short
write/reads when kernel_[send,recv]msg() returns a value different
than the requested transfer length, returning -EPIPE and thus
causing a connection reset to occur.
This avoids a potential bug in the original
From: Nicholas Bellinger n...@linux-iscsi.org
This patch changes iscsit_do_[tx,rx]_data() to fail on short
write/reads when kernel_[send,recv]msg() returns a value different
than the requested transfer length, returning -EPIPE and thus
causing a connection reset to occur.
This avoids a potential
Hi MST,
On Wed, 2014-12-10 at 21:14 +0200, Michael S. Tsirkin wrote:
> OK, so far I got positive test reports from Cornelia, so tomorrow, I'm
> going to send a pull request with the following:
> - this huge patchset
> - virtio 1.0 enhancements
> - virtio_ccw: minor enhancements
>
> Everything
Hi MST,
On Wed, 2014-12-10 at 21:14 +0200, Michael S. Tsirkin wrote:
OK, so far I got positive test reports from Cornelia, so tomorrow, I'm
going to send a pull request with the following:
- this huge patchset
- virtio 1.0 enhancements
- virtio_ccw: minor enhancements
Everything can be
> - shost->sg_tablesize * sizeof(struct scatterlist);
> + min_t(unsigned int,
> + shost->sg_tablesize, SCSI_MAX_SG_SEGMENTS) *
> + sizeof(struct scatterlist);
> memset(cmd->prot_sdb, 0, sizeof(str
,
+ shost-sg_tablesize, SCSI_MAX_SG_SEGMENTS) *
+ sizeof(struct scatterlist);
memset(cmd-prot_sdb, 0, sizeof(struct scsi_data_buffer));
cmd-prot_sdb-table.sgl =
Nice catch.
Reviewed-by: Nicholas Bellinger n...@linux-iscsi.org
Adding
On Sun, 2014-11-30 at 12:00 +0100, Lino Sanfilippo wrote:
> In iscsi_target_init_module() unwind transport protocol registration in case
> that iscsit_load_discovery_tpg() failed.
>
> Signed-off-by: Lino Sanfilippo
> ---
> drivers/target/iscsi/iscsi_target.c | 1 +
> 1 file changed, 1
On Sun, 2014-11-30 at 19:14 +0100, Julia Lawall wrote:
> From: Julia Lawall
>
> Delete a local array that is only used to be initialized by memset.
>
> A semantic patch that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
>
> //
> @@
> identifier x;
> type T;
> @@
>
> {
> ...
On Sun, 2014-11-30 at 19:14 +0100, Julia Lawall wrote:
From: Julia Lawall julia.law...@lip6.fr
Delete a local array that is only used to be initialized by memset.
A semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)
// smpl
@@
identifier x;
type T;
@@
On Sun, 2014-11-30 at 12:00 +0100, Lino Sanfilippo wrote:
In iscsi_target_init_module() unwind transport protocol registration in case
that iscsit_load_discovery_tpg() failed.
Signed-off-by: Lino Sanfilippo linosanfili...@gmx.de
---
drivers/target/iscsi/iscsi_target.c | 1 +
1 file
On Fri, 2014-11-21 at 10:30 +0100, SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Fri, 21 Nov 2014 10:25:45 +0100
>
> The module_put() function tests whether its argument is NULL and then
> returns immediately. Thus the test around the call is not needed.
>
> This issue was detected by
On Fri, 2014-11-21 at 10:30 +0100, SF Markus Elfring wrote:
From: Markus Elfring elfr...@users.sourceforge.net
Date: Fri, 21 Nov 2014 10:25:45 +0100
The module_put() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.
This
Nicholas Bellinger (1):
vhost-scsi: Take configfs group dependency during
VHOST_SCSI_SET_ENDPOINT
Or Gerlitz (1):
ib_isert: Add max_send_sge=2 minimum for control PDU responses
Roland Dreier (1):
target: Don't call TFO->write_pending if data_length == 0
Sagi Grimberg (1):
iser-tar
Nicholas Bellinger (1):
vhost-scsi: Take configfs group dependency during
VHOST_SCSI_SET_ENDPOINT
Or Gerlitz (1):
ib_isert: Add max_send_sge=2 minimum for control PDU responses
Roland Dreier (1):
target: Don't call TFO->write_pending if data_length == 0
Sagi Grimberg (1):
iser-tar
Hi Al & Co,
On Thu, 2014-11-20 at 21:47 +, Al Viro wrote:
> On Wed, Nov 19, 2014 at 04:53:40PM -0500, David Miller wrote:
>
> > Pulled, thanks Al.
>
> Umm... Not in net-next.git#master... Anyway, the next portion is in
> vfs.git#iov_iter-net right now; I'll post it on netdev once I get
Hi Al Co,
On Thu, 2014-11-20 at 21:47 +, Al Viro wrote:
On Wed, Nov 19, 2014 at 04:53:40PM -0500, David Miller wrote:
Pulled, thanks Al.
Umm... Not in net-next.git#master... Anyway, the next portion is in
vfs.git#iov_iter-net right now; I'll post it on netdev once I get some
Nicholas Bellinger (1):
vhost-scsi: Take configfs group dependency during
VHOST_SCSI_SET_ENDPOINT
Or Gerlitz (1):
ib_isert: Add max_send_sge=2 minimum for control PDU responses
Roland Dreier (1):
target: Don't call TFO-write_pending if data_length == 0
Sagi Grimberg (1):
iser-target
Nicholas Bellinger (1):
vhost-scsi: Take configfs group dependency during
VHOST_SCSI_SET_ENDPOINT
Or Gerlitz (1):
ib_isert: Add max_send_sge=2 minimum for control PDU responses
Roland Dreier (1):
target: Don't call TFO-write_pending if data_length == 0
Sagi Grimberg (1):
iser-target
qla_target: improve qlt_unmap_sg()
qla_target: rearrange struct qla_tgt_prm
qla_target: don't delete changed nacls
Nicholas Bellinger (5):
iscsi-target: Drop duplicate __iscsi_target_login_thread check
target/user: Fix up smatch warnings in tcmu_netlink_event
target: Fix APTPL metadata handling
qla_target: improve qlt_unmap_sg()
qla_target: rearrange struct qla_tgt_prm
qla_target: don't delete changed nacls
Nicholas Bellinger (5):
iscsi-target: Drop duplicate __iscsi_target_login_thread check
target/user: Fix up smatch warnings in tcmu_netlink_event
target: Fix APTPL metadata handling
On Mon, 2014-10-06 at 16:40 -0700, Zach Brown wrote:
> Both of the file target's calls to vfs_fsync_range() got the end offset
> off by one. The range is inclusive, not exclusive. It would sync a bit
> more data than was required.
>
> The sync path already tested the length of the range and
On Mon, 2014-10-06 at 16:40 -0700, Zach Brown wrote:
Both of the file target's calls to vfs_fsync_range() got the end offset
off by one. The range is inclusive, not exclusive. It would sync a bit
more data than was required.
The sync path already tested the length of the range and fell
On Fri, 2014-10-03 at 15:46 +1000, Stephen Rothwell wrote:
> Hi Nicholas,
>
> After merging the target-updates tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/target/target_core_user.c: In function 'tcmu_netlink_event':
>
On Fri, 2014-10-03 at 15:46 +1000, Stephen Rothwell wrote:
Hi Nicholas,
After merging the target-updates tree, today's linux-next build (x86_64
allmodconfig) failed like this:
drivers/target/target_core_user.c: In function 'tcmu_netlink_event':
drivers/target/target_core_user.c:780:2:
On Mon, 2014-09-22 at 14:00 -0700, Andy Grover wrote:
> On 09/22/2014 01:58 PM, Nicholas A. Bellinger wrote:
> > So I'd still like to start for an initial merge with the two different
> > modes mentioned earlier. The pure-passthrough mode where everything is
> > handled by u
On Fri, 2014-09-19 at 17:35 -0700, Andy Grover wrote:
> On 09/19/2014 04:51 PM, Alex Elsayed wrote:
>
> >> Not sure I follow.. How does the proposed passthrough mode prevent
> >> someone from emulating OSDs, media changers, optical disks or anything
> >> else in userspace with TCMU..?
> >>
> >>
On Fri, 2014-09-19 at 16:51 -0700, Alex Elsayed wrote:
> Nicholas A. Bellinger wrote:
>
> > On Fri, 2014-09-19 at 14:43 -0700, Alex Elsayed wrote:
> >> Nicholas A. Bellinger wrote:
> >>
> >>
> >> > So the idea of allowing the in-kernel CDB em
On Fri, 2014-09-19 at 16:51 -0700, Alex Elsayed wrote:
Nicholas A. Bellinger wrote:
On Fri, 2014-09-19 at 14:43 -0700, Alex Elsayed wrote:
Nicholas A. Bellinger wrote:
snip
So the idea of allowing the in-kernel CDB emulation to run after
user-space has returned unsupported opcode
On Fri, 2014-09-19 at 17:35 -0700, Andy Grover wrote:
On 09/19/2014 04:51 PM, Alex Elsayed wrote:
Not sure I follow.. How does the proposed passthrough mode prevent
someone from emulating OSDs, media changers, optical disks or anything
else in userspace with TCMU..?
The main thing
On Mon, 2014-09-22 at 14:00 -0700, Andy Grover wrote:
On 09/22/2014 01:58 PM, Nicholas A. Bellinger wrote:
So I'd still like to start for an initial merge with the two different
modes mentioned earlier. The pure-passthrough mode where everything is
handled by user-space, and an I/O
On Fri, 2014-09-19 at 14:43 -0700, Alex Elsayed wrote:
> Nicholas A. Bellinger wrote:
>
>
> > So the idea of allowing the in-kernel CDB emulation to run after
> > user-space has returned unsupported opcode is problematic for a couple
> > of different reasons.
>
Referrals
changes that when in during the v3.14 time-frame.
Also included are a few iscsi-target fixes, most recently of which where
found during Joern's Coverity scanning of target code.
Thanks,
--nab
Joern Engel (1):
iscsi-target: avoid NULL pointer in iscsi_copy_param_list failure
Nicholas
Hi Andy,
A few comments are inline below.
On Mon, 2014-09-15 at 16:12 -0700, Andy Grover wrote:
> Add a LIO storage engine that presents commands to userspace for execution.
> This would allow more complex backstores to be implemented out-of-kernel,
> and also make experimentation a-la FUSE (but
Hi Andy,
A few comments are inline below.
On Mon, 2014-09-15 at 16:12 -0700, Andy Grover wrote:
Add a LIO storage engine that presents commands to userspace for execution.
This would allow more complex backstores to be implemented out-of-kernel,
and also make experimentation a-la FUSE (but at
Referrals
changes that when in during the v3.14 time-frame.
Also included are a few iscsi-target fixes, most recently of which where
found during Joern's Coverity scanning of target code.
Thanks,
--nab
Joern Engel (1):
iscsi-target: avoid NULL pointer in iscsi_copy_param_list failure
Nicholas
On Fri, 2014-09-19 at 14:43 -0700, Alex Elsayed wrote:
Nicholas A. Bellinger wrote:
snip
So the idea of allowing the in-kernel CDB emulation to run after
user-space has returned unsupported opcode is problematic for a couple
of different reasons.
First, if the correct feature bits
On Thu, 2014-09-18 at 15:54 -0700, Andy Grover wrote:
> On 09/18/2014 12:38 AM, Nicholas A. Bellinger wrote:
> > On Sat, 2014-09-13 at 21:55 +0200, Christoph Hellwig wrote:
> >> ping again. We're getting closer to the end of the 3.18 merge window
> >> and there s
On Sat, 2014-09-13 at 21:55 +0200, Christoph Hellwig wrote:
> On Tue, Jul 29, 2014 at 03:15:11PM +0200, Christoph Hellwig wrote:
> > Nic,
> >
> > any progress on looking over these? Seems like there's actually
> > nothing at all queued up for 3.17 in the target tree, or am І missing
> >
On Thu, 2014-09-18 at 15:54 -0700, Andy Grover wrote:
On 09/18/2014 12:38 AM, Nicholas A. Bellinger wrote:
On Sat, 2014-09-13 at 21:55 +0200, Christoph Hellwig wrote:
ping again. We're getting closer to the end of the 3.18 merge window
and there still hasn't been a response. Should Andy
On Sat, 2014-09-13 at 21:55 +0200, Christoph Hellwig wrote:
On Tue, Jul 29, 2014 at 03:15:11PM +0200, Christoph Hellwig wrote:
Nic,
any progress on looking over these? Seems like there's actually
nothing at all queued up for 3.17 in the target tree, or am І missing
something?
ping
related bug-fixes, along
with a few other very minor cleanups.
Thank you,
--nab
Andreea-Cristina Bernat (1):
tcm_fc: Replace rcu_assign_pointer() with RCU_INIT_POINTER()
Himangi Saraogi (1):
target/configfs: Remove unnecessary null test
Nicholas Bellinger (1):
iscsi-target: Ignore
related bug-fixes, along
with a few other very minor cleanups.
Thank you,
--nab
Andreea-Cristina Bernat (1):
tcm_fc: Replace rcu_assign_pointer() with RCU_INIT_POINTER()
Himangi Saraogi (1):
target/configfs: Remove unnecessary null test
Nicholas Bellinger (1):
iscsi-target: Ignore
Hi Rasmus,
On Fri, 2014-08-22 at 14:54 +0200, Rasmus Villemoes wrote:
> Clearly the file was meant to contain an include guard, but it was
> missing the #define part.
>
> Signed-off-by: Rasmus Villemoes
> ---
> drivers/target/target_core_ua.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff
Hi Andreea-Cristina,
On Mon, 2014-08-18 at 15:05 +0300, Andreea-Cristina Bernat wrote:
> The use of "rcu_assign_pointer()" is NULLing out the pointer.
> According to RCU_INIT_POINTER()'s block comment:
> "1. This use of RCU_INIT_POINTER() is NULLing out the pointer"
> it is better to use it
Hi Rickard,
On Sun, 2014-08-03 at 23:50 +0200, Rickard Strandqvist wrote:
> Ensures that the string is null-terminate in connection with the
> use of strncpy. Optimized code by replacing unnecessary sprintf
> with strlcat and more, and simultaneously guarantees that the
> string does not get
Hi Rickard,
On Sun, 2014-08-03 at 23:50 +0200, Rickard Strandqvist wrote:
Ensures that the string is null-terminate in connection with the
use of strncpy. Optimized code by replacing unnecessary sprintf
with strlcat and more, and simultaneously guarantees that the
string does not get bigger
Hi Andreea-Cristina,
On Mon, 2014-08-18 at 15:05 +0300, Andreea-Cristina Bernat wrote:
The use of rcu_assign_pointer() is NULLing out the pointer.
According to RCU_INIT_POINTER()'s block comment:
1. This use of RCU_INIT_POINTER() is NULLing out the pointer
it is better to use it instead of
Hi Rasmus,
On Fri, 2014-08-22 at 14:54 +0200, Rasmus Villemoes wrote:
Clearly the file was meant to contain an include guard, but it was
missing the #define part.
Signed-off-by: Rasmus Villemoes li...@rasmusvillemoes.dk
---
drivers/target/target_core_ua.h | 1 +
1 file changed, 1
On Mon, 2014-08-11 at 13:52 -0700, Nicholas A. Bellinger wrote:
> (Responding again without gmail, as the last email hit a failure when
> responding to the lists..)
>
> On Mon, 2014-08-11 at 16:17 -0400, Alexander Gordeev wrote:
> > On Fri, Jul 18, 2014 at 12:20:56PM +0200,
(Responding again without gmail, as the last email hit a failure when
responding to the lists..)
On Mon, 2014-08-11 at 16:17 -0400, Alexander Gordeev wrote:
> On Fri, Jul 18, 2014 at 12:20:56PM +0200, Alexander Gordeev wrote:
> > The performance test is not decent, though. I used "fio" random
> >
(Responding again without gmail, as the last email hit a failure when
responding to the lists..)
On Mon, 2014-08-11 at 16:17 -0400, Alexander Gordeev wrote:
On Fri, Jul 18, 2014 at 12:20:56PM +0200, Alexander Gordeev wrote:
The performance test is not decent, though. I used fio random
read
On Mon, 2014-08-11 at 13:52 -0700, Nicholas A. Bellinger wrote:
(Responding again without gmail, as the last email hit a failure when
responding to the lists..)
On Mon, 2014-08-11 at 16:17 -0400, Alexander Gordeev wrote:
On Fri, Jul 18, 2014 at 12:20:56PM +0200, Alexander Gordeev wrote
Hi Himangi,
On Thu, 2014-07-17 at 02:29 +0530, Himangi Saraogi wrote:
> This patch removes the null test on lun_cg. lun_cg is initialized
> at the beginning of the function to >lun_group. Since lun_cg is
> dereferenced prior to the null test, it must be a valid pointer.
>
> The following
Hi Himangi,
On Thu, 2014-07-17 at 02:29 +0530, Himangi Saraogi wrote:
This patch removes the null test on lun_cg. lun_cg is initialized
at the beginning of the function to lun-lun_group. Since lun_cg is
dereferenced prior to the null test, it must be a valid pointer.
The following
601 - 700 of 1751 matches
Mail list logo
