Re: [PATCH-v2 12/17] target/file: Add DIF protection init/format support

2014-01-22 Thread Nicholas A. Bellinger
On Wed, 2014-01-22 at 12:12 +0200, Sagi Grimberg wrote: > On 1/22/2014 12:28 AM, Nicholas A. Bellinger wrote: > > On Sun, 2014-01-19 at 14:31 +0200, Sagi Grimberg wrote: > >> On 1/19/2014 4:44 AM, Nicholas A. Bellinger wrote: > >>> From: Nicholas Bellinger >

Re: [PATCH-v2 0/3] percpu_ida+Co: Make percpu_ida_alloc accept task state bitmask

2014-01-22 Thread Nicholas A. Bellinger
Hey Jens, On Mon, 2014-01-20 at 03:44 +, Nicholas A. Bellinger wrote: > From: Nicholas Bellinger > > Hi Linus, > > Here is the -v2 series for converting percpu_ida_alloc() + consumer > usage to accept the task state bitmask parameter, w/o the extra > legacy gfp_t wrapp

Re: [PATCH-v2 1/3] percpu_ida: Make percpu_ida_alloc + callers accept task state bitmask

2014-01-22 Thread Nicholas A. Bellinger
-21 at 14:18 -0800, Kent Overstreet wrote: > On Mon, Jan 20, 2014 at 12:34:15PM +0100, Peter Zijlstra wrote: > > On Mon, Jan 20, 2014 at 03:44:44AM +, Nicholas A. Bellinger wrote: > > > From: Kent Overstreet > > > > > > This patch changes percpu_ida_al

Re: [PATCH-v2 1/3] percpu_ida: Make percpu_ida_alloc + callers accept task state bitmask

2014-01-22 Thread Nicholas A. Bellinger
-21 at 14:18 -0800, Kent Overstreet wrote: On Mon, Jan 20, 2014 at 12:34:15PM +0100, Peter Zijlstra wrote: On Mon, Jan 20, 2014 at 03:44:44AM +, Nicholas A. Bellinger wrote: From: Kent Overstreet k...@daterainc.com This patch changes percpu_ida_alloc() + callers to accept task state

Re: [PATCH-v2 0/3] percpu_ida+Co: Make percpu_ida_alloc accept task state bitmask

2014-01-22 Thread Nicholas A. Bellinger
Hey Jens, On Mon, 2014-01-20 at 03:44 +, Nicholas A. Bellinger wrote: From: Nicholas Bellinger n...@linux-iscsi.org Hi Linus, Here is the -v2 series for converting percpu_ida_alloc() + consumer usage to accept the task state bitmask parameter, w/o the extra legacy gfp_t wrapper

Re: [PATCH-v2 12/17] target/file: Add DIF protection init/format support

2014-01-22 Thread Nicholas A. Bellinger
On Wed, 2014-01-22 at 12:12 +0200, Sagi Grimberg wrote: On 1/22/2014 12:28 AM, Nicholas A. Bellinger wrote: On Sun, 2014-01-19 at 14:31 +0200, Sagi Grimberg wrote: On 1/19/2014 4:44 AM, Nicholas A. Bellinger wrote: From: Nicholas Bellinger n...@linux-iscsi.org This patch adds support

Re: [PATCH-v2 02/17] target: Add DIF CHECK_CONDITION ASC/ASCQ exception cases

2014-01-22 Thread Nicholas A. Bellinger
On Wed, 2014-01-22 at 18:44 +0200, Sagi Grimberg wrote: On 1/19/2014 4:44 AM, Nicholas A. Bellinger wrote: From: Nicholas Bellinger n...@linux-iscsi.org This patch adds support for DIF related CHECK_CONDITION ASC/ASCQ exception cases into transport_send_check_condition_and_sense

Re: [PATCH-v2 03/17] target/sbc: Add DIF setup in sbc_check_prot + sbc_parse_cdb

2014-01-22 Thread Nicholas A. Bellinger
On Wed, 2014-01-22 at 20:00 +0200, Sagi Grimberg wrote: On 1/22/2014 12:48 AM, Nicholas A. Bellinger wrote: + cmd-prot_handover = PROT_SEPERATED; I know that we are not planning to support interleaved mode at the moment, But I think that the protection handover type is the backstore

Re: linux rdma 3.14 merge plans

2014-01-21 Thread Nicholas A. Bellinger
Roland & Co, On Tue, 2014-01-21 at 16:43 -0800, Roland Dreier wrote: > On Tue, Jan 21, 2014 at 2:00 PM, Or Gerlitz wrote: > > Roland, ping! the signature patches were posted > three months ago. We > > deserve a response from the maintainer that goes beyond "I need to > > think on that". > > > >

Re: bio_integrity_verify() bug causing READ verify to be silently skipped

2014-01-21 Thread Nicholas A. Bellinger
On Fri, 2014-01-17 at 16:58 -0500, Martin K. Petersen wrote: > >>>>> "nab" == Nicholas A Bellinger writes: > > >> That breaks partial completion, though. I'll take a look at Kent's > >> changes... > > nab> Ping..? Any updates on a prope

Re: [PATCH-v2 03/17] target/sbc: Add DIF setup in sbc_check_prot + sbc_parse_cdb

2014-01-21 Thread Nicholas A. Bellinger
On Sun, 2014-01-19 at 13:43 +0200, Sagi Grimberg wrote: > On 1/19/2014 4:44 AM, Nicholas A. Bellinger wrote: > > From: Nicholas Bellinger > > > > This patch adds sbc_check_prot() for performing various DIF > > related CDB sanity checks, along with setting cmd->pr

Re: [PATCH-v2 12/17] target/file: Add DIF protection init/format support

2014-01-21 Thread Nicholas A. Bellinger
On Sun, 2014-01-19 at 14:31 +0200, Sagi Grimberg wrote: > On 1/19/2014 4:44 AM, Nicholas A. Bellinger wrote: > > From: Nicholas Bellinger > > > > This patch adds support for DIF protection init/format support into > > the FILEIO backend. > > > > It inv

Re: [PATCH-v2 11/17] target/iblock: Add blk_integrity + BIP passthrough support

2014-01-21 Thread Nicholas A. Bellinger
On Sun, 2014-01-19 at 14:21 +0200, Sagi Grimberg wrote: > On 1/19/2014 4:44 AM, Nicholas A. Bellinger wrote: > > From: Nicholas Bellinger > > > > This patch adds blk_integrity passthrough support for block_device > > backends using IBLOCK. > > Nice! >

Re: [PATCH-v2 10/17] target: Add protection SGLs to target_submit_cmd_map_sgls

2014-01-21 Thread Nicholas A. Bellinger
On Sun, 2014-01-19 at 14:12 +0200, Sagi Grimberg wrote: > On 1/19/2014 4:44 AM, Nicholas A. Bellinger wrote: > > From: Nicholas Bellinger > > > > This patch adds support to target_submit_cmd_map_sgls() for > > accepting 'sgl_prot' + 'sgl_prot_count' parameters for >

Re: [PATCH-v2 1/3] percpu_ida: Make percpu_ida_alloc + callers accept task state bitmask

2014-01-21 Thread Nicholas A. Bellinger
On Mon, 2014-01-20 at 12:34 +0100, Peter Zijlstra wrote: > On Mon, Jan 20, 2014 at 03:44:44AM +0000, Nicholas A. Bellinger wrote: > > From: Kent Overstreet > > > > This patch changes percpu_ida_alloc() + callers to accept task state > > bitmask for prepare_to_wait()

Re: [PATCH-v2 1/3] percpu_ida: Make percpu_ida_alloc + callers accept task state bitmask

2014-01-21 Thread Nicholas A. Bellinger
On Mon, 2014-01-20 at 12:34 +0100, Peter Zijlstra wrote: On Mon, Jan 20, 2014 at 03:44:44AM +, Nicholas A. Bellinger wrote: From: Kent Overstreet k...@daterainc.com This patch changes percpu_ida_alloc() + callers to accept task state bitmask for prepare_to_wait() for code like target

Re: [PATCH-v2 10/17] target: Add protection SGLs to target_submit_cmd_map_sgls

2014-01-21 Thread Nicholas A. Bellinger
On Sun, 2014-01-19 at 14:12 +0200, Sagi Grimberg wrote: On 1/19/2014 4:44 AM, Nicholas A. Bellinger wrote: From: Nicholas Bellinger n...@linux-iscsi.org This patch adds support to target_submit_cmd_map_sgls() for accepting 'sgl_prot' + 'sgl_prot_count' parameters for DIF protection

Re: [PATCH-v2 11/17] target/iblock: Add blk_integrity + BIP passthrough support

2014-01-21 Thread Nicholas A. Bellinger
On Sun, 2014-01-19 at 14:21 +0200, Sagi Grimberg wrote: On 1/19/2014 4:44 AM, Nicholas A. Bellinger wrote: From: Nicholas Bellinger n...@linux-iscsi.org This patch adds blk_integrity passthrough support for block_device backends using IBLOCK. Nice! This includes iblock_alloc_bip

Re: [PATCH-v2 12/17] target/file: Add DIF protection init/format support

2014-01-21 Thread Nicholas A. Bellinger
On Sun, 2014-01-19 at 14:31 +0200, Sagi Grimberg wrote: On 1/19/2014 4:44 AM, Nicholas A. Bellinger wrote: From: Nicholas Bellinger n...@linux-iscsi.org This patch adds support for DIF protection init/format support into the FILEIO backend. It involves using a seperate

Re: [PATCH-v2 03/17] target/sbc: Add DIF setup in sbc_check_prot + sbc_parse_cdb

2014-01-21 Thread Nicholas A. Bellinger
On Sun, 2014-01-19 at 13:43 +0200, Sagi Grimberg wrote: On 1/19/2014 4:44 AM, Nicholas A. Bellinger wrote: From: Nicholas Bellinger n...@linux-iscsi.org This patch adds sbc_check_prot() for performing various DIF related CDB sanity checks, along with setting cmd-prot_type once sanity

Re: bio_integrity_verify() bug causing READ verify to be silently skipped

2014-01-21 Thread Nicholas A. Bellinger
On Fri, 2014-01-17 at 16:58 -0500, Martin K. Petersen wrote: nab == Nicholas A Bellinger n...@linux-iscsi.org writes: That breaks partial completion, though. I'll take a look at Kent's changes... nab Ping..? Any updates on a proper bugfix for this..? I did put your patch in my queue

Re: linux rdma 3.14 merge plans

2014-01-21 Thread Nicholas A. Bellinger
Roland Co, On Tue, 2014-01-21 at 16:43 -0800, Roland Dreier wrote: On Tue, Jan 21, 2014 at 2:00 PM, Or Gerlitz or.gerl...@gmail.com wrote: Roland, ping! the signature patches were posted three months ago. We deserve a response from the maintainer that goes beyond I need to think on that.

Re: [PATCH 1/5] percpu_ida: Make percpu_ida_alloc accept task state bitmask

2014-01-19 Thread Nicholas A. Bellinger
On Sun, 2014-01-19 at 18:38 -0800, Linus Torvalds wrote: > On Sun, Jan 19, 2014 at 2:16 AM, Nicholas A. Bellinger > wrote: > > > > This patch changes percpu_ida_alloc() to accept task state bitmask > > for prepare_to_wait() to support interruptible sleep for

[PATCH-v2 3/3] iscsi-target: Fix connection reset hang with percpu_ida_alloc

2014-01-19 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch addresses a bug where connection reset would hang indefinately once percpu_ida_alloc() was starved for tags, due to the fact that it always assumed uninterruptible sleep mode. So now make percpu_ida_alloc() check for signal_pending_state() for making

[PATCH-v2 0/3] percpu_ida+Co: Make percpu_ida_alloc accept task state bitmask

2014-01-19 Thread Nicholas A. Bellinger
From: Nicholas Bellinger Hi Linus, Here is the -v2 series for converting percpu_ida_alloc() + consumer usage to accept the task state bitmask parameter, w/o the extra legacy gfp_t wrapper. As requested, the first patch contains only the parameter change to percpu_ida_alloc() + existing

[PATCH-v2 2/3] blk-mq: Convert gfp_t parameters to task state bitmask

2014-01-19 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch propigates the use of task state bitmask for percpu_ida_alloc() up the blk-mq callchain, to the point in blk_get_request() where the blk-mq vs. blk-old split occurs. Along with the obvious parameters changes, there are two cases in mq_flush_work

[PATCH-v2 1/3] percpu_ida: Make percpu_ida_alloc + callers accept task state bitmask

2014-01-19 Thread Nicholas A. Bellinger
Torvalds Cc: Ingo Molnar Cc: Peter Zijlstra Cc: Jens Axboe Signed-off-by: Kent Overstreet Cc: #3.12+ Signed-off-by: Nicholas Bellinger --- block/blk-mq-tag.c |6 -- drivers/target/iscsi/iscsi_target_util.c |8 ++-- drivers/target/tcm_fc/tfc_cmd.c

Re: [GIT PULL] target fixes for v3.13

2014-01-19 Thread Nicholas A. Bellinger
On Fri, 2014-01-17 at 17:29 -0800, Linus Torvalds wrote: > On Thu, Jan 16, 2014 at 4:09 PM, Nicholas A. Bellinger > wrote: > > > > This change allows the percpu_ida tag allocator to optionally use > > interruptible sleep that iscsi-target expects, while still leavi

[PATCH 3/5] target: Update percpu_ida_alloc to use task state bitmask

2014-01-19 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch updates percpu_ida_alloc() for target/vhost to TASK_RUNNING (cannot sleep) instead of GFP_ATOMIC, and updates iscsi-target to use TASK_INTERRUPTIBLE (may sleep) or TASK_RUNNING (cannot sleep). Both are following the changes to percpu_ida to allow for task

[PATCH 5/5] target/iscsi: Convert gfp_t parameter to task state bitmask

2014-01-19 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch propigates the use of task state bitmask now used by percpu_ida_alloc() up the iscsi-target callchain, replacing the use of GFP_ATOMIC + GFP_KERNEL. Also, drop the unnecessary gfp_t parameter to isert_allocate_cmd(), and just pass TASK_INTERRUPTIBLE

[PATCH 2/5] blk-mq: Update percpu_ida_alloc to use task state bitmask

2014-01-19 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch updates percpu_ida_alloc() usage within blk-mq tag allocation code to use TASK_UNINTERRUPTIBLE (may sleep) or ASK_RUNNING (cannot sleep), following the changes to percpu_ida to allow for task state bitmask to be passed from the caller. Reported-by: Linus

[PATCH 4/5] blk-mq: Convert gfp_t parameters to task state bitmask

2014-01-19 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch propigates the use of task state bitmask for percpu_ida_alloc() up the blk-mq callchain, to the point in blk_get_request() where the blk-mq vs. blk-old split occurs. Along with the obvious parameters changes, there are two cases in mq_flush_work

[PATCH 1/5] percpu_ida: Make percpu_ida_alloc accept task state bitmask

2014-01-19 Thread Nicholas A. Bellinger
Torvalds Cc: Ingo Molnar Cc: Peter Zijlstra Signed-off-by: Kent Overstreet Cc: #3.12+ Signed-off-by: Nicholas Bellinger --- include/linux/percpu_ida.h |3 ++- lib/percpu_ida.c | 17 +++-- 2 files changed, 13 insertions(+), 7 deletions(-) diff --git a/include/linux

[PATCH 0/5] percpu_ida+Co: Make percpu_ida_alloc accept task state bitmask

2014-01-19 Thread Nicholas A. Bellinger
From: Nicholas Bellinger Hello Linus, Here is the series for converting percpu_ida_alloc() + consumer usage to accept the task state bitmask parameter, w/o the extra legacy gfp_t wrapper. Also, given that the first three patches needs to be backported to different kernel versions, the series

[PATCH 0/5] percpu_ida+Co: Make percpu_ida_alloc accept task state bitmask

2014-01-19 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org Hello Linus, Here is the series for converting percpu_ida_alloc() + consumer usage to accept the task state bitmask parameter, w/o the extra legacy gfp_t wrapper. Also, given that the first three patches needs to be backported to different kernel

[PATCH 2/5] blk-mq: Update percpu_ida_alloc to use task state bitmask

2014-01-19 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org This patch updates percpu_ida_alloc() usage within blk-mq tag allocation code to use TASK_UNINTERRUPTIBLE (may sleep) or ASK_RUNNING (cannot sleep), following the changes to percpu_ida to allow for task state bitmask to be passed from the caller

[PATCH 4/5] blk-mq: Convert gfp_t parameters to task state bitmask

2014-01-19 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org This patch propigates the use of task state bitmask for percpu_ida_alloc() up the blk-mq callchain, to the point in blk_get_request() where the blk-mq vs. blk-old split occurs. Along with the obvious parameters changes, there are two cases

[PATCH 1/5] percpu_ida: Make percpu_ida_alloc accept task state bitmask

2014-01-19 Thread Nicholas A. Bellinger
Torvalds torva...@linux-foundation.org Cc: Linus Torvalds torva...@linux-foundation.org Cc: Ingo Molnar mi...@redhat.com Cc: Peter Zijlstra pet...@infradead.org Signed-off-by: Kent Overstreet k...@daterainc.com Cc: sta...@vger.kernel.org #3.12+ Signed-off-by: Nicholas Bellinger n...@linux-iscsi.org

[PATCH 3/5] target: Update percpu_ida_alloc to use task state bitmask

2014-01-19 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org This patch updates percpu_ida_alloc() for target/vhost to TASK_RUNNING (cannot sleep) instead of GFP_ATOMIC, and updates iscsi-target to use TASK_INTERRUPTIBLE (may sleep) or TASK_RUNNING (cannot sleep). Both are following the changes to percpu_ida

[PATCH 5/5] target/iscsi: Convert gfp_t parameter to task state bitmask

2014-01-19 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org This patch propigates the use of task state bitmask now used by percpu_ida_alloc() up the iscsi-target callchain, replacing the use of GFP_ATOMIC + GFP_KERNEL. Also, drop the unnecessary gfp_t parameter to isert_allocate_cmd(), and just pass

Re: [GIT PULL] target fixes for v3.13

2014-01-19 Thread Nicholas A. Bellinger
On Fri, 2014-01-17 at 17:29 -0800, Linus Torvalds wrote: On Thu, Jan 16, 2014 at 4:09 PM, Nicholas A. Bellinger n...@linux-iscsi.org wrote: This change allows the percpu_ida tag allocator to optionally use interruptible sleep that iscsi-target expects, while still leaving

[PATCH-v2 1/3] percpu_ida: Make percpu_ida_alloc + callers accept task state bitmask

2014-01-19 Thread Nicholas A. Bellinger
torva...@linux-foundation.org Cc: Linus Torvalds torva...@linux-foundation.org Cc: Ingo Molnar mi...@redhat.com Cc: Peter Zijlstra pet...@infradead.org Cc: Jens Axboe ax...@kernel.dk Signed-off-by: Kent Overstreet k...@daterainc.com Cc: sta...@vger.kernel.org #3.12+ Signed-off-by: Nicholas Bellinger

[PATCH-v2 2/3] blk-mq: Convert gfp_t parameters to task state bitmask

2014-01-19 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org This patch propigates the use of task state bitmask for percpu_ida_alloc() up the blk-mq callchain, to the point in blk_get_request() where the blk-mq vs. blk-old split occurs. Along with the obvious parameters changes, there are two cases

[PATCH-v2 3/3] iscsi-target: Fix connection reset hang with percpu_ida_alloc

2014-01-19 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org This patch addresses a bug where connection reset would hang indefinately once percpu_ida_alloc() was starved for tags, due to the fact that it always assumed uninterruptible sleep mode. So now make percpu_ida_alloc() check for signal_pending_state

[PATCH-v2 0/3] percpu_ida+Co: Make percpu_ida_alloc accept task state bitmask

2014-01-19 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org Hi Linus, Here is the -v2 series for converting percpu_ida_alloc() + consumer usage to accept the task state bitmask parameter, w/o the extra legacy gfp_t wrapper. As requested, the first patch contains only the parameter change to percpu_ida_alloc

Re: [PATCH 1/5] percpu_ida: Make percpu_ida_alloc accept task state bitmask

2014-01-19 Thread Nicholas A. Bellinger
On Sun, 2014-01-19 at 18:38 -0800, Linus Torvalds wrote: On Sun, Jan 19, 2014 at 2:16 AM, Nicholas A. Bellinger n...@linux-iscsi.org wrote: This patch changes percpu_ida_alloc() to accept task state bitmask for prepare_to_wait() to support interruptible sleep for callers that require

[PATCH-v2 10/17] target: Add protection SGLs to target_submit_cmd_map_sgls

2014-01-18 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch adds support to target_submit_cmd_map_sgls() for accepting 'sgl_prot' + 'sgl_prot_count' parameters for DIF protection information. Note the passed parameters are stored at se_cmd->t_prot_sg and se_cmd->t_prot_nents respectively. Also, update tc

[PATCH-v2 04/17] target/sbc: Add DIF TYPE1+TYPE3 read/write verify emulation

2014-01-18 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch adds support for DIF read/write verify emulation for TARGET_DIF_TYPE1_PROT + TARGET_DIF_TYPE3_PROT operation. This includes sbc_dif_verify_write() + sbc_dif_verify_read() calls accessable by backend drivers to perform DIF verify for SGL based data

[PATCH-v2 07/17] target/sbc: Add P_TYPE + PROT_EN bits to READ_CAPACITY_16

2014-01-18 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch updates sbc_emulate_readcapacity_16() to set P_TYPE and PROT_EN bits when DIF emulation is enabled by the backend device. Reviewed-by: Martin K. Petersen Cc: Christoph Hellwig Cc: Hannes Reinecke Cc: Sagi Grimberg Cc: Or Gerlitz Signed-off-by: Nicholas

[PATCH-v2 08/17] target/spc: Expose ATO bit in control mode page

2014-01-18 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch updates spc_modesense_control() to set the Application Tag Owner (ATO) bit when when DIF emulation is enabled by the backend device. Reviewed-by: Martin K. Petersen Cc: Christoph Hellwig Cc: Hannes Reinecke Cc: Sagi Grimberg Cc: Or Gerlitz Signed-off

[PATCH-v2 02/17] target: Add DIF CHECK_CONDITION ASC/ASCQ exception cases

2014-01-18 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch adds support for DIF related CHECK_CONDITION ASC/ASCQ exception cases into transport_send_check_condition_and_sense(). This includes: LOGICAL BLOCK GUARD CHECK FAILED LOGICAL BLOCK APPLICATION TAG CHECK FAILED LOGICAL BLOCK REFERENCE TAG CHECK FAILED

[PATCH-v2 06/17] target/spc: Add protection related bits to INQUIRY EVPD=0x86

2014-01-18 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch updates spc_emulate_evpd_86() (extended INQUIRY) to report GRD_CHK (Guard Check) and REF_CHK (Reference Check) bits when DIF emulation is enabled by the backend device. Reviewed-by: Martin K. Petersen Cc: Christoph Hellwig Cc: Hannes Reinecke Cc: Sagi

[PATCH-v2 11/17] target/iblock: Add blk_integrity + BIP passthrough support

2014-01-18 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch adds blk_integrity passthrough support for block_device backends using IBLOCK. This includes iblock_alloc_bip() + setup of bio_integrity_payload information that attaches to the leading struct bio once bio_list is populated during fast-path iblock_execute_rw

[PATCH-v2 14/17] target/rd: Refactor rd_build_device_space + rd_release_device_space

2014-01-18 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch refactors rd_build_device_space() + rd_release_device_space() into rd_allocate_sgl_table() + rd_release_device_space() so that they may be used seperatly for setup + release of protection information scatterlists. Also add explicit memset of pages within

[PATCH-v2 15/17] target/rd: Add support for protection SGL setup + release

2014-01-18 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch adds rd_build_prot_space() + rd_release_prot_space() logic to setup + release protection information scatterlists. It also adds rd_init_prot() + rd_free_prot() se_subsystem_api callbacks used by target core code for setup + release of protection information

[PATCH-v2 17/17] tcm_loop: Enable DIF/DIX modes in SCSI host LLD

2014-01-18 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch updates tcm_loop_driver_probe() to set protection information using scsi_host_set_prot() and scsi_host_set_guard(), which currently enabled all modes of DIF/DIX protection, minus DIX TYPE0. Also, update tcm_loop_submission_work() to pass struct scsi_cmnd

[PATCH-v2 12/17] target/file: Add DIF protection init/format support

2014-01-18 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch adds support for DIF protection init/format support into the FILEIO backend. It involves using a seperate $FILE.protection for storing PI that is opened via fd_init_prot() using the common pi_prot_type attribute. The actual formatting of the protection

[PATCH-v2 13/17] target/file: Add DIF protection support to fd_execute_rw

2014-01-18 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch adds support for DIF protection into fd_execute_rw() code for WRITE/READ I/O using sbc_dif_verify_[write,read]() logic. It adds fd_do_prot_rw() for handling interface with FILEIO PI, and uses a locally allocated fd_prot->prot_buf + fd_prot->p

[PATCH-v2 16/17] target/rd: Add DIF protection into rd_execute_rw

2014-01-18 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch adds support for DIF protection into rd_execute_rw() code for WRITE/READ I/O using sbc_dif_verify_[write,read]() logic. It also adds rd_get_prot_table() for locating protection SGLs assoicated with the ramdisk backend device. v2 changes: - Make

[PATCH-v2 03/17] target/sbc: Add DIF setup in sbc_check_prot + sbc_parse_cdb

2014-01-18 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch adds sbc_check_prot() for performing various DIF related CDB sanity checks, along with setting cmd->prot_type once sanity checks have passed. Also, add calls in sbc_parse_cdb() for READ_[10,12,16] + WRITE_[10,12,16] to perform DIF sanity checking. v2 chan

[PATCH-v2 05/17] target/spc: Add protection bit to standard INQUIRY output

2014-01-18 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch updates spc_emulate_inquiry_std() to set the PROTECT bit when DIF emulation is enabled by the backend device. Reviewed-by: Martin K. Petersen Cc: Christoph Hellwig Cc: Hannes Reinecke Cc: Sagi Grimberg Cc: Or Gerlitz Signed-off-by: Nicholas Bellinger

[PATCH-v2 09/17] target/configfs: Expose protection device attributes

2014-01-18 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch adds support for exposing DIF protection device attributes via configfs. This includes: pi_prot_type: Protection Type (0, 1, 3 currently support) pi_prot_format: Protection Format Operation (FILEIO only) Within se_dev_set_pi_prot_type() it also adds

[PATCH-v2 00/17] target: Add support for DIF Type1+Type3 emulation + passthrough

2014-01-18 Thread Nicholas A. Bellinger
From: Nicholas Bellinger Hi MKP & Co, This -v2 series contains support for target mode DIF Type1+Type3 emulation within target core, FILEIO, and RAMDISK_MCP device backends, BIP passthrough of T10 PI within IBLOCK device backends, and DIF/DIX host support in the tcm_loop fabric driver.

[PATCH-v2 01/17] target: Add DIF related base definitions

2014-01-18 Thread Nicholas A. Bellinger
From: Nicholas Bellinger This patch adds DIF related definitions to target_core_base.h that includes enums for target_prot_op + target_prot_type + target_prot_version + target_guard_type + target_pi_error. Also included is struct se_dif_v1_tuple, along with changes to struct se_cmd, struct

[PATCH-v2 01/17] target: Add DIF related base definitions

2014-01-18 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org This patch adds DIF related definitions to target_core_base.h that includes enums for target_prot_op + target_prot_type + target_prot_version + target_guard_type + target_pi_error. Also included is struct se_dif_v1_tuple, along with changes to struct

[PATCH-v2 03/17] target/sbc: Add DIF setup in sbc_check_prot + sbc_parse_cdb

2014-01-18 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org This patch adds sbc_check_prot() for performing various DIF related CDB sanity checks, along with setting cmd-prot_type once sanity checks have passed. Also, add calls in sbc_parse_cdb() for READ_[10,12,16] + WRITE_[10,12,16] to perform DIF sanity

[PATCH-v2 05/17] target/spc: Add protection bit to standard INQUIRY output

2014-01-18 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org This patch updates spc_emulate_inquiry_std() to set the PROTECT bit when DIF emulation is enabled by the backend device. Reviewed-by: Martin K. Petersen martin.peter...@oracle.com Cc: Christoph Hellwig h...@lst.de Cc: Hannes Reinecke h...@suse.de Cc

[PATCH-v2 09/17] target/configfs: Expose protection device attributes

2014-01-18 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org This patch adds support for exposing DIF protection device attributes via configfs. This includes: pi_prot_type: Protection Type (0, 1, 3 currently support) pi_prot_format: Protection Format Operation (FILEIO only) Within

[PATCH-v2 00/17] target: Add support for DIF Type1+Type3 emulation + passthrough

2014-01-18 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org Hi MKP Co, This -v2 series contains support for target mode DIF Type1+Type3 emulation within target core, FILEIO, and RAMDISK_MCP device backends, BIP passthrough of T10 PI within IBLOCK device backends, and DIF/DIX host support in the tcm_loop

[PATCH-v2 12/17] target/file: Add DIF protection init/format support

2014-01-18 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org This patch adds support for DIF protection init/format support into the FILEIO backend. It involves using a seperate $FILE.protection for storing PI that is opened via fd_init_prot() using the common pi_prot_type attribute. The actual formatting

[PATCH-v2 13/17] target/file: Add DIF protection support to fd_execute_rw

2014-01-18 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org This patch adds support for DIF protection into fd_execute_rw() code for WRITE/READ I/O using sbc_dif_verify_[write,read]() logic. It adds fd_do_prot_rw() for handling interface with FILEIO PI, and uses a locally allocated fd_prot-prot_buf + fd_prot

[PATCH-v2 16/17] target/rd: Add DIF protection into rd_execute_rw

2014-01-18 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org This patch adds support for DIF protection into rd_execute_rw() code for WRITE/READ I/O using sbc_dif_verify_[write,read]() logic. It also adds rd_get_prot_table() for locating protection SGLs assoicated with the ramdisk backend device. v2 changes

[PATCH-v2 11/17] target/iblock: Add blk_integrity + BIP passthrough support

2014-01-18 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org This patch adds blk_integrity passthrough support for block_device backends using IBLOCK. This includes iblock_alloc_bip() + setup of bio_integrity_payload information that attaches to the leading struct bio once bio_list is populated during fast

[PATCH-v2 14/17] target/rd: Refactor rd_build_device_space + rd_release_device_space

2014-01-18 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org This patch refactors rd_build_device_space() + rd_release_device_space() into rd_allocate_sgl_table() + rd_release_device_space() so that they may be used seperatly for setup + release of protection information scatterlists. Also add explicit memset

[PATCH-v2 15/17] target/rd: Add support for protection SGL setup + release

2014-01-18 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org This patch adds rd_build_prot_space() + rd_release_prot_space() logic to setup + release protection information scatterlists. It also adds rd_init_prot() + rd_free_prot() se_subsystem_api callbacks used by target core code for setup + release

[PATCH-v2 17/17] tcm_loop: Enable DIF/DIX modes in SCSI host LLD

2014-01-18 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org This patch updates tcm_loop_driver_probe() to set protection information using scsi_host_set_prot() and scsi_host_set_guard(), which currently enabled all modes of DIF/DIX protection, minus DIX TYPE0. Also, update tcm_loop_submission_work() to pass

[PATCH-v2 08/17] target/spc: Expose ATO bit in control mode page

2014-01-18 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org This patch updates spc_modesense_control() to set the Application Tag Owner (ATO) bit when when DIF emulation is enabled by the backend device. Reviewed-by: Martin K. Petersen martin.peter...@oracle.com Cc: Christoph Hellwig h...@lst.de Cc: Hannes

[PATCH-v2 02/17] target: Add DIF CHECK_CONDITION ASC/ASCQ exception cases

2014-01-18 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org This patch adds support for DIF related CHECK_CONDITION ASC/ASCQ exception cases into transport_send_check_condition_and_sense(). This includes: LOGICAL BLOCK GUARD CHECK FAILED LOGICAL BLOCK APPLICATION TAG CHECK FAILED LOGICAL BLOCK

[PATCH-v2 06/17] target/spc: Add protection related bits to INQUIRY EVPD=0x86

2014-01-18 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org This patch updates spc_emulate_evpd_86() (extended INQUIRY) to report GRD_CHK (Guard Check) and REF_CHK (Reference Check) bits when DIF emulation is enabled by the backend device. Reviewed-by: Martin K. Petersen martin.peter...@oracle.com Cc

[PATCH-v2 10/17] target: Add protection SGLs to target_submit_cmd_map_sgls

2014-01-18 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org This patch adds support to target_submit_cmd_map_sgls() for accepting 'sgl_prot' + 'sgl_prot_count' parameters for DIF protection information. Note the passed parameters are stored at se_cmd-t_prot_sg and se_cmd-t_prot_nents respectively. Also

[PATCH-v2 04/17] target/sbc: Add DIF TYPE1+TYPE3 read/write verify emulation

2014-01-18 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org This patch adds support for DIF read/write verify emulation for TARGET_DIF_TYPE1_PROT + TARGET_DIF_TYPE3_PROT operation. This includes sbc_dif_verify_write() + sbc_dif_verify_read() calls accessable by backend drivers to perform DIF verify for SGL

[PATCH-v2 07/17] target/sbc: Add P_TYPE + PROT_EN bits to READ_CAPACITY_16

2014-01-18 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org This patch updates sbc_emulate_readcapacity_16() to set P_TYPE and PROT_EN bits when DIF emulation is enabled by the backend device. Reviewed-by: Martin K. Petersen martin.peter...@oracle.com Cc: Christoph Hellwig h...@lst.de Cc: Hannes Reinecke h

Re: bio_integrity_verify() bug causing READ verify to be silently skipped

2014-01-16 Thread Nicholas A. Bellinger
On Fri, 2014-01-03 at 15:09 -0500, Martin K. Petersen wrote: > >>>>> "nab" == Nicholas A Bellinger writes: > > nab> Given that bio_integrity_verify() is using bio_for_each_segment(), > nab> the loop starts from the updated bio->bi_idx, and n

[GIT PULL] target fixes for v3.13

2014-01-16 Thread Nicholas A. Bellinger
ows the percpu_ida tag allocator to optionally use interruptible sleep that iscsi-target expects, while still leaving the functionality + interface for existing percpu_ida consumers unchanged. Thank you, --nab Kent Overstreet (1): percpu_ida: Allow tag alloc interface to interruptible sleep Nicho

[GIT PULL] target fixes for v3.13

2014-01-16 Thread Nicholas A. Bellinger
the percpu_ida tag allocator to optionally use interruptible sleep that iscsi-target expects, while still leaving the functionality + interface for existing percpu_ida consumers unchanged. Thank you, --nab Kent Overstreet (1): percpu_ida: Allow tag alloc interface to interruptible sleep Nicholas Bellinger

Re: bio_integrity_verify() bug causing READ verify to be silently skipped

2014-01-16 Thread Nicholas A. Bellinger
On Fri, 2014-01-03 at 15:09 -0500, Martin K. Petersen wrote: nab == Nicholas A Bellinger n...@linux-iscsi.org writes: nab Given that bio_integrity_verify() is using bio_for_each_segment(), nab the loop starts from the updated bio-bi_idx, and not a zero value, nab which ends up skipping

Re: [PATCH 00/14] target: Initial support for DIF Type1+Type3 emulation

2014-01-15 Thread Nicholas A. Bellinger
On Wed, 2014-01-15 at 20:42 -0500, Martin K. Petersen wrote: > >>>>> "nab" == Nicholas A Bellinger writes: > > nab> The issue is that existing fs/bio-integrity.c code always assumes > nab> client/initiator mode, in that it will attempt to > nab>

[LSF/MM TOPIC] [ATTEND] scsi-mq

2014-01-15 Thread Nicholas A. Bellinger
Hi all, I'd like to discuss the current state of scsi-mq prototype code. And now that blk-mq is upstream for v3.13, exploring the remaining TODO items towards an initial scsi-mq merge sometime before 2015 is upon us. The benefits of scsi-mq remain unchanged: - Utilizes blk-mq's native

Re: [PATCH 00/14] target: Initial support for DIF Type1+Type3 emulation

2014-01-15 Thread Nicholas A. Bellinger
On Wed, 2014-01-15 at 20:03 +0200, sagi grimberg wrote: > On 1/8/2014 10:36 PM, Nicholas A. Bellinger wrote: > > From: Nicholas Bellinger > > > > Hi MKP & SCSI folks, > > > > This series contains initial support for target mode DIF Type1+Type3 > > emula

Re: [PATCH 00/14] target: Initial support for DIF Type1+Type3 emulation

2014-01-15 Thread Nicholas A. Bellinger
On Wed, 2014-01-15 at 20:03 +0200, sagi grimberg wrote: On 1/8/2014 10:36 PM, Nicholas A. Bellinger wrote: From: Nicholas Bellinger n...@linux-iscsi.org Hi MKP SCSI folks, This series contains initial support for target mode DIF Type1+Type3 emulation within target core, RAMDISK_MCP

[LSF/MM TOPIC] [ATTEND] scsi-mq

2014-01-15 Thread Nicholas A. Bellinger
Hi all, I'd like to discuss the current state of scsi-mq prototype code. And now that blk-mq is upstream for v3.13, exploring the remaining TODO items towards an initial scsi-mq merge sometime before 2015 is upon us. The benefits of scsi-mq remain unchanged: - Utilizes blk-mq's native

Re: [PATCH 00/14] target: Initial support for DIF Type1+Type3 emulation

2014-01-15 Thread Nicholas A. Bellinger
On Wed, 2014-01-15 at 20:42 -0500, Martin K. Petersen wrote: nab == Nicholas A Bellinger n...@linux-iscsi.org writes: nab The issue is that existing fs/bio-integrity.c code always assumes nab client/initiator mode, in that it will attempt to nab bio_integrity_generate() protection

Re: [PATCH 02/14] target: Add DIF CHECK_CONDITION ASC/ASCQ exception cases

2014-01-14 Thread Nicholas A. Bellinger
On Tue, 2014-01-14 at 09:44 +0200, Sagi Grimberg wrote: > On 1/10/2014 8:53 AM, Nicholas A. Bellinger wrote: > > On Thu, 2014-01-09 at 12:43 +0200, Sagi Grimberg wrote: > >> On 1/8/2014 10:36 PM, Nicholas A. Bellinger wrote: > >>> From: Nicholas Bellinger >

Re: [PATCH 02/14] target: Add DIF CHECK_CONDITION ASC/ASCQ exception cases

2014-01-14 Thread Nicholas A. Bellinger
On Tue, 2014-01-14 at 09:44 +0200, Sagi Grimberg wrote: On 1/10/2014 8:53 AM, Nicholas A. Bellinger wrote: On Thu, 2014-01-09 at 12:43 +0200, Sagi Grimberg wrote: On 1/8/2014 10:36 PM, Nicholas A. Bellinger wrote: From: Nicholas Bellinger n...@linux-iscsi.org This patch adds support

Re: [PATCH 09/14] target/configfs: Expose protection device attributes

2014-01-13 Thread Nicholas A. Bellinger
On Mon, 2014-01-13 at 10:52 -0800, James Bottomley wrote: > On Mon, 2014-01-13 at 10:30 -0800, Nicholas A. Bellinger wrote: > > Hey MKP, > > > > On Fri, 2014-01-10 at 16:01 -0500, Martin K. Petersen wrote: > > > >>>>> "nab" == Nicholas

Re: [PATCH 03/14] target/sbc: Add sbc_check_prot + update sbc_parse_cdb for DIF

2014-01-13 Thread Nicholas A. Bellinger
On Sun, 2014-01-12 at 13:59 +0200, Sagi Grimberg wrote: > On 1/10/2014 9:04 AM, Nicholas A. Bellinger wrote: > > On Thu, 2014-01-09 at 16:58 +0200, Sagi Grimberg wrote: > >> On 1/8/2014 10:36 PM, Nicholas A. Bellinger wrote: > >>> diff --git a/drivers/target/targ

Re: [PATCH 13/14] target/rd: Add DIF protection into rd_execute_rw

2014-01-13 Thread Nicholas A. Bellinger
On Sun, 2014-01-12 at 13:53 +0200, Sagi Grimberg wrote: > > > >> I wander how we can skip sbc_dif_verify_ if the transport already > >> offloaded DIF verify. > >> I think that the transport should signal the core layer that it is able > >> to offload DIF (ADD/STRIP/PASS/VERIFY), in which

Re: [PATCH 14/14] tcm_loop: Enable DIF/DIX modes in SCSI host LLD

2014-01-13 Thread Nicholas A. Bellinger
On Fri, 2014-01-10 at 16:09 -0500, Martin K. Petersen wrote: > >>>>> "nab" == Nicholas A Bellinger writes: > > nab> This patch updates tcm_loop_driver_probe() to set protection > nab> information using scsi_host_set_prot() and scsi_host_set_guard(

Re: [PATCH 09/14] target/configfs: Expose protection device attributes

2014-01-13 Thread Nicholas A. Bellinger
Hey MKP, On Fri, 2014-01-10 at 16:01 -0500, Martin K. Petersen wrote: > >>>>> "nab" == Nicholas A Bellinger writes: > > nab> This patch adds support for exposing DIF protection device > nab> attributes via configfs. This includes: > > nab>

Re: [PATCH 09/14] target/configfs: Expose protection device attributes

2014-01-13 Thread Nicholas A. Bellinger
Hey MKP, On Fri, 2014-01-10 at 16:01 -0500, Martin K. Petersen wrote: nab == Nicholas A Bellinger n...@daterainc.com writes: nab This patch adds support for exposing DIF protection device nab attributes via configfs. This includes: nabpi_prot_type: Protection Type (0, 1, 3 currently

<    4   5   6   7   8   9   10   11   12   13   >