Re: [PATCH v2 2/2] Input: synaptics-rmi4 - Propagate correct number of rx and tx electrodes to F54

2016-11-15 Thread Nick Dyer
F54 to avoid > corrupted output if not all electrodes are enabled. > > Fixes: 3a762dbd5347 ("[media] Input: synaptics-rmi4 - add support for F54 > ...") > Cc: Nick Dyer > Cc: Andrew Duggan > Cc: Chris Healy > Signed-off-by: Guenter Roeck Tested-by: Nick Dye

Re: [PATCH v2 1/2] Input: synaptics-rmi4 - add support for F55 sensor tuning

2016-11-15 Thread Nick Dyer
: synaptics-rmi4 - add support for F54 > ...") > Signed-off-by: Guenter Roeck Hi Guenter- I've tested this patch on s7813 and it works correctly. Tested-by: Nick Dyer > --- > v2: Drop unnecessary include files > Only read required number of query elements > Added F

Re: [PATCH v3 00/18] Synaptics RMI4 and SMBus implementation

2016-11-07 Thread Nick Dyer
t; Input: synaptics-rmi4 - smbus: on resume, try 3 times if init fails > > Input: synaptics-rmi4 - fix documentation of > > rmi_2d_sensor_platform_data > > > > Bjorn Andersson (1): > > Input: synaptics-rmi4 - Move IRQ handling to rmi_driver > > > > Dennis Wassenberg (1): > > Input: synaptics-rmi4 - f03: grab data passed by transport device > > > > Lyude Paul (1): > > Input: synaptics-rmi4 - add support for F03 > > > > Nick Dyer (1): > > Input: synaptics-rmi4 - factor out functions from probe

Re: [PATCH v3 00/18] Synaptics RMI4 and SMBus implementation

2016-11-07 Thread Nick Dyer
l buttons on > > buttonpads to PS/2 guest > > Input: synaptics - allocate a Synaptics Intertouch device > > Input: synaptics-rmi4 - add rmi_platform > > Input: synaptics-rmi4 - smbus: call psmouse_deactivate before > > binding/resume > > Input: synaptics-rmi4 - smbus: on resu

[PATCH v3] Input: synaptics-rmi4 - stop scanning PDT after two empty pages

2016-10-26 Thread Nick Dyer
We have encountered some RMI4 firmwares where there are blank pages in between PDT pages which contain functions. This change makes them correctly enumerate all functions on the device. Tested on S7817 (has empty page 2). Signed-off-by: Nick Dyer <n...@shmanahar.org> [Tested succes

[PATCH v3] Input: synaptics-rmi4 - stop scanning PDT after two empty pages

2016-10-26 Thread Nick Dyer
We have encountered some RMI4 firmwares where there are blank pages in between PDT pages which contain functions. This change makes them correctly enumerate all functions on the device. Tested on S7817 (has empty page 2). Signed-off-by: Nick Dyer [Tested successfully on S7817 and S7300

[PATCH v2] Input: synaptics-rmi4 - stop scanning PDT after two empty pages

2016-10-25 Thread Nick Dyer
We have encountered some RMI4 firmwares where there are blank pages in between PDT pages which contain functions. This change makes them correctly enumerate all functions on the device. Tested on S7817 (has empty page 2). Signed-off-by: Nick Dyer <n...@shmanahar.org> --- drivers/inpu

[PATCH v2] Input: synaptics-rmi4 - stop scanning PDT after two empty pages

2016-10-25 Thread Nick Dyer
We have encountered some RMI4 firmwares where there are blank pages in between PDT pages which contain functions. This change makes them correctly enumerate all functions on the device. Tested on S7817 (has empty page 2). Signed-off-by: Nick Dyer --- drivers/input/rmi4/rmi_driver.c | 16

[PATCH v1] Input: synaptics-rmi4 - allow number of PDT pages to be specified

2016-10-24 Thread Nick Dyer
We have encountered some RMI4 firmwares where there are blank pages in between PDT pages which contain functions. Add a device tree property which can be set to force reading the first N pages. Signed-off-by: Nick Dyer <n...@shmanahar.org> --- Documentation/devicetree/bindings/inpu

[PATCH v1] Input: synaptics-rmi4 - allow number of PDT pages to be specified

2016-10-24 Thread Nick Dyer
We have encountered some RMI4 firmwares where there are blank pages in between PDT pages which contain functions. Add a device tree property which can be set to force reading the first N pages. Signed-off-by: Nick Dyer --- Documentation/devicetree/bindings/input/rmi4/rmi_i2c.txt | 2

[PATCH v5 4/7] Input: synaptics-rmi4 - add support for F34 V7 bootloader

2016-10-24 Thread Nick Dyer
Port firmware update code from Samsung Galaxy S7 driver into mainline framework. This patch has been tested on Synaptics S7813. Signed-off-by: Nick Dyer <n...@shmanahar.org> --- drivers/input/rmi4/Makefile |2 +- drivers/input/rmi4/rmi_driver.c | 56 +- drivers/input/rmi4/rmi

[PATCH v5 4/7] Input: synaptics-rmi4 - add support for F34 V7 bootloader

2016-10-24 Thread Nick Dyer
Port firmware update code from Samsung Galaxy S7 driver into mainline framework. This patch has been tested on Synaptics S7813. Signed-off-by: Nick Dyer --- drivers/input/rmi4/Makefile |2 +- drivers/input/rmi4/rmi_driver.c | 56 +- drivers/input/rmi4/rmi_f34.c| 53 +- drivers

[PATCH v5 2/7] Input: synaptics-rmi4 - add a couple of debug lines

2016-10-24 Thread Nick Dyer
Signed-off-by: Nick Dyer <n...@shmanahar.org> --- drivers/input/rmi4/rmi_bus.c| 3 +++ drivers/input/rmi4/rmi_driver.c | 1 + 2 files changed, 4 insertions(+) diff --git a/drivers/input/rmi4/rmi_bus.c b/drivers/input/rmi4/rmi_bus.c index ef8c747..3c6a1b5 100644 --- a/drivers/inpu

[PATCH v5 0/7] Input: synaptics-rmi4 - F34 device reflash support

2016-10-24 Thread Nick Dyer
Hi- Please find attached patches to add F34 firmware update to the RMI4 driver. Changes in v5: - Improve split between for different versions (req. Bjorn Andersson) - Address a couple of kbuild test robot issues - Fix a bug with configuration ID on V7 Changes in v4: - Add support for v7

[PATCH v5 5/7] Input: synaptics-rmi4 - add sysfs attribute update_fw_status

2016-10-24 Thread Nick Dyer
The status is the percentage complete, or once complete, zero for success or a negative return code. Signed-off-by: Nick Dyer <n...@shmanahar.org> --- drivers/input/rmi4/rmi_f34.c | 34 ++ drivers/input/rmi4/rmi_f34.h | 4 drivers/input/rmi4/rmi_f

[PATCH v5 0/7] Input: synaptics-rmi4 - F34 device reflash support

2016-10-24 Thread Nick Dyer
Hi- Please find attached patches to add F34 firmware update to the RMI4 driver. Changes in v5: - Improve split between for different versions (req. Bjorn Andersson) - Address a couple of kbuild test robot issues - Fix a bug with configuration ID on V7 Changes in v4: - Add support for v7

[PATCH v5 5/7] Input: synaptics-rmi4 - add sysfs attribute update_fw_status

2016-10-24 Thread Nick Dyer
The status is the percentage complete, or once complete, zero for success or a negative return code. Signed-off-by: Nick Dyer --- drivers/input/rmi4/rmi_f34.c | 34 ++ drivers/input/rmi4/rmi_f34.h | 4 drivers/input/rmi4/rmi_f34v7.c | 14

[PATCH v5 2/7] Input: synaptics-rmi4 - add a couple of debug lines

2016-10-24 Thread Nick Dyer
Signed-off-by: Nick Dyer --- drivers/input/rmi4/rmi_bus.c| 3 +++ drivers/input/rmi4/rmi_driver.c | 1 + 2 files changed, 4 insertions(+) diff --git a/drivers/input/rmi4/rmi_bus.c b/drivers/input/rmi4/rmi_bus.c index ef8c747..3c6a1b5 100644 --- a/drivers/input/rmi4/rmi_bus.c +++ b/drivers

[PATCH v5 7/7] Input: synaptics-rmi4 - add package_id sysfs attribute

2016-10-24 Thread Nick Dyer
Signed-off-by: Nick Dyer <n...@shmanahar.org> --- drivers/input/rmi4/rmi_driver.h | 1 + drivers/input/rmi4/rmi_f01.c| 24 +++- drivers/input/rmi4/rmi_f34.c| 16 3 files changed, 40 insertions(+), 1 deletion(-) diff --git a/drivers/inpu

[PATCH v5 3/7] Input: synaptics-rmi4 - add support for F34 device reflash

2016-10-24 Thread Nick Dyer
Add support for updating firmware, triggered by a sysfs attribute. This patch has been tested on Synaptics S7300. Signed-off-by: Nick Dyer <n...@shmanahar.org> Tested-by: Chris Healy <cphe...@gmail.com> --- drivers/input/rmi4/Kconfig | 11 + drivers/input/rmi4/Makefi

[PATCH v5 7/7] Input: synaptics-rmi4 - add package_id sysfs attribute

2016-10-24 Thread Nick Dyer
Signed-off-by: Nick Dyer --- drivers/input/rmi4/rmi_driver.h | 1 + drivers/input/rmi4/rmi_f01.c| 24 +++- drivers/input/rmi4/rmi_f34.c| 16 3 files changed, 40 insertions(+), 1 deletion(-) diff --git a/drivers/input/rmi4/rmi_driver.h b/drivers

[PATCH v5 3/7] Input: synaptics-rmi4 - add support for F34 device reflash

2016-10-24 Thread Nick Dyer
Add support for updating firmware, triggered by a sysfs attribute. This patch has been tested on Synaptics S7300. Signed-off-by: Nick Dyer Tested-by: Chris Healy --- drivers/input/rmi4/Kconfig | 11 + drivers/input/rmi4/Makefile | 1 + drivers/input/rmi4/rmi_bus.c| 3

[PATCH v5 6/7] Input: synaptics-rmi4 - add sysfs interfaces for hardware IDs

2016-10-24 Thread Nick Dyer
Signed-off-by: Nick Dyer <n...@shmanahar.org> --- drivers/input/rmi4/rmi_driver.c | 2 +- drivers/input/rmi4/rmi_driver.h | 5 +- drivers/input/rmi4/rmi_f01.c| 23 - drivers/input/rmi4/rmi_f34.c| 110 4 files changed, 137 inse

[PATCH v5 6/7] Input: synaptics-rmi4 - add sysfs interfaces for hardware IDs

2016-10-24 Thread Nick Dyer
Signed-off-by: Nick Dyer --- drivers/input/rmi4/rmi_driver.c | 2 +- drivers/input/rmi4/rmi_driver.h | 5 +- drivers/input/rmi4/rmi_f01.c| 23 - drivers/input/rmi4/rmi_f34.c| 110 4 files changed, 137 insertions(+), 3 deletions

[PATCH v5 1/7] Input: synaptics-rmi4 - factor out functions from probe

2016-10-24 Thread Nick Dyer
Signed-off-by: Nick Dyer <n...@shmanahar.org> Signed-off-by: Benjamin Tissoires <benjamin.tissoi...@redhat.com> --- drivers/input/rmi4/rmi_driver.c | 139 +--- 1 file changed, 86 insertions(+), 53 deletions(-) diff --git a/drivers/input/rmi4/rm

[PATCH v5 1/7] Input: synaptics-rmi4 - factor out functions from probe

2016-10-24 Thread Nick Dyer
Signed-off-by: Nick Dyer Signed-off-by: Benjamin Tissoires --- drivers/input/rmi4/rmi_driver.c | 139 +--- 1 file changed, 86 insertions(+), 53 deletions(-) diff --git a/drivers/input/rmi4/rmi_driver.c b/drivers/input/rmi4/rmi_driver.c index 4a88312..63c9e22

Re: [-next, 1/2] Input: synaptics-rmi4 - add support for F55 sensor tuning

2016-10-20 Thread Nick Dyer
On Mon, Oct 17, 2016 at 02:30:08PM -0700, Guenter Roeck wrote: > On Fri, Sep 30, 2016 at 08:22:47PM -0700, Guenter Roeck wrote: > > Sensor tuning support is needed to determine the number of enabled > > tx and rx electrodes for use in F54 functions. > > > > The number of enabled electrodes is not

Re: [-next, 1/2] Input: synaptics-rmi4 - add support for F55 sensor tuning

2016-10-20 Thread Nick Dyer
On Mon, Oct 17, 2016 at 02:30:08PM -0700, Guenter Roeck wrote: > On Fri, Sep 30, 2016 at 08:22:47PM -0700, Guenter Roeck wrote: > > Sensor tuning support is needed to determine the number of enabled > > tx and rx electrodes for use in F54 functions. > > > > The number of enabled electrodes is not

[PATCH v4 0/7]

2016-10-18 Thread Nick Dyer
Hi- Apologies, I think I hit send too soon on the previous email. Please find attached patches to add F34 firmware update to the RMI4 driver. Changes in v4: - Add support for v7 bootloaders and fix numerous issues - Add sysfs attributes for retrieving various hardware IDs - Add a couple of

[PATCH v4 0/7]

2016-10-18 Thread Nick Dyer
Hi- Apologies, I think I hit send too soon on the previous email. Please find attached patches to add F34 firmware update to the RMI4 driver. Changes in v4: - Add support for v7 bootloaders and fix numerous issues - Add sysfs attributes for retrieving various hardware IDs - Add a couple of

[PATCH v4 6/7] Input: synaptics-rmi4 - add sysfs interfaces for hardware IDs

2016-10-18 Thread Nick Dyer
Signed-off-by: Nick Dyer <n...@shmanahar.org> --- drivers/input/rmi4/rmi_driver.c | 2 +- drivers/input/rmi4/rmi_driver.h | 5 +- drivers/input/rmi4/rmi_f01.c| 23 - drivers/input/rmi4/rmi_f34.c| 112 4 files changed, 139 inse

[PATCH v4 4/7] Input: synaptics-rmi4 - add support for F34 V7 bootloader

2016-10-18 Thread Nick Dyer
Port firmware update code from Samsung Galaxy S7 driver into mainline framework. This patch has been tested on Synaptics S7813. Signed-off-by: Nick Dyer <n...@shmanahar.org> --- drivers/input/rmi4/Makefile |2 +- drivers/input/rmi4/rmi_driver.c | 56 +- drivers/input/rmi4/rmi

[PATCH v4 6/7] Input: synaptics-rmi4 - add sysfs interfaces for hardware IDs

2016-10-18 Thread Nick Dyer
Signed-off-by: Nick Dyer --- drivers/input/rmi4/rmi_driver.c | 2 +- drivers/input/rmi4/rmi_driver.h | 5 +- drivers/input/rmi4/rmi_f01.c| 23 - drivers/input/rmi4/rmi_f34.c| 112 4 files changed, 139 insertions(+), 3 deletions

[PATCH v4 4/7] Input: synaptics-rmi4 - add support for F34 V7 bootloader

2016-10-18 Thread Nick Dyer
Port firmware update code from Samsung Galaxy S7 driver into mainline framework. This patch has been tested on Synaptics S7813. Signed-off-by: Nick Dyer --- drivers/input/rmi4/Makefile |2 +- drivers/input/rmi4/rmi_driver.c | 56 +- drivers/input/rmi4/rmi_f34.c| 146

[PATCH v4 3/7] Input: synaptics-rmi4 - add support for F34 device reflash

2016-10-18 Thread Nick Dyer
Add support for updating firmware, triggered by a sysfs attribute. This patch has been tested on Synaptics S7300. Signed-off-by: Nick Dyer <n...@shmanahar.org> Tested-by: Chris Healy <cphe...@gmail.com> --- drivers/input/rmi4/Kconfig | 11 + drivers/input/rmi4/Makefi

[PATCH v4 5/7] Input: synaptics-rmi4 - add sysfs attribute update_fw_status

2016-10-18 Thread Nick Dyer
The status is the percentage complete, or once complete, zero for success or a negative return code. Signed-off-by: Nick Dyer <n...@shmanahar.org> --- drivers/input/rmi4/rmi_f34.c | 34 ++ drivers/input/rmi4/rmi_f34.h | 4 drivers/input/rmi4/rmi_f

[PATCH v4 3/7] Input: synaptics-rmi4 - add support for F34 device reflash

2016-10-18 Thread Nick Dyer
Add support for updating firmware, triggered by a sysfs attribute. This patch has been tested on Synaptics S7300. Signed-off-by: Nick Dyer Tested-by: Chris Healy --- drivers/input/rmi4/Kconfig | 11 + drivers/input/rmi4/Makefile | 1 + drivers/input/rmi4/rmi_bus.c| 3

[PATCH v4 5/7] Input: synaptics-rmi4 - add sysfs attribute update_fw_status

2016-10-18 Thread Nick Dyer
The status is the percentage complete, or once complete, zero for success or a negative return code. Signed-off-by: Nick Dyer --- drivers/input/rmi4/rmi_f34.c | 34 ++ drivers/input/rmi4/rmi_f34.h | 4 drivers/input/rmi4/rmi_f34v7.c | 14

[PATCH v4 2/7] Input: synaptics-rmi4 - add a couple of debug lines

2016-10-18 Thread Nick Dyer
Signed-off-by: Nick Dyer <n...@shmanahar.org> --- drivers/input/rmi4/rmi_bus.c| 3 +++ drivers/input/rmi4/rmi_driver.c | 1 + 2 files changed, 4 insertions(+) diff --git a/drivers/input/rmi4/rmi_bus.c b/drivers/input/rmi4/rmi_bus.c index ef8c747..3c6a1b5 100644 --- a/drivers/inpu

[PATCH v4 2/7] Input: synaptics-rmi4 - add a couple of debug lines

2016-10-18 Thread Nick Dyer
Signed-off-by: Nick Dyer --- drivers/input/rmi4/rmi_bus.c| 3 +++ drivers/input/rmi4/rmi_driver.c | 1 + 2 files changed, 4 insertions(+) diff --git a/drivers/input/rmi4/rmi_bus.c b/drivers/input/rmi4/rmi_bus.c index ef8c747..3c6a1b5 100644 --- a/drivers/input/rmi4/rmi_bus.c +++ b/drivers

[PATCH v4 7/7] Input: synaptics-rmi4 - add package_id sysfs attribute

2016-10-18 Thread Nick Dyer
Signed-off-by: Nick Dyer <n...@shmanahar.org> --- drivers/input/rmi4/rmi_driver.h | 1 + drivers/input/rmi4/rmi_f01.c| 24 +++- drivers/input/rmi4/rmi_f34.c| 16 3 files changed, 40 insertions(+), 1 deletion(-) diff --git a/drivers/inpu

[PATCH v4 1/7] Input: synaptics-rmi4 - factor out functions from probe

2016-10-18 Thread Nick Dyer
Signed-off-by: Nick Dyer <n...@shmanahar.org> Signed-off-by: Benjamin Tissoires <benjamin.tissoi...@redhat.com> --- drivers/input/rmi4/rmi_driver.c | 139 +--- 1 file changed, 86 insertions(+), 53 deletions(-) diff --git a/drivers/input/rmi4/rm

[PATCH v4 7/7] Input: synaptics-rmi4 - add package_id sysfs attribute

2016-10-18 Thread Nick Dyer
Signed-off-by: Nick Dyer --- drivers/input/rmi4/rmi_driver.h | 1 + drivers/input/rmi4/rmi_f01.c| 24 +++- drivers/input/rmi4/rmi_f34.c| 16 3 files changed, 40 insertions(+), 1 deletion(-) diff --git a/drivers/input/rmi4/rmi_driver.h b/drivers

[PATCH v4 1/7] Input: synaptics-rmi4 - factor out functions from probe

2016-10-18 Thread Nick Dyer
Signed-off-by: Nick Dyer Signed-off-by: Benjamin Tissoires --- drivers/input/rmi4/rmi_driver.c | 139 +--- 1 file changed, 86 insertions(+), 53 deletions(-) diff --git a/drivers/input/rmi4/rmi_driver.c b/drivers/input/rmi4/rmi_driver.c index 4a88312..63c9e22

Re: [PATCH v3 2/2] Input: synaptics-rmi4 - add support for F34 device reflash

2016-10-13 Thread Nick Dyer
On Thu, Oct 13, 2016 at 03:52:45PM +0200, Benjamin Tissoires wrote: > > > You could basically export rmi_fn_reset() which would call > > > rmi_free_function_list(), rmi_scan_pdt (if initial reset), > > > rmi_probe_interrupts() and rmi_init_functions, and this would allow you > > > to have all this

Re: [PATCH v3 2/2] Input: synaptics-rmi4 - add support for F34 device reflash

2016-10-13 Thread Nick Dyer
On Thu, Oct 13, 2016 at 03:52:45PM +0200, Benjamin Tissoires wrote: > > > You could basically export rmi_fn_reset() which would call > > > rmi_free_function_list(), rmi_scan_pdt (if initial reset), > > > rmi_probe_interrupts() and rmi_init_functions, and this would allow you > > > to have all this

Re: [PATCH v3 2/2] Input: synaptics-rmi4 - add support for F34 device reflash

2016-10-12 Thread Nick Dyer
Hi Benjamin- Thanks for the review, I've answered in line. On Mon, Oct 10, 2016 at 03:48:07PM +0200, Benjamin Tissoires wrote: > On Sep 20 2016 or thereabouts, Nick Dyer wrote: > > Signed-off-by: Nick Dyer <n...@shmanahar.org> > > Tested-by: Chris Healy <cphe...@gmail.c

Re: [PATCH v3 2/2] Input: synaptics-rmi4 - add support for F34 device reflash

2016-10-12 Thread Nick Dyer
Hi Benjamin- Thanks for the review, I've answered in line. On Mon, Oct 10, 2016 at 03:48:07PM +0200, Benjamin Tissoires wrote: > On Sep 20 2016 or thereabouts, Nick Dyer wrote: > > Signed-off-by: Nick Dyer > > Tested-by: Chris Healy > > --- > > drivers/in

[PATCH v3 0/2] Input: synaptics-rmi4 - F34 device reflash support

2016-09-20 Thread Nick Dyer
Hi- Please find attached patches to add F34 firmware update to the RMI4 driver. Git tree here: https://github.com/ndyer/linux/commits/synaptics-fw-update-v3-2016-09-20 Changes in v3: - Only attempt to flash on F34 V0 (later versions have different register map) Changes in v2: - Resolved

[PATCH v3 1/2] Input: synaptics-rmi4 - factor out functions from probe

2016-09-20 Thread Nick Dyer
Signed-off-by: Nick Dyer <n...@shmanahar.org> --- drivers/input/rmi4/rmi_driver.c | 139 +--- 1 file changed, 86 insertions(+), 53 deletions(-) diff --git a/drivers/input/rmi4/rmi_driver.c b/drivers/input/rmi4/rmi_driver.c index c83bce8..f17bfe0

[PATCH v3 0/2] Input: synaptics-rmi4 - F34 device reflash support

2016-09-20 Thread Nick Dyer
Hi- Please find attached patches to add F34 firmware update to the RMI4 driver. Git tree here: https://github.com/ndyer/linux/commits/synaptics-fw-update-v3-2016-09-20 Changes in v3: - Only attempt to flash on F34 V0 (later versions have different register map) Changes in v2: - Resolved

[PATCH v3 1/2] Input: synaptics-rmi4 - factor out functions from probe

2016-09-20 Thread Nick Dyer
Signed-off-by: Nick Dyer --- drivers/input/rmi4/rmi_driver.c | 139 +--- 1 file changed, 86 insertions(+), 53 deletions(-) diff --git a/drivers/input/rmi4/rmi_driver.c b/drivers/input/rmi4/rmi_driver.c index c83bce8..f17bfe0 100644 --- a/drivers/input/rmi4

[PATCH v3 2/2] Input: synaptics-rmi4 - add support for F34 device reflash

2016-09-20 Thread Nick Dyer
Signed-off-by: Nick Dyer <n...@shmanahar.org> Tested-by: Chris Healy <cphe...@gmail.com> --- drivers/input/rmi4/Kconfig | 11 + drivers/input/rmi4/Makefile | 1 + drivers/input/rmi4/rmi_bus.c| 3 + drivers/input/rmi4/rmi_driver.c | 161 ++- driver

[PATCH v3 2/2] Input: synaptics-rmi4 - add support for F34 device reflash

2016-09-20 Thread Nick Dyer
Signed-off-by: Nick Dyer Tested-by: Chris Healy --- drivers/input/rmi4/Kconfig | 11 + drivers/input/rmi4/Makefile | 1 + drivers/input/rmi4/rmi_bus.c| 3 + drivers/input/rmi4/rmi_driver.c | 161 ++- drivers/input/rmi4/rmi_driver.h | 7 + drivers/input/rmi4

Re: [PATCH 2/2] [media] Input: synaptics-rmi4: disallow impossible configuration

2016-09-15 Thread Nick Dyer
nd Bergmann <a...@arndb.de> > Fixes: 3a762dbd5347 ("[media] Input: synaptics-rmi4 - add support for F54 > diagnostics") Acked-by: Nick Dyer <n...@shmanahar.org> > --- > drivers/input/rmi4/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > &

Re: [PATCH 2/2] [media] Input: synaptics-rmi4: disallow impossible configuration

2016-09-15 Thread Nick Dyer
d Bergmann > Fixes: 3a762dbd5347 ("[media] Input: synaptics-rmi4 - add support for F54 > diagnostics") Acked-by: Nick Dyer > --- > drivers/input/rmi4/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/rmi4/Kconfig b/d

[PATCH] Input: v4l-touch - add copyright lines

2016-09-15 Thread Nick Dyer
Hi Hans- Please could you apply this patch to your media_tree/touch branch before it goes to v4.9 if possible. Thanks Add copyright lines for Zodiac who paid for the V4L touch work. Signed-off-by: Nick Dyer <n...@shmanahar.org> --- drivers/input/rmi4/rmi_f54.c | 1 + d

[PATCH] Input: v4l-touch - add copyright lines

2016-09-15 Thread Nick Dyer
Hi Hans- Please could you apply this patch to your media_tree/touch branch before it goes to v4.9 if possible. Thanks Add copyright lines for Zodiac who paid for the V4L touch work. Signed-off-by: Nick Dyer --- drivers/input/rmi4/rmi_f54.c | 1 + drivers/input/touchscreen

Re: [PATCH 1/2] [media] Input: atmel_mxt: disallow impossible configuration

2016-09-15 Thread Nick Dyer
l it. > > Signed-off-by: Arnd Bergmann <a...@arndb.de> > Fixes: ecfdd7e2660e ("[media] Input: atmel_mxt_ts - output diagnostic debug > via V4L2 device") Acked-by: Nick Dyer <n...@shmanahar.org> > --- > drivers/input/touchscreen/Kconfig | 3 ++- > 1 file chan

Re: [PATCH 1/2] [media] Input: atmel_mxt: disallow impossible configuration

2016-09-15 Thread Nick Dyer
ll it. > > Signed-off-by: Arnd Bergmann > Fixes: ecfdd7e2660e ("[media] Input: atmel_mxt_ts - output diagnostic debug > via V4L2 device") Acked-by: Nick Dyer > --- > drivers/input/touchscreen/Kconfig | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >

[PATCH v2] Documentation: add support for V4L touch devices

2016-08-14 Thread Nick Dyer
[v2: Fix minor issues and document V4L2_INPUT_TYPE_TOUCH and V4L2_CAP_TOUCH] Signed-off-by: Nick Dyer <n...@shmanahar.org> --- Documentation/media/uapi/mediactl/media-types.rst | 24 +++-- Documentation/media/uapi/v4l/dev-touch.rst| 56 +++ Documentation/media/ua

[PATCH v2] Documentation: add support for V4L touch devices

2016-08-14 Thread Nick Dyer
[v2: Fix minor issues and document V4L2_INPUT_TYPE_TOUCH and V4L2_CAP_TOUCH] Signed-off-by: Nick Dyer --- Documentation/media/uapi/mediactl/media-types.rst | 24 +++-- Documentation/media/uapi/v4l/dev-touch.rst| 56 +++ Documentation/media/uapi/v4l/devices.rst | 1

Re: [PATCH v8 10/10] Input: sur40 - use new V4L2 touch input type

2016-08-12 Thread Nick Dyer
Signed-off-by: Nick Dyer <n...@shmanahar.org> On 12 August 2016 10:41:08 BST, Hans Verkuil <hverk...@xs4all.nl> wrote: >Hi Nick, > >On 07/18/2016 11:10 PM, Nick Dyer wrote: >> Support both V4L2_TCH_FMT_TU08 and V4L2_PIX_FMT_GREY for backwards >> compatibilit

Re: [PATCH v8 10/10] Input: sur40 - use new V4L2 touch input type

2016-08-12 Thread Nick Dyer
Signed-off-by: Nick Dyer On 12 August 2016 10:41:08 BST, Hans Verkuil wrote: >Hi Nick, > >On 07/18/2016 11:10 PM, Nick Dyer wrote: >> Support both V4L2_TCH_FMT_TU08 and V4L2_PIX_FMT_GREY for backwards >> compatibility. >> >> Note: I have not teste

[PATCH v8 08/10] Input: atmel_mxt_ts - add support for reference data

2016-07-18 Thread Nick Dyer
There are different datatypes available from a maXTouch chip. Add support to retrieve reference data as well. Signed-off-by: Nick Dyer <n...@shmanahar.org> --- drivers/input/touchscreen/atmel_mxt_ts.c | 57 ++ 1 file changed, 51 insertions(+), 6 deletions(-)

[PATCH v8 02/10] v4l2-core: Add support for touch devices

2016-07-18 Thread Nick Dyer
touch data - V4L2_TCH_FMT_TU08 for unsigned 8-bit touch data This support will be used by: - Atmel maXTouch (atmel_mxt_ts) - Synaptics RMI4. - sur40 Signed-off-by: Nick Dyer <n...@shmanahar.org> Tested-By: Chris Healy <cphe...@gmail.com> --- drivers/media/media-entity.c |2

[PATCH] v4l2-compliance: Changes to support touch sensors

2016-07-18 Thread Nick Dyer
Signed-off-by: Nick Dyer <n...@shmanahar.org> --- utils/v4l2-compliance/v4l2-compliance.cpp| 51 +- utils/v4l2-compliance/v4l2-compliance.h |1 + utils/v4l2-compliance/v4l2-test-input-output.cpp |4 +- 3 files changed, 53 insertions(+), 3 del

[PATCH v8 08/10] Input: atmel_mxt_ts - add support for reference data

2016-07-18 Thread Nick Dyer
There are different datatypes available from a maXTouch chip. Add support to retrieve reference data as well. Signed-off-by: Nick Dyer --- drivers/input/touchscreen/atmel_mxt_ts.c | 57 ++ 1 file changed, 51 insertions(+), 6 deletions(-) diff --git a/drivers/input

[PATCH v8 02/10] v4l2-core: Add support for touch devices

2016-07-18 Thread Nick Dyer
touch data - V4L2_TCH_FMT_TU08 for unsigned 8-bit touch data This support will be used by: - Atmel maXTouch (atmel_mxt_ts) - Synaptics RMI4. - sur40 Signed-off-by: Nick Dyer Tested-By: Chris Healy --- drivers/media/media-entity.c |2 ++ drivers/media/v4l2-core/v4l2-dev.c | 16

[PATCH] v4l2-compliance: Changes to support touch sensors

2016-07-18 Thread Nick Dyer
Signed-off-by: Nick Dyer --- utils/v4l2-compliance/v4l2-compliance.cpp| 51 +- utils/v4l2-compliance/v4l2-compliance.h |1 + utils/v4l2-compliance/v4l2-test-input-output.cpp |4 +- 3 files changed, 53 insertions(+), 3 deletions(-) diff --git

[PATCH v8 07/10] Input: atmel_mxt_ts - add diagnostic data support for mXT1386

2016-07-18 Thread Nick Dyer
The mXT1386 family of chips have a different architecture which splits the diagnostic data into 3 columns. Signed-off-by: Nick Dyer <n...@shmanahar.org> --- drivers/input/touchscreen/atmel_mxt_ts.c | 31 +++--- 1 file changed, 28 insertions(+), 3 deletions(-)

[PATCH v8 0/10] Output raw touch data via V4L2

2016-07-18 Thread Nick Dyer
This is a series of patches to add output of raw touch diagnostic data via V4L2 to the Atmel maXTouch and Synaptics RMI4 drivers. It's a rewrite of the previous implementation which output via debugfs: it now uses a V4L2 device in a similar way to the sur40 driver. We have a utility which can

[PATCH v8 07/10] Input: atmel_mxt_ts - add diagnostic data support for mXT1386

2016-07-18 Thread Nick Dyer
The mXT1386 family of chips have a different architecture which splits the diagnostic data into 3 columns. Signed-off-by: Nick Dyer --- drivers/input/touchscreen/atmel_mxt_ts.c | 31 +++--- 1 file changed, 28 insertions(+), 3 deletions(-) diff --git a/drivers/input

[PATCH v8 0/10] Output raw touch data via V4L2

2016-07-18 Thread Nick Dyer
This is a series of patches to add output of raw touch diagnostic data via V4L2 to the Atmel maXTouch and Synaptics RMI4 drivers. It's a rewrite of the previous implementation which output via debugfs: it now uses a V4L2 device in a similar way to the sur40 driver. We have a utility which can

[PATCH v8 10/10] Input: sur40 - use new V4L2 touch input type

2016-07-18 Thread Nick Dyer
Support both V4L2_TCH_FMT_TU08 and V4L2_PIX_FMT_GREY for backwards compatibility. Note: I have not tested these changes (I have no access to the hardware) so not signing off. --- drivers/input/touchscreen/sur40.c | 122 +++-- 1 file changed, 89 insertions(+), 33

[PATCH v8 03/10] Input: atmel_mxt_ts - add support for T37 diagnostic data

2016-07-18 Thread Nick Dyer
Atmel maXTouch devices have a T37 object which can be used to read raw touch deltas from the device. This consists of an array of 16-bit integers, one for each node on the touchscreen matrix. Signed-off-by: Nick Dyer <n...@shmanahar.org> --- drivers/input/touchscreen/Kconfig

[PATCH v8 01/10] Input: atmel_mxt_ts - update MAINTAINERS email address

2016-07-18 Thread Nick Dyer
I'm leaving ITDev, so change to my personal email. My understanding is that someone at Atmel will take this on once their takeover by Microchip has settled down. Signed-off-by: Nick Dyer <n...@shmanahar.org> --- MAINTAINERS |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

[PATCH v8 01/10] Input: atmel_mxt_ts - update MAINTAINERS email address

2016-07-18 Thread Nick Dyer
I'm leaving ITDev, so change to my personal email. My understanding is that someone at Atmel will take this on once their takeover by Microchip has settled down. Signed-off-by: Nick Dyer --- MAINTAINERS |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/MAINTAINERS b

[PATCH v8 03/10] Input: atmel_mxt_ts - add support for T37 diagnostic data

2016-07-18 Thread Nick Dyer
Atmel maXTouch devices have a T37 object which can be used to read raw touch deltas from the device. This consists of an array of 16-bit integers, one for each node on the touchscreen matrix. Signed-off-by: Nick Dyer --- drivers/input/touchscreen/Kconfig|6 ++ drivers/input

[PATCH v8 10/10] Input: sur40 - use new V4L2 touch input type

2016-07-18 Thread Nick Dyer
Support both V4L2_TCH_FMT_TU08 and V4L2_PIX_FMT_GREY for backwards compatibility. Note: I have not tested these changes (I have no access to the hardware) so not signing off. --- drivers/input/touchscreen/sur40.c | 122 +++-- 1 file changed, 89 insertions(+), 33

[PATCH v8 06/10] Input: atmel_mxt_ts - handle diagnostic data orientation

2016-07-18 Thread Nick Dyer
Invert the diagnostic data to match the orientation of the input device. Signed-off-by: Nick Dyer <n...@shmanahar.org> --- drivers/input/touchscreen/atmel_mxt_ts.c | 26 +- 1 file changed, 21 insertions(+), 5 deletions(-) diff --git a/drivers/input/touch

[PATCH v8 06/10] Input: atmel_mxt_ts - handle diagnostic data orientation

2016-07-18 Thread Nick Dyer
Invert the diagnostic data to match the orientation of the input device. Signed-off-by: Nick Dyer --- drivers/input/touchscreen/atmel_mxt_ts.c | 26 +- 1 file changed, 21 insertions(+), 5 deletions(-) diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c b/drivers

[PATCH v8 09/10] Input: synaptics-rmi4 - add support for F54 diagnostics

2016-07-18 Thread Nick Dyer
Function 54 implements access to various RMI4 diagnostic features. This patch adds support for retrieving this data. It registers a V4L2 device to output the data to user space. Signed-off-by: Nick Dyer <n...@shmanahar.org> Tested-by: Andrew Duggan <adug...@synaptics.com> Tested-by:

[PATCH v8 09/10] Input: synaptics-rmi4 - add support for F54 diagnostics

2016-07-18 Thread Nick Dyer
Function 54 implements access to various RMI4 diagnostic features. This patch adds support for retrieving this data. It registers a V4L2 device to output the data to user space. Signed-off-by: Nick Dyer Tested-by: Andrew Duggan Tested-by: Chris Healy --- drivers/input/rmi4/Kconfig

[PATCH v8 05/10] Input: atmel_mxt_ts - read touchscreen size

2016-07-18 Thread Nick Dyer
The touchscreen may have a margin where not all the matrix is used. Read the parameters from T9 and T100 and take account of the difference. Note: this does not read the XORIGIN/YORIGIN fields so it assumes that the touchscreen starts at (0,0) Signed-off-by: Nick Dyer <n...@shmanahar.

[PATCH v8 05/10] Input: atmel_mxt_ts - read touchscreen size

2016-07-18 Thread Nick Dyer
The touchscreen may have a margin where not all the matrix is used. Read the parameters from T9 and T100 and take account of the difference. Note: this does not read the XORIGIN/YORIGIN fields so it assumes that the touchscreen starts at (0,0) Signed-off-by: Nick Dyer --- drivers/input

[PATCH v8 04/10] Input: atmel_mxt_ts - output diagnostic debug via V4L2 device

2016-07-18 Thread Nick Dyer
Register a video device to output T37 diagnostic data. Signed-off-by: Nick Dyer <n...@shmanahar.org> --- drivers/input/touchscreen/Kconfig|6 +- drivers/input/touchscreen/atmel_mxt_ts.c | 245 ++ 2 files changed, 249 insertions(+), 2 deletions(-)

[PATCH v8 04/10] Input: atmel_mxt_ts - output diagnostic debug via V4L2 device

2016-07-18 Thread Nick Dyer
Register a video device to output T37 diagnostic data. Signed-off-by: Nick Dyer --- drivers/input/touchscreen/Kconfig|6 +- drivers/input/touchscreen/atmel_mxt_ts.c | 245 ++ 2 files changed, 249 insertions(+), 2 deletions(-) diff --git a/drivers/input

[PATCH v2 1/2] Input: synaptics-rmi4 - factor out functions from probe

2016-07-08 Thread Nick Dyer
--- drivers/input/rmi4/rmi_driver.c | 139 --- 1 file changed, 86 insertions(+), 53 deletions(-) diff --git a/drivers/input/rmi4/rmi_driver.c b/drivers/input/rmi4/rmi_driver.c index faa295e..543cf7a 100644 --- a/drivers/input/rmi4/rmi_driver.c +++

[PATCH v2 2/2] Input: synaptics-rmi4 - add support for F34 device reflash

2016-07-08 Thread Nick Dyer
Signed-off-by: Nick Dyer <n...@shmanahar.org> Tested-by: Chris Healy <cphe...@gmail.com> --- drivers/input/rmi4/Kconfig | 11 + drivers/input/rmi4/Makefile |1 + drivers/input/rmi4/rmi_bus.c|3 + drivers/input/rmi4/rmi_driver.c | 157 +- driver

[PATCH v2 0/2] Input: synaptics-rmi4 - F34 device reflash support

2016-07-08 Thread Nick Dyer
Hi Dmitry/Andrew- Please find attached patches to add F34 firmware update to the RMI4 driver. Git tree here: https://github.com/ndyer/linux/commits/synaptics-fw-update-v2-2016-07-08 Changes in v2: - Resolved reliability issues with locking and teardown/re-probe - Add #ifdefs for CONFIG_RMI4_F34

[PATCH v2 1/2] Input: synaptics-rmi4 - factor out functions from probe

2016-07-08 Thread Nick Dyer
--- drivers/input/rmi4/rmi_driver.c | 139 --- 1 file changed, 86 insertions(+), 53 deletions(-) diff --git a/drivers/input/rmi4/rmi_driver.c b/drivers/input/rmi4/rmi_driver.c index faa295e..543cf7a 100644 --- a/drivers/input/rmi4/rmi_driver.c +++

[PATCH v2 2/2] Input: synaptics-rmi4 - add support for F34 device reflash

2016-07-08 Thread Nick Dyer
Signed-off-by: Nick Dyer Tested-by: Chris Healy --- drivers/input/rmi4/Kconfig | 11 + drivers/input/rmi4/Makefile |1 + drivers/input/rmi4/rmi_bus.c|3 + drivers/input/rmi4/rmi_driver.c | 157 +- drivers/input/rmi4/rmi_driver.h |6 + drivers/input/rmi4

[PATCH v2 0/2] Input: synaptics-rmi4 - F34 device reflash support

2016-07-08 Thread Nick Dyer
Hi Dmitry/Andrew- Please find attached patches to add F34 firmware update to the RMI4 driver. Git tree here: https://github.com/ndyer/linux/commits/synaptics-fw-update-v2-2016-07-08 Changes in v2: - Resolved reliability issues with locking and teardown/re-probe - Add #ifdefs for CONFIG_RMI4_F34

[PATCH v7 07/11] Input: atmel_mxt_ts - handle diagnostic data orientation

2016-07-08 Thread Nick Dyer
Invert the diagnostic data to match the orientation of the input device. Signed-off-by: Nick Dyer <n...@shmanahar.org> --- drivers/input/touchscreen/atmel_mxt_ts.c | 26 +- 1 file changed, 21 insertions(+), 5 deletions(-) diff --git a/drivers/input/touch

[PATCH v7 07/11] Input: atmel_mxt_ts - handle diagnostic data orientation

2016-07-08 Thread Nick Dyer
Invert the diagnostic data to match the orientation of the input device. Signed-off-by: Nick Dyer --- drivers/input/touchscreen/atmel_mxt_ts.c | 26 +- 1 file changed, 21 insertions(+), 5 deletions(-) diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c b/drivers

[PATCH v7 01/11] Input: atmel_mxt_ts - update MAINTAINERS email address

2016-07-08 Thread Nick Dyer
I'm leaving ITDev, so change to my personal email. My understanding is that someone at Atmel will take this on once their takeover by Microchip has settled down. Signed-off-by: Nick Dyer <n...@shmanahar.org> --- MAINTAINERS |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

[PATCH] v4l2-compliance: Changes to support touch sensors

2016-07-08 Thread Nick Dyer
Signed-off-by: Nick Dyer <n...@shmanahar.org> --- utils/v4l2-compliance/v4l2-compliance.cpp| 51 +- utils/v4l2-compliance/v4l2-compliance.h |1 + utils/v4l2-compliance/v4l2-test-input-output.cpp |4 +- 3 files changed, 53 insertions(+), 3 del

[PATCH] v4l2-compliance: Changes to support touch sensors

2016-07-08 Thread Nick Dyer
Signed-off-by: Nick Dyer --- utils/v4l2-compliance/v4l2-compliance.cpp| 51 +- utils/v4l2-compliance/v4l2-compliance.h |1 + utils/v4l2-compliance/v4l2-test-input-output.cpp |4 +- 3 files changed, 53 insertions(+), 3 deletions(-) diff --git

[PATCH v7 01/11] Input: atmel_mxt_ts - update MAINTAINERS email address

2016-07-08 Thread Nick Dyer
I'm leaving ITDev, so change to my personal email. My understanding is that someone at Atmel will take this on once their takeover by Microchip has settled down. Signed-off-by: Nick Dyer --- MAINTAINERS |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/MAINTAINERS b

<    1   2   3   4   5   6   7   8   9   10   >