Re: [BUG?] OOM with large cache....(x86_64, 2.6.24-rc3-git1, nohz)

2007-11-20 Thread Nick Piggin
On Tuesday 20 November 2007 18:26, Nick Piggin wrote: > On Tuesday 20 November 2007 16:46, Ingo Molnar wrote: > > * Nick Piggin <[EMAIL PROTECTED]> wrote: > > > Unfortunately, we don't show NR_ANON_PAGES in these stats, [...] > > > > sidenote:

Re: CONFIG_IRQBALANCE for 64-bit x86 ?

2007-11-19 Thread Nick Piggin
On Tuesday 20 November 2007 16:37, Arjan van de Ven wrote: > On Tue, 20 Nov 2007 15:17:15 +1100 > > For that matter, I'd like to know why it has been decided that the > > best place for IRQ balancing is in userspace. It should be in kernel > > IMO, and it would probably allow better power saving,

Re: [BUG?] OOM with large cache....(x86_64, 2.6.24-rc3-git1, nohz)

2007-11-19 Thread Nick Piggin
On Tuesday 20 November 2007 16:46, Ingo Molnar wrote: > * Nick Piggin <[EMAIL PROTECTED]> wrote: > > Unfortunately, we don't show NR_ANON_PAGES in these stats, [...] > > sidenote: the way i combat these missing pieces of instrumentation in > the scheduler is to ad

Re: CONFIG_IRQBALANCE for 64-bit x86 ?

2007-11-19 Thread Nick Piggin
On Tuesday 20 November 2007 15:37, Adrian Bunk wrote: > On Tue, Nov 20, 2007 at 05:29:29AM +0100, Willy Tarreau wrote: > > Agreed. When userspace has something to do with the way IRQs are > > delivered, it's going to smell as bad as micro-kernels... > > The next step to a micro-kernel would then b

[patch] vt: bitlock fix

2007-11-19 Thread Nick Piggin
Don't know who maintains vt.c, but Antonino's name comes up regularly ;) -- vt is missing a memory barrier to close the critical section. Use a real spinlock for this. Signed-off-by: Nick Piggin <[EMAIL PROTECTED]> --- Index: linux-2.6/d

Re: CONFIG_IRQBALANCE for 64-bit x86 ?

2007-11-19 Thread Nick Piggin
On Tuesday 20 November 2007 15:12, Mark Lord wrote: > On 32-bit x86, we have CONFIG_IRQBALANCE available, > but not on 64-bit x86. Why not? > > I ask, because this feature seems almost essential to obtaining > reasonable latencies during heavy I/O with fast devices. > > My 32-bit Core2Duo MythTV b

Re: [BUG?] OOM with large cache....(x86_64, 2.6.24-rc3-git1, nohz)

2007-11-19 Thread Nick Piggin
On Tuesday 20 November 2007 11:59, Ian Kumlien wrote: > Hi, > > I have had this before and sent a mail about it. > > It seems like the diskcache is still in use and is never shrunk. This > happened with a odd load though, trackerd started indexing a bit late > and the other workload which is a larg

Re: [rfc 08/45] cpu alloc: x86 support

2007-11-19 Thread Nick Piggin
On Tuesday 20 November 2007 13:02, Christoph Lameter wrote: > On Mon, 19 Nov 2007, H. Peter Anvin wrote: > > You're making the assumption here that NUMA = large number of CPUs. This > > assumption is flat-out wrong. > > Well maybe. Usually one gets to NUMA because the hardware gets too big to > be

Re: [PATCH] radix_tree.h trivial comment correction

2007-11-19 Thread Nick Piggin
On Mon, Nov 19, 2007 at 11:17:48AM -0800, Tim Pepper wrote: > There is an unmatched parenthesis in the locking commentary of radix_tree.h > which is trivially fixed by the patch below. > > Signed-off-by: Tim Pepper <[EMAIL PROTECTED]> > Cc: Nick Piggin <[EMAIL PROTECTED]

Re: [rfc 08/45] cpu alloc: x86 support

2007-11-19 Thread Nick Piggin
On Tuesday 20 November 2007 13:02, Christoph Lameter wrote: > On Mon, 19 Nov 2007, H. Peter Anvin wrote: > > You're making the assumption here that NUMA = large number of CPUs. This > > assumption is flat-out wrong. > > Well maybe. Usually one gets to NUMA because the hardware gets too big to > be

Re: [patch] slob: fix memory corruption

2007-11-15 Thread Nick Piggin
On Thursday 15 November 2007 23:48, Ingo Molnar wrote: > > From: Nick Piggin <[EMAIL PROTECTED]> > > > > - if (free_slob_pages.next != prev->next) > > + if (prev != free_slob_pages.prev && > > +

Re: [bug] SLOB crash, 2.6.24-rc2

2007-11-15 Thread Nick Piggin
On Thursday 15 November 2007 22:28, Ingo Molnar wrote: > * Nick Piggin <[EMAIL PROTECTED]> wrote: > > Anyway, I'm really happy to see you're testing and using SLOB upstream > > > > :) Is there any particular reason that you're using it? > > i som

Re: [bug] SLOB crash, 2.6.24-rc2

2007-11-15 Thread Nick Piggin
icular reason that you're using it? Thanks, Nick Previously, it would be possible for prev->next to point to &free_slob_pages, and thus we would try to move a list onto itself, and bad things would happen. It seems a bit hairy to be doing list operations with the list marker as an

Re: [patch 2.6.24-rc2 1/3] generic gpio -- gpio_chip support

2007-11-15 Thread Nick Piggin
On Thursday 15 November 2007 19:17, David Brownell wrote: > On Wednesday 14 November 2007, Nick Piggin wrote: > > > > > All this does is prevent constant and needless checking for > > > > > "do you want to preempt me now?" "now?" "now?

Re: [patch 2.6.24-rc2 1/3] generic gpio -- gpio_chip support

2007-11-15 Thread Nick Piggin
On Thursday 15 November 2007 06:19, Nick Piggin wrote: > On Thursday 15 November 2007 19:17, David Brownell wrote: > > On Wednesday 14 November 2007, Nick Piggin wrote: > > > > > > All this does is prevent constant and needless checking for > > > > > >

Re: [patch 2.6.24-rc2 1/3] generic gpio -- gpio_chip support

2007-11-15 Thread Nick Piggin
On Thursday 15 November 2007 17:28, David Brownell wrote: > On Tuesday 13 November 2007, Nick Piggin wrote: > > > All this does is prevent constant and needless checking for > > > "do you want to preempt me now?" "now?" "now?" in "

Re: 2.6.24-rc2: Network commit causes SLUB performance regression with tbench

2007-11-14 Thread Nick Piggin
On Thursday 15 November 2007 12:11, Herbert Xu wrote: > On Wed, Nov 14, 2007 at 05:03:25PM -0800, Christoph Lameter wrote: > > Well this is likely the result of the SLUB regression. If you allocate an > > order 1 page then the zone locks need to be taken. SLAB queues the a Yeah, it appears this is

Re: 2.6.24-rc2: Network commit causes SLUB performance regression with tbench

2007-11-14 Thread Nick Piggin
On Thursday 15 November 2007 10:46, David Miller wrote: > From: Herbert Xu <[EMAIL PROTECTED]> > Date: Wed, 14 Nov 2007 19:48:44 +0800 > > Signed-off-by: Herbert Xu <[EMAIL PROTECTED]> > > Applied and I'll queue it up for -stable too. Good result. Thanks, everyone! - To unsubscribe from this list

Re: [perfmon] Re: [perfmon2] perfmon2 merge news

2007-11-14 Thread Nick Piggin
On Thursday 15 November 2007 09:56, Chuck Ebbert wrote: > On 11/14/2007 05:17 AM, Nick Piggin wrote: > > But in general, for special files, I guess the response is usually > > some structured data (that is not visible at the syscall layer). > > So I don't see a big p

Re: [perfmon] Re: [perfmon2] perfmon2 merge news

2007-11-14 Thread Nick Piggin
On Thursday 15 November 2007 08:30, Paul Mackerras wrote: > Nick Piggin writes: > > What I really mean is a readv-like syscall, but one that also > > vectorises the file offset. Maybe this is useful enough as a generic > > syscall that also helps Paul's example... >

Re: [PATCH 3/3] nfs: use ->mmap_prepare() to avoid an AB-BA deadlock

2007-11-14 Thread Nick Piggin
On Wed, Nov 14, 2007 at 05:18:50PM -0500, Trond Myklebust wrote: > > On Wed, 2007-11-14 at 22:50 +0100, Peter Zijlstra wrote: > > Right, but I guess what Nick asked is, if pages could be stale to start > > with, how is that avoided in the future. > > > > The way I understand it, this re-validate

Re: [PATCH] mm: Don't allow ioremapping of ranges larger than vmalloc space

2007-11-14 Thread Nick Piggin
t; + if ((size + addr) < addr) > + goto out; > + if (addr > end - size) > + goto out; > > found: > area->next = *p; Yeah I noticed these missing checks when recently working in this area as well. Weren't sure if I was missing something or no

Re: [PATCH 3/3] nfs: use ->mmap_prepare() to avoid an AB-BA deadlock

2007-11-14 Thread Nick Piggin
On Wed, Nov 14, 2007 at 09:01:39PM +0100, Peter Zijlstra wrote: > Normal locking order is: > > i_mutex > mmap_sem > > However NFS's ->mmap hook, which is called under mmap_sem, can take i_mutex. > Avoid this potential deadlock by doing the work that requires i_mutex from > the new ->mmap_pr

Re: [perfmon] Re: [perfmon2] perfmon2 merge news

2007-11-14 Thread Nick Piggin
On Wednesday 14 November 2007 23:07, David Miller wrote: > From: Paul Mackerras <[EMAIL PROTECTED]> > Date: Wed, 14 Nov 2007 23:03:24 +1100 > > > You're suggesting that the behaviour of a read() should depend on what > > was in the buffer before the read? Gack! Surely you have better > > taste th

Re: [perfmon] Re: [perfmon2] perfmon2 merge news

2007-11-14 Thread Nick Piggin
On Wednesday 14 November 2007 22:58, David Miller wrote: > From: Nick Piggin <[EMAIL PROTECTED]> > Date: Wed, 14 Nov 2007 10:49:48 +1100 > > > On Wednesday 14 November 2007 22:44, Paul Mackerras wrote: > > > David Miller writes: > > > > This is my impress

Re: 2.6.24-rc2: Network commit causes SLUB performance regression with tbench

2007-11-14 Thread Nick Piggin
On Wednesday 14 November 2007 22:48, Herbert Xu wrote: > On Wed, Nov 14, 2007 at 03:10:22AM -0800, David Miller wrote: > > So the thing that's being effected here in TCP is > > net/ipv4/tcp.c:select_size(), specifically the else branch: > > Thanks for the pointer. Indeed there is a bug in that are

Re: [perfmon] Re: [perfmon2] perfmon2 merge news

2007-11-14 Thread Nick Piggin
On Wednesday 14 November 2007 22:44, Paul Mackerras wrote: > David Miller writes: > > This is my impression too, all of the things being done with > > a slew of system calls would be better served by real special > > files and appropriate fops. > > Special files and fops really only work well if yo

Re: 2.6.24-rc2: Network commit causes SLUB performance regression with tbench

2007-11-14 Thread Nick Piggin
On Wednesday 14 November 2007 22:10, David Miller wrote: > From: Nick Piggin <[EMAIL PROTECTED]> > Date: Wed, 14 Nov 2007 09:27:39 +1100 > > > OK, in vanilla kernels, the page allocator definitely shows higher > > in the results (than with Herbert's patch reverted).

Re: 2.6.24-rc2: Network commit causes SLUB performance regression with tbench

2007-11-14 Thread Nick Piggin
On Wednesday 14 November 2007 09:27, Nick Piggin wrote: > > 2) Try removing NETIF_F_SG in drivers/net/loopback.c's dev->feastures > >setting. > > Will try that now. Doesn't help (with vanilla kernel -- Herbert's patch applied). data_len histogram drops

Re: 2.6.24-rc2: Network commit causes SLUB performance regression with tbench

2007-11-14 Thread Nick Piggin
On Wednesday 14 November 2007 17:37, David Miller wrote: > From: Nick Piggin <[EMAIL PROTECTED]> > > I'm doing some oprofile runs now to see if I can get any more info. OK, in vanilla kernels, the page allocator definitely shows higher in the results (than with Herbert'

Re: [patch 2.6.24-rc2 1/3] generic gpio -- gpio_chip support

2007-11-14 Thread Nick Piggin
On Wednesday 14 November 2007 19:20, David Brownell wrote: > On Tuesday 13 November 2007, Nick Piggin wrote: > > I mean, if you have a > > timing critical operation, then you should ensure you have priorities > > set correctly so that you simply don't get preempted. &g

Re: [patch 2.6.24-rc2 1/3] generic gpio -- gpio_chip support

2007-11-14 Thread Nick Piggin
On Wednesday 14 November 2007 19:37, David Brownell wrote: > On Tuesday 13 November 2007, Nick Piggin wrote: > > Upstream, all spinlocks prevent preemption. > > I chose my wording carefully though. A preemption point is > more than just a small region where preemption isn'

Re: [patch 2.6.24-rc2 1/3] generic gpio -- gpio_chip support

2007-11-13 Thread Nick Piggin
On Wednesday 14 November 2007 17:52, David Brownell wrote: > On Tuesday 13 November 2007, Andrew Morton wrote: > > > I'll highlight the > > > point that such bitops shouldn't be preemption points. > > > > Disagree.  *everything* should be a preemption point. > > So it's wrong that uses the > same

Re: 2.6.24-rc2: Network commit causes SLUB performance regression with tbench

2007-11-13 Thread Nick Piggin
On Wednesday 14 November 2007 17:12, David Miller wrote: > From: Nick Piggin <[EMAIL PROTECTED]> > Date: Wed, 14 Nov 2007 04:36:24 +1100 > > > On Wednesday 14 November 2007 12:58, David Miller wrote: > > > I suspect the issue is about having a huge skb->data lin

Re: kernel BUG at mm/prio_tree.c:125

2007-11-13 Thread Nick Piggin
On Wednesday 14 November 2007 10:04, Marc Donner wrote: > hi > > i got this kernel bug on our production system, which is running since last > saturday. > > anybody an idea?? Hugh might be of most help here, cc'ed. But for the preliminary questions -- Is the bug reproduceable? And if it is possib

Re: 2.6.24-rc2: Network commit causes SLUB performance regression with tbench

2007-11-13 Thread Nick Piggin
On Wednesday 14 November 2007 12:58, David Miller wrote: > From: Nick Piggin <[EMAIL PROTECTED]> > Date: Tue, 13 Nov 2007 22:41:58 +1100 > > > On Tuesday 13 November 2007 06:44, Christoph Lameter wrote: > > > On Sat, 10 Nov 2007, Nick Piggin wrote: > > >

Re: [BUG] New Kernel Bugs

2007-11-13 Thread Nick Piggin
rant on :) ... These aren't directed specifically at Andrew, but everyone who merges patches or is involved in the release process. On Wednesday 14 November 2007 08:04, Andrew Morton wrote: > On Tue, 13 Nov 2007 21:00:30 +0100 (CET) Christian Kujau <[EMAIL PROTECTED]> wrote: > > On Tue, 13 Nov 20

Re: [patch 3/3] arch_rebalance_pgtables call

2007-11-13 Thread Nick Piggin
On Tuesday 13 November 2007 01:30, [EMAIL PROTECTED] wrote: > From: Martin Schwidefsky <[EMAIL PROTECTED]> > > In order to change the layout of the page tables after an mmap has > crossed the adress space limit of the current page table layout a > architecture hook in get_unmapped_area is needed. T

Re: [patch 2.6.24-rc2 1/3] generic gpio -- gpio_chip support

2007-11-13 Thread Nick Piggin
On Wednesday 14 November 2007 06:22, David Brownell wrote: > On Tuesday 13 November 2007, Ingo Molnar wrote: > > * David Brownell <[EMAIL PROTECTED]> wrote: > > > > > I speculate that either the design has changed (without fanfare), > > > > > or else that stuff is in RT kernels and has not yet gone

Re: 2.6.24-rc2: Network commit causes SLUB performance regression with tbench

2007-11-13 Thread Nick Piggin
On Tuesday 13 November 2007 06:44, Christoph Lameter wrote: > On Sat, 10 Nov 2007, Nick Piggin wrote: > > BTW. your size-2048 kmalloc cache is order-1 in the default setup, > > wheras kmalloc(1024) or kmalloc(4096) will be order-0 allocations. And > > SLAB also uses order-0 fo

Re: 2.6.24-rc2 slab vs slob tbench numbers

2007-11-13 Thread Nick Piggin
On Tuesday 13 November 2007 07:13, Matt Mackall wrote: > On Fri, Nov 09, 2007 at 11:36:56PM +1100, Nick Piggin wrote: > > Hi, > > > > Just ran some tbench numbers (from dbench-3.04), on a 2 socket, 8 > > core x86 system, with 1 NUMA node per socket. With kernel 2.6.24

Re: [rfc][patch] remove nopage

2007-11-11 Thread Nick Piggin
On Sun, Nov 11, 2007 at 09:04:29PM -0500, Jeff Garzik wrote: > Nick Piggin wrote: > >Index: linux-2.6/sound/oss/via82cxxx_audio.c > >=== > >--- linux-2.6.orig/sound/oss/via82cxxx_audio.c > >+++ linux-2.6/

[rfc][patch] remove nopage

2007-11-11 Thread Nick Piggin
close, - .nopage = snd_usX2Y_hwdep_pcm_vm_nopage, + .fault = snd_usX2Y_hwdep_pcm_vm_fault, }; Index: linux-2.6/Documentation/fb/deferred_io.txt === --- linux-2.6.orig/Documentation/fb/deferred_io.txt +++ linux-2.6/Doc

[patch] mm: unlockless reclaim

2007-11-11 Thread Nick Piggin
: Nick Piggin <[EMAIL PROTECTED]> --- Index: linux-2.6/mm/vmscan.c === --- linux-2.6.orig/mm/vmscan.c +++ linux-2.6/mm/vmscan.c @@ -589,7 +589,14 @@ static unsigned long shrink_page_list(st goto keep_

Re: [PATCH 0/11 v3] enable "make ARCH=x86"

2007-11-10 Thread Nick Piggin
On Saturday 10 November 2007 18:54, Sam Ravnborg wrote: > On Fri, Nov 09, 2007 at 10:23:23PM -0500, Jeff Garzik wrote: > > Sam Ravnborg wrote: > > >This is the patch that get rid of ARCH=i386 and ARCH=x86_64 > > >and introduce ARCH=x86. > > >It touches several files but the changes are all one or t

Re: 2.6.24-rc2: Network commit causes SLUB performance regression with tbench

2007-11-09 Thread Nick Piggin
On Saturday 10 November 2007 12:29, Nick Piggin wrote: > cc'ed linux-netdev Err, make that 'netdev' :P > On Saturday 10 November 2007 10:46, Christoph Lameter wrote: > > commit deea84b0ae3d26b41502ae0a39fe7fe134e703d0 seems to cause a drop > > in SLUB tbench perf

Re: [patch 1/2] mm: page trylock rename

2007-11-09 Thread Nick Piggin
ss, but we can't do non-atomic access. Split this into add_to_page_cache_locked, for tmpfs. Signed-off-by: Nick Piggin <[EMAIL PROTECTED]> --- Index: linux-2.6/mm/filemap.c === --- linux-2.6.orig/mm/filemap.c +++ linux-2.6/mm

[patch 2/2] fs: buffer trylock rename

2007-11-09 Thread Nick Piggin
fs: rename buffer trylock Converting the buffer lock to new bitops also requires name change, so convert the raw test_and_set bitop to a trylock. Signed-off-by: Nick Piggin <[EMAIL PROTECTED]> --- fs/buffer.c |4 ++-- fs/jbd/commit.c |2 +- fs/jbd2/co

[patch 1/2] mm: page trylock rename

2007-11-09 Thread Nick Piggin
=> trylock_page, SetPageLocked => set_page_locked). Signed-off-by: Nick Piggin <[EMAIL PROTECTED]> --- drivers/scsi/sg.c |2 +- fs/afs/write.c |2 +- fs/cifs/file.c |2 +- fs/jbd/commit.c |2 +- fs/jbd2/commit.c|

Re: 2.6.24-rc2: Network commit causes SLUB performance regression with tbench

2007-11-09 Thread Nick Piggin
cc'ed linux-netdev On Saturday 10 November 2007 10:46, Christoph Lameter wrote: > commit deea84b0ae3d26b41502ae0a39fe7fe134e703d0 seems to cause a drop > in SLUB tbench performance: > > 8p x86_64 system: > > 2.6.24-rc2: > 1260.80 MB/sec > > After reverting the patch: > 2350.04 MB/sec >

Re: [PATCH, RFC] improved hacks to allow -rt to run kernbench on POWER

2007-11-09 Thread Nick Piggin
On Saturday 10 November 2007 07:52, Benjamin Herrenschmidt wrote: > > diff -urpNa -X dontdiff linux-2.6.23.1-rt4/arch/powerpc/kernel/process.c > > linux-2.6.23.1-rt4-fix/arch/powerpc/kernel/process.c --- > > linux-2.6.23.1-rt4/arch/powerpc/kernel/process.c2007-10-12 > > 09:43:44.0 -0700

Re: [PATCH] sched: avoid large irq-latencies in smp-balancing

2007-11-09 Thread Nick Piggin
On Thursday 08 November 2007 15:37, Gregory Haskins wrote: > Peter Zijlstra wrote: > > Bah, missed a hunk > > > > --- > > Subject: sched: avoid large irq-latencies in smp-balancing > > > > SMP balancing is done with IRQs disabled and can iterate the full rq. > > When rqs are large this can cause la

2.6.24-rc2 slab vs slob tbench numbers

2007-11-09 Thread Nick Piggin
Hi, Just ran some tbench numbers (from dbench-3.04), on a 2 socket, 8 core x86 system, with 1 NUMA node per socket. With kernel 2.6.24-rc2, comparing slab vs slub allocators. I run from 1 to 16 client threads, 5 times each, and restarting the tbench server between every run. I'm just taking the h

Re: VM/networking crash cause #1: page allocation failure (order:1, GFP_ATOMIC)

2007-11-08 Thread Nick Piggin
On Thursday 08 November 2007 00:48, Frank van Maarseveen wrote: > On Wed, Nov 07, 2007 at 09:01:17AM +1100, Nick Piggin wrote: > > On Tuesday 06 November 2007 04:42, Frank van Maarseveen wrote: > > > For quite some time I'm seeing occasional lockups spread over 50 >

Re: [patch 1/4] x86: FIFO ticket spinlocks

2007-11-07 Thread Nick Piggin
On Fri, Nov 02, 2007 at 04:33:32PM +0100, Ingo Molnar wrote: > > * Nick Piggin <[EMAIL PROTECTED]> wrote: > > > Anyway, if this can make its way to the x86 tree, I think it will get > > pulled into -mm (?) and get some exposure... > > ok, we can certainly try

Re: [RFC/PATCH] Optimize zone allocator synchronization

2007-11-06 Thread Nick Piggin
On Wednesday 07 November 2007 17:19, Andrew Morton wrote: > > On Tue, 06 Nov 2007 05:08:07 -0500 Chris Snook <[EMAIL PROTECTED]> wrote: > > > > Don Porter wrote: > > > From: Donald E. Porter <[EMAIL PROTECTED]> > > > > > > In the bulk page allocation/free routines in mm/page_alloc.c, the zone > > >

Re: VM/networking crash cause #1: page allocation failure (order:1, GFP_ATOMIC)

2007-11-06 Thread Nick Piggin
On Tuesday 06 November 2007 04:42, Frank van Maarseveen wrote: > For quite some time I'm seeing occasional lockups spread over 50 different > machines I'm maintaining. Symptom: a page allocation failure with order:1, > GFP_ATOMIC, while there is plenty of memory, as it seems (lots of free > pages,

Re: Oom-killer error.

2007-11-06 Thread Nick Piggin
On Tuesday 06 November 2007 19:34, Jim van Wel wrote: > Hi there, > > I have a strange problem with like 10-15 servers right now. > We have here all HP DL380-G5 servers with kernel 2.6.22.6. System all > works normall. But after a uptime of like 15 a 25 days, we get these > messages, and the server

Re: [patch 1/4] x86: FIFO ticket spinlocks

2007-11-02 Thread Nick Piggin
On Fri, Nov 02, 2007 at 08:56:46PM -0400, Chuck Ebbert wrote: > On 11/02/2007 07:01 PM, Nick Piggin wrote: > > > > In the contended multi-threaded tight loop, the xchg lock is slower than inc > > lock but still beats the fair xadd lock, but that's only because it is >

Re: [patch 1/4] x86: FIFO ticket spinlocks

2007-11-02 Thread Nick Piggin
On Fri, Nov 02, 2007 at 09:51:27AM -0700, Linus Torvalds wrote: > > > On Fri, 2 Nov 2007, Chuck Ebbert wrote: > > > > There's also a very easy way to get better fairness with our current > > spinlocks: > > use xchg to release the lock instead of mov. > > That does nothing at all. > > Yes, it

Re: [patch 1/4] x86: FIFO ticket spinlocks

2007-11-02 Thread Nick Piggin
On Fri, Nov 02, 2007 at 10:05:37AM -0400, Rik van Riel wrote: > On Fri, 2 Nov 2007 07:42:20 +0100 > Nick Piggin <[EMAIL PROTECTED]> wrote: > > > On Thu, Nov 01, 2007 at 06:19:41PM -0700, Linus Torvalds wrote: > > > > > > > > > On Thu, 1 Nov

Re: 2.6.23 regression: accessing invalid mmap'ed memory from gdb causes unkillable spinning

2007-11-02 Thread Nick Piggin
On Thu, Nov 01, 2007 at 10:02:04PM -0700, David Miller wrote: > From: David Miller <[EMAIL PROTECTED]> > Date: Wed, 31 Oct 2007 00:44:25 -0700 (PDT) > > > From: Nick Piggin <[EMAIL PROTECTED]> > > Date: Wed, 31 Oct 2007 08:41:06 +0100 > > > > > Y

Re: [patch 1/4] x86: FIFO ticket spinlocks

2007-11-01 Thread Nick Piggin
On Thu, Nov 01, 2007 at 06:19:41PM -0700, Linus Torvalds wrote: > > > On Thu, 1 Nov 2007, Rik van Riel wrote: > > > > Larry Woodman managed to wedge the VM into a state where, on his > > 4x dual core system, only 2 cores (on the same CPU) could get the > > zone->lru_lock overnight. The other 6

Re: 2.6.23 regression: accessing invalid mmap'ed memory from gdb causes unkillable spinning

2007-11-01 Thread Nick Piggin
On Thu, Nov 01, 2007 at 06:17:42PM -0700, Linus Torvalds wrote: > > > On Fri, 2 Nov 2007, Nick Piggin wrote: > > > > But we do want to allow forced COW faults for MAP_PRIVATE mappings. gdb > > uses this for inserting breakpoints (but fortunately, a COW page in a &

Re: [patch 1/4] x86: FIFO ticket spinlocks

2007-11-01 Thread Nick Piggin
On Thu, Nov 01, 2007 at 04:01:45PM -0400, Chuck Ebbert wrote: > On 11/01/2007 10:03 AM, Nick Piggin wrote: > > [edited to show the resulting code] > > > + __asm__ __volatile__ ( > > + LOCK_PREFIX "xaddw %w0, %1\n" > > + &

Re: 2.6.23 regression: accessing invalid mmap'ed memory from gdb causes unkillable spinning

2007-11-01 Thread Nick Piggin
On Thu, Nov 01, 2007 at 09:08:45AM -0700, Linus Torvalds wrote: > > > On Thu, 1 Nov 2007, Nick Piggin wrote: > > > > Untested patch follows > > Ok, this looks ok. > > Except I would remove the VM_MAYSHARE bit from the test. But we do want to allow forced CO

Re: [patch 1/4] spinlock: lockbreak cleanup

2007-11-01 Thread Nick Piggin
On Thu, Nov 01, 2007 at 04:46:36PM +0100, Ingo Molnar wrote: > > * Lee Schermerhorn <[EMAIL PROTECTED]> wrote: > > > > I guess it was done to make the "template" hacks eaiser. I don't > > > really find that in good taste, especially for important core > > > infrastructure. Anyway. > > > > Actu

Re: 2.6.23 regression: accessing invalid mmap'ed memory from gdb causes unkillable spinning

2007-11-01 Thread Nick Piggin
On Thu, Nov 01, 2007 at 08:14:47AM -0700, Linus Torvalds wrote: > > > On Thu, 1 Nov 2007, Nick Piggin wrote: > > > On Wed, Oct 31, 2007 at 04:08:21PM -0700, Linus Torvalds wrote: > > > > > > We made much bigger changes to ptrace support when we disallowe

Re: [patch 1/4] spinlock: lockbreak cleanup

2007-11-01 Thread Nick Piggin
On Thu, Nov 01, 2007 at 03:06:05PM +0100, Peter Zijlstra wrote: > On Thu, 2007-11-01 at 15:02 +0100, Nick Piggin wrote: > > > Rename need_lockbreak to spin_needbreak, make it use spin_is_contended to > > decouple it from the spinlock implementation, and make it typesafe (rwloc

[patch 3/4] x86: spinlock.h merge prep

2007-11-01 Thread Nick Piggin
Prepare for merging 32 and 64 bit spinlocks, by making them identical (except for the OOSTORE thing). raw_read_lock and raw_write_lock get a relaxed register constraint, and 64-bit has a few "=m" constraints changed to "+m". I hope these things actually make the code better.

[patch 4/4] x86: spinlock.h merge

2007-11-01 Thread Nick Piggin
Merge spinlock_32.h and spinlock_64.h into spinlock.h. Signed-off-by: Nick Piggin <[EMAIL PROTECTED]> --- Index: linux-2.6/include/asm-x86/spinlock.h === --- linux-2.6.orig/include/asm-x86/spinlock.h +++ linux-2.6/include/a

[patch 1/4] x86: FIFO ticket spinlocks

2007-11-01 Thread Nick Piggin
is to keep critical sections short, and ensure locks are reasonably fair (which this patch does). Signed-off-by: Nick Piggin <[EMAIL PROTECTED]> --- Index: linux-2.6/include/asm-x86/spinlock_64.h === --- linux-2.6.orig/include/asm-x

[patch 1/4] spinlock: lockbreak cleanup

2007-11-01 Thread Nick Piggin
do they even get bloated up with that break_lock then?). Signed-off-by: Nick Piggin <[EMAIL PROTECTED]> --- Index: linux-2.6/include/linux/sched.h === --- linux-2.6.orig/include/linux/sched.h +++ linux-2.6/include/linux/s

[patch 0/4] ticket spinlocks for x86

2007-11-01 Thread Nick Piggin
Hi, I'd like to propose these patches for the x86 tree for a bit more exposure and testing. Or at least get some discussion going again. Just for fun I also had a shot at merging the headers, as they become a lot more similar after this with the removal of the paravirt crud. Nick - To unsubscri

Re: 2.6.34-rc1 eat my photo SD card :-(

2007-11-01 Thread Nick Piggin
On Thursday 01 November 2007 22:56, Romano Giannetti wrote: > Hi, > > I have a very possible regression to signal. This morning 2.6.24-rc1 > eat and destroyed my SD card. I have a toshiba laptop with a card slot > and I have used it with 2.6.23-rcX and 2.6.23 without problems so far. > This m

Re: dealing with barriers (was Re: [PATCH] firewire: fw-core: enforce write order when updating fw_device.generation)

2007-11-01 Thread Nick Piggin
On Thursday 01 November 2007 20:51, Stefan Richter wrote: > Nick Piggin wrote: > > On Thursday 01 November 2007 12:49, Stefan Richter wrote: > >> fw_device.node_id and fw_device.generation are accessed without mutexes. > >> We have to ensure that all readers will

Re: filp usage when cpu busy

2007-10-31 Thread Nick Piggin
On Thursday 01 November 2007 12:56, bc Wong (chimwong) wrote: > Hi, > > With 2.6.16 x86_64 on a 4 core machine, I noticed > that the filp usage (according to /proc/slabinfo) > shoots up and keeps on increasing sharply when one > of the CPUs is (1) locked up, or (2) very busy > doing a lot of printk

Re: [PATCH] firewire: fw-core: enforce write order when updating fw_device.generation

2007-10-31 Thread Nick Piggin
On Thursday 01 November 2007 12:49, Stefan Richter wrote: > fw_device.node_id and fw_device.generation are accessed without mutexes. > We have to ensure that all readers will get to see node_id updates > before generation updates. > Hi, a few points: - can change it to use spinlocks instead? This

Re: 2.6.23 regression: accessing invalid mmap'ed memory from gdb causes unkillable spinning

2007-10-31 Thread Nick Piggin
On Wed, Oct 31, 2007 at 04:08:21PM -0700, Linus Torvalds wrote: > > > On Wed, 31 Oct 2007, Nick Piggin wrote: > > > > No that would be great. Fingers crossed it won't cause any problems. > > I actually doubt it will cause problems. > > We made much bi

Re: 2.6.23 regression: accessing invalid mmap'ed memory from gdb causes unkillable spinning

2007-10-31 Thread Nick Piggin
On Wed, Oct 31, 2007 at 08:59:41AM -0700, Linus Torvalds wrote: > > > On Wed, 31 Oct 2007, Nick Piggin wrote: > > > > Well the patch is right, in the context of the regression I introduced > > (and so it should probably go into 2.6.23). > > Yeah, it probably

Re: 2.6.23 regression: accessing invalid mmap'ed memory from gdb causes unkillable spinning

2007-10-31 Thread Nick Piggin
On Wed, Oct 31, 2007 at 08:11:10AM -0700, Linus Torvalds wrote: > > > On Wed, 31 Oct 2007, Nick Piggin wrote: > > > > However I actually don't really like how this all works. I don't like that > > filemap.c should have to know about ptrace, or exactly

Re: [PATCH 03/33] mm: slub: add knowledge of reserve pages

2007-10-31 Thread Nick Piggin
On Wednesday 31 October 2007 23:17, Peter Zijlstra wrote: > On Wed, 2007-10-31 at 21:46 +1100, Nick Piggin wrote: > > And I'd prevent these ones from doing so. > > > > Without keeping track of "reserve" pages, which doesn't feel > > too clean. &g

Re: [PATCH 06/33] mm: allow PF_MEMALLOC from softirq context

2007-10-31 Thread Nick Piggin
On Wednesday 31 October 2007 21:42, Peter Zijlstra wrote: > On Wed, 2007-10-31 at 14:51 +1100, Nick Piggin wrote: > > On Wednesday 31 October 2007 03:04, Peter Zijlstra wrote: > > > Allow PF_MEMALLOC to be set in softirq context. When running softirqs > > > from a bo

Re: [PATCH 03/33] mm: slub: add knowledge of reserve pages

2007-10-31 Thread Nick Piggin
On Wednesday 31 October 2007 21:42, Peter Zijlstra wrote: > On Wed, 2007-10-31 at 14:37 +1100, Nick Piggin wrote: > > On Wednesday 31 October 2007 03:04, Peter Zijlstra wrote: > > > Restrict objects from reserve slabs (ALLOC_NO_WATERMARKS) to allocation > > > conte

Re: [PATCH] Swap delay accounting, include lock_page() delays

2007-10-31 Thread Nick Piggin
On Wednesday 31 October 2007 18:41, Nick Piggin wrote: > On Wednesday 31 October 2007 18:52, Balbir Singh wrote: > > Reported-by: Nick Piggin <[EMAIL PROTECTED]> > > > > The delay incurred in lock_page() should also be accounted in swap delay > > accounting &g

Re: [PATCH] Swap delay accounting, include lock_page() delays

2007-10-31 Thread Nick Piggin
On Wednesday 31 October 2007 18:52, Balbir Singh wrote: > Reported-by: Nick Piggin <[EMAIL PROTECTED]> > > The delay incurred in lock_page() should also be accounted in swap delay > accounting > > Signed-off-by: Balbir Singh <[EMAIL PROTECTED]> Ah right, I forgot to

Re: 2.6.23 regression: accessing invalid mmap'ed memory from gdb causes unkillable spinning

2007-10-30 Thread Nick Piggin
On Tue, Oct 30, 2007 at 11:56:00PM -0700, David Miller wrote: > From: Nick Piggin <[EMAIL PROTECTED]> > Date: Wed, 31 Oct 2007 07:42:21 +0100 > > > Sysrq+T fails to show the stack trace of a running task. Presumably this > > is to avoid a garbled stack, however it can o

Re: 2.6.23 regression: accessing invalid mmap'ed memory from gdb causes unkillable spinning

2007-10-30 Thread Nick Piggin
k won't start running in the middle of show_stack(). If there are any correctness issues, then the archietcture would have to take further steps to ensure the task is not running. Signed-off-by: Nick Piggin <[EMAIL PROTECTE

Re: [PATCH 00/33] Swap over NFS -v14

2007-10-30 Thread Nick Piggin
On Wednesday 31 October 2007 15:37, David Miller wrote: > From: Nick Piggin <[EMAIL PROTECTED]> > Date: Wed, 31 Oct 2007 14:26:32 +1100 > > > Is it really worth all the added complexity of making swap > > over NFS files work, given that you could use a network block &g

Re: [PATCH 09/33] mm: system wide ALLOC_NO_WATERMARK

2007-10-30 Thread Nick Piggin
On Wednesday 31 October 2007 03:04, Peter Zijlstra wrote: > Change ALLOC_NO_WATERMARK page allocation such that the reserves are system > wide - which they are per setup_per_zone_pages_min(), when we scrape the > barrel, do it properly. > IIRC it's actually not too uncommon to have allocations com

Re: [PATCH 06/33] mm: allow PF_MEMALLOC from softirq context

2007-10-30 Thread Nick Piggin
On Wednesday 31 October 2007 03:04, Peter Zijlstra wrote: > Allow PF_MEMALLOC to be set in softirq context. When running softirqs from > a borrowed context save current->flags, ksoftirqd will have its own > task_struct. What's this for? Why would ksoftirqd pick up PF_MEMALLOC? (I guess that some

Re: [PATCH 05/33] mm: kmem_estimate_pages()

2007-10-30 Thread Nick Piggin
On Wednesday 31 October 2007 03:04, Peter Zijlstra wrote: > Provide a method to get the upper bound on the pages needed to allocate > a given number of objects from a given kmem_cache. > Fair enough, but just to make it a bit easier, can you provide a little reason of why in this patch (or referen

Re: [PATCH 04/33] mm: allow mempool to fall back to memalloc reserves

2007-10-30 Thread Nick Piggin
On Wednesday 31 October 2007 03:04, Peter Zijlstra wrote: > Allow the mempool to use the memalloc reserves when all else fails and > the allocation context would otherwise allow it. I don't see what this is for. The whole point of when I fixed this to *not* use the memalloc reserves is because pro

Re: [PATCH 03/33] mm: slub: add knowledge of reserve pages

2007-10-30 Thread Nick Piggin
On Wednesday 31 October 2007 03:04, Peter Zijlstra wrote: > Restrict objects from reserve slabs (ALLOC_NO_WATERMARKS) to allocation > contexts that are entitled to it. > > Care is taken to only touch the SLUB slow path. > > This is done to ensure reserve pages don't leak out and get consumed. I th

Re: [PATCH 00/33] Swap over NFS -v14

2007-10-30 Thread Nick Piggin
On Wednesday 31 October 2007 03:04, Peter Zijlstra wrote: > Hi, > > Another posting of the full swap over NFS series. Hi, Is it really worth all the added complexity of making swap over NFS files work, given that you could use a network block device instead? Also, have you ensured that page_file

Re: 2.6.23 regression: accessing invalid mmap'ed memory from gdb causes unkillable spinning

2007-10-30 Thread Nick Piggin
ill also avoid changing applicatoin behaviour due to a gdb read... Thanks, Nick -- Duane Griffin noticed a 2.6.23 regression that will cause gdb to hang when it tries to access the memory of another process beyond i_size. This is because the solution to the fault vs invalidate race requires that w

Re: 2.6.23 performance regression

2007-10-30 Thread Nick Piggin
On Tuesday 30 October 2007 18:54, Lorenzo Allegrucci wrote: > Hi, sorry if this is a faq but reading > http://people.freebsd.org/~kris/scaling/7.0%20Preview.pdf (slides 17, > 18) > looks like 2.6.23 is having a performance regression on MySQL and > PostgreSQL benchmarks. Has anyone investigated th

Re: [patch 09/10] SLUB: Do our own locking via slab_lock and slab_unlock.

2007-10-30 Thread Nick Piggin
On Wednesday 31 October 2007 05:32, Christoph Lameter wrote: > On Tue, 30 Oct 2007, Nick Piggin wrote: > > Is this actually a speedup on any architecture to roll your own locking > > rather than using bit spinlock? > > It avoids one load from memory when allocating and

Re: [patch 09/10] SLUB: Do our own locking via slab_lock and slab_unlock.

2007-10-29 Thread Nick Piggin
On Sunday 28 October 2007 14:32, Christoph Lameter wrote: > Too many troubles with the bitlocks and we really do not need > to do any bitops. Bitops do not effectively retrieve the old > value which we want. So use a cmpxchg instead on the arches > that allow it. > > Instead of modifying the page->

Re: [PATCH resend2] rd: fix data corruption on memory pressure

2007-10-29 Thread Nick Piggin
ck for the > ramdisk driver. This avoids try_to_free_buffers for ramdisk pages. I think this is the least intrusive change that is least likely to break rd, or any other kernel code, that we've seen. It really should go in 2.6.24, IMO. Acked-by: Nick Piggin <[EMAIL PROTECTED]>

<    1   2   3   4   5   6   7   8   9   10   >