Re: [PATCH] Coccinelle: memdup: Fix typo in warning messages

2018-03-01 Thread Nicolas Palix (LIG)
Le 01/03/2018 à 09:57, Dafna Hirschfeld a écrit : Replace 'kmemdep' with 'kmemdup' in warning messages. Signed-off-by: Dafna Hirschfeld Acked-by: Julia Lawall Acked-by: Nicolas Palix --- scripts/coccinelle/api/memdup.cocci | 4 ++-- 1 file changed, 2 insertions(+),

Re: [PATCH] coccinelle: grep Options and Requires fields more precisely

2017-10-26 Thread Nicolas Palix (LIG)
equires:" in order to avoid accidental matching to what just happens to appear in comment lines. Signed-off-by: Masahiro Yamada Thanks for checking on this! Acked-by: Julia Lawall Acked-by: Nicolas Palix --- scripts/coccicheck| 4 ++-- scripts/coccinelle/nul

Re: [PATCH] coccinelle: fix verbose message about .cocci file being run

2017-10-26 Thread Nicolas Palix (LIG)
sed is not a good choice here. Strip $srctree/ simply without sed. Signed-off-by: Masahiro Yamada Acked-by: Nicolas Palix --- scripts/coccicheck | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/coccicheck b/scripts/coccicheck index 1bfa2d2..9d18662 100755 --- a/sc

Re: [PATCH] coccicheck: improve pattern for getting relative path

2017-09-23 Thread Nicolas Palix (LIG)
$COCCI | sed "s|^$srctree/||"` echo "Processing `basename $COCCI`" echo "with option(s) \"$OPT\"" -- Nicolas Palix http://lig-membres.imag.fr/palix/ smime.p7s Description: Signature cryptographique S/MIME

Re: [PATCH 02/10] docs: sphinxify coccinelle.txt and add it to dev-tools

2016-08-09 Thread Nicolas Palix (LIG)
Le 09/08/16 à 01:34, Jonathan Corbet a écrit : No textual changes have been made, but the formatting has obviously been tweaked. Cc: Michal Marek Cc: Gilles Muller Cc: Nicolas Palix Cc: Julia Lawall Signed-off-by: Jonathan Corbet Acked-by: Nicolas Palix --- .../{coccinelle.txt =>

Re: [PATCH v3 2/8] coccicheck: make SPFLAGS more useful

2016-06-22 Thread Nicolas Palix (LIG)
last option that makes sense. Signed-off-by: Luis R. Rodriguez Acked-by: Nicolas Palix --- scripts/coccicheck | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/scripts/coccicheck b/scripts/coccicheck index f137b04dfdd3..5319fae910b4 100755 --- a/scripts/coccicheck +++ b

Re: [PATCH v3 8/8] scripts/coccinelle: require coccinelle >= 1.0.4 on device_node_continue.cocci

2016-06-21 Thread Nicolas Palix (LIG)
. Rodriguez Acked-by: Julia Lawall Acked-by: Nicolas Palix --- scripts/coccinelle/iterators/device_node_continue.cocci | 3 +++ 1 file changed, 3 insertions(+) diff --git a/scripts/coccinelle/iterators/device_node_continue.cocci b/scripts/coccinelle/iterators/device_node_continue.cocci index

Re: [PATCH v3 6/8] coccicheck: add support for requring a coccinelle version

2016-06-21 Thread Nicolas Palix (LIG)
-off-by: Luis R. Rodriguez Acked-by: Nicolas Palix --- scripts/coccicheck | 14 ++ 1 file changed, 14 insertions(+) diff --git a/scripts/coccicheck b/scripts/coccicheck index 998d764636e0..01b6716ea931 100755 --- a/scripts/coccicheck +++ b/scripts/coccicheck @@ -5,6 +5,7

Re: [PATCH v3 7/8] coccicheck: refer to coccicheck bottest wiki for documentation

2016-06-21 Thread Nicolas Palix (LIG)
-next version of the script. # # This script requires at least spatch # version 1.0.0-rc11. -# DIR="$(dirname $(readlink -f $0))/.." SPATCH="`which ${SPATCH:=spatch}`" -- Nicolas Palix http://lig-membres.imag.fr/palix/ smime.p7s Description: Signature cryptographique S/MIME

Re: [PATCH v3 5/8] scripts: add Linux .cocciconfig for coccinelle

2016-06-21 Thread Nicolas Palix (LIG)
e directory provided with the --dir option is processed last, if used Signed-off-by: Luis R. Rodriguez Acked-by: Nicolas Palix --- .cocciconfig | 3 +++ .gitignore | 1 + 2 files changed, 4 insertions(+) create mode 100644 .cocciconfig diff --git a/.cocciconfig b/.cocciconfig new

Re: [PATCH v3 3/8] coccicheck: enable parmap support

2016-06-21 Thread Nicolas Palix (LIG)
both modes (parmap and non-parmap). julia -- Nicolas Palix http://lig-membres.imag.fr/palix/ smime.p7s Description: Signature cryptographique S/MIME

Re: [PATCH v3 1/8] coccicheck: move spatch binary check up

2016-06-21 Thread Nicolas Palix (LIG)
Le 21/06/16 à 21:21, Luis R. Rodriguez a écrit : This has no functional changes. This is being done to enable us to later use spatch binary for some flag checking for certain features early on. Signed-off-by: Luis R. Rodriguez Acked-by: Nicolas Palix --- scripts/coccicheck | 10

Re: [PATCH] coccicheck: Allow for overriding spatch flags

2016-06-12 Thread Nicolas Palix (LIG)
, rearrage the FLAGS for org or report mode. This allows for overriding of the default --no-show-diff option through SPFLAGS. Signed-off-by: Deepa Dinamani Cc: Julia Lawall Cc: Gilles Muller Cc: Nicolas Palix Acked-By: Nicolas Palix Cc: Michal Marek --- scripts/coccicheck | 4 ++-- 1 file changed

Re: [PATCH] coccicheck: Fix missing 0 index in kill loop

2016-05-17 Thread Nicolas Palix (LIG)
Le 16/05/16 14:55, Kees Cook a écrit : > By default, "seq" counts from 1, but processes were starting counting > from 0, so when interrupted, coccicheck would leave the 0th process > running. > > Signed-off-by: Kees Cook Acked-by: Nicolas Palix > --- > scri

Re: [PATCH 23/24] net, diet: Add coccinelle script to convert drivers to ETHTOOL_OPS

2014-05-06 Thread Nicolas Palix
ndi Kleen > > Useful to remove unneeded driver code when ethtool is disabled. > > The patches doing this are submitted too, but let's add > the script too so people can re-use it. > > Cc: Julia Lawall > Cc: Gilles Muller > Cc: Nicolas Palix > Signed-off-by: Andi

Re: [Cocci] [PATCH] invoke arguments the right way in coccinelle script

2013-07-09 Thread Nicolas Palix
tual patch >> virtual context > > ___ > Cocci mailing list > co...@systeme.lip6.fr > https://systeme.lip6.fr/mailman/listinfo/cocci -- Nicolas Palix Tel: +33 4 76 51 46 27 http://membres-liglab.imag.fr/palix/ -- To unsubscribe fr

[PATCH] Coccinelle: Update information about the minimal version required

2013-07-03 Thread Nicolas Palix
The naming convention of options has changed one year ago. The options have been recently updated in the cocci file and in scripts/coccicheck. This patch also adds this information in the documentation. Signed-off-by: Nicolas Palix --- Documentation/coccinelle.txt | 19

Re: [Cocci] [PATCH 3/3] Coccinelle: Update the options used to the new option scheme

2013-07-03 Thread Nicolas Palix
Hi, On Wed, Jul 3, 2013 at 3:36 PM, Michal Marek wrote: > On 20.6.2013 13:10, Nicolas Palix wrote: >> spatch has changed its option scheme. >> E.g., --no_show_diff is now --no-show-diff >> >> This patch updates: >> - scripts/coccicheck >> - Semantic pat

Re: [PATCH] scripts: Coccinelle script for pci_free_consistent()

2013-06-25 Thread Nicolas Palix
On Wed, May 8, 2013 at 11:03 PM, wrote: > Created coccinelle script for reporting missing pci_free_consistent() calls. > > Signed-off-by: Petr Strnad Signed-off-by: Nicolas Palix > --- > diff --git a/scripts/coccinelle/free/pci_free_consistent.cocci > b/scrip

[PATCH] Coccinelle: Update the documentation

2013-06-20 Thread Nicolas Palix
- The new default mode is 'report'. - The available modes are detailed a bit more. - Some information about the use of spatch options are also given concerning the use of indexing tools. Signed-off-by: Nicolas Palix --- v2: Fix typo reported by Sachin Kamat Documentation/cocc

[PATCH 2/3] Coccinelle: Update the documentation

2013-06-20 Thread Nicolas Palix
- The new default mode is 'report'. - The available modes are detailed a bit more. - Some information about the use of spatch options are also given concerning the use of indexing tools. Signed-off-by: Nicolas Palix --- Documentation/coccinelle.

[PATCH 1/3] Coccinelle: Update section of MAINTAINERS

2013-06-20 Thread Nicolas Palix
Add Documentation/coccinelle.txt in the COCCINELLE section. Signed-off-by: Nicolas Palix --- MAINTAINERS |1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 73b1b3a..2d94051 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2103,6 +2103,7 @@ L:co

[PATCH 3/3] Coccinelle: Update the options used to the new option scheme

2013-06-20 Thread Nicolas Palix
spatch has changed its option scheme. E.g., --no_show_diff is now --no-show-diff This patch updates: - scripts/coccicheck - Semantic patches under scripts/coccinelle/ Signed-off-by: Nicolas Palix --- scripts/coccicheck | 28

Re: [PATCH v3] coccicheck: span checks across CPUs

2013-06-18 Thread Nicolas Palix
On Tue, Jun 18, 2013 at 11:49 PM, Kees Cook wrote: > This adds parallelism by default to the "coccicheck" target using > spatch's "-max" and "-index" arguments. > > Signed-off-by: Kees Cook Signed-off-by: Nicolas Palix > --- > v3: >

Re: [PATCH] coccicheck: span checks across CPUs

2013-06-18 Thread Nicolas Palix
Hi Kees, This is indeed something that was on my TO-DO list! :) Thank you a lot. Could you consider merging with the following or something equivalent for handling running spatch processes when make is interrupted ? For the resubmission, please add Michal Marek (in CC) who will apply it to the m

Re: [PATCH] USB: serial/ftdi_sio.c Fix kernel oops

2013-06-17 Thread Nicolas Palix
ainline by >> commits c515598e0f5769916c31c00392cc2bfe6af74e55 and >> a816e3113b63753c330ca4751ea1d208e93e3015. >> >> This is to be fixed in longterm 2.6.32.60 and 3.4.47. >> This bug has been found with coccinelle. >> >> Signed-off-by: Lotfi Manseur >> Signed-o

[PATCH 1/2] Coccinelle: Make 'report' the default mode

2013-06-06 Thread Nicolas Palix
It appears that the 'report' mode is the one always provided by the semantic patches included in the kernel. It is thus more natural to select it by default. The 'chain' mode is however kept and the 'patch' mode is still the first tried in that case. Signed-off-by

[PATCH 2/2] Coccinelle: Update the Coccinelle section of MAINTAINERS

2013-06-06 Thread Nicolas Palix
Add Michal Marek and the misc branch of the kbuild tree in the Coccinelle section of MAINTAINERS. Signed-off-by: Nicolas Palix --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 3d7782b..73b1b3a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS

[PATCH 2/2] Coccinelle: Update the Coccinelle section of MAINTAINERS

2013-06-06 Thread Nicolas Palix
/Semantic Patches (SmPL) M: Julia Lawall M: Gilles Muller M: Nicolas Palix +M: Michal Marek L: co...@systeme.lip6.fr (moderated for non-subscribers) +T: git git://git.kernel.org/pub/scm/linux/kernel/git/mmarek/kbuild.git misc W: http://coccinelle.lip6.fr/ S

[PATCH 1/2] Coccinelle: Make 'report' the default mode

2013-06-06 Thread Nicolas Palix
It appears that the 'report' mode is the one always provided by the semantic patches included in the kernel. It is thus more natural to select it by default. The 'chain' mode is however kept and the 'patch' mode is still the first tried in that case. --- scripts/coccicheck | 14 +++--- 1

[PATCH 2/4] Coccinelle: Cleanup the setting of the FLAGS and OPTIONS variables

2013-03-02 Thread Nicolas Palix
. Signed-off-by: Nicolas Palix --- scripts/coccicheck | 25 + 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/scripts/coccicheck b/scripts/coccicheck index 7f0d6a6..cdde8e0 100755 --- a/scripts/coccicheck +++ b/scripts/coccicheck @@ -1,4 +1,4 @@ -#!/bin/sh

[PATCH 3/4] Coccinelle: Add support to the SPFLAGS variable

2013-03-02 Thread Nicolas Palix
The SPFLAGS variable allows to pass additional options to spatch, e.g. -use_glimpse. Signed-off-by: Nicolas Palix --- Documentation/coccinelle.txt | 11 ++- scripts/coccicheck |2 +- 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/Documentation

[PATCH 1/4] Coccinelle: Restore coccicheck verbosity in ONLINE mode (C=1 or C=2)

2013-03-02 Thread Nicolas Palix
A recent patch have introduce the VERBOSE variable and comments now depend on it. However, the message printed for each cocci file such not be printed when the ONLINE mode is active, whatever is the value of VERBOSE. Signed-off-by: Nicolas Palix --- scripts/coccicheck |2 +- 1 file changed

[PATCH 4/4] Coccinelle: Fix patch output when coccicheck is used with M= and C=

2013-03-02 Thread Nicolas Palix
When the M variable is used, the -patch option should be given to spatch. This patch fixes the case where C is used. Signed-off-by: Nicolas Palix --- scripts/coccicheck |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/scripts/coccicheck b/scripts/coccicheck index

Re: [PATCH 2 2/2] coccicheck: Allow to show the executed command line

2013-02-01 Thread Nicolas Palix
uted command line is being > shown. > > Signed-off-by: Bernd Schubert > CC: Julia Lawall > CC: Nicolas Palix Acked-by: Nicolas Palix > CC: co...@systeme.lip6.fr > CC: Michal Marek > --- > scripts/coccicheck | 28 +--- > 1 file changed, 21

Re: [PATCH 2 1/2] coccicheck: Allow the user to give a V= (verbose) argument

2013-02-01 Thread Nicolas Palix
t; > Signed-off-by: Bernd Schubert > CC: Julia Lawall > CC: Nicolas Palix Acked-by: Nicolas Palix > CC: co...@systeme.lip6.fr > CC: Michal Marek > --- > Documentation/coccinelle.txt |4 > scripts/coccicheck | 11 ++- > 2 files changed, 14

Re: [PATCH 1/2] coccicheck: Allow the user to give a VERBOSE= argument

2013-01-23 Thread Nicolas Palix
Hi, On Tue, Jan 22, 2013 at 4:05 PM, Bernd Schubert wrote: > Hello Nicolas, > > > On 01/22/2013 03:31 PM, Nicolas Palix wrote: >> >> Hi, >> >> Thank you Bernd for your proposition. >> >> I added Michal in CC, who is responsible for the integrati

Re: [PATCH 1/2] coccicheck: Allow the user to give a VERBOSE= argument

2013-01-22 Thread Nicolas Palix
and warnings > might not be noticed. Allow the user to set the verbosity level. > > > Signed-off-by: Bernd Schubert > CC: Julia Lawall > CC: Nicolas Palix > CC: co...@systeme.lip6.fr > --- > scripts/coccicheck |8 +++- > 1 file changed, 7 insertions

[PATCH] Coccicheck: Improvement for online checking with 'make C=[12]'

2012-10-12 Thread Nicolas Palix
option allows to preserve all gcc options, e.g. -I, while checking code. Other gcc-specific options are discarded by spatch. The support for external modules is also added. Signed-off-by: Nicolas Palix --- scripts/coccicheck | 16 1 file changed, 8 insertions(+), 8 deletions

Re: [PATCH 1/3] Coccicheck: Add the rep+ctxt mode

2012-10-11 Thread Nicolas Palix
Hi, On Thu, Oct 11, 2012 at 3:34 PM, Michal Marek wrote: > On Thu, Sep 20, 2012 at 10:30:46PM +0200, Nicolas Palix wrote: >> This adds a 'rep+ctxt' mode which prints the warning >> message followed by the context. >> >> Signed-off-by: Nicolas Palix >&g