Re: Umount failing due to a file leak on 3.18 Android

2016-04-19 Thread Nikhilesh Reddy
much in advance for your help. -- Thanks Nikhilesh Reddy Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.

Re: Umount failing due to a file leak on 3.18 Android

2016-04-19 Thread Nikhilesh Reddy
much in advance for your help. -- Thanks Nikhilesh Reddy Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.

Re: Umount failing due to a file leak on 3.18 Android

2016-04-19 Thread Nikhilesh Reddy
On Tue 19 Apr 2016 06:26:27 PM PDT, Nikhilesh Reddy wrote: Hi I am looking into a bug that results in umount failures ( since there is a mount ref from the leaked file that is never freed on the mount ) The issue seems to be a result of the following callstack 39.958104: <6>

Re: Umount failing due to a file leak on 3.18 Android

2016-04-19 Thread Nikhilesh Reddy
On Tue 19 Apr 2016 06:26:27 PM PDT, Nikhilesh Reddy wrote: Hi I am looking into a bug that results in umount failures ( since there is a mount ref from the leaked file that is never freed on the mount ) The issue seems to be a result of the following callstack 39.958104: <6>

Umount failing due to a file leak on 3.18 Android

2016-04-19 Thread Nikhilesh Reddy
delayed_fput_list Any chance you can help me get to the bottom of this leak? I dont understand why the delayed_fput_list is missing the file. Is there some sort of race condition? -- Thanks Nikhilesh Reddy Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of

Umount failing due to a file leak on 3.18 Android

2016-04-19 Thread Nikhilesh Reddy
delayed_fput_list Any chance you can help me get to the bottom of this leak? I dont understand why the delayed_fput_list is missing the file. Is there some sort of race condition? -- Thanks Nikhilesh Reddy Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of

Re: [PATCH v5] fuse: Add support for passthrough read/write

2016-02-03 Thread Nikhilesh Reddy
On 02/03/2016 11:53 AM, Jann Horn wrote: On Wed, Feb 03, 2016 at 11:05:57AM -0800, Nikhilesh Reddy wrote: Hi Thanks for your review again :) Uh... how do you know at this point that the file is actually writable? Normally, e.g. vfs_write() will ensure that the file is writable, and e.g

Re: [PATCH v5] fuse: Add support for passthrough read/write

2016-02-03 Thread Nikhilesh Reddy
not sure what you mean. Again thanks for your reviews :) Appreciate your help -- Thanks Nikhilesh Reddy Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.

Re: [PATCH v5] fuse: Add support for passthrough read/write

2016-02-03 Thread Nikhilesh Reddy
On 02/01/2016 11:45 AM, Jann Horn wrote: On Mon, Feb 01, 2016 at 11:28:51AM -0800, Nikhilesh Reddy wrote: On Mon 01 Feb 2016 11:15:56 AM PST, Jann Horn wrote: On Mon, Feb 01, 2016 at 10:56:27AM -0800, Nikhilesh Reddy wrote: diff --git a/fs/fuse/passthrough.c b/fs/fuse/passthrough.c

Re: [PATCH v5] fuse: Add support for passthrough read/write

2016-02-03 Thread Nikhilesh Reddy
On 02/03/2016 11:53 AM, Jann Horn wrote: On Wed, Feb 03, 2016 at 11:05:57AM -0800, Nikhilesh Reddy wrote: Hi Thanks for your review again :) Uh... how do you know at this point that the file is actually writable? Normally, e.g. vfs_write() will ensure that the file is writable, and e.g

Re: [PATCH v5] fuse: Add support for passthrough read/write

2016-02-03 Thread Nikhilesh Reddy
On 02/01/2016 11:45 AM, Jann Horn wrote: On Mon, Feb 01, 2016 at 11:28:51AM -0800, Nikhilesh Reddy wrote: On Mon 01 Feb 2016 11:15:56 AM PST, Jann Horn wrote: On Mon, Feb 01, 2016 at 10:56:27AM -0800, Nikhilesh Reddy wrote: diff --git a/fs/fuse/passthrough.c b/fs/fuse/passthrough.c

Re: [PATCH v5] fuse: Add support for passthrough read/write

2016-02-03 Thread Nikhilesh Reddy
not sure what you mean. Again thanks for your reviews :) Appreciate your help -- Thanks Nikhilesh Reddy Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.

Re: [PATCH v5] fuse: Add support for passthrough read/write

2016-02-01 Thread Nikhilesh Reddy
On Mon 01 Feb 2016 11:15:56 AM PST, Jann Horn wrote: On Mon, Feb 01, 2016 at 10:56:27AM -0800, Nikhilesh Reddy wrote: diff --git a/fs/fuse/passthrough.c b/fs/fuse/passthrough.c [...] +static ssize_t fuse_passthrough_read_write_iter(struct kiocb *iocb

[PATCH v5] fuse: Add support for passthrough read/write

2016-02-01 Thread Nikhilesh Reddy
name to passthrough from stacked_io [Proposed by Linus Torvalds] Signed-off-by: Nikhilesh Reddy --- fs/fuse/Makefile | 2 +- fs/fuse/dev.c | 13 +++-- fs/fuse/dir.c | 3 ++ fs/fuse/file.c | 37 +++-- fs/fuse/fuse_i.h

Re: [PATCH v5] fuse: Add support for passthrough read/write

2016-02-01 Thread Nikhilesh Reddy
On Mon 01 Feb 2016 11:15:56 AM PST, Jann Horn wrote: On Mon, Feb 01, 2016 at 10:56:27AM -0800, Nikhilesh Reddy wrote: diff --git a/fs/fuse/passthrough.c b/fs/fuse/passthrough.c [...] +static ssize_t fuse_passthrough_read_write_iter(struct kiocb *iocb

[PATCH v5] fuse: Add support for passthrough read/write

2016-02-01 Thread Nikhilesh Reddy
name to passthrough from stacked_io [Proposed by Linus Torvalds] Signed-off-by: Nikhilesh Reddy <red...@codeaurora.org> --- fs/fuse/Makefile | 2 +- fs/fuse/dev.c | 13 +++-- fs/fuse/dir.c | 3 ++ fs/fuse/file.c | 37 +++-- fs/fus

Re: [fuse-devel] [PATCH v4] fuse: Add support for passthrough read/write

2016-01-25 Thread Nikhilesh Reddy
On Fri 22 Jan 2016 03:04:36 PM PST, Mike Shal wrote: On Wed, Jan 20, 2016 at 7:16 PM, Nikhilesh Reddy mailto:red...@codeaurora.org>> wrote: diff --git a/fs/fuse/dev.c b/fs/fuse/dev.c @@ -569,6 +570,8 @@ ssize_t fuse_simple_request(struct fuse_conn *fc, struct fuse_args

Re: [fuse-devel] [PATCH v4] fuse: Add support for passthrough read/write

2016-01-25 Thread Nikhilesh Reddy
On Fri 22 Jan 2016 03:04:36 PM PST, Mike Shal wrote: On Wed, Jan 20, 2016 at 7:16 PM, Nikhilesh Reddy <red...@codeaurora.org <mailto:red...@codeaurora.org>> wrote: diff --git a/fs/fuse/dev.c b/fs/fuse/dev.c @@ -569,6 +570,8 @@ ssize_t fuse_simple_request(struct fuse_conn

Re: [PATCH v4] fuse: Add support for passthrough read/write

2016-01-21 Thread Nikhilesh Reddy
. My enthusiasm is getting the better of me:) -- Thanks Nikhilesh Reddy Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.

Re: [PATCH v4] fuse: Add support for passthrough read/write

2016-01-21 Thread Nikhilesh Reddy
. My enthusiasm is getting the better of me:) -- Thanks Nikhilesh Reddy Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.

[PATCH v4] fuse: Add support for passthrough read/write

2016-01-20 Thread Nikhilesh Reddy
eved which is really important on embedded systems that use fuse for I/O. Signed-off-by: Nikhilesh Reddy --- fs/fuse/Makefile | 2 +- fs/fuse/dev.c | 4 ++ fs/fuse/dir.c | 3 ++ fs/fuse/file.c | 37 +++-- fs/fuse/fuse_i.h

Re: [PATCH v3] fuse: Add support for passthrough read/write

2016-01-20 Thread Nikhilesh Reddy
On Wed 20 Jan 2016 03:38:41 PM PST, Jann Horn wrote: On Wed, Jan 20, 2016 at 03:20:34PM -0800, Nikhilesh Reddy wrote: Add support for filesystem passthrough read/write of files when enabled in userspace through the option FUSE_PASSTHROUGH. [...] + daemon_fd = (int)open_out

Re: [PATCH] fuse: Add support for fuse stacked I/O

2016-01-20 Thread Nikhilesh Reddy
On 01/18/2016 06:57 PM, Nikhilesh Reddy wrote: On 01/15/2016 01:53 PM, Linus Torvalds wrote: On Fri, Jan 15, 2016 at 1:46 PM, Andy Lutomirski wrote: If mmap sets vm_file to the underlying thing, wouldn't CRIU and anything else that uses map_files get confused? Or did you have something else

[PATCH v3] fuse: Add support for passthrough read/write

2016-01-20 Thread Nikhilesh Reddy
eved which is really important on embedded systems that use fuse for I/O. Signed-off-by: Nikhilesh Reddy --- fs/fuse/Makefile | 2 +- fs/fuse/dev.c | 4 ++ fs/fuse/dir.c | 3 ++ fs/fuse/file.c | 37 +++-- fs/fuse/fuse_i.h

Re: [PATCH] fuse: Add support for fuse stacked I/O

2016-01-20 Thread Nikhilesh Reddy
On 01/18/2016 07:07 PM, Jann Horn wrote: 2016-01-14 0:53 GMT+01:00 Nikhilesh Reddy : Add support for filesystem stacked read/write of files when enabled through a userspace init option of FUSE_STACKED_IO. When FUSE_STACKED_IO is enabled all the reads and writes to the fuse mount point go

Re: [PATCH] fuse: Add support for fuse stacked I/O

2016-01-20 Thread Nikhilesh Reddy
On 01/18/2016 07:07 PM, Jann Horn wrote: 2016-01-14 0:53 GMT+01:00 Nikhilesh Reddy <red...@codeaurora.org>: Add support for filesystem stacked read/write of files when enabled through a userspace init option of FUSE_STACKED_IO. When FUSE_STACKED_IO is enabled all the reads and

Re: [PATCH] fuse: Add support for fuse stacked I/O

2016-01-20 Thread Nikhilesh Reddy
On 01/18/2016 06:57 PM, Nikhilesh Reddy wrote: On 01/15/2016 01:53 PM, Linus Torvalds wrote: On Fri, Jan 15, 2016 at 1:46 PM, Andy Lutomirski <l...@amacapital.net> wrote: If mmap sets vm_file to the underlying thing, wouldn't CRIU and anything else that uses map_files get confused?

[PATCH v3] fuse: Add support for passthrough read/write

2016-01-20 Thread Nikhilesh Reddy
eved which is really important on embedded systems that use fuse for I/O. Signed-off-by: Nikhilesh Reddy <red...@codeaurora.org> --- fs/fuse/Makefile | 2 +- fs/fuse/dev.c | 4 ++ fs/fuse/dir.c | 3 ++ fs/fuse/file.c | 37 +

Re: [PATCH v3] fuse: Add support for passthrough read/write

2016-01-20 Thread Nikhilesh Reddy
On Wed 20 Jan 2016 03:38:41 PM PST, Jann Horn wrote: On Wed, Jan 20, 2016 at 03:20:34PM -0800, Nikhilesh Reddy wrote: Add support for filesystem passthrough read/write of files when enabled in userspace through the option FUSE_PASSTHROUGH. [...] + daemon_fd = (int)open_out

[PATCH v4] fuse: Add support for passthrough read/write

2016-01-20 Thread Nikhilesh Reddy
eved which is really important on embedded systems that use fuse for I/O. Signed-off-by: Nikhilesh Reddy <red...@codeaurora.org> --- fs/fuse/Makefile | 2 +- fs/fuse/dev.c | 4 ++ fs/fuse/dir.c | 3 ++ fs/fuse/file.c | 37 +