Re: [lvc-project] [PATCH] tracing: remove unreachable trace_array_put

On 7/16/24 12:45, Alexey Khoroshilov wrote: Yes, but there is another possible modification: replacement of call to nonseekable_open() by a call to some other function that returns error. Current code is already ready for such modification. The change of which function is called would change

Re: [PATCH] tracing: remove unreachable trace_array_put

As nonseekable_open() documentation states: "The function is not supposed to ever fail, the only reason it returns an 'int' and not 'void' is so that it can be plugged directly into file_operations structure." So it seems, that it will not fail anytime as it is not meant to? Otherwise, there will

[PATCH] tracing: remove unreachable trace_array_put

. Fixes: 7b85af630348 ("tracing: Get trace_array ref counts when accessing trace files") Signed-off-by: Nikita Kiryushin --- kernel/trace/trace.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c index 578a49ff5c32..7e480501b