Re: [PATCH] locking/mutex: initialize osq lock in __MUTEX_INITIALIZER()

2021-04-14 Thread Nikitas Angelinas
On Mon, Mar 29, 2021 at 03:50:56PM +0100, Will Deacon wrote: > On Mon, Mar 29, 2021 at 12:15:16AM -0700, Nikitas Angelinas wrote: > > Since __MUTEX_INITIALIZER() is used on memory that is initialized to 0 > > anyway this change should not have an effect, but it seems better to >

[PATCH] locking/mutex: initialize osq lock in __MUTEX_INITIALIZER()

2021-03-29 Thread Nikitas Angelinas
Since __MUTEX_INITIALIZER() is used on memory that is initialized to 0 anyway this change should not have an effect, but it seems better to initialize osq explicitly for completeness, as done in other macros and functions that initialize mutex and rwsem. Signed-off-by: Nikitas Angelinas

Re: [PATCH] power/poweroff.c: mark variables with __initdata and __maybe_unused

2019-05-02 Thread Nikitas Angelinas
On Thu, May 02, 2019 at 12:15:00PM +0200, Pavel Machek wrote: > On Thu 2019-05-02 00:43:05, Nikitas Angelinas wrote: > > There is no need to keep sysrq_poweroff_op after initialization, so mark > > it with __initdata. > > Are you sure? > > pavel@duo:/data/l/k$ gre

[PATCH] power/poweroff.c: mark variables with __initdata and __maybe_unused

2019-05-02 Thread Nikitas Angelinas
There is no need to keep sysrq_poweroff_op after initialization, so mark it with __initdata. Mark some of the function parameters with __maybe_unused to avoid compilation warnings. Signed-off-by: Nikitas Angelinas --- kernel/power/poweroff.c | 7 --- 1 file changed, 4 insertions(+), 3

Re: b050de0f98 ("fs/binfmt_elf.c: free PT_INTERP filename ASAP"): BUG: KASAN: null-ptr-deref in allow_write_access

2019-04-02 Thread Nikitas Angelinas
On Tue, Apr 02, 2019 at 08:53:42PM +0530, Mukesh Ojha wrote: > I think, this may fix the problem. > > https://patchwork.kernel.org/patch/10878501/ > > > Thanks, > Mukesh > > On 4/2/2019 8:24 PM, kernel test robot wrote: > > Greetings, > > > > 0day kernel testing robot got the below dmesg and

[PATCH] fs/binfmt_elf.c: fix GPF when dereferencing invalid interpreter

2019-03-30 Thread Nikitas Angelinas
sue, but it should, imho. Signed-off-by: Nikitas Angelinas Reported-by: syzbot+0d1fcd7268b21bace...@syzkaller.appspotmail.com Fixes: 44e63c4a0263 ("fs/binfmt_elf.c: free PT_INTERP filename ASAP") --- fs/binfmt_elf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/binf

[PATCH] printk: Clean up do_syslog() error handling

2017-07-29 Thread Nikitas Angelinas
of the error variable to 0 is also removed. This patch has been build-tested on x86_64, but not tested for functionality. Signed-off-by: Nikitas Angelinas <nikitas.angeli...@gmail.com> --- kernel/printk/printk.c | 35 --- 1 file changed, 12 insertions(

[PATCH] printk: Clean up do_syslog() error handling

2017-07-29 Thread Nikitas Angelinas
of the error variable to 0 is also removed. This patch has been build-tested on x86_64, but not tested for functionality. Signed-off-by: Nikitas Angelinas --- kernel/printk/printk.c | 35 --- 1 file changed, 12 insertions(+), 23 deletions(-) diff --git a/kernel

[PATCH] MIPS: Alchemy: Remove reverted CONFIG_NETLINK_MMAP from db1xxx_defconfig

2017-05-29 Thread Nikitas Angelinas
Netlink mmap support and the relevant CONFIG_NETLINK_MMAP option have been reverted by commit d1b4c689d4130bcfd3532680b64db562300716b6 ("netlink: remove mmapped netlink support"). Remove the occurrence of CONFIG_NETLINK_MMAP from db1xxx_defconfig. Signed-off-by: Nikitas Angelinas <n

[PATCH] MIPS: Alchemy: Remove reverted CONFIG_NETLINK_MMAP from db1xxx_defconfig

2017-05-29 Thread Nikitas Angelinas
Netlink mmap support and the relevant CONFIG_NETLINK_MMAP option have been reverted by commit d1b4c689d4130bcfd3532680b64db562300716b6 ("netlink: remove mmapped netlink support"). Remove the occurrence of CONFIG_NETLINK_MMAP from db1xxx_defconfig. Signed-off-by: Nikitas Angelinas C

Re: [PATCH 4/4] Staging: lustre: sparse lock warning fix

2015-05-21 Thread Nikitas Angelinas
(Apologies for the double-posting to individual recipients; resending in plain text to get through vger list filters.) The current code does not have a bug in this path (until we find one, of course). nrs_resource_put_safe() releases references to the related NRS resource hierarchies and policies

Re: [PATCH 4/4] Staging: lustre: sparse lock warning fix

2015-05-21 Thread Nikitas Angelinas
(Apologies for the double-posting to individual recipients; resending in plain text to get through vger list filters.) The current code does not have a bug in this path (until we find one, of course). nrs_resource_put_safe() releases references to the related NRS resource hierarchies and policies