Re: [PATCH 2/2] Staging: lustre: lnet: lib-move return of an errno should typically be negative (ie: return -EAGAIN)

2015-10-23 Thread Nilesh Kokane
On Fri, Oct 23, 2015 at 5:10 PM, Dilger, Andreas wrote: > On 2015/10/22, 22:30, "Nilesh Kokane" wrote: >>Fixed- Return of an errno should typically be negative (ie: return >>-EAGAIN) > > Nak. Please do not change these function return values. They are > con

[PATCH] Staging: media: lirc Braces not needed for single statement

2015-10-22 Thread Nilesh Kokane
Fixed the braces issue for single statement. Signed-off-by: Nilesh Kokane --- drivers/staging/media/lirc/lirc_imon.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/media/lirc/lirc_imon.c b/drivers/staging/media/lirc/lirc_imon.c index 62ec9f7..a6cae49

[PATCH] staging: lustre: lnet :socklnd Braces not necessary

2015-10-22 Thread Nilesh Kokane
Braces not needed for single statement block Signed-off-by: Nilesh Kokane --- drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c b/drivers/staging/lustre/lnet/klnds

[PATCH] Staging: lustre: lnet :socklnd return statement in void function not useful

2015-10-22 Thread Nilesh Kokane
Return function in void function is not needed. Signed-off-by: Nilesh Kokane --- drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c b/drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c

[PATCH 2/2] Staging: lustre: lnet: lib-move return of an errno should typically be negative (ie: return -EAGAIN)

2015-10-22 Thread Nilesh Kokane
Fixed- Return of an errno should typically be negative (ie: return -EAGAIN) Signed-off-by: Nilesh Kokane --- drivers/staging/lustre/lnet/lnet/lib-move.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/staging/lustre/lnet/lnet/lib-move.c b

[PATCH] Staging: lustre: lov_obd: fixed a brace coding style issue

2015-10-22 Thread Nilesh Kokane
Fixed a coding style issue. Signed-off-by: Nilesh kokane --- drivers/staging/lustre/lustre/lov/lov_obd.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/lustre/lustre/lov/lov_obd.c b/drivers/staging/lustre/lustre/lov/lov_obd.c index 96c55ac..8e1729e