On Thu, Dec 17, Andrea Parri (Microsoft) wrote:
> Check that the packet is of the expected size at least, don't copy data
> past the packet.
> + if (hv_pkt_datalen(desc) < sizeof(struct vstor_packet) -
> + stor_device->vmscsi_size_delta) {
> +
Am Fri, 26 Mar 2021 01:55:41 +0900
schrieb Masahiro Yamada :
> What about drivers/net/ethernet/lantiq_etop.c ?
Nothing complained about it. I guess there is a build-bot for alpha, but none
for mips.
> I got a lot of complaints in the last trial.
Why did you get complains, instead of me?
Wh
Am Fri, 19 Mar 2021 15:32:31 +0100
schrieb Olaf Hering :
> It is a hard error if a return value is ignored.
The automated builds found only a single error, in load_em86().
Let me know if there are other reasons why the patch was rejected.
Olaf
pgpwH6ihF0muQ.pgp
Description: Digitale Signa
In preparation to build with -Werror=unused-result, use remove_arg_zero
properly.
Fixes commit b6a2fea39318e43fee84fa7b0b90d68bed92d2ba
Signed-off-by: Olaf Hering
---
fs/binfmt_em86.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/fs/binfmt_em86.c b/fs/binfmt_em86.c
Am Fri, 19 Mar 2021 15:41:44 +0100
schrieb Olaf Hering :
> FullyQualifiedDomainName
I think in the past I did asked MSFT what the host side really expects. Maybe
this time there will be an answer.
Why would the host expect a FQDN from a VM? Why would it care about DNS layout
of the netw
answered with an empty
string.
Signed-off-by: Olaf Hering
---
v2:
resend, the thread aims for success.
tools/hv/Makefile| 2 ++
tools/hv/hv_kvp_daemon.c | 69 ++--
2 files changed, 48 insertions(+), 23 deletions(-)
diff --git a/tools/hv/Make
It is a hard error if a return value is ignored.
In case the return value has no meaning, remove the attribute.
Signed-off-by: Olaf Hering
---
v2:
resend
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index a28bb374663d..9b7def6db494 100644
It is a hard error if a return value is ignored.
In case the return value has no meaning, remove the attribute.
Signed-off-by: Olaf Hering
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index e2c3f65c4721..c7f9acffad42 100644
--- a/Makefile
hvfb_getmem uses vzalloc, therefore vmalloc.h should be included.
Fixes commit d21987d709e807ba7bbf47044deb56a3c02e8be4 ("video: hyperv:
hyperv_fb: Support deferred IO for Hyper-V frame buffer driver")
Signed-off-by: Olaf Hering
---
drivers/video/fbdev/hyperv_fb.c | 1 +
1 file
Am Mon, 19 Oct 2020 02:58:08 +
schrieb Michael Kelley :
> I think we should take the patch.
Thanks. I just briefly looked at the code, did not understand much of it. But
it feels like the math uses the wrong input. I think its is not the 'pr_warn'
that needs changing, the 'Fixes' tag would
Am Tue, 13 Oct 2020 11:19:21 +0200
schrieb Olaf Hering :
> A message is generated every 5 minutes. Unclear why this remained unnoticed
> since at least v5.3. I have added debug to my distro kernel to see what the
> involved variable values are. More info later today.
The actual v
Am Tue, 13 Oct 2020 09:17:17 +
schrieb Wei Liu :
> So ... this patch is not needed anymore?
Why? A message is generated every 5 minutes. Unclear why this remained
unnoticed since at least v5.3. I have added debug to my distro kernel to see
what the involved variable values are. More info la
Catch errors which at least gcc tolerates by default:
warning: 'return' with no value, in function returning non-void [-Wreturn-type]
Signed-off-by: Olaf Hering
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index f84d7e4ca0be..96
Am Thu, 8 Oct 2020 09:12:15 +0200
schrieb Olaf Hering :
> warning is logged in dmesg
Actually it is logged on the system console, depending on how logging is
configured.
Olaf
pgpdjkpjAh1xK.pgp
Description: Digitale Signatur von OpenPGP
It is not an error if a the host requests to balloon down, but the VM
refuses to do so. Without this change a warning is logged in dmesg
every five minutes.
Fixes commit b3bb97b8a49f3
Signed-off-by: Olaf Hering
---
drivers/hv/hv_balloon.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion
Catch errors which at least gcc tolerates by default:
warning: 'return' with no value, in function returning non-void [-Wreturn-type]
Signed-off-by: Olaf Hering
---
Makefile | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Makefile b/Makefile
index f84d7e4ca0be..7b2e63e7be18 10
No need to cast a void pointer.
Signed-off-by: Olaf Hering
---
drivers/hv/vmbus_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c
index 910b6e90866c..187809977360 100644
--- a/drivers/hv/vmbus_drv.c
+++ b/drivers/hv
On Fri, Jun 26, Joseph Salisbury wrote:
> When the kernel panics, one page worth of kmsg data is written to an allocated
> page. The Hypervisor is notified of the page address trough the MSR. This
> panic information is collected on the host. Since we are only collecting one
> page of data, the
On Fri, Feb 22, Paolo Bonzini wrote:
> On 22/02/19 12:44, Thomas Gleixner wrote:
> >> The specific usecase I have is a workload within VMs that makes heavy
> >> use of TSC. The kernel is booted with 'clocksource=tsc highres=off
> >> nohz=off'
> >> because only this clocksource gives enough granul
Am Fri, 22 Feb 2019 12:44:39 +0100 (CET)
schrieb Thomas Gleixner :
> Whether that is accurate enough or not to make NTP happy, I can't tell, but
> it's definitely worth a try.
Thanks Thomas, I will look into the suggestions.
Olaf
pgpKvKEGb9vSF.pgp
Description: Digitale Signatur von OpenPGP
Is there a way to recalibrate the x86 TSC during a suspend/resume cycle?
While the frequency will remain the same on a Laptop, it may (or rather:
it definitly will) differ if a VM is migrated from one host to another.
The hypervisor may choose to emulate the expected TSC frequency on the
destinati
On Thu, Feb 07, lantianyu1...@gmail.com wrote:
> +++ b/drivers/iommu/Kconfig
> +config HYPERV_IOMMU
> + bool "Hyper-V x2APIC IRQ Handling"
> + depends on HYPERV
> + select IOMMU_API
> + help
Consider adding 'default HYPERV' like some other drivers already do it.
Olaf
signature
Am Sun, 17 Sep 2017 20:54:18 -0700
schrieb k...@exchange.microsoft.com:
> This extends existing vmbus related sysfs structure to provide per-channel
> state information. This is useful when diagnosing issues with multiple
> queues in networking and storage.
> +++ b/drivers/hv/vmbus_drv.c
> +stati
From: Olaf Hering
Python3 changed the way how 'print' works.
Adjust the code to a syntax that is understood by python2 and python3.
Signed-off-by: Olaf Hering
---
tools/hv/lsvmbus | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/tools/hv/lsvmbus
Python3 changed the way how 'print' works.
Adjust the code to a syntax that is understood by python2 and python3.
Signed-off-by: Olaf Hering
---
v2:
correct author
tools/hv/lsvmbus | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/tools/hv/lsvmbus
The usage of strchr requires inclusion of string.h.
Fixes: 0c38cda64aec ("tools: hv: remove unnecessary header files and netlink
related code")
Signed-off-by: Olaf Hering
---
tools/hv/hv_fcopy_daemon.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/hv/hv_fcopy_daemon.c
On Fri, Dec 08, Eduardo Otubo wrote:
> tools/hv/hv_set_ifconfig.sh | 45
> +++--
> 1 file changed, 43 insertions(+), 2 deletions(-)
> +# let's wait for 3 minutes
Was this codepath runtime tested?
Last time this came up, the conclusion was that W
On Tue, Sep 05, KY Srinivasan wrote:
> Were you planning on sending a patch for this.
No, not yet. I dont know how SA_RESTART works.
Olaf
signature.asc
Description: PGP signature
On Mon, Aug 28, Eduardo Otubo wrote:
> +sleep 30s;
Was this runtime tested?
Once this sleep(1) is done, HV_UTIL_TIMEOUT kicks in and the daemon dies.
Olaf
signature.asc
Description: PGP signature
On Fri, Aug 25, Vitaly Kuznetsov wrote:
> Shall we request SA_RESTART with sigaction() in all three daemons instead?
If that works better, probably yes.
Olaf
signature.asc
Description: PGP signature
slightly less than expected.
Fix this by restoring the expected buffer size in case of WRITE_TO_FILE.
Fixes: c7e490fc23eb ("Drivers: hv: fcopy: convert to hv_utils_transport")
Fixes: 3f2baa8a7d2e ("Tools: hv: update buffer handling in hv_fcopy_daemon")
Signed-off-by: Olaf Her
If strace attaches to the daemon pread returns with EINTR, and the
process exits. Catch this case and continue with the next iteration.
Signed-off-by: Olaf Hering
---
tools/hv/hv_fcopy_daemon.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tools/hv/hv_fcopy_daemon.c b/tools/hv
members as
needed. This also gives the correct size for the buffer (~6K instead of 64K).
Signed-off-by: Olaf Hering
---
tools/hv/hv_fcopy_daemon.c | 31 ---
1 file changed, 16 insertions(+), 15 deletions(-)
diff --git a/tools/hv/hv_fcopy_daemon.c b/tools/hv
Increase buffer size so that "_{-INT_MAX}" will fit.
Spotted by the gcc7 snprintf checker.
Signed-off-by: Olaf Hering
---
tools/hv/hv_kvp_daemon.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/hv/hv_kvp_daemon.c b/tools/hv/hv_kvp_daemon.c
index 88
On Thu, Dec 01, Olaf Hering wrote:
> On Wed, Nov 16, Olaf Hering wrote:
> > During boot into a current openSUSE Tumbleweed 20161108 this laptop
> > starts to hang sometimes with 4.8.x. Today I was able to catch this
> > crash in __wake_up_common caused by i9
On Fri, Jan 13, Vitaly Kuznetsov wrote:
> + hv_ptp_clock = ptp_clock_register(&ptp_hyperv_info, NULL);
> + if (IS_ERR(hv_ptp_clock)) {
Should that be IS_ERR_OR_NULL to catch "!IS_REACHABLE(CONFIG_PTP_1588_CLOCK)"?
Olaf
signature.asc
Description: PGP signature
On Tue, Dec 20, Roman Kagan wrote:
Reverting commit 22356585712d ("staging: hv: use sync_bitops when
interacting with the hypervisor") is save because ...
> - sync_set_bit(channel->monitor_bit,
> + set_bit(channel->monitor_bit,
Olaf
signature.asc
Description: PGP s
On Thu, Dec 15, Vitaly Kuznetsov wrote:
> -> K. Y., but these words were written before I implemented
> vmbus_wait_for_unload(), to me they just explain how we read messages.
Another question for KY:
In my testing, while busy-looping in vmbus_wait_for_unload, I see a few
"message_type==1, hdr->msg
On Thu, Dec 15, Vitaly Kuznetsov wrote:
> vmbus_wait_for_unload() may be receiving a message (not necessarily the
> CHANNELMSG_UNLOAD_RESPONSE, we may see some other message) on the same
> CPU it runs and in this case wrmsrl() makes sense. In other cases it
> does nothing (neither good nor bad).
On Thu, Dec 15, Vitaly Kuznetsov wrote:
> We actually need to read the reply and empty the message slot to make
> unload happen. And reading on a different CPU may not work, see:
>
> http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2016-December/097330.html
Does the following se
On Thu, Dec 15, Vitaly Kuznetsov wrote:
> I see a number of minor but at least one major issue against such move:
> At least for some Hyper-V versions (2012R2 for example)
> CHANNELMSG_UNLOAD_RESPONSE is delivered to the CPU which initially sent
> CHANNELMSG_REQUESTOFFERS and on kdump we may not
On Thu, Dec 15, Olaf Hering wrote:
> On Thu, Dec 15, Vitaly Kuznetsov wrote:
>
> > I see a number of minor but at least one major issue against such move:
> > At least for some Hyper-V versions (2012R2 for example)
> > CHANNELMSG_UNLOAD_RESPONSE is delivered to the
On Mon, Dec 12, Olaf Hering wrote:
> On Mon, Dec 12, Theodore Ts'o wrote:
>
> > What was going on at the time of the crash, and can you reproduce this?
>
> Its the 'rm -rf $dir/$oldbackup.N' at the end of each rsnapshot run.
Also, the system was otherwise
On Mon, Dec 12, Theodore Ts'o wrote:
> What was going on at the time of the crash, and can you reproduce this?
Its the 'rm -rf $dir/$oldbackup.N' at the end of each rsnapshot run.
I will try to reproduce it, see if it happens again during the hourly
rsnapshot runs. So far I have not seen it with
On Mon, Dec 12, Olaf Hering wrote:
> [197064.401309] RIP: 0010:[] []
> __d_lookup_rcu+0x67/0x180
... and umount is not happy after that, which I think is expected:
root@probook:~ # umount -v /BACKUP_OLH_1T ; dmsetup remove
luks-feaf408d-3257-4850-b597-bbca1dc651df ; sync ; bl
This crash happend during rsnapshot cleanup, full dmesg below:
Dec 11 17:15:02 probook rsnapshot-backup-scripts.hourly.sh[3244]: claimed
rsnapshot_pid_lock
Dec 11 17:15:02 probook rsnapshot-backup-scripts.hourly.sh[3247]: running hourly
...
[197064.399173] general protection fault: [#1] PRE
On Wed, Dec 07, KY Srinivasan wrote:
> May be a better solution might be to have a new mechanism to indicate
> to the host that all state of the previous incarnation of the kernel
> needs to be cleaned up. This will be close to what we have on
> hardware.
That would be cool, but until this appea
On Wed, Dec 07, KY Srinivasan wrote:
> Is there a mechanism for stashing away state that can be retrieved in
> the context of the execed kernel.
I have to find out. To simplify things the new approach may only be used
in the kdump case, which already passes various info in cmdline. Most
likely th
Am 7. Dezember 2016 16:04:29 MEZ, schrieb KY Srinivasan :
>Yes; I had played with this approach a while ago. The issue is that the
>host knows about a
>bunch of in memory state that will be different in the kexec kernel.
>For instance if we did all
>the cleanup as part of the boot sequence, we wi
KY,
if a hyperv VM crashes alot of work must be done to prepare the
environment for the kdump kernel. This approach is different compared to
all the other VM types, or baremetal. Since the just crashed kernel is
per definition unreliable all that work should be done within the kdump
kernel because
On Wed, Nov 16, Olaf Hering wrote:
> During boot into a current openSUSE Tumbleweed 20161108 this laptop
> starts to hang sometimes with 4.8.x. Today I was able to catch this
> crash in __wake_up_common caused by i915 or drm or whatever:
>
> ...
> [ 69.851635] BUG: unabl
On Mon, Nov 21, Boris Ostrovsky wrote:
> Commit 9c17d96500f7 ("xen/gntdev: Grant maps should not be subject to
> NUMA balancing") set VM_IO flag to prevent grant maps from being
> subjected to NUMA balancing.
Tested-by: Olaf Hering
This should go to stable as well.
O
On Thu, Nov 17, Boris Ostrovsky wrote:
> Commit 9c17d96500f7 ("xen/gntdev: Grant maps should not be subject to
> NUMA balancing") set VM_IO flag to prevent grant maps from being
> subjected to NUMA balancing.
Thanks, this works for me in 4.4:
Tested-by: Olaf Hering
O
On Thu, Nov 17, Boris Ostrovsky wrote:
> On 11/17/2016 06:28 AM, Olaf Hering wrote:
> > ERROR: "__mpol_dup" [drivers/xen/xen-gntdev.ko] undefined!
> > ERROR: "get_task_policy" [drivers/xen/xen-gntdev.ko] undefined!
> I just built 4.4.11 with this patch appl
On Wed, Nov 16, Boris Ostrovsky wrote:
> Unfortunately I haven't been able to trigger NUMA balancing
> so while I tested this in general I am not sure I actually
> exercised the code path.
Thanks for the patch!
Would be nice to actually test the code path which caused the initial
addition of VM_
During boot into a current openSUSE Tumbleweed 20161108 this laptop
starts to hang sometimes with 4.8.x. Today I was able to catch this
crash in __wake_up_common caused by i915 or drm or whatever:
...
[ 69.851635] BUG: unable to handle kernel NULL pointer dereference at
(null)
[ 69
On Thu, Nov 10, Boris Ostrovsky wrote:
> Are you sure it's this patch that causes the failure?
>
> I commented out '| VM_IO' and still unable to boot with this option.
Yes, this works for me, sles12sp2 dom0+domU, which is linux-4.4 based:
+++ b/drivers/xen/gntdev.c
@@ -804,7 +804,7 @@ static in
On Thu, Nov 10, Boris Ostrovsky wrote:
> Is this something new? Because this patch has been there for a year.
It was just tested now, cycling through all the combinations for a
disk=[]. Removing "direct-is-save" will use different code paths and the
error is not seen.
Olaf
signature.asc
Descri
On Tue, Nov 10, Boris Ostrovsky wrote:
> Doing so will cause the grant to be unmapped and then, during
> fault handling, the fault to be mistakenly treated as NUMA hint
> fault.
>
> In addition, even if those maps could partcipate in NUMA
> balancing, it wouldn't provide any benefit since we are
On Fri, Sep 09, k...@exchange.microsoft.com wrote:
> + * This check is safe since we are executing in the
> + * interrupt context and time synch messages arre always
Typo.
Olaf
signature.asc
Description: PGP signature
On Tue, Sep 13, Alex Ng (LIS) wrote:
> > On Thu, Sep 08, k...@exchange.microsoft.com wrote:
> > Perhaps a better approach would be to list the known existing hosts and use
> > the new protocol for upcoming, unknown hosts via 'default:'.
> This is a good idea. I will create another patch that addre
On Thu, Sep 08, k...@exchange.microsoft.com wrote:
> - default:
> + case(VERSION_WIN10):
> util_fw_version = UTIL_FW_VERSION;
> sd_srv_version = SD_VERSION;
> ts_srv_version = TS_VERSION;
> hb_srv_version = HB_VERSION;
> +
On Mon, Aug 29, Michal Hocko wrote:
> On Mon 29-08-16 16:52:03, Olaf Hering wrote:
> > I ran rc3 for a few hours on Friday amd FireFox was not killed.
> > Now rc3 is running for a day with the usual workload and FireFox is
> > still running.
> Is the patch
>
On Mon, Aug 29, Olaf Hering wrote:
> Full dmesg attached.
Now..
dmesg-4.8.0-rc3-3.bug994066-default.txt.gz
Description: GNU Zip compressed data
signature.asc
Description: PGP signature
On Thu, Aug 25, Olaf Hering wrote:
> On Thu, Aug 25, Michal Hocko wrote:
>
> > Any luck with the testing of this patch?
I ran rc3 for a few hours on Friday amd FireFox was not killed.
Now rc3 is running for a day with the usual workload and FireFox is
still running.
Today I
On Thu, Aug 25, Michal Hocko wrote:
> Any luck with the testing of this patch?
Not this week, sorry.
Olaf
signature.asc
Description: PGP signature
On Thu, Jun 30, Dexuan Cui wrote:
> +/* The MTU is 16KB per the host side's design. */
> +struct hvsock_recv_buf {
> + unsigned int data_len;
> + unsigned int data_offset;
> +
> + struct vmpipe_proto_header hdr;
> + u8 buf[PAGE_SIZE * 4];
Please use some macro related to the proto
On Thu, Jun 30, Olaf Hering wrote:
> On Thu, Jun 30, Dexuan Cui wrote:
>
> > -#define AF_MAX 43 /* For now.. */
> > +#define AF_MAX 44 /* For now.. */
>
> Should this patch also change the places where AF_MAX is used,
> like all th
On Thu, Jun 30, Dexuan Cui wrote:
> -#define AF_MAX 43 /* For now.. */
> +#define AF_MAX 44 /* For now.. */
Should this patch also change the places where AF_MAX is used,
like all the arrays in net/core/sock.c?
Olaf
signature.asc
Description: PGP signature
On Thu, Jun 09, James Bottomley wrote:
> On Thu, 2016-06-09 at 18:25 +0200, Olaf Hering wrote:
> > Reducing the sg_tablesize allows booting of 32bit kernels in VMs,
> > after
> > commit be0cf6ca301c61458dc4aa1a37acf4f58d2ed3d6 ("scsi: storvsc: Set
> > the
> &
Reducing the sg_tablesize allows booting of 32bit kernels in VMs, after
commit be0cf6ca301c61458dc4aa1a37acf4f58d2ed3d6 ("scsi: storvsc: Set the
tablesize based on the information given by the host")
[5.567138] hv_storvsc vmbus_1: adjusting sg_tablesize 0x800 -> 0x20
Signed
On Mon, May 16, Joseph Salisbury wrote:
> > CONFIG_64BIT=y
> It doesn't appear this patch ever landed in Mainline. Olaf, do you have
> plans to submit this patch?
Yes, will do.
Olaf
members as
needed. This also gives the correct size for the buffer (~6K instead of 64K).
Signed-off-by: Olaf Hering
---
tools/hv/hv_fcopy_daemon.c | 31 ---
1 file changed, 16 insertions(+), 15 deletions(-)
diff --git a/tools/hv/hv_fcopy_daemon.c b/tools/hv
On Wed, Apr 20, Stefano Stabellini wrote:
> b4ff8389ed14 is incomplete: relies on nr_legacy_irqs() to get the number
> of legacy interrupts when actually nr_legacy_irqs() returns 0 after
> probe_8259A(). Use NR_IRQS_LEGACY instead.
>
> Signed-off-by: Stefano Stabellini
Tested-
At some point each disk had its size exported via
/sys/dev/block/$mm/device/size. Now this moved to
/sys/dev/block/$mm/device/block/*/size.
Why was this interface changed?
Olaf
On Wed, Jan 27, K. Y. Srinivasan wrote:
> + depends on SCSI_FC_ATTRS
I think 'depends' instead of 'select' will cause HYPERV_STORAGE to
disapepar during make oldconfig if SCSI_FC_ATTRS was not set before.
Not sure what the policy of 'depends' vs. 'select' actually is. If
SCSI_FC_ATTRS is su
On Wed, Jan 27, James Bottomley wrote:
> It's not really architecture independent, is it? Just use the bit
> width config.
Again: which one? This driver is not for mips|powerpc|score|sh.
Olaf
On Tue, Jan 26, Dexuan Cui wrote:
> +#define AF_MAX 42 /* For now.. */
Maybe net/core/sock.c needs additional strings for the new socket?
Olaf
On Fri, Oct 02, Olaf Hering wrote:
> On Thu, Oct 01, James Bottomley wrote:
>
> > On Thu, 2015-10-01 at 20:30 +, KY Srinivasan wrote:
>
> > > > +#if defined(CONFIG_X86_32)
>
> > Um, this is a bit architecture specific (I know Azure is x86, but
> &
icframe_vercnt/icmsg_vercnt. But the host ignores that and
continues to send ICMSGTYPE_NEGOTIATE messages. The result are weird
errors during boot and general misbehaviour.
Check the Windows version to work around the host bug, skip hv_vss_init
on WS2012 and older.
Signed-off-by: Olaf Hering
---
v2
On Wed, Oct 14, Ilia Mirkin wrote:
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=25d295882a1adfcdaaad85369289677b87c7c8f0
Thanks.
Almost perfect, lacks a stable tag.
Olaf
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a me
On Sun, Oct 11, Laurent Vivier wrote:
> On PowerMac G5 (and I think on all OpenFirmware platforms), nvbios_pcirTp()
> returns NULL. But in fact the OpenFirmware has given us the size
> we can store in image->size.
> CC: imir...@alum.mit.edu
> Signed-off-by: Laurent Vivier
icframe_vercnt/icmsg_vercnt. But the host ignores that and
continues to send ICMSGTYPE_NEGOTIATE messages. The result are weird
errors during boot and general misbehaviour.
Check the Windows version to work around the host bug, skip hv_vss_init
on WS2012 and older.
Signed-off-by: Olaf Hering
On Fri, Oct 09, Olaf Hering wrote:
> On Thu, Oct 08, KY Srinivasan wrote:
>
> > > yes, but after doing fcopy_respond_to_host(). I'd suggest we leave the
> > > check in place, better safe than sorry.
> >
> > Agreed; Olaf, if it is ok with you, I can fi
On Fri, Oct 09, Vitaly Kuznetsov wrote:
> Olaf Hering writes:
>
> > On Thu, Oct 08, KY Srinivasan wrote:
> >
> >> > yes, but after doing fcopy_respond_to_host(). I'd suggest we leave the
> >> > check in place, better safe than sorry.
> >>
On Thu, Oct 08, KY Srinivasan wrote:
> > yes, but after doing fcopy_respond_to_host(). I'd suggest we leave the
> > check in place, better safe than sorry.
>
> Agreed; Olaf, if it is ok with you, I can fix it up and send.
I will retest with this part reverted. I think without two code paths
ente
On Thu, Oct 08, Vitaly Kuznetsov wrote:
> > @@ -295,9 +288,6 @@ static int fcopy_on_msg(void *msg, int len)
> > if (fcopy_transaction.state == HVUTIL_DEVICE_INIT)
> > return fcopy_handle_handshake(*val);
> >
> > - if (fcopy_transaction.state != HVUTIL_USERSPACE_REQ)
> > -
On Wed, Oct 07, K. Y. Srinivasan wrote:
> Util services such as KVP and FCOPY need assistance from daemon's running
> in user space. Increase the timeout so we don't prematurely terminate
> the transaction in the kernel.
Is this an arbitrary number, or does the host allow such a large delay
for t
rst interrupt after
negociation.
Signed-off-by: Olaf Hering
---
drivers/hv/hv_fcopy.c | 37 +
drivers/hv/hv_kvp.c | 28 ++--
drivers/hv/hv_snapshot.c | 29 +++--
drivers/hv/hyperv_vmbus.h | 6 +-
Various hyperv changes, based on v4.3-rc4 linux.git
Olaf
Olaf Hering (5):
Drivers: hv: utils: run polling callback always in interrupt context
tools: hv: report ENOSPC errors in hv_fcopy_daemon
tools: hv: remove repeated HV_FCOPY string
Drivers: hv: util: catch allocation errors
Use memdup_user to handle OOM.
Fixes: 14b50f80c32d ('Drivers: hv: util: introduce hv_utils_transport
abstraction')
Signed-off-by: Olaf Hering
---
drivers/hv/hv_utils_transport.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/hv/hv_utils_tra
Currently some "Unspecified error 0x80004005" is reported on the Windows
side if something fails. Handle the ENOSPC case and return
ERROR_DISK_FULL, which allows at least Copy-VMFile to report a meaning
full error.
Signed-off-by: Olaf Hering
---
include/uapi/linux/hyperv.h | 1 +
HV_FCOPY is already used as identifier in syslog.
Signed-off-by: Olaf Hering
---
tools/hv/hv_fcopy_daemon.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/hv/hv_fcopy_daemon.c b/tools/hv/hv_fcopy_daemon.c
index f1d7426..fdc9ca4 100644
--- a/tools/hv
Catch allocation errors in hvutil_transport_send.
Fixes: 14b50f80c32d ('Drivers: hv: util: introduce hv_utils_transport
abstraction')
Signed-off-by: Olaf Hering
---
drivers/hv/hv_utils_transport.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/
On Thu, Oct 01, James Bottomley wrote:
> On Thu, 2015-10-01 at 20:30 +, KY Srinivasan wrote:
> > > +#if defined(CONFIG_X86_32)
> Um, this is a bit architecture specific (I know Azure is x86, but
> still). Can you make the define check CONFIG_32BIT rather than
> CONFIG_X86_32?
According to
The header might be in /usr/include/ncursesw, which is not
part of the standard include path. This fixes compile on openSUSE.
Signed-off-by: Olaf Hering
---
tools/thermal/tmon/Makefile | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tools/thermal/tmon/Makefile b/tools/thermal/tmon
Catch allocation errors in hvt_op_write and hvutil_transport_send.
Fixes: 14b50f80c32d ('Drivers: hv: util: introduce hv_utils_transport
abstraction')
Signed-off-by: Olaf Hering
---
drivers/hv/hv_utils_transport.c | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
di
On Mon, Sep 21, Vitaly Kuznetsov wrote:
> I'd like to see a trace from the hang, it is not obvious to me how it
> happened and what caused it. (or if you have such hang scenario in your
> head, can you please reveal it?)
There is no trace. I think fcopy_respond_to_host notifies the host,
which in
On Sun, Sep 20, Greg KH wrote:
> Just use a lock, that's what it is there for.
How would that help? It might help because it enforces ordering. But
that requires that all three utils get refactored to deal with the
introduced locking. I will let KY comment on this.
The issue I see with fcopy is
On Sun, Sep 20, Greg KH wrote:
> On Tue, Sep 15, 2015 at 05:37:53PM -0700, K. Y. Srinivasan wrote:
> > @@ -122,8 +125,8 @@ static void kvp_timeout_func(struct work_struct *dummy)
> > + if (kvp_get_state() > HVUTIL_READY)
> > + kvp_set_state(HVUTIL_READY);
> And what if the state chan
1 - 100 of 609 matches
Mail list logo
