Re: [PATCH v2] Persistent grant maps for xen blk drivers

2012-09-27 Thread Oliver Chick
Wilk wrote: > On Fri, Sep 21, 2012 at 04:52:47PM +0100, Oliver Chick wrote: > > This patch implements persistent grants for the xen-blk{front,back} > > mechanism. The effect of this change is to reduce the number of unmap > > operations performed, since they cause a (costly) TLB

[PATCH v2] Persistent grant maps for xen blk drivers

2012-09-21 Thread Oliver Chick
in granting, and ending foreign access. Signed-off-by: Oliver Chick --- Changes since v1: * Maximum number of persistent grants per device now 64, rather than 256, as this is the actual maxmimum request in a (1 page) ring. * If blkfront supplies more grefs than it is meant to, to blkbac

[PATCH] Change xen_vbd's flush_support and discard_secure to have type unsigned int, rather than bool

2012-09-21 Thread Oliver Chick
Changing the type of bdev parameters to be unsigned int :1, rather than bool. This is more consistent with the types of other features in the block drivers. Signed-off-by: Oliver Chick --- drivers/block/xen-blkback/common.h |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

Re: [Xen-devel] [PATCH] Persistent grant maps for xen blk drivers

2012-09-21 Thread Oliver Chick
On Fri, 2012-09-21 at 08:18 +0100, Jan Beulich wrote: > >>> On 20.09.12 at 23:24, Konrad Rzeszutek Wilk > >>> wrote: > > On Thu, Sep 20, 2012 at 03:13:42PM +0100, Oliver Chick wrote: > >> On Thu, 2012-09-20 at 14:49 +0100, Konrad Rzeszutek Wilk wrote: &g

Re: [Xen-devel] [PATCH] Persistent grant maps for xen blk drivers

2012-09-20 Thread Oliver Chick
On Thu, 2012-09-20 at 14:49 +0100, Konrad Rzeszutek Wilk wrote: > On Thu, Sep 20, 2012 at 12:48:41PM +0100, Jan Beulich wrote: > > >>> On 20.09.12 at 13:30, Oliver Chick wrote: > > > The memory overhead, and fallback mode points are related: > > > -Firstl

Re: [PATCH] Persistent grant maps for xen blk drivers

2012-09-20 Thread Oliver Chick
Thank you for all your useful feedback, Konrad. I have made most of the changes you suggest. I will test them and repost. I have made a few points below. On Wed, 2012-09-19 at 15:11 +0100, Konrad Rzeszutek Wilk wrote: > On Wed, Sep 19, 2012 at 11:51:27AM +0100, Oliver Chick wrote: > > T

Re: [Xen-devel] [PATCH] Persistent grant maps for xen blk drivers

2012-09-20 Thread Oliver Chick
abel wrote: > On 19/09/12 11:51, Oliver Chick wrote: > > This patch implements persistent grants for the xen-blk{front,back} > > mechanism. > [...] > > We (ijc, and myself) have introduced a new constant, > > BLKIF_MAX_PERS_REQUESTS_PER_DEV. This is to prevent a malic

Re: [Xen-devel] [PATCH] Persistent grant maps for xen blk drivers

2012-09-20 Thread Oliver Chick
guest does an fio sequential read of the ramdisk, then 2, then 3 etc. -The y axis is the sum of the iops, as reported by the guests' fio output. On Wed, 2012-09-19 at 14:16 +0100, X5650Pasi Kärkkäinen wrote: > On Wed, Sep 19, 2012 at 11:51:27AM +0100, Oliver Chick wrote: > > This pa

Re: [Xen-devel] [PATCH] Persistent grant maps for xen blk drivers

2012-09-20 Thread Oliver Chick
? On Wed, 2012-09-19 at 13:03 +0100, Jan Beulich wrote: > >>> On 19.09.12 at 12:51, Oliver Chick wrote: > > +/* > > + * Maximum number of persistent grants that can be mapped by Dom0 for each > > + * interface. This is set to be the size of the ring, as this is a limi

[PATCH] Persistent grant maps for xen blk drivers

2012-09-19 Thread Oliver Chick
s of not performing TLB shootdowns. The answer to that question is `no'. There appears to be very little, if any additional cost to the guest of using persistent grants. There is perhaps a small saving, from the reduced number of hypercalls performed in granting, and ending foreign access. Sig