Re: [PATCH v3 0/7] mm/kvm: Improve parallelism for access bit harvesting

2024-04-19 Thread Oliver Upton
On Fri, Apr 19, 2024 at 01:57:03PM -0700, James Houghton wrote: > On Fri, Apr 12, 2024 at 11:41 AM David Matlack wrote: > > > > On 2024-04-01 11:29 PM, James Houghton wrote: > > > This patchset adds a fast path in KVM to test and clear access bits on > > > sptes without taking the mmu_lock. It

Re: [PATCH v3 6/7] KVM: arm64: Participate in bitmap-based PTE aging

2024-04-02 Thread Oliver Upton
On Tue, Apr 02, 2024 at 12:06:56AM -0400, Yu Zhao wrote: > On Mon, Apr 1, 2024 at 7:30 PM James Houghton wrote: > > Suggested-by: Yu Zhao > > Thanks but I did not suggest this. Entirely up to you, but I would still want to credit everyone who contributed to a feature even if the underlying

Re: [BUG]: KVM: arm64: Fix symbol dependency in __hyp_call_panic_nvhe

2021-01-26 Thread Oliver Upton
On Mon, Jan 25, 2021 at 12:56 PM Marc Zyngier wrote: > - Cherry-pick 9fd339a45be5 ("arm64: Work around broken GCC 4.9 > handling of "S" constraint"), which works around this particular GCC > bug > > - Cherry-pick dca5244d2f5b ("compiler.h: Raise minimum version of GCC > to 5.1 for arm64"),

Re: [BUG]: KVM: arm64: Fix symbol dependency in __hyp_call_panic_nvhe

2021-01-25 Thread Oliver Upton
> That means we have two options: > (a) define __hyp_panic_string in a different .c file in all pre-5.9 branches, > or > (b) revert the backported patch. > > The patch was needed in 5.9 and should stay there. It wasn't needed in earlier > versions because the symbol was being kept alive by

Re: [PATCH v2 1/3] KVM: x86: implement KVM_{GET|SET}_TSC_STATE

2020-12-10 Thread Oliver Upton
On Thu, Dec 10, 2020 at 12:05 PM Paolo Bonzini wrote: > > On 10/12/20 18:59, Oliver Upton wrote: > > However, I don't believe we can assume the guest's TSCs to be synchronized, > > even if sane guests will never touch them. In this case, I think a per-vCPU > > ioctl is s

Re: [PATCH v2 1/3] KVM: x86: implement KVM_{GET|SET}_TSC_STATE

2020-12-10 Thread Oliver Upton
On Thu, Dec 10, 2020 at 9:16 AM Andy Lutomirski wrote: > > > > > On Dec 10, 2020, at 6:52 AM, Maxim Levitsky wrote: > > > > On Thu, 2020-12-10 at 12:48 +0100, Paolo Bonzini wrote: > >>> On 08/12/20 22:20, Thomas Gleixner wrote: > >>> So now life migration comes a long time after timekeeping had

Re: [PATCH v2 1/3] KVM: x86: implement KVM_{GET|SET}_TSC_STATE

2020-12-08 Thread Oliver Upton
+cc Sean's new handle On Tue, Dec 8, 2020 at 9:57 AM Oliver Upton wrote: > > On Tue, Dec 8, 2020 at 5:13 AM Maxim Levitsky wrote: > > > > On Mon, 2020-12-07 at 11:29 -0600, Oliver Upton wrote: > > > On Thu, Dec 3, 2020 at 11:12 AM Maxim Levitsky > > > wrote

Re: [PATCH v2 1/3] KVM: x86: implement KVM_{GET|SET}_TSC_STATE

2020-12-08 Thread Oliver Upton
On Tue, Dec 8, 2020 at 5:13 AM Maxim Levitsky wrote: > > On Mon, 2020-12-07 at 11:29 -0600, Oliver Upton wrote: > > On Thu, Dec 3, 2020 at 11:12 AM Maxim Levitsky wrote: > > > These two new ioctls allow to more precisly capture and > > > restore guest's TSC

Re: [PATCH v2 1/3] KVM: x86: implement KVM_{GET|SET}_TSC_STATE

2020-12-07 Thread Oliver Upton
On Thu, Dec 3, 2020 at 11:12 AM Maxim Levitsky wrote: > > These two new ioctls allow to more precisly capture and > restore guest's TSC state. > > Both ioctls are meant to be used to accurately migrate guest TSC > even when there is a significant downtime during the migration. > > Suggested-by:

Re: [PATCH] KVM: nVMX: Morph notification vector IRQ on nested VM-Enter to pending PI

2020-10-06 Thread Oliver Upton
On Tue, Oct 6, 2020 at 11:35 AM Sean Christopherson wrote: > > On Tue, Oct 06, 2020 at 10:36:09AM -0700, Jim Mattson wrote: > > On Wed, Aug 12, 2020 at 10:51 AM Sean Christopherson > > wrote: > > > > > > On successful nested VM-Enter, check for pending interrupts and convert > > > the highest

Re: [PATCH] kvm: x86: fix reversed timespec values in PV wall clock

2020-07-24 Thread Oliver Upton
On Fri, Jul 24, 2020 at 10:35 AM Oliver Upton wrote: > > commit 8171cd68806b ("KVM: x86: use raw clock values consistently") > causes KVM to accidentally write seconds to the nanoseconds field (and > vice versa) in the KVM wall clock. Fix it by reversing this accid

[PATCH] kvm: x86: fix reversed timespec values in PV wall clock

2020-07-24 Thread Oliver Upton
the amount of time represented as seconds. Fixes: 8171cd68806b ("KVM: x86: use raw clock values consistently") Cc: sta...@vger.kernel.org Reviewed-by: Jim Mattson Reviewed-by: Peter Shier Signed-off-by: Oliver Upton --- Parent commit: c34b26b98cac ("KVM: MIPS: clean up redund

Re: [PATCH v2] KVM: nVMX: Consult only the "basic" exit reason when routing nested exit

2020-06-08 Thread Oliver Upton
"KVM: nVMX: Deciding if L0 or L1 should handle an L2 > exit") > Cc: Jim Mattson > Cc: Xiaoyao Li > Cc: sta...@vger.kernel.org > Cc: Oliver Upton > Cc: Krish Sadhukhan > Cc: Miaohe Lin > Signed-off-by: Sean Christopherson Reviewed-by: Oliver Upton > ---

Re: [PATCH] KVM: x86: allow KVM_STATE_NESTED_MTF_PENDING in kvm_state flags

2020-05-19 Thread Oliver Upton
e MTF when performing instruction > emulation") > Cc: sta...@vger.kernel.org > Signed-off-by: Paolo Bonzini Reviewed-by: Oliver Upton > --- > arch/x86/kvm/x86.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/kvm/x86.c b/arch/x86/kv

Re: [PATCH] KVM: Fix a warning in __kvm_gfn_to_hva_cache_init()

2020-05-11 Thread Oliver Upton
On Mon, May 11, 2020 at 9:05 AM Sean Christopherson wrote: > > +cc a few other people that have reported this at one time or another. > > On Tue, May 05, 2020 at 10:12:45AM -0400, Peter Xu wrote: > > On Mon, May 04, 2020 at 06:39:29PM -0700, Sean Christopherson wrote: > > > On Mon, May 04, 2020

Re: [PATCH 01/13] KVM: nVMX: Preserve exception priority irrespective of exiting behavior

2020-04-28 Thread Oliver Upton
t; > be addressed in a future patch. > > > > Fixes: b6b8a1451fc4 ("KVM: nVMX: Rework interception of IRQs and NMIs") > > Reported-by: Jim Mattson > > Cc: Oliver Upton > > Cc: Peter Shier > > Signed-off-by: Sean Christopherson > Reviewed-by: Jim Mattson Reviewed-by: Oliver Upton