Re: [dm-devel] [RFC] dm-crypt: add ability to use keys from the kernel key retention service

2016-08-10 Thread Ondrej Kozina
On 08/09/2016 03:56 PM, Andrey Ryabinin wrote: Hi Andrey, I'm definitely in favour of dm-crypt with support for kernel keyring service, but I think this patch do lack in addressing few issues: Currently the dm-crypt guarantees that on remove ioctl command the volume key gets deleted from

Re: [dm-devel] [RFC] dm-crypt: add ability to use keys from the kernel key retention service

2016-08-10 Thread Ondrej Kozina
On 08/09/2016 03:56 PM, Andrey Ryabinin wrote: Hi Andrey, I'm definitely in favour of dm-crypt with support for kernel keyring service, but I think this patch do lack in addressing few issues: Currently the dm-crypt guarantees that on remove ioctl command the volume key gets deleted from

Re: System freezes after OOM

2016-07-14 Thread Ondrej Kozina
On 07/14/2016 05:31 PM, Michal Hocko wrote: On Thu 14-07-16 16:08:28, Ondrej Kozina wrote: [...] As Mikulas pointed out, this doesn't work. The system froze as well with the patch above. Will try to tweak the patch with Mikulas's suggestion... Thank you for testing! Do you happen to have

Re: System freezes after OOM

2016-07-14 Thread Ondrej Kozina
On 07/14/2016 05:31 PM, Michal Hocko wrote: On Thu 14-07-16 16:08:28, Ondrej Kozina wrote: [...] As Mikulas pointed out, this doesn't work. The system froze as well with the patch above. Will try to tweak the patch with Mikulas's suggestion... Thank you for testing! Do you happen to have

Re: System freezes after OOM

2016-07-14 Thread Ondrej Kozina
On 07/14/2016 04:59 PM, Michal Hocko wrote: On Thu 14-07-16 10:00:16, Mikulas Patocka wrote: On Thu, 14 Jul 2016, Michal Hocko wrote: On Wed 13-07-16 11:02:15, Mikulas Patocka wrote: diff --git a/drivers/md/dm-crypt.c b/drivers/md/dm-crypt.c index 4f3cb3554944..0b806810efab 100644 ---

Re: System freezes after OOM

2016-07-14 Thread Ondrej Kozina
On 07/14/2016 04:59 PM, Michal Hocko wrote: On Thu 14-07-16 10:00:16, Mikulas Patocka wrote: On Thu, 14 Jul 2016, Michal Hocko wrote: On Wed 13-07-16 11:02:15, Mikulas Patocka wrote: diff --git a/drivers/md/dm-crypt.c b/drivers/md/dm-crypt.c index 4f3cb3554944..0b806810efab 100644 ---

Re: System freezes after OOM

2016-07-14 Thread Ondrej Kozina
On 07/14/2016 02:51 PM, Michal Hocko wrote: On Wed 13-07-16 11:02:15, Mikulas Patocka wrote: On Wed, 13 Jul 2016, Michal Hocko wrote: [...] We are discussing several topics together so let's focus on this particlar thing for now The kernel 4.7-rc almost deadlocks in another way. The machine

Re: System freezes after OOM

2016-07-14 Thread Ondrej Kozina
On 07/14/2016 02:51 PM, Michal Hocko wrote: On Wed 13-07-16 11:02:15, Mikulas Patocka wrote: On Wed, 13 Jul 2016, Michal Hocko wrote: [...] We are discussing several topics together so let's focus on this particlar thing for now The kernel 4.7-rc almost deadlocks in another way. The machine

Re: [dm-devel] System freezes after OOM

2016-07-14 Thread Ondrej Kozina
On 07/13/2016 05:02 PM, Mikulas Patocka wrote: On Wed, 13 Jul 2016, Michal Hocko wrote: On Tue 12-07-16 19:44:11, Mikulas Patocka wrote: The problem of swapping to dm-crypt is this. The free memory goes low, kswapd decides that some page should be swapped out. However, when you swap to an

Re: [dm-devel] System freezes after OOM

2016-07-14 Thread Ondrej Kozina
On 07/13/2016 05:02 PM, Mikulas Patocka wrote: On Wed, 13 Jul 2016, Michal Hocko wrote: On Tue 12-07-16 19:44:11, Mikulas Patocka wrote: The problem of swapping to dm-crypt is this. The free memory goes low, kswapd decides that some page should be swapped out. However, when you swap to an

Re: [dm-devel] Page Allocation Failures/OOM with dm-crypt on software RAID10 (Intel Rapid Storage)

2016-07-13 Thread Ondrej Kozina
On 07/13/2016 05:32 PM, Matthias Dahl wrote: No matter what, I have no clue how to further diagnose this issue. And given that I already had unsolvable issues with dm-crypt a couple of months ago with my old machine where the system simply hang itself or went OOM when the swap was encrypted and

Re: [dm-devel] Page Allocation Failures/OOM with dm-crypt on software RAID10 (Intel Rapid Storage)

2016-07-13 Thread Ondrej Kozina
On 07/13/2016 05:32 PM, Matthias Dahl wrote: No matter what, I have no clue how to further diagnose this issue. And given that I already had unsolvable issues with dm-crypt a couple of months ago with my old machine where the system simply hang itself or went OOM when the swap was encrypted and

Re: [dm-devel] [4.4, 4.5, 4.6] Regression: encrypted swap (dm-crypt) freezes system while under memory pressure and swapping

2016-05-05 Thread Ondrej Kozina
On 04/21/2016 09:48 AM, Matthias Dahl wrote: Hello @all, first of all, I sent this exact msg also to the lkml a few days ago but since I received no reaction, I thought this list might be a better place for this problem -- or I might at least reach the right persons to get this

Re: [dm-devel] [4.4, 4.5, 4.6] Regression: encrypted swap (dm-crypt) freezes system while under memory pressure and swapping

2016-05-05 Thread Ondrej Kozina
On 04/21/2016 09:48 AM, Matthias Dahl wrote: Hello @all, first of all, I sent this exact msg also to the lkml a few days ago but since I received no reaction, I thought this list might be a better place for this problem -- or I might at least reach the right persons to get this

Re: [dm-devel] [PATCH 0/3] dm-crypt: Adds support for wiping key when doing suspend/hibernation

2015-04-17 Thread Ondrej Kozina
On 04/17/2015 09:52 AM, Mike Snitzer wrote: On Thu, Apr 16 2015 at 5:23am -0400, Alex Elsayed wrote: Mike Snitzer wrote: On Thu, Apr 09 2015 at 9:28am -0400, Pali Rohár wrote: On Thursday 09 April 2015 09:12:08 Mike Snitzer wrote: On Mon, Apr 06 2015 at 9:29am -0400, Pali Rohár

Re: [dm-devel] [PATCH 0/3] dm-crypt: Adds support for wiping key when doing suspend/hibernation

2015-04-17 Thread Ondrej Kozina
On 04/17/2015 09:52 AM, Mike Snitzer wrote: On Thu, Apr 16 2015 at 5:23am -0400, Alex Elsayed eternal...@gmail.com wrote: Mike Snitzer wrote: On Thu, Apr 09 2015 at 9:28am -0400, Pali Rohár pali.ro...@gmail.com wrote: On Thursday 09 April 2015 09:12:08 Mike Snitzer wrote: On Mon, Apr 06