Re: [PATCH][next][resend] lib/mpi: fix off-by-one check on index "no"

2020-09-30 Thread Ondrej Mosnáček
st 30. 9. 2020 o 15:04 Colin King napísal(a): > > From: Colin Ian King > > There is an off-by-one range check on the upper limit of > index "no". Fix this by changing the > comparison to >= Note that this doesn't completely fix the bug though... (see below) > > Addresses-Coverity:

Re: [patch 2/9] crypto: aegis - Cleanup license mess

2019-01-18 Thread Ondrej Mosnáček
pi 18. 1. 2019 o 0:15 Thomas Gleixner napísal(a): > Precise and non-ambiguous license information is important. The recently > added aegis header file has a SPDX license identifier, which is nice, but > at the same time it has a contradictionary license boiler plate text. > >

Re: [patch 5/9] crypto: morus - Convert to SPDX license identifiers

2019-01-18 Thread Ondrej Mosnáček
pi 18. 1. 2019 o 0:15 Thomas Gleixner napísal(a): > The license boiler plate text is not ideal for machine parsing. The kernel > uses SPDX license identifiers for that purpose, which replace the boiler > plate text. > > Signed-off-by: Thomas Gleixner > Cc: Ondrej Mosnacek > Cc: Herbert Xu >

Re: [patch 4/9] crypto: aegis - Convert to SPDX license identifiers

2019-01-18 Thread Ondrej Mosnáček
pi 18. 1. 2019 o 0:15 Thomas Gleixner napísal(a): > The license boiler plate text is not ideal for machine parsing. The kernel > uses SPDX license identifiers for that purpose, which replace the boiler > plate text. > > Signed-off-by: Thomas Gleixner > Cc: Ondrej Mosnacek > Cc: Herbert Xu >

Re: [patch 3/9] crypto: morus - Cleanup license mess

2019-01-18 Thread Ondrej Mosnáček
pi 18. 1. 2019 o 0:15 Thomas Gleixner napísal(a): > Precise and non-ambiguous license information is important. The recently > added morus header files have a SPDX license identifier, which is nice, but > at the same time they have a contradictionary license boiler plate text. > >

Re: [PATCH] crypto/morus(640,1280) - make crypto_...-algs static

2018-09-27 Thread Ondrej Mosnáček
št 27. 9. 2018 o 0:50 napísal(a): > sparse complains thusly: > > CHECK arch/x86/crypto/morus640-sse2-glue.c > arch/x86/crypto/morus640-sse2-glue.c:38:1: warning: symbol > 'crypto_morus640_sse2_algs' was not declared. Should it be static? > CHECK arch/x86/crypto/morus1280-sse2-glue.c >

Re: [PATCH] crypto/morus(640,1280) - make crypto_...-algs static

2018-09-27 Thread Ondrej Mosnáček
št 27. 9. 2018 o 0:50 napísal(a): > sparse complains thusly: > > CHECK arch/x86/crypto/morus640-sse2-glue.c > arch/x86/crypto/morus640-sse2-glue.c:38:1: warning: symbol > 'crypto_morus640_sse2_algs' was not declared. Should it be static? > CHECK arch/x86/crypto/morus1280-sse2-glue.c >

Re: linux-next: build failure after merge of the crypto tree

2018-05-29 Thread Ondrej Mosnáček
Hi Stephen, there is already a patch pending that fixes the issue: https://patchwork.kernel.org/patch/10416245/ Cheers, Ondrej 2018-05-29 11:08 GMT+02:00 Stephen Rothwell : > Hi Herbert, > > After merging the crypto tree, today's linux-next build (powerpc > allyesconfig) failed like this: > >

Re: linux-next: build failure after merge of the crypto tree

2018-05-29 Thread Ondrej Mosnáček
Hi Stephen, there is already a patch pending that fixes the issue: https://patchwork.kernel.org/patch/10416245/ Cheers, Ondrej 2018-05-29 11:08 GMT+02:00 Stephen Rothwell : > Hi Herbert, > > After merging the crypto tree, today's linux-next build (powerpc > allyesconfig) failed like this: > >

Re: [PATCH] crypto: morus - Hide Kconfig option for glue code

2018-05-28 Thread Ondrej Mosnáček
(Resending in plaintext because Gmail for Android sucks...) Hi Arnd, I have already addressed that in a follow-up patch here: https://patchwork.kernel.org/patch/10416245/ Regards, Ondrej 2018-05-28 17:47 GMT+02:00 Arnd Bergmann : > Enabling the glue drivers for morus640 and/or morus1280 leads

Re: [PATCH] crypto: morus - Hide Kconfig option for glue code

2018-05-28 Thread Ondrej Mosnáček
(Resending in plaintext because Gmail for Android sucks...) Hi Arnd, I have already addressed that in a follow-up patch here: https://patchwork.kernel.org/patch/10416245/ Regards, Ondrej 2018-05-28 17:47 GMT+02:00 Arnd Bergmann : > Enabling the glue drivers for morus640 and/or morus1280 leads

Re: [RFC PATCH v2] crypto: Add IV generation algorithms

2017-01-11 Thread Ondrej Mosnáček
Hi Binoy, 2016-12-13 9:49 GMT+01:00 Binoy Jayan : > Currently, the iv generation algorithms are implemented in dm-crypt.c. > The goal is to move these algorithms from the dm layer to the kernel > crypto layer by implementing them as template ciphers so they can be >

Re: [RFC PATCH v2] crypto: Add IV generation algorithms

2017-01-11 Thread Ondrej Mosnáček
Hi Binoy, 2016-12-13 9:49 GMT+01:00 Binoy Jayan : > Currently, the iv generation algorithms are implemented in dm-crypt.c. > The goal is to move these algorithms from the dm layer to the kernel > crypto layer by implementing them as template ciphers so they can be > implemented in hardware for