Re: linux-next: manual merge of the net-next tree with the net tree

2018-12-19 Thread Or Gerlitz
On Thu, Dec 20, 2018 at 4:47 AM Stephen Rothwell wrote: > > Hi all, > > Today's linux-next merge of the net-next tree got a conflict in: > > drivers/net/ethernet/mellanox/mlx5/core/en_rep.c > > between commit: > > 8956f0014ea5 ("net/mlx5e: Fix default amount of channels for VF > representors"

Re: linux-next: manual merge of the net-next tree with the net tree

2018-12-17 Thread Or Gerlitz
On Mon, Dec 17, 2018 at 11:29 PM Saeed Mahameed wrote: > On Sun, Dec 16, 2018 at 4:25 PM Stephen Rothwell > wrote: > > I fixed it up (see below) and can carry the fix as necessary. This > Looks good to me. here too > > Today's linux-next merge of the net-next tree got a conflict in: > > d

Re: linux-next: manual merge of the net-next tree with the net tree

2018-12-10 Thread Or Gerlitz
On Mon, Dec 10, 2018 at 3:38 AM Stephen Rothwell wrote: > > Hi all, > > Today's linux-next merge of the net-next tree got a conflict in: > > net/sched/cls_flower.c > > between commit: > > 35cc3cefc4de ("net/sched: cls_flower: Reject duplicated rules also under > skip_sw") > > from the net tre

Re: [PATCH] IB/mlx5: avoid binding a new mpi unit to the same devices repeatedly

2018-07-14 Thread Or Gerlitz
On Sat, Jul 14, 2018 at 2:50 AM, Qing Huang wrote: > When a CX5 device is configured in dual-port RoCE mode, after creating > many VFs against port 1, creating the same number of VFs against port 2 > will flood kernel/syslog with something like > "mlx5_*:mlx5_ib_bind_slave_port:4266:(pid 5269): po

Re: [PATCH 13/14] net: sched: use unique idr insert function in unlocked actions

2018-05-20 Thread Or Gerlitz
On Mon, May 21, 2018 at 12:33 AM, Marcelo Ricardo Leitner wrote: > On Mon, May 21, 2018 at 12:13:06AM +0300, Or Gerlitz wrote: >> On Sun, May 20, 2018 at 1:20 AM, Marcelo Ricardo Leitner >> wrote: >> > On Mon, May 14, 2018 at 05:27:14PM +0300, Vlad Buslov wrote: >>

Re: [PATCH 13/14] net: sched: use unique idr insert function in unlocked actions

2018-05-20 Thread Or Gerlitz
On Sun, May 20, 2018 at 1:20 AM, Marcelo Ricardo Leitner wrote: > On Mon, May 14, 2018 at 05:27:14PM +0300, Vlad Buslov wrote: >> Substitute calls to action insert function with calls to action insert >> unique function that warns if insertion overwrites index in idr. > > I know this patch may be

Re: Setting large MTU size on slave interfaces may stall the whole system

2017-12-13 Thread Or Gerlitz
On Tue, Dec 12, 2017 at 5:21 AM, Qing Huang wrote: > Hi, > > We found an issue with the bonding driver when testing Mellanox devices. > The following test commands will stall the whole system sometimes, with > serial console > flooded with log messages from the bond_miimon_inspect() function. Sett

Re: [PATCH] [net-next] net/mlx5e: select CONFIG_MLXFW

2017-06-28 Thread Or Gerlitz
On Wed, Jun 28, 2017 at 11:10 PM, Arnd Bergmann wrote: > With the introduction of mlx5 firmware flash support, we get a link > error with CONFIG_MLXFW=m and CONFIG_MLX5_CORE=y: > > drivers/net/ethernet/mellanox/mlx5/core/fw.o: In function > `mlx5_firmware_flash': > fw.c:(.text+0x9d4): undefined r

Re: [PATCH] IB/IPoIB: Check the headroom size

2017-04-25 Thread Or Gerlitz
On Tue, Apr 25, 2017 at 2:11 PM, Erez Shitrit wrote: > On Tue, Apr 25, 2017 at 1:32 PM, Or Gerlitz wrote: >> On Tue, Apr 25, 2017 at 12:55 PM, Honggang LI wrote: >>> From: Honggang Li >>> >>> Minimal hard_header_len set by bond_compute_features is

Re: [PATCH] IB/IPoIB: Check the headroom size

2017-04-25 Thread Or Gerlitz
On Tue, Apr 25, 2017 at 12:55 PM, Honggang LI wrote: > From: Honggang Li > > Minimal hard_header_len set by bond_compute_features is ETH_HLEN, which > is smaller than IPOIB_HARD_LEN. ipoib_hard_header should check the > size of headroom to avoid skb_under_panic. sounds terrible, ipoib bonding is

Re: [PATCH] [net-next] net/mlx5e: fix another maybe-uninitialized false-positive

2017-02-05 Thread Or Gerlitz
els") > Signed-off-by: Arnd Bergmann frustrating... I don't see the warning with gcc 5.3.1 [1], but still, the patch is OKay Acked-by: Or Gerlitz [1] I used #make KCFLAGS='-Wmaybe-uninitialized' M=drivers/net/ethernet/mellanox/mlx5/core -j something

Re: [PATCH] [net] net/mlx5e: fix another -Wmaybe-uninitialized warning

2017-01-12 Thread Or Gerlitz
On Thu, Jan 12, 2017 at 6:04 PM, Arnd Bergmann wrote: > On Thursday, January 12, 2017 5:21:49 PM CET Or Gerlitz wrote: >> When I build here without CONFIG_INET in my system, the build goes fine >> with this approach. However, we're pretty sure that in the past we got >

Re: [PATCH] [net] net/mlx5e: fix another -Wmaybe-uninitialized warning

2017-01-12 Thread Or Gerlitz
On 1/11/2017 11:14 PM, Arnd Bergmann wrote: As found by Olof's build bot, today's mainline kernel gained a harmless warning about a potential uninitalied variable reference: drivers/net/ethernet/mellanox/mlx5/core/en_tc.c: In function 'parse_tc_fdb_actions': drivers/net/ethernet/mellanox/mlx5/c

Re: [PATCH] [net] net/mlx5e: fix another -Wmaybe-uninitialized warning

2017-01-12 Thread Or Gerlitz
On 1/11/2017 11:14 PM, Arnd Bergmann wrote: @@ -666,14 +666,15 @@ static int mlx5e_route_lookup_ipv4(struct mlx5e_priv *priv, struct rtable *rt; struct neighbour *n = NULL; int ttl; + int ret; + + if (!IS_ENABLED(CONFIG_INET)) + return -EOPNOTSUP

Re: [PULL REQUEST] Please pull rdma.git

2016-11-19 Thread Or Gerlitz
On Fri, Nov 18, 2016 at 4:01 AM, Doug Ledford wrote: > On 11/17/2016 5:24 PM, Or Gerlitz wrote: [...] > I agree with you. It doesn't fix your patch. The commit message can > still be fixed up. >> Please do not send it to Linus and wait for them to respond. I >>

Re: [PULL REQUEST] Please pull rdma.git

2016-11-17 Thread Or Gerlitz
On Thu, Nov 17, 2016 at 9:44 PM, Doug Ledford wrote: > On 11/17/16 1:49 PM, Leon Romanovsky wrote: >> On Thu, Nov 17, 2016 at 07:13:54AM -0500, Doug Ledford wrote: >>> Hi Linus, >>> >>> Due to various issues, I've been away and couldn't send a pull request >>> for about three weeks. There were a

Re: linux-next: manual merge of the net-next tree with the net tree

2016-11-13 Thread Or Gerlitz
On Thu, Nov 10, 2016 at 1:50 AM, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the net-next tree got a conflict in: > > drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c > > between commit: > ee39fbc4447d ("net/mlx5: E-Switch, Set the actions for offloaded rules >

Re: [PATCH 1/2] net/mlx5e: shut up maybe-uninitialized warning

2016-10-01 Thread Or Gerlitz
ot;net/mlx5e: Add TC vlan action for SRIOV offloads") > Signed-off-by: Arnd Bergmann Yeah, this is clearly false positive and I was sure that newish GCCs don't show that, but you are the master here.. so FWIW Acked-by: Or Gerlitz

Re: [PATCH] net: rtnl: avoid uninitialized data in IFLA_VF_VLAN_LIST handling

2016-09-30 Thread Or Gerlitz
On Fri, Sep 30, 2016 at 7:13 PM, Arnd Bergmann wrote: > With the newly added support for IFLA_VF_VLAN_LIST netlink messages, > we get a warning about potential uninitialized variable use in > the parsing of the user input when enabling the -Wmaybe-uninitialized > warning: > > net/core/rtnetlink.c:

Re: [patch] devlink: clean up a condition

2016-06-16 Thread Or Gerlitz
On 6/16/2016 9:50 AM, Dan Carpenter wrote: Presumably having a _get() function implies that we also have a _set() function but lets make it match when we're calling. Signed-off-by: Dan Carpenter diff --git a/net/core/devlink.c b/net/core/devlink.c index a4f88cb..b2e592a 100644 --- a/net/core/d

Re: [PATCH net-next v3 6/7] vmxnet3: introduce command to register memory region

2016-06-13 Thread Or Gerlitz
On Tue, Jun 14, 2016 at 4:50 AM, Shrikrishna Khare wrote: > +++ b/drivers/net/vmxnet3/vmxnet3_defs.h > @@ -81,6 +81,7 @@ enum { > VMXNET3_CMD_RESERVED2, > VMXNET3_CMD_RESERVED3, > VMXNET3_CMD_SET_COALESCE, > + VMXNET3_CMD_REGISTER_MEMREGS, > > VMXNET3_CMD_FIR

Re: [PATCH net-next v3 0/7] vmxnet3: upgrade to version 3

2016-06-13 Thread Or Gerlitz
On Tue, Jun 14, 2016 at 4:50 AM, Shrikrishna Khare wrote: > This patchset upgrades vmxnet3 to version 3. Except for one patch, all the rest lack change-log, which makes it somehow needlessly harder to review and maintain > Shrikrishna Khare (7): > vmxnet3: prepare for version 3 changes > vmx

Re: [PATCH v5 09/21] IB/hns: Add hca support

2016-05-03 Thread Or Gerlitz
On Tue, May 3, 2016 at 10:57 AM, Wei Hu (Xavier) wrote: > On 2016/4/30 12:33, Or Gerlitz wrote: >> Can you elaborate what design aspects in the driver or anywhere else >> should impose that limitation? > 1. Oulijun resolved the problem, and sent PATCH V6 on 2016-4-28.

Re: [PATCH v5 09/21] IB/hns: Add hca support

2016-04-29 Thread Or Gerlitz
On Wed, Apr 27, 2016 at 6:34 AM, oulijun wrote: > On 2016/4/26 22:25, Jiri Pirko wrote: >> Tue, Apr 26, 2016 at 04:18:21PM CEST, l...@kernel.org wrote: I appreciate your keen eye. this code is meant for ARM64bit therefore should run corretly for 64-bit AARCH64. >> The driver shoul

Re: linux-next: manual merge of the rdma tree with the net-next tree

2016-03-23 Thread Or Gerlitz
is required" means "you can just >>> ignore this entirely". >> I certainly didn't take it that way regardless of the wording. > It was Or Gerlitz. You were cc'd, since it was the whole rdma Mellanox > mess. I quote from that thread: > > "&

Re: [RFC PATCH kernel] Revert "net/mlx4_core: Set UAR page size to 4KB regardless of system page size"

2016-03-19 Thread Or Gerlitz
On Thu, Mar 17, 2016 at 3:40 AM, Alexey Kardashevskiy wrote: > On 03/16/2016 08:45 PM, Or Gerlitz wrote: >> On Wed, Mar 16, 2016 at 10:34 AM, Alexey Kardashevskiy >> wrote: >> >>> Oh. ok. It also looks like even with the reverted patch, mlx4 VF does not >>>

Re: [RFC PATCH kernel] Revert "net/mlx4_core: Set UAR page size to 4KB regardless of system page size"

2016-03-16 Thread Or Gerlitz
On Wed, Mar 16, 2016 at 10:34 AM, Alexey Kardashevskiy wrote: > Oh. ok. It also looks like even with the reverted patch, mlx4 VF does not > work in a guest: So where is the breakage point for you? does 4.4 works? if not, what?

Re: [RFC PATCH kernel] Revert "net/mlx4_core: Set UAR page size to 4KB regardless of system page size"

2016-03-15 Thread Or Gerlitz
On Tue, Mar 15, 2016 at 2:18 PM, Christoph Hellwig wrote: > On Tue, Mar 15, 2016 at 12:40:06PM +0200, Or Gerlitz wrote: >> "[..] Regarding backward compatibility in SR-IOV, if hypervisor has >> this new code, the virtual OS must be updated. [...]" > Which is broken,

Re: [RFC PATCH kernel] Revert "net/mlx4_core: Set UAR page size to 4KB regardless of system page size"

2016-03-15 Thread Or Gerlitz
On Tue, Mar 15, 2016 at 12:19 PM, Alexey Kardashevskiy wrote: > This reverts commit 85743f1eb34548ba4b056d2f184a3d107a3b8917. > > Without this revert, POWER "pseries" KVM guests with a VF passed to a guest > using VFIO fail to bring the driver up: > > mlx4_core: Mellanox ConnectX core driver v2.2-

Re: [PATCH RESEND] infiniband:core:Fix error handling in the function cm_lap_handler

2016-02-23 Thread Or Gerlitz
On 2/22/2016 8:59 PM, Nicholas Krause wrote: This fixes error handling in the function cm_lap_handler to properly check if the internal call to the function cm_init_av_for_response has failed by returning a error code and if so exit immediately from this particular function by freeing all previou

Re: linux-next: manual merge of the rdma tree with the nfsd tree

2016-01-06 Thread Or Gerlitz
On 1/6/2016 5:20 PM, Chuck Lever wrote: Chuck, > >Lets be concrete... anything wrong with patch [1]? Yes. It is missing Acked-by: lines from the maintainers of those files. All changes to files under net/sunrpc need an Ack from one of the maintainers listed in MAINTAINERS for that directory, if

Re: linux-next: manual merge of the rdma tree with the nfsd tree

2016-01-06 Thread Or Gerlitz
On 1/6/2016 4:24 PM, Chuck Lever wrote: Actually, one of Or's for-4.5 devattr patches doesn't appear to have the proper Ack's for the changes under net/sunrpc/xprtrdma either. Chuck, Lets be concrete... anything wrong with patch [1]? Or. [1] commit e3e45b1 "xprtrdma: Avoid calling ib_query

Re: linux-next: manual merge of the rdma tree with the nfsd tree

2016-01-06 Thread Or Gerlitz
On 1/6/2016 2:15 PM, Christoph Hellwig wrote: I'm not Doug, but all the recent for 4.5 work is in Dougs tree at https://github.com/dledford/linux rdma/k.o/for-4.5 Christoph, As I wrote here, the bits are already @ kernel.org git://git.kernel.org/pub/scm/linux/kernel/git/dledford/rdm

Re: linux-next: manual merge of the rdma tree with the nfsd tree

2016-01-06 Thread Or Gerlitz
On 1/6/2016 2:01 PM, Chuck Lever wrote: what is the URL for the branch I should rebase on? k.o/for-4.5 on Doug's kernel.org tree -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.k

Re: linux-next: manual merge of the rdma tree with the net-next tree

2016-01-05 Thread Or Gerlitz
On 1/5/2016 3:51 AM, Stephen Rothwell wrote: Hi Doug, Today's linux-next merge of the rdma tree got conflicts in: drivers/net/ethernet/mellanox/mlx5/core/vport.c include/linux/mlx5/mlx5_ifc.h include/linux/mlx5/vport.h between commits: e1d7d349c69d ("net/mlx5: Update access functi

Re: [PATCH] net/mlx4_core: fix handling return value of mlx4_slave_convert_port

2015-12-15 Thread Or Gerlitz
/gmane.linux.kernel/2046107 Please add here Fixes: fc48866f7 ('net/mlx4: Adapt code for N-Port VF') Signed-off-by: Andrzej Hajda otherwise, Looks good Acked-by: Or Gerlitz Or. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of

Re: [PATCH 7/9] IB/iser: Use a dedicated descriptor for login

2015-11-15 Thread Or Gerlitz
On 11/13/2015 3:46 PM, Christoph Hellwig wrote: From: Sagi Grimberg Makes better sense and we'll need it later with CQ abstraction. iser switch login bufs to void Sagi, few quick comments on this patch, please address for next version.. The 2nd sentence of the change-log needs better phrasing

Re: [PATCH 9/9] IB/iser: Convert to CQ abstraction

2015-11-15 Thread Or Gerlitz
On 11/13/2015 3:46 PM, Christoph Hellwig wrote: From: Sagi Grimberg Care to sparse some text here to assist a reviewer and future bisections?! I have asked multiple times to avoid empty change-logs for patches in this driver. Signed-off-by: Sagi Grimberg Signed-off-by: Christoph Hellwig -

Re: [PATCH 1/9] move blk_iopoll to limit and make it generally available

2015-11-15 Thread Or Gerlitz
On Sun, Nov 15, 2015 at 10:48 AM, Sagi Grimberg wrote: > Or is correct, > > I have attempted to convert iser to use blk_iopoll in the past, however > I've seen inconsistent performance and latency skews (comparing to > tasklets iser is using today). This was manifested in IOPs test cases > where I

Re: [PATCH 1/9] move blk_iopoll to limit and make it generally available

2015-11-13 Thread Or Gerlitz
On Fri, Nov 13, 2015 at 3:46 PM, Christoph Hellwig wrote: > The new name is irq_poll as iopoll is already taken. Better suggestions > welcome. Sagi (or Christoph if you can address that), @ some pointer over the last 18 months there was a port done at mellanox for iser to use blk-iopoll and AFA

Re: [RFC Patch 00/12] IXGBE: Add live migration support for SRIOV NIC

2015-10-22 Thread Or Gerlitz
On Wed, Oct 21, 2015 at 10:20 PM, Alex Williamson wrote: > This is why the typical VF agnostic approach here is to using bonding > and fail over to a emulated device during migration, so performance > suffers, but downtime is something acceptable. bonding in the VM isn't a zero touch solution, r

Re: [RFC Patch 00/12] IXGBE: Add live migration support for SRIOV NIC

2015-10-21 Thread Or Gerlitz
On Wed, Oct 21, 2015 at 7:37 PM, Lan Tianyu wrote: > This patchset is to propose a new solution to add live migration support > for 82599 SRIOV network card. > In our solution, we prefer to put all device specific operation into VF and > PF driver and make code in the Qemu more general. [...] >

Re: [PATCH] fix return value error

2015-10-14 Thread Or Gerlitz
On 10/14/2015 2:59 PM, Leon Romanovsky wrote: On Wed, Oct 14, 2015 at 11:17 AM, Heloise NH wrote: >Signed-off-by: Heloise NH The patch is a correct one, however can you update the subject and description to be more informative? Please add that new_inode() function can fail for allocation only.

Re: [PATCH RFC] IB/mad: remove obsolete snoop interface

2015-10-04 Thread Or Gerlitz
On Wed, Sep 30, 2015 at 9:01 AM, wrote: > This interface has no current users and is obsolete. mmm, how does Sean's madeye util is working? Or. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info a

Re: [PATCH] staging: rdma: Fix braces around if/else

2015-10-04 Thread Or Gerlitz
On 10/3/2015 11:55 PM, Martin Kletzander wrote: Get rid of all ELSE_AFTER_BRACE type errors reported by checkpatch.pl. Hi Greg, Is there a way to signal people/tools that a certain driver parks in staging on their way **out** of the kernel and not the other way around? I guess you (nor Doug)

Re: [PATCH] infiniband:mlx4:Fix assumation that ib_get_cached_pkey runs successfully in build_mlx_header

2015-09-09 Thread Or Gerlitz
On 9/10/2015 2:04 AM, Nicholas Krause wrote: This fixes a incorrect assumation that ib_get_cached_pkey always runs successfully in the function build_mlx_header by checking if the calls to this particular function return the error code, -EINVAL in order to signal they failed to grap the public ke

Re: [RFC/RFT PATCH v3 0/4] KVM: x86: full virtualization of guest MTRR

2015-07-29 Thread Or Gerlitz
On 7/8/2015 6:18 PM, Paolo Bonzini wrote: This part of the MTRR patches was dropped by Xiao. Bring SVM on feature parity with VMX, and then do guest MTRR virtualization for both VMX and SVM. The IPAT bit of VMX extended page tables is emulated by mangling the guest PAT value. I do not have any

Re: [BUG] mellanox IB driver fails to load on large config

2015-07-15 Thread Or Gerlitz
On 7/14/2015 11:28 PM, Alex Thorlton wrote: We see the same exact messages on 4.1-rc8. does this solves the problem? diff --git a/include/linux/mlx4/device.h b/include/linux/mlx4/device.h index ad31e47..c8ae3b9 100644 --- a/include/linux/mlx4/device.h +++ b/include/linux/mlx4/device.h @@ -

Re: [BUG] mellanox IB driver fails to load on large config

2015-07-14 Thread Or Gerlitz
On Tue, Jul 14, 2015 at 9:48 PM, Alex Thorlton wrote: > On Tue, Jul 14, 2015 at 01:22:34PM -0500, andrew banman wrote: >> On Sat, Jul 11, 2015 at 11:20:19PM +0300, Or Gerlitz wrote: >> > On Fri, Jul 10, 2015 at 10:15 PM, andrew banman wrote: >> > > I'm seeing

Re: [BUG] mellanox IB driver fails to load on large config

2015-07-11 Thread Or Gerlitz
On Fri, Jul 10, 2015 at 10:15 PM, andrew banman wrote: > I'm seeing a large number of allocation errors originating from the Mellanox > IB > driver when booting the 4.2-rc1 kernel on a 4096cpu 32TB memory system: Just to make sure, mlx4 works fine on this small (...) system with 4.1 and 4.2-rc1

Re: mlx4: "failed to allocate default counter port 1"

2015-06-30 Thread Or Gerlitz
On Tue, Jun 30, 2015 at 1:45 PM, Sebastian Ott wrote: > after the latest mellanox update the mlx4 driver fails to probe a VF: > [ 88.909562] mlx4_core :00:00.0: mlx4_allocate_default_counters: failed > to allocate default counter port 1 err -22 > [ 88.909564] mlx4_core :00:00.0: Faile

Re: [GIT] Networking

2015-06-25 Thread Or Gerlitz
On Thu, Jun 25, 2015 at 2:38 AM, Linus Torvalds wrote: > > On Wed, Jun 24, 2015 at 6:39 AM, David Miller wrote: > > > > git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master > > Just going through the conflicts, I see commit 7193a141eb74 ("IB/mlx4: > Set VF to read from QP cou

Re: [PATCH RFC v2] Documentation/infiniband: Add docs for rdma-helpers

2015-05-18 Thread Or Gerlitz
On Mon, May 18, 2015 at 11:41 AM, Michael Wang wrote: > Since v1: > * Merge the descriptions from Doug: > http://www.spinics.net/lists/linux-rdma/msg25172.html > > This is the following patch for: > https://lkml.org/lkml/2015/5/5/417 > which try to document the settled rdma_cap_XX(). > > H

Re: [PATCH v8 00/23] IB/Verbs: IB Management Helpers

2015-05-05 Thread Or Gerlitz
On 5/5/2015 3:50 PM, Michael Wang wrote: Since v7: * Thanks to Doug, Ira, Devesh for the testing:-) * Thanks for the comments from or, Doug, Ira, Jason:-) Please remind me if anything missed:-P * Use rdma_cap_XX() instead of cap_XX() for readability * Remove CC list in git log fo

Re: [PATCH v7 04/23] IB/Verbs: Reform IB-core cm

2015-04-29 Thread Or Gerlitz
On 4/29/2015 10:40 AM, Michael Wang wrote: On 04/28/2015 09:02 PM, Or Gerlitz wrote: >On Tue, Apr 28, 2015 at 6:10 PM, Michael Wang wrote: >>Use raw management helpers to reform IB-core cm. >> >>Cc: Hal Rosenstock >>Cc: Steve Wise >>Cc: Tom Talpey >>

Re: [PATCH v7 04/23] IB/Verbs: Reform IB-core cm

2015-04-29 Thread Or Gerlitz
On Wed, Apr 29, 2015 at 10:40 AM, Michael Wang wrote: > Hi, Or > > On 04/28/2015 09:02 PM, Or Gerlitz wrote: >> On Tue, Apr 28, 2015 at 6:10 PM, Michael Wang >> wrote: >>> Use raw management helpers to reform IB-core cm. >>> >>> Cc: Hal Rosenstock

Re: [PATCH v6 01/26] IB/Verbs: Implement new callback query_transport()

2015-04-28 Thread Or Gerlitz
On Tue, Apr 28, 2015 at 9:56 PM, Jason Gunthorpe wrote: > On Mon, Apr 27, 2015 at 09:24:35PM -0400, Doug Ledford wrote: >> On Mon, 2015-04-27 at 17:53 -0700, Tom Talpey wrote: > >> Having some of it refer to things as IBOE and some as ROCE would be >> similarly confusing, and switching existing IB

Re: [PATCH v7 04/23] IB/Verbs: Reform IB-core cm

2015-04-28 Thread Or Gerlitz
On Tue, Apr 28, 2015 at 6:10 PM, Michael Wang wrote: > Use raw management helpers to reform IB-core cm. > > Cc: Hal Rosenstock > Cc: Steve Wise > Cc: Tom Talpey > Cc: Jason Gunthorpe > Cc: Doug Ledford > Cc: Ira Weiny > Cc: Sean Hefty > Signed-off-by: Michael Wang > --- > drivers/infiniba

Re: [PATCH] mlx4: Fix tx ring affinity_mask creation

2015-04-28 Thread Or Gerlitz
On Fri, Apr 10, 2015 at 7:27 PM, Benjamin Poirier wrote: > By default, the number of tx queues is limited by the number of online cpus in > mlx4_en_get_profile(). However, this limit no longer holds after the ethtool > .set_channels method has been called. In that situation, the driver may access

Re: [PATCH v3 25/28] IB/Verbs: Use management helper cap_af_ib()

2015-04-16 Thread Or Gerlitz
On Mon, Apr 13, 2015 at 3:35 PM, Michael Wang wrote: > > Introduce helper cap_af_ib() to help us check if the port of an > IB device support Native Infiniband Address. > > Cc: Steve Wise > Cc: Tom Talpey > Cc: Jason Gunthorpe > Cc: Doug Ledford > Cc: Ira Weiny > Cc: Sean Hefty > Signed-off-b

Re: [PATCH linux-next v3] mlx5: wrong page mask if CONFIG_ARCH_DMA_ADDR_T_64BIT enabled for 32Bit architectures

2015-04-14 Thread Or Gerlitz
On 4/15/2015 6:19 AM, Honggang Li wrote: Fix(bf0bf77 mlx5: Support communicating arbitrary host page size to firmware) This isn't the way to write the fix note, do it that way Fixes: bf0bf77f6519 ('mlx5: Support communicating arbitrary host page size to firmware') Signed-off-by: Honggang

Re: [PATCH linux-next 1/4] infiniband/ipoib: fix possible NULL pointer dereference in ipoib_get_iflink

2015-04-14 Thread Or Gerlitz
On 4/14/2015 11:41 PM, Jason Gunthorpe wrote: Erez, you basically rewrote this, please make a proper patch with the Fixes and Reported-By credit for Honggang. Lets merge this through Dave M's tree right away. Agree, Erez, add proper Fixes: XXX note and send a patch to netdev against net-nex

Re: [PATCH v2 2/3] if_link: Add VF multicast promiscuous control

2015-03-08 Thread Or Gerlitz
On Mon, Feb 23, 2015 at 11:14 PM, Jeff Kirsher wrote: [...] > We discussed this during NetConf last week, and Don is correct that a > custom sysfs interface is not the way we want to handle this. We agreed > upon a generic interface so that any NIC is able to turn on or off VF > multicast promisc

Re: [PATCH v2 3/3] ixgbe: Add new ndo to allow VF multicast promiscuous mode

2015-02-19 Thread Or Gerlitz
On Fri, Feb 20, 2015 at 3:01 AM, Hiroshi Shimamoto wrote: > The administrator can allow to VF multicast promiscuous mode for only > trusted VM. > # ./ip link set dev eth0 vf 1 mc_promisc on > When disallowing multicast promiscuous mode, we can only use 30 IPv6 > addresses. > # ./ip link set de

Re: linux-next: build failure after merge of the infiniband tree

2014-12-16 Thread Or Gerlitz
On 12/16/2014 3:56 AM, Roland Dreier wrote: On Mon, Dec 15, 2014 at 5:47 PM, Stephen Rothwell wrote: Hi all, After merging the infiniband tree, today's linux-next build (x86_64 allmodconfig) failed like this: drivers/infiniband/hw/mlx5/main.c: In function 'mlx5_ib_query_device': drivers/infin

Re: mlx5: don't duplicate kvfree()

2014-11-20 Thread Or Gerlitz
On 11/20/2014 10:17 AM, Al Viro wrote: On Thu, Nov 20, 2014 at 08:13:57AM +, Al Viro wrote: > 9 files changed, 21 insertions(+), 35 deletions(-) grr... 8 files changed, actually - that was from the diff that included mlx4 bits. Patch split correctly and sent in two pieces, summary left as

Re: [PATCHv2 net 3/4] net/mlx4_en: Implement ndo_gso_check()

2014-11-16 Thread Or Gerlitz
On Fri, Nov 14, 2014 at 2:38 AM, Joe Stringer wrote: > Use vxlan_gso_check() to advertise offload support for this NIC. > > Signed-off-by: Joe Stringer FWIW (since the patches is applied already...) Acked-by: Or Gerlitz thanks for addressing this piece. -- To unsubscribe from this l

Re: [PATCH net 0/5] Implement ndo_gso_check() for vxlan nics

2014-11-06 Thread Or Gerlitz
On Thu, Nov 6, 2014 at 4:44 AM, Tom Herbert wrote: > On Wed, Nov 5, 2014 at 6:15 PM, David Miller wrote: >> From: Joe Stringer >> Date: Wed, 5 Nov 2014 17:06:46 -0800 >> >>> My impression was that the changes are more likely to be >>> hardware-specific (like the i40e changes) rather than softwar

Re: [PATCH net 0/5] Implement ndo_gso_check() for vxlan nics

2014-11-05 Thread Or Gerlitz
On Wed, Nov 5, 2014 at 8:00 PM, Tom Herbert wrote: > On Wed, Nov 5, 2014 at 9:50 AM, Joe Stringer wrote: >> >> On 5 November 2014 04:38, Or Gerlitz wrote: >>> >>> On Tue, Nov 4, 2014 at 11:56 PM, Joe Stringer >>> wrote: >>> > Most NICs tha

Re: [linux-nics] [PATCH net 3/5] fm10k: Implement ndo_gso_check()

2014-11-05 Thread Or Gerlitz
On Wed, Nov 5, 2014 at 2:34 PM, Jeff Kirsher wrote: > On Tue, 2014-11-04 at 13:56 -0800, Joe Stringer wrote: >> ndo_gso_check() was recently introduced to allow NICs to report the >> offloading support that they have on a per-skb basis. Add an >> implementation for this driver which checks for som

Re: [PATCH net 4/5] net/mlx4_en: Implement ndo_gso_check()

2014-11-05 Thread Or Gerlitz
On Tue, Nov 4, 2014 at 11:56 PM, Joe Stringer wrote: > ndo_gso_check() was recently introduced to allow NICs to report the > offloading support that they have on a per-skb basis. Add an > implementation for this driver which checks for something that looks > like VXLAN. > > Implementation shameles

Re: [PATCH net 0/5] Implement ndo_gso_check() for vxlan nics

2014-11-05 Thread Or Gerlitz
On Tue, Nov 4, 2014 at 11:56 PM, Joe Stringer wrote: > Most NICs that report NETIF_F_GSO_UDP_TUNNEL support VXLAN, and not other > UDP-based encapsulation protocols where the format and size of the header may > differ. This patch series implements ndo_gso_check() for these NICs, > restricting the

Re: vxlan gro problem ?

2014-10-13 Thread Or Gerlitz
On Mon, Oct 13, 2014 at 11:14 AM, yinpeijun wrote: > On 2014/10/13 3:50, Or Gerlitz wrote: > my test environment use mellanox ConnectX-3 Pro nic , as I know the nic > support Rx checksum offload. but I am not confirm if should I do some > special configure? > or the nic dri

Re: vxlan gro problem ?

2014-10-12 Thread Or Gerlitz
On 10/8/2014 10:46 AM, yinpeijun wrote: Hi all, recently Linux 3.14 has been released and I find the networking has added udp gro and vxlan gro funtion, then I use the redhat 7.0(there is also add this funtion) to test, I use kernel vxlan module and create a vxlan device then attach t

Re: [GIT PULL] please pull infiniband.git

2014-09-27 Thread Or Gerlitz
On Wed, Sep 24, 2014 at 12:58 AM, Roland Dreier wrote: > Hi Linus, [..] > This is later and bigger than I would like, and the blame is all on > me: I got very busy with other stuff for a few weeks during the 3.17 > cycle, and didn't prepare this tree as soon as I should have. However > I don't th

Re: [PATCH v1 for-next 00/16] On demand paging

2014-09-17 Thread Or Gerlitz
On 9/13/2014 12:16 AM, Or Gerlitz wrote: Per your request we provided the information on tests conducted with the patches. Note that the patches can't really disrupt existing applications that don't set the new IB_ACCESS_ON_DEMAND MR flag when they register memory. Also the whole set

Re: [PATCH v1 for-next 00/16] On demand paging

2014-09-12 Thread Or Gerlitz
On Tue, Sep 9, 2014, Haggai Eran wrote: > On 04/09/2014, Roland Dreier wrote: >> Have you done any review or testing of these changes? If so can you >> share the results? > We have tested this feature thoroughly inside Mellanox. We ran random > tests that performed MR registrations, memory mapp

Re: 3.17-rc1 oops during network interface configuration

2014-09-10 Thread Or Gerlitz
On 9/9/2014 10:30 PM, Chuck Lever wrote: This crash happens when booting v3.17-rcN on any of my IB-enabled systems. I have both ConnectX-2 and mthca systems, all are affected. I bisected this to: commit e0f31d8498676fda36289603a054d0d490aa2679 Author: Govindarajulu Varadarajan <_gov...@gmx

Re: [PATCH v1 for-next 00/16] On demand paging

2014-09-03 Thread Or Gerlitz
On Tue, Sep 2, 2014, Or Gerlitz wrote: > On 7/3/2014 11:44 AM, Haggai Eran wrote: >> >> Hi Roland, >> >> I understand that you were reluctant to review these patches as long as >> there was an ongoing debate on whether or not the i_mmap_mutex should be >>

Re: [PATCH for 3.16] IB/mlx5: Enable block multicast loopback for kernel consumers too

2014-07-15 Thread Or Gerlitz
On 25/06/2014 16:44, Or Gerlitz wrote: Under commit f360d88 we advertize blocking multicast loopback to both kernel and user-space consumers, but disallow the kernel ones (e.g IPoIB) to use it with their UD QPs, fix that. Fixes: f360d88 ('IB/mlx5: Add block multicast loopback support'

Re: [PATCH 3.10 26/52] net/mlx4_core: Preserve pci_dev_data after __mlx4_remove_one()

2014-06-24 Thread Or Gerlitz
On 25/06/2014 09:02, Or Gerlitz wrote: On 24/06/2014 18:50, Greg Kroah-Hartman wrote: 3.10-stable review patch. If anyone has any objections, please let me know. -- From: Wei Yang [ Upstream commit befdf8978accecac2e0739e6b5075afc62db37fe ] Hi Wei, Dave, In the same

Re: [PATCH 3.10 26/52] net/mlx4_core: Preserve pci_dev_data after __mlx4_remove_one()

2014-06-24 Thread Or Gerlitz
On 24/06/2014 18:50, Greg Kroah-Hartman wrote: 3.10-stable review patch. If anyone has any objections, please let me know. -- From: Wei Yang [ Upstream commit befdf8978accecac2e0739e6b5075afc62db37fe ] Hi Wei, Dave, In the same manner you acted for 3.14.y -- for this commi

Re: [PATCH 3.10 26/52] net/mlx4_core: Preserve pci_dev_data after __mlx4_remove_one()

2014-06-24 Thread Or Gerlitz
On 24/06/2014 18:50, Greg Kroah-Hartman wrote: 3.10-stable review patch. If anyone has any objections, please let me know. -- From: Wei Yang [ Upstream commit befdf8978accecac2e0739e6b5075afc62db37fe ] Hi Wei, Dave, In the same manner you acted for 3.14.y -- for this commi

Re: [PATCH for-next 00/15] Bug fixes for ocrdma driver

2014-06-09 Thread Or Gerlitz
On Wed, Jun 4, 2014 at 8:06 PM, Roland Dreier wrote: > On Wed, Jun 4, 2014 at 9:37 AM, Steve Wise > wrote: >> Seems like the subject lines in each patch are getting truncated? > Yes, truncated in patchwork too -- for example: > https://patchwork.kernel.org/patch/4292461/ > > Please fix and resen

Re: [PATCH v1 for-next 0/3] IB: Use GFP_NOIO calls in IPoIB connected mode TX path

2014-05-28 Thread Or Gerlitz
On Wed, May 28, 2014 at 5:05 PM, Roland Dreier wrote: > > > > Roland, so M2 starts worrying, you have picked into your for-next > > branch yesterday the other pending series, but not this one, so? > > Who is M2? me too -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

Re: [PATCH v1 for-next 0/3] IB: Use GFP_NOIO calls in IPoIB connected mode TX path

2014-05-28 Thread Or Gerlitz
On Mon, May 26, 2014 at 1:52 PM, Jiri Kosina wrote: > On Mon, 19 May 2014, Roland Dreier wrote: > >> > Roland, we're soon on -rc6 and there's no reason for this to miss >>> 3.16, could you please comment whether you want it to go through your >>> tree or net-next? >> I will pick it up. > Thanks

Re: [PATCH net-next V6 1/2] cpumask: Utility function to set n'th cpu - local cpu first

2014-05-27 Thread Or Gerlitz
On Tue, May 27, 2014 at 10:24 PM, David Miller wrote: > I would like someone who cares about these cpumask interfaces to provide > a review. understood, still, looking in the git log of that file didn't yield much only 1-2 commits per years for 2011/12/13, so, any concrete suggestion? Or. -- To

Re: [PATCH v1 for-next 0/3] IB: Use GFP_NOIO calls in IPoIB connected mode TX path

2014-05-17 Thread Or Gerlitz
On Tue, May 13, 2014 at 2:38 PM, Jiri Kosina wrote: > On Sun, 11 May 2014, Or Gerlitz wrote: >> This series is a refactored form of the one posted by Jiri Kosina >> to LKML and netdev according to the discussion that followed >> and the guidelines you provided here https://l

Re: [PATCH] drivers: net: ethernet: mellanox: mlx4: let mlx4 depend on SMP

2014-05-17 Thread Or Gerlitz
On Sat, May 17, 2014 at 8:36 AM, David Miller wrote: > > From: Chen Gang > Date: Sat, 17 May 2014 13:26:16 +0800 > > > 'struct irq_affinity_notify' and the related functions are only defined > > when SMP enabled, so at present, mlx4 has to only run under SMP. > > > > The related error (allmodconf

Re: randconfig build error with next-20140515, in drivers/net/ethernet/mellanox/mlx4/eq.c

2014-05-15 Thread Or Gerlitz
On 15/05/2014 16:48, Jim Davis wrote: Building with the attached random configuration file, drivers/net/ethernet/mellanox/mlx4/eq.c:58:29: error: field ‘notify’ has incomplete type struct irq_affinity_notify notify; ^ In file included from include/linux/interrupt

[PATCH v1 for-next 0/3] IB: Use GFP_NOIO calls in IPoIB connected mode TX path

2014-05-11 Thread Or Gerlitz
o use GFP_NOIO for the QP creation and fallback to GFP_KERNEL (as before) if the HW driver doesn't support that. This approach will let Jiri Kosina (1): mlx4: Enhance the QP creation path to use a given GFP directive Or Gerlitz (2): IB: Return error when QP creation are provided

Re: [PATCH] mlx4: Use GFP_NOFS calls during the ipoib TX path when creating the QP

2014-04-24 Thread Or Gerlitz
On Thu, Apr 24, 2014 at 8:03 PM, Jiri Kosina wrote: > > On Tue, 11 Mar 2014, Or Gerlitz wrote: [...] > > > So sounds like a plan that makes sense? > > Hi everybody, seems like this fell through cracks, Hi Jiri, I sent you private note on Mar 19th saying "are you o

Re: [PATCH] mlx4: Use GFP_NOFS calls during the ipoib TX path when creating the QP

2014-03-11 Thread Or Gerlitz
On 05/03/2014 21:25, Roland Dreier wrote: It's quite clear that this is a general problem with IPoIB connected mode on any IB device. In connected mode, a packet send can trigger establishing a new connection, which will allocate a new QP, which in particular will allocate memory for the QP in t

Re: [PATCH] mlx4: Use GFP_NOFS calls during the ipoib TX path when creating the QP

2014-03-06 Thread Or Gerlitz
On 21/02/2014 23:53, Jiri Kosina wrote: This was originally a patch from Matthew Finlay that addressed a problem whereby NFS writes would enter uninterruptible sleep forever. The issue happened when using NFS over IPoIB. This is not a recommended configuration as RDMA is preferred but it is sti

Re: [PATCH] mlx4: Use GFP_NOFS calls during the ipoib TX path when creating the QP

2014-03-05 Thread Or Gerlitz
On Wed, Feb 26, 2014 at 12:11 AM, Jiri Kosina wrote: > The problem encountered was described as follows: > It's not memory reclamation that is the problem as such. There is > an indirect dependency between network filesystems writing back > pages and ipoib_cm_tx_init() due

Re: [PATCH] mlx4: Use GFP_NOFS calls during the ipoib TX path when creating the QP

2014-03-05 Thread Or Gerlitz
On 05/03/2014 00:48, Jiri Kosina wrote: On Thu, 27 Feb 2014, Jiri Kosina wrote: On Thu, 27 Feb 2014, Or Gerlitz wrote: ipoib is coded over the verbs API (include/rdma/ib_verbs.h) --- so tracking the path from ipoib through the verbs api into mlx4 should be similar exercise as doing so for

Re: linux rdma 3.14 merge plans

2014-03-05 Thread Or Gerlitz
On 05/03/2014 17:18, Roland Dreier wrote: On Wed, Mar 5, 2014 at 1:54 AM, Nicholas A. Bellinger wrote: >That all said, do you have an objection wrt taking this bits through >target-pending..? Given the dependencies involved, that would seem the >most logical path to take. Perhaps not surpris

Re: [PATCH] mlx4: Use GFP_NOFS calls during the ipoib TX path when creating the QP

2014-02-27 Thread Or Gerlitz
On 27/02/2014 11:48, Jiri Kosina wrote: On Wed, 26 Feb 2014, Or Gerlitz wrote: But let's make sure that we don't diverge from the original problem too much. Simple fact is that the deadlock is there when using connected mode, and there is nothing preventing users from using i

Re: [PATCH] mlx4: Use GFP_NOFS calls during the ipoib TX path when creating the QP

2014-02-26 Thread Or Gerlitz
On Wed, Feb 26, 2014 at 12:55 AM, Jiri Kosina wrote: > On Wed, 26 Feb 2014, Or Gerlitz wrote: [...] > That definitely can be verified, and I am putting it on my TODO list. OK, thanks > But let's make sure that we don't diverge from the original problem too > much. S

Re: [PATCH] mlx4: Use GFP_NOFS calls during the ipoib TX path when creating the QP

2014-02-25 Thread Or Gerlitz
On Wed, Feb 26, 2014 at 12:40 AM, Jiri Kosina wrote: > On Wed, 26 Feb 2014, Or Gerlitz wrote: > >>>> And what happens if you use IPoIB datagram mode, is/why the patch is >>>> needed there? >>> I admittedly am no infiniband expert, but my understanding is t

  1   2   >