Re: linux-next: manual merge of the net-next tree with the net tree

On Thu, Dec 20, 2018 at 4:47 AM Stephen Rothwell wrote: > > Hi all, > > Today's linux-next merge of the net-next tree got a conflict in: > > drivers/net/ethernet/mellanox/mlx5/core/en_rep.c > > between commit: > > 8956f0014ea5 ("net/mlx5e: Fix default amount of channels for VF >

Re: linux-next: manual merge of the net-next tree with the net tree

On Mon, Dec 17, 2018 at 11:29 PM Saeed Mahameed wrote: > On Sun, Dec 16, 2018 at 4:25 PM Stephen Rothwell > wrote: > > I fixed it up (see below) and can carry the fix as necessary. This > Looks good to me. here too > > Today's linux-next merge of the net-next tree got a conflict in: > >

Re: linux-next: manual merge of the net-next tree with the net tree

On Mon, Dec 10, 2018 at 3:38 AM Stephen Rothwell wrote: > > Hi all, > > Today's linux-next merge of the net-next tree got a conflict in: > > net/sched/cls_flower.c > > between commit: > > 35cc3cefc4de ("net/sched: cls_flower: Reject duplicated rules also under > skip_sw") > > from the net

Re: [PATCH] IB/mlx5: avoid binding a new mpi unit to the same devices repeatedly

On Sat, Jul 14, 2018 at 2:50 AM, Qing Huang wrote: > When a CX5 device is configured in dual-port RoCE mode, after creating > many VFs against port 1, creating the same number of VFs against port 2 > will flood kernel/syslog with something like > "mlx5_*:mlx5_ib_bind_slave_port:4266:(pid 5269):

Re: [PATCH] IB/mlx5: avoid binding a new mpi unit to the same devices repeatedly

On Sat, Jul 14, 2018 at 2:50 AM, Qing Huang wrote: > When a CX5 device is configured in dual-port RoCE mode, after creating > many VFs against port 1, creating the same number of VFs against port 2 > will flood kernel/syslog with something like > "mlx5_*:mlx5_ib_bind_slave_port:4266:(pid 5269):

Re: [PATCH 13/14] net: sched: use unique idr insert function in unlocked actions

On Mon, May 21, 2018 at 12:33 AM, Marcelo Ricardo Leitner <marcelo.leit...@gmail.com> wrote: > On Mon, May 21, 2018 at 12:13:06AM +0300, Or Gerlitz wrote: >> On Sun, May 20, 2018 at 1:20 AM, Marcelo Ricardo Leitner >> <marcelo.leit...@gmail.com> wrote: >> > On M

Re: [PATCH 13/14] net: sched: use unique idr insert function in unlocked actions

On Mon, May 21, 2018 at 12:33 AM, Marcelo Ricardo Leitner wrote: > On Mon, May 21, 2018 at 12:13:06AM +0300, Or Gerlitz wrote: >> On Sun, May 20, 2018 at 1:20 AM, Marcelo Ricardo Leitner >> wrote: >> > On Mon, May 14, 2018 at 05:27:14PM +0300, Vlad Buslov wrote: >>

Re: [PATCH 13/14] net: sched: use unique idr insert function in unlocked actions

On Sun, May 20, 2018 at 1:20 AM, Marcelo Ricardo Leitner wrote: > On Mon, May 14, 2018 at 05:27:14PM +0300, Vlad Buslov wrote: >> Substitute calls to action insert function with calls to action insert >> unique function that warns if insertion overwrites index in idr. >

Re: [PATCH 13/14] net: sched: use unique idr insert function in unlocked actions

On Sun, May 20, 2018 at 1:20 AM, Marcelo Ricardo Leitner wrote: > On Mon, May 14, 2018 at 05:27:14PM +0300, Vlad Buslov wrote: >> Substitute calls to action insert function with calls to action insert >> unique function that warns if insertion overwrites index in idr. > > I know this patch may be

Re: Setting large MTU size on slave interfaces may stall the whole system

On Tue, Dec 12, 2017 at 5:21 AM, Qing Huang wrote: > Hi, > > We found an issue with the bonding driver when testing Mellanox devices. > The following test commands will stall the whole system sometimes, with > serial console > flooded with log messages from the

Re: Setting large MTU size on slave interfaces may stall the whole system

On Tue, Dec 12, 2017 at 5:21 AM, Qing Huang wrote: > Hi, > > We found an issue with the bonding driver when testing Mellanox devices. > The following test commands will stall the whole system sometimes, with > serial console > flooded with log messages from the bond_miimon_inspect() function.

Re: [PATCH] [net-next] net/mlx5e: select CONFIG_MLXFW

On Wed, Jun 28, 2017 at 11:10 PM, Arnd Bergmann wrote: > With the introduction of mlx5 firmware flash support, we get a link > error with CONFIG_MLXFW=m and CONFIG_MLX5_CORE=y: > > drivers/net/ethernet/mellanox/mlx5/core/fw.o: In function > `mlx5_firmware_flash': >

Re: [PATCH] [net-next] net/mlx5e: select CONFIG_MLXFW

On Wed, Jun 28, 2017 at 11:10 PM, Arnd Bergmann wrote: > With the introduction of mlx5 firmware flash support, we get a link > error with CONFIG_MLXFW=m and CONFIG_MLX5_CORE=y: > > drivers/net/ethernet/mellanox/mlx5/core/fw.o: In function > `mlx5_firmware_flash': > fw.c:(.text+0x9d4): undefined

Re: [PATCH] IB/IPoIB: Check the headroom size

On Tue, Apr 25, 2017 at 2:11 PM, Erez Shitrit <ere...@dev.mellanox.co.il> wrote: > On Tue, Apr 25, 2017 at 1:32 PM, Or Gerlitz <gerlitz...@gmail.com> wrote: >> On Tue, Apr 25, 2017 at 12:55 PM, Honggang LI <ho...@redhat.com> wrote: >>> From: Honggang L

Re: [PATCH] IB/IPoIB: Check the headroom size

On Tue, Apr 25, 2017 at 2:11 PM, Erez Shitrit wrote: > On Tue, Apr 25, 2017 at 1:32 PM, Or Gerlitz wrote: >> On Tue, Apr 25, 2017 at 12:55 PM, Honggang LI wrote: >>> From: Honggang Li >>> >>> Minimal hard_header_len set by bond_compute_features is

Re: [PATCH] IB/IPoIB: Check the headroom size

On Tue, Apr 25, 2017 at 12:55 PM, Honggang LI wrote: > From: Honggang Li > > Minimal hard_header_len set by bond_compute_features is ETH_HLEN, which > is smaller than IPOIB_HARD_LEN. ipoib_hard_header should check the > size of headroom to avoid

Re: [PATCH] IB/IPoIB: Check the headroom size

On Tue, Apr 25, 2017 at 12:55 PM, Honggang LI wrote: > From: Honggang Li > > Minimal hard_header_len set by bond_compute_features is ETH_HLEN, which > is smaller than IPOIB_HARD_LEN. ipoib_hard_header should check the > size of headroom to avoid skb_under_panic. sounds terrible, ipoib bonding

Re: [PATCH] [net-next] net/mlx5e: fix another maybe-uninitialized false-positive

s for > IPv6 tunnels") > Signed-off-by: Arnd Bergmann <a...@arndb.de> frustrating... I don't see the warning with gcc 5.3.1 [1], but still, the patch is OKay Acked-by: Or Gerlitz <ogerl...@mellanox.com> [1] I used #make KCFLAGS='-Wmaybe-uninitialized' M=drivers/net/ethernet/mellanox/mlx5/core -j something

Re: [PATCH] [net-next] net/mlx5e: fix another maybe-uninitialized false-positive

> Signed-off-by: Arnd Bergmann frustrating... I don't see the warning with gcc 5.3.1 [1], but still, the patch is OKay Acked-by: Or Gerlitz [1] I used #make KCFLAGS='-Wmaybe-uninitialized' M=drivers/net/ethernet/mellanox/mlx5/core -j something

Re: [PATCH] [net] net/mlx5e: fix another -Wmaybe-uninitialized warning

On Thu, Jan 12, 2017 at 6:04 PM, Arnd Bergmann <a...@arndb.de> wrote: > On Thursday, January 12, 2017 5:21:49 PM CET Or Gerlitz wrote: >> When I build here without CONFIG_INET in my system, the build goes fine >> with this approach. However, we're pretty sure that in the

Re: [PATCH] [net] net/mlx5e: fix another -Wmaybe-uninitialized warning

On Thu, Jan 12, 2017 at 6:04 PM, Arnd Bergmann wrote: > On Thursday, January 12, 2017 5:21:49 PM CET Or Gerlitz wrote: >> When I build here without CONFIG_INET in my system, the build goes fine >> with this approach. However, we're pretty sure that in the past we got >&

Re: [PATCH] [net] net/mlx5e: fix another -Wmaybe-uninitialized warning

On 1/11/2017 11:14 PM, Arnd Bergmann wrote: As found by Olof's build bot, today's mainline kernel gained a harmless warning about a potential uninitalied variable reference: drivers/net/ethernet/mellanox/mlx5/core/en_tc.c: In function 'parse_tc_fdb_actions':

Re: [PATCH] [net] net/mlx5e: fix another -Wmaybe-uninitialized warning

On 1/11/2017 11:14 PM, Arnd Bergmann wrote: As found by Olof's build bot, today's mainline kernel gained a harmless warning about a potential uninitalied variable reference: drivers/net/ethernet/mellanox/mlx5/core/en_tc.c: In function 'parse_tc_fdb_actions':

Re: [PATCH] [net] net/mlx5e: fix another -Wmaybe-uninitialized warning

On 1/11/2017 11:14 PM, Arnd Bergmann wrote: @@ -666,14 +666,15 @@ static int mlx5e_route_lookup_ipv4(struct mlx5e_priv *priv, struct rtable *rt; struct neighbour *n = NULL; int ttl; + int ret; + + if (!IS_ENABLED(CONFIG_INET)) + return

Re: [PATCH] [net] net/mlx5e: fix another -Wmaybe-uninitialized warning

On 1/11/2017 11:14 PM, Arnd Bergmann wrote: @@ -666,14 +666,15 @@ static int mlx5e_route_lookup_ipv4(struct mlx5e_priv *priv, struct rtable *rt; struct neighbour *n = NULL; int ttl; + int ret; + + if (!IS_ENABLED(CONFIG_INET)) + return

Re: [PULL REQUEST] Please pull rdma.git

On Fri, Nov 18, 2016 at 4:01 AM, Doug Ledford <dledf...@redhat.com> wrote: > On 11/17/2016 5:24 PM, Or Gerlitz wrote: [...] > I agree with you. It doesn't fix your patch. The commit message can > still be fixed up. >> Please do not send it to Linus and wait for them to r

Re: [PULL REQUEST] Please pull rdma.git

On Fri, Nov 18, 2016 at 4:01 AM, Doug Ledford wrote: > On 11/17/2016 5:24 PM, Or Gerlitz wrote: [...] > I agree with you. It doesn't fix your patch. The commit message can > still be fixed up. >> Please do not send it to Linus and wait for them to respond. I >> disa

Re: [PULL REQUEST] Please pull rdma.git

On Thu, Nov 17, 2016 at 9:44 PM, Doug Ledford wrote: > On 11/17/16 1:49 PM, Leon Romanovsky wrote: >> On Thu, Nov 17, 2016 at 07:13:54AM -0500, Doug Ledford wrote: >>> Hi Linus, >>> >>> Due to various issues, I've been away and couldn't send a pull request >>> for about three

Re: [PULL REQUEST] Please pull rdma.git

On Thu, Nov 17, 2016 at 9:44 PM, Doug Ledford wrote: > On 11/17/16 1:49 PM, Leon Romanovsky wrote: >> On Thu, Nov 17, 2016 at 07:13:54AM -0500, Doug Ledford wrote: >>> Hi Linus, >>> >>> Due to various issues, I've been away and couldn't send a pull request >>> for about three weeks. There were a

Re: linux-next: manual merge of the net-next tree with the net tree

On Thu, Nov 10, 2016 at 1:50 AM, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the net-next tree got a conflict in: > > drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c > > between commit: > ee39fbc4447d ("net/mlx5: E-Switch, Set the

Re: linux-next: manual merge of the net-next tree with the net tree

On Thu, Nov 10, 2016 at 1:50 AM, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the net-next tree got a conflict in: > > drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c > > between commit: > ee39fbc4447d ("net/mlx5: E-Switch, Set the actions for offloaded rules

Re: [PATCH 1/2] net/mlx5e: shut up maybe-uninitialized warning

action for SRIOV offloads") > Signed-off-by: Arnd Bergmann <a...@arndb.de> Yeah, this is clearly false positive and I was sure that newish GCCs don't show that, but you are the master here.. so FWIW Acked-by: Or Gerlitz <ogerl...@mellanox.com>

Re: [PATCH 1/2] net/mlx5e: shut up maybe-uninitialized warning

t;) > Signed-off-by: Arnd Bergmann Yeah, this is clearly false positive and I was sure that newish GCCs don't show that, but you are the master here.. so FWIW Acked-by: Or Gerlitz

Re: [PATCH] net: rtnl: avoid uninitialized data in IFLA_VF_VLAN_LIST handling

On Fri, Sep 30, 2016 at 7:13 PM, Arnd Bergmann wrote: > With the newly added support for IFLA_VF_VLAN_LIST netlink messages, > we get a warning about potential uninitialized variable use in > the parsing of the user input when enabling the -Wmaybe-uninitialized > warning: > >

Re: [PATCH] net: rtnl: avoid uninitialized data in IFLA_VF_VLAN_LIST handling

On Fri, Sep 30, 2016 at 7:13 PM, Arnd Bergmann wrote: > With the newly added support for IFLA_VF_VLAN_LIST netlink messages, > we get a warning about potential uninitialized variable use in > the parsing of the user input when enabling the -Wmaybe-uninitialized > warning: > >

Re: [patch] devlink: clean up a condition

On 6/16/2016 9:50 AM, Dan Carpenter wrote: Presumably having a _get() function implies that we also have a _set() function but lets make it match when we're calling. Signed-off-by: Dan Carpenter diff --git a/net/core/devlink.c b/net/core/devlink.c index

Re: [patch] devlink: clean up a condition

On 6/16/2016 9:50 AM, Dan Carpenter wrote: Presumably having a _get() function implies that we also have a _set() function but lets make it match when we're calling. Signed-off-by: Dan Carpenter diff --git a/net/core/devlink.c b/net/core/devlink.c index a4f88cb..b2e592a 100644 ---

Re: [PATCH net-next v3 6/7] vmxnet3: introduce command to register memory region

On Tue, Jun 14, 2016 at 4:50 AM, Shrikrishna Khare wrote: > +++ b/drivers/net/vmxnet3/vmxnet3_defs.h > @@ -81,6 +81,7 @@ enum { > VMXNET3_CMD_RESERVED2, > VMXNET3_CMD_RESERVED3, > VMXNET3_CMD_SET_COALESCE, > + VMXNET3_CMD_REGISTER_MEMREGS, > >

Re: [PATCH net-next v3 6/7] vmxnet3: introduce command to register memory region

On Tue, Jun 14, 2016 at 4:50 AM, Shrikrishna Khare wrote: > +++ b/drivers/net/vmxnet3/vmxnet3_defs.h > @@ -81,6 +81,7 @@ enum { > VMXNET3_CMD_RESERVED2, > VMXNET3_CMD_RESERVED3, > VMXNET3_CMD_SET_COALESCE, > + VMXNET3_CMD_REGISTER_MEMREGS, > >

Re: [PATCH net-next v3 0/7] vmxnet3: upgrade to version 3

On Tue, Jun 14, 2016 at 4:50 AM, Shrikrishna Khare wrote: > This patchset upgrades vmxnet3 to version 3. Except for one patch, all the rest lack change-log, which makes it somehow needlessly harder to review and maintain > Shrikrishna Khare (7): > vmxnet3: prepare for

Re: [PATCH net-next v3 0/7] vmxnet3: upgrade to version 3

On Tue, Jun 14, 2016 at 4:50 AM, Shrikrishna Khare wrote: > This patchset upgrades vmxnet3 to version 3. Except for one patch, all the rest lack change-log, which makes it somehow needlessly harder to review and maintain > Shrikrishna Khare (7): > vmxnet3: prepare for version 3 changes >

Re: [PATCH v5 09/21] IB/hns: Add hca support

On Tue, May 3, 2016 at 10:57 AM, Wei Hu (Xavier) <xavier.hu...@huawei.com> wrote: > On 2016/4/30 12:33, Or Gerlitz wrote: >> Can you elaborate what design aspects in the driver or anywhere else >> should impose that limitation? > 1. Oulijun resolved the problem, and se

Re: [PATCH v5 09/21] IB/hns: Add hca support

On Tue, May 3, 2016 at 10:57 AM, Wei Hu (Xavier) wrote: > On 2016/4/30 12:33, Or Gerlitz wrote: >> Can you elaborate what design aspects in the driver or anywhere else >> should impose that limitation? > 1. Oulijun resolved the problem, and sent PATCH V6 on 2016-4-28.

Re: [PATCH v5 09/21] IB/hns: Add hca support

On Wed, Apr 27, 2016 at 6:34 AM, oulijun wrote: > On 2016/4/26 22:25, Jiri Pirko wrote: >> Tue, Apr 26, 2016 at 04:18:21PM CEST, l...@kernel.org wrote: I appreciate your keen eye. this code is meant for ARM64bit therefore should run corretly for 64-bit AARCH64.

Re: [PATCH v5 09/21] IB/hns: Add hca support

On Wed, Apr 27, 2016 at 6:34 AM, oulijun wrote: > On 2016/4/26 22:25, Jiri Pirko wrote: >> Tue, Apr 26, 2016 at 04:18:21PM CEST, l...@kernel.org wrote: I appreciate your keen eye. this code is meant for ARM64bit therefore should run corretly for 64-bit AARCH64. >> The driver

Re: linux-next: manual merge of the rdma tree with the net-next tree

ne before it?) we had confusion with >>> people who thought that "no action is required" means "you can just >>> ignore this entirely". >> I certainly didn't take it that way regardless of the wording. > It was Or Gerlitz. You were cc'd, since i

Re: linux-next: manual merge of the rdma tree with the net-next tree

is required" means "you can just >>> ignore this entirely". >> I certainly didn't take it that way regardless of the wording. > It was Or Gerlitz. You were cc'd, since it was the whole rdma Mellanox > mess. I quote from that thread: > > "> Howeve

Re: [RFC PATCH kernel] Revert "net/mlx4_core: Set UAR page size to 4KB regardless of system page size"

On Thu, Mar 17, 2016 at 3:40 AM, Alexey Kardashevskiy <a...@ozlabs.ru> wrote: > On 03/16/2016 08:45 PM, Or Gerlitz wrote: >> On Wed, Mar 16, 2016 at 10:34 AM, Alexey Kardashevskiy <a...@ozlabs.ru> >> wrote: >> >>> Oh. ok. It also looks like even with the

Re: [RFC PATCH kernel] Revert "net/mlx4_core: Set UAR page size to 4KB regardless of system page size"

On Thu, Mar 17, 2016 at 3:40 AM, Alexey Kardashevskiy wrote: > On 03/16/2016 08:45 PM, Or Gerlitz wrote: >> On Wed, Mar 16, 2016 at 10:34 AM, Alexey Kardashevskiy >> wrote: >> >>> Oh. ok. It also looks like even with the reverted patch, mlx4 VF does not >>

Re: [RFC PATCH kernel] Revert "net/mlx4_core: Set UAR page size to 4KB regardless of system page size"

On Wed, Mar 16, 2016 at 10:34 AM, Alexey Kardashevskiy wrote: > Oh. ok. It also looks like even with the reverted patch, mlx4 VF does not > work in a guest: So where is the breakage point for you? does 4.4 works? if not, what?

Re: [RFC PATCH kernel] Revert "net/mlx4_core: Set UAR page size to 4KB regardless of system page size"

On Wed, Mar 16, 2016 at 10:34 AM, Alexey Kardashevskiy wrote: > Oh. ok. It also looks like even with the reverted patch, mlx4 VF does not > work in a guest: So where is the breakage point for you? does 4.4 works? if not, what?

Re: [RFC PATCH kernel] Revert "net/mlx4_core: Set UAR page size to 4KB regardless of system page size"

On Tue, Mar 15, 2016 at 2:18 PM, Christoph Hellwig <h...@infradead.org> wrote: > On Tue, Mar 15, 2016 at 12:40:06PM +0200, Or Gerlitz wrote: >> "[..] Regarding backward compatibility in SR-IOV, if hypervisor has >> this new code, the virtual OS must be updated. [...]&quo

Re: [RFC PATCH kernel] Revert "net/mlx4_core: Set UAR page size to 4KB regardless of system page size"

On Tue, Mar 15, 2016 at 2:18 PM, Christoph Hellwig wrote: > On Tue, Mar 15, 2016 at 12:40:06PM +0200, Or Gerlitz wrote: >> "[..] Regarding backward compatibility in SR-IOV, if hypervisor has >> this new code, the virtual OS must be updated. [...]" > Which is broken,

Re: [RFC PATCH kernel] Revert "net/mlx4_core: Set UAR page size to 4KB regardless of system page size"

On Tue, Mar 15, 2016 at 12:19 PM, Alexey Kardashevskiy wrote: > This reverts commit 85743f1eb34548ba4b056d2f184a3d107a3b8917. > > Without this revert, POWER "pseries" KVM guests with a VF passed to a guest > using VFIO fail to bring the driver up: > > mlx4_core: Mellanox ConnectX

Re: [RFC PATCH kernel] Revert "net/mlx4_core: Set UAR page size to 4KB regardless of system page size"

On Tue, Mar 15, 2016 at 12:19 PM, Alexey Kardashevskiy wrote: > This reverts commit 85743f1eb34548ba4b056d2f184a3d107a3b8917. > > Without this revert, POWER "pseries" KVM guests with a VF passed to a guest > using VFIO fail to bring the driver up: > > mlx4_core: Mellanox ConnectX core driver

Re: [PATCH RESEND] infiniband:core:Fix error handling in the function cm_lap_handler

On 2/22/2016 8:59 PM, Nicholas Krause wrote: This fixes error handling in the function cm_lap_handler to properly check if the internal call to the function cm_init_av_for_response has failed by returning a error code and if so exit immediately from this particular function by freeing all

Re: [PATCH RESEND] infiniband:core:Fix error handling in the function cm_lap_handler

On 2/22/2016 8:59 PM, Nicholas Krause wrote: This fixes error handling in the function cm_lap_handler to properly check if the internal call to the function cm_init_av_for_response has failed by returning a error code and if so exit immediately from this particular function by freeing all

Re: linux-next: manual merge of the rdma tree with the nfsd tree

On 1/6/2016 5:20 PM, Chuck Lever wrote: Chuck, > >Lets be concrete... anything wrong with patch [1]? Yes. It is missing Acked-by: lines from the maintainers of those files. All changes to files under net/sunrpc need an Ack from one of the maintainers listed in MAINTAINERS for that directory,

Re: linux-next: manual merge of the rdma tree with the nfsd tree

On 1/6/2016 4:24 PM, Chuck Lever wrote: Actually, one of Or's for-4.5 devattr patches doesn't appear to have the proper Ack's for the changes under net/sunrpc/xprtrdma either. Chuck, Lets be concrete... anything wrong with patch [1]? Or. [1] commit e3e45b1 "xprtrdma: Avoid calling

Re: linux-next: manual merge of the rdma tree with the nfsd tree

On 1/6/2016 2:15 PM, Christoph Hellwig wrote: I'm not Doug, but all the recent for 4.5 work is in Dougs tree at https://github.com/dledford/linux rdma/k.o/for-4.5 Christoph, As I wrote here, the bits are already @ kernel.org

Re: linux-next: manual merge of the rdma tree with the nfsd tree

On 1/6/2016 2:01 PM, Chuck Lever wrote: what is the URL for the branch I should rebase on? k.o/for-4.5 on Doug's kernel.org tree -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: linux-next: manual merge of the rdma tree with the nfsd tree

On 1/6/2016 2:15 PM, Christoph Hellwig wrote: I'm not Doug, but all the recent for 4.5 work is in Dougs tree at https://github.com/dledford/linux rdma/k.o/for-4.5 Christoph, As I wrote here, the bits are already @ kernel.org

Re: linux-next: manual merge of the rdma tree with the nfsd tree

On 1/6/2016 2:01 PM, Chuck Lever wrote: what is the URL for the branch I should rebase on? k.o/for-4.5 on Doug's kernel.org tree -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: linux-next: manual merge of the rdma tree with the nfsd tree

On 1/6/2016 4:24 PM, Chuck Lever wrote: Actually, one of Or's for-4.5 devattr patches doesn't appear to have the proper Ack's for the changes under net/sunrpc/xprtrdma either. Chuck, Lets be concrete... anything wrong with patch [1]? Or. [1] commit e3e45b1 "xprtrdma: Avoid calling

Re: linux-next: manual merge of the rdma tree with the nfsd tree

On 1/6/2016 5:20 PM, Chuck Lever wrote: Chuck, > >Lets be concrete... anything wrong with patch [1]? Yes. It is missing Acked-by: lines from the maintainers of those files. All changes to files under net/sunrpc need an Ack from one of the maintainers listed in MAINTAINERS for that directory,

Re: linux-next: manual merge of the rdma tree with the net-next tree

On 1/5/2016 3:51 AM, Stephen Rothwell wrote: Hi Doug, Today's linux-next merge of the rdma tree got conflicts in: drivers/net/ethernet/mellanox/mlx5/core/vport.c include/linux/mlx5/mlx5_ifc.h include/linux/mlx5/vport.h between commits: e1d7d349c69d ("net/mlx5: Update access

Re: linux-next: manual merge of the rdma tree with the net-next tree

On 1/5/2016 3:51 AM, Stephen Rothwell wrote: Hi Doug, Today's linux-next merge of the rdma tree got conflicts in: drivers/net/ethernet/mellanox/mlx5/core/vport.c include/linux/mlx5/mlx5_ifc.h include/linux/mlx5/vport.h between commits: e1d7d349c69d ("net/mlx5: Update access

Re: [PATCH] net/mlx4_core: fix handling return value of mlx4_slave_convert_port

/gmane.linux.kernel/2046107 Please add here Fixes: fc48866f7 ('net/mlx4: Adapt code for N-Port VF') Signed-off-by: Andrzej Hajda otherwise, Looks good Acked-by: Or Gerlitz Or. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message

Re: [PATCH] net/mlx4_core: fix handling return value of mlx4_slave_convert_port

/gmane.linux.kernel/2046107 Please add here Fixes: fc48866f7 ('net/mlx4: Adapt code for N-Port VF') Signed-off-by: Andrzej Hajda <a.ha...@samsung.com> otherwise, Looks good Acked-by: Or Gerlitz <ogerl...@mellanox.com> Or. -- To unsubscribe from this list: send the line "

Re: [PATCH 7/9] IB/iser: Use a dedicated descriptor for login

On 11/13/2015 3:46 PM, Christoph Hellwig wrote: From: Sagi Grimberg Makes better sense and we'll need it later with CQ abstraction. iser switch login bufs to void Sagi, few quick comments on this patch, please address for next version.. The 2nd sentence of the change-log needs better

Re: [PATCH 9/9] IB/iser: Convert to CQ abstraction

On 11/13/2015 3:46 PM, Christoph Hellwig wrote: From: Sagi Grimberg Care to sparse some text here to assist a reviewer and future bisections?! I have asked multiple times to avoid empty change-logs for patches in this driver. Signed-off-by: Sagi Grimberg Signed-off-by: Christoph Hellwig

Re: [PATCH 1/9] move blk_iopoll to limit and make it generally available

On Sun, Nov 15, 2015 at 10:48 AM, Sagi Grimberg wrote: > Or is correct, > > I have attempted to convert iser to use blk_iopoll in the past, however > I've seen inconsistent performance and latency skews (comparing to > tasklets iser is using today). This was manifested in IOPs test cases > where

Re: [PATCH 1/9] move blk_iopoll to limit and make it generally available

On Sun, Nov 15, 2015 at 10:48 AM, Sagi Grimberg wrote: > Or is correct, > > I have attempted to convert iser to use blk_iopoll in the past, however > I've seen inconsistent performance and latency skews (comparing to > tasklets iser is using today). This was manifested

Re: [PATCH 9/9] IB/iser: Convert to CQ abstraction

On 11/13/2015 3:46 PM, Christoph Hellwig wrote: From: Sagi Grimberg Care to sparse some text here to assist a reviewer and future bisections?! I have asked multiple times to avoid empty change-logs for patches in this driver. Signed-off-by: Sagi

Re: [PATCH 7/9] IB/iser: Use a dedicated descriptor for login

On 11/13/2015 3:46 PM, Christoph Hellwig wrote: From: Sagi Grimberg Makes better sense and we'll need it later with CQ abstraction. iser switch login bufs to void Sagi, few quick comments on this patch, please address for next version.. The 2nd sentence of the change-log

Re: [PATCH 1/9] move blk_iopoll to limit and make it generally available

On Fri, Nov 13, 2015 at 3:46 PM, Christoph Hellwig wrote: > The new name is irq_poll as iopoll is already taken. Better suggestions > welcome. Sagi (or Christoph if you can address that), @ some pointer over the last 18 months there was a port done at mellanox for iser to use blk-iopoll and

Re: [PATCH 1/9] move blk_iopoll to limit and make it generally available

On Fri, Nov 13, 2015 at 3:46 PM, Christoph Hellwig wrote: > The new name is irq_poll as iopoll is already taken. Better suggestions > welcome. Sagi (or Christoph if you can address that), @ some pointer over the last 18 months there was a port done at mellanox for iser to use

Re: [RFC Patch 00/12] IXGBE: Add live migration support for SRIOV NIC

On Wed, Oct 21, 2015 at 10:20 PM, Alex Williamson wrote: > This is why the typical VF agnostic approach here is to using bonding > and fail over to a emulated device during migration, so performance > suffers, but downtime is something acceptable. bonding in the VM isn't a zero touch solution,

Re: [RFC Patch 00/12] IXGBE: Add live migration support for SRIOV NIC

On Wed, Oct 21, 2015 at 10:20 PM, Alex Williamson wrote: > This is why the typical VF agnostic approach here is to using bonding > and fail over to a emulated device during migration, so performance > suffers, but downtime is something acceptable. bonding in the VM

Re: [RFC Patch 00/12] IXGBE: Add live migration support for SRIOV NIC

On Wed, Oct 21, 2015 at 7:37 PM, Lan Tianyu wrote: > This patchset is to propose a new solution to add live migration support > for 82599 SRIOV network card. > In our solution, we prefer to put all device specific operation into VF and > PF driver and make code in the Qemu more general. [...]

Re: [RFC Patch 00/12] IXGBE: Add live migration support for SRIOV NIC

On Wed, Oct 21, 2015 at 7:37 PM, Lan Tianyu wrote: > This patchset is to propose a new solution to add live migration support > for 82599 SRIOV network card. > In our solution, we prefer to put all device specific operation into VF and > PF driver and make code in the Qemu

Re: [PATCH] fix return value error

On 10/14/2015 2:59 PM, Leon Romanovsky wrote: On Wed, Oct 14, 2015 at 11:17 AM, Heloise NH wrote: >Signed-off-by: Heloise NH The patch is a correct one, however can you update the subject and description to be more informative? Please add that new_inode() function can fail for allocation

Re: [PATCH] fix return value error

On 10/14/2015 2:59 PM, Leon Romanovsky wrote: On Wed, Oct 14, 2015 at 11:17 AM, Heloise NH wrote: >Signed-off-by: Heloise NH The patch is a correct one, however can you update the subject and description to be more informative? Please add that new_inode()

Re: [PATCH RFC] IB/mad: remove obsolete snoop interface

On Wed, Sep 30, 2015 at 9:01 AM, wrote: > This interface has no current users and is obsolete. mmm, how does Sean's madeye util is working? Or. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH] staging: rdma: Fix braces around if/else

On 10/3/2015 11:55 PM, Martin Kletzander wrote: Get rid of all ELSE_AFTER_BRACE type errors reported by checkpatch.pl. Hi Greg, Is there a way to signal people/tools that a certain driver parks in staging on their way **out** of the kernel and not the other way around? I guess you (nor Doug)

Re: [PATCH] staging: rdma: Fix braces around if/else

On 10/3/2015 11:55 PM, Martin Kletzander wrote: Get rid of all ELSE_AFTER_BRACE type errors reported by checkpatch.pl. Hi Greg, Is there a way to signal people/tools that a certain driver parks in staging on their way **out** of the kernel and not the other way around? I guess you (nor Doug)

Re: [PATCH RFC] IB/mad: remove obsolete snoop interface

On Wed, Sep 30, 2015 at 9:01 AM, wrote: > This interface has no current users and is obsolete. mmm, how does Sean's madeye util is working? Or. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org

Re: [PATCH] infiniband:mlx4:Fix assumation that ib_get_cached_pkey runs successfully in build_mlx_header

On 9/10/2015 2:04 AM, Nicholas Krause wrote: This fixes a incorrect assumation that ib_get_cached_pkey always runs successfully in the function build_mlx_header by checking if the calls to this particular function return the error code, -EINVAL in order to signal they failed to grap the public

Re: [PATCH] infiniband:mlx4:Fix assumation that ib_get_cached_pkey runs successfully in build_mlx_header

On 9/10/2015 2:04 AM, Nicholas Krause wrote: This fixes a incorrect assumation that ib_get_cached_pkey always runs successfully in the function build_mlx_header by checking if the calls to this particular function return the error code, -EINVAL in order to signal they failed to grap the public

Re: [RFC/RFT PATCH v3 0/4] KVM: x86: full virtualization of guest MTRR

On 7/8/2015 6:18 PM, Paolo Bonzini wrote: This part of the MTRR patches was dropped by Xiao. Bring SVM on feature parity with VMX, and then do guest MTRR virtualization for both VMX and SVM. The IPAT bit of VMX extended page tables is emulated by mangling the guest PAT value. I do not have

Re: [RFC/RFT PATCH v3 0/4] KVM: x86: full virtualization of guest MTRR

On 7/8/2015 6:18 PM, Paolo Bonzini wrote: This part of the MTRR patches was dropped by Xiao. Bring SVM on feature parity with VMX, and then do guest MTRR virtualization for both VMX and SVM. The IPAT bit of VMX extended page tables is emulated by mangling the guest PAT value. I do not have

Re: [BUG] mellanox IB driver fails to load on large config

On 7/14/2015 11:28 PM, Alex Thorlton wrote: We see the same exact messages on 4.1-rc8. does this solves the problem? diff --git a/include/linux/mlx4/device.h b/include/linux/mlx4/device.h index ad31e47..c8ae3b9 100644 --- a/include/linux/mlx4/device.h +++ b/include/linux/mlx4/device.h @@

Re: [BUG] mellanox IB driver fails to load on large config

On 7/14/2015 11:28 PM, Alex Thorlton wrote: We see the same exact messages on 4.1-rc8. does this solves the problem? diff --git a/include/linux/mlx4/device.h b/include/linux/mlx4/device.h index ad31e47..c8ae3b9 100644 --- a/include/linux/mlx4/device.h +++ b/include/linux/mlx4/device.h @@

Re: [BUG] mellanox IB driver fails to load on large config

On Tue, Jul 14, 2015 at 9:48 PM, Alex Thorlton wrote: > On Tue, Jul 14, 2015 at 01:22:34PM -0500, andrew banman wrote: >> On Sat, Jul 11, 2015 at 11:20:19PM +0300, Or Gerlitz wrote: >> > On Fri, Jul 10, 2015 at 10:15 PM, andrew banman wrote: >> > > I'm seeing a lar

Re: [BUG] mellanox IB driver fails to load on large config

On Tue, Jul 14, 2015 at 9:48 PM, Alex Thorlton athorl...@sgi.com wrote: On Tue, Jul 14, 2015 at 01:22:34PM -0500, andrew banman wrote: On Sat, Jul 11, 2015 at 11:20:19PM +0300, Or Gerlitz wrote: On Fri, Jul 10, 2015 at 10:15 PM, andrew banman aban...@sgi.com wrote: I'm seeing a large number

Re: [BUG] mellanox IB driver fails to load on large config

On Fri, Jul 10, 2015 at 10:15 PM, andrew banman wrote: > I'm seeing a large number of allocation errors originating from the Mellanox > IB > driver when booting the 4.2-rc1 kernel on a 4096cpu 32TB memory system: Just to make sure, mlx4 works fine on this small (...) system with 4.1 and 4.2-rc1

Re: [BUG] mellanox IB driver fails to load on large config

On Fri, Jul 10, 2015 at 10:15 PM, andrew banman aban...@sgi.com wrote: I'm seeing a large number of allocation errors originating from the Mellanox IB driver when booting the 4.2-rc1 kernel on a 4096cpu 32TB memory system: Just to make sure, mlx4 works fine on this small (...) system with 4.1

Re: mlx4: "failed to allocate default counter port 1"

On Tue, Jun 30, 2015 at 1:45 PM, Sebastian Ott wrote: > after the latest mellanox update the mlx4 driver fails to probe a VF: > [ 88.909562] mlx4_core :00:00.0: mlx4_allocate_default_counters: failed > to allocate default counter port 1 err -22 > [ 88.909564] mlx4_core :00:00.0:

Re: mlx4: failed to allocate default counter port 1

On Tue, Jun 30, 2015 at 1:45 PM, Sebastian Ott seb...@linux.vnet.ibm.com wrote: after the latest mellanox update the mlx4 driver fails to probe a VF: [ 88.909562] mlx4_core :00:00.0: mlx4_allocate_default_counters: failed to allocate default counter port 1 err -22 [ 88.909564]

Re: [GIT] Networking

On Thu, Jun 25, 2015 at 2:38 AM, Linus Torvalds wrote: > > On Wed, Jun 24, 2015 at 6:39 AM, David Miller wrote: > > > > git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master > > Just going through the conflicts, I see commit 7193a141eb74 ("IB/mlx4: > Set VF to read from QP

  1   2   3   >