Hi Dmitry,
On 03:14 Tue 26 Nov , Dmitry Torokhov wrote:
> Hi Oskar,
>
> On Fri, Nov 22, 2013 at 02:27:04PM +0100, Oskar Andero wrote:
> > From: Aleksej Makarov
> >
> > When waking up the platform by pressing a specific key, sending a
> > release on that ke
Signed-off-by: Aleksej Makarov
Signed-off-by: Oskar Andero
---
drivers/input/input.c | 11 +--
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/drivers/input/input.c b/drivers/input/input.c
index 846ccdd..511d490 100644
--- a/drivers/input/input.c
+++ b/drivers/input/input.c
Hi Ulf,
On 18:50 Tue 22 Oct , Ulf Hansson wrote:
> > And this is after the patch has been applied:
> > KB reclen write rewritereadreread
> >51200 4 251 990 3280 3244
> >51200 8 4601545 4460 4463
> >
Hi Ulf,
On 17:01 Wed 16 Oct , Ulf Hansson wrote:
> Hi Oskar / Lars,
>
> Sorry for the delayed response!
>
> On 10 October 2013 15:28, Oskar Andero wrote:
> > From: Lars Svensson
> >
> > Some error bits in the status field of R1/R1b response are only set
transfer. In some situations this causes errors passing undetected.
The solution is to read the status and check for these errors after
each r/w operation.
Signed-off-by: Lars Svensson
Signed-off-by: Oskar Andero
Cc: linux-...@vger.kernel.org
---
drivers/mmc/card/block.c | 105
Hii Dmitry,
On 14:09 Thu 25 Jul , Oskar Andero wrote:
> From: Aleksej Makarov
>
> When waking up the platform by pressing a specific key, sending a
> release on that key makes it impossible to react on the event in
> user-space. This is fixed by moving the input_reset_d
Signed-off-by: Aleksej Makarov
Signed-off-by: Oskar Andero
---
drivers/input/input.c | 11 +--
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/drivers/input/input.c b/drivers/input/input.c
index c044699..ee3ff16 100644
--- a/drivers/input/input.c
+++ b/drivers/input/input.c
Hi,
On 14:47 Tue 09 Jul , Oskar Andero wrote:
> From: Lars Svensson
>
> Some error bits in the status field of R1/R1b response are only set
> by the device in response to the command following the failing
> command. The status is only read and checked after a r/w command i
On 09:46 Fri 05 Jul , Oskar Andero wrote:
> Hi Dmitry,
>
> On 18:33 Thu 04 Apr , Dmitry Torokhov wrote:
> > Hi Oskar,
> >
> > On Thu, Mar 07, 2013 at 03:01:22PM +0100, oskar.and...@sonymobile.com wrote:
> > > From: Aleksej Makarov
> > >
&g
transfer. In some situations this causes errors passing undetected.
The solution is to read the status and check for these errors after
each r/w operation.
Signed-off-by: Lars Svensson
Signed-off-by: Oskar Andero
Cc: linux-...@vger.kernel.org
---
drivers/mmc/card/block.c | 105
Hi Dmitry,
On 18:33 Thu 04 Apr , Dmitry Torokhov wrote:
> Hi Oskar,
>
> On Thu, Mar 07, 2013 at 03:01:22PM +0100, oskar.and...@sonymobile.com wrote:
> > From: Aleksej Makarov
> >
> > When waking up the platform by pressing a specific key, sending a
> > release on that key makes it impossible
From: Shingo Nakao
When backlight turns on early from display, a white line can be
seen on the screen. Therefore make sure backlight is off when we
are under an fb blank event.
Signed-off-by: Shingo Nakao
Cc: Milo Kim
Cc: Richard Purdie
Signed-off-by: Oskar Andero
---
drivers/video
From: Ren Bigcren
The device report an error capacity when read_capacity_16().
Using read_capacity_10() can get the correct capacity.
Signed-off-by: Ren Bigcren
Cc: Matthew Dharm
Signed-off-by: Oskar Andero
---
drivers/usb/storage/unusual_devs.h | 7 +++
1 file changed, 7 insertions
Add a VM_BUG_ON to catch any illegal value from the shrinkers. It's a
potential bug if scan_objects returns a negative other than -1 and
would lead to undefined behaviour.
Cc: Glauber Costa
Cc: Dave Chinner
Cc: Andrew Morton
Cc: Hugh Dickins
Cc: Greg Kroah-Hartman
Signed-off-by: Oskar A
Add a BUG_ON to catch any illegal value from the shrinkers. This fixes a
potential bug if scan_objects returns a negative other than -1, which
would lead to undefined behaviour.
Cc: Glauber Costa
Cc: Dave Chinner
Cc: Andrew Morton
Cc: Hugh Dickins
Cc: Greg Kroah-Hartman
Signed-off-by: Oskar
On 08:33 Fri 17 May , Dave Chinner wrote:
> On Thu, May 16, 2013 at 02:27:52PM +0200, Oskar Andero wrote:
> > On 13:52 Thu 16 May , Dave Chinner wrote:
> > > On Thu, May 16, 2013 at 10:42:16AM +0200, Oskar Andero wrote:
> > > > The shrinkers must return
On 13:52 Thu 16 May , Dave Chinner wrote:
> On Thu, May 16, 2013 at 10:42:16AM +0200, Oskar Andero wrote:
> > The shrinkers must return -1 to indicate that it is busy. Instead, treat
> > any negative value as busy.
>
> Why? The API defines return condition for aborting
The shrinkers must return -1 to indicate that it is busy. Instead, treat
any negative value as busy.
This fixes a potential bug if scan_objects returns a negative other than -1.
Cc: Glauber Costa
Cc: Dave Chinner
Cc: Andrew Morton
Cc: Hugh Dickins
Cc: Greg Kroah-Hartman
Signed-off-by: Oskar
On 16:49 Wed 15 May , Glauber Costa wrote:
> On 05/15/2013 06:47 PM, Oskar Andero wrote:
> > On 16:18 Wed 15 May , Glauber Costa wrote:
> >> On 05/15/2013 06:10 PM, Oskar Andero wrote:
> >>> On 17:03 Tue 14 May , Glauber Costa wrote:
> >>>&g
On 01:05 Thu 16 May , Andrew Morton wrote:
> On Mon, 13 May 2013 16:16:33 +0200 Oskar Andero
> wrote:
>
> > In a previous discussion on lkml it was noted that the shrinkers use the
> > magic value "-1" to signal that something went wrong.
> >
> >
On 16:18 Wed 15 May , Glauber Costa wrote:
> On 05/15/2013 06:10 PM, Oskar Andero wrote:
> > On 17:03 Tue 14 May , Glauber Costa wrote:
> >> On 05/13/2013 06:16 PM, Oskar Andero wrote:
> >>> Hi,
> >>>
> >>> In a previous disc
On 17:03 Tue 14 May , Glauber Costa wrote:
> On 05/13/2013 06:16 PM, Oskar Andero wrote:
> > Hi,
> >
> > In a previous discussion on lkml it was noted that the shrinkers use the
> > magic value "-1" to signal that something went wrong.
> >
>
hat do you say? Is this a good idea or does it make no sense at all?
Thanks!
-Oskar
Oskar Andero (2):
mm: vmscan: let any negative return value from shrinker mean error
Clean-up shrinker return values
drivers/staging/android/ashmem.c | 2 +-
drivers/staging/zcache/zcache-main.c | 2 +
The shrinkers must return -1 to indicate that it is busy. Instead of
relaying on magical numbers, let any negative value indicate error. This
opens up for using the errno.h error codes in the shrinker
implementations.
Cc: Hugh Dickins
Cc: Greg Kroah-Hartman
Signed-off-by: Oskar Andero
Shrinkers return hardcoded -1 on error. Use errno.h values instead
to add more meaning to the errors.
Cc: Hugh Dickins
Cc: Greg Kroah-Hartman
Signed-off-by: Oskar Andero
---
drivers/staging/android/ashmem.c | 2 +-
drivers/staging/zcache/zcache-main.c | 2 +-
fs/gfs2/glock.c
This adds support for Microchip's 12 bit AD converters MCP3204 and
MCP3208. These chips communicates over SPI and supports single-ended
and pseudo-differential configurations.
Cc: Jonathan Cameron
Cc: Lars-Peter Clausen
Signed-off-by: Oskar Andero
---
drivers/iio/adc/Kconfig
This adds support for Microchip's 12 bit AD converters MCP3204 and
MCP3208. These chips communicates over SPI and supports single-ended
and pseudo-differential configurations.
Cc: Jonathan Cameron
Cc: Lars-Peter Clausen
Signed-off-by: Oskar Andero
---
drivers/iio/adc/Kconfig
This adds support for Microchip's 12 bit AD converters MCP3204 and
MCP3208. These chips communicates over SPI and supports single-ended
and pseudo-differential configurations.
Cc: Jonathan Cameron
Cc: Lars-Peter Clausen
Signed-off-by: Oskar Andero
---
drivers/iio/adc/Kconfig
Hi,
On 16:07 Wed 01 May , Lars-Peter Clausen wrote:
> On 05/01/2013 12:21 AM, Oskar Andero wrote:
> > This adds support for Microchip's 12 bit AD converters MCP3204 and
> > MCP3208. These chips communicates over SPI and supports single-ended
> > and pseudo-d
This adds support for Microchip's 12 bit AD converters MCP3204 and
MCP3208. These chips communicates over SPI and supports single-ended
and pseudo-differential configurations.
Cc: Jonathan Cameron
Cc: Lars-Peter Clausen
Signed-off-by: Oskar Andero
---
drivers/iio/adc/Kc
On 22:00 Tue 16 Apr , David Rientjes wrote:
> On Tue, 16 Apr 2013, Oskar Andero wrote:
>
> > > > The comment in shrinker.h is misleading, not the source code.
> > > > do_shrinker_shrink() will fail for anything negative and 0.
> > >
> > > The c
On 08:19 Tue 16 Apr , Dan Carpenter wrote:
> On Mon, Apr 15, 2013 at 04:11:18PM -0700, David Rientjes wrote:
> > On Mon, 15 Apr 2013, Greg Kroah-Hartman wrote:
> >
> > > > The positive numbers are used to return information on the remaining
> > > > cache size (again, see the comment I pasted a
On 16:13 Mon 15 Apr , Dan Carpenter wrote:
> On Mon, Apr 15, 2013 at 03:38:08PM +0200, Dolkow, Snild wrote:
> > >Where is lowmem_shrink called from? I only see shrink called from the
> > >bcache sysfs handler __bch_cache_set(). The return value isn't checked
> > >there.
> > >
> > >Up to now t
: Brian Swetland
Reviewed-by: Radovan Lekanovic
Signed-off-by: Snild Dolkow
Signed-off-by: Oskar Andero
---
drivers/staging/android/lowmemorykiller.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/staging/android/lowmemorykiller.c
b/drivers/staging/android/lowmemorykiller.c
Hi James,
On 18:39 Mon 08 Apr , James Bottomley wrote:
> On Mon, 2013-04-08 at 13:42 +0200, Oskar Andero wrote:
> > On 14:36 Thu 07 Mar , oskar.and...@sonymobile.com wrote:
> > > From: "syunsuke.x.itou"
> > >
> > > By repeatadly connecting
ointer. This
> patch adds a null pointer check.
>
> Reviewed-by: Radovan Lekanovic
> Signed-off-by: syunsuke.x.itou
> Signed-off-by: Oskar Andero
> ---
> drivers/scsi/sd.c |7 ++-
> 1 files changed, 6 insertions(+), 1 deletions(-)
>
> diff --git a/drivers
From: Toby Collett
The symbol lookup can take a long time and kprobes is
initialised very early in boot, so delay symbol lookup
until the blacklist is first used.
Cc: Masami Hiramatsu
Cc: David S. Miller
Reviewed-by: Radovan Lekanovic
Signed-off-by: Toby Collett
Signed-off-by: Oskar Andero
...@vger.kernel.org
Reviewed-by: Radovan Lekanovic
Signed-off-by: Björn Davidsson
Signed-off-by: Oskar Andero
Acked-by: Masami Hiramatsu
---
arch/x86/kernel/kprobes/core.c | 7 +++
kernel/kprobes.c | 3 ---
2 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/arch/x86/kernel
. Miller
Cc: linux-a...@vger.kernel.org
Signed-off-by: Oskar Andero
---
kernel/kprobes.c | 88 +---
1 file changed, 59 insertions(+), 29 deletions(-)
diff --git a/kernel/kprobes.c b/kernel/kprobes.c
index c8c2281..2458ae1 100644
--- a/kernel
arch_kprobes_blacksyms.* as __weak symbols.
-Oskar
Björn Davidsson (1):
kprobes: move x86-specific blacklist symbols to arch directory
Oskar Andero (2):
kprobes: split blacklist into common and arch
kprobes: replace printk with pr_-functions
Toby Collett (1):
kprobes: delay blacklist
Instead of using printk use pr_info/pr_err/pr_warn. This was
detected by the checkpatch.pl script.
Cc: Masami Hiramatsu
Cc: David S. Miller
Signed-off-by: Oskar Andero
Acked-by: Masami Hiramatsu
---
kernel/kprobes.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions
Thanks for your input guys!
On 04:16 Fri 05 Apr , Masami Hiramatsu wrote:
> (2013/04/05 9:56), Joonsoo Kim wrote:
> > Hello, Oskar.
> >
> > On Thu, Apr 04, 2013 at 02:51:26PM +0200, Oskar Andero wrote:
> >> From: Toby Collett
> >>
> >> The s
On 18:33 Thu 04 Apr , Dmitry Torokhov wrote:
> Hi Oskar,
>
> On Thu, Mar 07, 2013 at 03:01:22PM +0100, oskar.and...@sonymobile.com wrote:
> > From: Aleksej Makarov
> >
> > When waking up the platform by pressing a specific key, sending a
> > release on that key makes it impossible to react o
ed-by: Radovan Lekanovic
> Signed-off-by: Aleksej Makarov
> Signed-off-by: Oskar Andero
> ---
> drivers/input/input.c |5 -
> 1 files changed, 4 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/input/input.c b/drivers/input/input.c
> index c044699..61ce
. Miller
Cc: linux-a...@vger.kernel.org
Signed-off-by: Oskar Andero
---
arch/arc/kernel/kprobes.c | 3 ++
arch/arm/kernel/kprobes.c | 2 +
arch/avr32/kernel/kprobes.c| 3 ++
arch/ia64/kernel/kprobes.c | 3 ++
arch/mips/kernel/kprobes.c | 3 ++
arch/mn10300/kernel
...@vger.kernel.org
Reviewed-by: Radovan Lekanovic
Signed-off-by: Björn Davidsson
Signed-off-by: Oskar Andero
---
arch/x86/kernel/kprobes/core.c | 6 +-
kernel/kprobes.c | 3 ---
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/arch/x86/kernel/kprobes/core.c b/arch/x86
also included linux-arch in Cc for this post.
-Oskar
Björn Davidsson (1):
kprobes: move x86-specific blacklist symbols to arch directory
Oskar Andero (2):
kprobes: split blacklist into common and arch
kprobes: replace printk with pr_-functions
Toby Collett (1):
kprobes: delay blacklist s
From: Toby Collett
The symbol lookup can take a long time and kprobes is
initialised very early in boot, so delay symbol lookup
until the blacklist is first used.
Cc: Masami Hiramatsu
Cc: David S. Miller
Reviewed-by: Radovan Lekanovic
Signed-off-by: Toby Collett
Signed-off-by: Oskar Andero
Instead of using printk use pr_info/pr_err/pr_warn. This was
detected by the checkpatch.pl script.
Cc: Masami Hiramatsu
Cc: David S. Miller
Signed-off-by: Oskar Andero
Acked-by: Masami Hiramatsu
---
kernel/kprobes.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions
On 08:17 Thu 04 Apr , Masami Hiramatsu wrote:
> (2013/04/03 17:28), oskar.and...@sonymobile.com wrote:
> > Some blackpoints are only valid for specific architectures. To let each
> > architecture specify its own blackpoints the list has been split in two
> > lists: common and arch. The common l
gt;
> > -Oskar
> >
> > Björn Davidsson (1):
> > kprobes: move x86-specific blacklist symbols to arch directory
> >
> > Oskar Andero (2):
> > kprobes: split blacklist into common and arch
> > kprobes: replace printk with pr_-functions
> &
On 08:44 Thu 04 Apr , Masami Hiramatsu wrote:
> (2013/04/03 17:28), oskar.and...@sonymobile.com wrote:
> >
> > +/* it can take some time ( > 100ms ) to initialise the
> > + * blacklist so we delay this until we actually need it
> > + */
> > +static void init_kprobe_blacklist(void)
> > +{
> >
52 matches
Mail list logo