[PATCH 7/9] cpufreq: loongson1: Add missing MODULE_ALIAS

2020-11-03 Thread Pali Rohár
This patch adds missing MODULE_ALIAS for automatic loading of this cpufreq driver when it is compiled as an external module. Signed-off-by: Pali Rohár Fixes: a0a22cf14472f ("cpufreq: Loongson1: Add cpufreq driver for Loongson1B") --- drivers/cpufreq/loongson1-cpufreq.c | 1 + 1 file

[PATCH 8/9] cpufreq: scpi: Add missing MODULE_ALIAS

2020-11-03 Thread Pali Rohár
This patch adds missing MODULE_ALIAS for automatic loading of this cpufreq driver when it is compiled as an external module. Signed-off-by: Pali Rohár Fixes: 8def31034d033 ("cpufreq: arm_big_little: add SCPI interface driver") --- drivers/cpufreq/scpi-cpufreq.c | 1 + 1 file

[PATCH 1/9] cpufreq: ap806: Add missing MODULE_DEVICE_TABLE

2020-11-03 Thread Pali Rohár
This patch adds missing MODULE_DEVICE_TABLE definition which generates correct modalias for automatic loading of this cpufreq driver when it is compiled as an external module. Signed-off-by: Pali Rohár Fixes: f525a670533d9 ("cpufreq: ap806: add cpufreq driver for Armada 8K") --- drive

[PATCH 5/9] cpufreq: st: Add missing MODULE_DEVICE_TABLE

2020-11-03 Thread Pali Rohár
This patch adds missing MODULE_DEVICE_TABLE definition which generates correct modalias for automatic loading of this cpufreq driver when it is compiled as an external module. Signed-off-by: Pali Rohár Fixes: ab0ea257fc58d ("cpufreq: st: Provide runtime initialised driver for ST's plat

[PATCH 3/9] cpufreq: mediatek: Add missing MODULE_DEVICE_TABLE

2020-11-03 Thread Pali Rohár
This patch adds missing MODULE_DEVICE_TABLE definition which generates correct modalias for automatic loading of this cpufreq driver when it is compiled as an external module. Signed-off-by: Pali Rohár Fixes: 501c574f4e3a5 ("cpufreq: mediatek: Add support of cpufreq to MT2701/MT762

[PATCH 9/9] cpufreq: vexpress-spc: Add missing MODULE_ALIAS

2020-11-03 Thread Pali Rohár
This patch adds missing MODULE_ALIAS for automatic loading of this cpufreq driver when it is compiled as an external module. Signed-off-by: Pali Rohár Fixes: 47ac9aa165540 ("cpufreq: arm_big_little: add vexpress SPC interface driver") --- drivers/cpufreq/vexpress-spc-cpufreq.c | 1

Re: [PATCH v11 00/10] NTFS read-write driver GPL implementation by Paragon Software

2020-10-30 Thread Pali Rohár
Hello! On Friday 30 October 2020 18:02:29 Konstantin Komarov wrote: > 27 files changed, 28364 insertions(+) > create mode 100644 Documentation/filesystems/ntfs3.rst > create mode 100644 fs/ntfs3/Kconfig > create mode 100644 fs/ntfs3/Makefile > create mode 100644 fs/ntfs3/attrib.c > create

Re: [PATCH v11 00/10] NTFS read-write driver GPL implementation by Paragon Software

2020-10-30 Thread Pali Rohár
Hello! On Friday 30 October 2020 15:51:10 Konstantin Komarov wrote: > From: Pali Rohár > Sent: Friday, October 30, 2020 6:25 PM > > To: Konstantin Komarov > > Cc: linux-fsde...@vger.kernel.org; v...@zeniv.linux.org.uk; > > linux-kernel@vger.kernel.org; dste...@suse.cz;

Re: [PATCH v11 00/10] NTFS read-write driver GPL implementation by Paragon Software

2020-10-30 Thread Pali Rohár
Hello and thanks for update! I have just two comments for the last v11 version. I really do not like nls_alt mount option and I do not think we should merge this mount option into ntfs kernel driver. Details I described in:

Re: [PATCH v2] libata: Fix retrieving of active qcs

2020-10-28 Thread Pali Rohár
de:0055] (rev f3) Both disks are working fine, I do not see any regression or change, so you can add my: Tested-by: Pali Rohár Ideally add also Fixes line: Fixes: 28361c403683 ("libata: add extra internal command") Jens, do you need something more from me? Some special tests, etc?

Re: [PATCH v2] arm64: dts: marvell: add DT for ESPRESSObin-Ultra

2020-10-26 Thread Pali Rohár
Hello! On Friday 23 October 2020 18:21:11 Vladimir Vid wrote: > This adds support for ESPRESSObin-Ultra from Globalscale. > > Specifications are similar to the base ESPRESSObin board, with main > difference being being WAN port with PoE capability and 2 additional ethernet > ports. > > Full

Re: Reducing number of Espressobin DTS files

2020-10-22 Thread Pali Rohár
On Thursday 22 October 2020 16:29:00 Andrew Lunn wrote: > > For example, Turris MOX board which is also A3720 based has optional > > SDIO module which can be plugged / unplugged, standard variant is sold > > without it and in DTS file is this node always enabled: > > I think the Turris has quite

Reducing number of Espressobin DTS files

2020-10-22 Thread Pali Rohár
Hello! For Espressobin A3720 board there are currently 4 DTS files: https://git.kernel.org/pub/scm/linux/kernel/git/gclement/mvebu.git/tree/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts?h=for-next

Re: [PATCH v2 01/24] mmc: sdio: add SDIO IDs for Silabs WF200 chip

2020-10-21 Thread Pali Rohár
; the DT. > > Signed-off-by: Jérôme Pouiller Looks good! Acked-by: Pali Rohár > --- > include/linux/mmc/sdio_ids.h | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/include/linux/mmc/sdio_ids.h b/include/linux/mmc/sdio_ids.h > index 12036619346c..20a48162f7f

Re: [PATCH] arm64: dts: marvell: espressobin: Add support for LED2

2020-10-21 Thread Pali Rohár
On Wednesday 21 October 2020 17:01:19 Andre Heider wrote: > On 19/10/2020 10:04, Pali Rohár wrote: > > Hello! Gregory, I would like to remind you following patch. > > > > Andre, if you have a time, could you test it too? > > I would, but I desoldered all LEDs a long t

Re: [PATCH v2] arm64: dts: marvell: espressobin: Update link to V7 schematic

2020-10-19 Thread Pali Rohár
Gregory, it is OK now? On Monday 05 October 2020 15:35:13 Pali Rohár wrote: > Up-to-date version of V7 schematic is on new URL linked from official > tech-spec webpage http://espressobin.net/tech-spec/ > > Signed-off-by: Pali Rohár > > --- > Changes in V2: > *

Re: [PATCH] arm64: dts: marvell: espressobin: Add support for LED2

2020-10-19 Thread Pali Rohár
Hello! Gregory, I would like to remind you following patch. Andre, if you have a time, could you test it too? On Tuesday 06 October 2020 14:44:55 Pali Rohár wrote: > LED2 is connected to MPP1_2 pin. It is working only on V7 boards. > V5 boards have hw bug which cause that LED2 is non-w

Re: [PATCH 07/23] wfx: add bus_sdio.c

2020-10-14 Thread Pali Rohár
On Wednesday 14 October 2020 13:52:15 Jérôme Pouiller wrote: > Hello Pali, > > On Tuesday 13 October 2020 22:11:56 CEST Pali Rohár wrote: > > Hello! > > > > On Monday 12 October 2020 12:46:32 Jerome Pouiller wrote: > > > +#define SDIO_VENDOR_ID

Re: [PATCH 07/23] wfx: add bus_sdio.c

2020-10-13 Thread Pali Rohár
Hello! On Monday 12 October 2020 12:46:32 Jerome Pouiller wrote: > +#define SDIO_VENDOR_ID_SILABS0x > +#define SDIO_DEVICE_ID_SILABS_WF200 0x1000 > +static const struct sdio_device_id wfx_sdio_ids[] = { > + { SDIO_DEVICE(SDIO_VENDOR_ID_SILABS, SDIO_DEVICE_ID_SILABS_WF200) },

Re: [PATCH] PCI: aardvark: Update comment about disabling link training

2020-10-11 Thread Pali Rohár
On Thursday 24 September 2020 17:22:32 Pali Rohár wrote: > On Thursday 24 September 2020 10:11:06 Bjorn Helgaas wrote: > > On Thu, Sep 24, 2020 at 10:46:18AM +0200, Pali Rohár wrote: > > > It is not HW bug or workaround for some cards but it is requirement by PCI > &g

Re: [PATCH v5 08/10] fs/ntfs3: Add Kconfig, Makefile and doc

2020-10-09 Thread Pali Rohár
On Friday 09 October 2020 15:31:10 Konstantin Komarov wrote: > From: Pali Rohár > Sent: Saturday, September 26, 2020 11:23 AM > > To: Konstantin Komarov > > Cc: linux-fsde...@vger.kernel.org; v...@zeniv.linux.org.uk; > > linux-kernel@vger.kernel.org; dste...@suse.cz;

Re: [PATCH] arm64: dts: marvell: add DT for ESPRESSObin-Ultra

2020-10-09 Thread Pali Rohár
Hello! On Friday 09 October 2020 17:27:10 Vladimir Vid wrote: > This adds support for ESPRESSObin-Ultra from Globalscale. > > Specifications are similar to the base ESPRESSObin board, with main > difference being being WAN port with PoE capability and 2 additional ethernet > ports. Cannot you

[PATCH] ata: ahci: mvebu: Make SATA PHY optional for Armada 3720

2020-10-09 Thread Pali Rohár
: dts: marvell: armada-3720-espressobin: declare SATA PHY property") where SATA phy was defined and therefore ahci_platform_enable_phys() on Espressobin started failing. Signed-off-by: Pali Rohár Tested-by: Tomasz Maciej Nowak Fixes: 8e18c8e58da64 ("arm64: dts: marvell: armada-3720-espre

Re: PCI: Race condition in pci_create_sysfs_dev_files

2020-10-09 Thread Pali Rohár
On Thursday 08 October 2020 14:59:07 Bjorn Helgaas wrote: > On Wed, Oct 07, 2020 at 11:14:34AM -0500, Bjorn Helgaas wrote: > > On Wed, Oct 07, 2020 at 10:14:00AM +0200, Pali Rohár wrote: > > > On Wednesday 07 October 2020 12:47:40 Oliver O'Halloran wrote: > > > > O

Re: PCI: Race condition in pci_create_sysfs_dev_files

2020-10-07 Thread Pali Rohár
On Wednesday 07 October 2020 12:47:40 Oliver O'Halloran wrote: > On Wed, Oct 7, 2020 at 10:26 AM Bjorn Helgaas wrote: > > > > I'm not really a fan of this because pci_sysfs_init() is a bit of a > > hack to begin with, and this makes it even more complicated. > > > > It's not obvious from the code

Re: PCI: Race condition in pci_create_sysfs_dev_files

2020-10-07 Thread Pali Rohár
On Tuesday 06 October 2020 17:22:22 Bjorn Helgaas wrote: > [+cc Krzysztof, Yinghai] > > On Wed, Sep 09, 2020 at 01:28:50PM +0200, Pali Rohár wrote: > > Hello! I'm adding more people to loop. > > > > Can somebody look at these race conditions and my patch? > > &

[PATCH] arm64: dts: marvell: espressobin: Add support for LED2

2020-10-06 Thread Pali Rohár
LED2 can be controlled directly from the host. LED1 is possible to control via WiFi card inserted in miniPCIe slot if driver for particular card supports it. Signed-off-by: Pali Rohár Tested-by: Gérald Kerma --- Previous version of this patch was sent by Uwe in March 2018, but it did not work

[PATCH v2] arm64: dts: marvell: espressobin: Update link to V7 schematic

2020-10-05 Thread Pali Rohár
Up-to-date version of V7 schematic is on new URL linked from official tech-spec webpage http://espressobin.net/tech-spec/ Signed-off-by: Pali Rohár --- Changes in V2: * Added commit description --- arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7-emmc.dts | 2 +- arch/arm64/boot/dts

Re: PCI: Race condition in pci_create_sysfs_dev_files

2020-10-05 Thread Pali Rohár
PING? On Wednesday 09 September 2020 13:28:50 Pali Rohár wrote: > Hello! I'm adding more people to loop. > > Can somebody look at these race conditions and my patch? > > On Friday 14 August 2020 10:08:24 Pali Rohár wrote: > > Hello! I would like to remind this issue which

Re: [PATCH 0/2] PCI: aardvark: Fix comphy with old ATF

2020-10-02 Thread Pali Rohár
On Friday 02 October 2020 16:15:47 Lorenzo Pieralisi wrote: > On Fri, Oct 02, 2020 at 05:07:01PM +0200, Pali Rohár wrote: > > [...] > > > > I will apply the stable tag and dependency, it should be fine. > > > > Ok! I thought that according to stable-kernel-rul

Re: [PATCH 0/2] PCI: aardvark: Fix comphy with old ATF

2020-10-02 Thread Pali Rohár
On Friday 02 October 2020 16:03:09 Lorenzo Pieralisi wrote: > On Fri, Oct 02, 2020 at 04:52:37PM +0200, Pali Rohár wrote: > > On Friday 02 October 2020 15:38:51 Lorenzo Pieralisi wrote: > > > On Fri, Oct 02, 2020 at 04:26:16PM +0200, Pali Rohár wrote: > > > > On F

Re: [PATCH 0/2] PCI: aardvark: Fix comphy with old ATF

2020-10-02 Thread Pali Rohár
On Friday 02 October 2020 15:38:51 Lorenzo Pieralisi wrote: > On Fri, Oct 02, 2020 at 04:26:16PM +0200, Pali Rohár wrote: > > On Friday 02 October 2020 14:37:13 Lorenzo Pieralisi wrote: > > > On Wed, Sep 02, 2020 at 04:43:42PM +0200, Pali Rohár wrote: > > > > This

Re: [PATCH 0/2] PCI: aardvark: Fix comphy with old ATF

2020-10-02 Thread Pali Rohár
On Friday 02 October 2020 14:37:13 Lorenzo Pieralisi wrote: > On Wed, Sep 02, 2020 at 04:43:42PM +0200, Pali Rohár wrote: > > This patch series fixes regression introduced in commit 366697018c9a > > ("PCI: aardvark: Add PHY support") which caused aardvark driver &

Re: [PATCH] arm64: dts: marvell: espressobin: De-duplicate eMMC definitions

2020-10-02 Thread Pali Rohár
On Sunday 27 September 2020 08:40:41 Andre Heider wrote: > On 25/09/2020 10:50, Pali Rohár wrote: > > eMMC definitions in files armada-3720-espressobin-emmc.dts and > > armada-3720-espressobin-v7-emmc.dts is same. So move it into common > > armada-3720-espressobin.dtsi file

Re: [PATCH 0/2] PCI: aardvark: Fix comphy with old ATF

2020-10-02 Thread Pali Rohár
On Wednesday 02 September 2020 16:43:42 Pali Rohár wrote: > This patch series fixes regression introduced in commit 366697018c9a > ("PCI: aardvark: Add PHY support") which caused aardvark driver > initialization failure on EspressoBin board with factory version of > Arm Tru

Re: Removal of HCI commands, userspace bluetooth regression?

2020-09-30 Thread Pali Rohár
On Wednesday 30 September 2020 13:20:06 Greg Kroah-Hartman wrote: > On Wed, Sep 30, 2020 at 01:00:13PM +0200, Pali Rohár wrote: > > On Wednesday 30 September 2020 12:54:34 Greg Kroah-Hartman wrote: > > > On Wed, Sep 30, 2020 at 11:46:16AM +0200, Pali Rohár wrote: > > >

Re: Removal of HCI commands, userspace bluetooth regression?

2020-09-30 Thread Pali Rohár
On Wednesday 30 September 2020 12:54:34 Greg Kroah-Hartman wrote: > On Wed, Sep 30, 2020 at 11:46:16AM +0200, Pali Rohár wrote: > > On Wednesday 30 September 2020 11:20:43 Greg Kroah-Hartman wrote: > > > On Wed, Sep 30, 2020 at 10:25:34AM +0200, Pali Rohár wrote: > > >

Re: Removal of HCI commands, userspace bluetooth regression?

2020-09-30 Thread Pali Rohár
On Wednesday 30 September 2020 11:20:20 Greg Kroah-Hartman wrote: > On Wed, Sep 30, 2020 at 10:16:40AM +0200, Marcel Holtmann wrote: > > Hi Greg, > > > > I wrote a simple script "sco_features.pl" which show all supported > > codecs by local HCI bluetooth adapter. Script is

Re: Removal of HCI commands, userspace bluetooth regression?

2020-09-30 Thread Pali Rohár
On Wednesday 30 September 2020 11:20:43 Greg Kroah-Hartman wrote: > On Wed, Sep 30, 2020 at 10:25:34AM +0200, Pali Rohár wrote: > > On Wednesday 30 September 2020 10:02:05 Greg Kroah-Hartman wrote: > > > On Tue, Sep 29, 2020 at 11:32:54PM +0200, Pali Rohár wrote: > &g

Re: Removal of HCI commands, userspace bluetooth regression?

2020-09-30 Thread Pali Rohár
On Wednesday 30 September 2020 10:02:05 Greg Kroah-Hartman wrote: > On Tue, Sep 29, 2020 at 11:32:54PM +0200, Pali Rohár wrote: > > CCing other lists and maintainers, hopefully, somebody would have a time to > > look at it... > > > > On Saturday 08 August 202

Removal of HCI commands, userspace bluetooth regression?

2020-09-29 Thread Pali Rohár
CCing other lists and maintainers, hopefully, somebody would have a time to look at it... On Saturday 08 August 2020 15:27:47 Pali Rohár wrote: > On Wednesday 15 April 2020 00:56:18 Pali Rohár wrote: > > On Sunday 09 February 2020 14:21:37 Pali Rohár wrote: > > > On Saturday

Re: [PATCH] MAINTAINERS: Add me as a reviewer for PCI aardvark

2020-09-26 Thread Pali Rohár
On Friday 25 September 2020 10:40:47 Bjorn Helgaas wrote: > On Fri, Sep 25, 2020 at 11:21:15AM +0200, Pali Rohár wrote: > > Signed-off-by: Pali Rohár > > --- > > I have provided more fixes to this driver, I have needed functional > > specification for this PCI c

Re: [PATCH v5 08/10] fs/ntfs3: Add Kconfig, Makefile and doc

2020-09-26 Thread Pali Rohár
On Friday 25 September 2020 16:30:19 Konstantin Komarov wrote: > From: Pali Rohár > Sent: Monday, September 21, 2020 4:27 PM > > To: Konstantin Komarov > > Cc: linux-fsde...@vger.kernel.org; v...@zeniv.linux.org.uk; > > linux-kernel@vger.kernel.org; dste...@suse.cz;

Re: [PATCH] arm64: dts: marvell: espressobin: Update link to V7 schematic

2020-09-25 Thread Pali Rohár
. Previous URL just contains older version. New URL is available in the main / official web page [1] for technical documentation and also is more descriptive. [1] - http://espressobin.net/tech-spec/ > Thank, > > Gregory > > > Signed-off-by: Pali Rohár > > --- > >

[PATCH] MAINTAINERS: Add me as a reviewer for PCI aardvark

2020-09-25 Thread Pali Rohár
Signed-off-by: Pali Rohár --- I have provided more fixes to this driver, I have needed functional specification for this PCI controller and also hardware for testing and developing (Espressobin V5 and Turris MOX B and G modules). Thomas already wrote [1] that is less involved in this driver, so

[PATCH] arm64: dts: marvell: espressobin: De-duplicate eMMC definitions

2020-09-25 Thread Pali Rohár
eMMC definitions in files armada-3720-espressobin-emmc.dts and armada-3720-espressobin-v7-emmc.dts is same. So move it into common armada-3720-espressobin.dtsi file with status "disabled". This change simplifies eMMC variants of DTS files for Espressobin. Signed-off-by: Pali Rohár --

[PATCH] arm64: dts: marvell: espressobin: Update link to V7 schematic

2020-09-25 Thread Pali Rohár
Signed-off-by: Pali Rohár --- arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7-emmc.dts | 2 +- arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7.dts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin-v7

Re: [PATCH] PCI: aardvark: Update comment about disabling link training

2020-09-24 Thread Pali Rohár
On Thursday 24 September 2020 10:11:06 Bjorn Helgaas wrote: > On Thu, Sep 24, 2020 at 10:46:18AM +0200, Pali Rohár wrote: > > It is not HW bug or workaround for some cards but it is requirement by PCI > > Express spec. After fundamental reset is needed 100ms delay prior enabling &g

[PATCH] PCI: aardvark: Update comment about disabling link training

2020-09-24 Thread Pali Rohár
It is not HW bug or workaround for some cards but it is requirement by PCI Express spec. After fundamental reset is needed 100ms delay prior enabling link training. So update comment in code to reflect this requirement. Signed-off-by: Pali Rohár --- drivers/pci/controller/pci-aardvark.c | 7

Re: [PATCH] arm64: dts: marvell: espressobin: Add ethernet switch aliases

2020-09-23 Thread Pali Rohár
On Tuesday 08 September 2020 09:47:33 Pali Rohár wrote: > On Monday 07 September 2020 19:23:45 Andrew Lunn wrote: > > On Mon, Sep 07, 2020 at 06:13:16PM +0200, Pali Rohár wrote: > > > On Monday 07 September 2020 17:43:53 Andrew Lunn wrote: > > > > > I w

Re: [PATCH v3 1/2] Bluetooth: btusb: define HCI packet sizes of USB Alts

2020-09-23 Thread Pali Rohár
Hello! On Monday 14 September 2020 20:18:27 Joseph Hwang wrote: > On Thu, Sep 10, 2020 at 4:18 PM Pali Rohár wrote: > > And this part of code which you write is Realtek specific. > > We currently only have Intel and Realtek platforms to test with. If > making it generic with

Re: [PATCH] arm64: dts: marvell: espressobin: Get rid of duplicate serial aliases

2020-09-21 Thread Pali Rohár
On Monday 21 September 2020 18:57:46 Andre Heider wrote: > On 21/09/2020 18:53, Pali Rohár wrote: > > On Monday 21 September 2020 18:48:30 Andre Heider wrote: > > > The included armada-372x.dtsi already defines these two aliases. > > > > Where? I do not

Re: [PATCH] arm64: dts: marvell: espressobin: Get rid of duplicate serial aliases

2020-09-21 Thread Pali Rohár
On Monday 21 September 2020 18:48:30 Andre Heider wrote: > The included armada-372x.dtsi already defines these two aliases. Where? I do not see it in that file: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/marvell/armada-372x.dtsi > >

Re: [PATCH v3 04/10] fs/ntfs3: Add file operations and implementation

2020-09-21 Thread Pali Rohár
On Friday 11 September 2020 16:52:50 Konstantin Komarov wrote: > From: Pali Rohár > Sent: Friday, September 4, 2020 2:51 PM > > > > Hello Konstantin! > > > > On Friday 28 August 2020 07:39:32 Konstantin Komarov wrote: > > > +/* > &g

Re: [PATCH v5 08/10] fs/ntfs3: Add Kconfig, Makefile and doc

2020-09-21 Thread Pali Rohár
On Friday 11 September 2020 17:10:16 Konstantin Komarov wrote: > +Mount Options > += > + > +The list below describes mount options supported by NTFS3 driver in addition > to > +generic ones. > + > +=== > + >

Re: [PATCH 0/2] PCI: aardvark: Fix comphy with old ATF

2020-09-21 Thread Pali Rohár
Lorenzo, could you look and review this patch series? It fixes commit 366697018c9a and we would like to have fix also in stable kernels. On Wednesday 16 September 2020 17:14:02 Tomasz Maciej Nowak wrote: > W dniu 02.09.2020 o 16:43, Pali Rohár pisze: > > This patch series fixes r

Re: [PATCH v3 1/2] Bluetooth: btusb: define HCI packet sizes of USB Alts

2020-09-10 Thread Pali Rohár
On Thursday 10 September 2020 14:04:01 Joseph Hwang wrote: > It is desirable to define the HCI packet payload sizes of > USB alternate settings so that they can be exposed to user > space. > > Reviewed-by: Alain Michaud > Reviewed-by: Abhishek Pandit-Subedi > Signed-off-by: Joseph Hwang > ---

Re: [PATCH v3 2/2] Bluetooth: sco: new getsockopt options BT_SNDMTU/BT_RCVMTU

2020-09-10 Thread Pali Rohár
ting kernels. > > Reviewed-by: Alain Michaud > Reviewed-by: Abhishek Pandit-Subedi > Signed-off-by: Joseph Hwang Looks good, Reviewed-by: Pali Rohár > --- > > Changes in v3: > - Fixed the commit message. > > Changes in v2: > - Used BT_SNDMTU/BT_RCVMTU

Re: [PATCH v2 2/2] Bluetooth: sco: expose WBS packet length in socket option

2020-09-09 Thread Pali Rohár
On Wednesday 09 September 2020 17:42:02 Joseph Hwang wrote: > It is desirable to expose the wideband speech packet length via > a socket option to the user space so that the user space can set > the value correctly in configuring the sco connection. Hello! I'm fine with change below, but I would

Re: PCI: Race condition in pci_create_sysfs_dev_files

2020-09-09 Thread Pali Rohár
Hello! I'm adding more people to loop. Can somebody look at these race conditions and my patch? On Friday 14 August 2020 10:08:24 Pali Rohár wrote: > Hello! I would like to remind this issue which I reported month ago. > > On Thursday 16 July 2020 13:04:23 Pali Rohár wrote: > &

Re: [PATCH v2 1/2] Bluetooth: btusb: define HCI packet sizes of USB Alts

2020-09-09 Thread Pali Rohár
On Wednesday 09 September 2020 17:42:01 Joseph Hwang wrote: > It is desirable to define the HCI packet payload sizes of > USB alternate settings so that they can be exposed to user > space. > > Reviewed-by: Alain Michaud > Reviewed-by: Abhishek Pandit-Subedi > Signed-off-by: Joseph Hwang > ---

Re: [PATCH] arm64: dts: marvell: espressobin: Add ethernet switch aliases

2020-09-08 Thread Pali Rohár
On Monday 07 September 2020 19:23:45 Andrew Lunn wrote: > On Mon, Sep 07, 2020 at 06:13:16PM +0200, Pali Rohár wrote: > > On Monday 07 September 2020 17:43:53 Andrew Lunn wrote: > > > > I would not say it is a "new feature". But rather that patch in this > > &g

Re: [PATCH] arm64: dts: marvell: espressobin: Simplify v7 ethernet port labeling

2020-09-08 Thread Pali Rohár
On Tuesday 08 September 2020 09:30:50 Andre Heider wrote: > Now that the switch ports have a label in the .dtsi, simplify the whole > "switch0" block for the v7 dts files. > > Signed-off-by: Andre Heider Thank you, looks good! Reviewed-by: Pali Rohár > --- >

[PATCH v3 2/5] PCI: aardvark: Check for errors from pci_bridge_emul_init() call

2020-09-07 Thread Pali Rohár
Function pci_bridge_emul_init() may fail so correctly check for errors. Fixes: 8a3ebd8de328 ("PCI: aardvark: Implement emulated root PCI bridge config space") Signed-off-by: Pali Rohár Reviewed-by: Marek Behún --- drivers/pci/controller/pci-aardvark.c | 11 +++ 1 file

Re: [PATCH v2 0/5] PCIe aardvark controller improvements

2020-09-07 Thread Pali Rohár
On Monday 07 September 2020 10:40:32 Lorenzo Pieralisi wrote: > can you rebase it on top of v5.9-rc1 and resend, thanks. Done!

[PATCH v3 3/5] PCI: pci-bridge-emul: Export API functions

2020-09-07 Thread Pali Rohár
It allows kernel modules which are not compiled into kernel image to use pci-bridge-emul API functions. Signed-off-by: Pali Rohár Reviewed-by: Marek Behún --- drivers/pci/pci-bridge-emul.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/pci/pci-bridge-emul.c b/drivers/pci/pci

[PATCH v3 1/5] PCI: aardvark: Fix compilation on s390

2020-09-07 Thread Pali Rohár
://lore.kernel.org/r/20200628.lxtenqfl%25...@intel.com Reported-by: kernel test robot Fixes: 5169a9851da ("PCI: aardvark: Issue PERST via GPIO") Signed-off-by: Pali Rohár Reviewed-by: Marek Behún --- drivers/pci/controller/pci-aardvark.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH v3 0/5] PCIe aardvark controller improvements

2020-09-07 Thread Pali Rohár
-rc1 release Changes in V2 for patch 4/5: * Protect pci_stop_root_bus() and pci_remove_root_bus() function calls by pci_lock_rescan_remove() and pci_unlock_rescan_remove() Pali Rohár (5): PCI: aardvark: Fix compilation on s390 PCI: aardvark: Check for errors from pci_bridge_emul_init() call

Re: [PATCH] arm64: dts: marvell: espressobin: Add ethernet switch aliases

2020-09-07 Thread Pali Rohár
On Monday 07 September 2020 19:43:08 Andre Heider wrote: > On 07/09/2020 19:35, Pali Rohár wrote: > > On Monday 07 September 2020 19:23:03 Andrew Lunn wrote: > > > > My dts-foo is a little rusty, but now that you labeled the ports in the > > > > .dtsi, can t

Re: [PATCH] arm64: dts: marvell: espressobin: Add ethernet switch aliases

2020-09-07 Thread Pali Rohár
On Monday 07 September 2020 19:13:41 Andre Heider wrote: > > @@ -120,7 +124,7 @@ > > #address-cells = <1>; > > #size-cells = <0>; > > - port@0 { > > + switch0port0: port@0 { > > This label is unused it seems. Yes, it is

Re: [PATCH] arm64: dts: marvell: espressobin: Add ethernet switch aliases

2020-09-07 Thread Pali Rohár
On Monday 07 September 2020 19:23:03 Andrew Lunn wrote: > > My dts-foo is a little rusty, but now that you labeled the ports in the > > .dtsi, can this whole "switch0" block reduced to something like: > > > > { > > label = "lan1"; > > }; > > > > { > > label = "wan"; > > }; > >

Re: [PATCH] arm64: dts: marvell: espressobin: Add ethernet switch aliases

2020-09-07 Thread Pali Rohár
On Monday 07 September 2020 17:43:53 Andrew Lunn wrote: > > I would not say it is a "new feature". But rather that patch in this > > email fixes issue that Linux kernel did not set correct MAC address for > > DSA slave ports. I think it is something which could be backported also > > to stable

Re: [PATCH] arm64: dts: marvell: espressobin: Add ethernet switch aliases

2020-09-07 Thread Pali Rohár
On Monday 07 September 2020 16:42:28 Andrew Lunn wrote: > On Mon, Sep 07, 2020 at 01:27:17PM +0200, Pali Rohár wrote: > > Espressobin boards have 3 ethernet ports and some of them got assigned more > > then one MAC address. MAC addresses are stored in U-Boot environment. > &

[PATCH] cpufreq: armada-37xx: Add missing MODULE_DEVICE_TABLE

2020-09-07 Thread Pali Rohár
CONFIG_ARM_ARMADA_37XX_CPUFREQ is tristate option and therefore this cpufreq driver can be compiled as a module. This patch adds missing MODULE_DEVICE_TABLE which generates correct modalias for automatic loading of this cpufreq driver when is compiled as an external module. Signed-off-by: Pali

[PATCH] arm64: dts: marvell: espressobin: Add ethernet switch aliases

2020-09-07 Thread Pali Rohár
ethernet2 and ethernet3 are used for lan ports for both Espressobin revisions (V5 and V7). Fixes: 5253cb8c00a6f ("arm64: dts: marvell: espressobin: add ethernet alias") Signed-off-by: Pali Rohár --- .../dts/marvell/armada-3720-espressobin-v7-emmc.dts | 10 -- .../boot/dts

[PATCH v3 5/5] PCI: aardvark: Move PCIe reset card code to advk_pcie_train_link()

2020-09-07 Thread Pali Rohár
it is a good idea to have this code at the same place as link training calls. This patch does not change behavior of aardvark initialization. Signed-off-by: Pali Rohár Tested-by: Marek Behún --- drivers/pci/controller/pci-aardvark.c | 64 ++- 1 file changed, 34 insertions

[PATCH v3 4/5] PCI: aardvark: Implement driver 'remove' function and allow to build it as module

2020-09-07 Thread Pali Rohár
to new kernel. Signed-off-by: Pali Rohár Reviewed-by: Marek Behún --- drivers/pci/controller/Kconfig| 2 +- drivers/pci/controller/pci-aardvark.c | 27 --- 2 files changed, 25 insertions(+), 4 deletions(-) diff --git a/drivers/pci/controller/Kconfig b/drivers/pci

Re: [PATCH v3 02/10] fs/ntfs3: Add initialization of super block

2020-09-04 Thread Pali Rohár
Hello Konstantin! On Friday 28 August 2020 07:39:30 Konstantin Komarov wrote: > + if (nls_name[0]) { > + sbi->nls = load_nls(nls_name); > + if (!sbi->nls) { > + ntfs_printk(sb, KERN_ERR "failed to load \"%s\"", > +

Re: [PATCH v3 04/10] fs/ntfs3: Add file operations and implementation

2020-09-04 Thread Pali Rohár
Hello Konstantin! On Friday 28 August 2020 07:39:32 Konstantin Komarov wrote: > +/* > + * Convert little endian utf16 to UTF-8. There is mistake in comment. This function converts UTF-16 to some NLS. It does not have to be UTF-8. > + */ > +int ntfs_utf16_to_nls(struct ntfs_sb_info *sbi, const

Re: [PATCH 1/2] phy: marvell: comphy: Convert internal SMCC firmware return codes to errno

2020-09-02 Thread Pali Rohár
On Wednesday 02 September 2020 19:20:29 Andrew Lunn wrote: > On Wed, Sep 02, 2020 at 07:05:25PM +0200, Pali Rohár wrote: > > On Wednesday 02 September 2020 19:00:10 Andrew Lunn wrote: > > > > > > + switch (ret) { > > > > > > + case SMCCC_

Re: [PATCH 1/2] phy: marvell: comphy: Convert internal SMCC firmware return codes to errno

2020-09-02 Thread Pali Rohár
On Wednesday 02 September 2020 19:00:10 Andrew Lunn wrote: > > > > + switch (ret) { > > > > + case SMCCC_RET_SUCCESS: > > > > + return 0; > > > > + case SMCCC_RET_NOT_SUPPORTED: > > > > + return -EOPNOTSUPP; > > > > + default: > > > > +

Re: [PATCH 1/2] phy: marvell: comphy: Convert internal SMCC firmware return codes to errno

2020-09-02 Thread Pali Rohár
On Wednesday 02 September 2020 18:13:28 Andrew Lunn wrote: > On Wed, Sep 02, 2020 at 04:43:43PM +0200, Pali Rohár wrote: > > Driver ->power_on and ->power_off callbacks leaks internal SMCC firmware > > return codes to phy caller. This patch converts SMCC error codes to >

[PATCH 1/2] phy: marvell: comphy: Convert internal SMCC firmware return codes to errno

2020-09-02 Thread Pali Rohár
. Note that return value is signed 32bit, but stored in unsigned long type with zero padding. Signed-off-by: Pali Rohár --- drivers/phy/marvell/phy-mvebu-a3700-comphy.c | 14 +++--- drivers/phy/marvell/phy-mvebu-cp110-comphy.c | 14 +++--- 2 files changed, 22 insertions(+), 6 del

[PATCH 2/2] PCI: aardvark: Fix initialization with old Marvell's Arm Trusted Firmware

2020-09-02 Thread Pali Rohár
wer on. Signed-off-by: Pali Rohár Fixes: 366697018c9a ("PCI: aardvark: Add PHY support") --- drivers/pci/controller/pci-aardvark.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/pci/controller/pci-aardvark.c b/drivers/pci/controller/pci-aardvark.c index

[PATCH 0/2] PCI: aardvark: Fix comphy with old ATF

2020-09-02 Thread Pali Rohár
p aardvark initialization failed. Pali Rohár (2): phy: marvell: comphy: Convert internal SMCC firmware return codes to errno PCI: aardvark: Fix initialization with old Marvell's Arm Trusted Firmware drivers/pci/controller/pci-aardvark.c| 4 +++- drivers/phy/marvell/phy-m

Re: [PATCH v2 08/10] fs/ntfs3: Add Kconfig, Makefile and doc

2020-08-23 Thread Pali Rohár
On Friday 21 August 2020 16:25:37 Konstantin Komarov wrote: > +Mount Options > += > + > +The list below describes mount options supported by NTFS3 driver in addtion > to > +generic ones. > + > +=== > + >

Re: [PATCH v2 02/10] fs/ntfs3: Add initialization of super block

2020-08-23 Thread Pali Rohár
On Friday 21 August 2020 16:25:03 Konstantin Komarov wrote: > + case Opt_nls: > + match_strlcpy(nls_name, [0], sizeof(nls_name)); > + break; > + > + /* unknown option */ > + default: > + if (!silent) >

Re: [PATCH v2 04/10] fs/ntfs3: Add file operations and implementation

2020-08-23 Thread Pali Rohár
Hello Konstantin! On Friday 21 August 2020 16:25:15 Konstantin Komarov wrote: > diff --git a/fs/ntfs3/dir.c b/fs/ntfs3/dir.c > new file mode 100644 > index ..5f1105f1283c > --- /dev/null > +++ b/fs/ntfs3/dir.c > @@ -0,0 +1,529 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + *

Re: [PATCH 0/4] mmc: sdio: Export CISTPL_VERS_1 attributes to userspace

2020-08-22 Thread Pali Rohár
Hello Ulf! I would like to remind you this SDIO patch series. Could you please look and review it? On Monday 27 July 2020 15:38:33 Pali Rohár wrote: > CISTPL_VERS_1 structure contains useful information for identification > of SDIO cards. It contains revision number according to which st

Re: [PATCH v2 0/5] PCIe aardvark controller improvements

2020-08-22 Thread Pali Rohár
On Tuesday 04 August 2020 13:57:42 Pali Rohár wrote: > Hi, > > we have some more improvements for PCIe aardvark controller (Armada 3720 > SOC - EspressoBIN and Turris MOX). > > The main improvement is that with these patches the driver can be compiled > as a module

Re: [PATCH v1 2/2] Bluetooth: sco: expose WBS packet length in socket option

2020-08-19 Thread Pali Rohár
On Wednesday 19 August 2020 11:21:00 Luiz Augusto von Dentz wrote: > Hi Pali, > > On Wed, Aug 19, 2020 at 7:37 AM Pali Rohár wrote: > > > > On Friday 14 August 2020 12:56:05 Luiz Augusto von Dentz wrote: > > > Hi Joseph, > > > > > > On Thu, Au

Re: [PATCH v1 1/2] Bluetooth: btusb: define HCI packet sizes of USB Alts

2020-08-19 Thread Pali Rohár
On Friday 14 August 2020 13:07:25 Luiz Augusto von Dentz wrote: > Hi Joseph, > > On Thu, Aug 13, 2020 at 1:42 AM Joseph Hwang wrote: > > > > It is desirable to define the HCI packet payload sizes of > > USB alternate settings so that they can be exposed to user > > space. > > > > Reviewed-by:

Re: [PATCH v1 2/2] Bluetooth: sco: expose WBS packet length in socket option

2020-08-19 Thread Pali Rohár
On Friday 14 August 2020 12:56:05 Luiz Augusto von Dentz wrote: > Hi Joseph, > > On Thu, Aug 13, 2020 at 1:42 AM Joseph Hwang wrote: > > > > It is desirable to expose the wideband speech packet length via > > a socket option to the user space so that the user space can set > > the value

Re: [PATCH] fs: NTFS read-write driver GPL implementation by Paragon Software.

2020-08-16 Thread Pali Rohár
On Friday 14 August 2020 12:29:01 Konstantin Komarov wrote: > This patch adds NTFS Read-Write driver to fs/ntfs3. > > Having decades of expertise in commercial file systems development and huge > test coverage, we at Paragon Software GmbH want to make our contribution to > the Open Source

Re: [PATCH v4 0/3] platform/x86: dell-wmi: new keys

2020-08-14 Thread Pali Rohár
On Monday 13 July 2020 09:29:12 Pali Rohár wrote: > On Thursday 09 July 2020 22:29:42 Andy Shevchenko wrote: > > On Wed, Jun 10, 2020 at 10:23 PM wrote: > > > > > > > -Original Message- > > > > From: Y Paritcher > > > > Sent: We

Re: PCI: Race condition in pci_create_sysfs_dev_files

2020-08-14 Thread Pali Rohár
Hello! I would like to remind this issue which I reported month ago. On Thursday 16 July 2020 13:04:23 Pali Rohár wrote: > Hello Bjorn! > > I see following error message in dmesg which looks like a race condition: > > sysfs: cannot create duplicate filename > '/devices/pla

Re: [PATCH] PCI: mvebu: Check if reset gpio is defined

2020-08-10 Thread Pali Rohár
On Friday 24 July 2020 15:29:30 Pali Rohár wrote: > Reset gpio is optional and it does not have to be defined for all boards. > > So in mvebu_pcie_powerdown() like in mvebu_pcie_powerup() check that reset > gpio is defined prior usage to prevent NULL pointer dereference. > > S

Re: Removal of HCI commands? (Was: Re: OCF_READ_LOCAL_CODECS is permitted only for root user)

2020-08-08 Thread Pali Rohár
On Wednesday 15 April 2020 00:56:18 Pali Rohár wrote: > On Sunday 09 February 2020 14:21:37 Pali Rohár wrote: > > On Saturday 04 January 2020 11:24:36 Pali Rohár wrote: > > > On Saturday 04 January 2020 10:44:52 Marcel Holtmann wrote: > > > > Hi Pali, > > &g

[PATCH v2 1/5] PCI: aardvark: Fix compilation on s390

2020-08-04 Thread Pali Rohár
://lore.kernel.org/r/20200628.lxtenqfl%25...@intel.com Reported-by: kernel test robot Fixes: 5169a9851da ("PCI: aardvark: Issue PERST via GPIO") Signed-off-by: Pali Rohár Reviewed-by: Marek Behún --- drivers/pci/controller/pci-aardvark.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH v2 4/5] PCI: aardvark: Implement driver 'remove' function and allow to build it as module

2020-08-04 Thread Pali Rohár
to new kernel. Signed-off-by: Pali Rohár Reviewed-by: Marek Behún --- drivers/pci/controller/Kconfig| 2 +- drivers/pci/controller/pci-aardvark.c | 27 --- 2 files changed, 25 insertions(+), 4 deletions(-) diff --git a/drivers/pci/controller/Kconfig b/drivers/pci

<    1   2   3   4   5   6   7   8   9   10   >