On 9/25/24 18:41, Shuah Khan wrote:
On 9/25/24 06:23, Javier Carrasco wrote:
These executables are missing from their corresponding gitignore files.
Add them to the lists.
Signed-off-by: Javier Carrasco
---
tools/testing/selftests/core/.gitignore | 1 +
tools/testing/selftests/net/.gitign
On 9/20/24 11:32, David Woodhouse wrote:
From: David Woodhouse
The vmclock device addresses the problem of live migration with
precision clocks. The tolerances of a hardware counter (e.g. TSC) are
typically around ±50PPM. A guest will use NTP/PTP/PPS to discipline that
counter against an extern
On 9/19/24 10:10, Paolo Abeni wrote:
On 9/14/24 18:00, David Hunter wrote:
The error message describing the required modules is inaccurate.
Currently, only "SKIP: Need act_mirred module" is printed when any of
the modules are missing. As a result, users might only include that
modul
On 9/14/24 18:00, David Hunter wrote:
The error message describing the required modules is inaccurate.
Currently, only "SKIP: Need act_mirred module" is printed when any of
the modules are missing. As a result, users might only include that
module; however, three modules are required.
Fix th
On 9/11/24 10:41, Florian Kauer wrote:
rxq contains a pointer to the device from where
the redirect happened. Currently, the BPF program
that was executed after a redirect via BPF_MAP_TYPE_DEVMAP*
does not have it set.
Add bugfix and related selftest.
Signed-off-by: Florian Kauer
---
Changes i
On 9/7/24 18:42, Justin Iurman wrote:
TL;DR This patch comes from a discussion we had with Jakub and Paolo.
This patch updates the IOAM selftests to support the new "tunsrc"
feature of IOAM. As a consequence, some changes were required. For
example, the IPv6 header must be accessed to check some
On 8/23/24 12:09, David Woodhouse wrote:
diff --git a/drivers/ptp/Kconfig b/drivers/ptp/Kconfig
index 604541dcb320..e98c9767e0ef 100644
--- a/drivers/ptp/Kconfig
+++ b/drivers/ptp/Kconfig
@@ -131,6 +131,19 @@ config PTP_1588_CLOCK_KVM
To compile this driver as a module, choose M here: t
Hi,
Just a bunch of 'nits below
On 7/24/24 19:16, David Woodhouse wrote:
diff --git a/drivers/ptp/ptp_vmclock.c b/drivers/ptp/ptp_vmclock.c
new file mode 100644
index ..9c508c21c062
--- /dev/null
+++ b/drivers/ptp/ptp_vmclock.c
[...]
+/*
+ * Multiply a 64-bit count by a 64-bit t
On Tue, 2024-06-25 at 02:33 +0900, ysk...@gmail.com wrote:
> From: Yunseong Kim
>
> In the TRACE_EVENT(qdisc_reset) NULL dereference occurred from
>
> qdisc->dev_queue->dev ->name
>
> This situation simulated from bunch of veths and Bluetooth disconnection
> and reconnection.
>
> During qdis
On Fri, 2024-06-14 at 10:19 +0200, Johannes Berg wrote:
> From: Johannes Berg
>
> The __print_symbolic() could only ever print the core
> drop reasons, since that's the way the infrastructure
> works. Now that we have __print_sym() with all the
> advantages mentioned in that commit, convert to th
On Wed, 2024-06-12 at 09:59 +0200, Jesper Dangaard Brouer wrote:
>
> On 11/06/2024 22.11, Yan Zhai wrote:
> > skb does not include enough information to find out receiving
> > sockets/services and netns/containers on packet drops. In theory
> > skb->dev tells about netns, but it can get cleared/re
'&' of a char array is not compatible with strcmp().
>
> The '&' is not necessary, remove it.
>
> Fixes: d8355240cf8fb ("net: hns3: add trace event support for PF/VF mailbox")
checkpactch in strict mode complains the hash is not 12 char long.
> Signed-off-by: Steven Rostedt (Google)
FWIW
Acked-by: Paolo Abeni
On Wed, 2024-02-28 at 17:30 +0800, Yunsheng Lin wrote:
> introduce vhost_net_test for both vhost_net tx and rx basing
> on virtio_test to test vhost_net changing in the kernel.
>
> Steps for vhost_net tx testing:
> 1. Prepare a out buf.
> 2. Kick the vhost_net to do tx processing.
> 3. Do the rece
On Wed, 2024-02-28 at 19:05 +0800, Yunjian Wang wrote:
> @@ -2661,6 +2776,54 @@ static int tun_ptr_peek_len(void *ptr)
> }
> }
>
> +static void tun_peek_xsk(struct tun_file *tfile)
> +{
> + struct xsk_buff_pool *pool;
> + u32 i, batch, budget;
> + void *frame;
> +
> + if (!
On Wed, 2024-02-28 at 19:05 +0800, Yunjian Wang wrote:
> If TUN supports AF_XDP TX zero-copy, the XDP program will enqueue
> packets to the XDP ring and wake up the vhost worker. This requires
> the vhost worker to call peek_len(), which can be used to consume
> XDP descriptors.
>
> Signed-off-by:
On Wed, 2024-02-28 at 19:05 +0800, Yunjian Wang wrote:
> Now dma mappings are used by the physical NICs. However the vNIC
> maybe do not need them. So remove non-zero 'dma_page' check in
> xp_assign_dev.
>
> Signed-off-by: Yunjian Wang
> ---
> net/xdp/xsk_buff_pool.c | 7 ---
> 1 file change
On Fri, 2024-02-09 at 18:39 +0800, Liang Chen wrote:
> On Wed, Feb 7, 2024 at 10:27 PM Paolo Abeni wrote:
> >
> > On Wed, 2024-02-07 at 10:54 +0800, Liang Chen wrote:
> > > On Tue, Feb 6, 2024 at 6:44 PM Paolo Abeni wrote:
> > > >
> > > > On
On Wed, 2024-02-07 at 10:54 +0800, Liang Chen wrote:
> On Tue, Feb 6, 2024 at 6:44 PM Paolo Abeni wrote:
> >
> > On Sat, 2024-02-03 at 10:56 +0800, Liang Chen wrote:
> > > On Sat, Feb 3, 2024 at 12:20 AM Jesper Dangaard Brouer
> > > wrote:
> > &g
On Fri, 2024-02-02 at 08:53 -0800, Breno Leitao wrote:
> From: Jakub Kicinski
>
> softnet_data->time_squeeze is sometimes used as a proxy for
> host overload or indication of scheduling problems. In practice
> this statistic is very noisy and has hard to grasp units -
> e.g. is 10 squeezes a seco
On Sat, 2024-02-03 at 10:56 +0800, Liang Chen wrote:
> On Sat, Feb 3, 2024 at 12:20 AM Jesper Dangaard Brouer
> wrote:
> > On 02/02/2024 13.11, Liang Chen wrote:
[...]
> > > @@ -1033,6 +1039,16 @@ static void put_xdp_frags(struct xdp_buff *xdp)
> > > }
> > > }
> > >
> > > +static void vi
On Fri, 2024-02-02 at 10:10 +0800, Yunsheng Lin wrote:
> On 2024/2/1 21:16, Paolo Abeni wrote:
>
> > from the __page_frag_cache_refill() allocator - which never accesses
> > the memory reserves.
>
> I am not really sure I understand the above commemt.
>
On Tue, 2024-01-30 at 19:37 +0800, Yunsheng Lin wrote:
> Currently there seems to be three page frag implementions
> which all try to allocate order 3 page, if that fails, it
> then fail back to allocate order 0 page, and each of them
> all allow order 3 page allocation to fail under certain
> cond
On Thu, 2023-11-23 at 12:12 +0100, Lukas Bulwahn wrote:
> The Kconfig parser is quite relaxed when parsing config definition lines.
> However, there are just a few config definition lines that do not follow
> the common regular expression 'config [0-9A-Z]', i.e., there are only a few
> cases where
On Wed, 2021-03-31 at 15:10 +0200, Norman Maurer wrote:
> As this missing change was most likely an oversight in the original
> commit I do think it should go into 5.12 and subsequently stable as
> well. That’s also the reason why I didn’t send a v2 and changed the
> commit message / subject for th
On Fri, 2021-03-26 at 11:22 +0100, Norman Maurer wrote:
> On 26. Mar 2021, at 10:36, Paolo Abeni wrote:
> > One thing you can do to simplifies the maintainer's life, would be post
> > a v2 with the correct tag (and ev. obsolete this patch in patchwork).
>
> I am quite
Hello,
On Thu, 2021-03-25 at 20:56 +0100, Norman Maurer wrote:
> From: Norman Maurer
>
> Support for UDP_GRO was added in the past but the implementation for
> getsockopt was missed which did lead to an error when we tried to
> retrieve the setting for UDP_GRO. This patch adds the missing switch
On Fri, 2021-03-19 at 11:43 +, Alexander Lobakin wrote:
> I'm not sure if you did it on purpose in commit aaa5d90b395a7
> ("net: use indirect call wrappers at GRO network layer").
> Was that intentional
I must admit that 2y+ later my own intentions are not so clear to me
too;)
> for the sake
Hello,
On Thu, 2021-03-18 at 18:42 +, Alexander Lobakin wrote:
> call_gro_receive() is used to limit GRO recursion, but it works only
> with callback pointers.
> There's a combined version of call_gro_receive() + INDIRECT_CALL_2()
> in , but it doesn't check for IPv6 modularity.
AFAICS, ip6_o
Hello,
On Mon, 2021-03-01 at 14:52 +, Chuck Lever wrote:
> > On Mar 1, 2021, at 8:49 AM, syzbot
> > wrote:
> >
> > Hello,
> >
> > syzbot found the following issue on:
> >
> > HEAD commit:eee7ede6 Merge branch 'bnxt_en-error-recovery-bug-fixes'
> > git tree: net
> > console outpu
On Wed, 2021-02-17 at 09:31 -0800, syzbot wrote:
> syzbot found the following issue on:
>
> HEAD commit:c48f8607 Merge branch 'PTP-for-DSA-tag_ocelot_8021q'
> git tree: net-next
> console output: https://syzkaller.appspot.com/x/log.txt?x=16525cb0d0
> kernel config: https://syzkaller
On Wed, 2021-02-17 at 07:36 -0800, syzbot wrote:
> Hello,
>
> syzbot found the following issue on:
>
> HEAD commit:773dc50d Merge branch 'Xilinx-axienet-updates'
> git tree: net-next
> console output: https://syzkaller.appspot.com/x/log.txt?x=13460822d0
> kernel config: https://syz
On Wed, 2021-02-17 at 09:30 -0800, syzbot wrote:
> syzbot found the following issue on:
>
> HEAD commit:966df6de lan743x: sync only the received area of an rx rin..
> git tree: net-next
> console output: https://syzkaller.appspot.com/x/log.txt?x=11afe082d0
> kernel config: https://s
On Thu, 2021-02-11 at 14:28 +, Alexander Lobakin wrote:
> From: Paolo Abeni on Thu, 11 Feb 2021 11:16:40 +0100
> wrote:
> > What about changing __napi_alloc_skb() to always use
> > the __napi_build_skb(), for both kmalloc and page backed skbs? That is,
> > always doi
On Wed, 2021-02-10 at 16:30 +, Alexander Lobakin wrote:
> Reuse the old and forgotten SKB_ALLOC_NAPI to add an option to get
> an skbuff_head from the NAPI cache instead of inplace allocation
> inside __alloc_skb().
> This implies that the function is called from softirq or BH-off
> context, no
On Wed, 2021-02-10 at 12:25 +, Alexander Lobakin wrote:
> Paolo Abeni on Wed, 10 Feb 2021 11:21:06 +0100 wrote:
> > Perhaps giving the device drivers the ability to opt-in on this infra
> > via a new helper - as done back then with napi_consume_skb() - would
> > m
Hello,
I'm sorry for the late feedback, I could not step-in before.
Also adding Jesper for awareness, as he introduced the bulk free
infrastructure.
On Tue, 2021-02-09 at 20:48 +, Alexander Lobakin wrote:
> @@ -231,7 +256,7 @@ struct sk_buff *__build_skb(void *data, unsigned int
> frag_size
On Fri, 2021-01-22 at 11:13 -0300, Marcelo Tosatti wrote:
> On Thu, Oct 01, 2020 at 04:47:31PM +0200, Frederic Weisbecker wrote:
> > On Wed, Jul 22, 2020 at 02:58:24PM +, Alex Belits wrote:
> > > From: Yuri Norov
> > >
> > > so we don't need to flush it.
> >
> > What guarantees that we have
On Wed, 2021-01-13 at 10:32 +, Alexander Lobakin wrote:
> Commit 9fd1ff5d2ac7 ("udp: Support UDP fraglist GRO/GSO.") actually
> not only added a support for fraglisted UDP GRO, but also tweaked
> some logics the way that non-fraglisted UDP GRO started to work for
> forwarding too.
> Commit 2e4e
On Wed, 2020-11-18 at 16:15 +0800, Tian Tao wrote:
> use kmem_cache_zalloc instead kmem_cache_alloc and memset.
>
> Signed-off-by: Tian Tao
> ---
> net/core/skbuff.c | 10 +++---
> 1 file changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/net/core/skbuff.c b/net/core/skbuff.c
> index
Hello,
On Mon, 2020-10-26 at 17:39 +0800, Menglong Dong wrote:
> The error returned from __udp_enqueue_schedule_skb is ENOMEM or ENOBUFS.
> For now, only ENOMEM is counted into UDP_MIB_RCVBUFERRORS in
> __udp_queue_rcv_skb. UDP_MIB_RCVBUFERRORS should count all of the
> failed skb because of memor
sed because this commit above was done in parallel to one here below.
>
> Fixes: 1a418cb8e888 ("mptcp: simult flow self-tests")
> Signed-off-by: Matthieu Baerts
Acked-by: Paolo Abeni
usly, the idea was to add a new line before the socket stat and not
> print "\nnetns".
>
> Fixes: b08fbf241064 ("selftests: add test-cases for MPTCP MP_JOIN")
> Fixes: 048d19d444be ("mptcp: add basic kselftest for mptcp")
> Signed-off-by: Matthieu Baerts
Acked-by: Paolo Abeni
kfree_skb_list(to_free);
> > >
> > >
> > > Per other thread we also need the state deactivated check added
> > > back.
> >
> > I guess no, because pfifo_dequeue() seems to require q->seqlock,
> > according to comments in qdisc_run(), so we c
On Wed, 2020-09-02 at 22:01 -0700, Cong Wang wrote:
> Can you test the attached one-line fix? I think we are overthinking,
> probably all
> we need here is a busy wait.
I think that will solve, but I also think that will kill NOLOCK
performances due to really increased contention.
At this point I
.@syzkaller.appspotmail.com
> Reported-by: syzbot+f612c02823acb02ff...@syzkaller.appspotmail.com
> Signed-off-by: Tonghao Zhang
Acked-by: Paolo Abeni
tcp_subflow_tcp_sock(subflow);
>
> if (!ssk->sk_socket)
Acked-by: Paolo Abeni
cking connect()")
> Signed-off-by: Matthieu Baerts
Acked-by: Paolo Abeni
On Wed, 2020-07-15 at 10:36 +0800, YueHaibing wrote:
> commit 263e1201a2c3 ("mptcp: consolidate synack processing.")
> left behind this, remove it.
>
> Signed-off-by: YueHaibing
Acked-by: Paolo Abeni
Thank you for the clean-up!
/P
On Wed, 2020-07-08 at 13:16 -0700, Cong Wang wrote:
> On Tue, Jul 7, 2020 at 7:18 AM Paolo Abeni wrote:
> > So the regression with 2 pktgen threads is still relevant. 'perf' shows
> > relevant time spent into net_tx_action() and __netif_schedule().
>
> So, touching
On Thu, 2020-07-02 at 11:08 -0700, Josh Hunt wrote:
> On 7/2/20 2:45 AM, Paolo Abeni wrote:
> > Hi all,
> >
> > On Thu, 2020-07-02 at 08:14 +0200, Jonas Bonn wrote:
> > > Hi Cong,
> > >
> > > On 01/07/2020 21:58, Cong Wang wrote:
> > > &
Hi all,
On Thu, 2020-07-02 at 08:14 +0200, Jonas Bonn wrote:
> Hi Cong,
>
> On 01/07/2020 21:58, Cong Wang wrote:
> > On Wed, Jul 1, 2020 at 9:05 AM Cong Wang wrote:
> > > On Tue, Jun 30, 2020 at 2:08 PM Josh Hunt wrote:
> > > > Do either of you know if there's been any development on a fix for
the patch the average is 354263 pkt/s or 2822 ns/pkt and with
> the patch the average is 360738 pkt/s or 2772 ns/pkt which gives an
> estimate of 50 ns per packet.
>
> [1] http://netsniff-ng.org/
>
> Changelog since v1:
> - Change ordering in the ICW (Paolo
> +#define INDIRECT_CALL_3(f, f3, f2, f1, ...) f(__VA_ARGS__)
> +#define INDIRECT_CALL_4(f, f4, f3, f2, f1, ...) f(__VA_ARGS__)
> #define INDIRECT_CALLABLE_DECLARE(f)
> #define INDIRECT_CALLABLE_SCOPE static
> #endif
Acked-by: Paolo Abeni
On Mon, 2020-06-22 at 12:26 -0700, Brian Vazquez wrote:
>
>
> On Mon, Jun 22, 2020 at 11:00 AM Paolo Abeni wrote:
> > On Mon, 2020-06-22 at 09:25 -0700, Brian Vazquez wrote:
> > >
> > > Hi Paolo
> > > On Mon, Jun 22, 2020 at 3:13 AM Paolo Abeni wrote:
On Mon, 2020-06-22 at 09:25 -0700, Brian Vazquez wrote:
>
> Hi Paolo
> On Mon, Jun 22, 2020 at 3:13 AM Paolo Abeni wrote:
> > Hi,
> >
> > On Fri, 2020-06-19 at 20:14 -0700, Brian Vazquez wrote:
> > > @@ -111,11 +111,13 @@ struct dst_entry *fib6_rule_lookup(s
Hi,
On Fri, 2020-06-19 at 20:14 -0700, Brian Vazquez wrote:
> @@ -111,11 +111,13 @@ struct dst_entry *fib6_rule_lookup(struct net *net,
> struct flowi6 *fl6,
> } else {
> struct rt6_info *rt;
>
> - rt = lookup(net, net->ipv6.fib6_local_tbl, fl6, skb, flags);
> +
https://syzkaller.appspot.com/x/repro.syz?x=141034ba10
> C reproducer: https://syzkaller.appspot.com/x/repro.c?x=119cd01610
>
> The bug was bisected to:
>
> commit 263e1201a2c324b60b15ecda5de9ebf1e7293e31
> Author: Paolo Abeni
> Date: Thu Apr 30 13:01:51 2020
On Wed, 2019-10-09 at 08:46 +0200, Jonas Bonn wrote:
> Hi,
>
> The lockless pfifo_fast qdisc has an issue with packets getting stuck in
> the queue. What appears to happen is:
>
> i) Thread 1 holds the 'seqlock' on the qdisc and dequeues packets.
> ii) Thread 1 dequeues the last packet in the
Hi,
On Tue, 2019-06-25 at 14:42 +0800, Zhiyuan Hou wrote:
> In ipvlan l3s mode, ingress packet is switched to slave interface and
> delivers to l4 stack. This may cause two problems:
>
> 1. When slave is in an ns different from master, the behavior of stack
> in slave ns may cause confusion
On Thu, 2019-01-10 at 09:25 +0100, Ian Kumlien wrote:
> On Thu, Jan 10, 2019 at 6:53 AM Eric Dumazet wrote:
> > On Wed, Jan 9, 2019 at 4:48 PM Ian Kumlien wrote:
> > > Hi,
> > >
> > > Just been trough ~5+ hours of bisecting and eventually actually found
> > > the culprit =)
> > >
> > > commit f
On Thu, 2019-01-10 at 01:38 +0100, Ian Kumlien wrote:
> Confirmed, sending a new mail with summary etc
>
> On Thu, Jan 10, 2019 at 1:16 AM Ian Kumlien wrote:
> > On Wed, Jan 9, 2019 at 12:17 AM Ian Kumlien wrote:
> > > On Wed, Jan 9, 2019, 00:09 Florian Fainelli >
> > [--8<---]
> >
> > > > >
Hi,
On Mon, 2018-12-17 at 12:36 +1100, Stephen Rothwell wrote:
> After merging the net-next tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
>
> In file included from net/core/dev.c:148:
> net/core/dev.c: In function 'napi_gro_complete':
> net/core/dev.c:5364:26: error:
On Sat, 2018-12-15 at 13:23 -0800, David Miller wrote:
> From: Paolo Abeni
> Date: Fri, 14 Dec 2018 11:51:56 +0100
>
> > The spectre v2 counter-measures, aka retpolines, are a source of measurable
> > overhead[1]. We can partially address that when the function pointer
some special care.
v1 -> v2:
- adapted to INDIRECT_CALL_ changes
v2 -> v3:
- fix build issue with CONFIG_IPV6=m
Signed-off-by: Paolo Abeni
---
include/net/inet_common.h | 7 +++
net/ipv4/af_inet.c| 13 +++--
net/ipv4/tcp_offload.c| 6 --
net/ipv4/udp_off
f
[2]
https://linuxplumbersconf.org/event/2/contributions/99/attachments/98/117/lpc18_paper_af_xdp_perf-v2.pdf
Paolo Abeni (4):
indirect call wrappers: helpers to speed-up indirect calls of builtin
net: use indirect call wrappers at GRO network layer
net: use indirect call wrappers at GRO tra
LL_ changes
Signed-off-by: Paolo Abeni
---
include/net/inet_common.h | 2 ++
net/core/dev.c| 15 +--
net/ipv6/ip6_offload.c| 6 +++---
3 files changed, 18 insertions(+), 5 deletions(-)
diff --git a/include/net/inet_common.h b/include/net/inet_common.h
index 3ca969cbd
This avoids another indirect call for UDP GRO. Again, the test
for the IPv6 variant is performed first.
v1 -> v2:
- adapted to INDIRECT_CALL_ changes
Signed-off-by: Paolo Abeni
---
net/ipv4/udp_offload.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/net/i
implement the boilerplate for the above schema
and will be used by the next patches.
rfc -> v1:
- use branch prediction hint, as suggested by Eric
v1 -> v2:
- list explicitly the builtin function names in INDIRECT_CALL_*(),
as suggested by Ed Cree
Suggested-by: Eric Dumazet
Signed-off-by:
Hi,
I'm sorry for the long delay, I was (and still I am) diverted by some
other duty.
On Fri, 2018-12-07 at 21:46 +, David Woodhouse wrote:
> On Fri, 2018-12-07 at 21:46 +0100, Paolo Abeni wrote:
> > > I wonder if we can declare the common case functions as 'weak&#
On Fri, 2018-12-07 at 09:46 +, David Woodhouse wrote:
> On Wed, 2018-12-05 at 19:13 +0100, Paolo Abeni wrote:
> > +/*
> > + * We can use INDIRECT_CALL_$NR for ipv6 related functions only if ipv6 is
> > + * builtin, this macro simplify dealing with indirect calls wit
Hi,
On Thu, 2018-12-06 at 22:28 -0800, David Miller wrote:
> From: David Miller
> Date: Thu, 06 Dec 2018 22:24:09 -0800 (PST)
>
> > Series applied, thanks!
>
> Erm... actually reverted. Please fix these build failures:
oops ...
I'm sorry for the late reply. I'm travelling and I will not able
On Wed, 2018-11-21 at 06:32 -0700, Jens Axboe wrote:
> I did some more investigation yesterday, and found this:
>
> commit 236222d39347e0e486010f10c1493e83dbbdfba8
> Author: Paolo Abeni
> Date: Thu Jun 29 15:55:58 2017 +0200
>
> x86/uaccess: Optimize copy_user_enhan
cffdef9288529077...@syzkaller.appspotmail.com
This should be addressed in current net-next, by commit:
commit 9c48060141bd937497774546e4bb89b8992be383
Author: Paolo Abeni
Date: Thu Nov 15 02:34:50 2018 +0100
udp: fix jump label misuse
Cheers,
Paolo
[hopefully fixed the 'mm' recipient]
On Tue, 2018-06-26 at 09:54 -0700, Kees Cook wrote:
> On Tue, Jun 26, 2018 at 2:48 AM, Paolo Abeni wrote:
> > With CONFIG_HARDENED_USERCOPY=y, perf shows ~6% of CPU time spent
> > cumulatively in __check_object_size (~4%) and __virt_a
Hi,
On Mon, 25 Jun 2018 11:21:38 -0700 Kees Cook wrote:
> On Mon, Jun 25, 2018 at 8:08 AM, Chris von Recklinghausen
> wrote:
> > Enabling HARDENED_USER_COPY causes measurable regressions in the
> > networking performances, up to 8% under UDP flood.
>
> Which function is "hot"? i.e. which copy*u
On Wed, 2018-05-23 at 11:40 -0400, Willem de Bruijn wrote:
> On Sun, May 20, 2018 at 7:13 PM, Willem de Bruijn
> wrote:
> > On Fri, May 18, 2018 at 2:59 PM, Willem de Bruijn
> > wrote:
> > > On Fri, May 18, 2018 at 2:46 PM, Willem de Bruijn
> > > wrote:
> > > > On Fri, May 18, 2018 at 2:44 PM, W
Hi,
On Sat, 2018-05-12 at 19:00 +0800, liuq...@huawei.com wrote:
> From: Keefe Liu
>
> When master device's mac has been changed, the
> commit <32c10bbfe914> "ipvlan: always use the current L2
> addr of the master" makes the IPVlan devices's mac changed
> also, but it doesn't flush the IPVlan's
On Sun, 2018-04-01 at 20:31 +0200, Anton Gary Ceph wrote:
> After a few profiling and analysis, turned out that the ethertype field
> of the packets has the following distribution:
[...]
> 0.6% don't know/no opinion
Am I the only one finding the submission date and the above info
suspicious ?
Hi,
On Fri, 2018-03-16 at 11:26 +0100, Jakob Unterwurzacher wrote:
> On 15.03.18 23:30, John Fastabend wrote:
> > > I have reproduced it using two USB network cards connected to each other.
> > > The test tool sends UDP packets containing a counter and listens on the
> > > other interface, it is
On Mon, 2018-03-05 at 00:21 -0800, syzbot wrote:
> Hello,
>
> syzbot hit the following crash on upstream commit
> 5fbdefcf685defd8bc5a8f37b17538d25c58d77a (Fri Mar 2 21:05:20 2018 +)
> Merge branch 'parisc-4.16-1' of
> git://git.kernel.org/pub/scm/linux/kernel/git/deller/parisc-linux
>
> So
On Mon, 2018-02-19 at 13:23 +, Jon Maloy wrote:
> I don't understand this one. tipc_topsrv_stop() can only be trigged
> from a user doing rmmod(), and I double checked that this is running
> in user mode.
> How does the call chain you are reporting occur?
tipc_topsrv_stop() is called also at n
On Wed, 2018-02-07 at 09:43 +0100, Paolo Abeni wrote:
> On Tue, 2018-02-06 at 22:42 -0800, Cong Wang wrote:
> > On Tue, Feb 6, 2018 at 6:27 AM, syzbot
> > wrote:
> > > Hello,
> > >
> > > syzbot hit the following crash on net-next commit
> > >
#syz test: git://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git master
I can't reproduce the issue locally, so asking the syzbot to test the
tentive fix for me (and hoping I did not mess with the tag/format)
---
net/ipv4/netfilter/ipt_CLUSTERIP.c | 30 +++---
1 f
On Tue, 2018-02-06 at 19:00 +0100, Dmitry Vyukov wrote:
> On Tue, Feb 6, 2018 at 6:58 PM, syzbot
> wrote:
> > Hello,
> >
> > syzbot hit the following crash on net-next commit
> > 617aebe6a97efa539cc4b8a52adccd89596e6be0 (Sun Feb 4 00:25:42 2018 +)
> > Merge tag 'usercopy-v4.16-rc1' of
> > git
On Tue, 2018-02-06 at 22:42 -0800, Cong Wang wrote:
> On Tue, Feb 6, 2018 at 6:27 AM, syzbot
> wrote:
> > Hello,
> >
> > syzbot hit the following crash on net-next commit
> > 617aebe6a97efa539cc4b8a52adccd89596e6be0 (Sun Feb 4 00:25:42 2018 +)
> > Merge tag 'usercopy-v4.16-rc1' of
> > git://g
On Wed, 2018-01-24 at 10:05 -0500, David Miller wrote:
> From: Paolo Abeni
> Date: Wed, 24 Jan 2018 15:54:05 +0100
>
> > Niklas suggested a possible relation with CONFIG_IRQ_TIME_ACCOUNTING=y
> > and indeed he was right.
> >
> > The patched kernel under test h
On Tue, 2018-01-23 at 09:42 -0800, Linus Torvalds wrote:
> On Tue, Jan 23, 2018 at 8:57 AM, Paolo Abeni wrote:
> >
> > > Or is it that the workqueue execution is simply not yielding for some
> > > reason?
> >
> > It's like that.
> >
> >
On Tue, 2018-01-23 at 11:22 -0500, David Miller wrote:
> From: Paolo Abeni
> Date: Tue, 23 Jan 2018 11:13:52 +0100
>
> > Hi,
> >
> > On Fri, 2018-01-19 at 16:46 +0100, Frederic Weisbecker wrote:
> >> As per Linus suggestion, this take doesn't limi
Hi,
On Fri, 2018-01-19 at 16:46 +0100, Frederic Weisbecker wrote:
> As per Linus suggestion, this take doesn't limit the number of occurences
> per jiffy anymore but instead defers a vector to workqueues as soon as
> it gets re-enqueued on IRQ tail.
>
> No tunable here, so testing should be easie
afonov
> Cc: Eric Dumazet
> Cc: Linus Torvalds
> Cc: Peter Zijlstra
> Cc: Andrew Morton
> Cc: David Miller
> Cc: Hannes Frederic Sowa
> Cc: Ingo Molnar
> Cc: Levin Alexander
> Cc: Paolo Abeni
> Cc: Paul E. McKenney
> Cc: Radu Rendec
> Cc: Rik v
On Tue, 2017-10-10 at 21:02 -0700, Paul E. McKenney wrote:
> Linus and Ingo will ask me how users decide how they should set that
> additional build flag. Especially given that if there is code that
> requires non-strict checking, isn't everyone required to set up non-strict
> checking to avoid fa
On Fri, 2017-10-06 at 09:34 -0700, Paul E. McKenney wrote:
> On Fri, Oct 06, 2017 at 05:10:09PM +0200, Paolo Abeni wrote:
> > Hi,
> >
> > On Fri, 2017-10-06 at 06:34 -0700, Paul E. McKenney wrote:
> > > On Fri, Oct 06, 2017 at 02:57:45PM +0200, Paolo Abeni wrote:
&g
Hi,
On Fri, 2017-10-06 at 07:37 -0700, Eric Dumazet wrote:
> On Fri, 2017-10-06 at 14:57 +0200, Paolo Abeni wrote:
> > Enabling CONFIG_RCU_NOREF_DEBUG gives the following splat when
> > processing tcp packets:
> >
> >to-be-untracked noref entity 942c
Hi,
On Fri, 2017-10-06 at 06:34 -0700, Paul E. McKenney wrote:
> On Fri, Oct 06, 2017 at 02:57:45PM +0200, Paolo Abeni wrote:
> > The networking subsystem is currently using some kind of long-lived
> > RCU-protected, references to avoid the overhead of full book-keeping.
> >
We can now ensure noref dsts do no escape the relevant RCU
section. This does not introduce any functional changes, it adds
the relevant debug code enabled by CONFIG_RCU_NOREF_DEBUG.
Signed-off-by: Paolo Abeni
---
include/linux/skbuff.h | 1 +
include/net/dst.h | 5 +
2 files changed
Fix it by adding the explicit drop in tcp_queue_rcv() and moving
the current skb_dst_drop() just before the other enqueuing
operation, do avoid unneeded double skb_dst_drop() for some
path.
The leak itself is not harmful, because the tcp recvmsg() code
should not access such info.
Signed-off-by: Pa
ps the unneeded lock.
Signed-off-by: Paolo Abeni
---
net/ipv4/route.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/net/ipv4/route.c b/net/ipv4/route.c
index 94d4cd2d5ea4..5a6ca1f16d3f 100644
--- a/net/ipv4/route.c
+++ b/net/ipv4/route.c
@@ -2069,14 +2069,9
different places (e.g. noref dst on skb_clone()).
To keep the patch/implementation simple RCU_NOREF_DEBUG depends
on PREEMPT_RCU=n in Kconfig.
Signed-off-by: Paolo Abeni
---
include/linux/rcupdate.h | 11 ++
kernel/rcu/Kconfig.debug | 15
kernel/rcu/Makefile | 1 +
kernel/rcu
usage in the networking
stack.
Patch 3 and 4 are bugfixes for small buglet found running this infrastructure
on basic scenarios.
Paolo Abeni (4):
rcu: introduce noref debug
net: use RCU noref infrastructure to track dst noref
ipv4: drop unneeded and misleading RCU lock in ip_route_input_
On Thu, 2017-09-21 at 18:37 -0700, David Miller wrote:
> From: Stephen Rothwell
> Date: Fri, 22 Sep 2017 11:03:55 +1000
>
> > After merging the net-next tree, today's linux-next build (arm
> > multi_v7_defconfig) failed like this:
> >
> > net/ipv4/fib_frontend.c: In function 'fib_validate_source
1 - 100 of 140 matches
Mail list logo
