egards,
Parav Pandit
> -Original Message-
> From: linux-kernel-ow...@vger.kernel.org ow...@vger.kernel.org> On Behalf Of Parav Pandit
> Sent: Wednesday, August 14, 2019 9:51 PM
> To: Alex Williamson
> Cc: Cornelia Huck ; Kirti Wankhede
> ; k...@vger.kernel.org; linux-
> -Original Message-
> From: Alex Williamson
> Sent: Wednesday, August 14, 2019 8:28 PM
> To: Parav Pandit
> Cc: Cornelia Huck ; Kirti Wankhede
> ; k...@vger.kernel.org; linux-
> ker...@vger.kernel.org; c...@nvidia.com; Jiri Pirko ;
> net...@vger.kernel.org
&g
> -Original Message-
> From: Cornelia Huck
> Sent: Wednesday, August 14, 2019 6:39 PM
> To: Parav Pandit
> Cc: Alex Williamson ; Kirti Wankhede
> ; k...@vger.kernel.org; linux-
> ker...@vger.kernel.org; c...@nvidia.com; Jiri Pirko ;
> net...@vger.kernel.org
&g
+ Jiri, + netdev
To get perspective on the ndo->phys_port_name for the representor netdev of
mdev.
Hi Cornelia,
> -Original Message-
> From: Cornelia Huck
> Sent: Wednesday, August 14, 2019 1:32 PM
> To: Parav Pandit
> Cc: Alex Williamson ; Kirti Wankhede
> ;
> -Original Message-
> From: Alex Williamson
> Sent: Tuesday, August 13, 2019 10:42 PM
> To: Parav Pandit
> Cc: Kirti Wankhede ; k...@vger.kernel.org; linux-
> ker...@vger.kernel.org; coh...@redhat.com; c...@nvidia.com
> Subject: Re: [PATCH v2 0/2] Simplify mtty
Hi Christoph, Greg,
> -Original Message-
> From: Greg Kroah-Hartman
> Sent: Tuesday, August 13, 2019 11:10 PM
> To: Christoph Hellwig ; Parav Pandit
>
> Cc: Kirti Wankhede ; Alex Williamson
> ; k...@vger.kernel.org; linux-
> ker...@vger.kernel.org; coh...@red
> -Original Message-
> From: Alex Williamson
> Sent: Tuesday, August 13, 2019 8:23 PM
> To: Parav Pandit
> Cc: Kirti Wankhede ; k...@vger.kernel.org; linux-
> ker...@vger.kernel.org; coh...@redhat.com; c...@nvidia.com
> Subject: Re: [PATCH v2 0/2] Simplify mtty
Hi Alex,
> -Original Message-
> From: Alex Williamson
> Sent: Friday, August 9, 2019 4:33 AM
> To: Parav Pandit
> Cc: k...@vger.kernel.org; kwankh...@nvidia.com; linux-
> ker...@vger.kernel.org; coh...@redhat.com; c...@nvidia.com
> Subject: Re: [PATCH v2 0/2]
> -Original Message-
> From: Kirti Wankhede
> Sent: Monday, August 12, 2019 5:06 PM
> To: Alex Williamson ; Parav Pandit
>
> Cc: k...@vger.kernel.org; linux-kernel@vger.kernel.org; coh...@redhat.com;
> c...@nvidia.com
> Subject: Re: [PATCH v2 0/2] Simplify m
, Since no production driver uses mdev_uuid(), simplifies and
removes redandant mdev_uuid() exported symbol.
---
Changelog:
v1->v2:
- Corrected email of Kirti
- Updated cover letter commit log to address comment from Cornelia
- Added Reviewed-by tag
v0->v1:
- Updated commit log
Parav Pan
-by: Parav Pandit
---
Changelog:
v0->v1:
- Updated commit log to address comments from Cornelia
---
drivers/vfio/mdev/mdev_core.c | 6 --
include/linux/mdev.h | 1 -
2 files changed, 7 deletions(-)
diff --git a/drivers/vfio/mdev/mdev_core.c b/drivers/vfio/mdev/mdev_core.c
in
de to use mdev_state and remove unused helper
function with that.
Reviewed-by: Cornelia Huck
Signed-off-by: Parav Pandit
---
samples/vfio-mdev/mtty.c | 39 ---
1 file changed, 8 insertions(+), 31 deletions(-)
diff --git a/samples/vfio-mdev/mtty.c b/samples/vfio-md
> -Original Message-
> From: Cornelia Huck
> Sent: Thursday, August 8, 2019 2:00 PM
> To: Parav Pandit
> Cc: k...@vger.kernel.org; wankh...@nvidia.com; linux-
> ker...@vger.kernel.org; alex.william...@redhat.com; c...@nvidia.com
> Subject: Re: [PATCH v1 2/2] vfio
> -Original Message-
> From: Cornelia Huck
> Sent: Wednesday, August 7, 2019 2:58 PM
> To: Parav Pandit
> Cc: k...@vger.kernel.org; wankh...@nvidia.com; linux-
> ker...@vger.kernel.org; alex.william...@redhat.com; c...@nvidia.com
> Subject: Re: [PATCH v1 2/2] vfio
de to use mdev_state and remove unused helper
function with that.
Reviewed-by: Cornelia Huck
Signed-off-by: Parav Pandit
---
samples/vfio-mdev/mtty.c | 39 ---
1 file changed, 8 insertions(+), 31 deletions(-)
diff --git a/samples/vfio-mdev/mtty.c b/samples/vfio-md
There is no single production driver who is interested in mdev device
uuid. Currently UUID is mainly used to derive a device name.
Additionally mdev device name is already available using core kernel
API dev_name().
Hence removed unused exported symbol.
Signed-off-by: Parav Pandit
---
Changelog
, Since no production driver uses mdev_uuid() and mdev's name
(derived from UUID) is already available using core kernel dev_name(),
this patch simplifies and removes redandant mdev_uuid() exported symbol.
Parav Pandit (2):
vfio-mdev/mtty: Simplify interrupt generation
vfio/mdev: Removed unused
> -Original Message-
> From: Cornelia Huck
> Sent: Tuesday, August 6, 2019 1:59 PM
> To: Parav Pandit
> Cc: k...@vger.kernel.org; wankh...@nvidia.com; linux-
> ker...@vger.kernel.org; alex.william...@redhat.com; c...@nvidia.com
> Subject: Re: [PATCH 2/2] vfio
+1413,7 @@ static int esw_vport_egress_config(struct mlx5_eswitch
> *esw,
>
> static bool element_type_supported(struct mlx5_eswitch *esw, int type)
> {
> - struct mlx5_core_dev *dev = esw->dev = esw->dev;
> + const struct mlx5_core_dev *dev = esw->dev;
>
> switch (type) {
> case SCHEDULING_CONTEXT_ELEMENT_TYPE_TSAR:
> --
> 2.20.1
>
Reviewed-by: Parav Pandit
> -Original Message-
> From: linux-rdma-ow...@vger.kernel.org ow...@vger.kernel.org> On Behalf Of Colin King
> Sent: Friday, August 2, 2019 3:52 PM
> To: Saeed Mahameed ; Leon Romanovsky
> ; David S . Miller ;
> net...@vger.kernel.org; linux-r...@vger.kernel.org
> Cc:
, Since no production driver uses mdev_uuid(), and mdev's name
is already available using core kernel dev_name(), simplifies and removes
redandant mdev_uuid() exported symbol.
Parav Pandit (2):
vfio-mdev/mtty: Simplify interrupt generation
vfio/mdev: Removed unused and redundant API for mdev name
There is no single production driver who is interested in mdev device
name.
Additionally mdev device name is already available using core kernel
API dev_name().
Hence removed unused exported symbol.
Signed-off-by: Parav Pandit
---
drivers/vfio/mdev/mdev_core.c | 6 --
include/linux/mdev.h
de to use mdev_state and remove unused helper
function with that.
Signed-off-by: Parav Pandit
---
samples/vfio-mdev/mtty.c | 39 ---
1 file changed, 8 insertions(+), 31 deletions(-)
diff --git a/samples/vfio-mdev/mtty.c b/samples/vfio-mdev/mtty.c
index 92e
> -Original Message-
> From: linux-kernel-ow...@vger.kernel.org ow...@vger.kernel.org> On Behalf Of Parav Pandit
> Sent: Monday, July 29, 2019 10:55 AM
> To: Jia-Ju Bai ; l...@kernel.org;
> dledf...@redhat.com; j...@ziepe.ca
> Cc: linux-r...@vger.kernel.org; linux-k
tself so when GID is NULL, gid->raw is NULL too.
One way to suppress the static checker warning/error is below patch.
Will let Leon review it.
> I do not know how to correctly fix this bug, so I only report it.
>
>
> Best wishes,
> Jia-Ju Bai
From 30e055dba77e595bf88aebd3a9c
_event_send(n, NULL);
> ret = -ENODATA;
> - } else {
> - memcpy(dev_addr->dst_dev_addr, n->ha, MAX_ADDR_LEN);
> }
>
> neigh_release(n);
> --
> 2.20.1
>
Reviewed-by: Parav Pandit
A sample trace such as below in commit message would be good to have
> -Original Message-
> From: linux-kernel-ow...@vger.kernel.org ow...@vger.kernel.org> On Behalf Of Alex Williamson
> Sent: Tuesday, July 2, 2019 11:12 AM
> To: Kirti Wankhede
> Cc: coh...@redhat.com; k...@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v2] mdev:
> -Original Message-
> From: Alex Williamson
> Sent: Tuesday, June 11, 2019 11:25 PM
> To: Parav Pandit
> Cc: Cornelia Huck ; k...@vger.kernel.org; linux-
> ker...@vger.kernel.org; kwankh...@nvidia.com; c...@nvidia.com
> Subject: Re: [PATCHv6 3/3] vfio/mdev: Sync
Hi Alex,
> -Original Message-
> From: Cornelia Huck
> Sent: Tuesday, June 4, 2019 11:18 AM
> To: Parav Pandit
> Cc: k...@vger.kernel.org; linux-kernel@vger.kernel.org;
> kwankh...@nvidia.com; alex.william...@redhat.com; c...@nvidia.com
> Subject: Re: [PATCHv6 3/3] v
amed remove helped to mdev_device_remove_common().
- Rebased for uuid/guid change
Parav Pandit (3):
vfio/mdev: Improve the create/remove sequence
vfio/mdev: Avoid creating sysfs remove file on stale device removal
vfio/mdev: Synchronize device create/remove with parent removal
drivers/vfi
: kernfs_fop_write+0x113/0x1a0
kernel: vfs_write+0xad/0x1b0
kernel: ksys_write+0x5a/0xe0
kernel: do_syscall_64+0x5a/0x210
kernel: entry_SYSCALL_64_after_hwframe+0x49/0xbe
Reviewed-by: Cornelia Huck
Signed-off-by: Parav Pandit
---
drivers/vfio/mdev/mdev_sysfs.c | 4 +---
1 file changed, 1
;] entry_SYSCALL_64_after_hwframe+0x49/0xbe
[<0>] 0x
This prepares the code to eliminate calling device_create_file() in
subsequent patch.
Reviewed-by: Cornelia Huck
Signed-off-by: Parav Pandit
---
drivers/vfio/mdev/mdev_core.c| 94 +---
drivers/vf
avoid
acquiring unreg_sem of the parent.
Fixes: 7b96953bc640 ("vfio: Mediated device Core driver")
Signed-off-by: Parav Pandit
---
drivers/vfio/mdev/mdev_core.c| 71
drivers/vfio/mdev/mdev_private.h | 2 +
2 files changed, 55 insertions(+), 18 deletion
> -Original Message-
> From: Cornelia Huck
> Sent: Monday, June 3, 2019 11:13 PM
> To: Parav Pandit
> Cc: k...@vger.kernel.org; linux-kernel@vger.kernel.org;
> kwankh...@nvidia.com; alex.william...@redhat.com; c...@nvidia.com
> Subject: Re: [PATCHv5 3/3] vfio/mde
;] entry_SYSCALL_64_after_hwframe+0x49/0xbe
[<0>] 0x
This prepares the code to eliminate calling device_create_file() in
subsequent patch.
Reviewed-by: Cornelia Huck
Signed-off-by: Parav Pandit
---
drivers/vfio/mdev/mdev_core.c| 94 +---
drivers/vf
: kernfs_fop_write+0x113/0x1a0
kernel: vfs_write+0xad/0x1b0
kernel: ksys_write+0x5a/0xe0
kernel: do_syscall_64+0x5a/0x210
kernel: entry_SYSCALL_64_after_hwframe+0x49/0xbe
Reviewed-by: Cornelia Huck
Signed-off-by: Parav Pandit
---
drivers/vfio/mdev/mdev_sysfs.c | 4 +---
1 file changed, 1
atch to smaller refactor and fixes patch
- Following coding style commenting format
- Fixed accidental delete of mutex_lock in mdev_unregister_device
- Renamed remove helped to mdev_device_remove_common().
- Rebased for uuid/guid change
Parav Pandit (3):
vfio/mdev: Improve the create/remove seque
uiring unreg_sem of the parent.
Fixes: 7b96953bc640 ("vfio: Mediated device Core driver")
Signed-off-by: Parav Pandit
---
drivers/vfio/mdev/mdev_core.c| 60
drivers/vfio/mdev/mdev_private.h | 2 ++
2 files changed, 48 insertions(+), 14 deletion
Hi Alex,
> -Original Message-
> From: Alex Williamson
> Sent: Wednesday, May 29, 2019 8:27 PM
[..]
> >
> > diff --git a/drivers/vfio/mdev/mdev_core.c
> > b/drivers/vfio/mdev/mdev_core.c index 0bef0cae1d4b..c5401a8c6843
> > 100644
> > --- a/drivers/vfio/mdev/mdev_core.c
> > +++
Hi Alex, Cornelia,
> -Original Message-
> From: Cornelia Huck
> Sent: Wednesday, May 22, 2019 3:25 PM
> To: Parav Pandit
> Cc: k...@vger.kernel.org; linux-kernel@vger.kernel.org;
> kwankh...@nvidia.com; alex.william...@redhat.com; c...@nvidia.com
> Subject: Re: [P
: kernfs_fop_write+0x113/0x1a0
kernel: vfs_write+0xad/0x1b0
kernel: ksys_write+0x5a/0xe0
kernel: do_syscall_64+0x5a/0x210
kernel: entry_SYSCALL_64_after_hwframe+0x49/0xbe
Signed-off-by: Parav Pandit
---
drivers/vfio/mdev/mdev_sysfs.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff
_SYSCALL_64_after_hwframe+0x49/0xbe
[<0>] 0xffff
This prepares the code to eliminate calling device_create_file() in
subsequent patch.
Signed-off-by: Parav Pandit
---
drivers/vfio/mdev/mdev_core.c| 94 +---
drivers/vfio/mdev/mdev_private.h |
coding style commenting format
- Fixed accidental delete of mutex_lock in mdev_unregister_device
- Renamed remove helped to mdev_device_remove_common().
- Rebased for uuid/guid change
Parav Pandit (3):
vfio/mdev: Improve the create/remove sequence
vfio/mdev: Avoid creating sysfs remove file on
uiring unreg_sem of the parent.
Fixes: 7b96953bc640 ("vfio: Mediated device Core driver")
Signed-off-by: Parav Pandit
---
drivers/vfio/mdev/mdev_core.c| 61
drivers/vfio/mdev/mdev_private.h | 2 ++
2 files changed, 49 insertions(+), 14 deletion
Hi Alex,
I was on travel for last 3 days, hence the slow response.
Started working now. Please see inline response below.
> -Original Message-
> From: Alex Williamson
> Sent: Tuesday, May 21, 2019 3:42 AM
> To: Parav Pandit
> Cc: Cornelia Huck ; k...@vger.kernel.or
Hi Alex, Cornelia,
> -Original Message-
> From: linux-kernel-ow...@vger.kernel.org ow...@vger.kernel.org> On Behalf Of Parav Pandit
> Sent: Thursday, May 16, 2019 6:31 PM
> To: k...@vger.kernel.org; linux-kernel@vger.kernel.org; coh...@redhat.com;
> kwankh...@nvidia
> -Original Message-
> From: Cornelia Huck
> Sent: Monday, May 20, 2019 6:29 AM
> To: Parav Pandit
> Cc: k...@vger.kernel.org; linux-kernel@vger.kernel.org;
> kwankh...@nvidia.com; alex.william...@redhat.com; c...@nvidia.com
> Subject: Re: [PATCHv3 3/3] vfio/mde
Hi Cornelia,
> -Original Message-
> From: Cornelia Huck
> Sent: Friday, May 17, 2019 6:22 AM
> To: Parav Pandit
> Cc: k...@vger.kernel.org; linux-kernel@vger.kernel.org;
> kwankh...@nvidia.com; alex.william...@redhat.com; c...@nvidia.com
> Subject: Re: [P
_SYSCALL_64_after_hwframe+0x49/0xbe
[<0>] 0xffff
This prepares the code to eliminate calling device_create_file() in
subsquent patch.
Signed-off-by: Parav Pandit
---
drivers/vfio/mdev/mdev_core.c| 94 +---
drivers/vfio/mdev/mdev_private.h |
: kernfs_fop_write+0x113/0x1a0
kernel: vfs_write+0xad/0x1b0
kernel: ksys_write+0x5a/0xe0
kernel: do_syscall_64+0x5a/0x210
kernel: entry_SYSCALL_64_after_hwframe+0x49/0xbe
Signed-off-by: Parav Pandit
---
drivers/vfio/mdev/mdev_sysfs.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff
xes patch
- Following coding style commenting format
- Fixed accidental delete of mutex_lock in mdev_unregister_device
- Renamed remove helped to mdev_device_remove_common().
- Rebased for uuid/guid change
Parav Pandit (3):
vfio/mdev: Improve the create/remove sequence
vfio/mdev: Avoid creat
finish.
While removing mdev devices during parent unregistration, there isn't
need to acquire refcount of parent device, hence code is restructured
using mdev_device_remove_common() to avoid it.
Fixes: 7b96953bc640 ("vfio: Mediated device Core driver")
Signed-off-by: Parav Pandit
---
d
> -Original Message-
> From: Alex Williamson
> Sent: Tuesday, May 14, 2019 5:20 PM
> To: Parav Pandit
> Cc: Cornelia Huck ; k...@vger.kernel.org; linux-
> ker...@vger.kernel.org; kwankh...@nvidia.com; c...@nvidia.com; Tony
> Krowiak ; Pierre Morel ;
> Ha
Hi Alex, Cornelia,
> -Original Message-
> From: linux-kernel-ow...@vger.kernel.org ow...@vger.kernel.org> On Behalf Of Parav Pandit
> Sent: Thursday, May 9, 2019 2:20 PM
> To: Cornelia Huck
> Cc: k...@vger.kernel.org; linux-kernel@vger.kernel.org;
> kwankh...@nvi
> -Original Message-
> From: Cornelia Huck
> Sent: Thursday, May 9, 2019 4:06 AM
> To: Parav Pandit
> Cc: k...@vger.kernel.org; linux-kernel@vger.kernel.org;
> kwankh...@nvidia.com; alex.william...@redhat.com; c...@nvidia.com;
> Tony Krowiak ; Pierre Morel
>
> -Original Message-
> From: Cornelia Huck
> Sent: Thursday, May 9, 2019 4:49 AM
> To: Alex Williamson
> Cc: Parav Pandit ; k...@vger.kernel.org; linux-
> ker...@vger.kernel.org; kwankh...@nvidia.com; c...@nvidia.com
> Subject: Re: [PATCHv2 10/10] vfio/mdev: Sync
> -Original Message-
> From: Cornelia Huck
> Sent: Thursday, May 9, 2019 4:18 AM
> To: Parav Pandit
> Cc: k...@vger.kernel.org; linux-kernel@vger.kernel.org;
> kwankh...@nvidia.com; alex.william...@redhat.com; c...@nvidia.com
> Subject: Re: [PATCHv2 09/10] vfio
> -Original Message-
> From: Alex Williamson
> Sent: Wednesday, May 8, 2019 9:46 PM
> To: Parav Pandit
> Cc: k...@vger.kernel.org; linux-kernel@vger.kernel.org;
> kwankh...@nvidia.com; c...@nvidia.com
> Subject: Re: [PATCHv2 10/10] vfio/mdev: Synchronize
> -Original Message-
> From: Cornelia Huck
> Sent: Wednesday, May 8, 2019 12:17 PM
> To: Parav Pandit
> Cc: k...@vger.kernel.org; linux-kernel@vger.kernel.org;
> kwankh...@nvidia.com; alex.william...@redhat.com; c...@nvidia.com
> Subject: Re: [PATCHv2 09/10] vfio
> -Original Message-
> From: Cornelia Huck
> Sent: Wednesday, May 8, 2019 12:10 PM
> To: Parav Pandit
> Cc: k...@vger.kernel.org; linux-kernel@vger.kernel.org;
> kwankh...@nvidia.com; alex.william...@redhat.com; c...@nvidia.com
> Subject: Re: [PATCHv2 08/1
> -Original Message-
> From: Alex Williamson
> Sent: Monday, May 6, 2019 5:03 PM
> To: Parav Pandit
> Cc: k...@vger.kernel.org; linux-kernel@vger.kernel.org;
> kwankh...@nvidia.com; c...@nvidia.com
> Subject: Re: [PATCHv2 00/10] vfio/mdev: Improve vfio/mdev core m
nelia Huck
Reviewed By: Kirti Wankhede
Reviewed-by: Maxim Levitsky
Signed-off-by: Parav Pandit
---
drivers/vfio/mdev/mdev_core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/vfio/mdev/mdev_core.c b/drivers/vfio/mdev/mdev_core.c
index b96fedc77ee5..1299d2e72ce2 100644
--- a/drivers
Instead of masking return error to -EBUSY, return actual error
returned by the driver.
Reviewed-by: Cornelia Huck
Reviewed-by: Maxim Levitsky
Signed-off-by: Parav Pandit
---
drivers/vfio/mdev/mdev_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/vfio/mdev
Remove unused kref from the mdev_device structure.
Fixes: 7b96953bc640 ("vfio: Mediated device Core driver")
Reviewed-by: Cornelia Huck
Reviewed By: Kirti Wankhede
Reviewed-by: Maxim Levitsky
Signed-off-by: Parav Pandit
---
drivers/vfio/mdev/mdev_core.c| 1 -
drivers
.
mdev_device_remove() is called from two paths.
1. mdev_unregister_driver()
mdev_device_remove_cb()
mdev_device_remove()
2. remove_store()
mdev_device_remove()
Fixes: 7b96953bc640 ("vfio: Mediated device Core driver")
Reviewed-by: Maxim Levitsky
Signed-off-by: Parav Pandit
--
As section 15 of Documentation/process/coding-style.rst clearly
describes that compiler will be able to optimize code.
Hence drop inline for get and put helpers for parent.
Signed-off-by: Parav Pandit
---
drivers/vfio/mdev/mdev_core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions
Signed-off-by: Parav Pandit
---
drivers/vfio/mdev/mdev_sysfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/vfio/mdev/mdev_sysfs.c b/drivers/vfio/mdev/mdev_sysfs.c
index 5193a0e0ce5a..cbf94b8165ea 100644
--- a/drivers/vfio/mdev/mdev_sysfs.c
+++ b/drivers/vfio/mdev/md
: kernfs_fop_write+0x113/0x1a0
kernel: vfs_write+0xad/0x1b0
kernel: ksys_write+0x5a/0xe0
kernel: do_syscall_64+0x5a/0x210
kernel: entry_SYSCALL_64_after_hwframe+0x49/0xbe
Signed-off-by: Parav Pandit
---
drivers/vfio/mdev/mdev_sysfs.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff
finish.
While removing mdev devices during parent unregistration, there isn't
need to acquire refcount of parent device, hence code is restructured
using mdev_device_remove_common() to avoid it.
Fixes: 7b96953bc640 ("vfio: Mediated device Core driver")
Signed-off-by: Parav Pandit
---
d
move_store+0x71/0x90 [mdev]
[<0>] kernfs_fop_write+0x113/0x1a0
[<0>] vfs_write+0xad/0x1b0
[<0>] ksys_write+0x5a/0xe0
[<0>] do_syscall_64+0x5a/0x210
[<0>] entry_SYSCALL_64_after_hwframe+0x49/0xbe
[<0>] 0x
This prepares the code to eliminate
There is no need use 'extern' for exported functions.
Acked-by: Cornelia Huck
Reviewed-by: Maxim Levitsky
Signed-off-by: Parav Pandit
---
include/linux/mdev.h | 21 ++---
1 file changed, 10 insertions(+), 11 deletions(-)
diff --git a/include/linux/mdev.h b/include/linux
coding style commenting format
- Fixed accidental delete of mutex_lock in mdev_unregister_device
- Renamed remove helped to mdev_device_remove_common().
- Rebased for uuid/guid change
Parav Pandit (10):
vfio/mdev: Avoid release parent reference during error path
vfio/mdev: Removed unuse
Hi Alex,
> -Original Message-
> From: Alex Williamson
> Sent: Friday, April 26, 2019 11:09 AM
> To: Parav Pandit
> Cc: k...@vger.kernel.org; linux-kernel@vger.kernel.org;
> kwankh...@nvidia.com; c...@nvidia.com
> Subject: Re: [PATCHv1 7/7] vfio/mdev: Fix race
> -Original Message-
> From: Alex Williamson
> Sent: Friday, April 26, 2019 10:34 AM
> To: Parav Pandit
> Cc: k...@vger.kernel.org; linux-kernel@vger.kernel.org;
> kwankh...@nvidia.com; c...@nvidia.com
> Subject: Re: [PATCHv1 7/7] vfio/mdev: Fix race conditions wi
Hi Alex,
First, sorry for my late reply.
> -Original Message-
> From: Alex Williamson
> Sent: Tuesday, April 23, 2019 2:22 PM
> To: Parav Pandit
> Cc: k...@vger.kernel.org; linux-kernel@vger.kernel.org;
> kwankh...@nvidia.com; c...@nvidia.com
> Subject: Re: [PATCHv
> -Original Message-
> From: Alex Williamson
> Sent: Thursday, April 4, 2019 3:44 PM
> To: Parav Pandit
> Cc: k...@vger.kernel.org; linux-kernel@vger.kernel.org;
> kwankh...@nvidia.com; c...@nvidia.com
> Subject: Re: [PATCHv1 7/7] vfio/mdev: Fix race conditions wi
> -Original Message-
> From: Alex Williamson
> Sent: Wednesday, April 3, 2019 4:27 PM
> To: Parav Pandit
> Cc: k...@vger.kernel.org; linux-kernel@vger.kernel.org;
> kwankh...@nvidia.com; c...@nvidia.com
> Subject: Re: [PATCHv1 7/7] vfio/mdev: Fix race condit
> -Original Message-
> From: Alex Williamson
> Sent: Tuesday, April 2, 2019 5:33 PM
> To: Parav Pandit
> Cc: Cornelia Huck ; k...@vger.kernel.org; linux-
> ker...@vger.kernel.org; kwankh...@nvidia.com; c...@nvidia.com
> Subject: Re: [PATCHv1 6/7] vfio/mdev: Fi
> -Original Message-
> From: Cornelia Huck
> Sent: Monday, April 1, 2019 12:39 PM
> To: Parav Pandit
> Cc: k...@vger.kernel.org; linux-kernel@vger.kernel.org;
> kwankh...@nvidia.com; alex.william...@redhat.com; c...@nvidia.com
> Subject: Re: [PATCHv1 6/7] vfio/md
mdev_remove_sysfs_files() should follow exact mirror sequence of a
create, similar to what is followed in error unwinding path of
mdev_create_sysfs_files().
Fixes: 6a62c1dfb5c7 ("vfio/mdev: Re-order sysfs attribute creation")
Reviewed-by: Maxim Levitsky
Signed-off-by: Parav Pandit
--
removal while parent is being access by create() and remove callbacks.
mdev_device_remove() is refactored to not block on srcu when device is
removed as part of parent removal.
Fixes: 7b96953bc640 ("vfio: Mediated device Core driver")
Signed-off-by: Parav Pandit
---
drivers/vfio/mdev/m
device removal using generic child
iterator, mdev check is already done using dev_is_mdev().
Hence, remove the unnecessary loop in mdev_device_remove().
Fixes: 7b96953bc640 ("vfio: Mediated device Core driver")
Reviewed-by: Maxim Levitsky
Signed-off-by: Parav Pandit
---
drivers
i Wankhede
Reviewed-by: Maxim Levitsky
Signed-off-by: Parav Pandit
---
drivers/vfio/mdev/mdev_core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/vfio/mdev/mdev_core.c b/drivers/vfio/mdev/mdev_core.c
index b96fedc..1299d2e 100644
--- a/drivers/vfio/mdev/mdev_core.c
+++ b/drivers
Instead of masking return error to -EBUSY, return actual error
returned by the driver.
Reviewed-by: Maxim Levitsky
Signed-off-by: Parav Pandit
---
drivers/vfio/mdev/mdev_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/vfio/mdev/mdev_core.c b/drivers/vfio/mdev
Remove unused kref from the mdev_device structure.
Fixes: 7b96953bc640 ("vfio: Mediated device Core driver")
Reviewed By: Kirti Wankhede
Reviewed-by: Maxim Levitsky
Signed-off-by: Parav Pandit
---
drivers/vfio/mdev/mdev_core.c| 1 -
drivers/vfio/mdev/mdev_private.h | 1 -
2 fil
There is no need use 'extern' for exported functions.
Reviewed-by: Maxim Levitsky
Signed-off-by: Parav Pandit
---
include/linux/mdev.h | 21 ++---
1 file changed, 10 insertions(+), 11 deletions(-)
diff --git a/include/linux/mdev.h b/include/linux/mdev.h
index d7aee90..4924d80
ock in mdev_unregister_device
- Renamed remove helped to mdev_device_remove_common().
- Rebased for uuid/guid change
Parav Pandit (7):
vfio/mdev: Avoid release parent reference during error path
vfio/mdev: Removed unused kref
vfio/mdev: Drop redundant extern for exported symbols
vfio/mdev: Avoid mask
Hi Alex,
> -Original Message-
> From: Alex Williamson
> Sent: Tuesday, March 26, 2019 10:27 AM
> To: Kirti Wankhede
> Cc: Parav Pandit ; k...@vger.kernel.org; linux-
> ker...@vger.kernel.org; Neo Jia
> Subject: Re: [PATCH 8/8] vfio/mdev: Improve the create/remove
> -Original Message-
> From: Kirti Wankhede
> Sent: Tuesday, March 26, 2019 2:06 AM
> To: Parav Pandit ; k...@vger.kernel.org; linux-
> ker...@vger.kernel.org; alex.william...@redhat.com
> Cc: Neo Jia
> Subject: Re: [PATCH 8/8] vfio/mdev: Improve the c
> -Original Message-
> From: linux-kernel-ow...@vger.kernel.org ow...@vger.kernel.org> On Behalf Of Parav Pandit
> Sent: Monday, March 25, 2019 10:19 PM
> To: Alex Williamson
> Cc: k...@vger.kernel.org; linux-kernel@vger.kernel.org;
> kwankh...@nvidia.com
>
> -Original Message-
> From: Alex Williamson
> Sent: Monday, March 25, 2019 9:17 PM
> To: Parav Pandit
> Cc: k...@vger.kernel.org; linux-kernel@vger.kernel.org;
> kwankh...@nvidia.com
> Subject: Re: [PATCH 8/8] vfio/mdev: Improve the create/remove sequence
>
> -Original Message-
> From: Alex Williamson
> Sent: Monday, March 25, 2019 7:06 PM
> To: Parav Pandit
> Cc: k...@vger.kernel.org; linux-kernel@vger.kernel.org;
> kwankh...@nvidia.com
> Subject: Re: [PATCH 8/8] vfio/mdev: Improve the create/remove sequence
>
> -Original Message-
> From: Alex Williamson
> Sent: Monday, March 25, 2019 6:19 PM
> To: Parav Pandit
> Cc: k...@vger.kernel.org; linux-kernel@vger.kernel.org;
> kwankh...@nvidia.com
> Subject: Re: [PATCH 8/8] vfio/mdev: Improve the create/remove sequence
>
Hi Alex,
> -Original Message-
> From: Alex Williamson
> Sent: Monday, March 25, 2019 4:52 PM
> To: Parav Pandit
> Cc: Kirti Wankhede ; k...@vger.kernel.org; linux-
> ker...@vger.kernel.org
> Subject: Re: [PATCH 7/8] vfio/mdev: Fix aborting mdev child device r
> -Original Message-
> From: Maxim Levitsky
> Sent: Monday, March 25, 2019 8:24 AM
> To: Parav Pandit ; k...@vger.kernel.org; linux-
> ker...@vger.kernel.org; kwankh...@nvidia.com;
> alex.william...@redhat.com
> Subject: Re: [PATCH 8/8] vfio/mdev: Improve the c
> -Original Message-
> From: Alex Williamson
> Sent: Monday, March 25, 2019 3:50 PM
> To: Kirti Wankhede
> Cc: Parav Pandit ; k...@vger.kernel.org; linux-
> ker...@vger.kernel.org
> Subject: Re: [PATCH 7/8] vfio/mdev: Fix aborting mdev child device removal if
&g
> -Original Message-
> From: Alex Williamson
> Sent: Monday, March 25, 2019 3:21 PM
> To: Parav Pandit
> Cc: k...@vger.kernel.org; linux-kernel@vger.kernel.org;
> kwankh...@nvidia.com
> Subject: Re: [PATCH 6/8] vfio/mdev: Follow correct remove sequence
>
>
> -Original Message-
> From: Kirti Wankhede
> Sent: Monday, March 25, 2019 2:18 PM
> To: Parav Pandit ; k...@vger.kernel.org; linux-
> ker...@vger.kernel.org; alex.william...@redhat.com
> Subject: Re: [PATCH 5/8] vfio/mdev: Avoid masking error code to EBUSY
>
>
> -Original Message-
> From: Alex Williamson
> Sent: Monday, March 25, 2019 2:50 PM
> To: Kirti Wankhede
> Cc: Parav Pandit ; k...@vger.kernel.org; linux-
> ker...@vger.kernel.org
> Subject: Re: [PATCH 4/8] vfio/mdev: Drop redundant extern for exported
> sym
> -Original Message-
> From: Alex Williamson
> Sent: Monday, March 25, 2019 2:21 PM
> To: Kirti Wankhede
> Cc: Parav Pandit ; k...@vger.kernel.org; linux-
> ker...@vger.kernel.org
> Subject: Re: [PATCH 1/8] vfio/mdev: Fix to not do put_device on
> device_regi
101 - 200 of 680 matches
Mail list logo
