Re: [PATCH RFC] [media] dib0700: remove redundant else

2016-10-10 Thread Patrick Boettcher
On Mon, 10 Oct 2016 06:30:35 -0300 Mauro Carvalho Chehab wrote: > > drivers/media/usb/dvb-usb/dib0700_devices.c | 10 +++--- > > 1 file changed, 3 insertions(+), 7 deletions(-) > > > > diff --git a/drivers/media/usb/dvb-usb/dib0700_devices.c > >

Re: [PATCH RFC] [media] dib0700: remove redundant else

2016-10-10 Thread Patrick Boettcher
On Mon, 10 Oct 2016 06:30:35 -0300 Mauro Carvalho Chehab wrote: > > drivers/media/usb/dvb-usb/dib0700_devices.c | 10 +++--- > > 1 file changed, 3 insertions(+), 7 deletions(-) > > > > diff --git a/drivers/media/usb/dvb-usb/dib0700_devices.c > > b/drivers/media/usb/dvb-usb/dib0700_devices.c

Re: [PATCH 09/26] dibusb: don't do DMA on stack

2016-10-10 Thread Patrick Boettcher
dvb_usb_nec_rc_key_to_event(d, buf, event, state); > + > + if (buf[0] != 0) > + deb_info("key: %*ph\n", 5, buf); > + > + kfree(buf); > + > return 0; > } > EXPORT_SYMBOL(dibusb_rc_query); > diff --git a/drivers/media/usb/dvb-usb/dibusb.h > b/drivers/media/usb/dvb-usb/dibusb.h index 3f82163d8ab8..42e9750393e5 > 100644 --- a/drivers/media/usb/dvb-usb/dibusb.h > +++ b/drivers/media/usb/dvb-usb/dibusb.h > @@ -96,10 +96,15 @@ > #define DIBUSB_IOCTL_CMD_ENABLE_STREAM 0x01 > #define DIBUSB_IOCTL_CMD_DISABLE_STREAM 0x02 > > +/* Max transfer size done by I2C transfer functions */ > +#define MAX_XFER_SIZE 64 > + > struct dibusb_state { > struct dib_fe_xfer_ops ops; > int mt2060_present; > u8 tuner_addr; > + > + unsigned char data[MAX_XFER_SIZE]; > }; > > struct dibusb_device_state { Reviewed-By: Patrick Boettcher <patrick.boettc...@posteo.de>

Re: [PATCH 09/26] dibusb: don't do DMA on stack

2016-10-10 Thread Patrick Boettcher
> + if (buf[0] != 0) > + deb_info("key: %*ph\n", 5, buf); > + > + kfree(buf); > + > return 0; > } > EXPORT_SYMBOL(dibusb_rc_query); > diff --git a/drivers/media/usb/dvb-usb/dibusb.h > b/drivers/media/usb/dvb-usb/dibusb.h index 3f82163d8ab8..42e9750393e5 > 100644 --- a/drivers/media/usb/dvb-usb/dibusb.h > +++ b/drivers/media/usb/dvb-usb/dibusb.h > @@ -96,10 +96,15 @@ > #define DIBUSB_IOCTL_CMD_ENABLE_STREAM 0x01 > #define DIBUSB_IOCTL_CMD_DISABLE_STREAM 0x02 > > +/* Max transfer size done by I2C transfer functions */ > +#define MAX_XFER_SIZE 64 > + > struct dibusb_state { > struct dib_fe_xfer_ops ops; > int mt2060_present; > u8 tuner_addr; > + > + unsigned char data[MAX_XFER_SIZE]; > }; > > struct dibusb_device_state { Reviewed-By: Patrick Boettcher

Re: [PATCH 08/26] dib0700_core: don't use stack on I2C reads

2016-10-10 Thread Patrick Boettcher
buf, msg[i].len); > > /* write/read request */ > @@ -299,6 +319,11 @@ static int dib0700_i2c_xfer_legacy(struct > i2c_adapter *adap, break; > } > > + if (msg[i + 1].len > sizeof(st->buf)) { > + deb_info("i2c xfer buffer to small > for %d\n", > + msg[i].len); > + return -EIO; > + } > memcpy(msg[i + 1].buf, st->buf, msg[i + > 1].len); > msg[i+1].len = len; Reviewed-By: Patrick Boettcher <patrick.boettc...@posteo.de>

Re: [PATCH 02/26] cinergyT2-core: don't do DMA on stack

2016-10-10 Thread Patrick Boettcher
13 +175,13 @@ static int cinergyt2_rc_query(struct > dvb_usb_device *d, u32 *event, int *state) } > > /* hack to pass checksum on the custom field */ > - key[2] = ~key[1]; > - dvb_usb_nec_rc_key_to_event(d, key, event, state); > - if (key[0] != 0) { > + st->data[2] = ~st->data[1]; > + dvb_usb_nec_rc_key_to_event(d, st->data, event, state); > + if (st->data[0] != 0) { > if (*event != d->last_event) > st->rc_counter = 0; > > - deb_rc("key: %*ph\n", 5, key); > + deb_rc("key: %*ph\n", 5, st->data); > } > return 0; > } Reviewed-By: Patrick Boettcher <patrick.boettc...@posteo.de>

Re: [PATCH 08/26] dib0700_core: don't use stack on I2C reads

2016-10-10 Thread Patrick Boettcher
*/ > @@ -299,6 +319,11 @@ static int dib0700_i2c_xfer_legacy(struct > i2c_adapter *adap, break; > } > > + if (msg[i + 1].len > sizeof(st->buf)) { > + deb_info("i2c xfer buffer to small > for %d\n", > + msg[i].len); > + return -EIO; > + } > memcpy(msg[i + 1].buf, st->buf, msg[i + > 1].len); > msg[i+1].len = len; Reviewed-By: Patrick Boettcher

Re: [PATCH 02/26] cinergyT2-core: don't do DMA on stack

2016-10-10 Thread Patrick Boettcher
_usb_device *d, u32 *event, int *state) } > > /* hack to pass checksum on the custom field */ > - key[2] = ~key[1]; > - dvb_usb_nec_rc_key_to_event(d, key, event, state); > - if (key[0] != 0) { > + st->data[2] = ~st->data[1]; > + dvb_usb_nec_rc_key_to_event(d, st->data, event, state); > + if (st->data[0] != 0) { > if (*event != d->last_event) > st->rc_counter = 0; > > - deb_rc("key: %*ph\n", 5, key); > + deb_rc("key: %*ph\n", 5, st->data); > } > return 0; > } Reviewed-By: Patrick Boettcher

Re: [PATCH 05/26] cinergyT2-fe: don't do DMA on stack

2016-10-10 Thread Patrick Boettcher
break; > case 700: > - param.bandwidth = 7; > + param->bandwidth = 7; > break; > case 600: > - param.bandwidth = 6; > + param->bandwidth = 6; > break; > } > > - err = dvb_usb_generic_rw(state->d, > - (char *), sizeof(param), > - result, sizeof(result), 0); > + err = dvb_usb_generic_rw(state->d, state->data, > sizeof(*param), > + state->data, 2, 0); > if (err < 0) > err("cinergyt2_fe_set_frontend() Failed! err=%d\n", > err); Reviewed-By: Patrick Boettcher <patrick.boettc...@posteo.de>

Re: [PATCH 05/26] cinergyT2-fe: don't do DMA on stack

2016-10-10 Thread Patrick Boettcher
; - param.bandwidth = 7; > + param->bandwidth = 7; > break; > case 600: > - param.bandwidth = 6; > + param->bandwidth = 6; > break; > } > > - err = dvb_usb_generic_rw(state->d, > - (char *), sizeof(param), > - result, sizeof(result), 0); > + err = dvb_usb_generic_rw(state->d, state->data, > sizeof(*param), > + state->data, 2, 0); > if (err < 0) > err("cinergyt2_fe_set_frontend() Failed! err=%d\n", > err); Reviewed-By: Patrick Boettcher

Re: [PATCH 06/26] cxusb: don't do DMA on stack

2016-10-10 Thread Patrick Boettcher
nsfer size done by I2C transfer functions */ > +#define MAX_XFER_SIZE 80 > + > struct cxusb_state { > u8 gpio_write_state[3]; > struct i2c_client *i2c_client_demod; > struct i2c_client *i2c_client_tuner; > + > + unsigned char data[MAX_XFER_SIZE]; > }; > > #endif Reviewed-By: Patrick Boettcher <patrick.boettc...@posteo.de>

Re: [PATCH 07/26] dib0700: be sure that dib0700_ctrl_rd() users can do DMA

2016-10-10 Thread Patrick Boettcher
peat(d->rc_dev); > return 0; > } > > protocol = RC_TYPE_NEC; > - scancode = RC_SCANCODE_NEC(key[3-2], key[3-3]); > + scancode = RC_SCANCODE_NEC(st->buf[3 - 2], st->buf[3 > - 3]); toggle = 0; > break; > > default: > /* RC-5 protocol changes toggle bit on new keypress > */ protocol = RC_TYPE_RC5; > - scancode = RC_SCANCODE_RC5(key[3-2], key[3-3]); > - toggle = key[3-1]; > + scancode = RC_SCANCODE_RC5(st->buf[3 - 2], st->buf[3 > - 3]); > + toggle = st->buf[3 - 1]; > break; > } > Reviewed-By: Patrick Boettcher <patrick.boettc...@posteo.de>

Re: [PATCH 06/26] cxusb: don't do DMA on stack

2016-10-10 Thread Patrick Boettcher
..18acda19527a > 100644 --- a/drivers/media/usb/dvb-usb/cxusb.h > +++ b/drivers/media/usb/dvb-usb/cxusb.h > @@ -28,10 +28,15 @@ > #define CMD_ANALOG0x50 > #define CMD_DIGITAL 0x51 > > +/* Max transfer size done by I2C transfer functions */ > +#define MAX_XFER_SIZE 80 > + > struct cxusb_state { > u8 gpio_write_state[3]; > struct i2c_client *i2c_client_demod; > struct i2c_client *i2c_client_tuner; > + > + unsigned char data[MAX_XFER_SIZE]; > }; > > #endif Reviewed-By: Patrick Boettcher

Re: [PATCH 07/26] dib0700: be sure that dib0700_ctrl_rd() users can do DMA

2016-10-10 Thread Patrick Boettcher
} > > protocol = RC_TYPE_NEC; > - scancode = RC_SCANCODE_NEC(key[3-2], key[3-3]); > + scancode = RC_SCANCODE_NEC(st->buf[3 - 2], st->buf[3 > - 3]); toggle = 0; > break; > > default: > /* RC-5 protocol changes toggle bit on new keypress > */ protocol = RC_TYPE_RC5; > - scancode = RC_SCANCODE_RC5(key[3-2], key[3-3]); > - toggle = key[3-1]; > + scancode = RC_SCANCODE_RC5(st->buf[3 - 2], st->buf[3 > - 3]); > + toggle = st->buf[3 - 1]; > break; > } > Reviewed-By: Patrick Boettcher

Re: [PATCH 11/26] digitv: don't do DMA on stack

2016-10-10 Thread Patrick Boettcher
drivers/media/usb/dvb-usb/digitv.h index 908c09f4966b..cf104689bdff > 100644 --- a/drivers/media/usb/dvb-usb/digitv.h > +++ b/drivers/media/usb/dvb-usb/digitv.h > @@ -6,6 +6,9 @@ > > struct digitv_state { > int is_nxt6000; > + > +unsigned char sndbuf[7]; > +unsigned char rcvbuf[7]; > }; > > /* protocol (from usblogging and the SDK: Reviewed-By: Patrick Boettcher <patrick.boettc...@posteo.de>

Re: [PATCH 11/26] digitv: don't do DMA on stack

2016-10-10 Thread Patrick Boettcher
966b..cf104689bdff > 100644 --- a/drivers/media/usb/dvb-usb/digitv.h > +++ b/drivers/media/usb/dvb-usb/digitv.h > @@ -6,6 +6,9 @@ > > struct digitv_state { > int is_nxt6000; > + > +unsigned char sndbuf[7]; > +unsigned char rcvbuf[7]; > }; > > /* protocol (from usblogging and the SDK: Reviewed-By: Patrick Boettcher

Re: [PATCH 14/26] dtt200u: don't do DMA on stack

2016-10-10 Thread Patrick Boettcher
rmware = "dvb-usb-wt220u-fc03.fw", > > + .size_of_priv = sizeof(struct dtt200u_state), > + > .num_adapters = 1, > .adapter = { > { > @@ -290,6 +311,8 @@ static struct dvb_usb_device_properties > wt220u_zl0353_properties = { .usb_ctrl = CYPRESS_FX2, > .firmware = "dvb-usb-wt220u-zl0353-01.fw", > > + .size_of_priv = sizeof(struct dtt200u_state), > + > .num_adapters = 1, > .adapter = { > { > @@ -340,6 +363,8 @@ static struct dvb_usb_device_properties > wt220u_miglia_properties = { .usb_ctrl = CYPRESS_FX2, > .firmware = "dvb-usb-wt220u-miglia-01.fw", > > + .size_of_priv = sizeof(struct dtt200u_state), > + > .num_adapters = 1, > .generic_bulk_ctrl_endpoint = 0x01, > Reviewed-By: Patrick Boettcher <patrick.boettc...@posteo.de>

Re: [PATCH 14/26] dtt200u: don't do DMA on stack

2016-10-10 Thread Patrick Boettcher
.adapter = { > { > @@ -240,6 +259,8 @@ static struct dvb_usb_device_properties > wt220u_fc_properties = { .usb_ctrl = CYPRESS_FX2, > .firmware = "dvb-usb-wt220u-fc03.fw", > > + .size_of_priv = sizeof(struct dtt200u_state), > + >

Re: [PATCH 19/26] nova-t-usb2: don't do DMA on stack

2016-10-10 Thread Patrick Boettcher
deb_rc("raw key code 0x%02x, 0x%02x, 0x%02x > to c: %02x d: %02x toggle: %d\n", > +buf[1], buf[2], buf[3], custom, data, > toggle); > for (i = 0; i < > ARRAY_SIZE(rc_map_haupp_table); i++) { if

Re: [PATCH 19/26] nova-t-usb2: don't do DMA on stack

2016-10-10 Thread Patrick Boettcher
, 0x%02x > to c: %02x d: %02x toggle: %d\n", > +buf[1], buf[2], buf[3], custom, data, > toggle); > for (i = 0; i < > ARRAY_SIZE(rc_map_haupp_table); i++) { if > (rc5_data(_map_haupp_table[i]) == data && @@ -117,6 +124,7 @@ > static int nova_t_rc_query(struct dvb_usb_device *d, u32 *event, int > *state) break; } > > + kfree(buf); > return 0; > } > Reviewed-By: Patrick Boettcher

Re: [PATCH 20/26] pctv452e: don't do DMA on stack

2016-10-10 Thread Patrick Boettcher
return ret; > > if (debug > 3) { > - info("%s: read: %2d: %*ph: ", __func__, ret, 3, rx); > - for (i = 0; (i < rx[3]) && ((i+3) < > PCTV_ANSWER_LEN); i++) > - info(" %02x", rx[i+3]); > + info("%s: read: %2d: %*ph: ", __func__, ret, 3, > state->data); > + for (i = 0; (i < state->data[3]) && ((i + 3) < > PCTV_ANSWER_LEN); i++) > + info(" %02x", state->data[i + 3]); > > info("\n"); > } > > - if ((rx[3] == 9) && (rx[12] & 0x01)) { > + if ((state->data[3] == 9) && (state->data[12] & 0x01)) { > /* got a "press" event */ > - state->last_rc_key = RC_SCANCODE_RC5(rx[7], rx[6]); > + state->last_rc_key = RC_SCANCODE_RC5(state->data[7], > state->data[6]); if (debug > 2) > info("%s: cmd=0x%02x sys=0x%02x\n", > - __func__, rx[6], rx[7]); > + __func__, state->data[6], > state->data[7]); > rc_keydown(d->rc_dev, RC_TYPE_RC5, > state->last_rc_key, 0); } else if (state->last_rc_key) { Reviewed-By: Patrick Boettcher <patrick.boettc...@posteo.de>

Re: [PATCH 20/26] pctv452e: don't do DMA on stack

2016-10-10 Thread Patrick Boettcher
read: %2d: %*ph: ", __func__, ret, 3, rx); > - for (i = 0; (i < rx[3]) && ((i+3) < > PCTV_ANSWER_LEN); i++) > - info(" %02x", rx[i+3]); > + info("%s: read: %2d: %*ph: ", __func__, ret, 3, > state->data); > + for (i = 0; (i < state->data[3]) && ((i + 3) < > PCTV_ANSWER_LEN); i++) > + info(" %02x", state->data[i + 3]); > > info("\n"); > } > > - if ((rx[3] == 9) && (rx[12] & 0x01)) { > + if ((state->data[3] == 9) && (state->data[12] & 0x01)) { > /* got a "press" event */ > - state->last_rc_key = RC_SCANCODE_RC5(rx[7], rx[6]); > + state->last_rc_key = RC_SCANCODE_RC5(state->data[7], > state->data[6]); if (debug > 2) > info("%s: cmd=0x%02x sys=0x%02x\n", > - __func__, rx[6], rx[7]); > + __func__, state->data[6], > state->data[7]); > rc_keydown(d->rc_dev, RC_TYPE_RC5, > state->last_rc_key, 0); } else if (state->last_rc_key) { Reviewed-By: Patrick Boettcher

Re: [PATCH 22/26] technisat-usb2: use DMA buffers for I2C transfers

2016-10-10 Thread Patrick Boettcher
goto err; > } > > deb_i2c("status: %d, ", b[0]); > @@ -154,7 +158,9 @@ static int technisat_usb2_i2c_access(struct > usb_device *udev, > deb_i2c("\n"); > > - return 0; > +err: > + kfree(b); > + return ret; > } > > static int technisat_usb2_i2c_xfer(struct i2c_adapter *adap, struct > i2c_msg *msg, Reviewed-By: Patrick Boettcher <patrick.boettc...@posteo.de>

Re: [PATCH 22/26] technisat-usb2: use DMA buffers for I2C transfers

2016-10-10 Thread Patrick Boettcher
: %d, ", b[0]); > @@ -154,7 +158,9 @@ static int technisat_usb2_i2c_access(struct > usb_device *udev, > deb_i2c("\n"); > > - return 0; > +err: > + kfree(b); > + return ret; > } > > static int technisat_usb2_i2c_xfer(struct i2c_adapter *adap, struct > i2c_msg *msg, Reviewed-By: Patrick Boettcher

Re: RFC - unclear change in "[media] DiBxxxx: Codingstype updates"

2016-10-10 Thread Patrick Boettcher
Hi, der Herr Hofrat ;-) On Sat, 8 Oct 2016 13:57:14 + Nicholas Mc Guire wrote: > - lo6 |= (1 << 2) | 2; > - else > - lo6 |= (1 << 2) | 1; > + lo6 |= (1 << 2) | 2;//SigmaDelta and Dither > + else { > +

Re: RFC - unclear change in "[media] DiBxxxx: Codingstype updates"

2016-10-10 Thread Patrick Boettcher
Hi, der Herr Hofrat ;-) On Sat, 8 Oct 2016 13:57:14 + Nicholas Mc Guire wrote: > - lo6 |= (1 << 2) | 2; > - else > - lo6 |= (1 << 2) | 1; > + lo6 |= (1 << 2) | 2;//SigmaDelta and Dither > + else { > + if

dvb-usb stack-memory used for URB-buffers (was: Re: Problem with VMAP_STACK=y)

2016-10-05 Thread Patrick Boettcher
Hi, On Tue, 4 Oct 2016 15:26:28 +0200 (CEST) Jiri Kosina wrote: > On Tue, 4 Oct 2016, Jörg Otte wrote: > > > With kernel 4.8.0-01558-g21f54dd I get thousands of > > "dvb-usb: bulk message failed: -11 (1/0)" > > messages in the logs and the DVB adapter is not working. > > > >

dvb-usb stack-memory used for URB-buffers (was: Re: Problem with VMAP_STACK=y)

2016-10-05 Thread Patrick Boettcher
Hi, On Tue, 4 Oct 2016 15:26:28 +0200 (CEST) Jiri Kosina wrote: > On Tue, 4 Oct 2016, Jörg Otte wrote: > > > With kernel 4.8.0-01558-g21f54dd I get thousands of > > "dvb-usb: bulk message failed: -11 (1/0)" > > messages in the logs and the DVB adapter is not working. > > > > It tourned out

Re: Problem with VMAP_STACK=y

2016-10-05 Thread Patrick Boettcher
On Wed, 5 Oct 2016 09:26:29 +0200 (CEST) Jiri Kosina wrote: > On Tue, 4 Oct 2016, Jörg Otte wrote: > > > Thanks for the quick response. > > Drivers are: > > dvb_core, dvb_usb, dbv_usb_cynergyT2 > > This dbv_usb_cynergyT2 is not from Linus' tree, is it? I don't seem > to be

Re: Problem with VMAP_STACK=y

2016-10-05 Thread Patrick Boettcher
On Wed, 5 Oct 2016 09:26:29 +0200 (CEST) Jiri Kosina wrote: > On Tue, 4 Oct 2016, Jörg Otte wrote: > > > Thanks for the quick response. > > Drivers are: > > dvb_core, dvb_usb, dbv_usb_cynergyT2 > > This dbv_usb_cynergyT2 is not from Linus' tree, is it? I don't seem > to be able to find it,

Re: Kernel docs: muddying the waters a bit

2016-02-18 Thread Patrick Boettcher
On Thu, 18 Feb 2016 10:44:34 -0200 Mauro Carvalho Chehab wrote: > > > It is workable, but I guess nested tables produced a better > > > result. > > > > > > I did myself a test with nested tables with asciidoc too: > > > > > >

Re: Kernel docs: muddying the waters a bit

2016-02-18 Thread Patrick Boettcher
On Thu, 18 Feb 2016 10:44:34 -0200 Mauro Carvalho Chehab wrote: > > > It is workable, but I guess nested tables produced a better > > > result. > > > > > > I did myself a test with nested tables with asciidoc too: > > > > > >

csdio-kernel module status, if any (was: Re: char interface to sdio, chdio.c)

2015-11-03 Thread Patrick Boettcher
Hi all, Sorry for posting out-of-thread, but I don't have the original mail and thus cannot reply. If refer to this thread: https://lkml.org/lkml/2014/7/15/975 where you guys started to review and prepare things for upstream-inclusion of the csdio-module. Strangely enough the last mail on

csdio-kernel module status, if any (was: Re: char interface to sdio, chdio.c)

2015-11-03 Thread Patrick Boettcher
Hi all, Sorry for posting out-of-thread, but I don't have the original mail and thus cannot reply. If refer to this thread: https://lkml.org/lkml/2014/7/15/975 where you guys started to review and prepare things for upstream-inclusion of the csdio-module. Strangely enough the last mail on

Re: [PATCH] staging: android: fix coding style error (v2)

2015-01-14 Thread Patrick Boettcher
Hi Dan, Thanks for your valuable input. It's appreciated. On Wed, 14 Jan 2015 12:28:44 +0300 Dan Carpenter wrote: > > lots of Cc:'s [..] > > This block is not needed. This is a whitespace patch not something > controversial where we will need to look at who was CC'd so that we > can get

[PATCH] staging: android: fix coding style error (v2)

2015-01-14 Thread Patrick Boettcher
Simple style fix - 80 char limit was exceeded. This is second version of the patch. Thanks Joe Perches. Context: eudyptula challenge (http://eudyptula-challenge.org/) Signed-off-by: Patrick Boettcher Cc: Greg Kroah-Hartman Cc: Arnd Bergmann Cc: John Stultz Cc: Peter Senna Tschudin Cc

[PATCH] staging: android: fix coding style error

2015-01-14 Thread Patrick Boettcher
Simple style fix - 80 char limit was exceeded. Context: eudyptula challenge (http://eudyptula-challenge.org/) Signed-off-by: Patrick Boettcher Cc: Greg Kroah-Hartman Cc: Arnd Bergmann Cc: John Stultz Cc: Peter Senna Tschudin Cc: Daniel Vetter Cc: Maarten Lankhorst Cc: Tapasweni Pathak

[PATCH] staging: android: fix coding style error

2015-01-14 Thread Patrick Boettcher
Simple style fix - 80 char limit was exceeded. Context: eudyptula challenge (http://eudyptula-challenge.org/) Signed-off-by: Patrick Boettcher patrick.boettc...@posteo.de Cc: Greg Kroah-Hartman gre...@linuxfoundation.org Cc: Arnd Bergmann a...@arndb.de Cc: John Stultz john.stu...@linaro.org Cc

[PATCH] staging: android: fix coding style error (v2)

2015-01-14 Thread Patrick Boettcher
Simple style fix - 80 char limit was exceeded. This is second version of the patch. Thanks Joe Perches. Context: eudyptula challenge (http://eudyptula-challenge.org/) Signed-off-by: Patrick Boettcher patrick.boettc...@posteo.de Cc: Greg Kroah-Hartman gre...@linuxfoundation.org Cc: Arnd

Re: [PATCH] staging: android: fix coding style error (v2)

2015-01-14 Thread Patrick Boettcher
Hi Dan, Thanks for your valuable input. It's appreciated. On Wed, 14 Jan 2015 12:28:44 +0300 Dan Carpenter dan.carpen...@oracle.com wrote: lots of Cc:'s [..] This block is not needed. This is a whitespace patch not something controversial where we will need to look at who was CC'd so that

Re: dvb-usb/technisat-usb2: Fix cut-n-paste thinko

2013-09-05 Thread Patrick Boettcher
BIT; Nice catch. Mauro, feel free to add my signed-off-line, when integrating Signed-off-by: Patrick Boettcher -- Patrick -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo inf

Re: dvb-usb/technisat-usb2: Fix cut-n-paste thinko

2013-09-05 Thread Patrick Boettcher
, when integrating Signed-off-by: Patrick Boettcher pboettc...@kernellabs.com -- Patrick -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read

Re: dib7000m_i2c_enumeration() is unused

2007-11-10 Thread Patrick Boettcher
Hi all, This is another story of "the chip-vendor provides driver support and is waiting for device to hit the market". DiBcom knows that there are devices out there that are using the dib7000m in way that they need the dib7000m_i2c_enumeration to work properly. But it is impossible to know

Re: dib7000m_i2c_enumeration() is unused

2007-11-10 Thread Patrick Boettcher
Hi all, This is another story of the chip-vendor provides driver support and is waiting for device to hit the market. DiBcom knows that there are devices out there that are using the dib7000m in way that they need the dib7000m_i2c_enumeration to work properly. But it is impossible to know

Re: [v4l-dvb-maintainer] DVB: BANDWIDTH_TO_KHZ strangeness

2007-10-22 Thread Patrick Boettcher
Hi all, This coverity checker is great. He even finds all the things which are there because I'm lazy ;) . The dib-drivers are all generated from our internal drivers to have at least something for Linux. Because of no time there is no dedicated source for the kernel but just the

Re: [v4l-dvb-maintainer] DVB: BANDWIDTH_TO_KHZ strangeness

2007-10-22 Thread Patrick Boettcher
Hi all, This coverity checker is great. He even finds all the things which are there because I'm lazy ;) . The dib-drivers are all generated from our internal drivers to have at least something for Linux. Because of no time there is no dedicated source for the kernel but just the

[PATCH] fix for race problem in DVB USB drivers (dibusb)

2005-08-27 Thread Patrick Boettcher
and starting the actual transfer in hardware (demodulator and USB controller) which sometimes lead to garbled data transfers. URBs are now submitted first, then the transfer is enabled. Dibusb devices and clones are now fully functional again. Signed-off-by: Patrick Boettcher <[EMAIL PROTEC

[PATCH] fix for race problem in DVB USB drivers (dibusb)

2005-08-27 Thread Patrick Boettcher
and starting the actual transfer in hardware (demodulator and USB controller) which sometimes lead to garbled data transfers. URBs are now submitted first, then the transfer is enabled. Dibusb devices and clones are now fully functional again. Signed-off-by: Patrick Boettcher [EMAIL PROTECTED

Re: [linux-dvb-maintainer] [2.6 patch] Documentation/dvb/get_dvb_firmware: fix firmware URL

2005-08-24 Thread Patrick Boettcher
On Wed, 24 Aug 2005, Adrian Bunk wrote: This patch fixes a wrong URL in Documentation/dvb/get_dvb_firmware. It is already in dvb-kernel CVS. I think it was just not send to Andrew along with the latest patchset. Thank you anyway. best regards, Patrick. -- Mail: [EMAIL PROTECTED] WWW:

Re: [linux-dvb-maintainer] [2.6 patch] Documentation/dvb/get_dvb_firmware: fix firmware URL

2005-08-24 Thread Patrick Boettcher
On Wed, 24 Aug 2005, Adrian Bunk wrote: This patch fixes a wrong URL in Documentation/dvb/get_dvb_firmware. It is already in dvb-kernel CVS. I think it was just not send to Andrew along with the latest patchset. Thank you anyway. best regards, Patrick. -- Mail: [EMAIL PROTECTED] WWW:

Re: cx22702.c, 2.6.13-rc3 and a pci Hauppauge Nova-T DVB-T TV card

2005-07-15 Thread Patrick Boettcher
On Fri, 15 Jul 2005, Mauro Carvalho Chehab wrote: Patrick, Patrick Boettcher wrote: On Fri, 15 Jul 2005, Andrew Benton wrote: Hi, I tried the patch but unfortunately the kernel didn't compile, it ended like this CC drivers/media/video/cx88/cx88-blackbird.o CC drivers/media/video

Re: cx22702.c, 2.6.13-rc3 and a pci Hauppauge Nova-T DVB-T TV card

2005-07-15 Thread Patrick Boettcher
On Fri, 15 Jul 2005, Andrew Benton wrote: Hi, I tried the patch but unfortunately the kernel didn't compile, it ended like this CC drivers/media/video/cx88/cx88-blackbird.o CC drivers/media/video/cx88/cx88-dvb.o drivers/media/video/cx88/cx88-dvb.c:169: error: unknown field

Re: cx22702.c, 2.6.13-rc3 and a pci Hauppauge Nova-T DVB-T TV card

2005-07-15 Thread Patrick Boettcher
= dntv_live_dvbt_demod_init, .pll_set = mt352_pll_set, }; Please include. Thanks Signed-off-by: Patrick Boettcher <[EMAIL PROTECTED]> best regards, Patrick. -- Mail: [EMAIL PROTECTED] WWW: http://www.wi-bw.tfh-wildau.de/~pboettch/ - To unsubscribe from this list: send th

Re: cx22702.c, 2.6.13-rc3 and a pci Hauppauge Nova-T DVB-T TV card

2005-07-15 Thread Patrick Boettcher
= dntv_live_dvbt_demod_init, .pll_set = mt352_pll_set, }; Please include. Thanks Signed-off-by: Patrick Boettcher [EMAIL PROTECTED] best regards, Patrick. -- Mail: [EMAIL PROTECTED] WWW: http://www.wi-bw.tfh-wildau.de/~pboettch/ - To unsubscribe from this list: send the line

Re: cx22702.c, 2.6.13-rc3 and a pci Hauppauge Nova-T DVB-T TV card

2005-07-15 Thread Patrick Boettcher
On Fri, 15 Jul 2005, Andrew Benton wrote: Hi, I tried the patch but unfortunately the kernel didn't compile, it ended like this CC drivers/media/video/cx88/cx88-blackbird.o CC drivers/media/video/cx88/cx88-dvb.o drivers/media/video/cx88/cx88-dvb.c:169: error: unknown field

Re: cx22702.c, 2.6.13-rc3 and a pci Hauppauge Nova-T DVB-T TV card

2005-07-15 Thread Patrick Boettcher
On Fri, 15 Jul 2005, Mauro Carvalho Chehab wrote: Patrick, Patrick Boettcher wrote: On Fri, 15 Jul 2005, Andrew Benton wrote: Hi, I tried the patch but unfortunately the kernel didn't compile, it ended like this CC drivers/media/video/cx88/cx88-blackbird.o CC drivers/media/video