Re: [PATCH v6] ARM: dts: aspeed: Adding Lenovo Hr630 BMC

2019-05-06 Thread Patrick Venture
onghui Liu > > Signed-off-by: Lisa Liu > > Reviewed-by: Andrew Jeffery Reviewed-by: Patrick Venture > > > --- > > Changes in v6: > > - add appropriate pinctrl property for uar1, uart2, uart3 and adc. > > - remove vhub definition and comment. > > - re

Re: [PATCH 1/2] dt-bindings: Add ir38064 as a trivial device

2019-04-30 Thread Patrick Venture
On Mon, Apr 29, 2019 at 5:42 PM Rob Herring wrote: > > On Tue, Apr 16, 2019 at 08:41:38AM -0700, Patrick Venture wrote: > > The ir38064 is a voltage regulator from Infineon. > > > > Signed-off-by: Patrick Venture > > --- > > Documentation/devicetree/binding

Re: [PATCH v2] soc: add aspeed folder and misc drivers

2019-04-29 Thread Patrick Venture
On Mon, Apr 29, 2019 at 12:35 PM Patrick Venture wrote: > > On Mon, Apr 29, 2019 at 12:27 PM Olof Johansson wrote: > > > > On Mon, Apr 29, 2019 at 10:12 AM Patrick Venture wrote: > > > > > > On Mon, Apr 29, 2019 at 10:08 AM Olof Johansson wrote: > >

Re: [PATCH v2] soc: add aspeed folder and misc drivers

2019-04-29 Thread Patrick Venture
On Mon, Apr 29, 2019 at 12:27 PM Olof Johansson wrote: > > On Mon, Apr 29, 2019 at 10:12 AM Patrick Venture wrote: > > > > On Mon, Apr 29, 2019 at 10:08 AM Olof Johansson wrote: > > > > > > On Thu, Apr 25, 2019 at 07:25:49PM +0200, Greg KH wrote: > > &g

Re: [PATCH v2] soc: add aspeed folder and misc drivers

2019-04-29 Thread Patrick Venture
On Mon, Apr 29, 2019 at 10:19 AM Olof Johansson wrote: > > On Mon, Apr 29, 2019 at 10:16 AM Patrick Venture wrote: > > > > On Mon, Apr 29, 2019 at 10:13 AM Olof Johansson wrote: > > > > > > On Mon, Apr 29, 2019 at 10:08 AM Olof Johansson wrote: > >

Re: [PATCH v2] soc: add aspeed folder and misc drivers

2019-04-29 Thread Patrick Venture
On Mon, Apr 29, 2019 at 10:13 AM Olof Johansson wrote: > > On Mon, Apr 29, 2019 at 10:08 AM Olof Johansson wrote: > > > > On Thu, Apr 25, 2019 at 07:25:49PM +0200, Greg KH wrote: > > > On Tue, Apr 23, 2019 at 08:28:14AM -0700, Patrick Venture wrote: > > &g

Re: [PATCH v2] soc: add aspeed folder and misc drivers

2019-04-29 Thread Patrick Venture
On Mon, Apr 29, 2019 at 10:08 AM Olof Johansson wrote: > > On Thu, Apr 25, 2019 at 07:25:49PM +0200, Greg KH wrote: > > On Tue, Apr 23, 2019 at 08:28:14AM -0700, Patrick Venture wrote: > > > On Tue, Apr 23, 2019 at 8:22 AM Patrick Venture > > > wrote: > > &

Re: linux-next: build warning after merge of the char-misc tree

2019-04-26 Thread Patrick Venture
On Fri, Apr 26, 2019 at 7:30 AM Patrick Venture wrote: > > On Thu, Apr 25, 2019 at 11:25 PM Greg KH wrote: > > > > On Fri, Apr 26, 2019 at 03:56:53PM +1000, Stephen Rothwell wrote: > > > Hi all, > > > > > > After merging the char-misc tree, today'

[PATCH] misc: aspeed-p2a-ctrl: fix mixed declarations

2019-04-26 Thread Patrick Venture
Fix up mixed declarations and code in aspeed_p2a_mmap. Tested: Verified the build had the error and that this patch resolved it and there were no other warnings or build errors associated with compilation of this driver. Reported-by: Stephen Rothwell Signed-off-by: Patrick Venture --- drivers

Re: linux-next: build warning after merge of the char-misc tree

2019-04-26 Thread Patrick Venture
On Thu, Apr 25, 2019 at 11:25 PM Greg KH wrote: > > On Fri, Apr 26, 2019 at 03:56:53PM +1000, Stephen Rothwell wrote: > > Hi all, > > > > After merging the char-misc tree, today's linux-next build (x86_64 > > allmodconfig) produced this warning: > > > > drivers/misc/aspeed-p2a-ctrl.c: In function

Re: [PATCH] fixup! drivers/misc: Add Aspeed P2A control driver

2019-04-25 Thread Patrick Venture
On Thu, Apr 25, 2019 at 1:36 PM Greg KH wrote: > > On Thu, Apr 25, 2019 at 01:23:47PM -0700, Patrick Venture wrote: > > Fixup compiler warnings: > > - 108 warning: ISO C90 forbids mixed declarations and code > > - 264 warning: unused variable 'value' > > - 335

[PATCH] fixup! drivers/misc: Add Aspeed P2A control driver

2019-04-25 Thread Patrick Venture
Fixup compiler warnings: - 108 warning: ISO C90 forbids mixed declarations and code - 264 warning: unused variable 'value' - 335 warning: unused variable 'res' Signed-off-by: Patrick Venture --- drivers/misc/aspeed-p2a-ctrl.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff

[PATCH 1/2] ARM: dts: aspeed: Add aspeed-p2a-ctrl node

2019-04-25 Thread Patrick Venture
Add a node for the aspeed-p2a-ctrl module. This node, when enabled will disable the PCI-to-AHB bridge and then allow control of this bridge via ioctls, and access via mmap. Signed-off-by: Patrick Venture --- arch/arm/boot/dts/aspeed-g4.dtsi | 4 arch/arm/boot/dts/aspeed-g5.dtsi | 5

[PATCH 2/2] ARM: dts: aspeed: quanta-q71: Enable p2a node

2019-04-25 Thread Patrick Venture
Enable the aspeed-p2a-ctrl node and configure with memory-region to enable mmap access. Signed-off-by: Patrick Venture --- arch/arm/boot/dts/aspeed-bmc-quanta-q71l.dts | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm/boot/dts/aspeed-bmc-quanta-q71l.dts b/arch/arm/boot/dts

Re: [PATCH v3] ARM: dts: aspeed: Adding Lenovo Hr630 BMC

2019-04-24 Thread Patrick Venture
On Wed, Apr 24, 2019 at 5:29 AM Andrew Peng wrote: > > Initial introduction of Lenovo Hr630 family equipped with > Aspeed 2500 BMC SoC. Hr630 is a x86 server development kit > with a ASPEED ast2500 BMC manufactured by Lenovo. > Specifically, This adds the Hr630 platform device tree file > used by

Re: [PATCH] soc: add aspeed folder and misc drivers

2019-04-23 Thread Patrick Venture
On Tue, Apr 23, 2019 at 8:33 AM Arnd Bergmann wrote: > > On Tue, Apr 23, 2019 at 4:24 PM Patrick Venture wrote: > > > > On Tue, Apr 23, 2019 at 1:08 AM Arnd Bergmann wrote: > > > > > > On Mon, Apr 22, 2019 at 7:38 PM Patrick Venture > > &g

Re: [PATCH v2] soc: add aspeed folder and misc drivers

2019-04-23 Thread Patrick Venture
On Tue, Apr 23, 2019 at 8:22 AM Patrick Venture wrote: > > On Tue, Apr 23, 2019 at 7:26 AM Patrick Venture wrote: > > > > Create a SoC folder for the ASPEED parts and place the misc drivers > > currently present into this folder. These drivers are not generic part >

Re: [PATCH v2] soc: add aspeed folder and misc drivers

2019-04-23 Thread Patrick Venture
On Tue, Apr 23, 2019 at 7:26 AM Patrick Venture wrote: > > Create a SoC folder for the ASPEED parts and place the misc drivers > currently present into this folder. These drivers are not generic part > drivers, but rather only apply to the ASPEED SoCs. > > Signed-off-b

Re: [PATCH v2] ARM: dts: aspeed: Adding Lenovo Hr630 BMC

2019-04-23 Thread Patrick Venture
On Tue, Apr 23, 2019 at 4:55 AM Andrew Peng wrote: > > Initial introduction of Lenovo Hr630 family equipped with > Aspeed 2500 BMC SoC. Hr630 is a x86 server development kit > with a ASPEED ast2500 BMC manufactured by Lenovo. > Specifically, This adds the Hr630 platform device tree file > used by

[PATCH v2] soc: add aspeed folder and misc drivers

2019-04-23 Thread Patrick Venture
Create a SoC folder for the ASPEED parts and place the misc drivers currently present into this folder. These drivers are not generic part drivers, but rather only apply to the ASPEED SoCs. Signed-off-by: Patrick Venture --- v2: Added configuration option for ASPEED to soc/Makefile

Re: [PATCH] soc: add aspeed folder and misc drivers

2019-04-23 Thread Patrick Venture
On Tue, Apr 23, 2019 at 1:08 AM Arnd Bergmann wrote: > > On Mon, Apr 22, 2019 at 7:38 PM Patrick Venture wrote: > > > > Create a SoC folder for the ASPEED parts and place the misc drivers > > currently present into this folder. These drivers are not generic part >

Re: [PATCH v2] soc: add aspeed folder and misc drivers

2019-04-22 Thread Patrick Venture
On Mon, Apr 22, 2019 at 10:54 AM Patrick Venture wrote: > > Create a SoC folder for the ASPEED parts and place the misc drivers > currently present into this folder. These drivers are not generic part > drivers, but rather only apply to the ASPEED SoCs. > > Signed-off-b

[PATCH v2] soc: add aspeed folder and misc drivers

2019-04-22 Thread Patrick Venture
Create a SoC folder for the ASPEED parts and place the misc drivers currently present into this folder. These drivers are not generic part drivers, but rather only apply to the ASPEED SoCs. Signed-off-by: Patrick Venture --- v2: Added configuration option for ASPEED to soc/Makefile

[PATCH] soc: add aspeed folder and misc drivers

2019-04-22 Thread Patrick Venture
Create a SoC folder for the ASPEED parts and place the misc drivers currently present into this folder. These drivers are not generic part drivers, but rather only apply to the ASPEED SoCs. Signed-off-by: Patrick Venture --- drivers/misc/Kconfig | 16

[PATCH 3/3] ARM: dts: aspeed: zaius: fixed I2C bus numbers for pcie slots

2019-04-16 Thread Patrick Venture
that they return to their former numbers before the cfam change. Signed-off-by: Robert Lippert Signed-off-by: Patrick Venture --- arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts | 40 ++ 1 file changed, 40 insertions(+) diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts b/arch/arm

[PATCH 0/3] update aspeed-bmc-opp-zaius device-tree

2019-04-16 Thread Patrick Venture
Hi, This series contains three updates to the Zaius ASPEED device-tree to add voltrage regulators, and update addresses and aliases. The Infineon and Intersil drivers are staged on hwmon-next, and the trivial device dt-bindings changed are up for review. Maxim Sloyko (1): ARM: dts: aspeed:

[PATCH 1/3] ARM: dts: aspeed: zaius: add Infineon and Intersil regulators

2019-04-16 Thread Patrick Venture
From: Maxim Sloyko Add the nodes for the ir38064 and isl68137 devices on the Zaius board. Signed-off-by: Maxim Sloyko Signed-off-by: Robert Lippert Signed-off-by: Patrick Venture --- arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts | 65 -- 1 file changed, 60 insertions(+), 5

[PATCH 2/3] ARM: dts: aspeed: zaius: update 12V brick I2C address

2019-04-16 Thread Patrick Venture
From: Robert Lippert The I2C address of the brick is different depending on the board SKU. Update the values to instantiate addresses which work for most boards. Signed-off-by: Robert Lippert Signed-off-by: Patrick Venture --- arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts | 18

[PATCH 2/2] dt-bindings: Add isl68137 as a trivial device

2019-04-16 Thread Patrick Venture
The isl68137 is a digital output 7-phrase configurable PWM controller with an AVSBus interface from Intersil. Signed-off-by: Patrick Venture --- Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/trivial

[PATCH 1/2] dt-bindings: Add ir38064 as a trivial device

2019-04-16 Thread Patrick Venture
The ir38064 is a voltage regulator from Infineon. Signed-off-by: Patrick Venture --- Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial

Re: [PATCH] dt-bindings: Add vendor prefix for intersil

2019-04-16 Thread Patrick Venture
On Tue, Apr 16, 2019 at 7:53 AM Patrick Venture wrote: > > Add vendor prefix for intersil, known as Intersil, a subsidiary of > Renesas Electronic Corporation. > > Signed-off-by: Patrick Venture > --- > Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + > 1 f

[PATCH] dt-bindings: Add vendor prefix for intersil

2019-04-16 Thread Patrick Venture
Add vendor prefix for intersil, known as Intersil, a subsidiary of Renesas Electronic Corporation. Signed-off-by: Patrick Venture --- Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt

Re: [PATCH v10 1/2] dt-bindings: misc: aspeed-p2a-ctrl: add support

2019-04-16 Thread Patrick Venture
On Mon, Apr 8, 2019 at 5:48 PM Andrew Jeffery wrote: > > > > On Tue, 9 Apr 2019, at 00:12, Patrick Venture wrote: > > Document the ast2400, ast2500 PCI-to-AHB bridge control driver bindings. > > > > Signed-off-by: Patrick Venture > > Reviewed-by: Rob Herr

[PATCH v10 2/2] drivers/misc: Add Aspeed P2A control driver

2019-04-08 Thread Patrick Venture
write to all of it. Signed-off-by: Patrick Venture Reviewed-by: Andrew Jeffery --- Changes for v10: - None Changes for v9: - Stop zeroing out memory that is already zeroed out. Changes for v8: - Promoted u32 address values to u64 to be compatible with either. Changes for v7: - Moved node under

[PATCH v10 1/2] dt-bindings: misc: aspeed-p2a-ctrl: add support

2019-04-08 Thread Patrick Venture
Document the ast2400, ast2500 PCI-to-AHB bridge control driver bindings. Signed-off-by: Patrick Venture Reviewed-by: Rob Herring --- Changes for v10: - Chopped out nearly identical information. Changes for v9: - Added missing details about syscon parent Changes for v8: - None Changes for v7

Re: [PATCH v9 1/2] dt-bindings: misc: aspeed-p2a-ctrl: add support

2019-04-08 Thread Patrick Venture
On Sun, Apr 7, 2019 at 7:03 PM Andrew Jeffery wrote: > > > > On Fri, 5 Apr 2019, at 01:55, Patrick Venture wrote: > > Document the ast2400, ast2500 PCI-to-AHB bridge control driver bindings. > > > > Signed-off-by: Patrick Venture > > Reviewed-by: Rob

[PATCH v9 2/2] drivers/misc: Add Aspeed P2A control driver

2019-04-04 Thread Patrick Venture
write to all of it. Signed-off-by: Patrick Venture Reviewed-by: Andrew Jeffery --- Changes for v9: - Stop zeroing out memory that is already zeroed out. Changes for v8: - Promoted u32 address values to u64 to be compatible with either. Changes for v7: - Moved node under the syscon node

[PATCH v9 1/2] dt-bindings: misc: aspeed-p2a-ctrl: add support

2019-04-04 Thread Patrick Venture
Document the ast2400, ast2500 PCI-to-AHB bridge control driver bindings. Signed-off-by: Patrick Venture Reviewed-by: Rob Herring --- Changes for v9: - Added missing details about syscon parent Changes for v8: - None Changes for v7: - Moved node under the syscon node it requires Changes for v6

Re: [PATCH v8 2/2] drivers/misc: Add Aspeed P2A control driver

2019-04-04 Thread Patrick Venture
On Tue, Apr 2, 2019 at 2:25 PM Patrick Venture wrote: > > On Mon, Apr 1, 2019 at 8:36 PM Andrew Jeffery wrote: > > > > > > > > On Thu, 28 Mar 2019, at 07:52, Patrick Venture wrote: > > > The ASPEED AST2400, and AST2500 in some configurations include a >

Re: [PATCH v8 2/2] drivers/misc: Add Aspeed P2A control driver

2019-04-02 Thread Patrick Venture
On Mon, Apr 1, 2019 at 8:36 PM Andrew Jeffery wrote: > > > > On Thu, 28 Mar 2019, at 07:52, Patrick Venture wrote: > > The ASPEED AST2400, and AST2500 in some configurations include a > > PCI-to-AHB MMIO bridge. This bridge allows a server to read and write > >

Re: [PATCH v8 1/2] dt-bindings: misc: aspeed-p2a-ctrl: add support

2019-04-02 Thread Patrick Venture
On Mon, Apr 1, 2019 at 8:42 PM Andrew Jeffery wrote: > > Hi Patrick, > > I held off on reviewing this until we'd hashed out what we needed in the > driver. > > I have some comments below. > > On Sat, 30 Mar 2019, at 01:40, Patrick Venture wrote: > > Documen

Re: [PATCH v8 1/2] dt-bindings: misc: aspeed-p2a-ctrl: add support

2019-03-29 Thread Patrick Venture
On Fri, Mar 29, 2019 at 7:59 AM Patrick Venture wrote: > > On Fri, Mar 29, 2019 at 7:56 AM Patrick Venture wrote: > > > > On Fri, Mar 29, 2019 at 6:38 AM Rob Herring wrote: > > > > > > On Thu, Mar 28, 2019 at 12:03 PM Patrick Venture > > > wrote:

[PATCH v8 1/2] dt-bindings: misc: aspeed-p2a-ctrl: add support

2019-03-29 Thread Patrick Venture
Document the ast2400, ast2500 PCI-to-AHB bridge control driver bindings. Signed-off-by: Patrick Venture Reviewed-by: Rob Herring --- Changes for v8: - None Changes for v7: - Moved node under the syscon node it requires Changes for v6: - None Changes for v5: - None Changes for v4: - None Changes

Re: [PATCH v8 1/2] dt-bindings: misc: aspeed-p2a-ctrl: add support

2019-03-29 Thread Patrick Venture
On Fri, Mar 29, 2019 at 7:56 AM Patrick Venture wrote: > > On Fri, Mar 29, 2019 at 6:38 AM Rob Herring wrote: > > > > On Thu, Mar 28, 2019 at 12:03 PM Patrick Venture wrote: > > > > > > On Thu, Mar 28, 2019 at 9:50 AM Rob Herring wrote: > > >

Re: [PATCH v8 1/2] dt-bindings: misc: aspeed-p2a-ctrl: add support

2019-03-29 Thread Patrick Venture
On Fri, Mar 29, 2019 at 6:38 AM Rob Herring wrote: > > On Thu, Mar 28, 2019 at 12:03 PM Patrick Venture wrote: > > > > On Thu, Mar 28, 2019 at 9:50 AM Rob Herring wrote: > > > > > > On Wed, 27 Mar 2019 14:21:55 -0700, Patrick Venture wrote: > > &g

Re: [PATCH v8 1/2] dt-bindings: misc: aspeed-p2a-ctrl: add support

2019-03-28 Thread Patrick Venture
On Thu, Mar 28, 2019 at 9:50 AM Rob Herring wrote: > > On Wed, 27 Mar 2019 14:21:55 -0700, Patrick Venture wrote: > > Document the ast2400, ast2500 PCI-to-AHB bridge control driver bindings. > > > > Signed-off-by: Patrick Venture > > --- > > Changes f

Re: [PATCH v7 2/2] drivers/misc: Add Aspeed P2A control driver

2019-03-28 Thread Patrick Venture
On Wed, Mar 27, 2019 at 11:52 PM Greg KH wrote: > > On Wed, Mar 27, 2019 at 12:01:50PM -0700, Patrick Venture wrote: > > On Wed, Mar 27, 2019 at 11:54 AM Greg KH wrote: > > > > > > On Wed, Mar 27, 2019 at 11:44:36AM -0700, Patrick Venture wrote: > > > >

[PATCH v8 2/2] drivers/misc: Add Aspeed P2A control driver

2019-03-27 Thread Patrick Venture
write to all of it. Signed-off-by: Patrick Venture --- Changes for v8: - Promoted u32 address values to u64 to be compatible with either. Changes for v7: - Moved node under the syscon node and changed therefore how it grabs the phandle for the regmap. Changes for v6: - Cleaned up documentation

[PATCH v8 1/2] dt-bindings: misc: aspeed-p2a-ctrl: add support

2019-03-27 Thread Patrick Venture
Document the ast2400, ast2500 PCI-to-AHB bridge control driver bindings. Signed-off-by: Patrick Venture --- Changes for v8: - None Changes for v7: - Moved node under the syscon node it requires Changes for v6: - None Changes for v5: - None Changes for v4: - None Changes for v3: - None Changes

Re: [PATCH v7 2/2] drivers/misc: Add Aspeed P2A control driver

2019-03-27 Thread Patrick Venture
On Wed, Mar 27, 2019 at 12:01 PM Patrick Venture wrote: > > On Wed, Mar 27, 2019 at 11:54 AM Greg KH wrote: > > > > On Wed, Mar 27, 2019 at 11:44:36AM -0700, Patrick Venture wrote: > > > On Wed, Mar 27, 2019 at 11:28 AM Greg KH > > > wrote: > > >

Re: [PATCH v7 2/2] drivers/misc: Add Aspeed P2A control driver

2019-03-27 Thread Patrick Venture
On Wed, Mar 27, 2019 at 11:54 AM Greg KH wrote: > > On Wed, Mar 27, 2019 at 11:44:36AM -0700, Patrick Venture wrote: > > On Wed, Mar 27, 2019 at 11:28 AM Greg KH wrote: > > > > > > On Tue, Mar 12, 2019 at 09:31:01AM -0700, Patrick Venture wrote: >

Re: [PATCH v7 2/2] drivers/misc: Add Aspeed P2A control driver

2019-03-27 Thread Patrick Venture
On Wed, Mar 27, 2019 at 11:28 AM Greg KH wrote: > > On Tue, Mar 12, 2019 at 09:31:01AM -0700, Patrick Venture wrote: > > + phys_addr_t mem_base; > > Is this really a 32bit value? It's going to be a 32-bit value if this is in the dts for one of the correspondingly suppo

Re: [PATCH v7 1/2] dt-bindings: misc: aspeed-p2a-ctrl: add support

2019-03-13 Thread Patrick Venture
On Wed, Mar 13, 2019 at 12:54 PM Rob Herring wrote: > > On Tue, Mar 12, 2019 at 11:30 AM Patrick Venture wrote: > > > > Document the ast2400, ast2500 PCI-to-AHB bridge control driver bindings. > > > > Signed-off-by: Patrick Venture > > --- > > Changes

[PATCH v7 1/2] dt-bindings: misc: aspeed-p2a-ctrl: add support

2019-03-12 Thread Patrick Venture
Document the ast2400, ast2500 PCI-to-AHB bridge control driver bindings. Signed-off-by: Patrick Venture --- Changes for v7: - Moved node under the syscon node it requires Changes for v6: - None Changes for v5: - None Changes for v4: - None Changes for v3: - None Changes for v2: - Added comment

[PATCH v7 2/2] drivers/misc: Add Aspeed P2A control driver

2019-03-12 Thread Patrick Venture
write to all of it. Signed-off-by: Patrick Venture --- Changes for v7: - Moved node under the syscon node and changed therefore how it grabs the phandle for the regmap. Changes for v6: - Cleaned up documentation - Added missing machine-readable copyright lines. - Fixed over 80 chars instances

Re: [PATCH v6 1/2] dt-bindings: misc: aspeed-p2a-ctrl: add support

2019-03-12 Thread Patrick Venture
On Mon, Mar 11, 2019 at 7:38 PM Rob Herring wrote: > > On Mon, Mar 11, 2019 at 6:49 PM Patrick Venture wrote: > > > > On Mon, Mar 11, 2019 at 3:20 PM Rob Herring wrote: > > > > > > On Mon, Mar 04, 2019 at 10:55:36AM -0800, Patrick Venture wrote: > > &g

Re: [PATCH v6 1/2] dt-bindings: misc: aspeed-p2a-ctrl: add support

2019-03-11 Thread Patrick Venture
On Mon, Mar 11, 2019 at 3:20 PM Rob Herring wrote: > > On Mon, Mar 04, 2019 at 10:55:36AM -0800, Patrick Venture wrote: > > Document the ast2400, ast2500 PCI-to-AHB bridge control driver bindings. > > > > Signed-off-by: Patrick Venture > > --- > > Changes f

Re: [PATCH v5 2/2] drivers/misc: Add Aspeed P2A control driver

2019-03-04 Thread Patrick Venture
On Mon, Mar 4, 2019 at 5:53 PM Andrew Jeffery wrote: > > > > On Tue, 5 Mar 2019, at 05:01, Patrick Venture wrote: > > On Mon, Mar 4, 2019 at 7:45 AM Patrick Venture wrote: > > > > > > On Sun, Mar 3, 2019 at 4:04 PM Andrew Jeffery wrote: > > > > &

[PATCH v6 2/2] drivers/misc: Add Aspeed P2A control driver

2019-03-04 Thread Patrick Venture
write to all of it. Signed-off-by: Patrick Venture --- Changes for v6: - Cleaned up documentation - Added missing machine-readable copyright lines. - Fixed over 80 chars instances. - Changed error from invalid memory-region node to ENODEV. Changes for v5: - Fixup missing exit condition and remove

[PATCH v6 1/2] dt-bindings: misc: aspeed-p2a-ctrl: add support

2019-03-04 Thread Patrick Venture
Document the ast2400, ast2500 PCI-to-AHB bridge control driver bindings. Signed-off-by: Patrick Venture --- Changes for v6: - None Changes for v5: - None Changes for v4: - None Changes for v3: - None Changes for v2: - Added comment about syscon required parameter. --- .../bindings/misc/aspeed

Re: [PATCH v5 2/2] drivers/misc: Add Aspeed P2A control driver

2019-03-04 Thread Patrick Venture
On Mon, Mar 4, 2019 at 7:45 AM Patrick Venture wrote: > > On Sun, Mar 3, 2019 at 4:04 PM Andrew Jeffery wrote: > > > > Hi Patrick. > > > > I've got some minor comments, otherwise it looks reasonable to me. > > > > On Thu, 28 Feb 2019, at 12:22, Patri

Re: [PATCH v5 2/2] drivers/misc: Add Aspeed P2A control driver

2019-03-04 Thread Patrick Venture
On Mon, Mar 4, 2019 at 8:31 AM Patrick Venture wrote: > > On Mon, Mar 4, 2019 at 8:31 AM Greg Kroah-Hartman > wrote: > > > > On Mon, Mar 04, 2019 at 07:45:31AM -0800, Patrick Venture wrote: > > > On Sun, Mar 3, 2019 at 4:04 PM Andrew Jeffery wro

Re: [PATCH v5 2/2] drivers/misc: Add Aspeed P2A control driver

2019-03-04 Thread Patrick Venture
On Mon, Mar 4, 2019 at 8:31 AM Greg Kroah-Hartman wrote: > > On Mon, Mar 04, 2019 at 07:45:31AM -0800, Patrick Venture wrote: > > On Sun, Mar 3, 2019 at 4:04 PM Andrew Jeffery wrote: > > > > > > Hi Patrick. > > > > > > I've got some min

Re: [PATCH v5 2/2] drivers/misc: Add Aspeed P2A control driver

2019-03-04 Thread Patrick Venture
On Sun, Mar 3, 2019 at 4:04 PM Andrew Jeffery wrote: > > Hi Patrick. > > I've got some minor comments, otherwise it looks reasonable to me. > > On Thu, 28 Feb 2019, at 12:22, Patrick Venture wrote: > > The ASPEED AST2400, and AST2500 in some configurations include a &g

[PATCH v5 1/2] dt-bindings: misc: aspeed-p2a-ctrl: add support

2019-02-27 Thread Patrick Venture
Document the ast2400, ast2500 PCI-to-AHB bridge control driver bindings. Signed-off-by: Patrick Venture --- Changes for v5: - None Changes for v4: - None Changes for v3: - None Changes for v2: - Added comment about syscon required parameter. --- .../bindings/misc/aspeed-p2a-ctrl.txt

[PATCH v5 2/2] drivers/misc: Add Aspeed P2A control driver

2019-02-27 Thread Patrick Venture
write to all of it. Signed-off-by: Patrick Venture --- Changes for v5: - Fixup missing exit condition and remove extra jump. Changes for v4: - Added ioctl for reading back the memory-region configuration. - Cleaned up some unused variables. Changes for v3: - Deleted unused read and write methods

Re: [PATCH v4 2/2] drivers/misc: Add Aspeed P2A control driver

2019-02-27 Thread Patrick Venture
On Wed, Feb 27, 2019 at 8:59 AM Patrick Venture wrote: > > The ASPEED AST2400, and AST2500 in some configurations include a > PCI-to-AHB MMIO bridge. This bridge allows a server to read and write > in the BMC's physical address space. This feature is especially useful > when us

[PATCH v4 1/2] dt-bindings: misc: aspeed-p2a-ctrl: add support

2019-02-27 Thread Patrick Venture
Document the ast2400, ast2500 PCI-to-AHB bridge control driver bindings. Signed-off-by: Patrick Venture --- Changes for v4: - None Changes for v3: - None Changes for v2: - Added comment about syscon required parameter. --- .../bindings/misc/aspeed-p2a-ctrl.txt | 32

[PATCH v4 2/2] drivers/misc: Add Aspeed P2A control driver

2019-02-27 Thread Patrick Venture
write to all of it. Signed-off-by: Patrick Venture --- Changes for v4: - Added ioctl for reading back the memory-region configuration. - Cleaned up some unused variables. Changes for v3: - Deleted unused read and write methods. Changes for v2: - Dropped unused reads. - Moved call to disable bridge

Re: [PATCH 2/2] drivers/misc: Add Aspeed P2A control driver

2019-02-27 Thread Patrick Venture
On Tue, Feb 26, 2019 at 9:53 PM Andrew Jeffery wrote: > > > > On Wed, 27 Feb 2019, at 13:04, Patrick Venture wrote: > > On Tue, Feb 26, 2019 at 5:05 PM Andrew Jeffery wrote: > > > > > > > > > > > > On Wed, 27 Feb 2019, at 08:12, Patrick

Re: [PATCH 2/2] drivers/misc: Add Aspeed P2A control driver

2019-02-27 Thread Patrick Venture
On Tue, Feb 26, 2019 at 9:05 PM Florian Fainelli wrote: > > > > On 2/21/2019 2:25 PM, Patrick Venture wrote: > > The ASPEED AST2400, and AST2500 in some configurations include a > > PCI-to-AHB MMIO bridge. This bridge allows a server to read and write > > in the BMC

Re: [PATCH 2/2] drivers/misc: Add Aspeed P2A control driver

2019-02-26 Thread Patrick Venture
On Tue, Feb 26, 2019 at 5:05 PM Andrew Jeffery wrote: > > > > On Wed, 27 Feb 2019, at 08:12, Patrick Venture wrote: > > On Sun, Feb 24, 2019 at 5:26 PM Andrew Jeffery wrote: > > > > > > On Fri, 22 Feb 2019, at 08:55, Patrick Venture wrote: > > &

[PATCH v3 2/2] drivers/misc: Add Aspeed P2A control driver

2019-02-26 Thread Patrick Venture
write to all of it. Signed-off-by: Patrick Venture --- Changes for v3: - Deleted unused read and write methods. Changes for v2: - Dropped unused reads. - Moved call to disable bridge to before registering device. - Switch from using regs to using a syscon regmap. <<< IN PROGRESS

Re: [PATCH v2 2/2] drivers/misc: Add Aspeed P2A control driver

2019-02-26 Thread Patrick Venture
On Tue, Feb 26, 2019 at 3:36 PM Patrick Venture wrote: > > The ASPEED AST2400, and AST2500 in some configurations include a > PCI-to-AHB MMIO bridge. This bridge allows a server to read and write > in the BMC's physical address space. This feature is especially useful > when us

[PATCH v2 2/2] drivers/misc: Add Aspeed P2A control driver

2019-02-26 Thread Patrick Venture
write to all of it. Signed-off-by: Patrick Venture Change-Id: I56da837e061556bb1e57d0aca0678d1cab0561f2 --- Changes for v2: - Dropped unused reads. - Moved call to disable bridge to before registering device. - Switch from using regs to using a syscon regmap. <<< IN PROGRESS - Updated t

[PATCH v2 1/2] dt-bindings: misc: aspeed-p2a-ctrl: add support

2019-02-26 Thread Patrick Venture
Document the ast2400, ast2500 PCI-to-AHB bridge control driver bindings. Signed-off-by: Patrick Venture Change-Id: Ic89a2df0f555dee10598f87537ee004e82d13acd --- Changes for v2: - Added comment about syscon required parameter. --- .../bindings/misc/aspeed-p2a-ctrl.txt | 32

Re: [PATCH 2/2] drivers/misc: Add Aspeed P2A control driver

2019-02-26 Thread Patrick Venture
On Tue, Feb 26, 2019 at 2:20 PM Andrew Jeffery wrote: > > > > On Wed, 27 Feb 2019, at 08:26, Patrick Venture wrote: > > On Tue, Feb 26, 2019 at 1:42 PM Patrick Venture wrote: > > > > > > On Sun, Feb 24, 2

Re: [PATCH 2/2] drivers/misc: Add Aspeed P2A control driver

2019-02-26 Thread Patrick Venture
On Tue, Feb 26, 2019 at 1:42 PM Patrick Venture wrote: > > On Sun, Feb 24, 2019 at 5:26 PM Andrew Jeffery wrote: > > > > On Fri, 22 Feb 2019, at 08:55, Patrick Venture wrote: > > > The ASPEED AST2400, and AST2500 in some configurations include a > > > PCI-to-

Re: [PATCH 2/2] drivers/misc: Add Aspeed P2A control driver

2019-02-26 Thread Patrick Venture
On Sun, Feb 24, 2019 at 5:26 PM Andrew Jeffery wrote: > > On Fri, 22 Feb 2019, at 08:55, Patrick Venture wrote: > > The ASPEED AST2400, and AST2500 in some configurations include a > > PCI-to-AHB MMIO bridge. This bridge allows a server to read and write > > in the BMC

[PATCH 1/2] dt-bindings: misc: aspeed-p2a-ctrl: add support

2019-02-21 Thread Patrick Venture
Document the ast2400, ast2500 PCI-to-AHB bridge control driver bindings. Signed-off-by: Patrick Venture --- .../bindings/misc/aspeed-p2a-ctrl.txt | 33 +++ 1 file changed, 33 insertions(+) create mode 100644 Documentation/devicetree/bindings/misc/aspeed-p2a-ctrl.txt

[PATCH 2/2] drivers/misc: Add Aspeed P2A control driver

2019-02-21 Thread Patrick Venture
SPI}, + {0x8000, 0x, SCU2C_DRAM}, + } +}; + +static const struct of_device_id aspeed_p2a_ctrl_match[] = { + { .compatible = "aspeed,ast2400-p2a-ctrl", + .data = _model_data }, + { .compatible = "aspeed,ast2500-p2a-ctrl", + .

[PATCH v4] drivers/misc: (aspeed-lpc-snoop): Add ast2400 to compat

2017-07-06 Thread Patrick Venture
This driver can be used on the aspeed ast2400 with minor modifications. Tested: ast2400 on quanta-q71l Signed-off-by: Patrick Venture <vent...@google.com> --- v4: fix the 2400/2500 data as they were backwards. v3: added .data object to determine behavior difference between a

[PATCH v4] drivers/misc: (aspeed-lpc-snoop): Add ast2400 to compat

2017-07-06 Thread Patrick Venture
This driver can be used on the aspeed ast2400 with minor modifications. Tested: ast2400 on quanta-q71l Signed-off-by: Patrick Venture --- v4: fix the 2400/2500 data as they were backwards. v3: added .data object to determine behavior difference between ast2400 and ast2500. v2: added aspeed

Re: [PATCH v3] drivers/misc: (aspeed-lpc-snoop): Add ast2400 to compat

2017-07-06 Thread Patrick Venture
On Thu, Jul 6, 2017 at 10:00 AM, Patrick Venture <vent...@google.com> wrote: > On Wed, Jul 5, 2017 at 2:51 PM, Patrick Venture <vent...@google.com> wrote: >> This driver can be used on the aspeed ast2400 with minor >> modifications. >> >> Tested: ast2400 on q

Re: [PATCH v3] drivers/misc: (aspeed-lpc-snoop): Add ast2400 to compat

2017-07-06 Thread Patrick Venture
On Thu, Jul 6, 2017 at 10:00 AM, Patrick Venture wrote: > On Wed, Jul 5, 2017 at 2:51 PM, Patrick Venture wrote: >> This driver can be used on the aspeed ast2400 with minor >> modifications. >> >> Tested: ast2400 on quanta-q71l >> >> Signed-off-by: Pat

Re: [PATCH v3] drivers/misc: (aspeed-lpc-snoop): Add ast2400 to compat

2017-07-06 Thread Patrick Venture
On Wed, Jul 5, 2017 at 2:51 PM, Patrick Venture <vent...@google.com> wrote: > This driver can be used on the aspeed ast2400 with minor > modifications. > > Tested: ast2400 on quanta-q71l > > Signed-off-by: Patrick Venture <vent...@google.com> > --- > v3: adde

Re: [PATCH v3] drivers/misc: (aspeed-lpc-snoop): Add ast2400 to compat

2017-07-06 Thread Patrick Venture
On Wed, Jul 5, 2017 at 2:51 PM, Patrick Venture wrote: > This driver can be used on the aspeed ast2400 with minor > modifications. > > Tested: ast2400 on quanta-q71l > > Signed-off-by: Patrick Venture > --- > v3: added .data object to determine behavior di

[PATCH v3] drivers/misc: (aspeed-lpc-snoop): Add ast2400 to compat

2017-07-05 Thread Patrick Venture
This driver can be used on the aspeed ast2400 with minor modifications. Tested: ast2400 on quanta-q71l Signed-off-by: Patrick Venture <vent...@google.com> --- v3: added .data object to determine behavior difference between ast2400 and ast2500. v2: added aspeed-g5 area because ast2400 d

[PATCH v3] drivers/misc: (aspeed-lpc-snoop): Add ast2400 to compat

2017-07-05 Thread Patrick Venture
This driver can be used on the aspeed ast2400 with minor modifications. Tested: ast2400 on quanta-q71l Signed-off-by: Patrick Venture --- v3: added .data object to determine behavior difference between ast2400 and ast2500. v2: added aspeed-g5 area because ast2400 doesn't use those bits

Re: [PATCH v2] drivers/misc: (aspeed-lpc-snoop): Add ast2400 to compat

2017-07-05 Thread Patrick Venture
On Wed, Jul 5, 2017 at 12:43 PM, Arnd Bergmann <a...@arndb.de> wrote: > On Wed, Jul 5, 2017 at 9:04 PM, Patrick Venture <vent...@google.com> wrote: >> This driver can be used on the aspeed ast2400 with minor >> modifications. >> >> Tested: ast2400 on q

Re: [PATCH v2] drivers/misc: (aspeed-lpc-snoop): Add ast2400 to compat

2017-07-05 Thread Patrick Venture
On Wed, Jul 5, 2017 at 12:43 PM, Arnd Bergmann wrote: > On Wed, Jul 5, 2017 at 9:04 PM, Patrick Venture wrote: >> This driver can be used on the aspeed ast2400 with minor >> modifications. >> >> Tested: ast2400 on quanta-q71l >> >> Signed-off-by: Patrick

[PATCH v2] drivers/misc: (aspeed-lpc-snoop): Add ast2400 to compat

2017-07-05 Thread Patrick Venture
This driver can be used on the aspeed ast2400 with minor modifications. Tested: ast2400 on quanta-q71l Signed-off-by: Patrick Venture <vent...@google.com> --- v2: added aspeed-g5 area because ast2400 doesn't use those bits. also updated commit message. --- drivers/misc/aspeed-lpc-s

[PATCH v2] drivers/misc: (aspeed-lpc-snoop): Add ast2400 to compat

2017-07-05 Thread Patrick Venture
This driver can be used on the aspeed ast2400 with minor modifications. Tested: ast2400 on quanta-q71l Signed-off-by: Patrick Venture --- v2: added aspeed-g5 area because ast2400 doesn't use those bits. also updated commit message. --- drivers/misc/aspeed-lpc-snoop.c | 4 +++- 1 file

Re: [PATCH linux dev-4.10] drivers/misc: (aspeed-lpc-snoop): Add ast2400 to compat

2017-07-05 Thread Patrick Venture
On Wed, Jul 5, 2017 at 10:52 AM, Rob Lippert <rob...@gmail.com> wrote: > On Wed, Jul 5, 2017 at 10:48 AM, Patrick Venture <vent...@google.com> wrote: >> On Wed, Jul 5, 2017 at 10:33 AM, Rob Lippert <rob...@gmail.com> wrote: >>> I checked the datasheets when I

Re: [PATCH linux dev-4.10] drivers/misc: (aspeed-lpc-snoop): Add ast2400 to compat

2017-07-05 Thread Patrick Venture
On Wed, Jul 5, 2017 at 10:52 AM, Rob Lippert wrote: > On Wed, Jul 5, 2017 at 10:48 AM, Patrick Venture wrote: >> On Wed, Jul 5, 2017 at 10:33 AM, Rob Lippert wrote: >>> I checked the datasheets when I wrote this and ast2400 does not have >>> the (undocumented

Re: [PATCH linux dev-4.10] drivers/misc: (aspeed-lpc-snoop): Add ast2400 to compat

2017-07-05 Thread Patrick Venture
is in the datasheet a post-code control register set, but I haven't explored configuring them or whether someone has written the fifo driver for them. > > -Rob > > On Tue, Jul 4, 2017 at 8:45 AM, Patrick Venture <vent...@google.com> wrote: >> This driver can be used on

Re: [PATCH linux dev-4.10] drivers/misc: (aspeed-lpc-snoop): Add ast2400 to compat

2017-07-05 Thread Patrick Venture
st-code control register set, but I haven't explored configuring them or whether someone has written the fifo driver for them. > > -Rob > > On Tue, Jul 4, 2017 at 8:45 AM, Patrick Venture wrote: >> This driver can be used on the aspeed ast2400. >> >> Tested: ast2400 on

[PATCH] drivers/misc: (aspeed-lpc-snoop): Add ast2400 to compat

2017-07-04 Thread Patrick Venture
This driver can be used on the aspeed ast2400. Tested: ast2400 on quanta-q71l Signed-off-by: Patrick Venture <vent...@google.com> --- drivers/misc/aspeed-lpc-snoop.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/misc/aspeed-lpc-snoop.c b/drivers/misc/aspeed-lpc-snoop.c

[PATCH] drivers/misc: (aspeed-lpc-snoop): Add ast2400 to compat

2017-07-04 Thread Patrick Venture
This driver can be used on the aspeed ast2400. Tested: ast2400 on quanta-q71l Signed-off-by: Patrick Venture --- drivers/misc/aspeed-lpc-snoop.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/misc/aspeed-lpc-snoop.c b/drivers/misc/aspeed-lpc-snoop.c index 593905565b74

Re: [PATCH linux dev-4.10] drivers/misc: (aspeed-lpc-snoop): Add ast2400 to compat

2017-07-04 Thread Patrick Venture
On Tue, Jul 4, 2017 at 8:50 AM, Greg KH <gre...@linuxfoundation.org> wrote: > On Tue, Jul 04, 2017 at 08:45:03AM -0700, Patrick Venture wrote: >> This driver can be used on the aspeed ast2400. >> >> Tested: ast2400 on quanta-q71l >> >> Signed-off-

  1   2   >