t; > Patch #4 adds the initial version of device tree for Facebook Galaxy100
> > BMC.
>
> Nice. They look good to me.
>
> Reviewed-by: Joel Stanley
>
> Is there another person familiar with the design you would like to
> review before I merge?
Also,
Reviewed-by: Patrick Williams
--
Patrick Williams
signature.asc
Description: PGP signature
uot; partition' size is updated to 4MB to be consistent
> with other Facebook OpenBMC platforms.
>
> Signed-off-by: Tao Ren
> ---
> .../boot/dts/aspeed-bmc-facebook-minipack.dts | 47 ++-
> 1 file changed, 45 insertions(+), 2 deletions(-)
>
Reviewed-
> ---
> arch/arm/boot/dts/aspeed-bmc-facebook-yamp.dts | 17 +
> 1 file changed, 17 insertions(+)
>
Reviewed-by: Patrick Williams
--
Patrick Williams
signature.asc
Description: PGP signature
> ---
> arch/arm/boot/dts/aspeed-bmc-facebook-cmm.dts | 17 +
> 1 file changed, 17 insertions(+)
>
Reviewed-by: Patrick Williams
--
Patrick Williams
signature.asc
Description: PGP signature
en
> ---
> .../boot/dts/ast2500-facebook-netbmc-common.dtsi| 13 -
> 1 file changed, 13 deletions(-)
>
Reviewed-by: Patrick Williams
--
Patrick Williams
signature.asc
Description: PGP signature
EMP | PMBUS_HAVE_STATUS_TEMP;
> > if (config & ADM1278_VIN_EN)
> > info->func[0] |= PMBUS_HAVE_VIN;
> > break;
> >
>
--
Patrick Williams
signature.asc
Description: PGP signature
need a device-tree entry for this?
> if (config & ADM1278_TEMP1_EN)
> info->func[0] |=
> PMBUS_HAVE_TEMP | PMBUS_HAVE_STATUS_TEMP;
> --
> 2.7.4
>
--
Patrick Williams
signature.asc
Description: PGP signature
ot/dts/aspeed-bmc-opp-nicole.dts | 326
> 2 files changed, 327 insertions(+)
> create mode 100644 arch/arm/boot/dts/aspeed-bmc-opp-nicole.dts
>
Reviewed-by: Patrick Williams
--
Patrick Williams
signature.asc
Description: PGP signature
Thanks for the review Andy.
On Tue, Oct 01, 2019 at 07:29:13PM +0300, Andy Shevchenko wrote:
>
>
> On Tue, Oct 01, 2019 at 10:59:59AM -0500, Patrick Williams wrote:
> There are quite a few people in the Cc list. I'm not sure they all are
> interested in this. I deliberately dr
addressable EEPROM.
Signed-off-by: Patrick Williams
---
drivers/i2c/i2c-slave-eeprom.c | 14 +++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/drivers/i2c/i2c-slave-eeprom.c b/drivers/i2c/i2c-slave-eeprom.c
index efee56106251..65419441313b 100644
--- a/drivers/i2c/i2c
The i2c-slave-eeprom driver emulates at24 class eeprom devices,
which come initialized with all 1s. Do the same in the software
emulation.
Signed-off-by: Patrick Williams
---
drivers/i2c/i2c-slave-eeprom.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/i2c/i2c-slave-eeprom.c b
With the i2c-pxa driver migrated to the standard i2c-slave
APIs, the custom APIs and structures are no longer needed
or used. Remove them.
Signed-off-by: Patrick Williams
---
drivers/i2c/busses/i2c-pxa.c | 1 -
include/linux/i2c-pxa.h | 18 --
include
-slave APIs so that
existing drivers, such as the i2c-slave-eeprom, can be used.
This has been tested with a Marvell EspressoBin, using i2c-pxa and
i2c-slave-eeprom, acting as a slave, and a RaspeberryPi 3, using the
at24 driver, acting as a master.
Signed-off-by: Patrick Williams
---
drivers
(ex. i2c-slave-eeprom).
Patrick Williams (2):
i2c: pxa: migrate to new i2c_slave APIs
i2c: pxa: remove unused i2c-slave APIs
drivers/i2c/busses/Kconfig| 1 +
drivers/i2c/busses/i2c-pxa.c | 75 +--
include/linux/i2c-pxa.h | 18
The configuration registers for the LED group have inverted
polarity, which puts the GPIO into open-drain state when used in
GPIO mode. Switch to '0' for GPIO and '1' for LED modes.
Fixes: 87466ccd9401 ("pinctrl: armada-37xx: Add pin controller support for
Armada 37xx")
Signed-off-b
the register / offset calculation to also adjust the offset.
Fixes: 5715092a458c ("pinctrl: armada-37xx: Add gpio support")
Signed-off-by: Patrick Williams
Acked-by: Gregory CLEMENT
Cc:
---
drivers/pinctrl/mvebu/pinctrl-armada-37xx.c | 18 +-
1 file changed, 9 insertions(+), 9
On Tue, Jun 25, 2019 at 03:38:59PM +0200, Gregory CLEMENT wrote:
> First you can add my
> Acked-by: Gregory CLEMENT
Thanks for the review Gregory.
> Then as the second patch is a fix, you should add the fix tag: "Fixes:
> 5715092a458c ("pinctrl: armada-37xx: Add gpio support") " as well as the
aemon that can, and
does, share most of its providers with the host-side daemon.
--
Patrick Williams
signature.asc
Description: Digital signature
aemon that can, and
does, share most of its providers with the host-side daemon.
--
Patrick Williams
signature.asc
Description: Digital signature
ake this. Go poke your fellow ppc people to do some work
> here, it shouldn't be up to me to do it for them :(
>
> thanks,
>
> greg k-h
We are actively using this driver in the OpenBMC project and have
exercised it in booting two different server variants (different
motherboards
fellow ppc people to do some work
> here, it shouldn't be up to me to do it for them :(
>
> thanks,
>
> greg k-h
We are actively using this driver in the OpenBMC project and have
exercised it in booting two different server variants (different
motherboards entirely).
Tested-by:
21 matches
Mail list logo
