On Wed, Mar 17, 2021 at 9:27 AM Yang Li wrote:
>
> This fixes the following sparse warnings:
> drivers/gpu/drm/gma500/psb_drv.c:303:56: warning: Using plain integer as
> NULL pointer
>
> Reported-by: Abaci Robot
> Signed-off-by: Yang Li
Applied to drm-misc-next
Thanks
Patrik
> ---
> drivers/
On Fri, Feb 5, 2021 at 12:07 PM Andy Shevchenko
wrote:
>
> On Thu, Feb 4, 2021 at 11:04 AM Andy Shevchenko
> wrote:
> >> Today's linux-next merge of the drivers-x86 tree got a conflict in:
> >
> > Thanks. I already asked Patrik yesterday day if DRM missed to pull an
> > immutable tag I provided.
On Sat, Jan 30, 2021 at 7:47 PM Joe Perches wrote:
>
> On Mon, 2020-08-24 at 21:56 -0700, Joe Perches wrote:
> > Use semicolons and braces.
>
> Ping?
This entire file is going away so perhaps just drop the patch to avoid
a conflict.
-Patrik
>
> > Signed-off-by: Joe Perches
> > ---
> > drivers
On Mon, Jan 18, 2021 at 1:22 PM Felipe Balbi wrote:
>
>
> Hi,
>
> Greg Kroah-Hartman writes:
> >> Al Cooper writes:
> >> > The BDC PCI driver was only used for design verification with
> >> > an PCI/FPGA board. The board no longer exists and is not in use
> >> > anywhere. All instances of this c
On Tue, Oct 27, 2020 at 5:50 PM Arnd Bergmann wrote:
>
> On Tue, Oct 27, 2020 at 10:54 AM Patrik Jakobsson
> wrote:
> > On Tue, Oct 27, 2020 at 10:33 AM Daniel Vetter wrote:
> > > On Mon, Oct 26, 2020 at 08:41:04PM +0100, Arnd Bergmann wrote:
> > > > From
On Tue, Oct 27, 2020 at 10:33 AM Daniel Vetter wrote:
>
> On Mon, Oct 26, 2020 at 08:41:04PM +0100, Arnd Bergmann wrote:
> > From: Arnd Bergmann
> >
> > gcc -Wextra notices that one of the fields in psbfb_roll_ops has two
> > initializers:
> >
> > drivers/gpu/drm/gma500/framebuffer.c:185:20: warn
On Wed, Aug 5, 2020 at 10:59 PM wrote:
>
> From: Tom Rix
>
> Reviewing this block of code in cdv_intel_dp_init()
>
> ret = cdv_intel_dp_aux_native_read(gma_encoder, DP_DPCD_REV, ...
>
> cdv_intel_edp_panel_vdd_off(gma_encoder);
> if (ret == 0) {
> /* if this fails, presume the device is a
On Mon, Jun 22, 2020 at 10:45 PM Denis Efremov wrote:
>
> psb_accel_2d_copy() checks direction PSB_2D_COPYORDER_BR2TL twice.
> Based on psb_accel_2d_copy_direction() results, PSB_2D_COPYORDER_TL2BR
> should be checked instead in the second direction check.
>
> Fixes: 4d8d096e9ae8 ("gma500: introdu
ock.m1' may be used
> uninitialized in this function
> drivers/gpu/drm/gma500/oaktrail_crtc.c:208: warning: 'clock.n' may be used
> uninitialized in this function
>
> This adds an initialization at declaration time to avoid the warning
> and make it well-defined on
of no HW, but buildbot is happy with this series at
> least. A branch can be found here:
Not sure anybody have hardware to test mdfld + tc358765. Perhaps some
smartphone exists but I've never seen one.
FWIW, for the small gma500 change you have my:
Acked-by: Patrik Jakobsson
Cheers
>
re's a hard rule about
that. I'll fix it up and take it through drm-misc-next.
Signed-off-by: Patrik Jakobsson
> ---
> drivers/gpu/drm/gma500/accel_2d.c |4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/gma500/accel_2d.c
>
x27;
> [-Werror=unused-variable]
>
> This removes them as well.
>
> Fixes: 94d7fb4982d2 ("gpu: drm: gma500: remove dead code")
> Signed-off-by: Arnd Bergmann
Thanks, I'll take this through drm-misc
Signed-off-by: Patrik Jakobsson
> ---
> drivers/gpu/drm/g
On Fri, May 19, 2017 at 2:28 PM, Patrik Jakobsson
wrote:
> On Fri, May 19, 2017 at 11:19 AM, Gustavo A. R. Silva
> wrote:
>> Local variable use_gct is assigned to a constant value and it is never
>> updated again. Remove this variable and the dead code it guards.
>>
On Fri, May 19, 2017 at 11:19 AM, Gustavo A. R. Silva
wrote:
> Local variable use_gct is assigned to a constant value and it is never
> updated again. Remove this variable and the dead code it guards.
>
> Addresses-Coverity-ID: 145690
> Signed-off-by: Gustavo A. R. Silva
I believe the first vers
On Tue, Feb 28, 2017 at 1:55 PM, Joe Perches wrote:
> Use a more common logging style.
>
> Miscellanea:
>
> o Coalesce formats and realign arguments
> o Neaten a few macros now using pr_
>
> Signed-off-by: Joe Perches
For the gma500 changes:
Acked-by: Patrik Jakobsso
On Tue, Oct 11, 2016 at 10:15 AM, Daniel Vetter wrote:
> On Mon, Oct 10, 2016 at 07:22:47AM +0530, Shyam Saini wrote:
>> On Mon, 2016-10-10 at 01:46 +0200, Patrik Jakobsson wrote:
>> > On Mon, Oct 10, 2016 at 1:07 AM, Shyam Saini
>> > wrote:
>> > >
>>
On Mon, Oct 10, 2016 at 1:07 AM, Shyam Saini wrote:
> Replace explicit computation of vma page count by a call to
> vma_pages()
Hi, I already have this patch in the "queue" from:
Muhammad Falak R Wani
Will include that one when I get around to sending out a PR.
Thanks
Patrik
>
> Signed-off-by
On Tue, Sep 20, 2016 at 2:08 PM, Jani Nikula
wrote:
> On Tue, 20 Sep 2016, Dan Carpenter wrote:
>> Don't be a dummy... This is easy to review an it fixes a bug.
In this particular case it might not be clear that an unknown GCT
version causes a complete GCT failure so both messages are useful.
On Tue, Jun 7, 2016 at 4:07 PM, Gustavo Padovan wrote:
> From: Gustavo Padovan
>
> Replace the legacy drm_vblank_{on,off}() with the new helper functions.
>
> Signed-off-by: Gustavo Padovan
Acked-by: Patrik Jakobsson
> ---
> drivers/gpu/drm/gma500/gma_display.c | 2 +-
On Sat, May 21, 2016 at 3:21 PM, Muhammad Falak R Wani
wrote:
> Replace explicit computation of vma page count by a call to
> vma_pages()
>
> Signed-off-by: Muhammad Falak R Wani
Thanks, queued for gma500-next
> ---
> drivers/gpu/drm/gma500/framebuffer.c | 2 +-
> 1 file changed, 1 insertion(+
On Wed, May 18, 2016 at 10:31 PM, Heinrich Schuchardt
wrote:
> Only dereference sender after checking if sender is NULL.
Hi Heinrich
I think we had a patch that did something similar a while ago. Don't
remember what happened to it. We do check for !sender right before
calling this function (at o
On Thu, Apr 7, 2016 at 5:52 PM, Sudip Mukherjee
wrote:
> On Wednesday 09 December 2015 05:50 PM, Patrik Jakobsson wrote:
>>
>> On Wed, Dec 9, 2015 at 12:53 PM, Sudip Mukherjee
>> wrote:
>>>
>>> On Thu, Oct 08, 2015 at 06:17:48PM +0530, Sudip Mukherjee wro
On Wed, Mar 23, 2016 at 2:28 AM, One Thousand Gnomes
wrote:
> On Tue, 22 Mar 2016 16:40:18 -0700
> Joe Perches wrote:
>
>> On Tue, 2016-03-22 at 22:49 +, Colin King wrote:
>> > From: Colin Ian King
>> >
>> > There is a missing comma between two strings in the dsi_errors[]
>> > array initiali
git-send-email-sudipm.mukher...@gmail.com
Acked-by: Patrik Jakobsson
Signed-off-by: Daniel Vetter
Thanks
Patrik
On Thu, Feb 18, 2016 at 3:58 PM, Daniel Wagner
wrote:
> 9a69a9ac20f7 ("drm: Make the connector dpms callback
> return a value, v2.") wants mdfld_dsi_connector
does is: if (mode == connector->dpms)
>
> Signed-off-by: Sudip Mukherjee
Looks good, thanks.
Signed-off-by: Patrik Jakobsson
> ---
> drivers/gpu/drm/gma500/mdfld_dsi_output.c | 12 +---
> 1 file changed, 1 insertion(+), 11 deletions(-)
>
> diff --git a/drivers/
tire function can be
> replaced by a simple if call.
>
> Signed-off-by: Alan Cox
Signed-off-by: Patrik Jakobsson
> ---
> drivers/gpu/drm/gma500/framebuffer.c | 20
> 1 file changed, 4 insertions(+), 16 deletions(-)
>
> diff --git a/drivers/gpu/d
ollow the execution path then we should be freeing
>> backing after we have released the helper. So remove the one which frees
>> backing before the helper is released.
>> While at it the error labels are also renamed to give a meaningful
>> name.
>>
>> Sign
Signed-off-by: Patrik Jakobsson
---
MAINTAINERS | 8
1 file changed, 8 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 0e1abe8..c7decf7 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3368,6 +3368,14 @@ S: Maintained
F: drivers/gpu/drm/imx/
F: Documentation
ased the helper. So remove the one which frees
> backing before the helper is released.
> While at it the error labels are also renamed to give a meaningful
> name.
>
> Cc: Patrik Jakobsson
> Signed-off-by: Sudip Mukherjee
> ---
>
> Hi Patrik,
> If you donot like the la
On Fri, Oct 2, 2015 at 5:56 PM, Sudip Mukherjee
wrote:
> On Thu, Oct 01, 2015 at 07:07:33PM +0200, Patrik Jakobsson wrote:
>> On Wed, Sep 30, 2015 at 8:12 AM, Sudip Mukherjee
>> wrote:
>> > On Tue, Sep 29, 2015 at 03:20:35PM +0200, Patrik Jakobsson wrote:
>> >
On Wed, Sep 30, 2015 at 8:12 AM, Sudip Mukherjee
wrote:
> On Tue, Sep 29, 2015 at 03:20:35PM +0200, Patrik Jakobsson wrote:
>> On Thu, Sep 24, 2015 at 5:57 PM, Sudip Mukherjee
>> wrote:
>> > On Wed, Sep 09, 2015 at 06:20:40PM +0530, Sudip Mukherjee wrote:
>> >>
On Thu, Sep 24, 2015 at 5:57 PM, Sudip Mukherjee
wrote:
> On Wed, Sep 09, 2015 at 06:20:40PM +0530, Sudip Mukherjee wrote:
>> If backing->stolen is true then we were freeing backing by calling
>> psb_gtt_free_range() but we called it again after unlocking the mutex.
>> Lets make it NULL after free
On Mon, May 11, 2015 at 5:54 PM, Nicholas Krause wrote:
>
>
> On May 11, 2015 4:24:01 AM EDT, Patrik Jakobsson
> wrote:
>>On Sun, May 10, 2015 at 9:50 PM, Nicholas Krause
>>wrote:
>>>
>>>
>>> On May 10, 2015 3:45:36 PM EDT, patrik.r.jakobs...
wrote:
>>> > On Sun, May 10, 2015 at 01:48:14PM -0400, nick wrote:
>>> >>
>>> >>
>>> >> On 2015-05-10 01:04 PM, patrik.r.jakobs...@gmail.com wrote:
>>> >>> On Tue, May 05, 2015 at 11:17:07AM -0400, nick wrote:
>>> >
On Tue, May 5, 2015 at 12:29 AM, Nicholas Krause wrote:
> This removes the deprecated functions,i2c_dp_aux_add_bus and
> i2c_dp_aux_prepare_bus and the only call in the function,
> cdv_intel_dp_i2c_init to i2c_dp_aux_add_bus respectfully.
> The call and use of these functions is now replaced along
On Thu, Jan 1, 2015 at 5:55 PM, Rickard Strandqvist
wrote:
> Remove the function psb_get_default_pd_addr() that is not used anywhere.
>
> This was partially found by using a static code analysis program called
> cppcheck.
>
> Signed-off-by: Rickard Strandqvist
Hej Rickard
I'd like to keep that
On Sat, Dec 27, 2014 at 4:37 PM, Fabian Frederick wrote:
> Fix sparse warning:
> drivers/gpu/drm/gma500/psb_drv.c:
> 328:56: warning: Using plain integer as NULL pointer
>
> Signed-off-by: Fabian Frederick
Reviewed-by: Patrik Jakobsson
> ---
> drivers/gpu/drm/gma500/
On Sun, Nov 30, 2014 at 3:24 AM, Nicholas Krause wrote:
> Removes unneeeded struct *lvds_i2c_bus of type, psb_intel_i2c_chan as this
> struct
> is no needed due to never being used in the header file, psb_drv.h and
> therefore
> should be removed from this header file.
>
> Signed-off-by: Nichola
On Sat, Nov 22, 2014 at 2:45 PM, nick wrote:
> Greetings again David and other maintainers,
> I am wondering if I can remove the following code below my message in
> psb_drv.h as you state it's unneeded in a TODO.
> Cheers Nick
> /* TODO: To get rid of */
> #define PSB_TT_PRIV0_LIMIT (256*1
On Mon, May 5, 2014 at 8:28 PM, Matthew Garrett
wrote:
> On Mon, 2014-05-05 at 16:49 +0200, Patrik Jakobsson wrote:
>> Hi Matthew,
>>
>> This seems to be in good shape. Do you have anything to add?
>> If not, can you pick this patch up through platform-drivers-x86?
>
Hi Matthew,
This seems to be in good shape. Do you have anything to add?
If not, can you pick this patch up through platform-drivers-x86?
Thanks
Patrik
On Tue, Apr 29, 2014 at 4:21 PM, Patrik Jakobsson
wrote:
> This driver takes control over the LP8550 backlight driver chip found
> in t
OK AIR 6,X BACKLIGHT DRIVER
+M: Patrik Jakobsson
+L: platform-driver-...@vger.kernel.org
+S: Maintained
+F: drivers/platform/x86/mba6x_bl.c
+
MACVLAN DRIVER
M: Patrick McHardy
L: net...@vger.kernel.org
diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
ind
On Tue, Apr 29, 2014 at 1:10 PM, Hans de Goede wrote:
>
> Hi,
>
> Why is this patch an RFC? If it is ready for upstreaming please drop
> the RFC prefix when you post the next version.
I'll do that
> On 04/27/2014 10:56 PM, Patrik Jakobsson wrote:
> > This driver
-by: Patrik Jakobsson
---
MAINTAINERS | 6 +
drivers/platform/x86/Kconfig| 13 ++
drivers/platform/x86/Makefile | 1 +
drivers/platform/x86/mba6x_bl.c | 351
4 files changed, 371 insertions(+)
create mode 100644 drivers
Hi Andrew and CCs
I've put together (rather quickly) a driver for directly handling the backlight
driver chip (LM8550) on the 2013 MacBook Air. It is needed to work around a bug
(likely in firmware) that occurs after suspend/resume. See:
https://bugs.freedesktop.org/show_bug.cgi?id=67454
This se
On Mon, Jan 6, 2014 at 4:02 PM, Rashika Kheria wrote:
> Mark function cdv_intel_fixed_panel_mode() as static in
> drm/gma500/cdv_intel_dp.c because it is not used outside this file.
>
> This eliminates the following warning in drm/gma500/cdv_intel_dp.c:
> drivers/gpu/drm/gma500/cdv_intel_dp.c:680:
On Thu, Nov 14, 2013 at 2:52 PM, One Thousand Gnomes
wrote:
>> My question now is, is it a bug in the driver or in the VGA Bios?
>>
>> I´ve checked the VGA bios and did a hex dump but there is really no "$VBT"
>> string.
>> On an Atom Gen1 CPU with intel GMA500 Graphic there is the string in the
On Wed, Nov 13, 2013 at 4:49 PM, Holger Schurig wrote:
> Kernel: 3.10.19
>
> From time to time, when I booted, I had a completely dark screen (with
> kernel command line quiet) and a non-blinking cursor. I wondered if
> that was perhaps gma500. So I turned on various debug checks. Then
> I've got
; -#endif
> +#endif
> }
>
> void gma_backlight_set(struct drm_device *dev, int v)
> @@ -67,7 +67,7 @@ void gma_backlight_set(struct drm_device *dev, int v)
> dev_priv->backlight_device->props.brightness = v;
> do_gma_backlight_set(dev);
> }
> -#endif
> +#end
On Fri, Sep 20, 2013 at 3:56 PM, Dave Jones wrote:
> This code appears to be calling psb_gtt_free_range twice with the same args.
> (The second call didn't appear in the diff output, it's right after the
> mutex_unlock)
>
> Spotted with Coverity, not tested due to lack of hardware.
>
> Signed-off
On Wed, May 8, 2013 at 10:37 AM, Artem S. Tashkinov wrote:
>>I think this is the official statement from Intel on the SATA issue:
>>http://newsroom.intel.com/community/intel_newsroom/blog/2011/01/31/intel-identifies-chipset-design-error-implementing-solution
>
> My motherboard has a new fixed B3 r
On Wed, May 8, 2013 at 12:02 AM, Bjorn Helgaas wrote:
> On Tue, May 7, 2013 at 2:48 PM, Patrik Jakobsson
> wrote:
>> On Tue, May 7, 2013 at 10:20 PM, Bjorn Helgaas wrote:
>>>> I'm not sure if reading /proc/mtrr actually reads the registers out of
>>>&
a ticking bomb.
I have a P8H67-V motherboard but I haven't seen any suspend related issues.
If this is totally unrelated I'm sorry for wasting your time. Just thought it
might be good to know.
Thanks
Patrik Jakobsson
--
To unsubscribe from this list: send the line "unsubscribe lin
een section to xorg.conf with
DefaultDepth 16 running the fbdev driver. That, at least tries to do the right
thing but gma500 fails in setting it up. On the other hand, you managed to set
800x480 at 16bbp. Have you tried the vesafb driver? Might do a better job.
-Patrik Jakobsson
--
To unsubscribe f
On Wed, Apr 10, 2013 at 2:37 PM, Xiong Zhou wrote:
> From: Xiong Zhou
>
> Last version of this patch is not clear enough and X86 duplicated.
>
> This patch fixes build failure of v3.9-rc5 and rc6.
> When config ACPI_VIDEO as m, DRM_GMA500 as y, here comes the failure.
> GMA5/600 needs acpi_video
On Tue, Apr 9, 2013 at 8:35 AM, Xiong Zhou wrote:
> From: Xiong Zhou
>
> This patch fixes build failure of v3.9-rc5.
> When config ACPI_VIDEO as m, DRM_GMA500 as y, here comes the failure.
> gma5/600 needs acpi_video just like nouveau.
>
> Failure message:
> drivers/built-in.o: In function `psb_d
bl));
> dev_priv->lvds_bl = lvds_bl;
> }
>
> --
> 1.7.9.5
>
> --
Your patch has been applied to:
https://github.com/patjak/drm-gma500.git gma500-next
Thanks
Patrik Jakobsson
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the b
-876,7 +876,6 @@ extern const struct psb_ops cdv_chip_ops;
> #define PSB_D_MSVDX (1 << 9)
> #define PSB_D_TOPAZ (1 << 10)
>
> -extern int drm_psb_no_fb;
> extern int drm_idle_check_interval;
>
> /*
> --
> 1.7.12.4.dirty
> --
Your patch has been ap
drm_connector_init(dev, connector,
>&cdv_hdmi_connector_funcs,
> --
Your patch has been applied to:
https://github.com/patjak/drm-gma500.git gma500-next
We might also consider polling if this causes problems for people, but for now
this is fin
s_bl = kmemdup(vbt_lvds_bl, sizeof(*vbt_lvds_bl), GFP_KERNEL);
> if (!lvds_bl) {
> dev_err(dev_priv->dev->dev, "out of memory for backlight
> data\n");
> return;
> }
> - memcpy(lvds_bl, vbt_lvds_bl, sizeof(*vbt_lvds_bl)
On Wed, Feb 27, 2013 at 11:19 AM, Chris Wilson wrote:
> On Wed, Feb 27, 2013 at 11:11:38AM +0100, Patrik Jakobsson wrote:
>> On Wed, Feb 27, 2013 at 1:08 AM, Greg Kroah-Hartman
>> wrote:
>> > 3.4-stable review patch. If anyone has any object
On Wed, Feb 27, 2013 at 1:08 AM, Greg Kroah-Hartman
wrote:
> 3.4-stable review patch. If anyone has any objections, please let me know.
>
> --
>
> From: Patrik Jakobsson
>
> commit 4f7dfb6788dd022446847fbbfbe45e13bedb5be2 upstream.
>
> The Intel PRM
62 matches
Mail list logo
