[PATCH] xen-blkfront: drop the use of llist_for_each_entry_safe

2013-02-11 Thread Roger Pau Monne
_safe macro remove it from llist.h. Signed-off-by: Roger Pau Monné Reported-by: Konrad Rzeszutek Wilk Cc: xen-de...@lists.xen.org Cc: Konrad Rzeszutek Wilk --- drivers/block/xen-blkfront.c |5 ++--- include/linux/llist.h| 25 - 2 files changed, 2 inser

Re: [Xen-devel] [PATCH 2/3] xen/ring: Add a new macro to detect whether there is an overflow in requests and response.

2013-01-25 Thread Roger Pau Monné
On 25/01/13 18:32, Konrad Rzeszutek Wilk wrote: > We want to be able to exit if the difference between the request > produced (what the frontend tells us) and the requests consumed > (what we have so far processed) is greater than the ring size. > > If so, we should terminate the loop as the reque

Re: [B.A.T.M.A.N.] [PATCH] net, batman: don't crash on zero length strings in routing_algo

2012-12-24 Thread Pau Koning
On Mon, Dec 24, 2012 at 3:38 PM, Marek Lindner wrote: > On Monday, December 24, 2012 22:18:52 Pau Koning wrote: >> On Mon, Nov 19, 2012 at 9:08 PM, Sasha Levin wrote: >> > The code that works with routing_algo assumes that the string passed is >> > non >> >

Re: [PATCH] net, batman: don't crash on zero length strings in routing_algo

2012-12-24 Thread Pau Koning
On Mon, Nov 19, 2012 at 9:08 PM, Sasha Levin wrote: > The code that works with routing_algo assumes that the string passed is non > empty, this assumption is wrong: Why isn't this patch part of Linux 3.7? It seems to be a bugfix and it was sent early enough? -- To unsubscribe from this list: send

[PATCH v4 2/3] llist: add a safe version of llist_for_each_entry

2012-12-13 Thread Roger Pau Monne
Signed-off-by: Roger Pau Monné Cc: Huang Ying Cc: Konrad Rzeszutek Wilk --- Changes since v3: * Change n to use type *, to keep the same semantics as list_for_each_entry_safe. Changes since v2: * Allow to pass a NULL node as the first entry of deleted list entries. --- include/linux

[PATCH v4 3/3] xen-blkfront: transverse list of persistent grants safely

2012-12-13 Thread Roger Pau Monne
Use llist_for_each_entry_safe in blkif_free. Previously grants where freed while iterating the list, which lead to dereferences when trying to fetch the next item. Reported-by: Dan Carpenter Signed-off-by: Roger Pau Monné Cc: Konrad Rzeszutek Wilk Cc: xen-de...@lists.xen.org --- drivers/block

[PATCH v4 1/3] xen-blkback: implement safe iterator for the list of persistent grants

2012-12-13 Thread Roger Pau Monne
Change foreach_grant iterator to a safe version, that allows freeing the element while iterating. Also move the free code in free_persistent_gnts to prevent freeing the element before the rb_next call. Reported-by: Dan Carpenter Signed-off-by: Roger Pau Monné Cc: Konrad Rzeszutek Wilk Cc: xen

Re: [PATCH v3] llist: add a safe version of llist_for_each_entry

2012-12-12 Thread Roger Pau Monné
On 12/12/12 01:37, Huang Ying wrote: > On Tue, 2012-12-11 at 12:25 +0100, Roger Pau Monne wrote: >> Signed-off-by: Roger Pau Monné >> Cc: Huang Ying >> Cc: Konrad Rzeszutek Wilk >> --- >> Changes since v2: >> * Allow to pass a NULL node as the fi

[PATCH v3] llist: add a safe version of llist_for_each_entry

2012-12-11 Thread Roger Pau Monne
Signed-off-by: Roger Pau Monné Cc: Huang Ying Cc: Konrad Rzeszutek Wilk --- Changes since v2: * Allow to pass a NULL node as the first entry of deleted list entries. --- include/linux/llist.h | 27 +++ 1 files changed, 27 insertions(+), 0 deletions(-) diff --git

[PATCH v2 3/3] xen-blkfront: transverse list of persistent grants safely

2012-12-10 Thread Roger Pau Monne
Use llist_for_each_entry_safe in blkif_free. Previously grants where freed while iterating the list, which lead to dereferences when trying to fetch the next item. Reported-by: Dan Carpenter Signed-off-by: Roger Pau Monné Cc: Konrad Rzeszutek Wilk Cc: xen-de...@lists.xen.org --- drivers/block

[PATCH v2 1/3] xen-blkback: implement safe iterator for the list of persistent grants

2012-12-10 Thread Roger Pau Monne
Change foreach_grant iterator to a safe version, that allows freeing the element while iterating. Also move the free code in free_persistent_gnts to prevent freeing the element before the rb_next call. Reported-by: Dan Carpenter Signed-off-by: Roger Pau Monné Cc: Konrad Rzeszutek Wilk Cc: xen

[PATCH v2 2/3] llist: add a safe version of llist_for_each_entry

2012-12-10 Thread Roger Pau Monne
Signed-off-by: Roger Pau Monné Cc: Huang Ying Cc: Konrad Rzeszutek Wilk --- include/linux/llist.h | 27 +++ 1 files changed, 27 insertions(+), 0 deletions(-) diff --git a/include/linux/llist.h b/include/linux/llist.h index a5199f6..f611cd8 100644 --- a/include/linux

Re: [Xen-devel] [PATCH 2/2] xen-blkfront: implement safe version of llist_for_each_entry

2012-12-10 Thread Roger Pau Monné
On 10/12/12 16:15, Konrad Rzeszutek Wilk wrote: > On Mon, Dec 10, 2012 at 01:15:50PM +0100, Roger Pau Monné wrote: >> On 07/12/12 21:20, Konrad Rzeszutek Wilk wrote: >>> On Tue, Dec 04, 2012 at 03:21:53PM +0100, Roger Pau Monne wrote: >>>> Implement a safe version of

Re: [Xen-devel] [PATCH 2/2] xen-blkfront: implement safe version of llist_for_each_entry

2012-12-10 Thread Roger Pau Monné
On 07/12/12 21:20, Konrad Rzeszutek Wilk wrote: > On Tue, Dec 04, 2012 at 03:21:53PM +0100, Roger Pau Monne wrote: >> Implement a safe version of llist_for_each_entry, and use it in >> blkif_free. Previously grants where freed while iterating the list, >> which lead to derefe

[PATCH] xen-blkfront: handle bvecs with partial data

2012-12-07 Thread Roger Pau Monne
Signed-off-by: Roger Pau Monné Cc: linux-kernel@vger.kernel.org Cc: Konrad Rzeszutek Wilk --- drivers/block/xen-blkfront.c |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c index df21b05..860f76d 100644

[PATCH 2/2] xen-blkfront: implement safe version of llist_for_each_entry

2012-12-04 Thread Roger Pau Monne
Implement a safe version of llist_for_each_entry, and use it in blkif_free. Previously grants where freed while iterating the list, which lead to dereferences when trying to fetch the next item. Reported-by: Dan Carpenter Signed-off-by: Roger Pau Monné Cc: Konrad Rzeszutek Wilk Cc: xen-de

[PATCH 1/2] xen-blkback: implement safe iterator for the list of persistent grants

2012-12-04 Thread Roger Pau Monne
Change foreach_grant iterator to a safe version, that allows freeing the element while iterating. Also move the free code in free_persistent_gnts to prevent freeing the element before the rb_next call. Reported-by: Dan Carpenter Signed-off-by: Roger Pau Monné Cc: Konrad Rzeszutek Wilk Cc: xen

[PATCH 2/2] xen-blkback: move free persistent grants code

2012-11-16 Thread Roger Pau Monne
Move the code that frees persistent grants from the red-black tree to a function. This will make it easier for other consumers to move this to a common place. Signed-off-by: Roger Pau Monné --- drivers/block/xen-blkback/blkback.c | 68 +++ 1 files changed, 37

[PATCH 1/2] xen-blkfront: free allocated page

2012-11-16 Thread Roger Pau Monne
Free the page allocated for the persistent grant. Signed-off-by: Roger Pau Monné --- drivers/block/xen-blkfront.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c index f1de806..96e9b00 100644 --- a/drivers

Re: [PATCH] xen-blk: persistent-grants fixes

2012-11-02 Thread Roger Pau Monné
On 02/11/12 18:05, Konrad Rzeszutek Wilk wrote: > On Fri, Nov 02, 2012 at 04:43:04PM +0100, Roger Pau Monne wrote: >> This patch contains fixes for persistent grants implementation v2: >> >> * handle == 0 is a valid handle, so initialize grants in blkback >&g

[PATCH] xen-blk: persistent-grants fixes

2012-11-02 Thread Roger Pau Monne
sure we don't try to access segments that have not been set. Signed-off-by: Roger Pau Monne Cc: Cc: --- drivers/block/xen-blkback/blkback.c | 15 +-- drivers/block/xen-blkback/xenbus.c |2 +- drivers/block/xen-blkfront.c|3 ++- 3 files changed, 12 insertions(+), 8

[PATCH v2] Persistent grant maps for xen blk drivers

2012-10-24 Thread Roger Pau Monne
ional cost to the guest of using persistent grants. There is perhaps a small saving, from the reduced number of hypercalls performed in granting, and ending foreign access. Signed-off-by: Oliver Chick Signed-off-by: Roger Pau Monne Cc: Cc: --- Changes since v1: * Changed the unmap_seg arr

Re: about the patch: Persistent grant maps for xen blk drivers

2012-10-24 Thread Roger Pau Monné
On 24/10/12 14:40, liuxiaolei1124 wrote: > Dear Roger: > > i have put the patch "Persistent grant maps for xen blk drivers" > (https://lkml.org/lkml/2012/10/18/191) into my Dom0 which is 2.6.32.36. > And when i start a vm, sometimes the blkback go to the BUG_ON. I'm working on top of the ne

Re: [Xen-devel] [PATCH RFC] Persistent grant maps for xen blk drivers

2012-10-24 Thread Roger Pau Monné
On 23/10/12 20:50, Konrad Rzeszutek Wilk wrote: > On Tue, Oct 23, 2012 at 08:09:27PM +0200, Roger Pau Monné wrote: >> On 23/10/12 19:20, Konrad Rzeszutek Wilk wrote: >>>>>> diff --git a/drivers/block/xen-blkback/blkback.c >>>>>> b/drivers/block/xen-bl

Re: [PATCH RFC] Persistent grant maps for xen blk drivers

2012-10-23 Thread Roger Pau Monné
On 23/10/12 19:20, Konrad Rzeszutek Wilk wrote: diff --git a/drivers/block/xen-blkback/blkback.c b/drivers/block/xen-blkback/blkback.c index c6decb9..2b982b2 100644 --- a/drivers/block/xen-blkback/blkback.c +++ b/drivers/block/xen-blkback/blkback.c @@ -78,6 +78,7 @@ s

Re: [PATCH RFC] Persistent grant maps for xen blk drivers

2012-10-23 Thread Roger Pau Monné
On 22/10/12 15:47, Konrad Rzeszutek Wilk wrote: > On Thu, Oct 18, 2012 at 01:22:01PM +0200, Roger Pau Monne wrote: >> This patch implements persistent grants for the xen-blk{front,back} >> mechanism. The effect of this change is to reduce the number of unmap >> operations

Re: [Xen-devel] [PATCH RFC] Persistent grant maps for xen blk drivers

2012-10-19 Thread Roger Pau Monné
On 19/10/12 03:34, James Harper wrote: >> >> This patch implements persistent grants for the xen-blk{front,back} >> mechanism. The effect of this change is to reduce the number of unmap >> operations performed, since they cause a (costly) TLB shootdown. This allows >> the I/O performance to scale b

[PATCH RFC] Persistent grant maps for xen blk drivers

2012-10-18 Thread Roger Pau Monne
here is perhaps a small saving, from the reduced number of hypercalls performed in granting, and ending foreign access. Signed-off-by: Oliver Chick Signed-off-by: Roger Pau Monne Cc: Cc: --- Benchmarks showing the impact of this patch in blk performance can be found at: http://xenbits.xens

Re: [Xen-devel] [PATCH v2] Persistent grant maps for xen blk drivers

2012-10-09 Thread Roger Pau Monné
On 24/09/12 13:36, Jan Beulich wrote: On 21.09.12 at 17:52, Oliver Chick wrote: >> Changes since v1: >> >> * Maximum number of persistent grants per device now 64, rather than >>256, as this is the actual maxmimum request in a (1 page) ring. > > As said previously, I don't see why this

Re: [Xen-devel] [PATCH WIP 2/6] xen/arm: Introduce xen_guest_init

2012-07-12 Thread Roger Pau Monne
David Vrabel wrote: > On 09/07/12 15:45, Konrad Rzeszutek Wilk wrote: >> On Fri, Jun 22, 2012 at 05:14:41PM +0100, Stefano Stabellini wrote: >>> We used to rely on a core_initcall to initialize Xen on ARM, however >>> core_initcalls are actually called after early consoles are initialized. >>> That

Re: i386/x86_64 segment register issuses (Re: PATCH: Fix x86 segment register access)

2005-03-30 Thread Pau Aliagas
2.6 detailed in this thread: http://kerneltrap.org/node/4940 I don't want at all to justify it with the change you talk about in gas, but maybe it is worth to check if it has anything to do with it. The slowdown happened in this last six months. -- Pau - To unsubscribe from this list: send t

Re: i386/x86_64 segment register issuses (Re: PATCH: Fix x86 segment register access)

2005-03-30 Thread Pau Aliagas
uld this be the reason for the reported slowdown in the last six months? -- Pau - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: 2.4.3-ac3 XIRCOM_CB only working as module

2001-04-05 Thread Pau
ou still have to unload the card and reload it again to get back the network working. I'm using hotplug. Pau - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-i

stick processes in 2.4.3 trace (alt-sysrq t)

2001-04-04 Thread Pau
Here's is the trace of a nautilus process in D state. I'm rebooting now in 2.4.3-ac2 to see if it still happens. Pau trace.bz2

processes stuck in D state

2001-04-04 Thread Pau Aliagas
/bin/galeon-bin This didn't happen neither with 2.4.2 nor with 2.4.3-pre7; I'm not sure about pre8. Pau - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majord

Re: 2.4.3-pre8 xircom_tulip_cb missing symbols

2001-03-28 Thread Pau Aliagas
are statically linked. I've been sent this patch by Eran Mann that adds net_init.o to the exported objects in the net Makefile. Still untested ;) Pau --- linux/kernel/nous_kernels/linux/drivers/net/Makefile.oldWed Mar 28 16:21:20 2001 +++ linux/kernel/nous_kernels/linux/drivers/net/Ma

2.4.3-pre8 xircom_tulip_cb missing symbols

2001-03-27 Thread Pau Aliagas
register_netdev /lib/modules/2.4.3-pre8/kernel/drivers/net/pcmcia/xircom_tulip_cb.o: insmod /lib/modules/2.4.3-pre8/kernel/drivers/net/pcmcia/xircom_tulip_cb.o failed /lib/modules/2.4.3-pre8/kernel/drivers/net/pcmcia/xircom_tulip_cb.o: insmod xircom_tulip_cb failed Pau - To unsubscribe from this

2.4.2-ac26 -> processes in D state

2001-03-27 Thread Pau Aliagas
I've tried 2.4.2-ac26 to test the new xircom_cb driver but I have had to reboot on 2.4.3-pre7 as some processes got stuck on D state. The processes were large apps: once nautilus and once mozilla. I couldn't get any other information. Pau - To unsubscribe from this list: sen

Re: PCMCIA serial CardBus support vanished in 2.4.3-pre3 and later

2001-03-20 Thread Pau
Tx hang basically with NFS, but also when moving high amount of Mb in the LAN. I've moved from pcmcia-cs to hotplug and it works too :) Pau - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info a

Re: PCMCIA serial CardBus support vanished in 2.4.3-pre3 and later

2001-03-20 Thread Pau
you have > CONFIG_SERIAL enabled, along with hotplugging support etc. In fact it does. I discovered it last weekend when my modem -them same one than Alessandro's- stopped working. Removing "alias char-major-4 serial_cb" from modules.conf did the trick and the serial driver worked

LDT allocated for cloned task!

2001-03-20 Thread Pau
I've been running 2.4.3-pre4 for a few days now and today I've got this message in the logs a couple of times. Is it harmless? Pau - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More maj

Re: pcmcia-issues with 2.2.18 & 2.4.0

2001-02-12 Thread Pau Aliagas
I use: alias eth0 xircom_tulip_cb and when this happens -90% if times when I boot and 100% of time when I awake after a sleep- I just do the following: ifconfig eth0 -promisc and it works again. Pau - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the

xircom_tulib_cb + NFS in 2.4.0 does not work

2001-01-12 Thread Pau
p;& ifconfig eth0 -promisc Any hints? Pau - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/

error compiling 2.4.1-pre3

2001-01-12 Thread Pau
Error 1 make[2]: Leaving directory `/usr/src/linux/drivers/md' make[1]: *** [_modsubdir_md] Error 2 make[1]: Leaving directory `/usr/src/linux/drivers' make: *** [_mod_drivers] Error 2 Pau - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a messa

xircom_tulip + NFS hanging interface

2001-01-09 Thread Pau
1 soundcore 3952 2 [maestro] uhci 18672 0 (unused) usbcore52304 2 [uhci] Thanks for your help Pau - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/

missing symbols in prerelease

2001-01-01 Thread Pau Aliagas
depmod: *** Unresolved symbols in /lib/modules/2.4.0-prerelease/kernel/drivers/net/irda/toshoboe.o depmod: __bad_udelay depmod: *** Unresolved symbols in /lib/modules/2.4.0-prerelease/kernel/drivers/video/atyfb.o depmod: __bad_udelay Pau - To unsubscribe from this list: send

happy milleniun to everybody!

2000-12-31 Thread Pau
Have a nice and happy new year's eve everybody. Pau - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/

Re: innd mmap bug in 2.4.0-test12 (UNIMPORTANT)

2000-12-28 Thread Pau
May I ask which PDA do you have running Linux and worth a few bucks? Pau - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/

Re: test13-pre1 changelog

2000-12-15 Thread Pau
On 14 Dec 2000, Linus Torvalds wrote: > if we figure out why apparently some people have trouble with external > modules (at least one person has trouble with loading alsa modules). I cannot load the xircom_tulip_cb module using the latest modutils 2.3.22. I think it's a modutils pr

Need advice: most suitable ATM/ADSL card + kernel

2000-12-06 Thread Pau
I want to plug a linux box as a router for the ADSL line I've got at home. My provider uses IP over ATM (not pppoe). I'd like to buy a suitable and cheap ATM/ADSL card, up to 2Mb (no need for 155 Mbps speeds :) and an advice about the kernel to use. Any hints? Thx for your help

Re: test10-pre4 gets stuck with kernel BUG at vmscan.c:102!

2000-10-19 Thread Pau
On Thu, 19 Oct 2000, Pau wrote: > I've compiled and installed test10-pre4 in my laptop and I have had to > reboot 4 times in less than a day. > > sysrq key is working so I attach some traces. Sorry to follow up my self but... definately it happens when it starts swapping.

test10-pre4 gets stuck with kernel BUG at vmscan.c:102!

2000-10-19 Thread Pau
I've compiled and installed test10-pre4 in my laptop and I have had to reboot 4 times in less than a day. sysrq key is working so I attach some traces. If something more is needed just tell me. Pau Oct 19 11:02:45 pau kernel: kernel BUG at vmscan.c:102! Oct 19 11:02:45 pau kernel: in

Re: test9-pre9 lockups using pine

2000-10-03 Thread Pau
what do you see after the system 'hangs' and > you type sysrq-T, sysrq-M and/or sysrq-P ? I wrote a message yesterday with the same problem. test8 works ok but test9-pre? hang when quickly keying while expunging a mailbox. Only sysrq-o (power down) responds. No oops. Pau - To unsub

<    1   2   3   4   5   6