Re: [PATCH] dax/hmem: Fix refcount leak in dax_hmem_probe()

2023-06-02 Thread Paul Cassella
On Fri, 2 Jun 2023, Ira Weiny wrote: > Paul Cassella wrote: > > On Sat, 3 Dec 2022, Ira Weiny wrote: > > > On Sat, Dec 03, 2022 at 09:58:58AM +, Yongqiang Liu wrote: > > > > We should always call dax_region_put() whenever devm_create_dev_dax() > > > &

Re: [PATCH] dax/hmem: Fix refcount leak in dax_hmem_probe()

2023-06-01 Thread Paul Cassella
; > - return PTR_ERR(dev_dax); > > > > /* child dev_dax instances now own the lifetime of the dax_region */ This comment should probably be updated now. :) -- Paul Cassella > > dax_region_put(dax_region); > > - return 0; > > + > > + return IS_ERR(dev_dax) ? PTR_ERR(dev_dax) : 0; > > } > > > > static int dax_hmem_remove(struct platform_device *pdev) > > -- > > 2.25.1 > > > > >

Re: Hangs under 2.4.2-ac{18,19,24} that do not happen under -ac12.

2001-04-03 Thread Paul Cassella
On Wed, 28 Mar 2001, Paul Cassella wrote: > Hangs under 2.4.2-ac{18,19,24} that do not happen under -ac12. I've been running -ac27 for over 5 days, and it's been fine, so this seems to have been fixed. -- Paul Cassella - To unsubscribe from this list: send the line "unsubscribe linu

Re: Hangs under 2.4.2-ac{18,19,24} that do not happen under -ac12.

2001-04-03 Thread Paul Cassella
On Wed, 28 Mar 2001, Paul Cassella wrote: Hangs under 2.4.2-ac{18,19,24} that do not happen under -ac12. I've been running -ac27 for over 5 days, and it's been fine, so this seems to have been fixed. -- Paul Cassella - To unsubscribe from this list: send the line "unsubscribe linux-k

Re: Hangs under 2.4.2-ac{18,19,24} that do not happen under -ac12.

2001-03-28 Thread Paul Cassella
ing the pm.c change. I also haven't tried anything after 24; is it likely to have been fixed? -- Paul Cassella - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majord

Re: Hangs under 2.4.2-ac{18,19,24} that do not happen under -ac12.

2001-03-28 Thread Paul Cassella
though. > When I get home and reboot (following this most recent hang :( ), I'll > put the diff, .config, and more stuff from /proc at > http://manetheren.eigenray.com/~fortytwo/crash-12-18.2 This is now there. -- Paul Cassella - To unsubscribe from this list: send the line &qu

Hangs under 2.4.2-ac{18,19,24} that do not happen under -ac12.

2001-03-28 Thread Paul Cassella
kernel(); inode->i_op->truncate(inode); + unlock_kernel(); + } return 0; out: return -EFBIG; A few lines earlier in this function, inode->i_op->truncate() is called without lock_kernel(). Should it also have a lock_kernel(), or i

Hangs under 2.4.2-ac{18,19,24} that do not happen under -ac12.

2001-03-28 Thread Paul Cassella
inode-i_op-truncate(inode); + unlock_kernel(); + } return 0; out: return -EFBIG; A few lines earlier in this function, inode-i_op-truncate() is called without lock_kernel(). Should it also have a lock_kernel(), or is it not needed there? -- Paul Cassella -

Re: Hangs under 2.4.2-ac{18,19,24} that do not happen under -ac12.

2001-03-28 Thread Paul Cassella
. When I get home and reboot (following this most recent hang :( ), I'll put the diff, .config, and more stuff from /proc at http://manetheren.eigenray.com/~fortytwo/crash-12-18.2 This is now there. -- Paul Cassella - To unsubscribe from this list: send the line "unsubscribe linux-k

Re: Hangs under 2.4.2-ac{18,19,24} that do not happen under -ac12.

2001-03-28 Thread Paul Cassella
the pm.c change. I also haven't tried anything after 24; is it likely to have been fixed? -- Paul Cassella - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.h

Re: 2.4.0-ac3 write() to tcp socket returning errno of -3 (ESRCH:"No such process")

2001-01-11 Thread Paul Cassella
On Tue, 9 Jan 2001, Paul Cassella wrote: > and mss_now seems to be less than skb->len when the printk happens. My > copy of K is at work; could that comparison be being done unsigned > because of skb->len? I wouldn't think so, but the alternative seems > somewhat worse...

Re: 2.4.0-ac3 write() to tcp socket returning errno of -3 (ESRCH:No such process)

2001-01-11 Thread Paul Cassella
On Tue, 9 Jan 2001, Paul Cassella wrote: and mss_now seems to be less than skb-len when the printk happens. My copy of KR is at work; could that comparison be being done unsigned because of skb-len? I wouldn't think so, but the alternative seems somewhat worse... That'll teach me to post

Re: 2.4.0-ac3 write() to tcp socket returning errno of -3 (ESRCH:"No such process")

2001-01-09 Thread Paul Cassella
6,8 +2069,10 @@ if (sk->state != TCP_LISTEN) break; err = sock_intr_errno(timeo); - if (signal_pending(current)) + if (signal_pending(current)) { + CHECK_TCP_RET(); break; + }

Re: 2.4.0-ac3 write() to tcp socket returning errno of -3 (ESRCH:"No such process")

2001-01-07 Thread Paul Cassella
On Mon, 8 Jan 2001, Andi Kleen wrote: > On Sun, Jan 07, 2001 at 11:55:28PM -0600, Paul Cassella wrote: > > write() returns -1 and sets errno non-sensically. 2.4.0{,-ac[23]} > Would it be possible to provide a compiling test case that shows these > errors ? The CVS versio

Re: 2.4.0-ac3 write() to tcp socket returning errno of -3 (ESRCH:"No such process")

2001-01-07 Thread Paul Cassella
On Sun, 7 Jan 2001, David S. Miller wrote: >Date: Sun, 7 Jan 2001 23:55:28 -0600 (CST) >From: Paul Cassella <[EMAIL PROTECTED]> > >[1.] One line summary of the problem: > >write() returns -1 and sets errno non-sensically. 2.4.0{,-ac[23]} > >

2.4.0-ac3 write() to tcp socket returning errno of -3 (ESRCH: "Nosuch process")

2001-01-07 Thread Paul Cassella
) messages that -ac3 fixed. I'm also getting TCP peer shrinks window messages, but had none this boot before this error. -- Paul Cassella - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/

2.4.0-ac3 write() to tcp socket returning errno of -3 (ESRCH: Nosuch process)

2001-01-07 Thread Paul Cassella
I'm also getting TCP peer shrinks window messages, but had none this boot before this error. -- Paul Cassella - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/

Re: 2.4.0-ac3 write() to tcp socket returning errno of -3 (ESRCH:No such process)

2001-01-07 Thread Paul Cassella
On Sun, 7 Jan 2001, David S. Miller wrote: Date: Sun, 7 Jan 2001 23:55:28 -0600 (CST) From: Paul Cassella [EMAIL PROTECTED] [1.] One line summary of the problem: write() returns -1 and sets errno non-sensically. 2.4.0{,-ac[23]} What you describe I can only say

Re: 2.4.0-ac3 write() to tcp socket returning errno of -3 (ESRCH:No such process)

2001-01-07 Thread Paul Cassella
On Mon, 8 Jan 2001, Andi Kleen wrote: On Sun, Jan 07, 2001 at 11:55:28PM -0600, Paul Cassella wrote: write() returns -1 and sets errno non-sensically. 2.4.0{,-ac[23]} Would it be possible to provide a compiling test case that shows these errors ? The CVS version (perhaps even version

Re: [RFC] Semaphores used for daemon wakeup

2000-12-21 Thread Paul Cassella
le of how they could be used to achieve the same behavior as the code that was posted. -- Paul Cassella [EMAIL PROTECTED] - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/

Re: [RFC] Semaphores used for daemon wakeup

2000-12-21 Thread Paul Cassella
the list, but I'm going on vacation tomorrow, so I'd appreciate a Cc: so I have a better chance of answering before then. Thanks. -- Paul Cassella [EMAIL PROTECTED] And now, the code. include/linux/sv.h: /* This is the version I'm using with a test8-pre1 kernel, so it uses the old TASK_EXC

Re: [RFC] Semaphores used for daemon wakeup

2000-12-21 Thread Paul Cassella
, so I'd appreciate a Cc: so I have a better chance of answering before then. Thanks. -- Paul Cassella [EMAIL PROTECTED] And now, the code. include/linux/sv.h: /* This is the version I'm using with a test8-pre1 kernel, so it uses the old TASK_EXCLUSIVE semantics; it should be trivial to mak

Re: [RFC] Semaphores used for daemon wakeup

2000-12-21 Thread Paul Cassella
behavior as the code that was posted. -- Paul Cassella [EMAIL PROTECTED] - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/