Re: [PATCH v3 2/2] random32: Re-enable KCSAN instrumentation

2020-12-01 Thread Paul E. McKenney
On Tue, Nov 24, 2020 at 12:02:10PM +0100, Marco Elver wrote: > Re-enable KCSAN instrumentation, now that KCSAN no longer relies on code > in lib/random32.c. > > Signed-off-by: Marco Elver Queued and pushed both, thank you! Thanx, Paul > -

Re: [GIT pull] locking/urgent for v5.10-rc6

2020-12-01 Thread Paul E. McKenney
On Tue, Dec 01, 2020 at 03:55:19PM +0100, Peter Zijlstra wrote: > On Tue, Dec 01, 2020 at 06:46:44AM -0800, Paul E. McKenney wrote: > > > > So after having talked to Sven a bit, the thing that is happening, is > > > that this is the one place where we take interrupts with

Re: [GIT pull] locking/urgent for v5.10-rc6

2020-12-01 Thread Paul E. McKenney
On Tue, Dec 01, 2020 at 12:07:24PM +0100, Peter Zijlstra wrote: > On Tue, Dec 01, 2020 at 09:07:34AM +0100, Peter Zijlstra wrote: > > On Mon, Nov 30, 2020 at 08:31:32PM +0100, Christian Borntraeger wrote: > > > On 30.11.20 19:04, Linus Torvalds wrote: > > > > On Mon, Nov 30, 2020 at 5:03 AM Peter Z

[GIT PULL tip/core/rcu] RCU, LKMM, and KCSAN commits for v5.11

2020-11-30 Thread Paul E. McKenney
up watchpoints on NULL pointers kcsan: Fix encoding masks and regain address bit Mauro Carvalho Chehab (1): docs: RCU: Requirements.rst: Fix a list block Neeraj Upadhyay (2): rcu: Fix single-CPU check in rcu_blocking_is_gp() rcu: Clarify nocb kthreads naming in RCU_NOCB_CPU

Re: [GIT pull] locking/urgent for v5.10-rc6

2020-11-29 Thread Paul E. McKenney
On Sun, Nov 29, 2020 at 11:31:41AM -0800, Linus Torvalds wrote: > On Sun, Nov 29, 2020 at 5:38 AM Thomas Gleixner wrote: > > > > Yet two more places which invoke tracing from RCU disabled regions in the > > idle path. Similar to the entry path the low level idle functions have to > > be non-instru

Re: [PATCH 2/2] tools/memory-model: Fix typo in klitmus7 compatibility table

2020-11-28 Thread Paul E. McKenney
On Sat, Nov 28, 2020 at 03:01:49PM +0900, Akira Yokosawa wrote: > >From 4f577823fa60e14ae58caa2d3c0b2ced64e6eb43 Mon Sep 17 00:00:00 2001 > From: Akira Yokosawa > Date: Sat, 28 Nov 2020 14:32:15 +0900 > Subject: [PATCH 2/2] tools/memory-model: Fix typo in klitmus7 compatibility > table > > klitm

Re: [PATCH v2 tip/core/rcu 1/6] srcu: Make Tiny SRCU use multi-bit grace-period counter

2020-11-27 Thread Paul E. McKenney
On Wed, Nov 25, 2020 at 10:03:26AM +0530, Neeraj Upadhyay wrote: > > > On 11/24/2020 10:48 AM, Neeraj Upadhyay wrote: > > > > > > On 11/24/2020 1:25 AM, Paul E. McKenney wrote: > > > On Mon, Nov 23, 2020 at 10:01:13AM +0530, Neeraj Upadhyay wrote:

Re: [PATCH memory-model 6/8] tools/memory-model: Add types to litmus tests

2020-11-27 Thread Paul E. McKenney
On Wed, Nov 25, 2020 at 08:34:47PM +0900, Akira Yokosawa wrote: > On Thu, 5 Nov 2020 14:56:05 -0800, Paul E. McKenney wrote: > > On Fri, Nov 06, 2020 at 07:41:48AM +0900, Akira Yokosawa wrote: > >> Hi Paul, > >> > >> On 2020/11/06 7:00, paul...@kernel.org

Re: kdump always hangs in rcu_barrier() -> wait_for_completion()

2020-11-26 Thread Paul E. McKenney
On Thu, Nov 26, 2020 at 10:59:19PM +, Dexuan Cui wrote: > > From: Paul E. McKenney > > Sent: Thursday, November 26, 2020 1:42 PM > > > > > > Another possibility is that rcu_state.gp_kthread is non-NULL, but that > > > > something else is preventing

Re: kdump always hangs in rcu_barrier() -> wait_for_completion()

2020-11-26 Thread Paul E. McKenney
On Thu, Nov 26, 2020 at 09:25:28PM +, Dexuan Cui wrote: > > From: Paul E. McKenney > > Sent: Thursday, November 26, 2020 7:47 AM > > ... > > The rcu_segcblist_n_cbs() function returns non-zero because something > > invoked call_rcu() some time previously. The

Re: kdump always hangs in rcu_barrier() -> wait_for_completion()

2020-11-26 Thread Paul E. McKenney
On Wed, Nov 25, 2020 at 04:56:33AM +, Dexuan Cui wrote: > Hi, > I happened to hit a kdump hang issue in a Linux VM running on some > Hyper-V host. Please see the attached log: the kdump kernel always hangs, > even if I configure only 1 virtual CPU to the VM. > > I firstly hit the issue in RHEL

Re: linux-next: build warnings after merge of the rcu tree

2020-11-26 Thread Paul E. McKenney
On Thu, Nov 26, 2020 at 05:44:28PM +1100, Stephen Rothwell wrote: > Hi all, > > After merging the rcu tree, today's linux-next build (htmldocs) produced > these warnings: > > include/linux/rcupdate.h:872: warning: Excess function parameter 'ptr' > description in 'kfree_rcu' > include/linux/rcupd

Re: [PATCH 2/2] rcu: eliminate the __kvfree_rcu() macro

2020-11-24 Thread Paul E. McKenney
On Fri, Nov 20, 2020 at 12:49:17PM +0100, Uladzislau Rezki (Sony) wrote: > Make the kvfree_rcu_arg_2() to be open-coded, so readability > and review look better from the first glance. Moreover, that > makes it clear that both kvfree_rcu_arg_1/2() use one single > interface. > > Signed-off-by: Ulad

Re: [PATCH v2 tip/core/rcu 4/6] srcu: Provide polling interfaces for Tiny SRCU grace periods

2020-11-24 Thread Paul E. McKenney
On Tue, Nov 24, 2020 at 10:44:24AM +0530, Neeraj Upadhyay wrote: > > > On 11/24/2020 2:42 AM, Paul E. McKenney wrote: > > On Mon, Nov 23, 2020 at 10:13:13AM +0530, Neeraj Upadhyay wrote: > > > > > > > > > On 11/21/2020 6:29 AM, paul...@kernel.

Re: linux-next: stall warnings and deadlock on Arm64 (was: [PATCH] kfence: Avoid stalling...)

2020-11-24 Thread Paul E. McKenney
On Tue, Nov 24, 2020 at 03:03:10PM +0100, Marco Elver wrote: > On Mon, Nov 23, 2020 at 07:32PM +, Mark Rutland wrote: > > On Fri, Nov 20, 2020 at 03:03:32PM +0100, Marco Elver wrote: > > > On Fri, Nov 20, 2020 at 10:30AM +, Mark Rutland wrote: > > > > On Thu, Nov 19, 2020 at 10:53:53PM +000

Re: [PATCH] kfence: Avoid stalling work queue task without allocations

2020-11-23 Thread Paul E. McKenney
th irqs disabled") Thanx, Paul ---- commit d02133f517e5b4eb417ad88b14c0759a0c0deac6 Author: Peter Zijlstra Date: Sat Aug 29 10:22:24 2020 -0700 sched/core: Allow try_invoke_on_l

Re: [PATCH v2 tip/core/rcu 4/6] srcu: Provide polling interfaces for Tiny SRCU grace periods

2020-11-23 Thread Paul E. McKenney
On Mon, Nov 23, 2020 at 10:13:13AM +0530, Neeraj Upadhyay wrote: > > > On 11/21/2020 6:29 AM, paul...@kernel.org wrote: > > From: "Paul E. McKenney" > > > > There is a need for a polling interface for SRCU grace > > periods, so this

Re: [PATCH RFC tip/core/rcu 4/5] srcu: Provide polling interfaces for Tiny SRCU grace periods

2020-11-23 Thread Paul E. McKenney
On Mon, Nov 23, 2020 at 10:04:23AM +0530, Neeraj Upadhyay wrote: > On 11/22/2020 11:31 PM, Paul E. McKenney wrote: > > On Sun, Nov 22, 2020 at 07:57:26PM +0530, Neeraj Upadhyay wrote: > > > On 11/21/2020 5:43 AM, Paul E. McKenney wrote: > > > > On Fri, Nov 20, 20

Re: [PATCH v2 tip/core/rcu 1/6] srcu: Make Tiny SRCU use multi-bit grace-period counter

2020-11-23 Thread Paul E. McKenney
On Mon, Nov 23, 2020 at 10:01:13AM +0530, Neeraj Upadhyay wrote: > On 11/21/2020 6:29 AM, paul...@kernel.org wrote: > > From: "Paul E. McKenney" > > > > There is a need for a polling interface for SRCU grace periods. This > > polling needs to distinguish b

Re: [PATCH RFC tip/core/rcu 4/5] srcu: Provide polling interfaces for Tiny SRCU grace periods

2020-11-22 Thread Paul E. McKenney
On Sun, Nov 22, 2020 at 07:57:26PM +0530, Neeraj Upadhyay wrote: > On 11/21/2020 5:43 AM, Paul E. McKenney wrote: > > On Fri, Nov 20, 2020 at 05:28:32PM +0530, Neeraj Upadhyay wrote: > > > Hi Paul, > > > > > > On 11/17/2020 6:10 AM, paul...@kernel.org wr

Re: [PATCH v2 tip/core/rcu 4/6] srcu: Provide polling interfaces for Tiny SRCU grace periods

2020-11-22 Thread Paul E. McKenney
On Sun, Nov 22, 2020 at 08:00:09PM +0530, Neeraj Upadhyay wrote: > > > On 11/21/2020 6:29 AM, paul...@kernel.org wrote: > > From: "Paul E. McKenney" > > > > There is a need for a polling interface for SRCU grace > > periods, so this

Re: linux-next: Signed-off-by missing for commit in the rcu tree

2020-11-22 Thread Paul E. McKenney
On Sun, Nov 22, 2020 at 09:09:13PM +1100, Stephen Rothwell wrote: > Hi all, > > On Sun, 22 Nov 2020 21:08:10 +1100 Stephen Rothwell > wrote: > > > > Commit > > > > ca3bd09a3a49 ("rcu: Allow rcu_irq_enter_check_tick() from NMI") > > > > is missing a Signed-off-by from its author. > > Please

Re: [PATCH tip/core/rcu 0/5] Provide SRCU polling grace-period interfaces

2020-11-20 Thread Paul E. McKenney
On Fri, Nov 20, 2020 at 08:05:53PM -0500, Steven Rostedt wrote: > On Fri, 20 Nov 2020 16:58:09 -0800 > "Paul E. McKenney" wrote: > > > OK, maybe no one needs it, but rcutorture does need it, so here > > it is anyway. > > Ah, so there was a use case.

Re: [PATCH tip/core/rcu 0/5] Provide SRCU polling grace-period interfaces

2020-11-20 Thread Paul E. McKenney
Hello! This is V2 of the series provides a polling interface for SRCU grace periods. The API is still as follows: unsigned long start_poll_synchronize_srcu(struct srcu_struct *ssp) Returns a "cookie" that can be thought of as a snapshot of the specified SRCU instance's grace-

Re: [PATCH RFC tip/core/rcu 3/5] srcu: Provide internal interface to start a Tree SRCU grace period

2020-11-20 Thread Paul E. McKenney
On Fri, Nov 20, 2020 at 05:06:50PM +0530, Neeraj Upadhyay wrote: > > > On 11/17/2020 6:10 AM, paul...@kernel.org wrote: > > From: "Paul E. McKenney" > > > > There is a need for a polling interface for SRCU grace periods. > > This polling needs to i

Re: [PATCH RFC tip/core/rcu 5/5] srcu: Provide polling interfaces for Tree SRCU grace periods

2020-11-20 Thread Paul E. McKenney
On Fri, Nov 20, 2020 at 05:31:43PM +0530, Neeraj Upadhyay wrote: > > > On 11/17/2020 6:10 AM, paul...@kernel.org wrote: > > From: "Paul E. McKenney" > > > > There is a need for a polling interface for SRCU grace > > periods, so this

Re: [PATCH RFC tip/core/rcu 4/5] srcu: Provide polling interfaces for Tiny SRCU grace periods

2020-11-20 Thread Paul E. McKenney
On Fri, Nov 20, 2020 at 05:28:32PM +0530, Neeraj Upadhyay wrote: > Hi Paul, > > On 11/17/2020 6:10 AM, paul...@kernel.org wrote: > > From: "Paul E. McKenney" > > > > There is a need for a polling interface for SRCU grace > > periods, so this

Re: linux-next: stall warnings and deadlock on Arm64 (was: [PATCH] kfence: Avoid stalling...)

2020-11-20 Thread Paul E. McKenney
On Fri, Nov 20, 2020 at 06:02:06PM +, Mark Rutland wrote: > On Fri, Nov 20, 2020 at 09:38:24AM -0800, Paul E. McKenney wrote: > > On Fri, Nov 20, 2020 at 03:22:00PM +, Mark Rutland wrote: > > > On Fri, Nov 20, 2020 at 06:39:28AM -0800, Paul E. McKenney wrote: > >

Re: linux-next: stall warnings and deadlock on Arm64 (was: [PATCH] kfence: Avoid stalling...)

2020-11-20 Thread Paul E. McKenney
On Fri, Nov 20, 2020 at 03:22:00PM +, Mark Rutland wrote: > On Fri, Nov 20, 2020 at 06:39:28AM -0800, Paul E. McKenney wrote: > > On Fri, Nov 20, 2020 at 03:19:28PM +0100, Marco Elver wrote: > > > I found that disabling ftrace for some of kernel/rcu (see below) solved > &g

Re: [PATCH] rcu: kasan: record and print kvfree_call_rcu call stack

2020-11-20 Thread Paul E. McKenney
On Fri, Nov 20, 2020 at 03:44:04PM +0100, Dmitry Vyukov wrote: > On Fri, Nov 20, 2020 at 3:34 PM Paul E. McKenney wrote: > > > > On Fri, Nov 20, 2020 at 09:51:15AM +0100, Dmitry Vyukov wrote: > > > On Thu, Nov 19, 2020 at 10:49 PM Paul E. McKenney > > > wrot

Re: [PATCH] rcu: kasan: record and print kvfree_call_rcu call stack

2020-11-20 Thread Paul E. McKenney
On Fri, Nov 20, 2020 at 06:34:40AM -0800, Paul E. McKenney wrote: > On Fri, Nov 20, 2020 at 09:51:15AM +0100, Dmitry Vyukov wrote: > > On Thu, Nov 19, 2020 at 10:49 PM Paul E. McKenney > > wrote: > > > > > > On Wed, Nov 18, 2020 at 11:53:09AM +0800, qiang.zh...@

Re: linux-next: stall warnings and deadlock on Arm64 (was: [PATCH] kfence: Avoid stalling...)

2020-11-20 Thread Paul E. McKenney
On Fri, Nov 20, 2020 at 03:19:28PM +0100, Marco Elver wrote: > On Thu, Nov 19, 2020 at 01:35PM -0800, Paul E. McKenney wrote: > > On Thu, Nov 19, 2020 at 08:38:19PM +0100, Marco Elver wrote: > > > On Thu, Nov 19, 2020 at 10:48AM -0800, Paul E. McKenney wrote: > > > >

Re: [PATCH] rcu: kasan: record and print kvfree_call_rcu call stack

2020-11-20 Thread Paul E. McKenney
On Fri, Nov 20, 2020 at 09:51:15AM +0100, Dmitry Vyukov wrote: > On Thu, Nov 19, 2020 at 10:49 PM Paul E. McKenney wrote: > > > > On Wed, Nov 18, 2020 at 11:53:09AM +0800, qiang.zh...@windriver.com wrote: > > > From: Zqiang > > > > > > Add kasan_rec

Re: [PATCH] tools/rcutorture: Make identify_qemu_vcpus() independant of local language

2020-11-19 Thread Paul E. McKenney
se output every language agree with. > > Signed-off-by: Frederic Weisbecker > Cc: Paul E. McKenney > Cc: Josh Triplett > Cc: Steven Rostedt > Cc: Mathieu Desnoyers > Cc: Lai Jiangshan > Cc: r...@vger.kernel.org Queued for review and testing, thank you! As usual, I coul

Re: [PATCH] rcu: kasan: record and print kvfree_call_rcu call stack

2020-11-19 Thread Paul E. McKenney
On Wed, Nov 18, 2020 at 11:53:09AM +0800, qiang.zh...@windriver.com wrote: > From: Zqiang > > Add kasan_record_aux_stack function for kvfree_call_rcu function to > record call stacks. > > Signed-off-by: Zqiang Thank you, but this does not apply on the "dev" branch of the -rcu tree. See file://

Re: linux-next: stall warnings and deadlock on Arm64 (was: [PATCH] kfence: Avoid stalling...)

2020-11-19 Thread Paul E. McKenney
On Thu, Nov 19, 2020 at 08:38:19PM +0100, Marco Elver wrote: > On Thu, Nov 19, 2020 at 10:48AM -0800, Paul E. McKenney wrote: > > On Thu, Nov 19, 2020 at 06:02:59PM +0100, Marco Elver wrote: [ . . . ] > > > I can try bisection again, or reverting some commits that might be >

Re: [PATCH v2] rcu/segcblist: Add debug checks for segment lengths

2020-11-19 Thread Paul E. McKenney
On Thu, Nov 19, 2020 at 02:44:35PM -0500, Joel Fernandes wrote: > On Thu, Nov 19, 2020 at 2:22 PM Paul E. McKenney wrote: > > > > > > On Wed, Nov 18, 2020 at 11:15:41AM -0500, Joel Fernandes (Google) > > > > > > wrote: > > > > > > > Aft

Re: [PATCH v2] rcu/segcblist: Add debug checks for segment lengths

2020-11-19 Thread Paul E. McKenney
On Thu, Nov 19, 2020 at 01:32:52PM -0500, Joel Fernandes wrote: > On Wed, Nov 18, 2020 at 07:56:13PM -0800, Paul E. McKenney wrote: > > On Wed, Nov 18, 2020 at 07:52:23PM -0800, Paul E. McKenney wrote: > > > On Wed, Nov 18, 2020 at 12:13:35PM -0800, Paul E. McKenney wrote: >

Re: [PATCH] kfence: Avoid stalling work queue task without allocations

2020-11-19 Thread Paul E. McKenney
On Thu, Nov 19, 2020 at 06:02:59PM +0100, Marco Elver wrote: > On Thu, Nov 19, 2020 at 07:14AM -0800, Paul E. McKenney wrote: > > On Thu, Nov 19, 2020 at 01:53:57PM +0100, Marco Elver wrote: > > > On Wed, Nov 18, 2020 at 03:38PM -0800, Paul E. McKenney wrote: > > > >

Re: [PATCH] srcu: Remove srcu_cblist_invoking member from sdp

2020-11-19 Thread Paul E. McKenney
On Thu, Nov 19, 2020 at 01:34:11PM +0800, qiang.zh...@windriver.com wrote: > From: Zqiang > > Workqueue can ensure the multiple same sdp->work sequential > execution in rcu_gp_wq, not need srcu_cblist_invoking to > prevent concurrent execution, so remove it. > > Signed-off-by: Zqiang Good job

Re: [PATCH RFC tip/core/rcu 1/5] srcu: Make Tiny SRCU use multi-bit grace-period counter

2020-11-19 Thread Paul E. McKenney
On Thu, Nov 19, 2020 at 01:44:49PM +0530, Neeraj Upadhyay wrote: > Hi Paul, > > On 11/17/2020 6:10 AM, paul...@kernel.org wrote: > > From: "Paul E. McKenney" > > > > There is a need for a polling interface for SRCU grace periods. This > > polling ne

Re: [PATCH] kfence: Avoid stalling work queue task without allocations

2020-11-19 Thread Paul E. McKenney
On Thu, Nov 19, 2020 at 01:53:57PM +0100, Marco Elver wrote: > On Wed, Nov 18, 2020 at 03:38PM -0800, Paul E. McKenney wrote: > > On Wed, Nov 18, 2020 at 11:56:21PM +0100, Marco Elver wrote: > > > [...] > > > I think I figured out one piece of the puzzle. Bisection keep

Re: [PATCH v2] rcu/segcblist: Add debug checks for segment lengths

2020-11-18 Thread Paul E. McKenney
On Wed, Nov 18, 2020 at 07:52:23PM -0800, Paul E. McKenney wrote: > On Wed, Nov 18, 2020 at 12:13:35PM -0800, Paul E. McKenney wrote: > > On Wed, Nov 18, 2020 at 11:15:41AM -0500, Joel Fernandes (Google) wrote: > > > After rcu_do_batch(), add a check for whether the seg

Re: [PATCH v2] rcu/segcblist: Add debug checks for segment lengths

2020-11-18 Thread Paul E. McKenney
On Wed, Nov 18, 2020 at 12:13:35PM -0800, Paul E. McKenney wrote: > On Wed, Nov 18, 2020 at 11:15:41AM -0500, Joel Fernandes (Google) wrote: > > After rcu_do_batch(), add a check for whether the seglen counts went to > > zero if the list was indeed empty. > > > > Si

Re: linux-next: Signed-off-by missing for commit in the rcu tree

2020-11-18 Thread Paul E. McKenney
On Mon, Sep 28, 2020 at 10:33:13AM -0700, Paul E. McKenney wrote: > On Mon, Sep 28, 2020 at 09:57:29AM +0200, Peter Zijlstra wrote: > > On Thu, Sep 17, 2020 at 11:00:05AM -0700, Paul E. McKenney wrote: > > > On Thu, Sep 17, 2020 at 01:26:52PM +1000, Stephen Rothwell wro

Re: [PATCH] kfence: Avoid stalling work queue task without allocations

2020-11-18 Thread Paul E. McKenney
On Wed, Nov 18, 2020 at 11:56:21PM +0100, Marco Elver wrote: > On Tue, Nov 17, 2020 at 10:29AM -0800, Paul E. McKenney wrote: > [...] > > But it would be good to get the kcompactd() people to look at this (not > > immediately seeing who they are in MAINTAINERS). Per

Re: [PATCH v2] rcu/segcblist: Add debug checks for segment lengths

2020-11-18 Thread Paul E. McKenney
On Wed, Nov 18, 2020 at 11:15:41AM -0500, Joel Fernandes (Google) wrote: > After rcu_do_batch(), add a check for whether the seglen counts went to > zero if the list was indeed empty. > > Signed-off-by: Joel Fernandes (Google) Queued for testing and further review, thank you!

Re: NOHZ tick-stop error: Non-RCU local softirq work is pending

2020-11-18 Thread Paul E. McKenney
On Wed, Nov 18, 2020 at 09:54:20AM -0800, Paul E. McKenney wrote: > On Wed, Nov 18, 2020 at 09:52:18AM -0800, Paul E. McKenney wrote: > > Hello, Frederic, > > > > Here is the last few months' pile of warnings from rcutorture runs. > > And this time with scenario

Re: NOHZ tick-stop error: Non-RCU local softirq work is pending

2020-11-18 Thread Paul E. McKenney
On Wed, Nov 18, 2020 at 09:52:18AM -0800, Paul E. McKenney wrote: > Hello, Frederic, > > Here is the last few months' pile of warnings from rcutorture runs. And this time with scenario names. ;-)

NOHZ tick-stop error: Non-RCU local softirq work is pending

2020-11-18 Thread Paul E. McKenney
Hello, Frederic, Here is the last few months' pile of warnings from rcutorture runs. Thanx, Paul [ 255.098527] NOHZ tick-stop error: Non-RCU local softirq work is pending, handler #282!!! [ 414.534548] NOHZ tick-stop error: Non-RCU local

Re: [PATCH] bpf: don't fail kmalloc while releasing raw_tp

2020-11-17 Thread Paul E. McKenney
On Tue, Nov 17, 2020 at 08:09:22PM -0500, Steven Rostedt wrote: > On Tue, 17 Nov 2020 16:42:44 -0800 > Matt Mullins wrote: > > > > > Indeed with a stub function, I don't see any need for > > > READ_ONCE/WRITE_ONCE. > > > > I'm not sure if this is a practical issue, but without WRITE_ONCE, ca

Re: [PATCH] kfence: Avoid stalling work queue task without allocations

2020-11-17 Thread Paul E. McKenney
On Tue, Nov 17, 2020 at 11:52:36AM +0100, Marco Elver wrote: > On Fri, Nov 13, 2020 at 09:57AM -0800, Paul E. McKenney wrote: > > On Thu, Nov 12, 2020 at 09:54:06AM -0800, Paul E. McKenney wrote: > > > On Thu, Nov 12, 2020 at 05:14:39PM +0100,

[PATCH tip/core/rcu 0/5] Provide SRCU polling grace-period interfaces

2020-11-16 Thread Paul E. McKenney
Hello! This series provides a polling interface for SRCU grace periods. The API is as follows: unsigned long start_poll_synchronize_srcu(struct srcu_struct *ssp) Returns a "cookie" that can be thought of as a snapshot of the specified SRCU instance's grace-period sequence number

[GIT RFC PULL rcu/urgent] Fix lockdep issue in rcu_print_task_stall()

2020-11-16 Thread Paul E. McKenney
7;t invoke try_invoke_on_locked_down_task() with irqs disabled (2020-11-10 17:10:38 -0800) -------- Paul E. McKenney (1): rcu: Don't invoke try_invoke_on_locked_down_task() with irqs disabled kernel/rcu/tree_stall.h | 22 +++

Re: [PATCH] rcu: Allow rcu_irq_enter_check_tick() from NMI

2020-11-16 Thread Paul E. McKenney
rcu_nmi_enter()") > > Reported-by: "Eugenio PĂ©rez" > > Signed-off-by: Peter Zijlstra (Intel) > > Reviewed-by: Andy Lutomirski > > Reviewed-by: Paul E. McKenney > > Reviewed-by: Thomas Gleixner Queued, thank you all! Thanx, Paul

Re: [PATCH v4 20/27] list: fix a typo at the kernel-doc markup

2020-11-16 Thread Paul E. McKenney
On Mon, Nov 16, 2020 at 11:18:16AM +0100, Mauro Carvalho Chehab wrote: > hlist_add_behing -> hlist_add_behind > > Signed-off-by: Mauro Carvalho Chehab Queued, thank you! Or if you would prefer pushing it yourself: Reviewed-by: Paul E. McKenney Either way, please

Re: [PATCH rcu-dev] rcu/trace: Add tracing for how segcb list changes

2020-11-16 Thread Paul E. McKenney
On Sat, Nov 14, 2020 at 02:31:32PM -0500, Joel Fernandes (Google) wrote: > Track how the segcb list changes before/after acceleration, during > queuing and during dequeuing. > > This has proved useful to discover an optimization to avoid unwanted GP > requests when there are no callbacks accelerat

Re: [rcu:dev.2020.11.10a 39/46] ERROR: modpost: "get_state_synchronize_srcu" undefined!

2020-11-15 Thread Paul E. McKenney
On Mon, Nov 16, 2020 at 07:25:48AM +0800, kernel test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git > dev.2020.11.10a > head: 1bc2f285f9c940176cc2c231db1372d5b2f0c635 > commit: 7c1d4bacb30f91a0962490cb9db98371aef1f4d6 [39/46] rcutorture: Add > init

Re: #PF from NMI

2020-11-13 Thread Paul E. McKenney
nge required on return-from-NMI side? > > Looks OK to me at first glance, but I could be missing something. > > No. The corresponding issue is not return from NMI. The corresponding > problem is the return from the page fault handler, but there is nothing > to worry about. Th

Re: [PATCH] kfence: Avoid stalling work queue task without allocations

2020-11-13 Thread Paul E. McKenney
On Thu, Nov 12, 2020 at 09:54:06AM -0800, Paul E. McKenney wrote: > On Thu, Nov 12, 2020 at 05:14:39PM +0100, Marco Elver wrote: [ . . . ] > > | [ 334.160218] BUG: workqueue lockup - pool cpus=0 node=0 flags=0x0 > > nice=0 stuck for 15s! > > It might be instructive

Re: [PATCH] kfence: Avoid stalling work queue task without allocations

2020-11-13 Thread Paul E. McKenney
On Fri, Nov 13, 2020 at 12:06:04PM +0100, Marco Elver wrote: > On Thu, Nov 12, 2020 at 12:00PM -0800, Paul E. McKenney wrote: > > On Thu, Nov 12, 2020 at 07:12:54PM +0100, Marco Elver wrote: > > > On Thu, Nov 12, 2020 at 09:54AM -0800, Paul E. McKenney wrote: > > > >

Re: #PF from NMI

2020-11-13 Thread Paul E. McKenney
On Fri, Nov 13, 2020 at 01:53:32PM +0100, Peter Zijlstra wrote: > Hi > > Eugenio reported > (https://bugzilla.kernel.org/attachment.cgi?id=293659&action=edit): > > [ 139.226723] [ cut here ] > [ 139.226724] WARNING: CPU: 9 PID: 2290 at kernel/rcu/tree.c:932 > __rcu_irq_

Re: [PATCH] kfence: Avoid stalling work queue task without allocations

2020-11-12 Thread Paul E. McKenney
On Thu, Nov 12, 2020 at 07:12:54PM +0100, Marco Elver wrote: > On Thu, Nov 12, 2020 at 09:54AM -0800, Paul E. McKenney wrote: > > On Thu, Nov 12, 2020 at 05:14:39PM +0100, Marco Elver wrote: > > > On Thu, Nov 12, 2020 at 01:49PM +0100, Marco Elver wrote: > > > > On T

Re: [PATCH] kfence: Avoid stalling work queue task without allocations

2020-11-12 Thread Paul E. McKenney
On Thu, Nov 12, 2020 at 05:14:39PM +0100, Marco Elver wrote: > On Thu, Nov 12, 2020 at 01:49PM +0100, Marco Elver wrote: > > On Thu, 12 Nov 2020 at 01:11, Paul E. McKenney wrote: > [...] > > > > This assert didn't fire yet, I just get more of the below. I'll keep

Re: [PATCH] kfence: Avoid stalling work queue task without allocations

2020-11-11 Thread Paul E. McKenney
On Wed, Nov 11, 2020 at 09:21:53PM +0100, Marco Elver wrote: > On Wed, Nov 11, 2020 at 11:21AM -0800, Paul E. McKenney wrote: > [...] > > > > rcu: Don't invoke try_invoke_on_locked_down_task() with irqs > > > > disabled > > > > > > Sa

Re: [PATCH] rcu: Check and report missed fqs timer wakeup on RCU stall

2020-11-11 Thread Paul E. McKenney
On Wed, Nov 11, 2020 at 07:37:37PM +0530, Neeraj Upadhyay wrote: > For a new grace period request, RCU GP kthread transitions > through following states: > > a. [RCU_GP_WAIT_GPS] -> [RCU_GP_DONE_GPS] > > Initial state, where GP kthread waits for a new GP start > request is RCU_GP_WAIT_GPS. On new

Re: [PATCH] kfence: Avoid stalling work queue task without allocations

2020-11-11 Thread Paul E. McKenney
On Wed, Nov 11, 2020 at 07:34:30PM +0100, Marco Elver wrote: > On Wed, Nov 11, 2020 at 10:23AM -0800, Paul E. McKenney wrote: > > On Wed, Nov 11, 2020 at 01:05:43PM -0500, Steven Rostedt wrote: > > > On Wed, 11 Nov 2020 14:38:13 +0100 > > > Marco Elver wrote: > &

Re: [PATCH] kfence: Avoid stalling work queue task without allocations

2020-11-11 Thread Paul E. McKenney
imeout+0x394/0x530 > > | rcu_gp_kthread+0x76c/0x19a8 > > | kthread+0x174/0x188 > > | ret_from_fork+0x10/0x18 > > | > > | > > | WARNING: inconsistent lock state > > | 5.10.0-rc3-next-20201110-1-gc07b306d7fa5-dirty #18 N

Re: [PATCH v9 4/7] rcu/trace: Add tracing for how segcb list changes

2020-11-10 Thread Paul E. McKenney
On Tue, Nov 03, 2020 at 09:26:00AM -0500, Joel Fernandes (Google) wrote: > Track how the segcb list changes before/after acceleration, during > queuing and during dequeuing. > > This has proved useful to discover an optimization to avoid unwanted GP > requests when there are no callbacks accelerat

Re: [PATCH tip/core/rcu 2/4] docs: Update RCU's hotplug requirements with a bit about design

2020-11-10 Thread Paul E. McKenney
On Tue, Nov 10, 2020 at 03:33:28PM -0500, Joel Fernandes wrote: > On Mon, Nov 09, 2020 at 06:14:33PM +0100, Peter Zijlstra wrote: > > On Mon, Nov 09, 2020 at 08:24:52AM -0800, Paul E. McKenney wrote: > > > On Mon, Nov 09, 2020 at 01:23:17PM +0100, Peter Zijlstra wrote: > >

Re: [PATCH][next] cpumask: allocate enough space for string and trailing '\0' char

2020-11-10 Thread Paul E. McKenney
On Tue, Nov 10, 2020 at 03:34:05PM +, Colin Ian King wrote: > On 10/11/2020 15:24, Paul E. McKenney wrote: > > On Mon, Nov 09, 2020 at 11:57:15PM -0500, Paul Gortmaker wrote: > >> > >> > >> On 2020-11-09 8:07 p.m., Qian Cai wrote: > >>> On

Re: [PATCH v2 0/4] support for global CPU list abbreviations

2020-11-10 Thread Paul E. McKenney
core machine with CONFIG_NR_CPUS=16 in .config file. > > Note that the two use cases (boot and runtime) are why you see "early" > parameter in the code - I entertained just sticking the string copy on > the stack vs. the early alloc dance, but this felt more correct/robu

Re: [PATCH][next] cpumask: allocate enough space for string and trailing '\0' char

2020-11-10 Thread Paul E. McKenney
On Mon, Nov 09, 2020 at 11:57:15PM -0500, Paul Gortmaker wrote: > > > On 2020-11-09 8:07 p.m., Qian Cai wrote: > > On Mon, 2020-11-09 at 13:04 +, Colin King wrote: > > > From: Colin Ian King > > > > > > Currently the allocation of cpulist is based on the length of buf but does > > > not inc

Re: linux-next: build warnings after merge of the rcu tree

2020-11-10 Thread Paul E. McKenney
On Tue, Nov 10, 2020 at 05:59:52PM +1100, Stephen Rothwell wrote: > Hi all, > > After merging the rcu tree, today's linux-next build (htmldocs) > produced these warnings: > > Documentation/RCU/Design/Requirements/Requirements.rst:119: WARNING: > Malformed table. My bad, apologies, queuing an al

Re: [PATCH tip/core/rcu 4/4] docs/rcu: Update the call_rcu() API

2020-11-10 Thread Paul E. McKenney
On Tue, Nov 10, 2020 at 10:25:05AM +0100, Peter Zijlstra wrote: > On Mon, Nov 09, 2020 at 05:20:32PM -0800, Paul E. McKenney wrote: > > On Mon, Nov 09, 2020 at 01:24:24PM +0100, Peter Zijlstra wrote: > > > On Thu, Nov 05, 2020 at 03:05:10PM -0800, paul...@kernel.org wrote: &g

Re: [PATCH v9 6/7] rcu/tree: segcblist: Remove redundant smp_mb()s

2020-11-09 Thread Paul E. McKenney
On Fri, Nov 06, 2020 at 07:26:04PM -0500, Joel Fernandes wrote: > On Wed, Nov 04, 2020 at 07:57:13PM -0800, Paul E. McKenney wrote: > > On Tue, Nov 03, 2020 at 09:26:02AM -0500, Joel Fernandes (Google) wrote: > > > This memory barrier is not needed as rcu_segcblist_add_len() alre

Re: [PATCH v9 2/7] rcu/segcblist: Add counters to segcblist datastructure

2020-11-09 Thread Paul E. McKenney
On Fri, Nov 06, 2020 at 04:48:15PM -0800, Paul E. McKenney wrote: > On Fri, Nov 06, 2020 at 07:18:47PM -0500, Joel Fernandes wrote: > > On Fri, Nov 06, 2020 at 07:01:57PM -0500, Joel Fernandes wrote: > > > On Wed, Nov 04, 2020 at 09:01:33AM -0800, Paul E. McKenney wrote: >

Re: [PATCH v9 7/7] rcu/segcblist: Add additional comments to explain smp_mb()

2020-11-09 Thread Paul E. McKenney
On Fri, Nov 06, 2020 at 05:41:41PM -0500, Joel Fernandes wrote: > On Thu, Nov 05, 2020 at 10:55:51AM -0800, Paul E. McKenney wrote: > > On Tue, Nov 03, 2020 at 09:26:03AM -0500, Joel Fernandes (Google) wrote: > > > Memory barriers are needed when updating the full length of t

Re: [PATCH tip/core/rcu 4/4] docs/rcu: Update the call_rcu() API

2020-11-09 Thread Paul E. McKenney
n-coded function definition. > > > > Signed-off-by: Hui Su > > Signed-off-by: Paul E. McKenney > > --- > > Documentation/RCU/whatisRCU.rst | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/Documentation/RCU/what

Re: [PATCH tip/core/rcu 2/4] docs: Update RCU's hotplug requirements with a bit about design

2020-11-09 Thread Paul E. McKenney
deadlocks, however the description of deadlocks other than those involving > > rcu_barrier() is rather incomplete. > > > > This commit therefore continues the section by describing how RCU's > > design handles CPU hotplug in a deadlock-free way. > >

Re: [PATCH tip/core/rcu 1/4] doc: Present the role of READ_ONCE()

2020-11-09 Thread Paul E. McKenney
On Mon, Nov 09, 2020 at 01:21:33PM +0100, Peter Zijlstra wrote: > On Thu, Nov 05, 2020 at 03:05:07PM -0800, paul...@kernel.org wrote: > > From: "Paul E. McKenney" > > > > This commit adds an explanation of the special cases where READ_ONCE() > > ma

Re: [PATCH 0/4] RFC: support for global CPU list abbreviations

2020-11-08 Thread Paul E. McKenney
On Sun, Nov 08, 2020 at 03:21:40PM -0500, Paul Gortmaker wrote: > On 2020-11-08 1:02 p.m., Paul E. McKenney wrote: > > > Or I can carry them if you wish. My expected changes in response to > > this series are shown below, and are also what I used to test it. > > Than

Re: [PATCH 0/4] RFC: support for global CPU list abbreviations

2020-11-08 Thread Paul E. McKenney
e early alloc dance, but this felt more correct/robust. > The cgroup and modular code using cpulist_parse() are runtime cases. I considered doing this when adding "all" for RCU, but was just too lazy. So you are a better man than I am! ;-)

Re: [PATCH] locking: remove duplicate include of percpu-rwsem.h

2020-11-07 Thread Paul E. McKenney
licate include of percpu-rwsem.h This commit removes an unnecessary #include. Signed-off-by: Wang Qing Signed-off-by: Paul E. McKenney diff --git a/kernel/locking/locktorture.c b/kernel/locking/locktorture.c index fd838ce..0ab94e1 100644 --- a/kernel/locking/locktortur

Re: [PATCH v9 2/7] rcu/segcblist: Add counters to segcblist datastructure

2020-11-06 Thread Paul E. McKenney
On Fri, Nov 06, 2020 at 07:18:47PM -0500, Joel Fernandes wrote: > On Fri, Nov 06, 2020 at 07:01:57PM -0500, Joel Fernandes wrote: > > On Wed, Nov 04, 2020 at 09:01:33AM -0800, Paul E. McKenney wrote: > > > > > A casual reader might be forgiven for being confused by

Re: [PATCH memory-model 5/8] tools/memory-model: Add a glossary of LKMM terms

2020-11-06 Thread Paul E. McKenney
On Fri, Nov 06, 2020 at 03:40:08PM -0500, Alan Stern wrote: > On Fri, Nov 06, 2020 at 11:59:12AM -0800, Paul E. McKenney wrote: > > On Fri, Nov 06, 2020 at 02:23:51PM -0500, Alan Stern wrote: > > > On Fri, Nov 06, 2020 at 10:04:46AM -0800, Paul E. McKenney wrote: > > > &

Re: [PATCH memory-model 5/8] tools/memory-model: Add a glossary of LKMM terms

2020-11-06 Thread Paul E. McKenney
On Fri, Nov 06, 2020 at 02:23:51PM -0500, Alan Stern wrote: > On Fri, Nov 06, 2020 at 10:04:46AM -0800, Paul E. McKenney wrote: > > On Fri, Nov 06, 2020 at 11:59:30AM -0500, Alan Stern wrote: > > > > +See also "Control Dependency". > > > >

Re: [PATCH tip/core/rcu 03/28] locktorture: Track time of last ->writeunlock()

2020-11-06 Thread Paul E. McKenney
On Thu, Nov 05, 2020 at 10:56:42PM -0800, Davidlohr Bueso wrote: > On Thu, 05 Nov 2020, paul...@kernel.org wrote: > > > From: "Paul E. McKenney" > > > > This commit adds a last_lock_release variable that tracks the time of > > the last ->writeunloc

Re: [PATCH memory-model 3/8] tools/memory-model: Document categories of ordering primitives

2020-11-06 Thread Paul E. McKenney
On Fri, Nov 06, 2020 at 11:56:54AM -0500, Alan Stern wrote: > On Thu, Nov 05, 2020 at 02:00:12PM -0800, paul...@kernel.org wrote: > > From: "Paul E. McKenney" > > > > The Linux kernel has a number of categories of ordering primitives, which > > are recorded

Re: [PATCH memory-model 5/8] tools/memory-model: Add a glossary of LKMM terms

2020-11-06 Thread Paul E. McKenney
On Fri, Nov 06, 2020 at 11:59:30AM -0500, Alan Stern wrote: > On Thu, Nov 05, 2020 at 02:00:14PM -0800, paul...@kernel.org wrote: > > From: "Paul E. McKenney" > > > > Signed-off-by: Paul E. McKenney > > --- > > tools/me

Re: [PATCH memory-model 5/8] tools/memory-model: Add a glossary of LKMM terms

2020-11-06 Thread Paul E. McKenney
On Fri, Nov 06, 2020 at 09:47:22AM +0800, Boqun Feng wrote: > On Thu, Nov 05, 2020 at 02:00:14PM -0800, paul...@kernel.org wrote: > > From: "Paul E. McKenney" > > > > Signed-off-by: Paul E. McKenney > > --- > > tools/me

Re: [PATCH 2/2] arm64: smp: Tell RCU about CPUs that fail to come online

2020-11-06 Thread Paul E. McKenney
_from_fork+0x0/0x30 > > Ensure that the dying CPU invokes rcu_report_dead() prior to being powered > off or parked. > > Cc: Qian Cai > Cc: "Paul E. McKenney" > Suggested-by: Qian Cai > Signed-off-by: Will Deacon Reviewed-by: Paul E. McKenney > --- >

Re: [PATCH] arm64/smp: Move rcu_cpu_starting() earlier

2020-11-05 Thread Paul E. McKenney
On Thu, Nov 05, 2020 at 09:15:24PM -0500, Qian Cai wrote: > On Thu, 2020-11-05 at 15:28 -0800, Paul E. McKenney wrote: > > On Thu, Nov 05, 2020 at 06:02:49PM -0500, Qian Cai wrote: > > > On Thu, 2020-11-05 at 22:22 +, Will Deacon wrote: > > > > On Fri, Oct 30,

[PATCH tip/core/rcu 0/28] Torture-test updates for v5.11

2020-11-05 Thread Paul E. McKenney
Hello! This series contains torture-test updates: 1. Bounds-check module parameters. 2. Don't kill gdb sessions. 3. Track time of last ->writeunlock(). 4. Periodically pause in stutter_wait(). 5. Make torture_stutter() use hrtimer. 6. Add an alternative IPI vect

[PATCH tip/core/rcu 0/4] RCU-tasks updates for v5.11

2020-11-05 Thread Paul E. McKenney
Hello! This series contains updates to the various RCU-tasks flavors: 1. Make preemptible TRACE02 enable lockdep. 2. Convert rcu_tasks_wait_gp() for-loop to while-loop. 3. Make grace-period kthread report match RCU flavor being tested. 4. Make the units of ->init_fract be j

Re: [PATCH] arm64/smp: Move rcu_cpu_starting() earlier

2020-11-05 Thread Paul E. McKenney
On Thu, Nov 05, 2020 at 06:02:49PM -0500, Qian Cai wrote: > On Thu, 2020-11-05 at 22:22 +, Will Deacon wrote: > > On Fri, Oct 30, 2020 at 04:33:25PM +, Will Deacon wrote: > > > On Wed, 28 Oct 2020 14:26:14 -0400, Qian Cai wrote: > > > > The call to rcu_cpu_starting() in secondary_start_kern

[PATCH tip/core/rcu 0/7] Lockdep-RCU updates for v5.11

2020-11-05 Thread Paul E. McKenney
Hello! This series simplifies use of the lockdep-RCU API, all courtesy of Jakub Kicinski: 1. Un-hide lockdep_tasklist_lock_is_held() for !LOCKDEP. 2. Un-hide RCU lockdep maps for !LOCKDEP. 3. Un-hide networking lockdep_sock_is_held() for !LOCKDEP. 4. Remove broken definitio

[PATCH tip/core/rcu 0/16] Miscellaneous fixes for v5.11

2020-11-05 Thread Paul E. McKenney
Hello! This series contains miscellaneous fixes: 1. Don't invoke try_invoke_on_locked_down_task() with irqs disabled. 2. Move x86's rcu_cpu_starting() earlier. 3. Panic after fixed number of stalls. 4. Update list.h comment to explicitly note circular lists. 5. Implem

[PATCH tip/core/rcu 0/4] Documentations updates for v5.11

2020-11-05 Thread Paul E. McKenney
Hello! This series contains documentation updates: 1. Present the role of READ_ONCE(). 2. Update RCU's hotplug requirements with a bit about design. 3. Fix a Requirements.rst list block. 4. Update the call_rcu() API. Thanx, P

[PATCH tip/core/rcu 0/2] smp_call_function updates for v5.11

2020-11-05 Thread Paul E. McKenney
Hello! This series prevents /proc/cpuinfo from piling up quite so many redundant IPIs, and also avoids IPIing idle CPUs. 1. Avoid cpuinfo-induced IPI pileups. 2. Avoid cpuinfo-induced IPIing of idle CPUs. Thanx, Paul ---

<    3   4   5   6   7   8   9   10   11   12   >