[PATCH] media: i2c: ov8865: remove unnecessary NULL check

2021-04-12 Thread Paul Kocialkowski
The check on mode_index is sufficient to ensure that we have a valid mode. Remove the explicit mode check similarly to commit 38a50230292f ("media: i2c: ov5648: remove unnecessary NULL check") Signed-off-by: Paul Kocialkowski --- drivers/media/i2c/ov8865.c | 2 +- 1 file changed, 1

Re: linux-next: manual merge of the irqchip tree with the sunxi tree

2021-02-26 Thread Paul Kocialkowski
Hi, On Thu 18 Feb 21, 15:48, Stephen Rothwell wrote: > Hi all, > > On Mon, 15 Feb 2021 09:11:24 +1100 Stephen Rothwell > wrote: > > > > On Mon, 1 Feb 2021 14:42:59 +1100 Stephen Rothwell > > wrote: > > > > > > Today's linux-next merge of the irqchip tree got a conflict in: > > > > > > >

Re: [PATCH v1 00/18] Add HANTRO G2/HEVC decoder support for IMX8MQ

2021-02-17 Thread Paul Kocialkowski
nk significant work is still needed. This initial implementation was kind of a proof of concept for simple cases. Cheers, Paul -- Paul Kocialkowski, Bootlin Embedded Linux and kernel engineering https://bootlin.com signature.asc Description: PGP signature

Re: BOG: commit 89c7cb1608ac3 ("of/device: Update dma_range_map only when dev has valid dma-ranges") seems to break Pinephone display or LCDC

2021-02-05 Thread Paul Kocialkowski
Hey, On Tue 02 Feb 21, 16:07, H. Nikolaus Schaller wrote: > Hi Paul, > > > Am 02.02.2021 um 14:42 schrieb Paul Kocialkowski > > : > > > > Hi Nikolaus, > > > > On Tue 02 Feb 21, 11:50, H. Nikolaus Schaller wrote: > >> Hi Paul, > >

Re: BOG: commit 89c7cb1608ac3 ("of/device: Update dma_range_map only when dev has valid dma-ranges") seems to break Pinephone display or LCDC

2021-02-02 Thread Paul Kocialkowski
Hi Nikolaus, On Tue 02 Feb 21, 11:50, H. Nikolaus Schaller wrote: > Hi Paul, > > > Am 02.02.2021 um 10:56 schrieb Paul Kocialkowski > > : > > > > Hi Nikolaus, > > > > On Tue 02 Feb 21, 10:18, H. Nikolaus Schaller wrote: > >> Hi, > &g

Re: BOG: commit 89c7cb1608ac3 ("of/device: Update dma_range_map only when dev has valid dma-ranges") seems to break Pinephone display or LCDC

2021-02-02 Thread Paul Kocialkowski
s to the same location. So IMO the MBUS dma-ranges shouldn't apply to DE2. I think this is already the case in dt, but the mbus driver may add it if you don't have that patch. I think I have a few A64 boards around, but probably not with 2 GiB RAM. If adding the patch doesn't help, I'll try to make a

Re: [PATCH 2/2] soc: sunxi: mbus: Remove DE2 display engine compatibles

2021-01-27 Thread Paul Kocialkowski
Hi, On Fri 15 Jan 21, 18:58, Paul Kocialkowski wrote: > The DE2 display engine hardware takes physical addresses that do not > need PHYS_BASE subtracted. As a result, they should not be present > on the mbus driver match list. Remove them. > > This was tested on the A83T, along

Re: [PATCH 1/2] of: device: Allow DMA range map to be set before of_dma_configure_id

2021-01-27 Thread Paul Kocialkowski
Hi, On Fri 15 Jan 21, 18:58, Paul Kocialkowski wrote: > A mechanism was recently introduced for the sunxi architecture where > the DMA offset for specific devices (under the MBUS) is set by a common > driver (sunxi_mbus). This driver calls dma_direct_set_offset to set > the device's d

Re: [PATCH v2] of/device: Update dma_range_map only when dev has valid dma-ranges

2021-01-27 Thread Paul Kocialkowski
es: e0d072782c73 ("dma-mapping: introduce DMA range map, supplanting > dma_pfn_offset"), > Suggested-by: Robin Murphy > Signed-off-by: Yong Wu > Signed-off-by: Paul Kocialkowski > Reviewed-by: Rob Herring > --- > drivers/of/device.c | 10 +++--- > 1 file changed, 7

Re: [PATCH v6 06/33] of/device: Move dma_range_map before of_iommu_configure

2021-01-19 Thread Paul Kocialkowski
nges, this looks good to me! Thanks, Paul > > > > Robin. > > > > [1] > > https://lore.kernel.org/linux-arm-kernel/5c7946f3-b56e-da00-a750-be097c7ce...@arm.com/ > > > > >> > > >>> return -EPROBE_DEFER; > > >>> } > > >>> > > >>> @@ -181,7 +183,6 @@ int of_dma_configure_id(struct device *dev, struct > > >>> device_node *np, > > >>> > > >>> arch_setup_dma_ops(dev, dma_start, size, iommu, coherent); > > >>> > > >>> - dev->dma_range_map = map; > > >>> return 0; > > >>> } > > >>> EXPORT_SYMBOL_GPL(of_dma_configure_id); > > >>> -- > > >>> 2.18.0 > > >>> > > > > > > ___ > > > iommu mailing list > > > io...@lists.linux-foundation.org > > > https://lists.linuxfoundation.org/mailman/listinfo/iommu > > > > -- Paul Kocialkowski, Bootlin Embedded Linux and kernel engineering https://bootlin.com signature.asc Description: PGP signature

Re: [PATCH v6 06/33] of/device: Move dma_range_map before of_iommu_configure

2021-01-19 Thread Paul Kocialkowski
> https://lore.kernel.org/linux-arm-kernel/5c7946f3-b56e-da00-a750-be097c7ce...@arm.com/ > > > > > > > > return -EPROBE_DEFER; > > > > } > > > > @@ -181,7 +183,6 @@ int of_dma_configure_id(struct device *dev, struct > > > > device_node *np, > > > > arch_setup_dma_ops(dev, dma_start, size, iommu, coherent); > > > > - dev->dma_range_map = map; > > > > return 0; > > > > } > > > > EXPORT_SYMBOL_GPL(of_dma_configure_id); > > > > -- > > > > 2.18.0 > > > > > > > > ___ > > iommu mailing list > > io...@lists.linux-foundation.org > > https://lists.linuxfoundation.org/mailman/listinfo/iommu > > -- Paul Kocialkowski, Bootlin Embedded Linux and kernel engineering https://bootlin.com signature.asc Description: PGP signature

Re: [PATCH 1/2] of: device: Allow DMA range map to be set before of_dma_configure_id

2021-01-19 Thread Paul Kocialkowski
Hi Robin, On Mon 18 Jan 21, 13:27, Robin Murphy wrote: > On 2021-01-16 17:07, Paul Kocialkowski wrote: > > Hi Robin, > > > > Le Sat 16 Jan 21, 14:57, Robin Murphy a écrit : > > > On 2021-01-15 17:58, Paul Kocialkowski wrote: > > > > A mechanism was rece

Re: [PATCH] media: i2c: fix odd_ptr_err.cocci warnings

2021-01-18 Thread Paul Kocialkowski
Hi, On Sat 16 Jan 21, 21:11, Julia Lawall wrote: > From: kernel test robot > > PTR_ERR should access the value just tested by IS_ERR Good catch! Reviewed-by: Paul Kocialkowski Cheers, Paul > Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci > > Fixes: 11c0d8f

Re: [PATCH 1/2] of: device: Allow DMA range map to be set before of_dma_configure_id

2021-01-16 Thread Paul Kocialkowski
Hi Robin, Le Sat 16 Jan 21, 14:57, Robin Murphy a écrit : > On 2021-01-15 17:58, Paul Kocialkowski wrote: > > A mechanism was recently introduced for the sunxi architecture where > > the DMA offset for specific devices (under the MBUS) is set by a common > > driver (sunxi_mbu

[PATCH v5 02/16] phy: Distinguish between Rx and Tx for MIPI D-PHY with submodes

2021-01-15 Thread Paul Kocialkowski
(zero value) is kept to Tx so only the rkisp1 driver, which uses D-PHY in Rx mode, needs to be adapted. Signed-off-by: Paul Kocialkowski Acked-by: Helen Koike --- drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c | 3 ++- include/linux/phy/phy-mipi-dphy.h | 13

[PATCH v5 13/16] dt-bindings: media: Add A83T MIPI CSI-2 bindings documentation

2021-01-15 Thread Paul Kocialkowski
This introduces YAML bindings documentation for the A83T MIPI CSI-2 controller. Signed-off-by: Paul Kocialkowski Reviewed-by: Rob Herring --- .../media/allwinner,sun8i-a83t-mipi-csi2.yaml | 147 ++ 1 file changed, 147 insertions(+) create mode 100644 Documentation/devicetree

[PATCH v5 10/16] media: sunxi: Add support for the A31 MIPI CSI-2 controller

2021-01-15 Thread Paul Kocialkowski
supported by this implementation. Signed-off-by: Paul Kocialkowski Acked-by: Maxime Ripard --- drivers/media/platform/sunxi/Kconfig | 1 + drivers/media/platform/sunxi/Makefile | 1 + .../platform/sunxi/sun6i-mipi-csi2/Kconfig| 12 + .../platform/sunxi/sun6i-mipi-csi2

[PATCH v5 15/16] ARM: dts: sun8i: a83t: Add MIPI CSI-2 controller node

2021-01-15 Thread Paul Kocialkowski
on the CSI driver. Signed-off-by: Paul Kocialkowski --- arch/arm/boot/dts/sun8i-a83t.dtsi | 26 ++ 1 file changed, 26 insertions(+) diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi index c010b27fdb6a..d6d55c12b995 100644 --- a/arch/arm

[PATCH v5 16/16] MAINTAINERS: Add entry for the Allwinner A83T MIPI CSI-2 bridge

2021-01-15 Thread Paul Kocialkowski
Add myself as maintainer of the A83T MIPI CSI-2 bridge media driver. Signed-off-by: Paul Kocialkowski --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index a41c41f6387c..af8095085f0f 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -718,6

[PATCH v5 00/16] Allwinner MIPI CSI-2 support for A31/V3s/A83T

2021-01-15 Thread Paul Kocialkowski
ported) test VIDIOC_(TRY_)DECODER_CMD: OK (Not Supported) Buffer ioctls (Input 0): test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK test VIDIOC_EXPBUF: OK test Requests: OK (Not Supported) Total for sun6i-video device /dev/video0: 45, Succeeded: 45, Failed: 0, Warnings: 6

[PATCH v5 01/16] docs: phy: Add a part about PHY mode and submode

2021-01-15 Thread Paul Kocialkowski
Besides giving pointers to the relevant functions for PHY mode and submode configuration, this clarifies the need to set them before powering on the PHY. Signed-off-by: Paul Kocialkowski Reviewed-by: Maxime Ripard --- Documentation/driver-api/phy/phy.rst | 18 ++ 1 file changed

[PATCH v5 14/16] media: sunxi: Add support for the A83T MIPI CSI-2 controller

2021-01-15 Thread Paul Kocialkowski
-csi driver. It was tested on a Banana Pi M3 board with an OV8865 sensor in a 4-lane configuration. Signed-off-by: Paul Kocialkowski Acked-by: Maxime Ripard --- drivers/media/platform/sunxi/Kconfig | 1 + drivers/media/platform/sunxi/Makefile | 1 + .../sunxi/sun8i-a83t-mipi

[PATCH v5 11/16] ARM: dts: sun8i: v3s: Add nodes for MIPI CSI-2 support

2021-01-15 Thread Paul Kocialkowski
is connected but this is fine since no other interface is available. Signed-off-by: Paul Kocialkowski --- arch/arm/boot/dts/sun8i-v3s.dtsi | 68 1 file changed, 68 insertions(+) diff --git a/arch/arm/boot/dts/sun8i-v3s.dtsi b/arch/arm/boot/dts/sun8i-v3s.dtsi

[PATCH v5 12/16] MAINTAINERS: Add entry for the Allwinner A31 MIPI CSI-2 bridge

2021-01-15 Thread Paul Kocialkowski
Add myself as maintainer of the A31 MIPI CSI-2 bridge media driver. Signed-off-by: Paul Kocialkowski --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 57f9e3047227..a41c41f6387c 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -710,6

[PATCH v5 08/16] media: sun6i-csi: Add support for MIPI CSI-2 bridge input

2021-01-15 Thread Paul Kocialkowski
the controller's output to the ISP instead of its DMA engine. Finally note that the MIPI CSI-2 bridges should not be linked in the fwnode graph unless they have a sensor subdev attached. Signed-off-by: Paul Kocialkowski Acked-by: Maxime Ripard --- .../platform/sunxi/sun6i-csi/sun6i_csi.c | 111

[PATCH v5 07/16] dt-bindings: media: sun6i-a31-csi: Add MIPI CSI-2 input port

2021-01-15 Thread Paul Kocialkowski
. Signed-off-by: Paul Kocialkowski Reviewed-by: Rob Herring Acked-by: Maxime Ripard --- .../media/allwinner,sun6i-a31-csi.yaml| 88 --- 1 file changed, 75 insertions(+), 13 deletions(-) diff --git a/Documentation/devicetree/bindings/media/allwinner,sun6i-a31-csi.yaml

[PATCH v5 09/16] dt-bindings: media: Add A31 MIPI CSI-2 bindings documentation

2021-01-15 Thread Paul Kocialkowski
This introduces YAML bindings documentation for the A31 MIPI CSI-2 controller. Signed-off-by: Paul Kocialkowski Reviewed-by: Maxime Ripard Reviewed-by: Rob Herring --- .../media/allwinner,sun6i-a31-mipi-csi2.yaml | 156 ++ 1 file changed, 156 insertions(+) create mode 100644

[PATCH v5 05/16] media: sun6i-csi: Use common V4L2 format info for storage bpp

2021-01-15 Thread Paul Kocialkowski
switch/case was also wrong concerning 10/12-bit Bayer formats, which are aligned to 16 bits in memory. Using the common helper fixes it. Fixes: 5cc7522d8965 ("media: sun6i: Add support for Allwinner CSI V3s") Signed-off-by: Paul Kocialkowski Acked-by: Maxime Ripard --- .../platform/sunxi

[PATCH v5 06/16] media: sun6i-csi: Only configure the interface data width for parallel

2021-01-15 Thread Paul Kocialkowski
block is moved around before the interlaced conditional block for nicer code symmetry (conditional blocks first) while at it. Co-developed-by: Kévin L'hôpital Signed-off-by: Kévin L'hôpital Signed-off-by: Paul Kocialkowski Acked-by: Maxime Ripard --- .../platform/sunxi/sun6i-csi/sun6i_csi.c

[PATCH v5 04/16] media: sun6i-csi: Stop using the deprecated fwnode endpoint parser

2021-01-15 Thread Paul Kocialkowski
The v4l2_async_notifier_parse_fwnode_endpoints helper is getting deprecated in favor of explicit parsing of the endpoints. Implement it instead of using this deprecated function. Since this was the last user of the helper, it should now be safe to remove. Signed-off-by: Paul Kocialkowski

[PATCH v5 03/16] phy: allwinner: phy-sun6i-mipi-dphy: Support D-PHY Rx mode for MIPI CSI-2

2021-01-15 Thread Paul Kocialkowski
. Signed-off-by: Paul Kocialkowski Acked-by: Maxime Ripard --- drivers/phy/allwinner/phy-sun6i-mipi-dphy.c | 164 +++- 1 file changed, 160 insertions(+), 4 deletions(-) diff --git a/drivers/phy/allwinner/phy-sun6i-mipi-dphy.c b/drivers/phy/allwinner/phy-sun6i-mipi-dphy.c index

[PATCH 2/2] soc: sunxi: mbus: Remove DE2 display engine compatibles

2021-01-15 Thread Paul Kocialkowski
display. Fixes: b4bdc4fbf8d0 ("soc: sunxi: Deal with the MBUS DMA offsets in a central place") Signed-off-by: Paul Kocialkowski --- drivers/soc/sunxi/sunxi_mbus.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/soc/sunxi/sunxi_mbus.c b/drivers/soc/sunxi/sunxi_mb

[PATCH 1/2] of: device: Allow DMA range map to be set before of_dma_configure_id

2021-01-15 Thread Paul Kocialkowski
to ensure that no previous DMA range map is overwritten and prints a warning when the map was already set while also being available from dt. In this case, the map that was already set is kept. Fixes: b4bdc4fbf8d0 ("soc: sunxi: Deal with the MBUS DMA offsets in a central place") Signed-of

Re: [linux-sunxi] [PATCH v4 09/15] media: sunxi: Add support for the A31 MIPI CSI-2 controller

2021-01-14 Thread Paul Kocialkowski
Hey Ezequiel, On Mon 11 Jan 21, 15:21, Ezequiel Garcia wrote: > Salut Paul, > > Just a minor comment about the v4l2 async API. > > On Thu, 31 Dec 2020 at 11:30, Paul Kocialkowski > wrote: > > > > The A31 MIPI CSI-2 controller is a dedicated MIPI CSI-2 brid

Re: [PATCH][next] media: i2c: fix spelling mistakes: "enpoint" -> "endpoint"

2021-01-14 Thread Paul Kocialkowski
Hi, On Wed 13 Jan 21, 10:05, Colin King wrote: > From: Colin Ian King > > There are two spelling mistakes in dev_err messages. Fix these. Thanks for the patch! Reviewed-by: Paul Kocialkowski Cheers, Paul > Signed-off-by: Colin Ian King > --- > drivers/medi

Re: [PATCH 5/5] media: hantro: Add support for the Rockchip PX30

2021-01-11 Thread Paul Kocialkowski
Hi, On Fri 08 Jan 21, 10:13, Ezequiel Garcia wrote: > On Fri, 2021-01-08 at 10:05 +0100, Paul Kocialkowski wrote: > > Hi Ezequiel, > > > > On Thu 07 Jan 21, 16:08, Ezequiel Garcia wrote: > > > Happy to see this patch. It was on my TODO list, > > > but

Re: [PATCH 3/5] dt-bindings: media: rockchip-vpu: Add PX30 compatible

2021-01-11 Thread Paul Kocialkowski
Hi Philipp, On Thu 07 Jan 21, 15:55, Philipp Zabel wrote: > Hi Paul, > > On Thu, 2021-01-07 at 14:40 +0100, Paul Kocialkowski wrote: > > The Rockchip PX30 SoC has a Hantro VPU that features a decoder (VDPU2) > > and an encoder (VEPU2). It is similar to the RK3399's VPU b

Re: [PATCH v4 09/15] media: sunxi: Add support for the A31 MIPI CSI-2 controller

2021-01-11 Thread Paul Kocialkowski
Hi Samuel, On Sat 09 Jan 21, 16:24, Samuel Holland wrote: > On 12/31/20 8:29 AM, Paul Kocialkowski wrote: > > The A31 MIPI CSI-2 controller is a dedicated MIPI CSI-2 bridge > > found on Allwinner SoCs such as the A31 and V3/V3s. > > > > It is a standalone block, conn

Re: [PATCH 5/5] media: hantro: Add support for the Rockchip PX30

2021-01-08 Thread Paul Kocialkowski
-01-07 at 14:41 +0100, Paul Kocialkowski wrote: > > The PX30 SoC includes both the VDPU2 and VEPU2 blocks which are similar > > to the RK3399 (Hantro G1/H1 with shuffled registers). > > > > Besides taking an extra clock, it also shares an interrupt with the IOMMU > &g

Re: [PATCH 2/5] arm64: dts: rockchip: Add RGA support to the PX30

2021-01-07 Thread Paul Kocialkowski
On Thu 07 Jan 21, 14:40, Paul Kocialkowski wrote: > The PX30 features a RGA block: add the necessary node to support it. > > Signed-off-by: Paul Kocialkowski > --- > arch/arm64/boot/dts/rockchip/px30.dtsi | 11 +++ > 1 file changed, 11 insertions(+) > > diff --g

[PATCH 3/5] dt-bindings: media: rockchip-vpu: Add PX30 compatible

2021-01-07 Thread Paul Kocialkowski
The Rockchip PX30 SoC has a Hantro VPU that features a decoder (VDPU2) and an encoder (VEPU2). It is similar to the RK3399's VPU but takes an extra clock (SCLK). Signed-off-by: Paul Kocialkowski --- .../bindings/media/rockchip-vpu.yaml | 25 +-- 1 file changed, 17

[PATCH 4/5] arm64: dts: rockchip: Add VPU support for the PX30

2021-01-07 Thread Paul Kocialkowski
The PX30 has a VPU (both decoder and encoder) with a dedicated IOMMU. Describe these two entities in device-tree. Signed-off-by: Paul Kocialkowski --- arch/arm64/boot/dts/rockchip/px30.dtsi | 23 +++ 1 file changed, 23 insertions(+) diff --git a/arch/arm64/boot/dts/rockchip

[PATCH 5/5] media: hantro: Add support for the Rockchip PX30

2021-01-07 Thread Paul Kocialkowski
The PX30 SoC includes both the VDPU2 and VEPU2 blocks which are similar to the RK3399 (Hantro G1/H1 with shuffled registers). Besides taking an extra clock, it also shares an interrupt with the IOMMU so it's necessary to request the interrupt shared. Signed-off-by: Paul Kocialkowski

[PATCH 0/5] Rockchip PX30 RGA and VPU support

2021-01-07 Thread Paul Kocialkowski
This series adds the required bits for RGA and VPU support on the Rockchip PX30 SoC. Cheers, Paul Paul Kocialkowski (5): dt-bindings: media: rockchip-rga: Add PX30 compatible arm64: dts: rockchip: Add RGA support to the PX30 dt-bindings: media: rockchip-vpu: Add PX30 compatible arm64

[PATCH 2/5] arm64: dts: rockchip: Add RGA support to the PX30

2021-01-07 Thread Paul Kocialkowski
The PX30 features a RGA block: add the necessary node to support it. Signed-off-by: Paul Kocialkowski --- arch/arm64/boot/dts/rockchip/px30.dtsi | 11 +++ 1 file changed, 11 insertions(+) diff --git a/arch/arm64/boot/dts/rockchip/px30.dtsi b/arch/arm64/boot/dts/rockchip/px30.dtsi

[PATCH 1/5] dt-bindings: media: rockchip-rga: Add PX30 compatible

2021-01-07 Thread Paul Kocialkowski
Add a new compatible for the PX30 Rockchip SoC, which also features a RGA block. It is compatible with the RK3288 RGA block. Signed-off-by: Paul Kocialkowski --- Documentation/devicetree/bindings/media/rockchip-rga.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

Re: [PATCH v8 4/4] NOTFORMERGE: drm/logicvc: Add plane colorkey support

2021-01-05 Thread Paul Kocialkowski
orkey: > > https://drmdb.emersion.fr/properties/4008636142/colorkey > > > > I know this is marked "not for merge", but it would be nice to discuss > > with them and come up with a standardized property. -- Paul Kocialkowski, Bootlin Embedded Linux and kernel engineering https://bootlin.com signature.asc Description: PGP signature

Re: [PATCH v4 2/3] media: i2c: Add support for the OV8865 image sensor

2021-01-05 Thread Paul Kocialkowski
Hi Sakari, On Tue 05 Jan 21, 16:41, Sakari Ailus wrote: > Hi Paul, > > On Tue, Jan 05, 2021 at 10:38:47AM +0100, Paul Kocialkowski wrote: > > Hi Sakari, > > > > On Mon 04 Jan 21, 14:07, Sakari Ailus wrote: > > > Hi Paul, > > > > > > On Th

[PATCH v2] media: i2c: ov5648/ov8865: Minor cosmetic fixes

2021-01-05 Thread Paul Kocialkowski
This solves a few minor cosmetic issues picked up by checkpatch for the OV5648 and OV8865 drivers. Signed-off-by: Paul Kocialkowski --- drivers/media/i2c/ov5648.c | 3 ++- drivers/media/i2c/ov8865.c | 8 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/media/i2c

Re: [PATCH v4 2/3] media: i2c: Add support for the OV8865 image sensor

2021-01-05 Thread Paul Kocialkowski
Hi Sakari, On Mon 04 Jan 21, 14:07, Sakari Ailus wrote: > Hi Paul, > > On Thu, Dec 31, 2020 at 03:27:01PM +0100, Paul Kocialkowski wrote: > > The OV8865 is a 8 Mpx CMOS image sensor producing 3264x2448 at 30 fps. > > Other modes (including some with sub-sampli

[PATCH] media: i2c: ov5648/ov8865: Minor cosmetic fixes

2021-01-05 Thread Paul Kocialkowski
This solves a few minor cosmetic issues picked up by checkpatch for the OV5648 and OV8865 drivers. Signed-off-by: Paul Kocialkowski --- drivers/media/i2c/ov5648.c | 2 +- drivers/media/i2c/ov8865.c | 7 +++ 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/media/i2c

[PATCH v4 10/15] ARM: dts: sun8i: v3s: Add nodes for MIPI CSI-2 support

2020-12-31 Thread Paul Kocialkowski
is connected but this is fine since no other interface is available. Signed-off-by: Paul Kocialkowski --- arch/arm/boot/dts/sun8i-v3s.dtsi | 67 1 file changed, 67 insertions(+) diff --git a/arch/arm/boot/dts/sun8i-v3s.dtsi b/arch/arm/boot/dts/sun8i-v3s.dtsi

[PATCH v4 12/15] dt-bindings: media: Add A83T MIPI CSI-2 bindings documentation

2020-12-31 Thread Paul Kocialkowski
This introduces YAML bindings documentation for the A83T MIPI CSI-2 controller. Signed-off-by: Paul Kocialkowski Reviewed-by: Rob Herring --- .../media/allwinner,sun8i-a83t-mipi-csi2.yaml | 147 ++ 1 file changed, 147 insertions(+) create mode 100644 Documentation/devicetree

[PATCH v4 05/15] media: sun6i-csi: Only configure the interface data width for parallel

2020-12-31 Thread Paul Kocialkowski
block is moved around before the interlaced conditional block for nicer code symmetry (conditional blocks first) while at it. Co-developed-by: Kévin L'hôpital Signed-off-by: Kévin L'hôpital Signed-off-by: Paul Kocialkowski --- .../platform/sunxi/sun6i-csi/sun6i_csi.c | 42

[PATCH v4 06/15] dt-bindings: media: sun6i-a31-csi: Add MIPI CSI-2 input port

2020-12-31 Thread Paul Kocialkowski
. Signed-off-by: Paul Kocialkowski Reviewed-by: Rob Herring --- .../media/allwinner,sun6i-a31-csi.yaml| 88 --- 1 file changed, 75 insertions(+), 13 deletions(-) diff --git a/Documentation/devicetree/bindings/media/allwinner,sun6i-a31-csi.yaml b/Documentation

[PATCH v4 07/15] media: sun6i-csi: Add support for MIPI CSI-2 bridge input

2020-12-31 Thread Paul Kocialkowski
the controller's output to the ISP instead of its DMA engine. Finally note that the MIPI CSI-2 bridges should not be linked in the fwnode graph unless they have a sensor subdev attached. Signed-off-by: Paul Kocialkowski --- .../platform/sunxi/sun6i-csi/sun6i_csi.c | 123

[PATCH v4 08/15] dt-bindings: media: Add A31 MIPI CSI-2 bindings documentation

2020-12-31 Thread Paul Kocialkowski
This introduces YAML bindings documentation for the A31 MIPI CSI-2 controller. Signed-off-by: Paul Kocialkowski --- .../media/allwinner,sun6i-a31-mipi-csi2.yaml | 149 ++ 1 file changed, 149 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/allwinner

[PATCH v4 09/15] media: sunxi: Add support for the A31 MIPI CSI-2 controller

2020-12-31 Thread Paul Kocialkowski
supported by this implementation. Signed-off-by: Paul Kocialkowski --- drivers/media/platform/sunxi/Kconfig | 1 + drivers/media/platform/sunxi/Makefile | 1 + .../platform/sunxi/sun6i-mipi-csi2/Kconfig| 12 + .../platform/sunxi/sun6i-mipi-csi2/Makefile | 4 + .../sunxi

[PATCH v4 03/15] phy: allwinner: phy-sun6i-mipi-dphy: Support D-PHY Rx mode for MIPI CSI-2

2020-12-31 Thread Paul Kocialkowski
. Signed-off-by: Paul Kocialkowski Acked-by: Maxime Ripard --- drivers/phy/allwinner/phy-sun6i-mipi-dphy.c | 164 +++- 1 file changed, 160 insertions(+), 4 deletions(-) diff --git a/drivers/phy/allwinner/phy-sun6i-mipi-dphy.c b/drivers/phy/allwinner/phy-sun6i-mipi-dphy.c index

[PATCH v4 15/15] MAINTAINERS: Add entry for the Allwinner A83T MIPI CSI-2 bridge

2020-12-31 Thread Paul Kocialkowski
Add myself as maintainer of the A83T MIPI CSI-2 bridge media driver. Signed-off-by: Paul Kocialkowski --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index a1352171778b..3b48612657b6 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -717,6

[PATCH v4 14/15] ARM: dts: sun8i: a83t: Add MIPI CSI-2 controller node

2020-12-31 Thread Paul Kocialkowski
on the CSI driver. Signed-off-by: Paul Kocialkowski --- arch/arm/boot/dts/sun8i-a83t.dtsi | 26 ++ 1 file changed, 26 insertions(+) diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi index c010b27fdb6a..d6d55c12b995 100644 --- a/arch/arm

[PATCH v4 04/15] media: sun6i-csi: Use common V4L2 format info for storage bpp

2020-12-31 Thread Paul Kocialkowski
switch/case was also wrong concerning 10/12-bit Bayer formats, which are aligned to 16 bits in memory. Using the common helper fixes it. Fixes: 5cc7522d8965 ("media: sun6i: Add support for Allwinner CSI V3s") Signed-off-by: Paul Kocialkowski Acked-by: Maxime Ripard --- .../platform/sunxi

[PATCH v4 13/15] media: sunxi: Add support for the A83T MIPI CSI-2 controller

2020-12-31 Thread Paul Kocialkowski
-csi driver. It was tested on a Banana Pi M3 board with an OV8865 sensor in a 4-lane configuration. Signed-off-by: Paul Kocialkowski --- drivers/media/platform/sunxi/Kconfig | 1 + drivers/media/platform/sunxi/Makefile | 1 + .../sunxi/sun8i-a83t-mipi-csi2/Kconfig| 11

[PATCH v4 01/15] docs: phy: Add a part about PHY mode and submode

2020-12-31 Thread Paul Kocialkowski
Besides giving pointers to the relevant functions for PHY mode and submode configuration, this clarifies the need to set them before powering on the PHY. Signed-off-by: Paul Kocialkowski Reviewed-by: Maxime Ripard --- Documentation/driver-api/phy/phy.rst | 18 ++ 1 file changed

[PATCH v4 02/15] phy: Distinguish between Rx and Tx for MIPI D-PHY with submodes

2020-12-31 Thread Paul Kocialkowski
(zero value) is kept to Tx so only the rkisp1 driver, which uses D-PHY in Rx mode, needs to be adapted. Signed-off-by: Paul Kocialkowski Acked-by: Helen Koike --- drivers/staging/media/rkisp1/rkisp1-isp.c | 3 ++- include/linux/phy/phy-mipi-dphy.h | 13 + 2 files changed

[PATCH v4 11/15] MAINTAINERS: Add entry for the Allwinner A31 MIPI CSI-2 bridge

2020-12-31 Thread Paul Kocialkowski
Add myself as maintainer of the A31 MIPI CSI-2 bridge media driver. Signed-off-by: Paul Kocialkowski --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 0644128640fb..a1352171778b 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -709,6

[PATCH v4 00/15] Allwinner MIPI CSI-2 support for A31/V3s/A83T

2020-12-31 Thread Paul Kocialkowski
er ioctls (Input 0): test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK test VIDIOC_EXPBUF: OK test Requests: OK (Not Supported) Total for sun6i-video device /dev/video0: 45, Succeeded: 45, Failed: 0, Warnings: 6 Paul Kocialkowski (15): docs: phy: Add a part about PHY mode and su

[PATCH NOT FOR MERGE v4 3/3] ARM: dts: sun8i: a83t: bananapi-m3: Enable MIPI CSI-2 with OV8865

2020-12-31 Thread Paul Kocialkowski
shutdown line. Signed-off-by: Kévin L'hôpital Signed-off-by: Paul Kocialkowski --- arch/arm/boot/dts/sun8i-a83t-bananapi-m3.dts | 102 +++ 1 file changed, 102 insertions(+) diff --git a/arch/arm/boot/dts/sun8i-a83t-bananapi-m3.dts b/arch/arm/boot/dts/sun8i-a83t-bananapi-m3.dts

[PATCH v4 2/3] media: i2c: Add support for the OV8865 image sensor

2020-12-31 Thread Paul Kocialkowski
b/drivers/media/i2c/ov8865.c @@ -0,0 +1,2972 @@ +// SPDX-License-Identifier: GPL-2.0-or-later +/* + * Copyright 2020 Kévin L'hôpital + * Copyright 2020 Bootlin + * Author: Paul Kocialkowski + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include

[PATCH v4 1/3] dt-bindings: media: i2c: Add OV8865 bindings documentation

2020-12-31 Thread Paul Kocialkowski
This introduces YAML bindings documentation for the OV8865 image sensor. Co-developed-by: Kévin L'hôpital Signed-off-by: Kévin L'hôpital Signed-off-by: Paul Kocialkowski Reviewed-by: Rob Herring --- .../bindings/media/i2c/ovti,ov8865.yaml | 124 ++ 1 file changed, 124

[PATCH v4 0/3] media: i2c: OV8865 image sensor support

2020-12-31 Thread Paul Kocialkowski
: Enable MIPI CSI-2 with OV8865 Paul Kocialkowski (2): dt-bindings: media: i2c: Add OV8865 bindings documentation media: i2c: Add support for the OV8865 image sensor .../bindings/media/i2c/ovti,ov8865.yaml | 124 + arch/arm/boot/dts/sun8i-a83t-bananapi-m3.dts | 102 + drivers/media

[PATCH v7 2/2] media: i2c: Add support for the OV5648 image sensor

2020-12-31 Thread Paul Kocialkowski
are still missing: - Debanding, based on power source frequency; - Exposition setting correlated to time units. Signed-off-by: Paul Kocialkowski --- drivers/media/i2c/Kconfig | 13 + drivers/media/i2c/Makefile |1 + drivers/media/i2c/ov5648.c | 2623 3

[PATCH v7 1/2] dt-bindings: media: i2c: Add OV5648 bindings documentation

2020-12-31 Thread Paul Kocialkowski
This introduces YAML bindings documentation for the OV5648 image sensor. Signed-off-by: Paul Kocialkowski Reviewed-by: Rob Herring --- .../bindings/media/i2c/ovti,ov5648.yaml | 115 ++ 1 file changed, 115 insertions(+) create mode 100644 Documentation/devicetree/bindings

[PATCH v7 0/2] media: i2c: OV5648 image sensor support

2020-12-31 Thread Paul Kocialkowski
assigned-clock-rate; - Removed clock name; - Returned closest size in set_fmt; - Removed unneeded references to v4l2 controls; - Removed i2c device table; - Dual-licensed bindings; - Used SPDX tags. Paul Kocialkowski (2): dt-bindings: media: i2c: Add OV5648 bindings documentation media: i2c: Add

[PATCH v6 0/2] media: i2c: OV5648 image sensor support

2020-12-31 Thread Paul Kocialkowski
; - Removed unneeded references to v4l2 controls; - Removed i2c device table; - Dual-licensed bindings; - Used SPDX tags. Paul Kocialkowski (2): dt-bindings: media: i2c: Add OV5648 bindings documentation media: i2c: Add support for the OV5648 image sensor .../bindings/media/i2c/ovti,ov5648.yaml

[PATCH v6 2/2] media: i2c: Add support for the OV5648 image sensor

2020-12-31 Thread Paul Kocialkowski
are still missing: - Debanding, based on power source frequency; - Exposition setting correlated to time units. Signed-off-by: Paul Kocialkowski --- drivers/media/i2c/Kconfig | 13 + drivers/media/i2c/Makefile |1 + drivers/media/i2c/ov5648.c | 2624 3

[PATCH v6 1/2] dt-bindings: media: i2c: Add OV5648 bindings documentation

2020-12-31 Thread Paul Kocialkowski
This introduces YAML bindings documentation for the OV5648 image sensor. Signed-off-by: Paul Kocialkowski Reviewed-by: Rob Herring --- .../bindings/media/i2c/ovti,ov5648.yaml | 115 ++ 1 file changed, 115 insertions(+) create mode 100644 Documentation/devicetree/bindings

Re: [PATCH v3 09/15] media: sunxi: Add support for the A31 MIPI CSI-2 controller

2020-12-31 Thread Paul Kocialkowski
Hi, On Mon 14 Dec 20, 12:39, Maxime Ripard wrote: > On Fri, Dec 11, 2020 at 04:57:02PM +0100, Paul Kocialkowski wrote: > > +#define sun6i_mipi_csi2_subdev_video(subdev) \ > > + container_of(subdev, struct sun6i_mipi_csi2_video, subdev) > > + > > +#define sun6

Re: [PATCH v5 2/2] media: i2c: Add support for the OV5648 image sensor

2020-12-31 Thread Paul Kocialkowski
n the next version for both drivers! Cheers, Paul > On Fri, Dec 11, 2020 at 04:40:27PM +0100, Paul Kocialkowski wrote: > > The OV5648 is a 5 Mpx CMOS image sensor, connected via MIPI CSI-2 > > in a one or two lane configuration. > > > > Most of the features of the hardware ar

Re: [PATCH v2 1/2] usb: ohci: Default to per-port over-current protection

2020-12-27 Thread Paul Kocialkowski
some > - * Mac platforms. ganged overcurrent reporting, if any. > + * Mac platforms. >*/ > val |= RH_A_NPS; > - ohci_writel (ohci, val, >regs->roothub.a); > } > + ohci_writel(ohci, val, >regs->r

Re: [PATCH v8 1/4] dt-bindings: display: Document the Xylon LogiCVC display controller

2020-12-25 Thread Paul Kocialkowski
Hi, On Thu 24 Dec 20, 10:01, Rob Herring wrote: > On Wed, 23 Dec 2020 22:29:44 +0100, Paul Kocialkowski wrote: > > The Xylon LogiCVC is a display controller implemented as programmable > > logic in Xilinx FPGAs. > > > > Signed-off-by: Paul Kocialkowski

Re: [PATCH v2 1/2] dt-bindings: pwm: allwinner: Add V3s compatible description

2020-12-24 Thread Paul Kocialkowski
Hi, Le Tue 22 Dec 20, 09:21, Jernej Škrabec a écrit : > Dne petek, 18. december 2020 ob 21:54:35 CET je Paul Kocialkowski napisal(a): > > Introduce bindings description for the V3s PWM, which is > > register-compatible with the A20 PWM. > > > > Signe

Re: [PATCH] ARM: dts: sun8i-v3s: Add CSI0 MCLK pin definition

2020-12-24 Thread Paul Kocialkowski
Hi, Le Tue 22 Dec 20, 09:17, Jernej Škrabec a écrit : > Dne petek, 18. december 2020 ob 20:50:33 CET je Paul Kocialkowski napisal(a): > > This adds a device-tree definition for the CSI0 MCLK pin, > > which can be used for feeding MIPI CSI-2 sensors. > > > > Signe

[PATCH v8 0/4] drm: LogiCVC display controller support

2020-12-23 Thread Paul Kocialkowski
t bindings documentation to dt schema; - Described more possible dt parameters; - Added support for the lvds-3bit interface; - Added support for grabbing syscon regmap from parent node; - Removed layers count property and count layers child nodes instead. Paul Kocialkowski (4): dt-bindings: display

[PATCH v8 3/4] drm: Add support for the LogiCVC display controller

2020-12-23 Thread Paul Kocialkowski
the implementation of logicvc_layer_buffer_find_setup for specifics. Version 4 allows configuring each buffer address directly, which guarantees that any buffer can be configured. Signed-off-by: Paul Kocialkowski Reviewed-by: Maxime Ripard --- MAINTAINERS | 6 + drivers

[PATCH v8 2/4] dt-bindings: mfd: logicvc: Add patternProperties for the display

2020-12-23 Thread Paul Kocialkowski
The LogiCVC multi-function device has a display part which is now described in its binding. Add a patternProperties match for it. Signed-off-by: Paul Kocialkowski --- Documentation/devicetree/bindings/mfd/xylon,logicvc.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation

[PATCH v8 4/4] NOTFORMERGE: drm/logicvc: Add plane colorkey support

2020-12-23 Thread Paul Kocialkowski
Signed-off-by: Paul Kocialkowski --- drivers/gpu/drm/logicvc/logicvc_drm.h | 3 + drivers/gpu/drm/logicvc/logicvc_layer.c | 150 +++- drivers/gpu/drm/logicvc/logicvc_layer.h | 7 ++ 3 files changed, 154 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/logicvc

[PATCH v8 1/4] dt-bindings: display: Document the Xylon LogiCVC display controller

2020-12-23 Thread Paul Kocialkowski
The Xylon LogiCVC is a display controller implemented as programmable logic in Xilinx FPGAs. Signed-off-by: Paul Kocialkowski Acked-by: Rob Herring --- .../display/xylon,logicvc-display.yaml| 313 ++ 1 file changed, 313 insertions(+) create mode 100644 Documentation

[PATCH v2 1/2] dt-bindings: pwm: allwinner: Add V3s compatible description

2020-12-18 Thread Paul Kocialkowski
Introduce bindings description for the V3s PWM, which is register-compatible with the A20 PWM. Signed-off-by: Paul Kocialkowski --- .../devicetree/bindings/pwm/allwinner,sun4i-a10-pwm.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/devicetree/bindings/pwm

[PATCH v2 2/2] ARM: dts: sun8i-v3s: Add PWM controller and pins definitions

2020-12-18 Thread Paul Kocialkowski
This introduces definitions for the PWM controller found in the V3s, as well as associated pins. This fashion of the controller has two PWM outputs and is register-compatible with the A20. Both PWM outputs were tested on a Lichee Pi Zero with a simple transistor-LED setup. Signed-off-by: Paul

[PATCH] ARM: dts: sun8i-v3s: Add CSI0 MCLK pin definition

2020-12-18 Thread Paul Kocialkowski
This adds a device-tree definition for the CSI0 MCLK pin, which can be used for feeding MIPI CSI-2 sensors. Signed-off-by: Paul Kocialkowski --- arch/arm/boot/dts/sun8i-v3s.dtsi | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm/boot/dts/sun8i-v3s.dtsi b/arch/arm/boot/dts/sun8i

[PATCH] ARM: dts: sun8i-v3s: Add PWM controller and pins definitions

2020-12-17 Thread Paul Kocialkowski
This introduces definitions for the PWM controller found in the V3s, as well as associated pins. This fashion of the controller has two PWM outputs and is register-compatible with the A20. Both PWM outputs were tested on a Lichee Pi Zero with a simple transistor-LED setup. Signed-off-by: Paul

[PATCH v3 10/15] ARM: dts: sun8i: v3s: Add nodes for MIPI CSI-2 support

2020-12-11 Thread Paul Kocialkowski
is connected but this is fine since no other interface is available. Signed-off-by: Paul Kocialkowski --- arch/arm/boot/dts/sun8i-v3s.dtsi | 67 1 file changed, 67 insertions(+) diff --git a/arch/arm/boot/dts/sun8i-v3s.dtsi b/arch/arm/boot/dts/sun8i-v3s.dtsi

[PATCH v3 12/15] dt-bindings: media: Add A83T MIPI CSI-2 bindings documentation

2020-12-11 Thread Paul Kocialkowski
This introduces YAML bindings documentation for the A83T MIPI CSI-2 controller. Signed-off-by: Paul Kocialkowski Reviewed-by: Rob Herring --- .../media/allwinner,sun8i-a83t-mipi-csi2.yaml | 147 ++ 1 file changed, 147 insertions(+) create mode 100644 Documentation/devicetree

[PATCH v3 11/15] MAINTAINERS: Add entry for the Allwinner A31 MIPI CSI-2 bridge

2020-12-11 Thread Paul Kocialkowski
Add myself as maintainer of the A31 MIPI CSI-2 bridge media driver. Signed-off-by: Paul Kocialkowski --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 0644128640fb..a1352171778b 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -709,6

[PATCH v3 14/15] ARM: dts: sun8i: a83t: Add MIPI CSI-2 controller node

2020-12-11 Thread Paul Kocialkowski
on the CSI driver. Signed-off-by: Paul Kocialkowski --- arch/arm/boot/dts/sun8i-a83t.dtsi | 26 ++ 1 file changed, 26 insertions(+) diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi index c010b27fdb6a..d6d55c12b995 100644 --- a/arch/arm

[PATCH v3 13/15] media: sunxi: Add support for the A83T MIPI CSI-2 controller

2020-12-11 Thread Paul Kocialkowski
-csi driver. It was tested on a Banana Pi M3 board with an OV8865 sensor in a 4-lane configuration. Signed-off-by: Paul Kocialkowski --- arch/arm/boot/dts/sun8i-a83t-bananapi-m3.dts | 2 +- drivers/media/platform/sunxi/Kconfig | 1 + drivers/media/platform/sunxi/Makefile | 1

[PATCH v3 15/15] MAINTAINERS: Add entry for the Allwinner A83T MIPI CSI-2 bridge

2020-12-11 Thread Paul Kocialkowski
Add myself as maintainer of the A83T MIPI CSI-2 bridge media driver. Signed-off-by: Paul Kocialkowski --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index a1352171778b..3b48612657b6 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -717,6

[PATCH v3 09/15] media: sunxi: Add support for the A31 MIPI CSI-2 controller

2020-12-11 Thread Paul Kocialkowski
supported by this implementation. Signed-off-by: Paul Kocialkowski --- drivers/media/platform/sunxi/Kconfig | 1 + drivers/media/platform/sunxi/Makefile | 1 + .../platform/sunxi/sun6i-mipi-csi2/Kconfig| 12 + .../platform/sunxi/sun6i-mipi-csi2/Makefile | 4 + .../sunxi

[PATCH v3 06/15] dt-bindings: media: sun6i-a31-csi: Add MIPI CSI-2 input port

2020-12-11 Thread Paul Kocialkowski
. Signed-off-by: Paul Kocialkowski --- .../media/allwinner,sun6i-a31-csi.yaml| 88 --- 1 file changed, 75 insertions(+), 13 deletions(-) diff --git a/Documentation/devicetree/bindings/media/allwinner,sun6i-a31-csi.yaml b/Documentation/devicetree/bindings/media/allwinner

  1   2   3   4   5   6   7   8   9   10   >