Re: [PATCH] pda_power: remove ac_draw_failed goto and label

Hello Anton, On 22/09/12 00:51, Anton Vorontsov wrote: On Fri, Sep 21, 2012 at 01:56:43AM +0100, Paul Parsons wrote: A previous patch added the ac_draw_failed goto and label to pda_power_probe(). The goto would be invoked after a failed call to regulator_get(). However the way ac_draw is used

[PATCH] pda_power: remove ac_draw_failed goto and label

ac_draw_failed goto and label, partly reverting the previous patch. This patch also removes the assignment of an error code to ret after a failed call to regulator_get(), since the error code is now never used. Signed-off-by: Paul Parsons Cc: Philipp Zabel --- drivers/power/pda_power.c |3

Re: [PATCH] pda_power: ac_draw used before set

Hello Anton, On 20/09/12 22:32, Anton Vorontsov wrote: On Wed, Sep 19, 2012 at 06:36:19PM +0100, Paul Parsons wrote: When I reboot my iPAQ hx4700 in its cradle, the battery will not begin to charge even though the AC supply is connected. Charging will start only after the PDA power driver is

[PATCH] pda_power: ac_draw used before set

lies in pda_power_probe(), where ac_draw is used by the call to update_charger() before being set by the call to regulator_get(). Moving the regulator_get() call to before the update_charger() call fixes the problem. Signed-off-by: Paul Parsons Cc: Philipp Zabel --- drivers/power/pda_power.c