[net-next PATCH v12 4/4] net: dsa: mv88e6xxx: Add support for mv88e6393x family of Marvell

Thanks Marek for catching this. I will have a closer look and update the patchset.

[net-next PATCH v12 3/4] net: dsa: mv88e6xxx: Change serdes lane parameter type from u8 type to int

Returning 0 is no more an error case with MV88E6393 family which has serdes lane numbers 0, 9 or 10. So with this change .serdes_get_lane will return lane number or -errno (-ENODEV or -EOPNOTSUPP). Signed-off-by: Pavana Sharma Reviewed-by: Andrew Lunn --- drivers/net/dsa/mv88e6xxx/chip.c

[net-next PATCH v12 2/4] net: phy: Add 5GBASER interface mode

Add 5GBASE-R phy interface mode Signed-off-by: Pavana Sharma --- include/linux/phy.h | 4 1 file changed, 4 insertions(+) diff --git a/include/linux/phy.h b/include/linux/phy.h index 381a95732b6a..868ee5cf7fce 100644 --- a/include/linux/phy.h +++ b/include/linux/phy.h @@ -106,6 +106,7

[net-next PATCH v12 4/4] net: dsa: mv88e6xxx: Add support for mv88e6393x family of Marvell

Boldaji Signed-off-by: Ashkan Boldaji Signed-off-by: Pavana Sharma --- Changes in v2: - Fix a warning (Reported-by: kernel test robot ) Changes in v3: - Fix 'unused function' warning Changes in v4-v9: - Incorporated feedback from maintainers. Changes in v10: - Fix ISO C90 forbids mixing

[net-next PATCH v12 1/4] dt-bindings: net: Add 5GBASER phy interface mode

Add 5gbase-r PHY interface mode. Signed-off-by: Pavana Sharma --- Documentation/devicetree/bindings/net/ethernet-controller.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/net/ethernet-controller.yaml b/Documentation/devicetree/bindings/net/ethernet

[net-next PATCH v12 0/4] Add support for mv88e6393x family of Marvell

Updated patchset after rebasing and incorporating feedback. Pavana Sharma (4): dt-bindings: net: Add 5GBASER phy interface mode net: phy: Add 5GBASER interface mode net: dsa: mv88e6xxx: Change serdes lane parameter type from u8 type to int net: dsa: mv88e6xxx: Add support

[PATCH v11 1/4] dt-bindings: net: Add 5GBASER phy interface mode

Hi Andrew, > For v10 i said: > > What value does the comment add? > I don't remember you replying. Why is 5gbase-r special and it needs a > comment, saying the same thing in CAPS LETTERS? What value is there in > the CAPS LETTERS string? There isn't anything special regarding 5gbase-r apart

[PATCH v11 4/4] net: dsa: mv88e6xxx: Add support for mv88e6393x family of Marvell

Boldaji Signed-off-by: Ashkan Boldaji Signed-off-by: Pavana Sharma --- Changes in v2: - Fix a warning (Reported-by: kernel test robot ) Changes in v3: - Fix 'unused function' warning Changes in v4-v9: - Incorporated feedback from maintainers. Changes in v10: - Fix ISO C90 forbids mixing

[PATCH v11 3/4] net: dsa: mv88e6xxx: Change serdes lane parameter type from u8 type to int

Returning 0 is no more an error case with MV88E6393 family which has serdes lane numbers 0, 9 or 10. So with this change .serdes_get_lane will return lane number or -errno (-ENODEV or -EOPNOTSUPP). Signed-off-by: Pavana Sharma --- drivers/net/dsa/mv88e6xxx/chip.c | 28 ++-- drivers

[PATCH v11 2/4] net: phy: Add 5GBASER interface mode

Add 5GBASE-R phy interface mode Signed-off-by: Pavana Sharma --- include/linux/phy.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/linux/phy.h b/include/linux/phy.h index 56563e5e0dc7..8151e6ecf1b9 100644 --- a/include/linux/phy.h +++ b/include/linux/phy.h @@ -106,6 +106,7

[PATCH v11 1/4] dt-bindings: net: Add 5GBASER phy interface mode

Add 5gbase-r PHY interface mode. Signed-off-by: Pavana Sharma --- Documentation/devicetree/bindings/net/ethernet-controller.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/net/ethernet-controller.yaml b/Documentation/devicetree/bindings/net/ethernet

[PATCH v11 0/4] Add support for mv88e6393x family of Marvell

Updated patchset after incorporating feedback. Pavana Sharma (4): dt-bindings: net: Add 5GBASER phy interface mode net: phy: Add 5GBASER interface mode net: dsa: mv88e6xxx: Change serdes lane parameter type from u8 type to int net: dsa: mv88e6xxx: Add support for mv88e6393x family

[PATCH v10 4/4] net: dsa: mv88e6xxx: Add support for mv88e6393x family of Marvell

Boldaji Signed-off-by: Ashkan Boldaji Signed-off-by: Pavana Sharma --- Changes in v2: - Fix a warning (Reported-by: kernel test robot ) Changes in v3: - Fix 'unused function' warning Changes in v4-v9: - Incorporated feedback from maintainers. Changes in v10: - Fix ISO C90 forbids mixing

[PATCH v10 3/4] net: dsa: mv88e6xxx: Change serdes lane parameter from u8 type to int

Returning 0 is no more an error case with MV88E6393 family which has serdes lane numbers 0, 9 or 10. So with this change .serdes_get_lane will return lane number or -errno (-ENODEV or -EOPNOTSUPP). Signed-off-by: Pavana Sharma --- drivers/net/dsa/mv88e6xxx/chip.c | 28 ++-- drivers

[PATCH v10 2/4] net: phy: Add 5GBASER interface mode

Add 5GBASE-R phy interface mode Signed-off-by: Pavana Sharma --- include/linux/phy.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/linux/phy.h b/include/linux/phy.h index eb3cb1a98b45..71e280059ec5 100644 --- a/include/linux/phy.h +++ b/include/linux/phy.h @@ -106,6 +106,7

[PATCH v10 1/4] dt-bindings: net: Add 5GBASER phy interface mode

Add 5gbase-r PHY interface mode. Signed-off-by: Pavana Sharma --- Documentation/devicetree/bindings/net/ethernet-controller.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/net/ethernet-controller.yaml b/Documentation/devicetree/bindings/net/ethernet

[PATCH v10 0/4] Add support for mv88e6393x family of Marvell

Updated patchset after fixing a warning. Pavana Sharma (4): dt-bindings: net: Add 5GBASER phy interface mode net: phy: Add 5GBASER interface mode net: dsa: mv88e6xxx: Change serdes lane parameter from u8 type to int net: dsa: mv88e6xxx: Add support for mv88e6393x family of Marvell

[PATCH v9 4/4] net: dsa: mv88e6xxx: Add support for mv88e6393x family of Marvell

Boldaji Signed-off-by: Ashkan Boldaji Signed-off-by: Pavana Sharma --- Changes in v2: - Fix a warning (Reported-by: kernel test robot ) Changes in v3: - Fix 'unused function' warning Changes in v4-v9: - Incorporated feedback from maintainers. --- drivers/net/dsa/mv88e6xxx/chip.c| 136

[PATCH v9 3/4] net: dsa: mv88e6xxx: Change serdes lane parameter from u8 type to int

Returning 0 is no more an error case with MV88E6393 family which has serdes lane numbers 0, 9 or 10. So with this change .serdes_get_lane will return lane number or -errno (-ENODEV or -EOPNOTSUPP). Signed-off-by: Pavana Sharma --- drivers/net/dsa/mv88e6xxx/chip.c | 28 ++-- drivers

[PATCH v9 2/4] net: phy: Add 5GBASER interface mode

Add 5GBASE-R phy interface mode Signed-off-by: Pavana Sharma --- include/linux/phy.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/linux/phy.h b/include/linux/phy.h index eb3cb1a98b45..71e280059ec5 100644 --- a/include/linux/phy.h +++ b/include/linux/phy.h @@ -106,6 +106,7

[PATCH v9 1/4] dt-bindings: net: Add 5GBASER phy interface mode

Add 5gbase-r PHY interface mode. Signed-off-by: Pavana Sharma --- Documentation/devicetree/bindings/net/ethernet-controller.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/net/ethernet-controller.yaml b/Documentation/devicetree/bindings/net/ethernet

[PATCH v9 0/4] Add support for mv88e6393x family of Marvell

Thanks for the review. Here's updated patchset. All possible checkpatch 'checks' are attended. Pavana Sharma (4): dt-bindings: net: Add 5GBASER phy interface mode net: phy: Add 5GBASER interface mode net: dsa: mv88e6xxx: Change serdes lane parameter from u8 type to int net: dsa

[PATCH v8 4/4] net: dsa: mv88e6xxx: Add support for mv88e6393x family of Marvell

Boldaji Signed-off-by: Ashkan Boldaji Signed-off-by: Pavana Sharma --- Changes in v2: - Fix a warning (Reported-by: kernel test robot ) Changes in v3: - Fix 'unused function' warning Changes in v4-v8: - Incorporated feedback from maintainers. --- drivers/net/dsa/mv88e6xxx/chip.c| 136

[PATCH v8 3/4] net: dsa: mv88e6xxx: Change serdes lane parameter from u8 type to int

Returning 0 is no more an error case with MV88E6393 family which has serdes lane numbers 0, 9 or 10. So with this change .serdes_get_lane will return lane number or error (-ENODEV). Signed-off-by: Pavana Sharma --- drivers/net/dsa/mv88e6xxx/chip.c | 28 +-- drivers/net/dsa/mv88e6xxx

[PATCH v8 2/4] net: phy: Add 5GBASER interface mode

Add 5GBASE-R phy interface mode Signed-off-by: Pavana Sharma --- include/linux/phy.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/linux/phy.h b/include/linux/phy.h index eb3cb1a98b45..71e280059ec5 100644 --- a/include/linux/phy.h +++ b/include/linux/phy.h @@ -106,6 +106,7

[PATCH v8 0/4] Add support for mv88e6393x family of Marvell

Updated patchset with following changes. - Add kerneldoc for 5GBASER phy interface - Remove lane param initialization wherever is it not needed. Pavana Sharma (4): dt-bindings: net: Add 5GBASER phy interface mode net: phy: Add 5GBASER interface mode net: dsa: mv88e6xxx: Change serdes lane

[PATCH v8 1/4] dt-bindings: net: Add 5GBASER phy interface mode

Add 5gbase-r PHY interface mode. Signed-off-by: Pavana Sharma --- Documentation/devicetree/bindings/net/ethernet-controller.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/net/ethernet-controller.yaml b/Documentation/devicetree/bindings/net/ethernet

[PATCH v7 2/4] net: phy: Add 5GBASER interface mode

> How many times have i asked for you to add kerneldoc for this new > value? How many times have you not done so? I have added kerneldoc comment for the new value added. > NACK. > If you don't understand a comment, please ask. Ok, explain what do you expect by that comment.

[PATCH v7 3/4] net: dsa: mv88e6xxx: Change serdes lane parameter from u8 type to int

Returning 0 is no more an error case with MV88E6393 family which has serdes lane numbers 0, 9 or 10. So with this change .serdes_get_lane will return lane number or error (-ENODEV). Signed-off-by: Pavana Sharma --- drivers/net/dsa/mv88e6xxx/chip.c | 28 +-- drivers/net/dsa/mv88e6xxx

[PATCH v7 4/4] net: dsa: mv88e6xxx: Add support for mv88e6393x family of Marvell

Boldaji Signed-off-by: Ashkan Boldaji Signed-off-by: Pavana Sharma --- Changes in v2: - Fix a warning (Reported-by: kernel test robot ) Changes in v3: - Fix 'unused function' warning Changes in v4-v7: - Incorporated feedback from maintainers. --- drivers/net/dsa/mv88e6xxx/chip.c| 136

[PATCH v7 2/4] net: phy: Add 5GBASER interface mode

Add 5GBASE-R phy interface mode Signed-off-by: Pavana Sharma --- include/linux/phy.h | 4 1 file changed, 4 insertions(+) diff --git a/include/linux/phy.h b/include/linux/phy.h index 3a09d2bf69ea..977b94a44e15 100644 --- a/include/linux/phy.h +++ b/include/linux/phy.h @@ -105,6 +105,8

[PATCH v7 1/4] dt-bindings: net: Add 5GBASER phy interface mode

Add 5gbase-r PHY interface mode. Signed-off-by: Pavana Sharma --- Documentation/devicetree/bindings/net/ethernet-controller.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/net/ethernet-controller.yaml b/Documentation/devicetree/bindings/net/ethernet

[PATCH v7 0/4] Add support for mv88e6393x family of Marvell

Thanks for the review. Here's updated patchset. Pavana Sharma (4): dt-bindings: net: Add 5GBASER phy interface mode net: phy: Add 5GBASER interface mode net: dsa: mv88e6xxx: Change serdes lane parameter from u8 type to int net: dsa: mv88e6xxx: Add support for mv88e6393x family of Marvell

[PATCH v6 1/4] dt-bindings: net: Add 5GBASER phy interface mode

Add 5GBASE-R phy interface mode supported by mv88e6393 family. Signed-off-by: Pavana Sharma --- Documentation/devicetree/bindings/net/ethernet-controller.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/net/ethernet-controller.yaml b/Documentation

[PATCH v6 4/4] net: dsa: mv88e6xxx: Change serdes lane parameter from u8 to int

Returning 0 is no more an error case with MV88E6393 family which has serdes lane numbers 0, 9 or 10. So with this change .serdes_get_lane will return lane number or error (-ENODEV). Signed-off-by: Pavana Sharma --- drivers/net/dsa/mv88e6xxx/chip.c | 28 +- drivers/net/dsa/mv88e6xxx

[PATCH v6 0/4] Add support for mv88e6393x family of Marvell

X. I am adding _ops for 6193X, mv88e6193x_ops which can be used for the other two products unless any specific functionality differs. Pavana Sharma (4): dt-bindings: net: Add 5GBASER phy interface mode net: phy: Add 5GBASER interface mode net: dsa: mv88e6xxx: Add support for mv88e6393

[PATCH v6 2/4] net: phy: Add 5GBASER interface mode

Add new mode supported by MV88E6393 family. Signed-off-by: Pavana Sharma --- include/linux/phy.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/linux/phy.h b/include/linux/phy.h index 3a09d2bf69ea..9de7c57cfd38 100644 --- a/include/linux/phy.h +++ b/include/linux/phy.h @@ -107,6

[PATCH v6 3/4] net: dsa: mv88e6xxx: Add support for mv88e6393x family of Marvell

Boldaji Signed-off-by: Ashkan Boldaji Signed-off-by: Pavana Sharma --- Changes in v2: - Fix a warning (Reported-by: kernel test robot ) Changes in v3: - Fix 'unused function' warning Changes in v4, v5, v6: - Incorporated feedback from maintainers. --- drivers/net/dsa/mv88e6xxx/chip.c

[PATCH v5 1/3] net: phy: Add 5GBASER interface mode

Add new mode supported by MV88E6393 family. Signed-off-by: Pavana Sharma --- include/linux/phy.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/linux/phy.h b/include/linux/phy.h index 3a09d2bf69ea..9de7c57cfd38 100644 --- a/include/linux/phy.h +++ b/include/linux/phy.h @@ -107,6

[PATCH v5 3/3] net: dsa: mv88e6xxx: Add support for mv88e6393x family of Marvell

The Marvell 88E6393X device is a single-chip integration of a 11-port Ethernet switch with eight integrated Gigabit Ethernet (GbE) transceivers and three 10-Gigabit interfaces. This patch adds functionalities specific to mv88e6393x family (88E6393X, 88E6193X and 88E6191X) Signed-off-by: Pavana

[PATCH v5 2/3] dt-bindings: net: Add 5GBASER phy interface mode

Add 5GBASE-R phy interface mode supported by mv88e6393 family. Signed-off-by: Pavana Sharma --- Documentation/devicetree/bindings/net/ethernet-controller.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/net/ethernet-controller.yaml b/Documentation

[PATCH v5 0/3] Add support for mv88e6393x family of Marvell

Updated patchset. Pavana Sharma (3): net: phy: Add 5GBASER interface mode dt-bindings: net: Add 5GBASER phy interface mode net: dsa: mv88e6xxx: Add support for mv88e6393x family of Marvell .../bindings/net/ethernet-controller.yaml | 2 + drivers/net/dsa/mv88e6xxx/chip.c

[PATCH v4 3/3] Change serdes lane parameter from u8 type to int.

Returning 0 is no more an error case with MV88E6393 family which has serdes lane numbers 0, 9 or 10. So with this change .serdes_get_lane will return lane number or error (-ENODEV). Signed-off-by: Pavana Sharma --- drivers/net/dsa/mv88e6xxx/chip.c | 28 +-- drivers/net/dsa/mv88e6xxx

[PATCH v4 2/3] Add phy interface for 5GBASER mode

Signed-off-by: Pavana Sharma --- include/linux/phy.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/linux/phy.h b/include/linux/phy.h index 3a09d2bf69ea..9de7c57cfd38 100644 --- a/include/linux/phy.h +++ b/include/linux/phy.h @@ -107,6 +107,7 @@ typedef enum

[PATCH v4 1/3] Add support for mv88e6393x family of Marvell.

The Marvell 88E6393X device is a single-chip integration of a 11-port Ethernet switch with eight integrated Gigabit Ethernet (GbE) transceivers and three 10-Gigabit interfaces. This patch adds functionalities specific to mv88e6393x family (88E6393X, 88E6193X and 88E6191X) Signed-off-by: Pavana

[PATCH v4 0/3] Add support for mv88e6393x family of Marvell.

on MV88E6193X device. Pavana Pavana Sharma (3): Add support for mv88e6393x family of Marvell. Add phy interface for 5GBASER mode Change serdes lane parameter from u8 type to int. drivers/net/dsa/mv88e6xxx/chip.c| 119 +-- drivers/net/dsa/mv88e6xxx/chip.h| 20 +- drivers/net/dsa

[PATCH v3] Add support for mv88e6393x family of Marvell.

The Marvell 88E6393X device is a single-chip integration of a 11-port Ethernet switch with eight integrated Gigabit Ethernet (GbE) transceivers and three 10-Gigabit interfaces. This patch adds functionalities specific to mv88e6393x family (88E6393X, 88E6193X and 88E6191X) Signed-off-by: Pavana

[PATCH v2] Add support for mv88e6393x family of Marvell.

The Marvell 88E6393X device is a single-chip integration of a 11-port Ethernet switch with eight integrated Gigabit Ethernet (GbE) transceivers and three 10-Gigabit interfaces. This patch adds functionalities specific to mv88e6393x family (88E6393X, 88E6193X and 88E6191X) Signed-off-by: Pavana

[PATCH] Add support for mv88e6393x family of Marvell.

The Marvell 88E6393X device is a single-chip integration of a 11-port Ethernet switch with eight integrated Gigabit Ethernet (GbE) transceivers and three 10-Gigabit interfaces. This patch adds functionalities specific to mv88e6393x family (88E6393X, 88E6193X and 88E6191X) Signed-off-by: Pavana