gt;mutex);”?
> https://elixir.bootlin.com/linux/v6.10-rc3/source/include/linux/mutex.h#L196
This does not look like real improvement for code this trivial.
BR,
Pavel
--
People of Russia, stop Putin before his war on Ukraine escalates.
signature.asc
Description: PGP signature
nting to a commit inside that branch, probably why your git
> update didn't get the tag. You could try a
>
> git fetch --tags
Aha, thanks for the pointer and sorry for the noise.
Best regards,
Pavel
--
DENX Soft
g/pub/scm/linux/kernel/git/rt/linux-stable-rt.git
>
> branch: v5.10-rt
> Head SHA1: 3d208061796d4addeb543c78e0a4ec769b6ce6b2
Thank you.
Could you also push v5.10.214-rt106-rebase tag to the repository for
consistency?
Best regards,
;t see v5.10.214-rt106 (which would be useful to me).
Is it a mistake or should I plan for v5.10.215-rt107?
Thanks and best regards,
Pavel
--
People of Russia, stop Putin before his war on Ukraine escalates.
signature.asc
Description: PGP signature
but having basic support
> > in mainline is needed to be able to work on the other stuff
> > (networking, cameras, power management).
> >
> > Signed-off-by: Ondrej Jirman
> > Co-developed-by: Martijn Braam
> > Co-developed-by: Samuel Holland
> > Signed-of
Hi!
> > Add binding for anx7688 usb type-c bridge. I don't have a datasheet,
> > but I did best I could.
> >
> > Signed-off-by: Pavel Machek
>
> ...
>
> > + cabledet-gpios:
> > +maxItems: 1
> > +description: GPIO co
ainline is needed to be able to work on the other stuff
(networking, cameras, power management).
Signed-off-by: Ondrej Jirman
Co-developed-by: Martijn Braam
Co-developed-by: Samuel Holland
Signed-off-by: Pavel Machek
---
v2: Fix checkpatch stuff. Some cleanups, adapt to dts format in 1/2.
v3:
Add binding for anx7688 usb type-c bridge. I don't have a datasheet,
but I did best I could.
Signed-off-by: Pavel Machek
---
v2: implement review feedback
v3: fix single character pointed by robot
diff --git a/Documentation/devicetree/bindings/usb/analogix,anx7688.yaml
b/Document
= pdo_max_voltage(pdo);
> > + unsigned int max_pow = pdo_max_power(pdo);
> > +
> > + dev_info(anx7688->dev, "SRC_CAP PDO_BATT
> > (%umV-%umV %umW)\n", min_volt, max_volt, max_pow);
>
> Noise. That line also really should be split in two.
>
> I'm stopping my review here. This driver is too noisy. All dev_info
> calls need to be dropped. If the driver is working correctly then it
> needs to quiet.
>
> Most of those prints are useful for debugging only, so I think similar
> debugfs log like the one tcpm.c uses could be a good idea for them
> since you already use debugfs in this driver in any case.
Ok, let me convert the non-error ones to dev_dbg() and split the long
lines. Debug needs to be enabled, so it should not bother anyone, and
it is easier than refactoring driver to use debugfs.
Best regards,
Pavel
--
People of Russia, stop Putin before his war on Ukraine escalates.
signature.asc
Description: PGP signature
here, but having basic support
> in mainline is needed to be able to work on the other stuff
> (networking, cameras, power management).
>
> Signed-off-by: Ondrej Jirman
> Co-developed-by: Martijn Braam
> Co-developed-by: Samuel Holland
> Signed-off
Hi!
> Add binding for anx7688 usb type-c bridge. I don't have a datasheet,
> but I did best I could.
>
> Signed-off-by: Pavel Machek
Any more comments here? Automatic system told me I need to replace one
character
ainline is needed to be able to work on the other stuff
(networking, cameras, power management).
Signed-off-by: Ondrej Jirman
Co-developed-by: Martijn Braam
Co-developed-by: Samuel Holland
Signed-off-by: Pavel Machek
---
v2: Fix checkpatch stuff. Some cleanups, adapt to dts format in 1/2.
di
Add binding for anx7688 usb type-c bridge. I don't have a datasheet,
but I did best I could.
Signed-off-by: Pavel Machek
---
v2: implement review feedback
diff --git a/Documentation/devicetree/bindings/usb/analogix,anx7688.yaml
b/Documentation/devicetree/bindings/usb/analogix,anx7688
; I don't understand why do you have here properties. Do you see any
> binding like this?
Well, it looks like I copied these mistakes from analogix,anx7411.yaml .
> > +
> > +required:
> > + - compatible
>
> Drop, why is it needed?
Again, copy from analogix
Hi!
> > Add binding for anx7688 usb type-c bridge. I don't have a datasheet,
> > but I did best I could.
> >
> > Signed-off-by: Pavel Machek
> >
>
> You miss proper diffstat which makes reviewing difficult.
> Actually entire patch is corrupte
Add binding for anx7688 usb type-c bridge. I don't have a datasheet,
but I did best I could.
Signed-off-by: Pavel Machek
diff --git a/Documentation/devicetree/bindings/usb/analogix,anx7688.yaml
b/Documentation/devicetree/bindings/usb/analogix,anx7688.yaml
new file mode 100644
uot;);
> > + return ret;
> > + }
>
> ^^^ The driver will need to follow usb-c-connector bindings and it will need
> a bindings documentation for itself.
>
> That's one of the missing things that I did not implement, yet.
Yep, I fought with device trees
e us to go back and guess in the future, that isn't nice.
Thanks for the review. Fixing checkpatch issues is easy, but it looks
like closer look will be needed at the devicetree probing.
Also, what are the authors preferences about the license? I'd prefer
GPLv2+.
Best regards,
Pavel
ainline is needed to be able to work on the other stuff
(networking, cameras, power management).
Signed-off-by: Ondrej Jirman
Signed-off-by: Martijn Braam
Signed-off-by: Samuel Holland
Signed-off-by: Pavel Machek
diff --git a/drivers/usb/typec/Kconfig b/drivers/usb/typec/Kconfig
index 2f
cal
> popped up, but that was not the case.
>
> Sorry for the inconvenience, I do hope a release tomorrow or Friday does
> not disrupt your workflow too much.
No problem, thanks for the information, and looking forward to the
release.
Best regards,
Hi!
We (as in cip project), are trying to do -cip-rt releases
once a month. Are there any plans for 5.10-rt release any time soon?
That would help us ;-).
Best regards,
Pavel
--
DENX Software Engineering GmbH,Managing
. And it looks someone did the work and patches
are floating around. GOod :-).
I'm fighting with kexec crashing as soon as I pass dtb. Do I need to
modify the dtb somehow?
Best regards,
Pavel
with rather old 6.1
kernel on it, and lack of keyboard/ethernet makes things tricky.]
Best regards,
Pavel
--
People of Russia, stop Putin before his war on Ukraine escalates.
signature.asc
Description: PGP signature
camera driver (front camera on
PinePhone)". I've added some cc-s in case people wanted to comment on
it.
Best regards,
Pavel
--
People of Russia, stop Putin before his war on Ukraine escalates.
signature.asc
Description: PGP signature
ode.
Thanks for the release. Do you plan 5.10.200-based one by chance? .199
is buggy on hardware we care about, so it would make our job a bit
easier.
Thanks and best regards,
Pavel
--
DENX Software Engineering GmbH,Managing D
egards,
Pavel
--
it behaved funny with that, too.
> If you have, that should not be used as the pmic can feed vbus.
Well, my plan was to use it as a desktop, and external power is useful
that as Droid battery is not that big.
Best regards,
Pavel
--
People of Russia, stop Putin before his war on Ukraine escalates.
signature.asc
Description: PGP signature
st regards,
Pavel
--
> + idxd->reg_base + IDXD_SWERR_OFFSET);
Best regards,
Pavel
--
http://www.livejournal.com/~pavelmachek
signature.asc
Description: PGP signature
Dne 19. 04. 21 v 18:30 Minas Harutyunyan napsal(a):
> Hi Pavel,
>
> On 4/19/2021 5:22 PM, Pavel Hofman wrote:
>>
>> Dne 11. 02. 21 v 12:21 Minas Harutyunyan napsal(a):
>>> Hi Ruslan,
>>>
>>> On 2/1/2021 3:44 AM, Ruslan Bilovol wrote:
>>>
f65d0
The repro looks pretty much like sqpoll-exit-hang test and issues
that were just recently fixed.
#syz test: git://git.kernel.dk/linux-block for-5.13/io_uring
>
> The issue was bisected to:
>
> commit d9d05217cb6990b9a56e13b56e7a1b71e2551f6c
> Author: Pavel B
Hi!
> [ Upstream commit a79ace4b312953c5835fafb12adc3cb6878b26bd ]
>
> These patches fix a series of spelling errors in net/tipc module.
This should not be in -stable, it just cleans up comments.
Best regards,
Apr 2021 13:05:09 +.
> Anything received after that time might be too late.
CIP testing did not find any problems here:
https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/tree/linux-5.10.y
Tested-by: Pavel Machek
ior.
This patch is crazy. Take a look at Message-ID:
<20210419084953.GA28564@amd>. Or just look at the patch :-).
Best regards,
Pavel
> +++ b/net/rds/message.c
> @@ -180,6 +180,7 @@ void rds_message_put(struct rds_message *
ing with:
>
> #syz fix: io_uring: Convert personality_idr to XArray
>
> For information about bisection process see: https://goo.gl/tpsmEJ#bisection
#syz fix: io_uring: Convert personality_idr to XArray
--
Pavel Begunkov
_exit_work+0xa64/0x12d0 fs/io_uring.c:8620
> process_one_work+0x98d/0x1600 kernel/workqueue.c:2275
> worker_thread+0x64c/0x1120 kernel/workqueue.c:2421
> kthread+0x3b1/0x4a0 kernel/kthread.c:292
> ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:294
>
#syz test: git://git.kernel.dk/linux-block for-5.13/io_uring
--
Pavel Begunkov
ds_message_put (and it was,
otherwise we oopsed), it is still non-NULL in second test.
Best regards,
Pavel
--
'DENX Software Engineering GmbH, Managing Director:Wolfgang Denk'
'HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany'
signature.asc
Description: Digital signature
o remove extra space. No need to add it,
either.
Best regards,
Pavel
--
http://www.livejournal.com/~pavelmachek
signature.asc
Description: Digital signature
ing to Q16.16
*/
- ff = DIV_ROUND_UP((freq << 13), (8*1000)) << 3;
+ //ff = DIV_ROUND_UP((freq << 13), (8*1000)) << 3;
+ ff = ((freq << 10) + 62) / 125;
}
*(__le32 *)buf = cpu_to_le32(ff);
}
Best regards,
Pavel.
here: (some boards are
unavailable)
https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/tree/linux-4.19.y
Tested-by: Pavel Machek (CIP)
Best regards,
Pavel
here: (some boards
are unavailable)
https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/tree/linux-4.4.y
https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/tree/linux-4.19.y
https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/tree/linux-5.10.y
Tested-by: Pavel
here:
https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/tree/linux-4.4.y
Tested-by: Pavel Machek (CIP)
Best regards,
Pavel
--
DENX Software Engineering GmbH,
= rcu_dereference(sbi->s_group_desc);
I look forward to hearing your perspective on this patch :)
With regards,
Pavel Skripkin
here:
https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/tree/linux-5.10.y
Tested-by: Pavel Machek (CIP)
Best regards,
Pavel
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office:
here:
https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/tree/linux-4.19.y
Tested-by: Pavel Machek (CIP)
Best regards,
Pavel
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office:
Hi!
On Mon, 2021-04-12 at 07:45 -0400, Alexander Aring wrote:
> Hi,
>
> On Mon, 12 Apr 2021 at 06:58, Pavel Skripkin
> wrote:
> >
> > syzbot reported WARNING in ieee802154_del_device. The problem
> > was in uninitialized mutex. In case of NL802154_IFTYPE_MONITOR
syzbot reported WARNING in ieee802154_del_device. The problem
was in uninitialized mutex. In case of NL802154_IFTYPE_MONITOR
mutex won't be initialized, but ieee802154_del_device() accessing it.
Reported-by: syzbot+bf8b5834b7ec22948...@syzkaller.appspotmail.com
Signed-off-by: Pavel Skr
On 11/04/2021 09:58, Hao Sun wrote:
> Pavel Begunkov 于2021年4月11日周日 下午4:14写道：
>>
>> On 11/04/2021 04:08, Hao Sun wrote:
>>> Hi
>>>
>>> When using Healer(https://github.com/SunHao-0/healer/tree/dev) to fuzz
>>> the Linux kernel, I found a null
00043
> R10: 0001 R11: 88804b8e0280 R12:
> R13: 8880409d5140 R14: 88804b8e0280 R15: 8880481c1800
> FS: 7f046fa1a700() GS:88807ec0() knlGS:
> CS: 0010 DS: ES: CR0: 80050033
> CR2: 0040 CR3: 479a5000 CR4: 00750ee0
> DR0: DR1: DR2:
> DR3: DR6: fffe0ff0 DR7: 0400
> PKRU: 5554
>
--
Pavel Begunkov
z or 32.768 kHz?
> +{
> + int retval;
> + long Adj;
Adj -> adj.
> +
> +static DEVICE_ATTR_WO(xt_frequency);
You are adding new user interface, you sould add documentation.
Best regards,
Pavel
't want that to run with clock being disabled and DMA
being unmapped.
We certainly don't want phy_disconnect() being undone by
phy_connect_direct() running in the workqueue.
IOW this patch is not enough to fix the bugs, and at least fix below
is needed to get something reasonable.
Signed
> > Thank you for noticing this. Not sure how this missmerge happened. I
> > have added the missing case, and VHE is initialized correctly during
> > boot.
> > [ 14.698175] kvm [1]: VHE mode initialized successfully
> >
> > During normal boot, kexec reboot, and kdump reboot. I will respin the
> >
On 4/8/21 6:26 PM, Eric Dumazet wrote:
On 4/8/21 5:14 PM, Pavel Tikhomirov wrote:
Reproduce:
modprobe sch_teql
tc qdisc add dev teql0 root teql0
This leads to (for instance in Centos 7 VM) OOPS:
Null pointer dereference happens on master->slaves dereference in
teql_destroy()
get OOPS.
Signed-off-by: Pavel Tikhomirov
---
net/sched/sch_teql.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/net/sched/sch_teql.c b/net/sched/sch_teql.c
index 2f1f0a378408..6af6b95bdb67 100644
--- a/net/sched/sch_teql.c
+++ b/net/sched/sch_teql.c
@@ -134,6 +134,9 @@ teql_
On Thu, Apr 8, 2021 at 6:24 AM Marc Zyngier wrote:
>
> On 2021-04-08 05:05, Pavel Tatashin wrote:
> > From: James Morse
> >
> > The hyp-stub's el1_sync code doesn't do very much, this can easily fit
> > in the vectors.
> >
> > With this, all of
?x=86318203e865a02b
> dashboard link: https://syzkaller.appspot.com/bug?extid=93f72b3885406bb09e0d
> compiler:
>
--
Pavel Begunkov
On 08/04/2021 06:05, syzbot wrote:
> Hello,
>
> syzbot has tested the proposed patch but the reproducer is still triggering
> an issue:
> INFO: task hung in io_ring_exit_work
Ok, it's really fancy, we add task_work with TWA_SIGNAL to a guaranteed
not exited/exec task, it succeeds, but the appare
n the mapping
it is executing from.
The makes no difference yet as the relocation code runs with the MMU
disabled.
Co-developed-by: James Morse
Signed-off-by: Pavel Tatashin
---
arch/arm64/include/asm/assembler.h | 19 +++
arch/arm64/include/asm/kexec.h | 2 ++
arch/
message]
Signed-off-by: Pavel Tatashin
---
arch/arm64/include/asm/trans_pgd.h | 5 +--
arch/arm64/mm/trans_pgd.c | 57 --
2 files changed, 1 insertion(+), 61 deletions(-)
diff --git a/arch/arm64/include/asm/trans_pgd.h
b/arch/arm64/include/asm/trans_pgd.h
index
This header contains only cpu_soft_restart() which is never used directly
anymore. So, remove this header, and rename the helper to be
cpu_soft_restart().
Suggested-by: James Morse
Signed-off-by: Pavel Tatashin
---
arch/arm64/include/asm/kexec.h| 6 ++
arch/arm64/kernel/cpu-reset.S
Currently, relocation code declares start and end variables
which are used to compute its size.
The better way to do this is to use ld script incited, and put relocation
function in its own section.
Signed-off-by: Pavel Tatashin
---
arch/arm64/include/asm/sections.h | 1 +
arch/arm64/kernel
Now that kexec does its relocations with the MMU enabled, we no longer
need to clean the relocation data to the PoC.
Co-developed-by: James Morse
Signed-off-by: Pavel Tatashin
---
arch/arm64/kernel/machine_kexec.c | 40 ---
1 file changed, 40 deletions(-)
diff
second.
Signed-off-by: Pavel Tatashin
---
arch/arm64/include/asm/kexec.h | 3 +++
arch/arm64/kernel/asm-offsets.c | 1 +
arch/arm64/kernel/machine_kexec.c | 16 ++
arch/arm64/kernel/relocate_kernel.S | 33 +++--
4 files changed, 38 insertions
Since we are going to keep MMU enabled during relocation, we need to
keep EL1 mode throughout the relocation.
Keep EL1 enabled, and switch EL2 only before enterying the new world.
Suggested-by: James Morse
Signed-off-by: Pavel Tatashin
---
arch/arm64/kernel/cpu-reset.h | 3 +--
arch
If we have a EL2 mode without VHE, the EL2 vectors are needed in order
to switch to EL2 and jump to new world with hypervisor privileges.
In preporation to MMU enabled relocation, configure our EL2 table now.
Suggested-by: James Morse
Signed-off-by: Pavel Tatashin
---
arch/arm64/Kconfig
more arguments: once we enable MMU we
will need to pass information about page tables.
Pass kimage to arm64_relocate_new_kernel, and teach it to get the
required fields from kimage.
Suggested-by: James Morse
Signed-off-by: Pavel Tatashin
---
arch/arm64/kernel/asm-offsets.c | 7 +++
arch
on
the eye.
Code generated by the existing callers is unchanged.
Signed-off-by: James Morse
[Fixed merging issues]
Signed-off-by: Pavel Tatashin
---
arch/arm64/include/asm/assembler.h | 12
arch/arm64/kernel/relocate_kernel.S | 13 +++--
2 files changed, 11 insertions
Currently, during kexec load we are copying relocation function and
flushing it. However, we can also flush kexec relocation buffers and
if new kernel image is already in place (i.e. crash kernel), we can
also flush the new kernel image itself.
Signed-off-by: Pavel Tatashin
---
arch/arm64
In case of kdump or when segments are already in place the relocation
is not needed, therefore the setup of relocation function and call to
it can be skipped.
Signed-off-by: Pavel Tatashin
Suggested-by: James Morse
---
arch/arm64/kernel/machine_kexec.c | 34
Currently, only hibernate sets custom ttbr0 with safe idmaped function.
Kexec, is also going to be using this functinality when relocation code
is going to be idmapped.
Move the setup seqeuence to a dedicated cpu_install_ttbr0() for custom
ttbr0.
Suggested-by: James Morse
Signed-off-by: Pavel
Replace places that contain logic like this:
is_hyp_mode_available() && !is_kernel_in_hyp_mode()
With a dedicated boolean function is_hyp_callable(). This will be needed
later in kexec in order to sooner switch back to EL2.
Suggested-by: James Morse
Signed-off-by: Pavel
Users of trans_pgd may also need a copy of vector table because it is
also may be overwritten if a linear map can be overwritten.
Move setup of EL2 vectors from hibernate to trans_pgd, so it can be
later shared with kexec as well.
Suggested-by: James Morse
Signed-off-by: Pavel Tatashin
t.
Signed-off-by: James Morse
[Fixed merging issues]
Signed-off-by: Pavel Tatashin
---
arch/arm64/kernel/hyp-stub.S | 59 ++--
1 file changed, 29 insertions(+), 30 deletions(-)
diff --git a/arch/arm64/kernel/hyp-stub.S b/arch/arm64/kernel/hyp-stub.S
index ff
ained within
its vectors.
Signed-off-by: James Morse
[Fixed merging issues]
Signed-off-by: Pavel Tatashin
---
arch/arm64/kernel/hyp-stub.S | 56 +++-
1 file changed, 23 insertions(+), 33 deletions(-)
diff --git a/arch/arm64/kernel/hyp-stub.S b/arch/arm64/kerne
marker, and
add a build check that we didn't overflow 2K.
Signed-off-by: James Morse
Signed-off-by: Pavel Tatashin
---
arch/arm64/kernel/hyp-stub.S | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/kernel/hyp-stub.S b/arch/arm64/kernel/hyp-stub.
sha.tatas...@soleen.com
James Morse (4):
arm64: hyp-stub: Check the size of the HYP stub's vectors
arm64: hyp-stub: Move invalid vector entries into the vectors
arm64: hyp-stub: Move el1_sync into the vectors
arm64: kexec: Use dcache ops macros instead of open-coding
Pavel Tatashin
On 07/04/2021 20:51, Pavel Begunkov wrote:
> On 05/04/2021 20:34, syzbot wrote:
>> Hello,
>>
>> syzbot has tested the proposed patch but the reproducer is still triggering
>> an issue:
>> INFO: task hung in io_ring_exit_work
>
> Let's see if it'
race.c:62
> trigger_all_cpu_backtrace include/linux/nmi.h:146 [inline]
> check_hung_uninterruptible_tasks kernel/hung_task.c:209 [inline]
> watchdog+0xd48/0xfb0 kernel/hung_task.c:294
> kthread+0x3b1/0x4a0 kernel/kthread.c:292
>
nt __init bcache_init(void)
>
> check_module_parameters();
>
> - mutex_init(&bch_register_lock);
> init_waitqueue_head(&unregister_wait);
> register_reboot_notifier(&reboot);
>
Pavel Goran
rt") you might be able to just use of_platform_populate()
> instead of walking the child nodes in gsm_serdev_register_tty_port().
I have "gsmmux,port" for that. And yes, I can take a look at
of_platform_populate.
But as I explained above, there's still problem with the parent
devices.
Best regards,
Pavel
--
http://www.livejournal.com/~pavelmachek
signature.asc
Description: Digital signature
here:
https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/tree/linux-4.4.y
Tested-by: Pavel Machek (CIP)
Best regards,
Pavel
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kir
roblems here: (Siemens boards
are unavailable)
https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/tree/linux-4.19.y
Tested-by: Pavel Machek (CIP)
Best regards,
Pavel
--
DENX Software Engineering GmbH, Managing Director: W
roblems here: (Siemens boards
are unavailable)
https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/tree/linux-5.10.y
Tested-by: Pavel Machek (CIP)
Best regards,
Pavel
--
DENX Software Engineering GmbH, Managing Director: W
of this actually leaking are practically zero, so I
> didn't want to bloat this bugfix with what's essentially dead code. I
> can queue up your fix below for v5.14, though, since it's obviously
> more correct from a theoretical point of view.
Yes, that sounds like good solut
On Tue, 2021-04-06 at 08:21 -0400, Alexander Aring wrote:
> Hi,
>
> On Mon, 5 Apr 2021 at 15:58, Pavel Skripkin
> wrote:
> >
> > syzbot reported shift-out-of-bounds in nl802154_new_interface.
> > The problem was in signed representation of enum nl802154_iftype
type
will be represented as signed integer.
type = nla_get_u32(info->attrs[NL802154_ATTR_IFTYPE]);
u32 will be casted to signed, which can cause negative value type.
Reported-by: syzbot+7bf7b22759195c9a2...@syzkaller.appspotmail.com
Signed-off-by: Pavel Skripkin
---
net/ieee802154/nl802
e4 RDI:
> RBP: 19f2 R08: R09: 7ffe75923090
> R10: 0000 R11: 0246 R12: 7ffe758f7ce4
> R13: 7ffe758f7d40 R14: 028f R15: 7ffe758f7d20
>
>
> ---
> This report is generated by a bot. It may contain errors.
> See https://goo.gl/tpsmEJ for more information about syzbot.
> syzbot engineers can be reached at syzkal...@googlegroups.com.
>
> syzbot will keep track of this issue. See:
> https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
> syzbot can test patches for this issue, for details see:
> https://goo.gl/tpsmEJ#testing-patches
>
--
Pavel Begunkov
sure that the SOR
> power domain is not powered off by holding on to a runtime PM reference
> to that power domain across the reset assert/deassert operation.
Yeah, but it should not leak the PM reference in the error handling.
Signed-off-by: Pavel Mach
ok at the goto. Does not need to be there.
Second check the crazy calling convention. If nic_start() fails, it
should clean up after itself.
Then, check the code. nic_stop() undoes initialization that was not
even done in the nic_start().
This introduces more problems than it solves.
Best regard
);
> }
The switch only takes the lock in 3 branches, but it is released
unconditionally at the end.
Something like this?
Best regards,
Pavel
Signed-off-by: Pavel Machek (CIP)
diff --git a/drivers/net/wireless/ath/ath10k/wmi-tl
r stable. I don't think any of the
follow up patches depend on it...?
Best regards,
Pavel
> drivers/net/can/Makefile | 7 +--
> drivers/net/can/dev/Makefile | 7 +++
> drivers/net/can/{ =&
ior.
This adds new counter exported via sysfs, but no documentation of that
counter...
Best regards,
Pavel
> @@ -257,6 +259,7 @@ static struct attribute *ext4_attrs[] = {
> ATTR_LIST(session_write_kbyte
Hi!
On Sun, 2021-04-04 at 20:43 -0400, Alexander Aring wrote:
> Hi,
>
> On Thu, 4 Mar 2021 at 10:25, Pavel Skripkin
> wrote:
> >
> > syzbot found general protection fault in crypto_destroy_tfm()[1].
> > It was caused by wrong clean up loop in llsec_key_alloc(
Hi!
On Sat, 2021-04-03 at 18:26 +0200, Johannes Berg wrote:
> On Sat, 2021-04-03 at 15:13 +0000, Pavel Skripkin wrote:
> > genl_family_rcv_msg_attrs_parse() can return NULL
> > pointer:
> >
> > if (!ops->maxattr)
> > return NULL;
>
sg+0x328/0x580 net/netlink/genetlink.c:800
Reported-by: syzbot+ac5c11d2959a8b3c4...@syzkaller.appspotmail.com
Signed-off-by: Pavel Skripkin
---
net/ieee802154/nl802154.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/net/ieee802154/nl802154.c b/net/ieee802154/nl802154
genl_family_rcv_msg_attrs_parse() can return NULL
pointer:
if (!ops->maxattr)
return NULL;
But this condition doesn't cause an error in
genl_family_rcv_msg_doit
Signed-off-by: Pavel Skripkin
---
net/netlink/genetlink.c | 2 ++
1 file changed, 2 insertions(
e3+set_tid can work for restoring pids on each level of
nested user and pid namespaces when used together with userns_fd:
https://github.com/Snorch/clone3_owner_ns
Signed-off-by: Pavel Tikhomirov
---
include/linux/nsproxy.h| 3 ++-
include/linux/sched/task.h | 1 +
include/linux/user_name
On 20/11/2020 19:13, Jens Axboe wrote:
> On 11/20/20 10:10 AM, Pavel Begunkov wrote:
>> io_uring's direct nowait requests end up waiting on io_schedule() in
>> sbitmap, that's seems to be so because blkdev_direct_IO() fails to
>> propagate IOCB_NOWAIT to a bio and he
> > Andrew, since "mm cma: rename PF_MEMALLOC_NOCMA to PF_MEMALLOC_PIN" is
> > not yet in the mainline, should I send a new version of this patch so
> > we won't have bisecting problems in the future?
>
> I've already added Mike's fix, as
> mm-cma-rename-pf_memalloc_nocma-to-pf_memalloc_pin-fix.pat
usb/pcan_usb_core.c:851 [inline] [1]
[<c09f9057>] peak_usb_probe+0x389/0x490
drivers/net/can/usb/peak_usb/pcan_usb_core.c:949
Reported-by: syzbot+91adee8d9ebb9193d...@syzkaller.appspotmail.com
Signed-off-by: Pavel Skripkin
---
drivers/net/can/usb/peak_usb/pcan_usb_core.c | 6 +-
1
1 - 100 of 8040 matches
Mail list logo
