Re: [PATCH] bcache: btree.c: Fix GC thread exit in case of cache device failure and unregister

2018-01-12 Thread Pavel Vazharov
On Sat, 13 Jan 2018 12:06:26 +0800 Coly Li wrote: > On 12/01/2018 11:24 PM, Pavel Vazharov wrote: > > There was a possibility for infinite do-while loop inside the GC thread > > function in case of total failure of the caching device. I was able to > > reproduce

Re: [PATCH] bcache: io.c: Fix check against error_limit in case of io errors

2018-01-12 Thread Pavel Vazharov
On Sat, 13 Jan 2018 11:40:54 +0800 Coly Li wrote: > On 12/01/2018 10:07 PM, Pavel Vazharov wrote: > > The actual sysfs io_error_limit value is left shifted IO_ERROR_SHIFT > > times before it is stored in the error_limit. > > This fixes the un-registering of the cache set whe

[PATCH] bcache: btree.c: Fix GC thread exit in case of cache device failure and unregister

2018-01-12 Thread Pavel Vazharov
re if the unregistering procedure has already started. Signed-off-by: Pavel Vazharov --- drivers/md/bcache/btree.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/md/bcache/btree.c b/drivers/md/bcache/btree.c index 81e8dc3..a672081 100644 --- a/drivers/md/bcache/b

[PATCH] bcache: io.c: Fix check against error_limit in case of io errors

2018-01-12 Thread Pavel Vazharov
The actual sysfs io_error_limit value is left shifted IO_ERROR_SHIFT times before it is stored in the error_limit. This fixes the un-registering of the cache set when the io_errors reach the error_limit value. Signed-off-by: Pavel Vazharov --- drivers/md/bcache/io.c | 2 +- 1 file changed, 1