From: Pawel Laszczak
Patch fixes lack of removing request from ep->pending_list on failure
of the stop endpoint command. Driver even after failing this command
must remove request from ep->pending_list.
Without this fix driver can stuck in cdnsp_gadget_ep_disable function
in loop:
>On 21-04-19 09:50:53, Pawel Laszczak wrote:
>> From: Pawel Laszczak
>>
>> Patch adds disabling endpoint before enabling it during changing
>> alternate setting. Lack of this functionality causes that in some
>> cases uac2 queue the same request multiple time.
From: Pawel Laszczak
Patch fixes lack of removing request from ep->pending_list on failure
of the stop endpoint command. Driver even after failing this command
must remove request from ep->pending_list.
Without this fix driver can stuck in cdnsp_gadget_ep_disable function
in loop:
From: Pawel Laszczak
Patch adds disabling endpoint before enabling it during changing
alternate setting. Lack of this functionality causes that in some
cases uac2 queue the same request multiple time.
Such situation can occur when host send set interface with
alternate setting 1 twice.
Signed
>
>On 21-04-07 08:36:29, Pawel Laszczak wrote:
>> From: Pawel Laszczak
>>
>> Patch adds flag EP_UNCONFIGURED to detect whether endpoint was
>> unconfigured. This flag is set in cdnsp_reset_device after Reset Device
>> command. Among others this command disable
From: Pawel Laszczak
Patch adds flag EP_UNCONFIGURED to detect whether endpoint was
unconfigured. This flag is set in cdnsp_reset_device after Reset Device
command. Among others this command disables all non control endpoints.
Flag is used in cdnsp_gadget_ep_disable to protect controller against
Hi Peter,
>
>On 21-03-22 07:09:02, Pawel Laszczak wrote:
>> From: Pawel Laszczak
>>
>> Patch adds flag EP_UNCONFIGURED to detect whether endpoint was
>> unconfigured. This flag is set in cdnsp_reset_device after Reset Device
>> command. Among others t
>
>On 21-03-22 07:19:46, Pawel Laszczak wrote:
>> Hi Peter,
>>
>> Can you add this patch to for-usb-next branch.
>>
>
>Feel free add your ACK base on this patch.
>
>Peter
>> Thanks.
>>
>> >
>> >
>> >dma_alloc_coherent
value")
>Signed-off-by: Colin Ian King
Reviewed-by: Pawel Laszczak
>---
> drivers/usb/cdns3/cdnsp-mem.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/usb/cdns3/cdnsp-mem.c b/drivers/usb/cdns3/cdnsp-mem.c
>index 7a84e928710e..d87b640e
Hi Peter,
Can you add this patch to for-usb-next branch.
Thanks.
>
>
>dma_alloc_coherent already zeroes out memory, so memset is not needed.
>
>Signed-off-by: Wang Qing
Reviewed-by: Pawel Laszczak
>---
> drivers/usb/cdns3/cdnsp-mem.c | 1 -
> 1 file changed, 1 d
From: Pawel Laszczak
Patch adds flag EP_UNCONFIGURED to detect whether endpoint was
unconfigured. This flag is set in cdnsp_reset_device after Reset Device
command. Among others this command disables all non control endpoints.
Flag is used in cdnsp_gadget_ep_disable to protect controller against
in part of Cadence
> USBSSP DRD Driver")
>
>has these problem(s):
>
> - leading word 'commit' unexpected
>
>--
>Cheers,
>Stephen Rothwell
Regards,
Pawel Laszczak
From: Pawel Laszczak
Patch fixes the bug:
BUG: kernel NULL pointer dereference, address: 0050
PGD 0 P4D 0
Oops: 0002 [#1] SMP PTI
CPU: 0 PID: 4137 Comm: uvc-gadget Tainted: G OE
5.10.0-next-20201214+ #3
Hardware name: ASUS All Series/Q87T, BIOS 0908 07/22/2014
RIP
From: Pawel Laszczak
Patch fixes the bug:
BUG: kernel NULL pointer dereference, address: 0050
PGD 0 P4D 0
Oops: 0002 [#1] SMP PTI
CPU: 0 PID: 4137 Comm: uvc-gadget Tainted: G OE
5.10.0-next-20201214+ #3
Hardware name: ASUS All Series/Q87T, BIOS 0908 07/22/2014
RIP
From: Pawel Laszczak
According with USB Device Class Definition for Video Device the
Processing Unit Descriptor bLength should be 12 (10 + bmControlSize),
but it has 11.
Invalid length caused that Processing Unit Descriptor Test Video form
CV tool failed. To fix this issue patch adds
Please ignore this one patch. I need to resend it. It causes compilation error.
Sorry for that.
>
>From: Pawel Laszczak
>
>According with USB Device Class Definition for Video Device the
>Processing Unit Descriptor bLength should be 12 (10 + bmControlSize),
>but it has 11.
From: Pawel Laszczak
Command Verifier during UVC Descriptor Tests (Class Video Control
Interface Descriptor Test Video) complains about:
Video Control Interface Header bcdUVC is 0x0100. USB Video Class
specification 1.0 has been replaced by 1.1 specification
(UVC: 6.2.26) Class Video Control
From: Pawel Laszczak
According with USB Device Class Definition for Video Device the
Processing Unit Descriptor bLength should be 12 (10 + bmControlSize),
but it has 11.
Invalid length caused that Processing Unit Descriptor Test Video form
CV tool failed. To fix this issue patch adds
Hi Laurent
>
>Hello Pawel,
>
>Thank you for the patch.
>
>On Sun, Mar 14, 2021 at 09:58:46AM +0800, Peter Chen wrote:
>> On 21-03-08 11:27:34, Pawel Laszczak wrote:
>> > From: Pawel Laszczak
>> >
>> > Command Verifier during UVC Descriptor Tests
Please check whether the problem occurs in this fragment of code:
https://elixir.bootlin.com/linux/latest/source/drivers/usb/cdns3/gadget.c#L2569
zlp_buff is allocated with kzalloc.
Pawel
>>On Fri, Mar 5, 2021 at 12:40 AM Pawel Laszczak <mailto:paw...@cadence.com>
>>wr
From: Pawel Laszczak
According with USB Device Class Definition for Video Device the
Processing Unit Descriptor bLength should be 12 (10 + bmControlSize),
but it has 11.
Invalid length caused that Processing Unit Descriptor Test Video form
CV tool failed. To fix this issue patch adds
Peter,
You're right. This patch is wrong. I didn't remove the
"uvc_hs_streaming_ep.bInterval"
assignment.
It has been fixed in v2.
Pawel
>>
>>On Fri, Mar 5, 2021 at 12:40 AM Pawel Laszczak <mailto:paw...@cadence.com>
>>wrote:
>>From: Pawel Laszcza
From: Pawel Laszczak
Patch adds extra checking for bInterval passed by configfs.
The 5.6.4 chapter of USB Specification (rev. 2.0) say:
"A high-bandwidth endpoint must specify a period of 1x125 µs
(i.e., a bInterval value of 1)."
The issue was observed during testing UVC class on C
From: Pawel Laszczak
According with USB Device Class Definition for Video Device the
Processing Unit Descriptor bLength should be 12 (10 + bmControlSize),
but it has 11.
Invalid length caused that Processing Unit Descriptor Test Video form
CV tool failed. To fix this issue patch adds
From: Pawel Laszczak
Command Verifier during UVC Descriptor Tests (Class Video Control
Interface Descriptor Test Video) compleins about:
Video Control Interface Header bcdUVC is 0x0100. USB Video Class
specification 1.0 has been replaced by 1.1 specification
(UVC: 6.2.26) Class Video Control
>
>On Fri, Mar 5, 2021 at 12:40 AM Pawel Laszczak <mailto:paw...@cadence.com>
>wrote:
>From: Pawel Laszczak <mailto:paw...@cadence.com>
>
>Patch adds extra checking for bInterval passed by configfs.
>The 5.6.4 chapter of USB Specification (rev. 2.0) say:
>&qu
You have right. It's the operator priority issue.
I've made this condition as separate "if" statement as suggested by Greg.
V2 has been posted.
Pawel
>
>
>On 21-03-05 06:10:59, Pawel Laszczak wrote:
>> From: Pawel Laszczak
>>
>> The value "
From: Pawel Laszczak
Fixes issue with priority of operator. Operator "|" priority is
higher then "? :".
To improve the readability the operator "? :" has been replaced with
"if ()" statement.
Fixes: 3d82904559f4 ("usb: cdnsp: cdns3 Add main pa
Hi,
Please ignore this patch. I put incorrect address to Peter. I have sent again
this patch with correct email address.
>-Original Message-
>From: Pawel Laszczak
>Sent: Friday, March 5, 2021 6:00 AM
>To: peter.c...@nxp.com
>Cc: gre...@linuxfoundation.org; linux-...@
From: Pawel Laszczak
The value "start_cycle ? 0 : 1" in assignment caused
implicit truncation whole value to 1 byte.
To fix the issue, an explicit casting has been added.
Fixes: commit 3d82904559f4 ("usb: cdnsp: cdns3 Add main part of Cadence USBSSP
DRD Driver")
Signed-of
From: Pawel Laszczak
The value "start_cycle ? 0 : 1" in assignment caused
implicit truncation whole value to 1 byte.
To fix the issue, an explicit casting has been added.
Fixes: commit 3d82904559f4 ("usb: cdnsp: cdns3 Add main part of Cadence USBSSP
DRD Driver")
Signed-of
From: Pawel Laszczak
Patch adds extra checking for bInterval passed by configfs.
The 5.6.4 chapter of USB Specification (rev. 2.0) say:
"A high-bandwidth endpoint must specify a period of 1x125 µs
(i.e., a bInterval value of 1)."
The issue was observed during testing UVC class on C
+ Peter Chen - Maintainer of CDNS3 driver
>
>[ Resending with an address that should work for Felipe ]
>
>On Sat, 27 Feb 2021 14:18:02 -0500
>Steven Rostedt wrote:
>
>> On Fri, 26 Feb 2021 14:21:00 -0800
>> Linus Torvalds wrote:
>>
>> > On Fri, Feb 26, 2021 at 11:07 AM Steven Rostedt
>> >
I've sent the patch that remove this one and others similar printk from driver.
>
>
>On Thu, Feb 04, 2021 at 05:07:16AM +0000, Pawel Laszczak wrote:
>> Hi Dan,
>>
>> >> From: Colin Ian King
>> >>
>> >> There is a spelling mistake in a
Patch removes some useless trace events that can
be replaced by ftrace.
Reported-by: Dan Carpenter
Signed-off-by: Pawel Laszczak
---
drivers/usb/cdns3/cdnsp-ep0.c| 5 -
drivers/usb/cdns3/cdnsp-gadget.c | 2 --
drivers/usb/cdns3/cdnsp-ring.c | 1 -
drivers/usb/cdns3/cdnsp-trace.h
sp* functions (echo cdnsp* >
set_ftrace_filter) but it
increases the trace log and makes it a little more difficult to analyze.
So maybe in some cases we shouldn't complain for such printk ?
It's my private opinion and not necessarily correct :)
Thanks,
Pawel Laszczak
>
>regards,
>dan carpenter
Hi Peter,
Can you replace the previous version with this one.
The v1 still has problem with undefined reference when CONFIG_PCI or
CONFIG_ACPI are disabled.
V2 fixes this issue.
Thanks,
Regards,
Pawel Laszczak
>From: Pawel Laszczak
>Sent: Wednesday, January 13, 2021 3:14 PM
>To
occurs for USB/CDNS3/CDNSP kernel configuration:
CONFIG_USB=m
CONFIG_USB_CDNS_SUPPORT=y
CONFIG_USB_CDNS3=m
CONFIG_USB_CDNS3_PCI_WRAP=m
CONFIG_USB_CDNSP_PCI=y
Reported-by: Randy Dunlap
Signed-off-by: Pawel Laszczak
---
changelog:
v2
- added missing condition
drivers/usb/cdns3/Makefile | 8
occurs for USB/CDNS3/CDNSP kernel configuration:
CONFIG_USB=m
CONFIG_USB_CDNS_SUPPORT=y
CONFIG_USB_CDNS3=m
CONFIG_USB_CDNS3_PCI_WRAP=m
CONFIG_USB_CDNSP_PCI=y
Reported-by: Randy Dunlap
Signed-off-by: Pawel Laszczak
---
drivers/usb/cdns3/Makefile | 4
1 file changed, 4 insertions(+)
diff
ecture.
>
>Signed-off-by: Pawel Laszczak
>Reported-by: kernel test robot
>---
> drivers/usb/cdns3/core.h | 12 ++--
> drivers/usb/cdns3/drd.c | 12 ++--
> 2 files changed, 12 insertions(+), 12 deletions(-)
>
>diff --git a/drivers/usb/cdns3/core.
Patch adds missing __iomem markers in core.h file
and makes some changes in drd.c file related with
these markers.
The lack of __iomem has reported by sparse checker
on parsic architecture.
Reported-by: kernel test robot
Signed-off-by: Pawel Laszczak
---
Changelog:
v2
- fixed typo
>>On 20-12-15 05:27:38, Pawel Laszczak wrote:
>>> >
>>> >
>>> >On 20-12-14 13:03:44, Pawel Laszczak wrote:
>>> >> Patch fixes all sparse warnings in cdsnp driver.
>>> >>
>>> >> It fixes the following warnings:
&
>On 20-12-15 05:27:38, Pawel Laszczak wrote:
>> >
>> >
>> >On 20-12-14 13:03:44, Pawel Laszczak wrote:
>> >> Patch fixes all sparse warnings in cdsnp driver.
>> >>
>> >> It fixes the following warnings:
>> >> cdnsp-ring.
>
>
>On 20-12-14 13:03:44, Pawel Laszczak wrote:
>> Patch fixes all sparse warnings in cdsnp driver.
>>
>> It fixes the following warnings:
>> cdnsp-ring.c:1441: warning: incorrect type in assignment
>> cdnsp-ring.c:1444: warning: restricted __le32 degrades t
Patch adds missing __iomem markers in core.h file
and makes some changes in drd.c file related with
these markers.
The lack of __iomem has reported by sparse checker
on parsic architecture.
Signed-off-by: Pawel Laszczak
Reported-by: kernel test robot
---
drivers/usb/cdns3/core.h | 12
__le32 degrades to integer
cdnsp-ep0.c:179: warning: incorrect type in argument 1
cdnsp-ep0.c:311: warning: incorrect type in argument 1
cdnsp-ep0.c:469: warning: incorrect type in assignment
cdnsp-trace.h:611:1: warning: cast from restricted __le32
Signed-off-by: Pawel Laszczak
Reported-by: kernel
-gadget.c:1253: sparse: right side has type unsigned long
cdns3-ep0.c:367: sparse: warning: restricted __le16 degrades to integer
cdns3-ep0.c:792: sparse: warning: symbol 'cdns3_gadget_ep0_ops' was not
declared. Should it be static?
Signed-off-by: Pawel Laszczak
dns3_suspend_quirk(struct usb_hcd *hcd)
>>>> {
>>>> struct xhci_hcd *xhci = hcd_to_xhci(hcd);
>>>>
>>>>
>>>>
>>>>
>>>> CONFIG_USB_GADGET=y
>>>> CONFIG_USB_SUPPORT=y
>>>> CONFIG_USB_COMMON=y
>>>> # CONFIG_USB_CONN_GPIO is not set
>>>> CONFIG_USB_ARCH_HAS_HCD=y
>>>> CONFIG_USB=m
>>>>
>>>> CONFIG_USB_CDNS_SUPPORT=y
>>>> CONFIG_USB_CDNS_HOST=y
>>>> CONFIG_USB_CDNS3=m
>>>> CONFIG_USB_CDNS3_GADGET=y
>>>> CONFIG_USB_CDNS3_HOST=y
>>>>
>>>> Problem is mostly that CONFIG_USB=m and CONFIG_USB_GADGET=y.
>>>>
>>>>
>>>> Full randconfig file is attached.
>>>>
>>>>
>>>> thanks.
>>>> --
>>>> ~Randy
>>>> Reported-by: Randy Dunlap
>>>
>>>
>>>
--
Thanks
Pawel Laszczak
; {
>>> struct xhci_hcd *xhci = hcd_to_xhci(hcd);
>>>
>>>
>>>
>>>
>>> CONFIG_USB_GADGET=y
>>> CONFIG_USB_SUPPORT=y
>>> CONFIG_USB_COMMON=y
>>> # CONFIG_USB_CONN_GPIO is not set
>>> CONFIG_USB_ARCH_HAS_HCD=y
>>> CONFIG_USB=m
>>>
>>> CONFIG_USB_CDNS_SUPPORT=y
>>> CONFIG_USB_CDNS_HOST=y
>>> CONFIG_USB_CDNS3=m
>>> CONFIG_USB_CDNS3_GADGET=y
>>> CONFIG_USB_CDNS3_HOST=y
>>>
>>> Problem is mostly that CONFIG_USB=m and CONFIG_USB_GADGET=y.
>>>
>>>
>>> Full randconfig file is attached.
>>>
>>>
>>> thanks.
>>> --
>>> ~Randy
>>> Reported-by: Randy Dunlap
>>
>>
>>
--
Thanks
Pawel Laszczak
t;>
>> CONFIG_USB_GADGET=y
>> CONFIG_USB_SUPPORT=y
>> CONFIG_USB_COMMON=y
>> # CONFIG_USB_CONN_GPIO is not set
>> CONFIG_USB_ARCH_HAS_HCD=y
>> CONFIG_USB=m
>>
>> CONFIG_USB_CDNS_SUPPORT=y
>> CONFIG_USB_CDNS_HOST=y
>> CONFIG_USB_CDNS3=m
>> CONFIG_USB_CDNS3_GADGET=y
>> CONFIG_USB_CDNS3_HOST=y
>>
>> Problem is mostly that CONFIG_USB=m and CONFIG_USB_GADGET=y.
>>
>>
>> Full randconfig file is attached.
>>
>>
>> thanks.
>> --
>> ~Randy
>> Reported-by: Randy Dunlap
>
>
>
--
Thanks
Pawel Laszczak
>
>On 12/9/20 12:15 PM, Souptick Joarder wrote:
>> Kernel test robot throws below warning ->
>>
>> In file included from drivers/usb/cdns3/core.c:23:
drivers/usb/cdns3/host-export.h:27:51: warning: 'struct usb_hcd'
declared inside parameter list will not be visible outside of this
Patch adds entry for USBSSP (CDNSP) driver into MAINTARNERS file.
Signed-off-by: Pawel Laszczak
---
MAINTAINERS | 9 +
1 file changed, 9 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 213b92ffe891..255390789176 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3859,6 +3859,15
Patch moves common reusable code used by cdns3 and cdnsp driver
to cdns-usb-common library. This library include core.c, drd.c
and host.c files.
Signed-off-by: Pawel Laszczak
Tested-by: Aswath Govindraju
---
drivers/usb/cdns3/Kconfig | 8
drivers/usb/cdns3/Makefile | 8
Patch splits file core.c into core.c containing the common reusable code
and cnd3-plat.c containing device platform specific code. These changes
are required to make possible reuse DRD part of CDNS3 driver in CDNSP
driver.
Signed-off-by: Pawel Laszczak
Tested-by: Aswath Govindraju
---
drivers
les to cdns3 as suggested by Peter Chen
- removed duplicate code from cdnsp_ep0_set_config function
- added cdns3 prefixes to file related with USBSS driver
- updated MAINTAINERS file
- fixed issue with U1
- fixed issue with L1
- some less improtant changes suggested by Chunfeng Yun
---
Pa
driver
cdns3: for names related only with cdns3 driver
Signed-off-by: Pawel Laszczak
Tested-by: Aswath Govindraju
---
drivers/usb/cdns3/cdns3-imx.c | 2 +-
drivers/usb/cdns3/cdns3-plat.c| 25 +++---
drivers/usb/cdns3/core.c | 142 +++---
drivers/usb
Patch adds the series of tracepoints that can be used for
debugging issues detected in driver.
Signed-off-by: Pawel Laszczak
Reviewed-by: Peter Chen
---
drivers/usb/cdns3/Makefile | 5 +
drivers/usb/cdns3/cdnsp-debug.h | 583 +
drivers/usb/cdns3/cdnsp-ep0.c
Patch defines macros, registers and structures used by
Device side driver.
Because the size of main patch is very big, I’ve decided to create
separate patch for cdnsp-gadget.h. It should simplify reviewing the code.
Signed-off-by: Pawel Laszczak
---
drivers/usb/cdns3/cdnsp-gadget.h | 1463
Patch changes the type for gadget_dev pointer in cdns structure from
pointer to cdns3_device structure to void pointer.
This filed is in reusable code and after this change it will be used to
point to both cdns3_device or cdnsp_device objects.
Signed-off-by: Pawel Laszczak
Tested-by: Aswath
was reused for CDNSP driver.
Signed-off-by: Pawel Laszczak
Tested-by: Aswath Govindraju
---
drivers/usb/cdns3/core.c | 24 +++---
drivers/usb/cdns3/core.h | 5 ++
drivers/usb/cdns3/drd.c | 101 +++
drivers/usb/cdns3/drd.h | 67 +-
4
Patch adds prefix cdns3- to all file names related only to
cdns3 driver.
Signed-off-by: Pawel Laszczak
---
drivers/usb/cdns3/Makefile | 6 +++---
drivers/usb/cdns3/{debug.h => cdns3-debug.h} | 0
drivers/usb/cdns3/{ep0.c => cdns3-ep0.c} | 4 ++--
drivers/usb
>
>On 20-12-02 14:25:38, Pawel Laszczak wrote:
>> This patch introduce new Cadence USBSS DRD driver to linux kernel.
>>
>> The Cadence USBSS DRD Controller is a highly configurable IP Core which
>> can be instantiated as Dual-Role Device (DRD), Peripheral Only and
>
Patch moves common reusable code used by cdns3 and cdnsp driver
to cdns-usb-common library. This library include core.c, drd.c
and host.c files.
Signed-off-by: Pawel Laszczak
---
drivers/usb/cdns3/Kconfig | 8
drivers/usb/cdns3/Makefile | 8 +---
drivers/usb/cdns3/cdns3
Patch adds prefix cdns3- to all file names related only to
cdns3 driver.
Signed-off-by: Pawel Laszczak
---
drivers/usb/cdns3/Makefile | 6 +++---
drivers/usb/cdns3/{debug.h => cdns3-debug.h} | 0
drivers/usb/cdns3/{ep0.c => cdns3-ep0.c} | 4 ++--
drivers/usb
was reused for CDNSP driver.
Signed-off-by: Pawel Laszczak
---
drivers/usb/cdns3/core.c | 24 +++---
drivers/usb/cdns3/core.h | 5 ++
drivers/usb/cdns3/drd.c | 101 +++
drivers/usb/cdns3/drd.h | 67 +-
4 files changed, 148 insertions
ile
- fixed issue with U1
- fixed issue with L1
- some less improtant changes sugested by Chunfeng Yun
---
Pawel Laszczak (10):
usb: cdns3: Add support for DRD CDNSP
usb: cdns3: Split core.c into cdns3-plat and core.c file
usb: cdns3: Moves reusable code to separate module
usb: cd
Patch adds entry for USBSSP (CDNSP) driver into MAINTARNERS file.
Signed-off-by: Pawel Laszczak
---
MAINTAINERS | 9 +
1 file changed, 9 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 213b92ffe891..255390789176 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3859,6 +3859,15
Patch splits file core.c into core.c containing the common reusable code
and cnd3-plat.c containing device platform specific code. These changes
are required to make possible reuse DRD part of CDNS3 driver in CDNSP
driver.
Signed-off-by: Pawel Laszczak
---
drivers/usb/cdns3/Makefile | 2
driver
cdns3: for names related only with cdns3 driver
Signed-off-by: Pawel Laszczak
---
drivers/usb/cdns3/cdns3-imx.c | 2 +-
drivers/usb/cdns3/cdns3-plat.c| 25 +++---
drivers/usb/cdns3/core.c | 142 +++---
drivers/usb/cdns3/core.h | 46
Patch defines macros, registers and structures used by
Device side driver.
Because the size of main patch is very big, I’ve decided to create
separate patch for cdnsp-gadget.h. It should simplify reviewing the code.
Signed-off-by: Pawel Laszczak
---
drivers/usb/cdns3/cdnsp-gadget.h | 1463
Patch adds the series of tracepoints that can be used for
debugging issues detected in driver.
Signed-off-by: Pawel Laszczak
Reviewed-by: Peter Chen
---
drivers/usb/cdns3/Makefile | 5 +
drivers/usb/cdns3/cdnsp-debug.h | 583 +
drivers/usb/cdns3/cdnsp-ep0.c
Patch changes the type for gadget_dev pointer in cdns structure from
pointer to cdns3_device structure to void pointer.
This filed is in reusable code and after this change it will be used to
point to both cdns3_device or cdnsp_device objects.
Signed-off-by: Pawel Laszczak
---
drivers/usb/cdns3
>
>On 25/11/2020 02:36, Peter Chen wrote:
>> On 20-11-24 14:22:25, Roger Quadros wrote:
>>> Peter,
>>>
>>> On 24/11/2020 13:47, Peter Chen wrote:
On 20-11-24 12:33:34, Roger Quadros wrote:
I am sorry about that. Do you use role switch /sys entry, if you have
used, I
Peter,
>
>>On 20-11-19 15:12:57, Pawel Laszczak wrote:
>>> This patch introduce new Cadence USBSS DRD driver to linux kernel.
>>>
>>> The Cadence USBSS DRD Controller is a highly configurable IP Core which
>>> can be instantiated as Dual-Role Device (
Peter,
>
>On 20-11-19 15:13:07, Pawel Laszczak wrote:
>> Patch adds entry for USBSSP (CDNSP) driver into MAINTARNERS file.
>>
>> Signed-off-by: Pawel Laszczak
>> ---
>> MAINTAINERS | 8
>> 1 file changed, 8 insertions(+)
>>
&g
Sekhar,
>
>
>On 24/11/20 2:51 PM, Pawel Laszczak wrote:
>> Peter,
>>
>>> On 20-11-19 15:12:57, Pawel Laszczak wrote:
>>>> This patch introduce new Cadence USBSS DRD driver to linux kernel.
>>>>
>>>> The Cadence USBSS DRD Controll
Peter,
>On 20-11-19 15:12:57, Pawel Laszczak wrote:
>> This patch introduce new Cadence USBSS DRD driver to linux kernel.
>>
>> The Cadence USBSS DRD Controller is a highly configurable IP Core which
>> can be instantiated as Dual-Role Device (DRD), Peripheral
d-off-by: Roger Quadros
Acked-by: Pawel Laszczak
I see the same issue on my PCI based platform.
But I afraid that there will be some conflict with applying my CDSNP series
after
applying this patch on Peter Chen branch :(
>---
> drivers/usb/cdns3/core.c | 2 +-
> drivers/usb/cdns3/host.
Patch adds entry for USBSSP (CDNSP) driver into MAINTARNERS file.
Signed-off-by: Pawel Laszczak
---
MAINTAINERS | 8
1 file changed, 8 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 842fef329119..70c31fd2cd61 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3867,6 +3867,14
Patch adds prefix cdns3- to all file names related only to
cdns3 driver.
Signed-off-by: Pawel Laszczak
---
drivers/usb/cdns3/Makefile | 6 +++---
drivers/usb/cdns3/{debug.h => cdns3-debug.h} | 0
drivers/usb/cdns3/{ep0.c => cdns3-ep0.c} | 4 ++--
drivers/usb
ver files to cdns3 as sugested by Peter Chan
- removed duplicate code from cdnsp_ep0_set_config function
- added cdns3 prefixes to file related with USBSS driver
- updated MAINTAINERS file
- fixed issue with U1
- fixed issue with L1
- some less improtant changes sugested by Chunfeng Yun
---
Pa
Patch defines macros, registers and structures used by
Device side driver.
Because the size of main patch is very big, I’ve decided to create
separate patch for cdnsp-gadget.h. It should simplify reviewing the code.
Signed-off-by: Pawel Laszczak
---
drivers/usb/cdns3/cdnsp-gadget.h | 1463
driver
cdns3: for names related only with cdns3 driver
Signed-off-by: Pawel Laszczak
---
drivers/usb/cdns3/cdns3-imx.c | 2 +-
drivers/usb/cdns3/cdns3-plat.c| 25 +++---
drivers/usb/cdns3/core.c | 142 +++---
drivers/usb/cdns3/core.h | 46
Patch adds the series of tracepoints that can be used for
debugging issues detected in driver.
Signed-off-by: Pawel Laszczak
Reviewed-by: Peter Chen
---
drivers/usb/cdns3/Makefile | 5 +
drivers/usb/cdns3/cdnsp-debug.h | 583 +
drivers/usb/cdns3/cdnsp-ep0.c
was reused for CDNSP driver.
Signed-off-by: Pawel Laszczak
---
drivers/usb/cdns3/core.c | 24 +++---
drivers/usb/cdns3/core.h | 5 ++
drivers/usb/cdns3/drd.c | 101 +++
drivers/usb/cdns3/drd.h | 67 +-
4 files changed, 148 insertions
Patch changes the type for gadget_dev pointer in cdns structure from
pointer to cdns3_device structure to void pointer.
This filed is in reusable code and after this change it will be used to
point to both cdns3_device or cdnsp_device objects.
Signed-off-by: Pawel Laszczak
---
drivers/usb/cdns3
Patch splits file core.c into core.c containing the common reusable code
and cnd3-plat.c containing device platform specific code. These changes
are required to make possible reuse DRD part of CDNS3 driver in CDNSP
driver.
Signed-off-by: Pawel Laszczak
---
drivers/usb/cdns3/Makefile | 2
Patch moves common reusable code used by cdns3 and cdnsp driver
to cdns-usb-common library. This library include core.c, drd.c
and host.c files.
Signed-off-by: Pawel Laszczak
---
drivers/usb/cdns3/Kconfig | 8
drivers/usb/cdns3/Makefile | 8 +---
drivers/usb/cdns3/cdns3
Hi,
>On 20-11-06 12:42:56, Pawel Laszczak wrote:
>> Patch defines macros, registers and structures used by
>> Device side driver.
>>
>> Because the size of main patch is very big, I’ve decided to create
>> separate patch for cdnsp-gadget.h. It should simplify rev
>
>On Tue, Nov 10, 2020 at 11:21:22AM +, Peter Chen wrote:
>> On 20-11-10 09:20:54, Pawel Laszczak wrote:
>> > Hi,
>> >
>> > >>
>> > >> int cdns3_hw_role_switch(struct cdns3 *cdns);
>> > >> -int cdns3_init(struct cdns3
Hi,
>
>On 20-11-06 12:42:53, Pawel Laszczak wrote:
>> Patch moves common reusable code used by cdns3 and cdnsp driver
>> to cdns-usb-common library. This library include core.c, drd.c
>> and host.c files.
>>
>> Signed-off-by: Pawel Laszczak
>> -
Hi,
>
>On Fri, Nov 06, 2020 at 12:42:50PM +0100, Pawel Laszczak wrote:
>> This patch introduce new Cadence USBSS DRD driver to linux kernel.
>>
>> The Cadence USBSS DRD Controller is a highly configurable IP Core which
>> can be instantiated as Dual-Role Device (DRD
Patch splits file core.c into core.c containing the common reusable code
and cnd3-plat.c containing device platform specific code. These changes
are required to make possible reuse DRD part of CDNS3 driver in CDNSP
driver.
Signed-off-by: Pawel Laszczak
---
drivers/usb/cdns3/Makefile | 2
Patch adds entry for USBSSP (CDNSP) driver into MAINTARNERS file.
Signed-off-by: Pawel Laszczak
---
MAINTAINERS | 7 +++
1 file changed, 7 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index f41d0e29b331..731150530d10 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3866,7 +3866,14
code from cdnsp_ep0_set_config function
- added cdns3 prefixes to file related with USBSS driver
- updated MAINTAINERS file
- fixed issue with U1
- fixed issue with L1
- some less improtant changes sugested by Chunfeng Yun
---
Pawel Laszczak (10):
usb: cdns3: Add support for DRD CDNSP
usb: cdns3
Patch adds prefix cdns3- to all file names related only to
cdsn3 driver.
Signed-off-by: Pawel Laszczak
---
drivers/usb/cdns3/Makefile | 6 +++---
drivers/usb/cdns3/{debug.h => cdns3-debug.h} | 0
drivers/usb/cdns3/{ep0.c => cdns3-ep0.c} | 4 ++--
drivers/usb
was reused for CDNSP driver.
Signed-off-by: Pawel Laszczak
---
drivers/usb/cdns3/core.c | 24 +++---
drivers/usb/cdns3/core.h | 5 ++
drivers/usb/cdns3/drd.c | 101 +++
drivers/usb/cdns3/drd.h | 67 +-
4 files changed, 148 insertions
Patch adds the series of tracepoints that can be used for
debugging issues detected in driver.
Signed-off-by: Pawel Laszczak
---
drivers/usb/cdns3/Makefile | 5 +
drivers/usb/cdns3/cdnsp-debug.h | 583 +
drivers/usb/cdns3/cdnsp-ep0.c| 22 +-
drivers/usb/cdns3
driver
cdns3: for names related only with cdns3 driver
Signed-off-by: Pawel Laszczak
---
drivers/usb/cdns3/cdns3-imx.c | 2 +-
drivers/usb/cdns3/cdns3-plat.c| 25 +++---
drivers/usb/cdns3/core.c | 142 +++---
drivers/usb/cdns3/core.h | 46
Patch changes the type for gadget_dev pointer in cdns structure from
pointer to cdns3_device structure to void pointer.
This filed is in reusable code and after this change it will be used to
point to both cdns3_device or cdnsp_device objects.
Signed-off-by: Pawel Laszczak
---
drivers/usb/cdns3
1 - 100 of 312 matches
Mail list logo
