> > {
> > u32 portsc, lpm, sts = 0;
> >
> > switch (ci->platdata->phy_mode) {
> > case USBPHY_INTERFACE_MODE_UTMI:
> > portsc = PORTSC_PTS(PTS_UTMI);
> > @@ -273,10 +275,12 @@ static void hw_phymode_configure(struct ci_hdrc
> *ci)
> >
> > if (ci->hw_bank.lpm) {
> >
Best regards,
Peter Chen
> -Original Message-
> From: linux-usb-ow...@vger.kernel.org [mailto:linux-usb-
> ow...@vger.kernel.org] On Behalf Of Chris Ruehl
> Sent: Friday, November 29, 2013 3:20 PM
> To: alexander.shish...@linux.intel.com; gre...@linuxfoundation.
ARAMS_LEN);
> ci->hw_bank.lpm = reg;
> - hw_alloc_regmap(ci, !!reg);
> + if (reg)
> + hw_alloc_regmap(ci, !!reg);
> ci->hw_bank.size = ci->hw_bank.op - ci->hw_bank.abs;
> ci->hw_bank.size += OP_LAST;
> ci->hw_bank.si
>
> On Friday, November 29, 2013 11:27 AM, Peter Chen wrote:
> >
> >> * init the sts flag to 0 (missed)
> >> * set the sts flag only if not 0
> >>
> > does PORTSC_STS bit as 1 or 0 affect your case?
> > If not, please remove hw_write(ci, OP
alize role(s) before the interrupt is requested */
> if (dr_mode == USB_DR_MODE_OTG || dr_mode == USB_DR_MODE_HOST) {
> --
> 1.7.10.4
>
> --
Acked-by: Peter Chen
Peter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
>
> * init the sts flag to 0 (missed)
> * set the sts flag only if not 0
>
does PORTSC_STS bit as 1 or 0 affect your case?
If not, please remove hw_write(ci, OP_DEVLC, DEVLC_STS, sts),
since it is useless at current code logic.
Peter
> Signed-off-by: Chris Ruehl
> ---
> drivers/usb/chipide
>
> Signed-off-by: Chris Ruehl
> ---
> drivers/usb/chipidea/core.c |3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c
> index 5d8981c..5075407 100644
> --- a/drivers/usb/chipidea/core.c
> +++ b/drivers/usb/c
vice *ci_pdev = platform_get_drvdata(pdev);
> +
> + ci_hdrc_remove_device(ci_pdev);
> +
> + return 0;
> +}
> +
> +static const struct of_device_id ci_hdrc_nspire_dt_ids[] = {
> + { .compatible = "zevio,nspire-usb", },
> + { /* sentinel */ }
> +};
> +
is for review purpose.
> +};
> +
> +MODULE_DEVICE_TABLE(of, ci_hdrc_nspire_dt_ids);
> +module_platform_driver(ci_hdrc_nspire_driver);
> +
> +MODULE_ALIAS("platform:nspire_usb");
> +MODULE_ALIAS("platform:ci_hdrc_nspire");
Just curious, why you need to two a
>
> From: Daniel Tang
>
> The USB controller in TI-NSPIRE calculators are based
> off either Freescale's USB OTG controller or the USB
> controller found in the IMX233, both of which are
> Chipidea compatible.
>
> This patch adds a device tree binding for the controller.
>
> Signed-off-by:
er (still some cleanups pending) will provide again
> USB2.0 gadget support for MSM targets.
>
We haven't seen msm chipidea patch for a long time, good news they appear.
Any plans to use the whole chipidea function for msm controller driver
(otg, host and peripheral)?
--
Best Regard
val |= ULPI_FUNC_CTRL_OPMODE_NONDRIVING;
> - usb_phy_io_write(ci->transceiver, val, ULPI_FUNC_CTRL);
> + usb_phy_notify_disconnect(ci->transceiver, USB_SPEED_UNKNOWN);
Where you have implemented .notify_disconnect?
I have not found it at your phy driver.
;
> ret = usb_add_phy_dev(&mxs_phy->phy);
> if (ret)
> --
It is so unlucky the struct usb_phy phy is the first element
of struct mxs_phy, so we haven't run any problems.
Jisheng, thanks for fixing it.
Acked-by: Peter Chen
--
To unsubscribe from t
The commit: "pinctrl: imx: Use struct type for pins" relaced
pin->input_reg by pin->input_val wrongly, fix it at this commit.
Signed-off-by: Peter Chen
---
drivers/pinctrl/pinctrl-imx.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/pinctrl
Some platforms may not define CONFIG_MFD_SYSCON (or haven't syscon),
it can fix build error for these platforms.
Signed-off-by: Peter Chen
---
Changes for v2:
- Using #ifdef instead of IS_ENABLED
- Using ENOSYS instead of ENXIO as return val
include/linux/mfd/syscon.h |
Some platforms may not define CONFIG_MFD_SYSCON (or haven't syscon),
it can fix build error for those platforms.
Signed-off-by: Peter Chen
---
include/linux/mfd/syscon.h | 24
1 files changed, 24 insertions(+), 0 deletions(-)
diff --git a/include/linux/mfd/sysco
t bit? Should I use PHY framework, or create some kind of a
> common module that is going to be used by EHCI and OHCI. In addition I
> wanted to ask where I should normally put a common code like [4].
For your situation, you may need to create a controller driver, and call
ehci, ohci, and
On Fri, Sep 13, 2013 at 10:00:33AM +0930, Rusty Russell wrote:
> Peter Chen writes:
> > Currently, if module's refcount is not zero during the unload,
> > it waits there until the user decreases that refcount.
>
> Hi Peter,
>
> In practice userspace uses
st wrongly, it will stop there
until there is another user process to unload B, and this
process can't be killed.
One use case is: the QA engineers do error test, they unload
module wrongly on purpose, after that, they find the console
is stopped there, and they can't do any thing go on.
S
> controller based on ChipIdea silicon IP. Currently, only the
I can't understand why the DMA can't be changed to fix this instead
of changing every driver?
--
Best Regards,
Peter Chen
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel&qu
On Wed, Jul 31, 2013 at 10:15:12AM -0400, Tejun Heo wrote:
> hello,
>
> On Wed, Jul 31, 2013 at 09:55:26PM +0800, Peter Chen wrote:
> > I think the main point is we should allocate managed resource which is used
> > at interrupt handler before devm_request_irq, and all
ler, but using managed interrupt
handler, things still will go wrong if there is an odd (unexpected)
interrupt after
we finish deactivation at removal.
--
BR,
Peter Chen
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger
on?
>
> I thought we already export events for gadget device states, have you
> looked for them? I can't dig through the code at the moment, but this
> seems like a pretty common issue...
>
If I understand correctly, what Rong wants is udev can be notified the
udc state cha
fined!
>
>
>
> Full randconfig file is attached.
>
>
Should be fixed with below fix, the problem is the same with host.
http://marc.info/?l=linux-usb&m=137331577204167&w=2
--
BR,
Peter Chen
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel&
d of USB_PHY support...?
>
> hmm, looks like a missing stub to me. Alex ?
>
> --
> balbi
Seems i386 chooses CONFIG_OF, but not CONFIG_USB_PHY.
I will send a patch to fix it.
--
BR,
Peter Chen
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
On Wed, Mar 06, 2013 at 11:33:02AM +0100, Maxime Ripard wrote:
> Hi,
>
> Just noticed this in 3.9-rc1 on an iMX28 (ARM) board with a config
> based on mxs_defconfig. I'm using the patchset "Add tested id switch
> and vbus connect detect support for Chipidea" from Pe
1f 100644
> --- a/drivers/usb/chipidea/core.c
> +++ b/drivers/usb/chipidea/core.c
> @@ -411,7 +411,7 @@ static int ci_hdrc_probe(struct platform_device *pdev)
> }
>
> base = devm_request_and_ioremap(dev, res);
> - if (!res) {
> + if (!base) {
>
n
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
Best Regards,
Peter Chen
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
>
> #include
> +#include
>
one small thing: is only needed at phy.h.
> /* OTG defines lots of enumeration states before device reset */
> enum usb_otg_state {
> @@ -35,31 +36,6 @@ enum usb_otg_state {
> OTG_STATE_A_VBUS_ERR,
> };
>
> -enum usb_phy_events {
> - USB_EVENT_NONE,
1201 - 1229 of 1229 matches
Mail list logo
