Re: [PATCH v4 4/6] tpm: modify tpm_pcr_read() definition to pass a TPM hash algorithm

Am 8. November 2018 16:15:04 MEZ schrieb Jarkko Sakkinen : >On Thu, Nov 08, 2018 at 03:16:03PM +0100, Roberto Sassu wrote: >> On 11/8/2018 3:04 PM, Jarkko Sakkinen wrote: >> > On Tue, Nov 06, 2018 at 04:01:57PM +0100, Roberto Sassu wrote: >> > > Currently the TPM driver allows other kernel

Re: [PATCH v4 4/6] tpm: modify tpm_pcr_read() definition to pass a TPM hash algorithm

Am 8. November 2018 16:15:04 MEZ schrieb Jarkko Sakkinen : >On Thu, Nov 08, 2018 at 03:16:03PM +0100, Roberto Sassu wrote: >> On 11/8/2018 3:04 PM, Jarkko Sakkinen wrote: >> > On Tue, Nov 06, 2018 at 04:01:57PM +0100, Roberto Sassu wrote: >> > > Currently the TPM driver allows other kernel

[PATCH] tpm: Make SECURITYFS a weak dependency

, as there is no eventlog present. By turning it from 'select' to 'imply' it still gets selected per default, but enables users who want to save some kb of ram by turning SECURITYFS off. Signed-off-by: Peter Huewe --- drivers/char/tpm/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] tpm: Make SECURITYFS a weak dependency

, as there is no eventlog present. By turning it from 'select' to 'imply' it still gets selected per default, but enables users who want to save some kb of ram by turning SECURITYFS off. Signed-off-by: Peter Huewe --- drivers/char/tpm/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH] MAINTAINERS: update TPM driver infrastructure changes

Hi, Am Freitag, 29. September 2017 22:23:13 CEST schrieb Jarkko Sakkinen: On Fri, Sep 29, 2017 at 08:29:09AM +, peter.hu...@infineon.com wrote: ... Spinics is archiving us at https://www.spinics.net/lists/linux-integrity/ It would be good to add this to the vger page + documented on the

Re: [PATCH] MAINTAINERS: update TPM driver infrastructure changes

Hi, Am Freitag, 29. September 2017 22:23:13 CEST schrieb Jarkko Sakkinen: On Fri, Sep 29, 2017 at 08:29:09AM +, peter.hu...@infineon.com wrote: ... Spinics is archiving us at https://www.spinics.net/lists/linux-integrity/ It would be good to add this to the vger page + documented on the

Re: Fixing CVE-2017-15361

Am 25. Oktober 2017 20:53:49 MESZ schrieb Jarkko Sakkinen : >On Wed, Oct 25, 2017 at 07:17:17AM -0700, Matthew Garrett wrote: >> On Wed, Oct 25, 2017 at 6:44 AM, Jarkko Sakkinen >> wrote: >> > I'm implementing a fix for

Re: Fixing CVE-2017-15361

Am 25. Oktober 2017 20:53:49 MESZ schrieb Jarkko Sakkinen : >On Wed, Oct 25, 2017 at 07:17:17AM -0700, Matthew Garrett wrote: >> On Wed, Oct 25, 2017 at 6:44 AM, Jarkko Sakkinen >> wrote: >> > I'm implementing a fix for CVE-2017-15361 that simply blacklists >> > vulnerable FW versions. I think

Re: [tpmdd-devel] [PATCH] tpm: remove chip_num parameter from in-kernel API

Am 24. Oktober 2017 20:15:12 MESZ schrieb Jarkko Sakkinen : >On Tue, Oct 24, 2017 at 10:02:00AM -0700, Dmitry Torokhov wrote: >> On Tue, Oct 24, 2017 at 9:11 AM, Jason Gunthorpe >> wrote: >> > On Tue, Oct 24, 2017 at 09:37:33PM

Re: [tpmdd-devel] [PATCH] tpm: remove chip_num parameter from in-kernel API

Am 24. Oktober 2017 20:15:12 MESZ schrieb Jarkko Sakkinen : >On Tue, Oct 24, 2017 at 10:02:00AM -0700, Dmitry Torokhov wrote: >> On Tue, Oct 24, 2017 at 9:11 AM, Jason Gunthorpe >> wrote: >> > On Tue, Oct 24, 2017 at 09:37:33PM +0530, PrasannaKumar >Muralidharan wrote: >> >> Hi Jason, >> >> >>

Re: Re: [PATCH] MAINTAINERS: update TPM driver infrastructure changes

Will do. Peter Am 4. Oktober 2017 09:27:08 MESZ schrieb Jarkko Sakkinen <jarkko.sakki...@linux.intel.com>: >On Fri, Sep 29, 2017 at 08:31:30PM +0200, Peter Huewe wrote: >> >>   >>   >> >> Gesendet: Freitag, 29. September 2017 um 18:59 Uhr

Re: Re: [PATCH] MAINTAINERS: update TPM driver infrastructure changes

Will do. Peter Am 4. Oktober 2017 09:27:08 MESZ schrieb Jarkko Sakkinen : >On Fri, Sep 29, 2017 at 08:31:30PM +0200, Peter Huewe wrote: >> >>   >>   >> >> Gesendet: Freitag, 29. September 2017 um 18:59 Uhr >> Von: "Jarkko Sakkinen" >> A

Aw: Re: [PATCH] MAINTAINERS: update TPM driver infrastructure changes

    Gesendet: Freitag, 29. September 2017 um 18:59 Uhr Von: "Jarkko Sakkinen" An: "Mimi Zohar" , peterhu...@gmx.de Cc: linux-kernel@vger.kernel.org, linux-integr...@vger.kernel.org Betreff: Re: [PATCH] MAINTAINERS: update TPM driver

Aw: Re: [PATCH] MAINTAINERS: update TPM driver infrastructure changes

    Gesendet: Freitag, 29. September 2017 um 18:59 Uhr Von: "Jarkko Sakkinen" An: "Mimi Zohar" , peterhu...@gmx.de Cc: linux-kernel@vger.kernel.org, linux-integr...@vger.kernel.org Betreff: Re: [PATCH] MAINTAINERS: update TPM driver infrastructure changes On Tue, Sep 26, 2017 at 12:16:20PM

Re: [tpmdd-devel] New ML for TPM and IMA

Am 15. September 2017 13:07:58 GMT-07:00 schrieb Ken Goldman : >Newbie question: Do I have to subscribe, or are email addresses being >migrated You have to subscribe yourself. Due to the new privacy regulations I do not have access to any member information anymore

Re: [tpmdd-devel] New ML for TPM and IMA

Am 15. September 2017 13:07:58 GMT-07:00 schrieb Ken Goldman : >Newbie question: Do I have to subscribe, or are email addresses being >migrated You have to subscribe yourself. Due to the new privacy regulations I do not have access to any member information anymore on the old list. Just

Re: [tpmdd-devel] New ML for TPM and IMA

Am 15. September 2017 10:40:14 GMT-07:00 schrieb Joe Perches : >On Fri, 2017-09-15 at 10:36 -0700, Jarkko Sakkinen wrote: >> On Fri, Sep 15, 2017 at 10:25:36AM -0700, Joe Perches wrote: >> > On Fri, 2017-09-15 at 10:18 -0700, Jarkko Sakkinen wrote: >[] >> > > We decided to

Re: [tpmdd-devel] New ML for TPM and IMA

Am 15. September 2017 10:40:14 GMT-07:00 schrieb Joe Perches : >On Fri, 2017-09-15 at 10:36 -0700, Jarkko Sakkinen wrote: >> On Fri, Sep 15, 2017 at 10:25:36AM -0700, Joe Perches wrote: >> > On Fri, 2017-09-15 at 10:18 -0700, Jarkko Sakkinen wrote: >[] >> > > We decided to create a new mailing

Re: [tpmdd-devel] New ML for TPM and IMA

Am 15. September 2017 10:18:25 GMT-07:00 schrieb Jarkko Sakkinen : >Hi > >Many people were kicked out from the SourceForge mailing list in the >July because SF required a resubscription, including non-human users, >such as patchwork. > >We decided to create a

Re: [tpmdd-devel] New ML for TPM and IMA

Am 15. September 2017 10:18:25 GMT-07:00 schrieb Jarkko Sakkinen : >Hi > >Many people were kicked out from the SourceForge mailing list in the >July because SF required a resubscription, including non-human users, >such as patchwork. > >We decided to create a new mailing list

Re: [tpmdd-devel] [PATCH v2 1/4] tpm: ignore burstcount to improve tpm_tis send() performance.

Am 13. September 2017 11:52:12 GMT-07:00 schrieb Ken Goldman : >On 9/6/2017 12:12 PM, Jason Gunthorpe wrote: >> >> The problem with this approach is that the TPM could totally block >> the CPU for very long periods of time. >> >> It seems very risky to enable.. >> >

Re: [tpmdd-devel] [PATCH v2 1/4] tpm: ignore burstcount to improve tpm_tis send() performance.

Am 13. September 2017 11:52:12 GMT-07:00 schrieb Ken Goldman : >On 9/6/2017 12:12 PM, Jason Gunthorpe wrote: >> >> The problem with this approach is that the TPM could totally block >> the CPU for very long periods of time. >> >> It seems very risky to enable.. >> > >How would you

Re: [PATCH v2 1/4] tpm: ignore burstcount to improve tpm_tis send() performance.

Am 12. September 2017 17:45:08 GMT-07:00 schrieb Jarkko Sakkinen : >On Wed, Sep 06, 2017 at 08:56:36AM -0400, Nayna Jain wrote: >> The TPM burstcount status indicates the number of bytes that can >> be sent to the TPM without causing bus wait states.

Re: [PATCH v2 1/4] tpm: ignore burstcount to improve tpm_tis send() performance.

Am 12. September 2017 17:45:08 GMT-07:00 schrieb Jarkko Sakkinen : >On Wed, Sep 06, 2017 at 08:56:36AM -0400, Nayna Jain wrote: >> The TPM burstcount status indicates the number of bytes that can >> be sent to the TPM without causing bus wait states. Effectively, >> it is the number of empty

Aw: Re: [tpmdd-devel] [PATCH] tpm: improve tpm_tis send() performance by ignoring burstcount

Hi Ken, (again speaking only on my behalf, not my employer) > Does anyone know of platforms where this occurs? > I suspect (but not sure) that the days of SuperIO connecting floppy > drives, printer ports, and PS/2 mouse ports on the LPC bus are over, and > such legacy systems will not have a

Aw: Re: [tpmdd-devel] [PATCH] tpm: improve tpm_tis send() performance by ignoring burstcount

Hi Ken, (again speaking only on my behalf, not my employer) > Does anyone know of platforms where this occurs? > I suspect (but not sure) that the days of SuperIO connecting floppy > drives, printer ports, and PS/2 mouse ports on the LPC bus are over, and > such legacy systems will not have a

Aw: Re: [tpmdd-devel] [PATCH] tpm: improve tpm_tis send() performance by ignoring burstcount

Hi Ken, (speaking on behalf of myself here, not my employer :) ) > On Mon, Aug 07, 2017 at 01:52:34PM +0200, Peter Huewe wrote: >> Imho: NACK from my side. > After these viewpoints definitive NACK from my side too... > I responded to the thread comments separately. However

Aw: Re: [tpmdd-devel] [PATCH] tpm: improve tpm_tis send() performance by ignoring burstcount

Hi Ken, (speaking on behalf of myself here, not my employer :) ) > On Mon, Aug 07, 2017 at 01:52:34PM +0200, Peter Huewe wrote: >> Imho: NACK from my side. > After these viewpoints definitive NACK from my side too... > I responded to the thread comments separately. However

Re: [PATCH] tpm: improve tpm_tis send() performance by ignoring burstcount

Am 7. August 2017 13:46:32 MESZ schrieb Nayna Jain : >The TPM burstcount status indicates the number of bytes that can >be sent to the TPM without causing bus wait states. Effectively, >it is the number of empty bytes in the command FIFO. Further, >some TPMs have a

Re: [PATCH] tpm: improve tpm_tis send() performance by ignoring burstcount

Am 7. August 2017 13:46:32 MESZ schrieb Nayna Jain : >The TPM burstcount status indicates the number of bytes that can >be sent to the TPM without causing bus wait states. Effectively, >it is the number of empty bytes in the command FIFO. Further, >some TPMs have a static burstcount, when the

[PATCH] tpm, tpmrm: Mark tpmrm_write as static

sparse complains that tpmrm_write can be made static, and since it is right we make it static. Signed-off-by: Peter Huewe <peterhu...@gmx.de> --- drivers/char/tpm/tpmrm-dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/char/tpm/tpmrm-dev.c b/drivers/char/tpm

[PATCH] tpm, tpmrm: Mark tpmrm_write as static

sparse complains that tpmrm_write can be made static, and since it is right we make it static. Signed-off-by: Peter Huewe --- drivers/char/tpm/tpmrm-dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/char/tpm/tpmrm-dev.c b/drivers/char/tpm/tpmrm-dev.c index

Aw: Re: [PATCH] tpm: remove struct tpm_pcrextend_in

> Removed struct tpm_pcrextend_in as it is not used for anything anymore. > > Signed-off-by: Jarkko Sakkinen <jarkko.sakki...@linux.intel.com> LGTM. Reviewed-by: Peter Huewe <peterhu...@gmx.de> > --- > drivers/char/tpm/tpm.h | 6 -- > 1 file changed, 6 deletio

Aw: Re: [PATCH] tpm: remove struct tpm_pcrextend_in

> Removed struct tpm_pcrextend_in as it is not used for anything anymore. > > Signed-off-by: Jarkko Sakkinen LGTM. Reviewed-by: Peter Huewe > --- > drivers/char/tpm/tpm.h | 6 -- > 1 file changed, 6 deletions(-) > > diff --git a/drivers/char/tpm/tpm.h b/driver

Aw: Re: [PATCH] tpm, tpm_infineon: remove useless snprintf() calls

> The memory copy from rodata to stack is useless. > > Signed-off-by: Jarkko Sakkinen <jarkko.sakki...@linux.intel.com> After review, yes that should work. Reviewed-by: Peter Huewe <peterhu...@gmx.de> > --- > drivers/char/tpm/tpm_infineon.c | 8 > 1 fi

Aw: Re: [PATCH] tpm, tpm_infineon: remove useless snprintf() calls

> The memory copy from rodata to stack is useless. > > Signed-off-by: Jarkko Sakkinen After review, yes that should work. Reviewed-by: Peter Huewe > --- > drivers/char/tpm/tpm_infineon.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff

Re: [1/5] w83627ehf: Use hwmon_device_register_with_info and sensor groups

Am 17. Mai 2017 21:35:52 MESZ schrieb Alexander Sverdlin <alexander.sverd...@gmail.com>: >Hello Peter! > >On 23/03/17 14:03, Peter Huewe wrote: >> This patch replaces the old, deprecated call to hwmon_device_register >> with the new hwmon_device_register_with_

Re: [1/5] w83627ehf: Use hwmon_device_register_with_info and sensor groups

Am 17. Mai 2017 21:35:52 MESZ schrieb Alexander Sverdlin : >Hello Peter! > >On 23/03/17 14:03, Peter Huewe wrote: >> This patch replaces the old, deprecated call to hwmon_device_register >> with the new hwmon_device_register_with_info and converts the whole >> driver

Re: [PATCH v3] tpm: Apply a sane minimum adapterlimit value for retransmission.

all back to a sane minimum >> when the maximum fails. >> >> Changes since v2: >> - Do not remove faster transfers when chip is SLB9645 (Peter Huewe) >> - Remember the adapterlimit length once it fails to not generate >extra >>i2c core me

Re: [PATCH v3] tpm: Apply a sane minimum adapterlimit value for retransmission.

ed-off-by: Enric Balletbo i Serra >> --- >> This is a reworked version of the original patch based on the >> suggestion made by Wolfram Sang to simply fall back to a sane minimum >> when the maximum fails. >> >> Changes since v2: >> - Do not remove

Re: [PATCH 1/5] w83627ehf: Use hwmon_device_register_with_info and sensor groups

Am 23. März 2017 19:43:39 MEZ schrieb Guenter Roeck <li...@roeck-us.net>: >On Thu, Mar 23, 2017 at 02:03:04PM +0100, Peter Huewe wrote: >> This patch replaces the old, deprecated call to hwmon_device_register >> with the new hwmon_device_register_with_info and convert

Re: [PATCH 1/5] w83627ehf: Use hwmon_device_register_with_info and sensor groups

Am 23. März 2017 19:43:39 MEZ schrieb Guenter Roeck : >On Thu, Mar 23, 2017 at 02:03:04PM +0100, Peter Huewe wrote: >> This patch replaces the old, deprecated call to hwmon_device_register >> with the new hwmon_device_register_with_info and converts the whole >> dr

[PATCH 4/5] w83627ehf: Drop FSFE template and replace with SPDX License information

As indicated by checkpatch it makes sense to not use the FSFE Template about GPLv2+ Signed-off-by: Peter Huewe <peterhu...@gmx.de> --- drivers/hwmon/w83627ehf.c | 15 ++- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/drivers/hwmon/w83627ehf.c b/drivers

[PATCH 4/5] w83627ehf: Drop FSFE template and replace with SPDX License information

As indicated by checkpatch it makes sense to not use the FSFE Template about GPLv2+ Signed-off-by: Peter Huewe --- drivers/hwmon/w83627ehf.c | 15 ++- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/drivers/hwmon/w83627ehf.c b/drivers/hwmon/w83627ehf.c index

[PATCH 2/5] w83627ehf: Use octal values for access rights of sysfs files

As indicated by checkpatch, use the octal representation for the access rights. S_IWUSR | S_IRUGO => 0644 S_IRUGO => 0444 Signed-off-by: Peter Huewe <peterhu...@gmx.de> --- drivers/hwmon/w83627ehf.c | 52 --- 1 file changed, 22 inser

[PATCH 2/5] w83627ehf: Use octal values for access rights of sysfs files

As indicated by checkpatch, use the octal representation for the access rights. S_IWUSR | S_IRUGO => 0644 S_IRUGO => 0444 Signed-off-by: Peter Huewe --- drivers/hwmon/w83627ehf.c | 52 --- 1 file changed, 22 insertions(+), 30 deletions(-) diff

[PATCH 5/5] w83627ehf: Drop support for nct6775/nct6776

nymore) - NUM_REG_TEMP changed to ARRAY_SIZE(W83627EHF_REG_TEMP) (different number of max temp sensors) - removal of intrusion1_alarm (nct6776 specific) v2: Updated Kconfig, Documentation and removed unused temp_sensors (5-9) Tested on NCT6776F (not probed anymore) Signed-off-by: Peter Huewe <peterhu.

[PATCH 5/5] w83627ehf: Drop support for nct6775/nct6776

nymore) - NUM_REG_TEMP changed to ARRAY_SIZE(W83627EHF_REG_TEMP) (different number of max temp sensors) - removal of intrusion1_alarm (nct6776 specific) v2: Updated Kconfig, Documentation and removed unused temp_sensors (5-9) Tested on NCT6776F (not probed anymore) Signed-off-by: Peter Huewe --- Documen

[PATCH 3/5] w83627ehf: Minor readability fixes

just some cosmetics for better readability, proposed by Lindent/checkpatch Signed-off-by: Peter Huewe <peterhu...@gmx.de> --- drivers/hwmon/w83627ehf.c | 39 +++ 1 file changed, 15 insertions(+), 24 deletions(-) diff --git a/drivers/hwmon/w83627e

[PATCH 3/5] w83627ehf: Minor readability fixes

just some cosmetics for better readability, proposed by Lindent/checkpatch Signed-off-by: Peter Huewe --- drivers/hwmon/w83627ehf.c | 39 +++ 1 file changed, 15 insertions(+), 24 deletions(-) diff --git a/drivers/hwmon/w83627ehf.c b/drivers/hwmon/w83627ehf.c

[PATCH 1/5] w83627ehf: Use hwmon_device_register_with_info and sensor groups

6776F chip. v2: - converted to proper is_visible methods - applied minor feedback of v1 Signed-off-by: Peter Huewe <peterhu...@gmx.de> --- drivers/hwmon/w83627ehf.c | 1536 +++-- 1 file changed, 778 insertions(+), 758 deletions(-) diff --git a/drivers/h

[PATCH 1/5] w83627ehf: Use hwmon_device_register_with_info and sensor groups

6776F chip. v2: - converted to proper is_visible methods - applied minor feedback of v1 Signed-off-by: Peter Huewe --- drivers/hwmon/w83627ehf.c | 1536 +++-- 1 file changed, 778 insertions(+), 758 deletions(-) diff --git a/drivers/hwmon/w83627ehf.c b/dri

[PATCH] w83627ehf: Drop support for nct6775/nct6776

nymore) - NUM_REG_TEMP changed to ARRAY_SIZE(W83627EHF_REG_TEMP) (different number of max temp sensors) - removal of intrusion1_alarm (nct6776 specific) Tested with NCT6776F that it does not get probed anymore. Signed-off-by: Peter Huewe <peterhu...@gmx.de> --- Please apply after my conversion

[PATCH] w83627ehf: Drop support for nct6775/nct6776

nymore) - NUM_REG_TEMP changed to ARRAY_SIZE(W83627EHF_REG_TEMP) (different number of max temp sensors) - removal of intrusion1_alarm (nct6776 specific) Tested with NCT6776F that it does not get probed anymore. Signed-off-by: Peter Huewe --- Please apply after my conversion patch series. drivers

[PATCH 1/4] w83627ehf: Use hwmon_device_register_with_info and sensor groups

quot; than it used to be, but still not completely. The conversion saves about 20k in the resulting .ko Tested with a NCT6776F chip. Signed-off-by: Peter Huewe <peterhu...@gmx.de> --- Target-Branch: groeck/hwmon Please cherry-pick 46dc4a97 hwmon: Constify str parameter of hwmon_ops->

[PATCH 1/4] w83627ehf: Use hwmon_device_register_with_info and sensor groups

quot; than it used to be, but still not completely. The conversion saves about 20k in the resulting .ko Tested with a NCT6776F chip. Signed-off-by: Peter Huewe --- Target-Branch: groeck/hwmon Please cherry-pick 46dc4a97 hwmon: Constify str parameter of hwmon_ops->read_string before this

[PATCH 2/4] w83627ehf: Use octal values for access rights of sysfs files

As indicated by checkpatch, use the octal representation for the access rights. S_IWUSR | S_IRUGO => 0644 S_IRUGO => 0444 Signed-off-by: Peter Huewe <peterhu...@gmx.de> --- drivers/hwmon/w83627ehf.c | 52 --- 1 file changed, 22 inser

[PATCH 2/4] w83627ehf: Use octal values for access rights of sysfs files

As indicated by checkpatch, use the octal representation for the access rights. S_IWUSR | S_IRUGO => 0644 S_IRUGO => 0444 Signed-off-by: Peter Huewe --- drivers/hwmon/w83627ehf.c | 52 --- 1 file changed, 22 insertions(+), 30 deletions(-) diff

[PATCH 3/4] w83627ehf: Minor readability fixes

just some cosmetics for better readability, proposed by Lindent/checkpatch Signed-off-by: Peter Huewe <peterhu...@gmx.de> --- drivers/hwmon/w83627ehf.c | 41 +++-- 1 file changed, 15 insertions(+), 26 deletions(-) diff --git a/drivers/hwmon/w83627e

[PATCH 3/4] w83627ehf: Minor readability fixes

just some cosmetics for better readability, proposed by Lindent/checkpatch Signed-off-by: Peter Huewe --- drivers/hwmon/w83627ehf.c | 41 +++-- 1 file changed, 15 insertions(+), 26 deletions(-) diff --git a/drivers/hwmon/w83627ehf.c b/drivers/hwmon

[PATCH 4/4] w83627ehf: Drop FSFE template and replace with SPDX License information

As indicated by checkpatch it makes sense to not use the FSFE Template about GPLv2+ Signed-off-by: Peter Huewe <peterhu...@gmx.de> --- drivers/hwmon/w83627ehf.c | 15 ++- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/drivers/hwmon/w83627ehf.c b/drivers

[PATCH 4/4] w83627ehf: Drop FSFE template and replace with SPDX License information

As indicated by checkpatch it makes sense to not use the FSFE Template about GPLv2+ Signed-off-by: Peter Huewe --- drivers/hwmon/w83627ehf.c | 15 ++- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/drivers/hwmon/w83627ehf.c b/drivers/hwmon/w83627ehf.c index

[PATCH] hwmon: Add missing HWMON_T_ALARM

Unfortunately the HWMON_T_ALARM define was missing, although the associated entry was present in hwmon_temp_attributes. This is needed to convert drivers to the new interface which use channel based alarms. Signed-off-by: Peter Huewe <peterhu...@gmx.de> --- include/linux/hwmon.h | 1 +

[PATCH] hwmon: Add missing HWMON_T_ALARM

Unfortunately the HWMON_T_ALARM define was missing, although the associated entry was present in hwmon_temp_attributes. This is needed to convert drivers to the new interface which use channel based alarms. Signed-off-by: Peter Huewe --- include/linux/hwmon.h | 1 + 1 file changed, 1 insertion

Re: [tpmdd-devel] [PATCH] tpm: Add sysfs interface to show TPM hardware version

Am 14. März 2017 19:18:15 MEZ schrieb Ken Goldman <kg...@linux.vnet.ibm.com>: >On 3/13/2017 3:10 AM, Peter Huewe wrote: > >> And yes you are right there is currently no way, except for trial and >> error, for the userspace to determine this. So an interface to get >>

Re: [tpmdd-devel] [PATCH] tpm: Add sysfs interface to show TPM hardware version

Am 14. März 2017 19:18:15 MEZ schrieb Ken Goldman : >On 3/13/2017 3:10 AM, Peter Huewe wrote: > >> And yes you are right there is currently no way, except for trial and >> error, for the userspace to determine this. So an interface to get >> this information makes sense

Re: [PATCH] tpm: Add sysfs interface to show TPM hardware version

Hi, Thanks for your patch. Am 13. März 2017 06:21:57 MEZ schrieb meng...@windriver.com: >From: Limeng > >So far, there is not a sysfs interface for user space code to >check the TPM hardware version(TPM1.x or TPM2). So, add a >file named description in /sys/class/tpm/tpmX/

Re: [PATCH] tpm: Add sysfs interface to show TPM hardware version

Hi, Thanks for your patch. Am 13. März 2017 06:21:57 MEZ schrieb meng...@windriver.com: >From: Limeng > >So far, there is not a sysfs interface for user space code to >check the TPM hardware version(TPM1.x or TPM2). So, add a >file named description in /sys/class/tpm/tpmX/ to show it. It's not

Re: Question about hwmon_attr_show_string

that case, what about the following change? > >Subject: hwmon: Constify str parameter of hwmon_ops->read_string > >The read_string callback is supposed to retrieve a pointer to a >constant string. I would think that clarifies the situation and also gets rid warnings about drop

Re: Question about hwmon_attr_show_string

what about the following change? > >Subject: hwmon: Constify str parameter of hwmon_ops->read_string > >The read_string callback is supposed to retrieve a pointer to a >constant string. I would think that clarifies the situation and also gets rid warnings about dropping const qu

[PATCH v2 3/5] tpm_tis_spi: Check correct byte for wait state indicator

<alexander.stef...@infineon.com> Signed-off-by: Peter Huewe <peter.hu...@infineon.com> Reviewed-by: Jarkko Sakkinen <jarkko.sakki...@linux.intel.com> Tested-by: Benoit Houyere <benoit.houy...@st.com> --- drivers/char/tpm/tpm_tis_spi.c | 36 ++

[PATCH v2 3/5] tpm_tis_spi: Check correct byte for wait state indicator

Wait states are signaled in the last byte received from the TPM in response to the header, not the first byte. Check rx_buf[3] instead of rx_buf[0]. Cc: Fixes: 0edbfea537d1 ("tpm/tpm_tis_spi: Add support for spi phy") Signed-off-by: Alexander Steffen Signed-off-by: Peter Huewe

[PATCH v2 1/5] tpm_tis_spi: Use single function to transfer data

for the length. Cc: <sta...@vger.kernel.org> Fixes: 0edbfea537d1 ("tpm/tpm_tis_spi: Add support for spi phy") Signed-off-by: Alexander Steffen <alexander.stef...@infineon.com> Signed-off-by: Peter Huewe <peter.hu...@infineon.com> Reviewed-by: Jarkko Sakkinen <jarkko.s

[PATCH v2 1/5] tpm_tis_spi: Use single function to transfer data

for the length. Cc: Fixes: 0edbfea537d1 ("tpm/tpm_tis_spi: Add support for spi phy") Signed-off-by: Alexander Steffen Signed-off-by: Peter Huewe Reviewed-by: Jarkko Sakkinen Tested-by: Benoit Houyere --- drivers/char/tpm/tpm_tis_spi.c | 87

Re: [tpmdd-devel] [PATCH v2] tpm: Apply a sane minimum adapterlimit value for retransmission.

Am 2. März 2017 13:55:43 MEZ schrieb Jarkko Sakkinen : >On Wed, Mar 01, 2017 at 04:36:17PM +0100, Enric Balletbo i Serra wrote: >> From: Bryan Freed >> >> When the I2C Infineon part is attached to an I2C adapter that imposes >> a size

Re: [tpmdd-devel] [PATCH v2] tpm: Apply a sane minimum adapterlimit value for retransmission.

Am 2. März 2017 13:55:43 MEZ schrieb Jarkko Sakkinen : >On Wed, Mar 01, 2017 at 04:36:17PM +0100, Enric Balletbo i Serra wrote: >> From: Bryan Freed >> >> When the I2C Infineon part is attached to an I2C adapter that imposes >> a size limitation, large requests will fail with -EOPNOTSUPP.

[PATCH v2 4/5] tpm_tis_spi: Remove limitation of transfers to MAX_SPI_FRAMESIZE bytes

Add support for spi phy") Signed-off-by: Alexander Steffen <alexander.stef...@infineon.com> Signed-off-by: Peter Huewe <peter.hu...@infineon.com> Reviewed-by: Jarkko Sakkinen <jarkko.sakki...@linux.intel.com> Tested-by: Benoit Houyere <benoit.houy...@st.com> -

[PATCH v2 4/5] tpm_tis_spi: Remove limitation of transfers to MAX_SPI_FRAMESIZE bytes

Signed-off-by: Alexander Steffen Signed-off-by: Peter Huewe Reviewed-by: Jarkko Sakkinen Tested-by: Benoit Houyere --- drivers/char/tpm/tpm_tis_spi.c | 107 ++--- 1 file changed, 58 insertions(+), 49 deletions(-) diff --git a/drivers/char/tpm/tpm_tis_spi.c b/dr

[PATCH v2 2/5] tpm_tis_spi: Abort transfer when too many wait states are signaled

hy") Signed-off-by: Alexander Steffen <alexander.stef...@infineon.com> Signed-off-by: Peter Huewe <peter.hu...@infineon.com> Reviewed-by: Jarkko Sakkinen <jarkko.sakki...@linux.intel.com> Tested-by: Benoit Houyere <benoit.houy...@st.com> --- drivers/char/tpm/tp

[PATCH v2 2/5] tpm_tis_spi: Abort transfer when too many wait states are signaled

Alexander Steffen Signed-off-by: Peter Huewe Reviewed-by: Jarkko Sakkinen Tested-by: Benoit Houyere --- drivers/char/tpm/tpm_tis_spi.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/char/tpm/tpm_tis_spi.c b/drivers/char/tpm/tpm_tis_spi.c index 062799e04f04..639614f2d415 100644 ---

Re: [tpmdd-devel] [PATCH 1/2] tpm: Apply an adapterlimit for retransmission.

Am 27. Februar 2017 20:12:45 MEZ schrieb Wolfram Sang : >Hi, > >> >> > Rather than trying small and smaller transfers, would it not be >better >> >> > to get the i2c core to expose the quirk info about transfer >limits? >> >> > >> >> >> >> Sounds a good idea to me, I guess

Re: [tpmdd-devel] [PATCH 1/2] tpm: Apply an adapterlimit for retransmission.

Am 27. Februar 2017 20:12:45 MEZ schrieb Wolfram Sang : >Hi, > >> >> > Rather than trying small and smaller transfers, would it not be >better >> >> > to get the i2c core to expose the quirk info about transfer >limits? >> >> > >> >> >> >> Sounds a good idea to me, I guess the quirk info can be

[PATCH v2 5/5] tpm_tis_spi: Add small delay after last transfer

for a negligible performance penalty. Cc: <sta...@vger.kernel.org> Fixes: 0edbfea537d1 ("tpm/tpm_tis_spi: Add support for spi phy") Signed-off-by: Alexander Steffen <alexander.stef...@infineon.com> Signed-off-by: Peter Huewe <peter.hu...@infineon.com> Reviewed-by: J

[PATCH v2 5/5] tpm_tis_spi: Add small delay after last transfer

for a negligible performance penalty. Cc: Fixes: 0edbfea537d1 ("tpm/tpm_tis_spi: Add support for spi phy") Signed-off-by: Alexander Steffen Signed-off-by: Peter Huewe Reviewed-by: Jarkko Sakkinen Tested-by: Benoit Houyere --- drivers/char/tpm/tpm_tis_spi.c | 1 + 1 file changed, 1 insertio

Re: [PATCH] tpm: do not suspend/resume if power stays on

Am 1. März 2017 12:51:16 MEZ schrieb Enric Balletbo i Serra : >From: Sonny Rao > >The suspend/resume behavior of the TPM can be controlled >by setting "powered-while-suspended" in the DTS. > >Signed-off-by: Sonny Rao

Re: [PATCH] tpm: do not suspend/resume if power stays on

Am 1. März 2017 12:51:16 MEZ schrieb Enric Balletbo i Serra : >From: Sonny Rao > >The suspend/resume behavior of the TPM can be controlled >by setting "powered-while-suspended" in the DTS. > >Signed-off-by: Sonny Rao >Signed-off-by: Enric Balletbo i Serra >---

Re: [PATCH] tpm: select CONFIG_CRYPTO

(CRYPTO) > >This adds another select to avoid the warning, consistent with other >users >of the crypto code. > >Fixes: c1f92b4b04ad ("tpm: enhance TPM 2.0 PCR extend to support >multiple banks") >Signed-off-by: Arnd Bergmann <a...@arndb.de> Lgtm Reviewed-by: P

Re: [PATCH] tpm: select CONFIG_CRYPTO

>This adds another select to avoid the warning, consistent with other >users >of the crypto code. > >Fixes: c1f92b4b04ad ("tpm: enhance TPM 2.0 PCR extend to support >multiple banks") >Signed-off-by: Arnd Bergmann Lgtm Reviewed-by: Peter Huewe >--- > drivers/char/tpm

Re: [PATCH 0/5] Fix whole native SPI TPM driver

Am 22. Februar 2017 22:19:24 MEZ schrieb Jarkko Sakkinen <jarkko.sakki...@linux.intel.com>: >On Thu, Feb 16, 2017 at 04:08:21PM +0000, Peter Huewe wrote: >> During our testing it showed that unfortunately the whole native spi >tpm driver >> was more or less non-functi

Re: [PATCH 0/5] Fix whole native SPI TPM driver

Am 22. Februar 2017 22:19:24 MEZ schrieb Jarkko Sakkinen : >On Thu, Feb 16, 2017 at 04:08:21PM +0000, Peter Huewe wrote: >> During our testing it showed that unfortunately the whole native spi >tpm driver >> was more or less non-functional since it was merged, e.

Re: [tpmdd-devel] [PATCH 1/2] tpm: Apply an adapterlimit for retransmission.

Am 21. Februar 2017 17:29:48 MEZ schrieb Andrew Lunn : >On Tue, Feb 21, 2017 at 03:44:59PM +0100, Enric Balletbo i Serra wrote: >> From: Bryan Freed >> >> When the I2C Infineon part is attached to an I2C adapter that imposes >> a size limitation, large

Re: [tpmdd-devel] [PATCH 1/2] tpm: Apply an adapterlimit for retransmission.

Am 21. Februar 2017 17:29:48 MEZ schrieb Andrew Lunn : >On Tue, Feb 21, 2017 at 03:44:59PM +0100, Enric Balletbo i Serra wrote: >> From: Bryan Freed >> >> When the I2C Infineon part is attached to an I2C adapter that imposes >> a size limitation, large requests will fail -EINVAL. >> Retry them

Re: [PATCH 5/5] tpm_tis_spi: Add small delay after last transfer

nd then file a bug/fix it. For now however the priority is to make the tpm_tis_spi driver work reliably also on the rpi, and this is what this workaround does. We can simply remove it once the rpi spi master is fixed. Peter > > >On 16/02/2017 08:09, Peter Huewe wrote: >> Testing th

Re: [PATCH 5/5] tpm_tis_spi: Add small delay after last transfer

now however the priority is to make the tpm_tis_spi driver work reliably also on the rpi, and this is what this workaround does. We can simply remove it once the rpi spi master is fixed. Peter > > >On 16/02/2017 08:09, Peter Huewe wrote: >> Testing the implementation with a Raspberry P

Re: [PATCH 4/5] tpm_tis_spi: Remove limitation of transfers to MAX_SPI_FRAMESIZE bytes

behind me now :-) > > >On 16/02/2017 08:08, Peter Huewe wrote: >> Limiting transfers to MAX_SPI_FRAMESIZE was not expected by the upper >> layers, as tpm_tis has no such limitation. Add a loop to hide that >> limitation. >> >> Cc: <sta...@vger.kernel.org>

Re: [PATCH 4/5] tpm_tis_spi: Remove limitation of transfers to MAX_SPI_FRAMESIZE bytes

nce the splitting loop went missing during the merge. At least with our tpms that's the case. (I think we are signalling a higher burstcount value than 64, which is allowed) >Or is this because of TIS vs PTP differences ? > >To be honest, this is a little behind me now :-) > > &g

Re: [PATCH 3/5] tpm_tis_spi: Check correct byte for wait state indicator

ally it makes sense to squash #1 and #3 - but reviewing it merged with #1 is quite hard since it "obfuscates" the problem - since too much stuff moves around. That's why I decided to split it - for easier review. Peter > > >On 16/02/2017 08:08, Peter Huewe wrote: >>

Re: [PATCH 3/5] tpm_tis_spi: Check correct byte for wait state indicator

- but reviewing it merged with #1 is quite hard since it "obfuscates" the problem - since too much stuff moves around. That's why I decided to split it - for easier review. Peter > > >On 16/02/2017 08:08, Peter Huewe wrote: >> Wait states are signaled in the l

[PATCH 5/5] tpm_tis_spi: Add small delay after last transfer

for a negligible performance penalty. Cc: <sta...@vger.kernel.org> Fixes: 0edbfea537d1 ("tpm/tpm_tis_spi: Add support for spi phy") Signed-off-by: Alexander Steffen <alexander.stef...@infineon.com> Signed-off-by: Peter Huewe <peter.hu...@infineon.com> --- drivers/char/tpm

[PATCH 5/5] tpm_tis_spi: Add small delay after last transfer

for a negligible performance penalty. Cc: Fixes: 0edbfea537d1 ("tpm/tpm_tis_spi: Add support for spi phy") Signed-off-by: Alexander Steffen Signed-off-by: Peter Huewe --- drivers/char/tpm/tpm_tis_spi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/char/tpm/tpm_tis_spi.c b/driver

  1   2   3   4   5   6   7   8   >