sta...@vger.kernel.org>
[prerequisite for other fixes in this series]
Fixes: 0edbfea537d1 ("tpm/tpm_tis_spi: Add support for spi phy")
Signed-off-by: Alexander Steffen <alexander.stef...@infineon.com>
Signed-off-by: Peter Huewe <peter.hu...@infineon.com>
---
drivers
for other fixes in this series]
Fixes: 0edbfea537d1 ("tpm/tpm_tis_spi: Add support for spi phy")
Signed-off-by: Alexander Steffen
Signed-off-by: Peter Huewe
---
drivers/char/tpm/tpm_tis_spi.c | 87 --
1 file changed, 24 insertions(+), 63 deletions(-)
<alexander.stef...@infineon.com>
Signed-off-by: Peter Huewe <peter.hu...@infineon.com>
---
drivers/char/tpm/tpm_tis_spi.c | 40 +---
1 file changed, 21 insertions(+), 19 deletions(-)
diff --git a/drivers/char/tpm/tpm_tis_spi.c b/drivers/char/tpm/tpm_
Wait states are signaled in the last byte received from the TPM in
response to the header, not the first byte. Check rx_buf[3] instead of
rx_buf[0].
Cc:
Fixes: 0edbfea537d1 ("tpm/tpm_tis_spi: Add support for spi phy")
Signed-off-by: Alexander Steffen
Signed-off-by: Peter Huewe
--
function was consolidated to one
transfer function, so we do not have to apply the same fix at two locations.
Maybe consider squashing it - we splitted it for easier review.
Affected Kernels: 4.8, 4.9, 4.10
Patchset was tested on Raspberry Pi2 with SLB9670 (TPM1.2 and TPM2.0)
Peter Huewe (5
function was consolidated to one
transfer function, so we do not have to apply the same fix at two locations.
Maybe consider squashing it - we splitted it for easier review.
Affected Kernels: 4.8, 4.9, 4.10
Patchset was tested on Raspberry Pi2 with SLB9670 (TPM1.2 and TPM2.0)
Peter Huewe (5
hy")
Signed-off-by: Alexander Steffen <alexander.stef...@infineon.com>
Signed-off-by: Peter Huewe <peter.hu...@infineon.com>
---
drivers/char/tpm/tpm_tis_spi.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/char/tpm/tpm_tis_spi.c b/drivers/char/tpm/tpm_
Alexander Steffen
Signed-off-by: Peter Huewe
---
drivers/char/tpm/tpm_tis_spi.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/char/tpm/tpm_tis_spi.c b/drivers/char/tpm/tpm_tis_spi.c
index 6e1a3c43f621..d782b9974c14 100644
--- a/drivers/char/tpm/tpm_tis_spi.c
+++ b/driver
<alexander.stef...@infineon.com>
Signed-off-by: Peter Huewe <peter.hu...@infineon.com>
---
drivers/char/tpm/tpm_tis_spi.c | 108 ++---
1 file changed, 57 insertions(+), 51 deletions(-)
diff --git a/drivers/char/tpm/tpm_tis_spi.c b/drivers/char/tpm/tpm_
Limiting transfers to MAX_SPI_FRAMESIZE was not expected by the upper
layers, as tpm_tis has no such limitation. Add a loop to hide that
limitation.
Cc:
Fixes: 0edbfea537d1 ("tpm/tpm_tis_spi: Add support for spi phy")
Signed-off-by: Alexander Steffen
Signed-off-by: Peter Huewe
--
ot;)
Signed-off-by: Alexander Steffen <alexander.stef...@infineon.com>
Signed-off-by: Peter Huewe <peter.hu...@infineon.com>
---
drivers/char/tpm/tpm_tis_core.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/char/tpm/tpm_tis_core.c b/drivers/char/tpm/tpm_t
Signed-off-by: Peter Huewe
---
drivers/char/tpm/tpm_tis_core.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/char/tpm/tpm_tis_core.c b/drivers/char/tpm/tpm_tis_core.c
index c0f296b5d413..fc0e9a2734ed 100644
--- a/drivers/char/tpm/tpm_tis_core.c
+++ b/driver
Hi
Am 11. Oktober 2016 19:13:13 MESZ, schrieb Jason Gunthorpe
<jguntho...@obsidianresearch.com>:
>On Tue, Oct 11, 2016 at 03:01:01PM +0300, Jarkko Sakkinen wrote:
>> From: Peter Huewe <peterhu...@gmx.de>
>>
>> In some weird cases it might be possible that
Hi
Am 11. Oktober 2016 19:13:13 MESZ, schrieb Jason Gunthorpe
:
>On Tue, Oct 11, 2016 at 03:01:01PM +0300, Jarkko Sakkinen wrote:
>> From: Peter Huewe
>>
>> In some weird cases it might be possible that the TPM does not set
>> STS.VALID within the given time
Hi Andrey,
thanks for the update.
> This patchset adds support for H1 Secure Microcontroller running
> Cr50 firmware. It implements several functions, including TPM-like
> functionality, and communicates over SPI using the FIFO protocol
> described in the PTP Spec, section 6.
> H1 is a
Hi Andrey,
thanks for the update.
> This patchset adds support for H1 Secure Microcontroller running
> Cr50 firmware. It implements several functions, including TPM-like
> functionality, and communicates over SPI using the FIFO protocol
> described in the PTP Spec, section 6.
> H1 is a
Am 14. Juli 2016 19:20:16 GMT-07:00, schrieb Andrey Pronin
:
>This patchset adds a TCG TPM2.0 PTP FIFO compliant interface for
>Cr50 chip on SPI.
>
>Depends on the following patches by Andrey Pronin
>
>that add new members to phy_ops in tpm_tis_core:
Am 14. Juli 2016 19:20:16 GMT-07:00, schrieb Andrey Pronin
:
>This patchset adds a TCG TPM2.0 PTP FIFO compliant interface for
>Cr50 chip on SPI.
>
>Depends on the following patches by Andrey Pronin
>
>that add new members to phy_ops in tpm_tis_core:
> - tpm: support driver-specific sysfs attrs
Faster suspend/resume is always appreciated.
--
Sent from my mobile
Faster suspend/resume is always appreciated.
--
Sent from my mobile
Reviewed-by: Peter Huewe <peterhu...@gmx.de>
--
Sent from my mobile
Reviewed-by: Peter Huewe
--
Sent from my mobile
Am 2. Dezember 2015 00:14:23 PST, schrieb Jarkko Sakkinen
:
>On Tue, Dec 01, 2015 at 05:15:14PM -0800, Peter Huewe wrote:
>>
>>
>> Am 1. Dezember 2015 14:22:23 PST, schrieb Jason Gunthorpe
>:
>> >On Tue, Dec 01, 2015 at 11:33:51PM +0200, Jarkko Sakkinen
Am 2. Dezember 2015 00:14:23 PST, schrieb Jarkko Sakkinen
<jarkko.sakki...@linux.intel.com>:
>On Tue, Dec 01, 2015 at 05:15:14PM -0800, Peter Huewe wrote:
>>
>>
>> Am 1. Dezember 2015 14:22:23 PST, schrieb Jason Gunthorpe
><jguntho...@obsidianresearch.com>
Am 1. Dezember 2015 14:22:23 PST, schrieb Jason Gunthorpe
:
>On Tue, Dec 01, 2015 at 11:33:51PM +0200, Jarkko Sakkinen wrote:
>
>> I went through the patches and didn't see anything that would shock
>me
>> enough not to apply the patches in the current if they also work when
>> tested *but* are
> > >That fixes tpm_tis, but there are other ancient TPM drivers that use
> > >the old, now broken way.
> > >
> > >So, we still need to do something here. Either fixup b8b2c7d845d5 as
> > >you have proposed, remove the now broken obsolete TPM drivers, or try
> > >and fix them..
> >
> > How broken
Am 1. Dezember 2015 09:25:37 PST, schrieb Jason Gunthorpe
:
>On Tue, Dec 01, 2015 at 04:19:25PM +0100, Wilck, Martin wrote:
>> > > > tpm_tis_init calls tpmm_chip_alloc which barfs when pdev (i.e.
>the return value
>> > > > of platform_device_register_simple above) isn't bound. It is
>not
Am 1. Dezember 2015 14:22:23 PST, schrieb Jason Gunthorpe
:
>On Tue, Dec 01, 2015 at 11:33:51PM +0200, Jarkko Sakkinen wrote:
>
>> I went through the patches and didn't see anything that would shock
>me
>> enough not to apply the patches in the current if they
Am 1. Dezember 2015 09:25:37 PST, schrieb Jason Gunthorpe
:
>On Tue, Dec 01, 2015 at 04:19:25PM +0100, Wilck, Martin wrote:
>> > > > tpm_tis_init calls tpmm_chip_alloc which barfs when pdev (i.e.
>the return value
>> > > > of platform_device_register_simple
> > >That fixes tpm_tis, but there are other ancient TPM drivers that use
> > >the old, now broken way.
> > >
> > >So, we still need to do something here. Either fixup b8b2c7d845d5 as
> > >you have proposed, remove the now broken obsolete TPM drivers, or try
> > >and fix them..
> >
> > How broken
Hi,
is this for stable as well?
Since when?
I'll take care of all the patches next week when coming back to germany.
Peter
--
Sent from my mobile
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info
Hi,
is this for stable as well?
Since when?
I'll take care of all the patches next week when coming back to germany.
Peter
--
Sent from my mobile
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info
Will look at it as soon as possible - relocating to the us is quite
stressful.sorry about that.
But since we are already at v9 i think it is in a good shape.
Peter
Am 25. August 2015 19:03:27 MESZ, schrieb Jarkko Sakkinen
:
>Does this start be in the shape that there would be chance to pull
Will look at it as soon as possible - relocating to the us is quite
stressful.sorry about that.
But since we are already at v9 i think it is in a good shape.
Peter
Am 25. August 2015 19:03:27 MESZ, schrieb Jarkko Sakkinen
jarkko.sakki...@intel.com:
Does this start be in the shape that there
Am 10. August 2015 18:23:52 MESZ, schrieb Geert Uytterhoeven
:
>
>I'd like the individual subsystem maintainers to apply the respective
>patches. Sorry for being unclear.
Okay, thanks for the clarification.
I'll apply the TPM patch.
Peter
--
Sent from my mobile
--
To unsubscribe from this
Am 10. August 2015 18:23:52 MESZ, schrieb Geert Uytterhoeven
ge...@linux-m68k.org:
I'd like the individual subsystem maintainers to apply the respective
patches. Sorry for being unclear.
Okay, thanks for the clarification.
I'll apply the TPM patch.
Peter
--
Sent from my mobile
--
To
If DEBUG is set dumpVGAReg is called and tries to access
XGISR which is defined as (xgifb_info->dev_info.P3c4)
which is not known within this function.
-> add as parameter to dumpVGAReg so xgifb_info becomes known
Signed-off-by: Peter Huewe
---
drivers/staging/xgifb/XGI_main_26
If DEBUG is set dumpVGAReg is called and tries to access
XGISR which is defined as (xgifb_info-dev_info.P3c4)
which is not known within this function.
- add as parameter to dumpVGAReg so xgifb_info becomes known
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/xgifb/XGI_main_26
docproc.c was moved in 2011 from scripts/basic to scripts
-> updated the references accordingly
Signed-off-by: Peter Huewe
---
Documentation/kernel-doc-nano-HOWTO.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/kernel-doc-nano-HOWTO.txt
b/Documentat
docproc.c was moved in 2011 from scripts/basic to scripts
- updated the references accordingly
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
Documentation/kernel-doc-nano-HOWTO.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/kernel-doc-nano-HOWTO.txt
b
ned-off-by: Jarkko Sakkinen
Reviewed-by: Peter Huewe
Acked-by: Peter Huewe # for TPM subsystem
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-i
Am 9. Juni 2015 13:39:13 MESZ, schrieb Jarkko Sakkinen
:
>On Tue, Jun 09, 2015 at 12:32:57PM +0200, Peter Huewe wrote:
>>
>>
>> Hi
>>
>> >> > +static inline void tpm_buf_store(struct tpm_buf *buf,
>> >&g
Hi
>> > +static inline void tpm_buf_store(struct tpm_buf *buf,
>> > + unsigned int pos,
>> > + const unsigned char *data,
>> > + unsigned int len)
>> > +{
>> > + BUG_ON((pos + len) > TPM_BUF_SIZE);
>> > +
>> > +
Am 9. Juni 2015 13:39:13 MESZ, schrieb Jarkko Sakkinen
jarkko.sakki...@linux.intel.com:
On Tue, Jun 09, 2015 at 12:32:57PM +0200, Peter Huewe wrote:
Hi
+static inline void tpm_buf_store(struct tpm_buf *buf,
+unsigned int pos
Hi
+static inline void tpm_buf_store(struct tpm_buf *buf,
+ unsigned int pos,
+ const unsigned char *data,
+ unsigned int len)
+{
+ BUG_ON((pos + len) TPM_BUF_SIZE);
+
+ memcpy(buf-data[pos], data,
...@linux.intel.com
Reviewed-by: Peter Huewe peterhu...@gmx.de
Acked-by: Peter Huewe peterhu...@gmx.de # for TPM subsystem
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org
Hi
>Betreff: [PATCH] tpm, tpm_crb: migrate to struct acpi_table_tpm2 and
>acpi_tpm2_control
> Migrate to struct acpi_table_tpm2 and struct acpi_tpm2_control defined
> in include/acpi/actbl3.h from the internal structures.
I definitely do like the idea! Thanks for spotting this!
However one
Hi,
> Betreff: [PATCH] tpm: introduce struct tpm_buf
> This patch introduces struct tpm_buf that provides a string buffer for
> constructing TPM commands. This allows to construct variable sized TPM
> commands. This feature is needed for TPM 2.0 commands in order to allow
> policy authentication
Hi
Betreff: [PATCH] tpm, tpm_crb: migrate to struct acpi_table_tpm2 and
acpi_tpm2_control
Migrate to struct acpi_table_tpm2 and struct acpi_tpm2_control defined
in include/acpi/actbl3.h from the internal structures.
I definitely do like the idea! Thanks for spotting this!
However one small
Hi,
Betreff: [PATCH] tpm: introduce struct tpm_buf
This patch introduces struct tpm_buf that provides a string buffer for
constructing TPM commands. This allows to construct variable sized TPM
commands. This feature is needed for TPM 2.0 commands in order to allow
policy authentication and
Make the tpm_infineon driver define its PM callbacks through
a struct dev_pm_ops object rather than by using legacy PM hooks
in struct pnp_driver.
This allows the driver to use tpm_pm_suspend() as its suspend
callback directly, so we can remove the duplicated savestate code.
Signed-off-by: Peter
Removing some boilerplate by using module_pnp_driver instead of calling
register and unregister in the otherwise empty init/exit functions
Signed-off-by: Peter Huewe
---
drivers/ata/pata_isapnp.c | 14 +-
1 file changed, 1 insertion(+), 13 deletions(-)
diff --git a/drivers/ata
Removing some boilerplate by using module_pnp_driver instead of calling
register and unregister in the otherwise empty init/exit functions
Signed-off-by: Peter Huewe
---
drivers/media/rc/ene_ir.c | 13 +
drivers/media/rc/fintek-cir.c | 13 +
drivers/media/rc/ite
Removing some boilerplate by using module_pnp_driver instead of calling
register and unregister in the otherwise empty init/exit functions
Signed-off-by: Peter Huewe
---
drivers/net/sb1000.c | 15 +--
1 file changed, 1 insertion(+), 14 deletions(-)
diff --git a/drivers/net/sb1000.c
Removing some boilerplate by using module_pnp_driver instead of calling
register and unregister in the otherwise empty init/exit functions
Signed-off-by: Peter Huewe
---
drivers/tty/serial/8250/8250_fintek.c | 13 +
1 file changed, 1 insertion(+), 12 deletions(-)
diff --git
Removing some boilerplate by using module_pnp_driver instead of calling
register and unregister in the otherwise empty init/exit functions
Signed-off-by: Peter Huewe
---
drivers/platform/x86/apple-gmux.c | 14 +-
1 file changed, 1 insertion(+), 13 deletions(-)
diff --git a/drivers
Removing some boilerplate by using module_pnp_driver instead of calling
register and unregister in the otherwise empty init/exit functions
Signed-off-by: Peter Huewe
---
drivers/ide/ide-pnp.c | 14 +-
1 file changed, 1 insertion(+), 13 deletions(-)
diff --git a/drivers/ide/ide
a few lines of boilerplate code per PNP driver.
Based on work done by Lars-Peter Clausen for other
busses (i2c and spi) and Greg KH for PCI.
Cc: Lars-Peter Clausen
Cc: Greg Kroah-Hartman
Signed-off-by: Peter Huewe
---
include/linux/pnp.h | 12
1 file changed, 12 insertions(+)
diff
)
Peter Huewe (8):
pnp: Add helper macro for pnp_register_driver boilerplate
pnp: tpm/tpm_infineon: Use module_pnp_driver to register driver
pnp: ata/pata_isapnp: Use module_pnp_driver to register driver
pnp: ide/ide-pnp: Use module_pnp_driver to register driver
Removing some boilerplate by using module_pnp_driver instead of calling
register and unregister in the otherwise empty init/exit functions
Signed-off-by: Peter Huewe
---
drivers/char/tpm/tpm_infineon.c | 13 +
1 file changed, 1 insertion(+), 12 deletions(-)
diff --git a/drivers
Removing some boilerplate by using module_pnp_driver instead of calling
register and unregister in the otherwise empty init/exit functions
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/char/tpm/tpm_infineon.c | 13 +
1 file changed, 1 insertion(+), 12 deletions(-)
diff
a few lines of boilerplate code per PNP driver.
Based on work done by Lars-Peter Clausen l...@metafoo.de for other
busses (i2c and spi) and Greg KH for PCI.
Cc: Lars-Peter Clausen l...@metafoo.de
Cc: Greg Kroah-Hartman gre...@suse.de
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
include/linux
)
Peter Huewe (8):
pnp: Add helper macro for pnp_register_driver boilerplate
pnp: tpm/tpm_infineon: Use module_pnp_driver to register driver
pnp: ata/pata_isapnp: Use module_pnp_driver to register driver
pnp: ide/ide-pnp: Use module_pnp_driver to register driver
Make the tpm_infineon driver define its PM callbacks through
a struct dev_pm_ops object rather than by using legacy PM hooks
in struct pnp_driver.
This allows the driver to use tpm_pm_suspend() as its suspend
callback directly, so we can remove the duplicated savestate code.
Signed-off-by: Peter
Removing some boilerplate by using module_pnp_driver instead of calling
register and unregister in the otherwise empty init/exit functions
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/ide/ide-pnp.c | 14 +-
1 file changed, 1 insertion(+), 13 deletions(-)
diff --git
Removing some boilerplate by using module_pnp_driver instead of calling
register and unregister in the otherwise empty init/exit functions
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/tty/serial/8250/8250_fintek.c | 13 +
1 file changed, 1 insertion(+), 12 deletions
Removing some boilerplate by using module_pnp_driver instead of calling
register and unregister in the otherwise empty init/exit functions
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/platform/x86/apple-gmux.c | 14 +-
1 file changed, 1 insertion(+), 13 deletions(-)
diff
Removing some boilerplate by using module_pnp_driver instead of calling
register and unregister in the otherwise empty init/exit functions
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/net/sb1000.c | 15 +--
1 file changed, 1 insertion(+), 14 deletions(-)
diff --git
Removing some boilerplate by using module_pnp_driver instead of calling
register and unregister in the otherwise empty init/exit functions
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/media/rc/ene_ir.c | 13 +
drivers/media/rc/fintek-cir.c | 13
Removing some boilerplate by using module_pnp_driver instead of calling
register and unregister in the otherwise empty init/exit functions
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/ata/pata_isapnp.c | 14 +-
1 file changed, 1 insertion(+), 13 deletions(-)
diff --git
Jason does an excellent job reviewing the TPM stuff, so we add him to
the designated reviewer list (with his consent :)
Jason Gunthorpe
Signed-off-by: Peter Huewe
Signed-off-by: Peter Huewe
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index
I got a lot of requests lately about whether the new TPM2.0 support
includes the FIFO interface for TPM2.0 as well.
The FIFO interface is handled by tpm_tis since FIFO=TIS (more or less).
-> Update the helptext and headline
Signed-off-by: Peter Huewe
---
drivers/char/tpm/Kconfig
Jason does an excellent job reviewing the TPM stuff, so we add him to
the designated reviewer list (with his consent :)
Jason Gunthorpe jguntho...@obsidianresearch.com
Signed-off-by: Peter Huewe peterhu...@gmx.de
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
MAINTAINERS | 1 +
1 file changed
I got a lot of requests lately about whether the new TPM2.0 support
includes the FIFO interface for TPM2.0 as well.
The FIFO interface is handled by tpm_tis since FIFO=TIS (more or less).
- Update the helptext and headline
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/char/tpm/Kconfig
Thanks for reporting.
>drivers/char/tpm/tpm_tis.c: In function ‘tpm_tis_pnp_init’:
>drivers/char/tpm/tpm_tis.c:912:45: error: invalid type argument of
>‘->’ (have ‘int’)
>acpi_dev_handle = pnp_acpi_device(pnp_dev)->handle;
>^
>make[3]: *** [drivers/char/tpm/tpm_tis.o] Error 1
I'll look into
Thanks for reporting.
drivers/char/tpm/tpm_tis.c: In function ‘tpm_tis_pnp_init’:
drivers/char/tpm/tpm_tis.c:912:45: error: invalid type argument of
‘-’ (have ‘int’)
acpi_dev_handle = pnp_acpi_device(pnp_dev)-handle;
^
make[3]: *** [drivers/char/tpm/tpm_tis.o] Error 1
I'll look into it.
> So, what do you think? Are we now settled with this?
Meh...
It does not recognize my tpm20 with force=1 :( :( :(
Probably since I don't have a machine with bios integration -> no tpm startup,
and your startup is returned with RC_SIZE :(
rmmod tpm; modprobe tpm_tis force=1 ; dmesg
modprobe:
So, what do you think? Are we now settled with this?
Meh...
It does not recognize my tpm20 with force=1 :( :( :(
Probably since I don't have a machine with bios integration - no tpm startup,
and your startup is returned with RC_SIZE :(
rmmod tpm; modprobe tpm_tis force=1 ; dmesg
modprobe:
>
> > Am Donnerstag, 4. Dezember 2014, 06:55:18 schrieb Jarkko Sakkinen:
> > > From: Will Arthur
> > >
> > > Detect TPM 2.0 by using the extended STS (STS3) register. For TPM 2.0,
> > > instead of calling tpm_get_timeouts(), assign duration and timeout
> > > values defined in the TPM 2.0 PTP
Hi Jarkko,
>is it cool if I prepare a separate set of fixes for all issues
>in v9? I do not see any problem that could not be fixed without
>major structural changes.
to be honest - I would prefer a v10 with the fixes included, especially since
there were quite a few issues/remarks.
If
Hi Jarkko,
is it cool if I prepare a separate set of fixes for all issues
in v9? I do not see any problem that could not be fixed without
major structural changes.
to be honest - I would prefer a v10 with the fixes included, especially since
there were quite a few issues/remarks.
If you
Am Donnerstag, 4. Dezember 2014, 06:55:18 schrieb Jarkko Sakkinen:
From: Will Arthur will.c.art...@intel.com
Detect TPM 2.0 by using the extended STS (STS3) register. For TPM 2.0,
instead of calling tpm_get_timeouts(), assign duration and timeout
values defined in the TPM 2.0
Hi Jarkko,
> Jarkko Sakkinen (3):
> tpm: merge duplicate transmit_cmd() functions
> tpm: two-phase chip management functions
> tpm: fix multiple race conditions in tpm_ppi.c
the patchset introduces a sparse error:
CHECK /home/phuewe/linux-2.6-host/drivers/char/tpm/tpm_tis.c
Hi Jarkko,
Jarkko Sakkinen (3):
tpm: merge duplicate transmit_cmd() functions
tpm: two-phase chip management functions
tpm: fix multiple race conditions in tpm_ppi.c
the patchset introduces a sparse error:
CHECK /home/phuewe/linux-2.6-host/drivers/char/tpm/tpm_tis.c
Hi,
we got an official slot at Monday 5.30pm in Room 01 (http://sched.co/1D5VKBL) :)
Peter
Gesendet: Sonntag, 12. Oktober 2014 um 23:16 Uhr
Von: "Peter Huewe"
An: "Jarkko Sakkinen"
Cc: keyri...@linux-nfs.org, jarkko.sakkin...@linux.intel.com,
"ksummit-disc...@
Hi
> apologies for top-posting but which day/time/place is this going to be held?
I'd suggest that we either meet tomorrow (Monday) during the other BoF Sessions
@ 5:30pm or afterwards.
Does one of the attendees have a conflict with the BOFs or the VIP Reception?
Personally, I think it's most
Hi
apologies for top-posting but which day/time/place is this going to be held?
I'd suggest that we either meet tomorrow (Monday) during the other BoF Sessions
@ 5:30pm or afterwards.
Does one of the attendees have a conflict with the BOFs or the VIP Reception?
Personally, I think it's most
Hi,
we got an official slot at Monday 5.30pm in Room 01 (http://sched.co/1D5VKBL) :)
Peter
Gesendet: Sonntag, 12. Oktober 2014 um 23:16 Uhr
Von: Peter Huewe peterhu...@gmx.de
An: Jarkko Sakkinen jarkko.sakki...@linux.intel.com
Cc: keyri...@linux-nfs.org, jarkko.sakkin...@linux.intel.com
Hi,
I would like to 'invite' all interested parties in a short TPM minisummit where
we can discuss the following hot topics of the TPM subsystem over a beer or two:
- State of the TPM Subsystem
- De-/Initialization Mess
- Devm'ification
- Testing
- TPM 2.0 Support
- Dependencies /
Hi,
I would like to 'invite' all interested parties in a short TPM minisummit where
we can discuss the following hot topics of the TPM subsystem over a beer or two:
- State of the TPM Subsystem
- De-/Initialization Mess
- Devm'ification
- Testing
- TPM 2.0 Support
- Dependencies /
g ACPI_HANDLE.
Signed-off-by: Peter Huewe
---
drivers/i2c/i2c-acpi.c | 14 --
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/drivers/i2c/i2c-acpi.c b/drivers/i2c/i2c-acpi.c
index 0dbc18c..c456b17 100644
--- a/drivers/i2c/i2c-acpi.c
+++ b/drivers/i2c/i2c
-by: Peter Huewe peterhu...@gmx.de
---
drivers/i2c/i2c-acpi.c | 14 --
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/drivers/i2c/i2c-acpi.c b/drivers/i2c/i2c-acpi.c
index 0dbc18c..c456b17 100644
--- a/drivers/i2c/i2c-acpi.c
+++ b/drivers/i2c/i2c-acpi.c
@@ -308,10 +308,15
Unfortunately the tpm_tis driver did never call request_region for its
adress space - now since we've got devm_ioremap_resource we can simply
remove all the stuff and do everything in one call.
Cc:
Signed-off-by: Peter Huewe
---
drivers/char/tpm/tpm_tis.c | 10 --
1 file changed, 4
Unfortunately the tpm_tis driver did never call request_region for its
adress space - now since we've got devm_ioremap_resource we can simply
remove all the stuff and do everything in one call.
Cc: sta...@vger.kernel.org
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/char/tpm/tpm_tis.c
Hi Derek,
Is this a regression?
Do you know since when?
Thanks
Peter
---
Sent from my mobile.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please
Hi Derek,
Is this a regression?
Do you know since when?
Thanks
Peter
---
Sent from my mobile.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please
From: Peter Huewe
If
status = acpi_get_name(handle, ACPI_FULL_PATHNAME, );
fails for whatever reason and does not return AE_OK
if (strstr(buffer.pointer, context) != NULL) {
does dereference a null pointer.
-> Check the return value and return the status to the caller
Found by coverity
From: Jason Gunthorpe
This builds on the last commit to use the ops structure in the core
and reduce the size of tpm_vendor_specific.
Signed-off-by: Jason Gunthorpe
Reviewed-by: Joel Schopp
Reviewed-by: Ashley Lai
Signed-off-by: Peter Huewe
---
drivers/char/tpm/tpm-interface.c| 34
From: Peter Huewe
smatch complains:
drivers/char/tpm/tpm_ibmvtpm.c:510
ibmvtpm_crq_process() info: ignoring unreachable code.
-> The return is not necessary here, remove it
Signed-off-by: Peter Huewe
---
drivers/char/tpm/tpm_ibmvtpm.c | 1 -
1 file changed, 1 deletion(-)
diff --
legacy pm_ops'
Also, unpon reviewing, the #ifdefs around tpm_tis_pm are not right, the first
reference is protected, the second is not. tpm_tis_pm is always defined so we
can drop the #ifdef.
Signed-off-by: Jason Gunthorpe
Signed-off-by: Peter Huewe
---
drivers/char/tpm/tpm_tis.c | 6 +-
1
101 - 200 of 702 matches
Mail list logo