variables UCharData and RegisterContent in
WriteBBPortUchar as they are not used / without effect.
Both functions are only 'local' so we can mark them as static.
Signed-off-by: Peter Huewe
---
drivers/staging/rtl8187se/r8185b_init.c | 30 +++---
1 files changed, 7
These two functions PlatformIORead2Byte and PlatformIORead4Byte are
unused and thus can be removed.
Signed-off-by: Peter Huewe
---
drivers/staging/rtl8187se/r8185b_init.c | 20
1 files changed, 0 insertions(+), 20 deletions(-)
diff --git a/drivers/staging/rtl8187se
In SetAntennaConfig87SE both branches of if (bAntDiversity) do exactly
the same, except that there is an offset of 0x80 for the register values
if bAntDiversity is true.
-> Consolidate both branches and assign the offset if necessary.
Signed-off-by: Peter Huewe
---
drivers/staging/rtl818
to
read_nic_byte but is kept for readability.
Since this functions is local only we can mark it as static.
Signed-off-by: Peter Huewe
---
drivers/staging/rtl8187se/r8185b_init.c | 17 +
1 files changed, 5 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8187se
The local variable u4bAcParam is never read/used after assignment,
thus we can remove the declaration, assignment and any related code.
-> the local variables u1bAIFS, eACI and pAcParam can also be removed.
Signed-off-by: Peter Huewe
---
drivers/staging/rtl8187se/r8185b_init.c |
The local variables priv and ieee are not used and thus can be removed.
The local variable u1bAIFS is not used/read after assignment and thus
can be removed.
Signed-off-by: Peter Huewe
---
drivers/staging/rtl8187se/r8185b_init.c |5 -
1 files changed, 0 insertions(+), 5 deletions
The local variable AcParam is only assigned to but not read/used
afterwards, thus it and all related code can be removed.
The bFollowLegacySetting variable and check can also be removed as it is
always true.
Signed-off-by: Peter Huewe
---
drivers/staging/rtl8187se/r8185b_init.c | 35
Local variable AcmCtrl is never read/used after assignment so we can remove
all assignments to it and the related code around the assignments.
Signed-off-by: Peter Huewe
---
drivers/staging/rtl8187se/r8185b_init.c | 49 +--
1 files changed, 1 insertions(+), 48
The local variable AcParam is only assigned to but not read/used
afterwards, thus it and all related code can be removed.
The bFollowLegacySetting variable and check can also be removed as it is
always true.
Signed-off-by: Peter Huewe
---
drivers/staging/rtl8187se/r8185b_init.c | 35
The local variables priv and ieee are not used and thus can be removed.
The local variable u1bAIFS is not used/read after assignment and thus
can be removed.
Signed-off-by: Peter Huewe
---
drivers/staging/rtl8187se/r8185b_init.c |5 -
1 files changed, 0 insertions(+), 5 deletions
The local variable u4bAcParam is never read/used after assignment,
thus we can remove the declaration, assignment and any related code.
-> the local variables u1bAIFS, eACI and pAcParam can also be removed.
Signed-off-by: Peter Huewe
---
drivers/staging/rtl8187se/r8185b_init.c |
to
read_nic_byte but is kept for readability.
Since this functions is local only we can mark it as static.
Signed-off-by: Peter Huewe
---
drivers/staging/rtl8187se/r8185b_init.c | 17 +
1 files changed, 5 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8187se
' was not declared. Should it be
static?
-> Add the static keyword.
Signed-off-by: Peter Huewe
---
drivers/staging/rtl8187se/r8185b_init.c | 34 +++---
1 files changed, 17 insertions(+), 17 deletions(-)
diff --git a/drivers/staging/rtl8187se/r8185b_init.c
b/driv
variables UCharData and RegisterContent in
WriteBBPortUchar as they are not used / without effect.
Both functions are only 'local' so we can mark them as static.
Signed-off-by: Peter Huewe
---
drivers/staging/rtl8187se/r8185b_init.c | 30 +++---
1 files changed, 7
These two functions PlatformIORead2Byte and PlatformIORead4Byte are
unused and thus can be removed.
Signed-off-by: Peter Huewe
---
drivers/staging/rtl8187se/r8185b_init.c | 20
1 files changed, 0 insertions(+), 20 deletions(-)
diff --git a/drivers/staging/rtl8187se
Local variable AcmCtrl is never read/used after assignment so we can remove
all assignments to it and the related code around the assignments.
Signed-off-by: Peter Huewe
---
drivers/staging/rtl8187se/r8185b_init.c | 49 +--
1 files changed, 1 insertions(+), 48
In SetAntennaConfig87SE both branches of if (bAntDiversity) do exactly
the same, except that there is an offset of 0x80 for the register values
if bAntDiversity is true.
-> Consolidate both branches and assign the offset if necessary.
Signed-off-by: Peter Huewe
---
drivers/staging/rtl818
Local variable AcmCtrl is never read/used after assignment so we can remove
all assignments to it and the related code around the assignments.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/rtl8187se/r8185b_init.c | 49 +--
1 files changed, 1
In SetAntennaConfig87SE both branches of if (bAntDiversity) do exactly
the same, except that there is an offset of 0x80 for the register values
if bAntDiversity is true.
- Consolidate both branches and assign the offset if necessary.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers
variables UCharData and RegisterContent in
WriteBBPortUchar as they are not used / without effect.
Both functions are only 'local' so we can mark them as static.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/rtl8187se/r8185b_init.c | 30 +++---
1 files
These two functions PlatformIORead2Byte and PlatformIORead4Byte are
unused and thus can be removed.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/rtl8187se/r8185b_init.c | 20
1 files changed, 0 insertions(+), 20 deletions(-)
diff --git a/drivers
' was not declared. Should it be
static?
- Add the static keyword.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/rtl8187se/r8185b_init.c | 34 +++---
1 files changed, 17 insertions(+), 17 deletions(-)
diff --git a/drivers/staging/rtl8187se/r8185b_init.c
to
read_nic_byte but is kept for readability.
Since this functions is local only we can mark it as static.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/rtl8187se/r8185b_init.c | 17 +
1 files changed, 5 insertions(+), 12 deletions(-)
diff --git a/drivers/staging
The local variable u4bAcParam is never read/used after assignment,
thus we can remove the declaration, assignment and any related code.
- the local variables u1bAIFS, eACI and pAcParam can also be removed.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/rtl8187se/r8185b_init.c
The local variable AcParam is only assigned to but not read/used
afterwards, thus it and all related code can be removed.
The bFollowLegacySetting variable and check can also be removed as it is
always true.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/rtl8187se
The local variables priv and ieee are not used and thus can be removed.
The local variable u1bAIFS is not used/read after assignment and thus
can be removed.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/rtl8187se/r8185b_init.c |5 -
1 files changed, 0 insertions(+), 5
Local variable AcmCtrl is never read/used after assignment so we can remove
all assignments to it and the related code around the assignments.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/rtl8187se/r8185b_init.c | 49 +--
1 files changed, 1
The local variable AcParam is only assigned to but not read/used
afterwards, thus it and all related code can be removed.
The bFollowLegacySetting variable and check can also be removed as it is
always true.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/rtl8187se
The local variables priv and ieee are not used and thus can be removed.
The local variable u1bAIFS is not used/read after assignment and thus
can be removed.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/rtl8187se/r8185b_init.c |5 -
1 files changed, 0 insertions(+), 5
The local variable u4bAcParam is never read/used after assignment,
thus we can remove the declaration, assignment and any related code.
- the local variables u1bAIFS, eACI and pAcParam can also be removed.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/rtl8187se/r8185b_init.c
to
read_nic_byte but is kept for readability.
Since this functions is local only we can mark it as static.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/rtl8187se/r8185b_init.c | 17 +
1 files changed, 5 insertions(+), 12 deletions(-)
diff --git a/drivers/staging
These two functions PlatformIORead2Byte and PlatformIORead4Byte are
unused and thus can be removed.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/rtl8187se/r8185b_init.c | 20
1 files changed, 0 insertions(+), 20 deletions(-)
diff --git a/drivers
In SetAntennaConfig87SE both branches of if (bAntDiversity) do exactly
the same, except that there is an offset of 0x80 for the register values
if bAntDiversity is true.
- Consolidate both branches and assign the offset if necessary.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers
variables UCharData and RegisterContent in
WriteBBPortUchar as they are not used / without effect.
Both functions are only 'local' so we can mark them as static.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/rtl8187se/r8185b_init.c | 30 +++---
1 files
' was not declared. Should it be
static?
- Add the static keyword.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/rtl8187se/r8185b_init.c | 34 +++---
1 files changed, 17 insertions(+), 17 deletions(-)
diff --git a/drivers/staging/rtl8187se/r8185b_init.c
VMK8061_MODEL and
VMK8055_MODEL it's safe to assume that VMK8055_DO_REG was meant as an
initial value.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/comedi/drivers/vmk80xx.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/staging/comedi/drivers/vmk80xx.c
b
e tree.
tpm_i2c_infineon is also retained as a compatible id as a fallback to
slb9635 protocol.
The driver was tested on Beaglebone.
Signed-off-by: Peter Huewe
---
Patch against Kent's tpmdd-02-05-13 branch
You might get an out-of-office reply, but I'm monitoring this email address
nevertheless
retained as a compatible id as a fallback to
slb9635 protocol.
The driver was tested on Beaglebone.
Signed-off-by: Peter Huewe peter.hu...@infineon.com
---
Patch against Kent's tpmdd-02-05-13 branch
You might get an out-of-office reply, but I'm monitoring this email address
nevertheless.
Thanks, Peter
':
goldfish_nand.c:239:2:
warning: format '%x' expects argument of type 'unsigned int', but
argument 3 has type 'size_t' [-Wformat]
-> As defined in the printk-formats use %zx for size_t variables
Signed-off-by: Peter Huewe
---
drivers/staging/goldfish/goldfish_nand.c |8
1 fi
':
goldfish_nand.c:(.text+0x6e8ba2): undefined reference to
`mtd_erase_callback'
drivers/built-in.o: In function `goldfish_nand_init_device':
goldfish_nand.c:(.text+0x6e8eba): undefined reference to
`mtd_device_parse_register'
Reported-by: Randy Dunlap
Signed-off-by: Peter Huewe
---
@Randy: The contact info
':
goldfish_nand.c:(.text+0x6e8ba2): undefined reference to
`mtd_erase_callback'
drivers/built-in.o: In function `goldfish_nand_init_device':
goldfish_nand.c:(.text+0x6e8eba): undefined reference to
`mtd_device_parse_register'
Reported-by: Randy Dunlap rdun...@infradead.org
Signed-off-by: Peter Huewe peterhu
':
goldfish_nand.c:239:2:
warning: format '%x' expects argument of type 'unsigned int', but
argument 3 has type 'size_t' [-Wformat]
- As defined in the printk-formats use %zx for size_t variables
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/goldfish/goldfish_nand.c |8
ted-by: Fengguang Wu
Signed-off-by: Peter Huewe
---
drivers/staging/vt6656/card.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/vt6656/card.c b/drivers/staging/vt6656/card.c
index 7d725bb..f988f07 100644
--- a/drivers/staging/vt6656/card.c
+++ b/driv
e 0, 1 or 2
-> only the first three values are used.
-> remove the remeining entries.
Signed-off-by: Peter Huewe
---
drivers/staging/xgifb/vb_table.h |5 -
1 files changed, 0 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/xgifb/vb_table.h b/drivers/staging/xgifb/vb_t
MCLKData does not contain any 0x1C value for its field SR28 nor does
XGI340_ECLKData contain any 0x1C or 0x22 value for its field SR2E.
-> the statement always evaluates to false.
-> remove
Signed-off-by: Peter Huewe
---
drivers/staging/xgifb/vb_init.c | 16
1 files c
pVBInfo->ram_type is assigned the return value of
XGINew_GetXG20DRAMType which can only be 0, 1 or 2
-> The conditional assignment is not needed here as it always evaluates
to true.
-> remove
Signed-off-by: Peter Huewe
---
drivers/staging/xgifb/vb_init.c |2 +-
1 files c
urn value of
XGINew_GetXG20DRAMType which can only be 0, 1 or 2
- pVBInfo->MCLKData is assigned to either XGI340New_MCLKData or
XGI27New_MCLKData in vb_setmode.c
-> only the first three values are used, the rest can be removed.
Signed-off-by: Peter Huewe
---
drivers/staging/xgifb/vb_table.h | 10 --
urn value of
XGINew_GetXG20DRAMType which can only be 0, 1 or 2
- pVBInfo->SR15 is assigned to either XG27_SR13 or XGI340_SR13 in
vb_setmode.c
-> only the first three values are used.
This becomes also evident as values 3-7 are all 0.
Signed-off-by: Peter Huewe
---
drivers/staging/xgifb/vb_struct.h |
urn value of
XGINew_GetXG20DRAMType which can only be 0, 1 or 2
- pVBInfo->CR40 is assigned to either XGI340_cr41 or XGI27_cr41 in
vb_setmode.c
-> only the first three values are used.
This becomes also evident as values 3-7 are all 0.
Signed-off-by: Peter Huewe
---
drivers/staging/xgifb/vb_struct.h |
’
[-Wunused-variable]
This patch fixes this
Signed-off-by: Peter Huewe
---
Sorry that I missed that one in the patch series.
drivers/staging/xgifb/vb_init.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/xgifb/vb_init.c b/drivers/staging/xgifb/vb_init.c
index
’
[-Wunused-variable]
This patch fixes this
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
Sorry that I missed that one in the patch series.
drivers/staging/xgifb/vb_init.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/xgifb/vb_init.c b/drivers/staging/xgifb
of
XGINew_GetXG20DRAMType which can only be 0, 1 or 2
- pVBInfo-CR40 is assigned to either XGI340_cr41 or XGI27_cr41 in
vb_setmode.c
- only the first three values are used.
This becomes also evident as values 3-7 are all 0.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/xgifb/vb_struct.h |2
of
XGINew_GetXG20DRAMType which can only be 0, 1 or 2
- pVBInfo-SR15 is assigned to either XG27_SR13 or XGI340_SR13 in
vb_setmode.c
- only the first three values are used.
This becomes also evident as values 3-7 are all 0.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/xgifb/vb_struct.h |2
which can only be 0, 1 or 2
- pVBInfo-MCLKData is assigned to either XGI340New_MCLKData or
XGI27New_MCLKData in vb_setmode.c
- only the first three values are used, the rest can be removed.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/xgifb/vb_table.h | 10 --
1
pVBInfo-ram_type is assigned the return value of
XGINew_GetXG20DRAMType which can only be 0, 1 or 2
- The conditional assignment is not needed here as it always evaluates
to true.
- remove
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/xgifb/vb_init.c |2 +-
1 files
MCLKData does not contain any 0x1C value for its field SR28 nor does
XGI340_ECLKData contain any 0x1C or 0x22 value for its field SR2E.
- the statement always evaluates to false.
- remove
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/xgifb/vb_init.c | 16
1
or 2
- only the first three values are used.
- remove the remeining entries.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/xgifb/vb_table.h |5 -
1 files changed, 0 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/xgifb/vb_table.h b/drivers/staging/xgifb
-by: Fengguang Wu fengguang...@intel.com
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/vt6656/card.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/vt6656/card.c b/drivers/staging/vt6656/card.c
index 7d725bb..f988f07 100644
--- a/drivers
are unnecessary.
-> we can safely remove them.
Tested-by: Aaro Koskinen
Signed-off-by: Peter Huewe
---
drivers/staging/xgifb/vb_init.c | 19 ++-
1 files changed, 6 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/xgifb/vb_init.c b/drivers/staging/xgifb/vb_init.c
in
Since XGI_LCDDesStruct is fully contained in XGI330_LCDDataDesStruct2
and the offsets for the first members is identical we can consolidate
the if/else branches here and use XGI330_LCDDataDesStruct2 for
everything.
Signed-off-by: Peter Huewe
---
drivers/staging/xgifb/vb_setmode.c | 31
Signed-off-by: Peter Huewe
---
drivers/staging/xgifb/vb_setmode.c | 13 ++---
1 files changed, 2 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/xgifb/vb_setmode.c
b/drivers/staging/xgifb/vb_setmode.c
index 131a267..bd81656 100644
--- a/drivers/staging/xgifb/vb_setmode.c
+++ b/drive
XGINew_SetDRAMDefaultRegister340 uses the same code fragment 4 times
with only a slight variation each time.
-> Move this code to a helper function - this saves some lines and
~450bytes in the .o / .ko
Tested-by: Aaro Koskinen
Signed-off-by: Peter Huewe
---
drivers/staging/xgifb/vb_ini
ine
we can simply replace the whole lookup table with a simple if/else assignment.
Tested-by: Aaro Koskinen
Signed-off-by: Peter Huewe
---
drivers/staging/xgifb/vb_init.c |2 +-
drivers/staging/xgifb/vb_table.h | 11 ---
2 files changed, 1 insertions(+), 12 deletions(-)
diff --
can simply replace the whole lookup table with a simple if/else assignment.
Tested-by: Aaro Koskinen aaro.koski...@iki.fi
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/xgifb/vb_init.c |2 +-
drivers/staging/xgifb/vb_table.h | 11 ---
2 files changed, 1 insertions
XGINew_SetDRAMDefaultRegister340 uses the same code fragment 4 times
with only a slight variation each time.
- Move this code to a helper function - this saves some lines and
~450bytes in the .o / .ko
Tested-by: Aaro Koskinen aaro.koski...@iki.fi
Signed-off-by: Peter Huewe peterhu...@gmx.de
1) The same condition (pVBInfo-IF_DEF_LVDS == 0) was checked in the if
clause directly in front of this one.
2) The same condition pVBInfo-VBType (VB_SIS301B | VB_SIS302B |
VB_SIS301LV | VB_SIS302LV | VB_XGI301C) was checked in the if
clause directly in front of this one.
Signed-off-by: Peter
Since XGI_LCDDesStruct is fully contained in XGI330_LCDDataDesStruct2
and the offsets for the first members is identical we can consolidate
the if/else branches here and use XGI330_LCDDataDesStruct2 for
everything.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/xgifb
are unnecessary.
- we can safely remove them.
Tested-by: Aaro Koskinen aaro.koski...@iki.fi
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/xgifb/vb_init.c | 19 ++-
1 files changed, 6 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/xgifb/vb_init.c b
-of-bounds access I changed the mask from 0x0F
to 0x07 and added a dummy value.
Signed-off-by: Peter Huewe
---
Please apply this series after my previous one
[PATCH 1/6] staging/xgifb: Remove unused variables and dead assignments
[PATCH 2/6] staging/xgifb: Remove unused variable
[PATCH 3/6] staging
Since data can only be 0x, 0x0035 or 0x0048 we can simply skip the
bit shifting and masking as data & 0xFF is always equal to data and
data & 0xFF00 is always 0.
So we simply use data and 0 directly and save the assignment.
Signed-off-by: Peter Huewe
---
drivers/staging/xgifb/vb_s
patch initializes the variable in this case.
Signed-off-by: Peter Huewe
---
drivers/staging/xgifb/XGI_main_26.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/staging/xgifb/XGI_main_26.c
b/drivers/staging/xgifb/XGI_main_26.c
index fa351f9..106abc8 100644
--- a/drivers/s
the
assignment to SR1 into the loop, which I prefer to start at 0.
Signed-off-by: Peter Huewe
---
drivers/staging/xgifb/vb_setmode.c | 23 ++-
drivers/staging/xgifb/vb_table.h |2 +-
2 files changed, 7 insertions(+), 18 deletions(-)
diff --git a/drivers/staging/xgifb
This patch simplifies the code of XGISetModeNew by reordering the
if/else if/case conditions when both branches are doing exactly the
same.
Signed-off-by: Peter Huewe
---
drivers/staging/xgifb/vb_setmode.c | 18 +++---
1 files changed, 3 insertions(+), 15 deletions(-)
diff --git
Instead of subtracting one and then assign a different name and add 1
again we simply use HDE directly. HDE wasn't used directly before, so no
change in functionality.
Same applies to VDE.
-> now we can remove the variable with the very descriptive name E ;)
Signed-off-by: Peter Hu
These two functions share the same code except one line - thus we can
simply merge them and add a parameter to switch between both variants.
Signed-off-by: Peter Huewe
---
drivers/staging/xgifb/vb_setmode.c | 48 +--
1 files changed, 13 insertions(+), 35
The mttr field must be declared as signed int (as in every other fb
driver) for the mttr functions to work properly.
Moreover the value should be initialized with -1.
Signed-off-by: Peter Huewe
---
drivers/staging/xgifb/XGI_main_26.c |2 +-
drivers/staging/xgifb/XGIfb.h |2 +-
2
We don't need to use this switch-case here for a simple two case
if-else.
Signed-off-by: Peter Huewe
---
drivers/staging/xgifb/XGI_main_26.c | 16 ++--
1 files changed, 2 insertions(+), 14 deletions(-)
diff --git a/drivers/staging/xgifb/XGI_main_26.c
b/drivers/staging/xgifb
This patch removes some comparisons that always evaluate to false since
xoffset and yoffset are defined as __u32 in fb_var_screeninfo in
include/linux/fb.h and thus can never be negative.
Signed-off-by: Peter Huewe
---
drivers/staging/xgifb/XGI_main_26.c |9 +
1 files changed, 1
This patch removes some comparisons that always evaluate to false since
xoffset and yoffset are defined as __u32 in fb_var_screeninfo in
include/linux/fb.h and thus can never be negative.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/xgifb/XGI_main_26.c |9 +
1
The mttr field must be declared as signed int (as in every other fb
driver) for the mttr functions to work properly.
Moreover the value should be initialized with -1.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/xgifb/XGI_main_26.c |2 +-
drivers/staging/xgifb/XGIfb.h
We don't need to use this switch-case here for a simple two case
if-else.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/xgifb/XGI_main_26.c | 16 ++--
1 files changed, 2 insertions(+), 14 deletions(-)
diff --git a/drivers/staging/xgifb/XGI_main_26.c
b/drivers
Instead of subtracting one and then assign a different name and add 1
again we simply use HDE directly. HDE wasn't used directly before, so no
change in functionality.
Same applies to VDE.
- now we can remove the variable with the very descriptive name E ;)
Signed-off-by: Peter Huewe peterhu
These two functions share the same code except one line - thus we can
simply merge them and add a parameter to switch between both variants.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/xgifb/vb_setmode.c | 48 +--
1 files changed, 13
the
assignment to SR1 into the loop, which I prefer to start at 0.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/xgifb/vb_setmode.c | 23 ++-
drivers/staging/xgifb/vb_table.h |2 +-
2 files changed, 7 insertions(+), 18 deletions(-)
diff --git a/drivers/staging
This patch simplifies the code of XGISetModeNew by reordering the
if/else if/case conditions when both branches are doing exactly the
same.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/xgifb/vb_setmode.c | 18 +++---
1 files changed, 3 insertions(+), 15
Since data can only be 0x, 0x0035 or 0x0048 we can simply skip the
bit shifting and masking as data 0xFF is always equal to data and
data 0xFF00 is always 0.
So we simply use data and 0 directly and save the assignment.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/xgifb
the variable in this case.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/xgifb/XGI_main_26.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/staging/xgifb/XGI_main_26.c
b/drivers/staging/xgifb/XGI_main_26.c
index fa351f9..106abc8 100644
-of-bounds access I changed the mask from 0x0F
to 0x07 and added a dummy value.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
Please apply this series after my previous one
[PATCH 1/6] staging/xgifb: Remove unused variables and dead assignments
[PATCH 2/6] staging/xgifb: Remove unused variable
The code checks twice for if (pVBInfo->VBInfo & SetCRT2ToTV) without any
changes in between -> we can remove the second check.
And while at it we can also save the temp variable and use tempbx
directly.
Signed-off-by: Peter Huewe
---
drivers/staging/xgifb/vb_setmod
Pindex and Pdata are unused -> remove
tempbx is unused -> remove
Signed-off-by: Peter Huewe
---
drivers/staging/xgifb/vb_setmode.c |7 +--
1 files changed, 1 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/xgifb/vb_setmode.c
b/drivers/staging/xgifb/vb_setmode.c
Index is not used here -> remove.
Signed-off-by: Peter Huewe
---
drivers/staging/xgifb/vb_setmode.c |4
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/xgifb/vb_setmode.c
b/drivers/staging/xgifb/vb_setmode.c
index 53b5557..a7fb52f 100644
--- a/driv
sed before
the next assignment -> remove the dead assignment.
Signed-off-by: Peter Huewe
---
drivers/staging/xgifb/vb_setmode.c | 46
1 files changed, 10 insertions(+), 36 deletions(-)
diff --git a/drivers/staging/xgifb/vb_setmode.c
b/drivers/staging/
XGI_P3cc is unused and the assignment without side effects -> remove;
Data can be simply replaced by the Temp variable, which was changed to
temp in order to make checkpatch happy.
Signed-off-by: Peter Huewe
---
drivers/staging/xgifb/vb_setmode.c | 19 ---
1 files changed
ferent
assignment a few lines later.
Signed-off-by: Peter Huewe
---
drivers/staging/xgifb/XGI_main_26.c | 35 +++
1 files changed, 3 insertions(+), 32 deletions(-)
diff --git a/drivers/staging/xgifb/XGI_main_26.c
b/drivers/staging/xgifb/XGI_main_26.c
index 68a216f..c
/devm_request_and_ioremap.cocci.
Signed-off-by: Peter Huewe
---
drivers/i2c/busses/i2c-mxs.c |7 +--
1 files changed, 1 insertions(+), 6 deletions(-)
diff --git a/drivers/i2c/busses/i2c-mxs.c b/drivers/i2c/busses/i2c-mxs.c
index d6abaf2..4ca92b6 100644
--- a/drivers/i2c/busses/i2c-mxs.c
+++ b/drivers/i2c/busses
/devm_request_and_ioremap.cocci.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/i2c/busses/i2c-mxs.c |7 +--
1 files changed, 1 insertions(+), 6 deletions(-)
diff --git a/drivers/i2c/busses/i2c-mxs.c b/drivers/i2c/busses/i2c-mxs.c
index d6abaf2..4ca92b6 100644
--- a/drivers/i2c/busses/i2c-mxs.c
+++ b
assignment a few lines later.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/xgifb/XGI_main_26.c | 35 +++
1 files changed, 3 insertions(+), 32 deletions(-)
diff --git a/drivers/staging/xgifb/XGI_main_26.c
b/drivers/staging/xgifb/XGI_main_26.c
index
assignment - remove the dead assignment.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/xgifb/vb_setmode.c | 46
1 files changed, 10 insertions(+), 36 deletions(-)
diff --git a/drivers/staging/xgifb/vb_setmode.c
b/drivers/staging/xgifb
XGI_P3cc is unused and the assignment without side effects - remove;
Data can be simply replaced by the Temp variable, which was changed to
temp in order to make checkpatch happy.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/xgifb/vb_setmode.c | 19 ---
1
Index is not used here - remove.
Signed-off-by: Peter Huewe peterhu...@gmx.de
---
drivers/staging/xgifb/vb_setmode.c |4
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/xgifb/vb_setmode.c
b/drivers/staging/xgifb/vb_setmode.c
index 53b5557..a7fb52f 100644
501 - 600 of 702 matches
Mail list logo
